[GitHub] incubator-taverna-mobile pull request #72: Fix: Latest Announcements show fi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-taverna-mobile/pull/72


---

[GitHub] incubator-taverna-mobile pull request #72: Fix: Latest Announcements show fi...

[sagar15795]

Github user sagar15795 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/72#discussion_r184889154
  
--- Diff: 
app/src/test/java/org/apache/taverna/mobile/AnnouncementPresenterTest.java ---
@@ -45,6 +49,9 @@ public void setUp() {
 announcements = FakeRemoteDataSource.getAnnouncements();
 announcement = FakeRemoteDataSource.getAnnouncement();
 
+option = new HashMap<>();
+option.put("order", "reverse");
+option.put("page", "pageNumber");
--- End diff --

I think you have to put value in place of pageNumber string


---

[GitHub] incubator-taverna-mobile pull request #72: Fix: Latest Announcements show fi...

[sagar15795]

Github user sagar15795 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/72#discussion_r184889150
  
--- Diff: 
app/src/main/java/org/apache/taverna/mobile/ui/anouncements/AnnouncementPresenter.java
 ---
@@ -110,4 +115,12 @@ public void onComplete() {
 }));
 }
 
+
+private Map getAnnouncementQueryOptions() {
+Map option = new HashMap<>();
+option.put("order", "reverse");
+option.put("page", "pageNumber");
--- End diff --

I think you have to put value in place of `pageNumber` string 


---

[GitHub] incubator-taverna-mobile pull request #72: Fix: Latest Announcements show fi...

[sagar15795]

Github user sagar15795 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/72#discussion_r180856614
  
--- Diff: 
app/src/main/java/org/apache/taverna/mobile/ui/anouncements/AnnouncementPresenter.java
 ---
@@ -110,4 +115,11 @@ public void onComplete() {
 }));
 }
 
+
+private Map getAnnouncementQueryOptions() {
+Map option = new HashMap<>();
+option.put("order", "reverse");
--- End diff --

add pageNumber query here.


---

[GitHub] incubator-taverna-mobile pull request #72: Fix: Latest Announcements show fi...

[sagar15795]

Github user sagar15795 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/72#discussion_r180856467
  
--- Diff: 
app/src/main/java/org/apache/taverna/mobile/data/remote/TavernaService.java ---
@@ -41,7 +41,8 @@
 public interface TavernaService {
 
 @GET(APIEndPoint.ALL_ANNOUNCEMENT)
-Observable getAllAnnouncements(@Query("page") int 
pageNumber);
+Observable getAllAnnouncements(@Query("page") int 
pageNumber,
--- End diff --

If we move it into `@QueryMap ` then it will be better 


---