[GitHub] incubator-taverna-mobile pull request #73: Fix: Improvements in UsageActivit...

[Hiteshgautam01]

GitHub user Hiteshgautam01 opened a pull request:

https://github.com/apache/incubator-taverna-mobile/pull/73

Fix: Improvements in UsageActivity UI for different screens

Please make sure these boxes are checked before submitting your pull 
request - thanks!

- [ ] Apply the `AndroidStyle.xml` style template to your code in Android 
Studio.

- [ ] Run the checks with `./gradlew check` to make sure you didn't break 
anything

- [ ] If you have multiple commits please combine them into one commit by 
squashing them.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Hiteshgautam01/incubator-taverna-mobile 
Icons_updates

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-taverna-mobile/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #73


commit bca9ec7242f76ab2541656d7b10341dbda2f9a51
Author: Hitesh Gautam 
Date:   2018-04-28T15:41:47Z

Fix: Improvements in UsageActivity UI for different screens




---

[GitHub] incubator-taverna-mobile pull request #73: Fix: Improvements in UsageActivit...

[sagar15795]

Github user sagar15795 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/73#discussion_r18953
  
--- Diff: app/src/main/res/layout/activity_usage.xml ---
@@ -33,16 +33,19 @@
 
+android:orientation="vertical">
 
 
+android:layout_height="wrap_content"
+android:paddingBottom="@dimen/usageCardViewPaddingBotton"
--- End diff --

change this also to `lowercase_underscore` conventions.


---

[GitHub] incubator-taverna-mobile pull request #73: Fix: Improvements in UsageActivit...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-taverna-mobile/pull/73


---