Re: [apache/incubator-teaclave-sgx-sdk] Are git tags being mutated? (#303)

2021-03-25 Thread Adam Szkoda
The new resolver [has landed in 
1.51.0](https://blog.rust-lang.org/2021/03/25/Rust-1.51.0.html#cargos-new-feature-resolver)!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/303#issuecomment-806897155

Re: [apache/incubator-teaclave-sgx-sdk] Are git tags being mutated? (#303)

2021-01-08 Thread Adam Szkoda
Thank you for clarifying @dingelish

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/303#issuecomment-756982675

[apache/incubator-teaclave-sgx-sdk] Are git tags being mutated? (#303)

2020-12-21 Thread Adam Szkoda
Hi 👋 

My cargo dependencies occasionally break in various ways.  While investigating, 
I noticed the `v1.1.3` tag got repointed to a newer commit:
 * Previous one: 
https://github.com/apache/incubator-teaclave-sgx-sdk/commit/254368badb9eb2d4cdab631a34e234bf6e54e585

![image](https://user-images.githubusercontent.com/165678/102764426-68030980-437b-11eb-92b7-b0404e4033da.png)

 * Current one: 
https://github.com/apache/incubator-teaclave-sgx-sdk/commit/a6a172e652b4db4eaa17e4faa078fda8922abdd0

![image](https://user-images.githubusercontent.com/165678/102764449-72bd9e80-437b-11eb-9a5b-f0cc367d621d.png)

Is this intentional?  In my understanding, it's generally assumed that tags, 
once created, do not change.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/303

Re: [apache/incubator-teaclave-sgx-sdk] The reason for TCSPolicy requirement on env_logger? (#271)

2020-10-08 Thread Adam Szkoda
Awesome, thank you!

I did some tests and it's almost perfect.  One glitch that I found is that 
within Rust tests, the `--nocapture` flag isn't being respected.  What I mean 
by that is when I initialize the logger like so (note the `is_test(true)` call) 
:

```Rust
#[no_mangle]
pub extern "C" fn ecall_init_test_logger() {
let mut builder = env_logger::Builder::from_default_env();
builder.is_test(true);
builder.init()
}
```

and then log from inside the enclave, it doesn't matter whether I pass 
`--nocapture` to a test or not — the output is the same in both cases.  The way 
to suppress/enable it, is of course the `RUST_LOG` environment variable, but it 
has the shortcoming of not depending on the test success/failure.  It's still 
beneficial to have `--nocapture` working, because it allows cargo to produce 
almost no output at all when a test succeeds (which is what we want), but dump 
everything out to output, when it fails, which is when you need the most 
information to debug the failure.

Hope I'm not missing some configuration here option here.  Cheers!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/271#issuecomment-705454120

[apache/incubator-teaclave-sgx-sdk] The reason for TCSPolicy requirement on env_logger? (#271)

2020-10-05 Thread Adam Szkoda
Hi!

I was trying to use the logging library within an enclave as described at 
https://github.com/apache/incubator-teaclave-sgx-sdk/tree/master/samplecode/logger#usage
 and came across the `TCSPolicy = 0` requirement.  Everything works great with 
that setting.  The problem is, unfortunately, I have a different library that 
needs `TCSPolicy = 1` (my colleague opened an issue about it some time ago: 
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/240).  So there's a 
conflict.

Now, while I can see why a library won't work if it depends on Thread Local 
Storage (TLS), it's not clear to me why log/env_logger depends on `TCSPolicy = 
1`.  Can you shed some light on why the forked version of log/env_logger crates 
need that?  Is it possible to bypass that requirement somehow?

Thanks in advance

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/271