Re: [apache/incubator-teaclave] A top-level Cargo.toml for virtual workspaces (#546)

2021-08-18 Thread Gordon King
Closed #546.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/issues/546#event-5177519238

Re: [apache/incubator-teaclave] A top-level Cargo.toml for virtual workspaces (#546)

2021-08-18 Thread Gordon King
The problem solved, thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/issues/546#issuecomment-901482402

Re: [apache/incubator-teaclave] A top-level Cargo.toml for virtual workspaces (#546)

2021-08-17 Thread Gordon King
@ya0guang @mssun  Thank you for the clarification. However, I still see some 
workspaces, e.g. `executor` which didn't get indexed either way because they 
seems not be included in both Cargo.toml files as workspace members. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/issues/546#issuecomment-900729137

Re: [apache/incubator-teaclave] A top-level Cargo.toml for virtual workspaces (#546)

2021-08-17 Thread Mingshen Sun
Hi, this is not feasible right now. Teaclave uses two set of Rust dependencies 
for SGX enclave and untrusted normal world separately. We haven't consolidated 
these into one. Therefore, we have to compile code in different worlds 
separately with different `Cargo.toml` files. You can find there here: 
https://github.com/apache/incubator-teaclave/tree/master/cmake/tomls. Our 
building system (cmake) will help to switch dependencies when building code for 
different worlds.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/issues/546#issuecomment-900625261

Re: [apache/incubator-teaclave] A top-level Cargo.toml for virtual workspaces (#546)

2021-08-17 Thread Hongbo
The trusted part and untrusted part use different set of crates. So we provide 
a script to prepare analyzer's essentials. You may check [this 
doc](https://teaclave.apache.org/docs/development-tips/) and try with the 
script to see if it can solve your concern.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/issues/546#issuecomment-900551505

[apache/incubator-teaclave] A top-level Cargo.toml for virtual workspaces (#546)

2021-08-17 Thread Gordon King
### Motivation & problem statement
The code analyzer cannot correctly identify this rust project and its 
workspaces corresponding to  each subdirectories.

### Proposed solution
Adding a top-level Cargo.toml, this configures a virtual workspace – a 
workspace that is only a container for member packages, but does not build a 
package itself.

See the main 
[Cargo.toml](https://github.com/SergioBenitez/Rocket/blob/master/Cargo.toml) 
file of Rocket for a real-world example of a virtual workspace



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/issues/546