Re: [I] Missing mem::forget(b) in TA_InvokeCommand() error path? [incubator-teaclave-trustzone-sdk]
a21152 commented on issue #119: URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/issues/119#issuecomment-2099427750 The following PR adds an example, test, and fix. https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For additional commands, e-mail: dev-h...@teaclave.apache.org
Re: [I] Missing mem::forget(b) in TA_InvokeCommand() error path? [incubator-teaclave-trustzone-sdk]
a21152 commented on issue #119:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/issues/119#issuecomment-1928780902
I don't have the code off my hand, but you will be able to reproduce the
problem with the following simple steps.
1. Take any of the example TA that make use of a session ctx parameter --
for example
https://github.com/apache/incubator-teaclave-trustzone-sdk/blob/master/examples/diffie_hellman-rs/ta/src/main.rs#L32
2. Implement the Drop trait on the session ctx object that just prints a
message, for example.
```
impl Drop for DiffieHellman {
fn drop( self) {
trace_println!("Dropping DiffieHellman!");
}
}
```
3. For an Err return from `fn invoke_command`.
4. Run the example CA and you shall observe drop being printed twice which
is indicative of a double-free bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org
For additional commands, e-mail: dev-h...@teaclave.apache.org
Re: [I] Missing mem::forget(b) in TA_InvokeCommand() error path? [incubator-teaclave-trustzone-sdk]
DemesneGH commented on issue #119: URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/issues/119#issuecomment-1926725865 Hi @a21152 , could you provide the code for reproducing the error? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For additional commands, e-mail: dev-h...@teaclave.apache.org
