[GitHub] incubator-tephra pull request #63: TEPHRA-265 Fix NOTICE_BINARY for Guice an...
Github user johnament commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/63#discussion_r144667984 --- Diff: tephra-distribution/NOTICE_BINARY --- @@ -6,10 +6,19 @@ The Apache Software Foundation (http://www.apache.org/). Apache Tephra - notice for binary distribution == -Apache Tephra includes Guice v3.0 and Guice Assisted Inject v3.0. Tephra -elects to include this software in this distribution under the Apache License. -You can obtain a copy of the License at: -http://apache.org/licenses/LICENSE-2.0 +Apache Tephra includes Guice v3.0. +Google Guice - Core Library +Copyright 2006-2011 Google, Inc. + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +Apache Tephra includes Guice Assisted Inject v3.0. +Google Guice - Extensions - AssistedInject +Copyright 2006-2011 Google, Inc. + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). Apache Tephra includes Guava v13.0.1. Tephra elects to include this software --- End diff -- Just because a dependency is apache licensed doesn't mean it will have a NOTICE. NOTICE is optional, so you shouldn't include one if none is present. ---
[jira] [Commented] (TEPHRA-265) Tephra Guice License
[ https://issues.apache.org/jira/browse/TEPHRA-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204272#comment-16204272 ] ASF GitHub Bot commented on TEPHRA-265: --- Github user johnament commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/63#discussion_r144667984 --- Diff: tephra-distribution/NOTICE_BINARY --- @@ -6,10 +6,19 @@ The Apache Software Foundation (http://www.apache.org/). Apache Tephra - notice for binary distribution == -Apache Tephra includes Guice v3.0 and Guice Assisted Inject v3.0. Tephra -elects to include this software in this distribution under the Apache License. -You can obtain a copy of the License at: -http://apache.org/licenses/LICENSE-2.0 +Apache Tephra includes Guice v3.0. +Google Guice - Core Library +Copyright 2006-2011 Google, Inc. + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +Apache Tephra includes Guice Assisted Inject v3.0. +Google Guice - Extensions - AssistedInject +Copyright 2006-2011 Google, Inc. + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). Apache Tephra includes Guava v13.0.1. Tephra elects to include this software --- End diff -- Just because a dependency is apache licensed doesn't mean it will have a NOTICE. NOTICE is optional, so you shouldn't include one if none is present. > Tephra Guice License > > > Key: TEPHRA-265 > URL: https://issues.apache.org/jira/browse/TEPHRA-265 > Project: Tephra > Issue Type: Bug >Affects Versions: 0.13.0-incubating >Reporter: Gokul Gunasekaran >Assignee: Gokul Gunasekaran > Fix For: 0.14.0-incubating > > > The NOTICE for Guice in 0.13.0-incubating release contains (which was added > as part of the fix for TEPHRA-231): > Apache Tephra includes Guice v3.0 and Guice Assisted Inject v3.0. Tephra > elects to include this software in this distribution under the Apache License. > You can obtain a copy of the License at: > http://apache.org/licenses/LICENSE-2.0 > Instead, it should contain the exact content from the NOTICE of the Guice > JAR. > Google Guice - Core Library > Copyright 2006-2011 Google, Inc. > This product includes software developed at > The Apache Software Foundation (http://www.apache.org/). > http://mail-archives.apache.org/mod_mbox/incubator-general/201709.mbox/%3CCAOqetn-zPeOanD1fVZHVsjfwqn5qnmN9WXWjb1jDJAE8JgQ_Zg%40mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TEPHRA-265) Tephra Guice License
[ https://issues.apache.org/jira/browse/TEPHRA-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204244#comment-16204244 ] ASF GitHub Bot commented on TEPHRA-265: --- Github user poornachandra commented on the issue: https://github.com/apache/incubator-tephra/pull/63 @gokulavasan Do you have time to take this PR to completion? > Tephra Guice License > > > Key: TEPHRA-265 > URL: https://issues.apache.org/jira/browse/TEPHRA-265 > Project: Tephra > Issue Type: Bug >Affects Versions: 0.13.0-incubating >Reporter: Gokul Gunasekaran >Assignee: Gokul Gunasekaran > Fix For: 0.14.0-incubating > > > The NOTICE for Guice in 0.13.0-incubating release contains (which was added > as part of the fix for TEPHRA-231): > Apache Tephra includes Guice v3.0 and Guice Assisted Inject v3.0. Tephra > elects to include this software in this distribution under the Apache License. > You can obtain a copy of the License at: > http://apache.org/licenses/LICENSE-2.0 > Instead, it should contain the exact content from the NOTICE of the Guice > JAR. > Google Guice - Core Library > Copyright 2006-2011 Google, Inc. > This product includes software developed at > The Apache Software Foundation (http://www.apache.org/). > http://mail-archives.apache.org/mod_mbox/incubator-general/201709.mbox/%3CCAOqetn-zPeOanD1fVZHVsjfwqn5qnmN9WXWjb1jDJAE8JgQ_Zg%40mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] incubator-tephra issue #63: TEPHRA-265 Fix NOTICE_BINARY for Guice and Guice...
Github user poornachandra commented on the issue: https://github.com/apache/incubator-tephra/pull/63 @gokulavasan Do you have time to take this PR to completion? ---
[GitHub] incubator-tephra pull request #45: [TEPHRA-236] Changes to replace deprecate...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tephra/pull/45 ---
[GitHub] incubator-tephra issue #45: [TEPHRA-236] Changes to replace deprecated class...
Github user poornachandra commented on the issue: https://github.com/apache/incubator-tephra/pull/45 Thanks for the contribution @bijugs! ---
