[jira] [Commented] (THRIFT-1031) Patch to compile Thrift for vc++ 9.0 and 10.0
[ https://issues.apache.org/jira/browse/THRIFT-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036628#comment-13036628 ] Carl Steinbach commented on THRIFT-1031: This patch depends on pthreads_win32 library which carries an LGPL license. The [ASF License FAQ|http://www.apache.org/legal/resolved.html#category-a] lists the LGPL in the prohibited category, though it's unclear to me if this prohibition is limited to creating a derivative work from LGPL'd code, or if it also applies to runtime dependencies against standalone LGPL libraries. Does anyone know the answer? > Patch to compile Thrift for vc++ 9.0 and 10.0 > - > > Key: THRIFT-1031 > URL: https://issues.apache.org/jira/browse/THRIFT-1031 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Environment: Windows XP 32bit, vc++ 9.0, 10.0 >Reporter: James Dickson >Priority: Trivial > Fix For: 0.7 > > Attachments: thrift_msvc.patch, thrift_msvc_v0_1.patch > > > At our company we need clients running on Windows being able to connect to > our linux servers running hypertable. The attached patch enables the parts > needed by Hypertable to be compiled on Windows using either the VC++ 9.0 or > 10.0 compilers. > Having read previous posts about ports using boost::asio we found these to be > too intrusive for our needs. This version uses pthreads_win32 and winsock2 > and is as designed to be as un-intrusive as is possible to the original unix > code base. It is mostly #defines between unix sockets and winsock2 sockets. > We also tried to follow the folder structuring of the C# runtime that has > visual studio solutions to be consistent. > More details are in the README as not all the functionality of the original > unix code base is available to windows users. We will add the missing > functionality, we just wanted to share what we had as for a Windows based > client for us it is sufficient. > The patch is based on the latest revision in SVN, we would love feedback and > any code reviews. If there is any possibility of this being added to the main > trunk then that would be much appreciated, however we don't expect that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-835) Bad AS3 syntax in constructors that set default values
[
https://issues.apache.org/jira/browse/THRIFT-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036402#comment-13036402
]
Hudson commented on THRIFT-835:
---
Integrated in Thrift #143 (See
[https://builds.apache.org/hudson/job/Thrift/143/])
Thrift-835: Bad AS3 syntax in constructors that set default values
Client: as3
Patch: Justin Florentine
Generated AS3 object won't compile since the compiler uses the same function
that generates member declarations.
> Bad AS3 syntax in constructors that set default values
> --
>
> Key: THRIFT-835
> URL: https://issues.apache.org/jira/browse/THRIFT-835
> Project: Thrift
> Issue Type: Bug
> Components: AS3 - Compiler
>Affects Versions: 0.3
> Environment: Any.
>Reporter: Justin Florentine
>Assignee: Justin Florentine
> Fix For: 0.7
>
> Attachments: THRIFT-835.patch
>
>
> If your thrift definition declares static default values, such as:
> struct Chat {
> 1: MessageType type = EVENT_CHAT,
> 2: i32 eventId,
> 3: string message,
> 4: Date at
> }
> The generated AS3 object won't compile since the compiler uses the same
> function that generates member declarations. Patch is below.
> {code}
> Index: compiler/cpp/src/generate/t_as3_generator.cc
> ===
> --- compiler/cpp/src/generate/t_as3_generator.cc(revision 981076)
> +++ compiler/cpp/src/generate/t_as3_generator.cc(working copy)
> @@ -696,7 +696,8 @@
> for (m_iter = members.begin(); m_iter != members.end(); ++m_iter) {
> t_type* t = get_true_type((*m_iter)->get_type());
> if ((*m_iter)->get_value() != NULL) {
> - print_const_value(out, "this." + (*m_iter)->get_name(), t,
> (*m_iter)->get_value(), true, true);
> + indent(out) << "this._" << (*m_iter)->get_name() << " = " <<
> (*m_iter)->get_value()->get_integer() << ";" <<
> + endl;
> }
> }
> indent_down();
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-835) Bad AS3 syntax in constructors that set default values
[
https://issues.apache.org/jira/browse/THRIFT-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-835.
---
> Bad AS3 syntax in constructors that set default values
> --
>
> Key: THRIFT-835
> URL: https://issues.apache.org/jira/browse/THRIFT-835
> Project: Thrift
> Issue Type: Bug
> Components: AS3 - Compiler
>Affects Versions: 0.3
> Environment: Any.
>Reporter: Justin Florentine
>Assignee: Justin Florentine
> Fix For: 0.7
>
> Attachments: THRIFT-835.patch
>
>
> If your thrift definition declares static default values, such as:
> struct Chat {
> 1: MessageType type = EVENT_CHAT,
> 2: i32 eventId,
> 3: string message,
> 4: Date at
> }
> The generated AS3 object won't compile since the compiler uses the same
> function that generates member declarations. Patch is below.
> {code}
> Index: compiler/cpp/src/generate/t_as3_generator.cc
> ===
> --- compiler/cpp/src/generate/t_as3_generator.cc(revision 981076)
> +++ compiler/cpp/src/generate/t_as3_generator.cc(working copy)
> @@ -696,7 +696,8 @@
> for (m_iter = members.begin(); m_iter != members.end(); ++m_iter) {
> t_type* t = get_true_type((*m_iter)->get_type());
> if ((*m_iter)->get_value() != NULL) {
> - print_const_value(out, "this." + (*m_iter)->get_name(), t,
> (*m_iter)->get_value(), true, true);
> + indent(out) << "this._" << (*m_iter)->get_name() << " = " <<
> (*m_iter)->get_value()->get_integer() << ";" <<
> + endl;
> }
> }
> indent_down();
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-835) Bad AS3 syntax in constructors that set default values
[
https://issues.apache.org/jira/browse/THRIFT-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell resolved THRIFT-835.
-
Resolution: Fixed
Fix Version/s: 0.7
Assignee: Justin Florentine
Added to trunk, thanks for the patch.
> Bad AS3 syntax in constructors that set default values
> --
>
> Key: THRIFT-835
> URL: https://issues.apache.org/jira/browse/THRIFT-835
> Project: Thrift
> Issue Type: Bug
> Components: AS3 - Compiler
>Affects Versions: 0.3
> Environment: Any.
>Reporter: Justin Florentine
>Assignee: Justin Florentine
> Fix For: 0.7
>
> Attachments: THRIFT-835.patch
>
>
> If your thrift definition declares static default values, such as:
> struct Chat {
> 1: MessageType type = EVENT_CHAT,
> 2: i32 eventId,
> 3: string message,
> 4: Date at
> }
> The generated AS3 object won't compile since the compiler uses the same
> function that generates member declarations. Patch is below.
> {code}
> Index: compiler/cpp/src/generate/t_as3_generator.cc
> ===
> --- compiler/cpp/src/generate/t_as3_generator.cc(revision 981076)
> +++ compiler/cpp/src/generate/t_as3_generator.cc(working copy)
> @@ -696,7 +696,8 @@
> for (m_iter = members.begin(); m_iter != members.end(); ++m_iter) {
> t_type* t = get_true_type((*m_iter)->get_type());
> if ((*m_iter)->get_value() != NULL) {
> - print_const_value(out, "this." + (*m_iter)->get_name(), t,
> (*m_iter)->get_value(), true, true);
> + indent(out) << "this._" << (*m_iter)->get_name() << " = " <<
> (*m_iter)->get_value()->get_integer() << ";" <<
> + endl;
> }
> }
> indent_down();
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-1174) Publish as3 client implementation via Maven for use by flex-mojos users
[ https://issues.apache.org/jira/browse/THRIFT-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell reassigned THRIFT-1174: Assignee: Jake Farrell > Publish as3 client implementation via Maven for use by flex-mojos users > --- > > Key: THRIFT-1174 > URL: https://issues.apache.org/jira/browse/THRIFT-1174 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.6.1 > Environment: Maven 3.0.3 using central repository >Reporter: Justin Florentine >Assignee: Jake Farrell > Labels: flex, maven > Fix For: 0.7 > > Attachments: pom.xml > > > It would be nice to be able to use the flex-mojos to get the as3 client > implementation .swc artifact the same way we can get the .jar artifact for > java clients. An example pom that uses this approach with our local > repositories should be attached. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1174) Publish as3 client implementation via Maven for use by flex-mojos users
[ https://issues.apache.org/jira/browse/THRIFT-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036385#comment-13036385 ] Jake Farrell commented on THRIFT-1174: -- Thanks Justin, should be able to accomplish this similar to how i did the fb303 and libthrift java versions > Publish as3 client implementation via Maven for use by flex-mojos users > --- > > Key: THRIFT-1174 > URL: https://issues.apache.org/jira/browse/THRIFT-1174 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.6.1 > Environment: Maven 3.0.3 using central repository >Reporter: Justin Florentine >Assignee: Jake Farrell > Labels: flex, maven > Fix For: 0.7 > > Attachments: pom.xml > > > It would be nice to be able to use the flex-mojos to get the as3 client > implementation .swc artifact the same way we can get the .jar artifact for > java clients. An example pom that uses this approach with our local > repositories should be attached. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1174) Publish as3 client implementation via Maven for use by flex-mojos users
[ https://issues.apache.org/jira/browse/THRIFT-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Florentine updated THRIFT-1174: -- Attachment: pom.xml This shows the dependency entry we use to retrieve a .swc from our corporate repository. > Publish as3 client implementation via Maven for use by flex-mojos users > --- > > Key: THRIFT-1174 > URL: https://issues.apache.org/jira/browse/THRIFT-1174 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.6.1 > Environment: Maven 3.0.3 using central repository >Reporter: Justin Florentine > Labels: flex, maven > Fix For: 0.7 > > Attachments: pom.xml > > > It would be nice to be able to use the flex-mojos to get the as3 client > implementation .swc artifact the same way we can get the .jar artifact for > java clients. An example pom that uses this approach with our local > repositories should be attached. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (THRIFT-1174) Publish as3 client implementation via Maven for use by flex-mojos users
Publish as3 client implementation via Maven for use by flex-mojos users --- Key: THRIFT-1174 URL: https://issues.apache.org/jira/browse/THRIFT-1174 Project: Thrift Issue Type: Improvement Components: Build Process Affects Versions: 0.6.1 Environment: Maven 3.0.3 using central repository Reporter: Justin Florentine Fix For: 0.7 It would be nice to be able to use the flex-mojos to get the as3 client implementation .swc artifact the same way we can get the .jar artifact for java clients. An example pom that uses this approach with our local repositories should be attached. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-835) Bad AS3 syntax in constructors that set default values
[
https://issues.apache.org/jira/browse/THRIFT-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Florentine updated THRIFT-835:
-
Attachment: THRIFT-835.patch
re-generated patch against the 0.6.x branch.
> Bad AS3 syntax in constructors that set default values
> --
>
> Key: THRIFT-835
> URL: https://issues.apache.org/jira/browse/THRIFT-835
> Project: Thrift
> Issue Type: Bug
> Components: AS3 - Compiler
>Affects Versions: 0.3
> Environment: Any.
>Reporter: Justin Florentine
> Attachments: THRIFT-835.patch
>
>
> If your thrift definition declares static default values, such as:
> struct Chat {
> 1: MessageType type = EVENT_CHAT,
> 2: i32 eventId,
> 3: string message,
> 4: Date at
> }
> The generated AS3 object won't compile since the compiler uses the same
> function that generates member declarations. Patch is below.
> {code}
> Index: compiler/cpp/src/generate/t_as3_generator.cc
> ===
> --- compiler/cpp/src/generate/t_as3_generator.cc(revision 981076)
> +++ compiler/cpp/src/generate/t_as3_generator.cc(working copy)
> @@ -696,7 +696,8 @@
> for (m_iter = members.begin(); m_iter != members.end(); ++m_iter) {
> t_type* t = get_true_type((*m_iter)->get_type());
> if ((*m_iter)->get_value() != NULL) {
> - print_const_value(out, "this." + (*m_iter)->get_name(), t,
> (*m_iter)->get_value(), true, true);
> + indent(out) << "this._" << (*m_iter)->get_name() << " = " <<
> (*m_iter)->get_value()->get_integer() << ";" <<
> + endl;
> }
> }
> indent_down();
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-68) Generated types define a hashcode method that always returns 0
[ https://issues.apache.org/jira/browse/THRIFT-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036285#comment-13036285 ] Greg Moulliet commented on THRIFT-68: - Given that Thrift supports Sets and Maps, and in Java uses HashSet and HashMap, it is particularly surprising to me that the default hashcode performs so poorly for Set and Map serialization, O(n^2). > Generated types define a hashcode method that always returns 0 > -- > > Key: THRIFT-68 > URL: https://issues.apache.org/jira/browse/THRIFT-68 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler, Java - Library >Reporter: Bryan Duxbury >Priority: Minor > > When not using the "hashcode" option with the Java generator, the hashCode > method that is created always returns 0, regardless of the type or instance. > This makes it completely impossible to use as a hash key (or in a hash set). > This is particularly curious because the default Java Object#hashCode method > returns a reasonably unique hashcode per object instance. Thus, the hashCode > method on generated types is actually explicitly worse than default. > I think at the very least we should remove the hashCode method declaration > and let the superclass method take care of it. At best, I think it would make > sense for us to write a simple real hashCode method that produced something > reasonably unique, if not perfect. If you need super hashCodes, then you can > use the "hashcode" option and just plan on using the external jar that it > requires. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: libthrift .swc artifact deployment for flex-mojos users?
Working on this, will have a patch shortly that will get this lib ready to be added into maven along side the java driver On May 18, 2011, at 4:23 PM, Aron Sogor wrote: > I think we would welcome help with that :) > > If you willing to take a crack at it we would be happy to help. > > On Wed, May 18, 2011 at 11:00 AM, Florentine, Justin F. > wrote: >> Thanks so much for getting the java implementation deployed to the central >> Maven repository! Would it be possible to do the same for the Flex >> implementation as well? Here at ESPN we are using flex-mojos to build and >> manage our Flex builds, and it would be great to no longer have to manage >> the entry for it in our repository locally. >> >> Thanks! >> >>
