[jira] [Commented] (THRIFT-1173) Using template system (for example: ctemplate) for code generation
[ https://issues.apache.org/jira/browse/THRIFT-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036733#comment-13036733 ] Roger Meier commented on THRIFT-1173: - I use ctemplate on several applications, it's a great piece of software. However migrating the Thrift compiler to a template based concept sounds like lot of work and adds additional dependencies to the Thrift compiler. And this will make it more difficult to cross compile the compiler for Windows. On the other side a template based mechanism would be a great option to test or prototype new adoptions of languages or to create other things like custom documentation or proprietary code ready to use. Do you already have a prototype? Using template system (for example: ctemplate) for code generation -- Key: THRIFT-1173 URL: https://issues.apache.org/jira/browse/THRIFT-1173 Project: Thrift Issue Type: Improvement Components: Compiler (General) Affects Versions: 0.6.1 Reporter: alessandro rossi Priority: Minor Labels: generation, template IMHO, the code generation embedded into generator's code is not a good solution. With ctemplate (http://code.google.com/p/google-ctemplate/), for example, we can separate logic with generation code. If you want I can implement an example for cpp generator. Best Regards, Alessandro -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1173) Using template system (for example: ctemplate) for code generation
[ https://issues.apache.org/jira/browse/THRIFT-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036745#comment-13036745 ] alessandro rossi commented on THRIFT-1173: -- No, I've not a prototype, but I can try to develop it for a language (cpp or python), so you could compare it with existing version. Using template system (for example: ctemplate) for code generation -- Key: THRIFT-1173 URL: https://issues.apache.org/jira/browse/THRIFT-1173 Project: Thrift Issue Type: Improvement Components: Compiler (General) Affects Versions: 0.6.1 Reporter: alessandro rossi Priority: Minor Labels: generation, template IMHO, the code generation embedded into generator's code is not a good solution. With ctemplate (http://code.google.com/p/google-ctemplate/), for example, we can separate logic with generation code. If you want I can implement an example for cpp generator. Best Regards, Alessandro -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1174) Publish as3 client implementation via Maven for use by flex-mojos users
[ https://issues.apache.org/jira/browse/THRIFT-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036905#comment-13036905 ] Jake Farrell commented on THRIFT-1174: -- got this all working and published to the staging repo with no issues. Generates the pom and swc files based on the current java version. Artifacts uploaded where libthrift-as3-0.7.0-snapshot.pom libthrift-as3-0.7.0-snapshot.swc I'm cleaning up the java/fb303/javascript and as3 build files to share common components and reduce code duplications. Will check the updates into trunk shortly Publish as3 client implementation via Maven for use by flex-mojos users --- Key: THRIFT-1174 URL: https://issues.apache.org/jira/browse/THRIFT-1174 Project: Thrift Issue Type: Improvement Components: Build Process Affects Versions: 0.6.1 Environment: Maven 3.0.3 using central repository Reporter: Justin Florentine Assignee: Jake Farrell Labels: flex, maven Fix For: 0.7 Attachments: pom.xml It would be nice to be able to use the flex-mojos to get the as3 client implementation .swc artifact the same way we can get the .jar artifact for java clients. An example pom that uses this approach with our local repositories should be attached. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (THRIFT-1175) Bad data can cause TProtocolUtil.skip to take a lot of CPU in a do-nothing loop
Bad data can cause TProtocolUtil.skip to take a lot of CPU in a do-nothing loop --- Key: THRIFT-1175 URL: https://issues.apache.org/jira/browse/THRIFT-1175 Project: Thrift Issue Type: Bug Components: Java - Library Reporter: Jake Donham If, due to bad data, skip gets to the LIST case with a large size and invalid elemType, it loops doing nothing (since nothing happens in the recursive call to skip with an invalid elemType), taking a lot of CPU. Same for the MAP and SET cases. The default case in skip should throw a TProtocolException so invalid elemTypes are caught. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1174) Publish as3 client implementation via Maven for use by flex-mojos users
[ https://issues.apache.org/jira/browse/THRIFT-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1174. Resolution: Fixed Added to trunk, next release the libthrift-as3 client will get published to apache maven central with the libthrift and fb303 clients. Publish as3 client implementation via Maven for use by flex-mojos users --- Key: THRIFT-1174 URL: https://issues.apache.org/jira/browse/THRIFT-1174 Project: Thrift Issue Type: Improvement Components: Build Process Affects Versions: 0.6.1 Environment: Maven 3.0.3 using central repository Reporter: Justin Florentine Assignee: Jake Farrell Labels: flex, maven Fix For: 0.7 Attachments: pom.xml It would be nice to be able to use the flex-mojos to get the as3 client implementation .swc artifact the same way we can get the .jar artifact for java clients. An example pom that uses this approach with our local repositories should be attached. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-980) as3: add version Info to the library
[ https://issues.apache.org/jira/browse/THRIFT-980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-980. --- as3: add version Info to the library Key: THRIFT-980 URL: https://issues.apache.org/jira/browse/THRIFT-980 Project: Thrift Issue Type: Sub-task Components: AS3 - Library Reporter: Roger Meier Assignee: Jake Farrell add version info to the library and update http://wiki.apache.org/thrift/HowToVersion -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (THRIFT-1176) Thrift compiler global leakage js
Thrift compiler global leakage js
-
Key: THRIFT-1176
URL: https://issues.apache.org/jira/browse/THRIFT-1176
Project: Thrift
Issue Type: Bug
Components: Node.js - Compiler
Affects Versions: 0.6
Reporter: Dan Di Spaltro
Priority: Trivial
Fix For: 0.6
Below I added the var qualifier on the declare field function. This is fairly
trivial and fixes the global scope leak.
{code}
diff --git a/compiler/cpp/src/generate/t_js_generator.cc
b/compiler/cpp/src/generate/t_js_generator.cc
index a654fc9..c4f201f 100644
--- a/compiler/cpp/src/generate/t_js_generator.cc
+++ b/compiler/cpp/src/generate/t_js_generator.cc
@@ -1623,7 +1623,7 @@ string t_js_generator::declare_field(t_field* tfield,
bool init, bool obj) {
string result = this. + tfield-get_name();
if(!obj){
- result = tfield-get_name();
+ result = var + tfield-get_name();
}
if (init) {
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1177) Update thrift to reflect changes in Go's networking libraries
[ https://issues.apache.org/jira/browse/THRIFT-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aalok Shah updated THRIFT-1177: --- Attachment: gopatch2.diff Works with the latest version of Go as of May 16, 2011. I don't have commit access, can someone else please confirm nothing broke and commit this? Thank You. Update thrift to reflect changes in Go's networking libraries - Key: THRIFT-1177 URL: https://issues.apache.org/jira/browse/THRIFT-1177 Project: Thrift Issue Type: Dependency upgrade Components: Go - Compiler, Go - Library Affects Versions: 0.7 Reporter: Aalok Shah Priority: Minor Fix For: 0.7 Attachments: gopatch2.diff Go updated its networking libraries requiring a change to both the thrift code generator and the libraries. Additionally, the Go generator did not support arguments/variables that were Go keywords, this needs to be updated to work with Cassandra's thrift since range is a Go keyword. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
