[jira] [Resolved] (THRIFT-1276) Add thrift compiler option to suppress warnings about
[ https://issues.apache.org/jira/browse/THRIFT-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-1276. - Resolution: Fixed Assignee: Roger Meier this makes sense, committed! Add thrift compiler option to suppress warnings about --- Key: THRIFT-1276 URL: https://issues.apache.org/jira/browse/THRIFT-1276 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Assignee: Roger Meier Priority: Minor Attachments: 0008-Add-thrift-compiler-option-to-suppress-warnings-abou.patch.diff From 888de29f39ea6235c39416585b234a32712ae16b Mon Sep 17 00:00:00 2001 From: Doug Ihde di...@fb.com Date: Thu, 4 Mar 2010 20:21:18 + Subject: [PATCH 08/33] Add thrift compiler option to suppress warnings about 64-bit constants Summary: The thrift compiler generates warnings whenever you define a 64-bit constant in a .thrift file, because some languages don't support 64-bit values. But most useful languages do, so it's annoying to get these warnings all the time for project in which we know we're only using 64-bit-safe languages. Test Plan: I added --allow-64bit-consts to the TARGETS file for business/account/if and watched all the warnings from account.thrift go away. --- compiler/cpp/src/globals.h |9 + compiler/cpp/src/main.cc|8 compiler/cpp/src/thrifty.yy |2 +- 3 files changed, 18 insertions(+), 1 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Build failed in Jenkins: Thrift #225
See https://builds.apache.org/job/Thrift/225/changes Changes: [roger] THRIFT-1276 Add thrift compiler option to suppress warnings about Patch: Dave Watson -- [...truncated 2121 lines...] [exec] Execute failed: java.io.IOException: Cannot run program Xvfb: java.io.IOException: error=2, No such file or directory phantomjs: compile: [javac] Compiling 21 source files to https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/test [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] Compiling 1 source file to https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/test [javac] Note: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/src/test/Httpd.java uses unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. jstest: [jar] Building jar: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/jstest.jar proxy: jslibs: [get] Getting: http://code.jquery.com/jquery-1.5.2.js [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/jquery-1.5.2.js [get] Getting: http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/equiv.js [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/equiv.js [get] Getting: http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/QUnitAdapter.js [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/QUnitAdapter.js [get] Getting: http://code.jquery.com/qunit/git/qunit.js [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/qunit.js [get] Getting: http://code.jquery.com/qunit/git/qunit.css [get] To: https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js/lib/qunit.css [copy] Copying 1 file to https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test/build/js unittest: test: BUILD SUCCESSFUL Total time: 12 seconds make[3]: Leaving directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test' make[2]: Leaving directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/js/test' Making check in py make[2]: Entering directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/py' /usr/bin/python setup.py build running build running build_py running build_ext make check-local make[3]: Entering directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/py' /usr/bin/python setup.py build running build running build_py running build_ext make[3]: Leaving directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/py' make[2]: Leaving directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/py' Making check in erl make[2]: Entering directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/erl' ./rebar eunit == erl (eunit) Compiled src/thrift_transport.erl Compiled src/thrift_protocol.erl Compiled src/thrift_service.erl Compiled test/smallTest_types.erl Compiled test/yowza_thrift.erl Compiled test/test_disklog.erl Compiled test/aService_thrift.erl Compiled test/test_membuffer.erl Compiled test/service_thrift.erl Compiled test/thriftTest_thrift.erl Compiled test/stress_server.erl Compiled test/secondService_thrift.erl Compiled test/test_thrift_1151.erl Compiled test/thriftTest_types.erl Compiled test/serviceForExceptionWithAMap_thrift.erl Compiled test/smallService_thrift.erl Compiled test/debugProtoTest_types.erl Compiled test/docTest_types.erl Compiled test/emptyService_thrift.erl Compiled test/test_server.erl Compiled test/thrift1151_types.erl Compiled test/srv_thrift.erl Compiled test/optionalRequiredTest_types.erl Compiled test/stressTest_types.erl Compiled test/manyTypedefs_types.erl Compiled test/javaBeansTest_types.erl Compiled test/constantsDemo_types.erl Compiled test/reverseOrderService_thrift.erl Compiled test/annotationTest_types.erl Compiled test/inherited_thrift.erl Compiled test/denseLinkingTest_types.erl Compiled src/thrift_http_transport.erl Compiled src/thrift_server.erl Compiled src/thrift_framed_transport.erl Compiled src/thrift_client_util.erl Compiled test/test_client.erl Compiled src/thrift_transport_state_test.erl Compiled src/thrift_reconnecting_client.erl Compiled src/thrift_socket_transport.erl Compiled src/thrift_disk_log_transport.erl Compiled src/thrift_socket_server.erl Compiled src/thrift_base64_transport.erl Compiled src/thrift_client.erl Compiled src/thrift_buffered_transport.erl Compiled src/thrift_file_transport.erl Compiled src/thrift_memory_buffer.erl Compiled src/thrift_binary_protocol.erl Compiled src/thrift_processor.erl =INFO REPORT 19-Aug-2011::11:44:17 === Skipping field 4 with wrong type (3 != 8) All 9 tests passed. make[2]: Leaving directory `https://builds.apache.org/job/Thrift/ws/thrift/lib/erl' Making check in rb make[2]: Entering
[jira] [Commented] (THRIFT-1276) Add thrift compiler option to suppress warnings about
[ https://issues.apache.org/jira/browse/THRIFT-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087665#comment-13087665 ] Hudson commented on THRIFT-1276: Integrated in Thrift #225 (See [https://builds.apache.org/job/Thrift/225/]) THRIFT-1276 Add thrift compiler option to suppress warnings about Patch: Dave Watson roger : http://svn.apache.org/viewvc/?view=revrev=1159593 Files : * /thrift/trunk/compiler/cpp/src/main.cc * /thrift/trunk/compiler/cpp/src/thrifty.yy * /thrift/trunk/compiler/cpp/src/globals.h Add thrift compiler option to suppress warnings about --- Key: THRIFT-1276 URL: https://issues.apache.org/jira/browse/THRIFT-1276 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Assignee: Roger Meier Priority: Minor Attachments: 0008-Add-thrift-compiler-option-to-suppress-warnings-abou.patch.diff From 888de29f39ea6235c39416585b234a32712ae16b Mon Sep 17 00:00:00 2001 From: Doug Ihde di...@fb.com Date: Thu, 4 Mar 2010 20:21:18 + Subject: [PATCH 08/33] Add thrift compiler option to suppress warnings about 64-bit constants Summary: The thrift compiler generates warnings whenever you define a 64-bit constant in a .thrift file, because some languages don't support 64-bit values. But most useful languages do, so it's annoying to get these warnings all the time for project in which we know we're only using 64-bit-safe languages. Test Plan: I added --allow-64bit-consts to the TARGETS file for business/account/if and watched all the warnings from account.thrift go away. --- compiler/cpp/src/globals.h |9 + compiler/cpp/src/main.cc|8 compiler/cpp/src/thrifty.yy |2 +- 3 files changed, 18 insertions(+), 1 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1263) publish ruby client to rubygems
[ https://issues.apache.org/jira/browse/THRIFT-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087673#comment-13087673 ] Jake Farrell commented on THRIFT-1263: -- I had seen that, wasnt sure on the best way to handle it yet. I'll come up with a fix for it today -Jake publish ruby client to rubygems --- Key: THRIFT-1263 URL: https://issues.apache.org/jira/browse/THRIFT-1263 Project: Thrift Issue Type: Bug Components: Ruby - Compiler Affects Versions: 0.7 Reporter: Jake Farrell Assignee: Jake Farrell Fix For: 0.8 Attachments: thrift-1263.patch As part of the release process release gem to rubygems.org -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1275) thrift: always prefix namespaces with ::
[ https://issues.apache.org/jira/browse/THRIFT-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury closed THRIFT-1275. - Resolution: Fixed Fix Version/s: 0.8 Assignee: Dave Watson I just committed this to TRUNK. thrift: always prefix namespaces with :: - Key: THRIFT-1275 URL: https://issues.apache.org/jira/browse/THRIFT-1275 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Assignee: Dave Watson Priority: Minor Fix For: 0.8 Attachments: 0007-thrift-always-prefix-namespaces-with.patch.diff From d56203d414d23c7858a269e4aa547ee3164832fd Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Thu, 4 Mar 2010 00:53:37 + Subject: [PATCH 07/33] thrift: always prefix namespaces with :: Summary: Thrift always refers to namespaces using their full name. Therefore, it should prefix them with :: to avoid accidentally matching a name defined in one of the current namespaces, rather than at the top-level. For example, if ServiceB is in namespace bar, and inherits from ServiceA in namespace foo, all code emitted for ServiceB now refers to ServiceA as ::foo::ServiceA instead of just foo::ServiceA. This allows the code to compile even if a namespace ::bar::foo also exists. An extra leading whitespace is also emitted, which is needed in cases when the name is used as the first template parameter, so that the emitted code contains :: instead of ::. Test Plan: jsong reported a build problem because of this name lookup error, and this change fixed his build. I also tested building [internal fb thing] and [internal fb thing], and they both built successfully. Tags: thrift --- compiler/cpp/src/generate/t_cpp_generator.cc | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1274) thrift: fail compilation if an unexpected token is
[ https://issues.apache.org/jira/browse/THRIFT-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury closed THRIFT-1274. - Resolution: Fixed Fix Version/s: 0.8 Assignee: Dave Watson I just committed this. thrift: fail compilation if an unexpected token is Key: THRIFT-1274 URL: https://issues.apache.org/jira/browse/THRIFT-1274 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Assignee: Dave Watson Priority: Minor Fix For: 0.8 Attachments: 0006-thrift-fail-compilation-if-an-unexpected-token-is-en.patch.diff From e52b015b1c3d3b25ca1c905ea28cab80783a14bc Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Fri, 26 Feb 2010 04:48:55 + Subject: [PATCH 06/33] thrift: fail compilation if an unexpected token is encountered Summary: Currently, if the thrift lexer encounters a token it does not expect, it prints the token it to stdout and continues. (This is the default behavior of flex when a token is unmatched.) This updates thriftl.ll to fail with an error message when it sees an unexpected character. Test Plan: [internal fb thing].thrift contains a stray single-quote. Previously it was getting printed to stdout whenever you compile this file, or anything that includes it. (Furthermore, it is printed out multiple times, since we scan the file twice each time it is included. Compiling [internal fb thing].thrift scans this file 8 times!) Now compiling this file fails with an error, as desired. I'll submit a separate diff to fix [internal fb thing].thrift. --- compiler/cpp/src/thriftl.ll |9 + 1 files changed, 9 insertions(+), 0 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1265) C++ container deserialize
[ https://issues.apache.org/jira/browse/THRIFT-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-1265: -- Fix Version/s: (was: 0.7) 0.8 0.7 is already released, so we'll fix it in 0.8. C++ container deserialize - Key: THRIFT-1265 URL: https://issues.apache.org/jira/browse/THRIFT-1265 Project: Thrift Issue Type: Bug Components: C++ - Compiler Affects Versions: 0.6.1, 0.7 Environment: Linux RedHat Reporter: Peng Futian Labels: patch Fix For: 0.8 Attachments: 0001-Fix-bug-generate_deserialize_container.patch Original Estimate: 1m Remaining Estimate: 1m When C++ container deserialize, Not set it's read length. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1277) Node.js serializes false booleans as null
[ https://issues.apache.org/jira/browse/THRIFT-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-1277: -- Fix Version/s: (was: 0.7) 0.8 Node.js serializes false booleans as null - Key: THRIFT-1277 URL: https://issues.apache.org/jira/browse/THRIFT-1277 Project: Thrift Issue Type: Bug Components: JavaScript - Compiler Affects Versions: 0.7 Reporter: Hans Duedal Labels: compiler, node, nodejs Fix For: 0.8 Attachments: nodejs_compiler_false_bools.patch, nodejs_compiler_false_bools_loose.patch When serializing boolean types, false booleans are serialized as null instead of false. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1267) Node.js can't throw exceptions.
[ https://issues.apache.org/jira/browse/THRIFT-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-1267: -- Fix Version/s: (was: 0.7) 0.8 Node.js can't throw exceptions. Key: THRIFT-1267 URL: https://issues.apache.org/jira/browse/THRIFT-1267 Project: Thrift Issue Type: Improvement Components: JavaScript - Compiler Affects Versions: 0.7 Reporter: Hans Duedal Labels: compiler, javascript, node, nodejs Fix For: 0.8 Attachments: nodejs-exception.patch There is no way as far as I can tell for node.js servers to throw thrift exceptions. I have made a patch to allow it to throw exceptions. It lets the node.js server implementation give params directly to the result object, thereby being able to specify the exception. It doesn't affect normal (non exception) return data. Test case: https://gist.github.com/1151782 Install thrift module npm install thrift, generate thrift thrift --gen js:node test.thrift and run server then client. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1271) thrift: fix missing namespace in generated local
[ https://issues.apache.org/jira/browse/THRIFT-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury closed THRIFT-1271. - Resolution: Fixed Fix Version/s: 0.8 Assignee: Dave Watson I just committed this. thrift: fix missing namespace in generated local -- Key: THRIFT-1271 URL: https://issues.apache.org/jira/browse/THRIFT-1271 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Assignee: Dave Watson Priority: Minor Fix For: 0.8 Attachments: 0003-thrift-fix-missing-namespace-in-generated-local-refl.patch.diff From a0ef2f341fcb613728c6be888082dfe98cde0ad8 Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Thu, 14 Jan 2010 23:02:40 + Subject: [PATCH 03/33] thrift: fix missing namespace in generated local reflection Summary: The TypeSpec definitions for lists, sets, and maps did not prefix the contained type names with the correct namespace. This resulted in a compile failure when defining a list of types from another namespace. Test Plan: Tested building [internal fb thing]'s [internal fb thing] changes. The generated C++ code compiles now. --- compiler/cpp/src/generate/t_cpp_generator.cc |8 1 files changed, 4 insertions(+), 4 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1268) FB cpp updates, jan-apr 2010.
[ https://issues.apache.org/jira/browse/THRIFT-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Watson resolved THRIFT-1268. - Resolution: Incomplete Submitting these separately instead FB cpp updates, jan-apr 2010. - Key: THRIFT-1268 URL: https://issues.apache.org/jira/browse/THRIFT-1268 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Priority: Minor I've got a backlog of about 18 months of thrift patches I'm going to push out as time allows. Around ~200 individual commits. Mostly cpp, but some java/php/python or other. Here's the first couple months of cpp patches. Let me know if you'd rather these come one commit per issue, or some other way, I'm flexible. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1271) thrift: fix missing namespace in generated local
[ https://issues.apache.org/jira/browse/THRIFT-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087877#comment-13087877 ] Hudson commented on THRIFT-1271: Integrated in Thrift #226 (See [https://builds.apache.org/job/Thrift/226/]) THRIFT-1271. cpp: missing namespace in generated local reflection Patch: Adam Simpkins bryanduxbury : http://svn.apache.org/viewvc/?view=revrev=1159734 Files : * /thrift/trunk/compiler/cpp/src/generate/t_cpp_generator.cc thrift: fix missing namespace in generated local -- Key: THRIFT-1271 URL: https://issues.apache.org/jira/browse/THRIFT-1271 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Assignee: Dave Watson Priority: Minor Fix For: 0.8 Attachments: 0003-thrift-fix-missing-namespace-in-generated-local-refl.patch.diff From a0ef2f341fcb613728c6be888082dfe98cde0ad8 Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Thu, 14 Jan 2010 23:02:40 + Subject: [PATCH 03/33] thrift: fix missing namespace in generated local reflection Summary: The TypeSpec definitions for lists, sets, and maps did not prefix the contained type names with the correct namespace. This resulted in a compile failure when defining a list of types from another namespace. Test Plan: Tested building [internal fb thing]'s [internal fb thing] changes. The generated C++ code compiles now. --- compiler/cpp/src/generate/t_cpp_generator.cc |8 1 files changed, 4 insertions(+), 4 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1275) thrift: always prefix namespaces with ::
[ https://issues.apache.org/jira/browse/THRIFT-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087875#comment-13087875 ] Hudson commented on THRIFT-1275: Integrated in Thrift #226 (See [https://builds.apache.org/job/Thrift/226/]) THRIFT-1275. cpp: always prefix namespaces with ' ::' Ensures no accidental namespace clashes. Patch: Adam Simpkins bryanduxbury : http://svn.apache.org/viewvc/?view=revrev=1159729 Files : * /thrift/trunk/compiler/cpp/src/generate/t_cpp_generator.cc thrift: always prefix namespaces with :: - Key: THRIFT-1275 URL: https://issues.apache.org/jira/browse/THRIFT-1275 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Assignee: Dave Watson Priority: Minor Fix For: 0.8 Attachments: 0007-thrift-always-prefix-namespaces-with.patch.diff From d56203d414d23c7858a269e4aa547ee3164832fd Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Thu, 4 Mar 2010 00:53:37 + Subject: [PATCH 07/33] thrift: always prefix namespaces with :: Summary: Thrift always refers to namespaces using their full name. Therefore, it should prefix them with :: to avoid accidentally matching a name defined in one of the current namespaces, rather than at the top-level. For example, if ServiceB is in namespace bar, and inherits from ServiceA in namespace foo, all code emitted for ServiceB now refers to ServiceA as ::foo::ServiceA instead of just foo::ServiceA. This allows the code to compile even if a namespace ::bar::foo also exists. An extra leading whitespace is also emitted, which is needed in cases when the name is used as the first template parameter, so that the emitted code contains :: instead of ::. Test Plan: jsong reported a build problem because of this name lookup error, and this change fixed his build. I also tested building [internal fb thing] and [internal fb thing], and they both built successfully. Tags: thrift --- compiler/cpp/src/generate/t_cpp_generator.cc | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1274) thrift: fail compilation if an unexpected token is
[ https://issues.apache.org/jira/browse/THRIFT-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087876#comment-13087876 ] Hudson commented on THRIFT-1274: Integrated in Thrift #226 (See [https://builds.apache.org/job/Thrift/226/]) THRIFT-1274. compiler: fail compilation if an unexpected token is encountered This patch makes the lexer throw an exception when an unexpected token is encountered, as opposed to the standard behavior of just printing it out and doing nothing. Patch: Adam Simpkins bryanduxbury : http://svn.apache.org/viewvc/?view=revrev=1159733 Files : * /thrift/trunk/compiler/cpp/src/thriftl.ll thrift: fail compilation if an unexpected token is Key: THRIFT-1274 URL: https://issues.apache.org/jira/browse/THRIFT-1274 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Assignee: Dave Watson Priority: Minor Fix For: 0.8 Attachments: 0006-thrift-fail-compilation-if-an-unexpected-token-is-en.patch.diff From e52b015b1c3d3b25ca1c905ea28cab80783a14bc Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Fri, 26 Feb 2010 04:48:55 + Subject: [PATCH 06/33] thrift: fail compilation if an unexpected token is encountered Summary: Currently, if the thrift lexer encounters a token it does not expect, it prints the token it to stdout and continues. (This is the default behavior of flex when a token is unmatched.) This updates thriftl.ll to fail with an error message when it sees an unexpected character. Test Plan: [internal fb thing].thrift contains a stray single-quote. Previously it was getting printed to stdout whenever you compile this file, or anything that includes it. (Furthermore, it is printed out multiple times, since we scan the file twice each time it is included. Compiling [internal fb thing].thrift scans this file 8 times!) Now compiling this file fails with an error, as desired. I'll submit a separate diff to fix [internal fb thing].thrift. --- compiler/cpp/src/thriftl.ll |9 + 1 files changed, 9 insertions(+), 0 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
