[jira] [Assigned] (THRIFT-1286) Modernize the Thrift Ruby Library Dev Environment

2011-08-23 Thread Jake Farrell (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell reassigned THRIFT-1286:


Assignee: Jake Farrell

> Modernize the Thrift Ruby Library Dev Environment
> -
>
> Key: THRIFT-1286
> URL: https://issues.apache.org/jira/browse/THRIFT-1286
> Project: Thrift
>  Issue Type: Improvement
>  Components: Ruby - Library
>Affects Versions: 0.7, 0.8
>Reporter: Scott Gonyea
>Assignee: Jake Farrell
> Fix For: 0.7, 0.8
>
> Attachments: thrift-1286.patch
>
>
> This fixes the ruby libraries environment. This introduces Bundler for 
> managing the development environment, as well as in handling the Gem release 
> process. Echoe is no longer present.
> The end result is that the development environment is easier to setup and 
> easier to reproduce.  Thus, easier to contribute to.
> This structures the spec folder to better follow conventions RSpec.
> The RSpec, as used in the ruby library, was using a mix of RSpec 1 and RSpec 
> 2. This brings everything into the land of RSpec 2.  Some additional cleanup 
> could definitely be done, but this gets us out of the deprecation warnings 
> and other weird behavior-ings.
> To run this in CI, however that is done, you'll effectively want the shell 
> script (or whatever) to look like this:
> which bundle || gem install bundler
> bundle install
> bundle exec rake spec
> Patch should be pulled from:
> https://github.com/sgonyea/thrift/compare/apache:trunk...1fd22f135700c5d32244c63c164610f52b94619b
> or up to the commit:
> https://github.com/sgonyea/thrift/commit/1fd22f135700c5d32244c63c164610f52b94619b

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1286) Modernize the Thrift Ruby Library Dev Environment

2011-08-23 Thread Jake Farrell (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell updated THRIFT-1286:
-

Attachment: thrift-1286.patch

I've been looking into why the rb client changes to rspec2 have been breaking 
the ci builds. The build servers are not on the latest version of ruby gems and 
are running rspec 1.3. The configure script checked for spec to be installed, 
which is available on the ci servers, and then when make check was issued the 
rb makefile was calling rake spec which caused the build to break since the new 
rake file depended on rspec2 not rspec 1.3. To solve this the attached patch 
introduces the bundler gem as a new ruby dependency. This will help ruby client 
builds with a Gemfile for versioning all the clients dependencies and i've 
added in the necessary calls in configure to guarantee that bundler is 
installed before attempting to use any ruby specific build tools (rake, rspec, 
spec, etc.).  

> Modernize the Thrift Ruby Library Dev Environment
> -
>
> Key: THRIFT-1286
> URL: https://issues.apache.org/jira/browse/THRIFT-1286
> Project: Thrift
>  Issue Type: Improvement
>  Components: Ruby - Library
>Affects Versions: 0.7, 0.8
>Reporter: Scott Gonyea
> Fix For: 0.7, 0.8
>
> Attachments: thrift-1286.patch
>
>
> This fixes the ruby libraries environment. This introduces Bundler for 
> managing the development environment, as well as in handling the Gem release 
> process. Echoe is no longer present.
> The end result is that the development environment is easier to setup and 
> easier to reproduce.  Thus, easier to contribute to.
> This structures the spec folder to better follow conventions RSpec.
> The RSpec, as used in the ruby library, was using a mix of RSpec 1 and RSpec 
> 2. This brings everything into the land of RSpec 2.  Some additional cleanup 
> could definitely be done, but this gets us out of the deprecation warnings 
> and other weird behavior-ings.
> To run this in CI, however that is done, you'll effectively want the shell 
> script (or whatever) to look like this:
> which bundle || gem install bundler
> bundle install
> bundle exec rake spec
> Patch should be pulled from:
> https://github.com/sgonyea/thrift/compare/apache:trunk...1fd22f135700c5d32244c63c164610f52b94619b
> or up to the commit:
> https://github.com/sgonyea/thrift/commit/1fd22f135700c5d32244c63c164610f52b94619b

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1286) Modernize the Thrift Ruby Library Dev Environment

2011-08-23 Thread Scott Gonyea (JIRA) 
Modernize the Thrift Ruby Library Dev Environment
-

 Key: THRIFT-1286
 URL: https://issues.apache.org/jira/browse/THRIFT-1286
 Project: Thrift
  Issue Type: Improvement
  Components: Ruby - Library
Affects Versions: 0.7, 0.8
Reporter: Scott Gonyea
 Fix For: 0.8, 0.7


This fixes the ruby libraries environment. This introduces Bundler for managing 
the development environment, as well as in handling the Gem release process. 
Echoe is no longer present.

The end result is that the development environment is easier to setup and 
easier to reproduce.  Thus, easier to contribute to.

This structures the spec folder to better follow conventions RSpec.

The RSpec, as used in the ruby library, was using a mix of RSpec 1 and RSpec 2. 
This brings everything into the land of RSpec 2.  Some additional cleanup could 
definitely be done, but this gets us out of the deprecation warnings and other 
weird behavior-ings.

To run this in CI, however that is done, you'll effectively want the shell 
script (or whatever) to look like this:


which bundle || gem install bundler
bundle install
bundle exec rake spec


Patch should be pulled from:

https://github.com/sgonyea/thrift/compare/apache:trunk...1fd22f135700c5d32244c63c164610f52b94619b

or up to the commit:

https://github.com/sgonyea/thrift/commit/1fd22f135700c5d32244c63c164610f52b94619b



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1282) Upgrade httpclient to 4.1.2 (from 4.0.1)

2011-08-23 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089906#comment-13089906
 ] 

Hudson commented on THRIFT-1282:


Integrated in Thrift #231 (See [https://builds.apache.org/job/Thrift/231/])
THRIFT-1282. java: Upgrade httpclient to 4.1.2 (from 4.0.1) 

Patch: Aravind Srini

bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1160941
Files : 
* /thrift/trunk/lib/java/build.xml
* /thrift/trunk/lib/java/src/org/apache/thrift/transport/THttpClient.java


> Upgrade httpclient to 4.1.2 (from 4.0.1) 
> -
>
> Key: THRIFT-1282
> URL: https://issues.apache.org/jira/browse/THRIFT-1282
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Library
>Affects Versions: 0.7
>Reporter: Aravind Srini
>Assignee: Aravind Srini
> Fix For: 0.8
>
> Attachments: THRIFT-1282.patch
>
>
> httpclient 4.1.x contains a lot of goodies compared to the httpclient 4.0.x 
> codeline, that thrift uses as of now. 
> Upgrading version of httpclient to 4.1.2 .  (And explicitly specifying 
> httpcore to be 4.1.3 , as well, the latter being an emergency fix). 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1280) Thrift: Improve Monitor exception-free interfaces

2011-08-23 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089904#comment-13089904
 ] 

Hudson commented on THRIFT-1280:


Integrated in Thrift #231 (See [https://builds.apache.org/job/Thrift/231/])
THRIFT-1280. cpp: Improve Monitor exception-free interfaces 

Patch: Mark Rabkin

bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1160944
Files : 
* /thrift/trunk/lib/cpp/src/concurrency/Monitor.cpp
* /thrift/trunk/lib/cpp/src/concurrency/Monitor.h


>  Thrift: Improve Monitor exception-free interfaces

> ---
>
> Key: THRIFT-1280
> URL: https://issues.apache.org/jira/browse/THRIFT-1280
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Assignee: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 0090-0010-Thrift-improve-monitor.patch
>
>
> From 768369c358664e2344366a82b80530a6308f3c32 Mon Sep 17 00:00:00 2001
> From: Mark Rabkin 
> Date: Tue, 16 Mar 2010 00:52:07 +
> Subject: [PATCH 09/33] Thrift: Improve Monitor exception-free interfaces
> Summary:
> Cleans up the code for the various variants of Monitor::wait() to reuse
> code cleanly and to present exception-free variants for all types of waiting
> (waiting forever, absolute timestamp, relative timeout).
> The behavior of existing variants should be unchanged
> Test Plan: run more thrift tests if you guys point me to them
> - begin *PUBLIC* platform impact section -
> Bugzilla: #
> - end platform impact -
> Conflicts:
>   lib/cpp/src/concurrency/Monitor.cpp
>   lib/cpp/src/concurrency/Monitor.h
> ---
>  lib/cpp/src/concurrency/Monitor.cpp |   76 
> ++-
>  lib/cpp/src/concurrency/Monitor.h   |   34 +++-
>  2 files changed, 89 insertions(+), 21 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1281) add @generated to the docblock

2011-08-23 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089905#comment-13089905
 ] 

Hudson commented on THRIFT-1281:


Integrated in Thrift #231 (See [https://builds.apache.org/job/Thrift/231/])
THRIFT-1281. compiler: add @generated to the docblock 

Patch: Bill Fumerola

bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1160943
Files : 
* /thrift/trunk/compiler/cpp/src/generate/t_php_generator.cc
* /thrift/trunk/compiler/cpp/src/generate/t_oop_generator.h


>  add @generated to the docblock
> ---
>
> Key: THRIFT-1281
> URL: https://issues.apache.org/jira/browse/THRIFT-1281
> Project: Thrift
>  Issue Type: Improvement
>  Components: Compiler (General)
>Reporter: Dave Watson
>Assignee: bill fumerola
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 0011-add-generated-to-the-docblock.patch
>
>
> From 3c0e31181f1773381eabe9fb1fd69d964cb15c5e Mon Sep 17 00:00:00 2001
> From: Bill Fumerola 
> Date: Wed, 20 Jan 2010 00:34:06 +
> Subject: [PATCH 11/33] add @generated to the docblock
> Summary:
> our static analysis tools can determine what to do based on the presence
> of @generated. epriestley suggested the name to me and based on 30 seconds of 
> googling
> at least Java uses this notation.
> Test Plan:
> generated an autoload and non-autoload thrift file, examined files (c++, 
> java, php), used lint (php) on them
> ---
>  compiler/cpp/src/generate/t_oop_generator.h  |1 +
>  compiler/cpp/src/generate/t_php_generator.cc |6 --
>  2 files changed, 5 insertions(+), 2 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Build failed in Jenkins: Thrift #231

2011-08-23 Thread Apache Jenkins Server 
See 

Changes:

[bryanduxbury] THRIFT-1280. cpp: Improve Monitor exception-free interfaces 

Patch: Mark Rabkin

[bryanduxbury] THRIFT-1281. compiler: add @generated to the docblock 

Patch: Bill Fumerola

[bryanduxbury] THRIFT-1282. java: Upgrade httpclient to 4.1.2 (from 4.0.1) 

Patch: Aravind Srini

--
[...truncated 2107 lines...]
/home/hudson/tools/ant/latest/bin/ant -Dtest.junit.output.format=xml test
Buildfile: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build.xml

generate:

check-gjslint:
 [echo] check if gjslint is available:
 [exec] Execute failed: java.io.IOException: Cannot run program "gjslint": 
java.io.IOException: error=2, No such file or directory

gjslint:

resolve:
 [copy] Copying 36 files to 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/lib

jslint:

lint:

dependencies:

init:
[mkdir] Created dir: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib
[mkdir] Created dir: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/log
[mkdir] Created dir: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/test
[mkdir] Created dir: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/test/log

xvfb:
 [echo] check if Xvfb is available:
 [exec] Result: 1

phantomjs:
 [echo] check if phantomjs is available:
 [exec] Execute failed: java.io.IOException: Cannot run program 
"phantomjs": java.io.IOException: error=2, No such file or directory

compile:
[javac] Compiling 21 source files to 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/test
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] Compiling 1 source file to 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/test
[javac] Note: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/src/test/Httpd.java
 uses or overrides a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/src/test/Httpd.java
 uses unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.

jstest:
  [jar] Building jar: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/jstest.jar

proxy:

jslibs:
  [get] Getting: http://code.jquery.com/jquery-1.5.2.js
  [get] To: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/jquery-1.5.2.js
  [get] Getting: 
http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/equiv.js
  [get] To: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/equiv.js
  [get] Getting: 
http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/QUnitAdapter.js
  [get] To: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/QUnitAdapter.js
  [get] Getting: http://code.jquery.com/qunit/git/qunit.js
  [get] To: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/qunit.js
  [get] Getting: http://code.jquery.com/qunit/git/qunit.css
  [get] To: 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js/lib/qunit.css
 [copy] Copying 1 file to 
/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test/build/js

unittest:

test:

BUILD SUCCESSFUL
Total time: 9 seconds
make[3]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test'
make[2]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/js/test'
Making check in py
make[2]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/py'
/usr/bin/python setup.py build
running build
running build_py
running build_ext
make  check-local
make[3]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/py'
/usr/bin/python setup.py build
running build
running build_py
running build_ext
make[3]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/py'
make[2]: Leaving directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/py'
Making check in erl
make[2]: Entering directory 
`/x1/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl'
./rebar eunit
==> erl (eunit)
Compiled src/thrift_protocol.erl
Compiled src/thrift_transport.erl
Compiled src/thrift_service.erl
Compiled test/smallTest_types.erl
Compiled test/smallService_thrift.erl
Compiled test/inherited_thrift.erl
Compiled test/aService_thrift.erl
Compiled test/stressTest_types.erl
Compiled test/test_client.erl
Compiled test/debugProtoTest_types.erl
Compiled test/yowza_thrift.erl
Compiled test/annotationTest_types.erl
Compiled test/denseLinkingTest_types.erl
Compiled test/secondService_thrift.erl
Compiled test/j

[jira] [Closed] (THRIFT-1280) Thrift: Improve Monitor exception-free interfaces

2011-08-23 Thread Bryan Duxbury (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Duxbury closed THRIFT-1280.
-

   Resolution: Fixed
Fix Version/s: 0.8
 Assignee: Dave Watson

I just committed this.

>  Thrift: Improve Monitor exception-free interfaces

> ---
>
> Key: THRIFT-1280
> URL: https://issues.apache.org/jira/browse/THRIFT-1280
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Assignee: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 0090-0010-Thrift-improve-monitor.patch
>
>
> From 768369c358664e2344366a82b80530a6308f3c32 Mon Sep 17 00:00:00 2001
> From: Mark Rabkin 
> Date: Tue, 16 Mar 2010 00:52:07 +
> Subject: [PATCH 09/33] Thrift: Improve Monitor exception-free interfaces
> Summary:
> Cleans up the code for the various variants of Monitor::wait() to reuse
> code cleanly and to present exception-free variants for all types of waiting
> (waiting forever, absolute timestamp, relative timeout).
> The behavior of existing variants should be unchanged
> Test Plan: run more thrift tests if you guys point me to them
> - begin *PUBLIC* platform impact section -
> Bugzilla: #
> - end platform impact -
> Conflicts:
>   lib/cpp/src/concurrency/Monitor.cpp
>   lib/cpp/src/concurrency/Monitor.h
> ---
>  lib/cpp/src/concurrency/Monitor.cpp |   76 
> ++-
>  lib/cpp/src/concurrency/Monitor.h   |   34 +++-
>  2 files changed, 89 insertions(+), 21 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1281) add @generated to the docblock

2011-08-23 Thread Bryan Duxbury (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Duxbury updated THRIFT-1281:
--

Component/s: (was: C++ - Library)
 Compiler (General)
   Assignee: bill fumerola
Summary:  add @generated to the docblock  (was:  add @generated to the 
docblock
)

>  add @generated to the docblock
> ---
>
> Key: THRIFT-1281
> URL: https://issues.apache.org/jira/browse/THRIFT-1281
> Project: Thrift
>  Issue Type: Improvement
>  Components: Compiler (General)
>Reporter: Dave Watson
>Assignee: bill fumerola
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 0011-add-generated-to-the-docblock.patch
>
>
> From 3c0e31181f1773381eabe9fb1fd69d964cb15c5e Mon Sep 17 00:00:00 2001
> From: Bill Fumerola 
> Date: Wed, 20 Jan 2010 00:34:06 +
> Subject: [PATCH 11/33] add @generated to the docblock
> Summary:
> our static analysis tools can determine what to do based on the presence
> of @generated. epriestley suggested the name to me and based on 30 seconds of 
> googling
> at least Java uses this notation.
> Test Plan:
> generated an autoload and non-autoload thrift file, examined files (c++, 
> java, php), used lint (php) on them
> ---
>  compiler/cpp/src/generate/t_oop_generator.h  |1 +
>  compiler/cpp/src/generate/t_php_generator.cc |6 --
>  2 files changed, 5 insertions(+), 2 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1281) add @generated to the docblock

2011-08-23 Thread Bryan Duxbury (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Duxbury closed THRIFT-1281.
-

   Resolution: Fixed
Fix Version/s: 0.8

I just committed this.

>  add @generated to the docblock
> ---
>
> Key: THRIFT-1281
> URL: https://issues.apache.org/jira/browse/THRIFT-1281
> Project: Thrift
>  Issue Type: Improvement
>  Components: Compiler (General)
>Reporter: Dave Watson
>Assignee: bill fumerola
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 0011-add-generated-to-the-docblock.patch
>
>
> From 3c0e31181f1773381eabe9fb1fd69d964cb15c5e Mon Sep 17 00:00:00 2001
> From: Bill Fumerola 
> Date: Wed, 20 Jan 2010 00:34:06 +
> Subject: [PATCH 11/33] add @generated to the docblock
> Summary:
> our static analysis tools can determine what to do based on the presence
> of @generated. epriestley suggested the name to me and based on 30 seconds of 
> googling
> at least Java uses this notation.
> Test Plan:
> generated an autoload and non-autoload thrift file, examined files (c++, 
> java, php), used lint (php) on them
> ---
>  compiler/cpp/src/generate/t_oop_generator.h  |1 +
>  compiler/cpp/src/generate/t_php_generator.cc |6 --
>  2 files changed, 5 insertions(+), 2 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1282) Upgrade httpclient to 4.1.2 (from 4.0.1)

2011-08-23 Thread Bryan Duxbury (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Duxbury closed THRIFT-1282.
-

Resolution: Fixed
  Assignee: Aravind Srini

I just committed this.

> Upgrade httpclient to 4.1.2 (from 4.0.1) 
> -
>
> Key: THRIFT-1282
> URL: https://issues.apache.org/jira/browse/THRIFT-1282
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Library
>Affects Versions: 0.7
>Reporter: Aravind Srini
>Assignee: Aravind Srini
> Fix For: 0.8
>
> Attachments: THRIFT-1282.patch
>
>
> httpclient 4.1.x contains a lot of goodies compared to the httpclient 4.0.x 
> codeline, that thrift uses as of now. 
> Upgrading version of httpclient to 4.1.2 .  (And explicitly specifying 
> httpcore to be 4.1.3 , as well, the latter being an emergency fix). 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1283) thrift: wrap t_cpp_generator::generate_process_function() to 80

2011-08-23 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089874#comment-13089874
 ] 

Hudson commented on THRIFT-1283:


Integrated in Thrift #230 (See [https://builds.apache.org/job/Thrift/230/])
THRIFT-1283. cpp: wrap t_cpp_generator::generate_process_function() to 80

Adjust the line width to 80 for generated CPP classes.

Patch: Adam Simpkins

bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1160931
Files : 
* /thrift/trunk/compiler/cpp/src/generate/t_cpp_generator.cc


>  thrift: wrap t_cpp_generator::generate_process_function() to 80
> 
>
> Key: THRIFT-1283
> URL: https://issues.apache.org/jira/browse/THRIFT-1283
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Assignee: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 
> 0012-thrift-wrap-t_cpp_generator-generate_process_functio.patch
>
>
> From 91243efb4193412d54ccbd85ac991e035f80fa53 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Sat, 3 Apr 2010 02:49:43 +
> Subject: [PATCH 12/33] thrift: wrap
>  t_cpp_generator::generate_process_function() to 80
>  chars
> Summary:
> I'm planning on making some other changes to this function, and it will
> be easier to review them if the line-wrapping fixes are done separately.
> Test Plan:
> Built [three facebook projects] both with and without
> these changes, and made sure the resulting files were identical.
> Revert Plan:
> OK
> Conflicts:
>   compiler/cpp/src/generate/t_cpp_generator.cc
> ---
>  compiler/cpp/src/generate/t_cpp_generator.cc |  149 +
>  1 files changed, 101 insertions(+), 48 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1284) thrift: fix processor inheritance

2011-08-23 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089873#comment-13089873
 ] 

Hudson commented on THRIFT-1284:


Integrated in Thrift #230 (See [https://builds.apache.org/job/Thrift/230/])
THRIFT-1284. cpp: fix processor inheritance 

Don't make processors that have a proper parent class also inherit from 
TProcessor.

Patch: Adam Simpkins

bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1160933
Files : 
* /thrift/trunk/compiler/cpp/src/generate/t_cpp_generator.cc


>  thrift: fix processor inheritance

> ---
>
> Key: THRIFT-1284
> URL: https://issues.apache.org/jira/browse/THRIFT-1284
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Assignee: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 0013-thrift-fix-processor-inheritance.patch
>
>
> From fa7a7d7fb25f13e7f375f21b91ed119d84cebc04 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Sat, 3 Apr 2010 02:49:45 +
> Subject: [PATCH 13/33] thrift: fix processor inheritance
> Summary:
> I don't see any reason why all of the generated processor classes
> multiply inherit from TProcessor via all of their parent classes.
> This eliminates the virtual inheritance by changing the code so that
> only the first class in the heirarchy inherits from TProcessor or
> TAsyncProcessor.
> As part of this change, we now have to explicitly write
> "this->eventHandler_" instead of just "eventHandler_" so that the
> compiler can tell that this is an inherited member variable when we are
> generating template code.
> Test Plan:
> Built [internal fb thing] and a few other projects, and everything compiled 
> fine.
> I haven't done much actual RPC testing.
> Revert Plan:
> OK
> Conflicts:
>   compiler/cpp/src/generate/t_cpp_generator.cc
> ---
>  compiler/cpp/src/generate/t_cpp_generator.cc |   91 
> +-
>  1 files changed, 46 insertions(+), 45 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Build failed in Jenkins: Thrift #230

2011-08-23 Thread Apache Jenkins Server 
See 

Changes:

[bryanduxbury] THRIFT-1284. cpp: fix processor inheritance 

Don't make processors that have a proper parent class also inherit from 
TProcessor.

Patch: Adam Simpkins

[bryanduxbury] THRIFT-1283. cpp: wrap 
t_cpp_generator::generate_process_function() to 80

Adjust the line width to 80 for generated CPP classes.

Patch: Adam Simpkins

--
[...truncated 2085 lines...]
make[2]: Leaving directory 
`
Making check in js/test
make[2]: Entering directory 
`
make  check-local
make[3]: Entering directory 
`
/home/hudson/tools/ant/latest/bin/ant -Dtest.junit.output.format=xml test
Buildfile: 


generate:

check-gjslint:
 [echo] check if gjslint is available:
 [exec] Execute failed: java.io.IOException: Cannot run program "gjslint": 
java.io.IOException: error=2, No such file or directory

gjslint:

resolve:
 [copy] Copying 36 files to 


jslint:

lint:

dependencies:

init:
[mkdir] Created dir: 

[mkdir] Created dir: 

[mkdir] Created dir: 

[mkdir] Created dir: 


xvfb:
 [echo] check if Xvfb is available:
 [exec] Execute failed: java.io.IOException: Cannot run program "Xvfb": 
java.io.IOException: error=2, No such file or directory

phantomjs:

compile:
[javac] Compiling 21 source files to 

[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] Compiling 1 source file to 

[javac] Note: 

 uses unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.

jstest:
  [jar] Building jar: 


proxy:

jslibs:
  [get] Getting: http://code.jquery.com/jquery-1.5.2.js
  [get] To: 

  [get] Getting: 
http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/equiv.js
  [get] To: 

  [get] Getting: 
http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/QUnitAdapter.js
  [get] To: 

  [get] Getting: http://code.jquery.com/qunit/git/qunit.js
  [get] To: 

  [get] Getting: http://code.jquery.com/qunit/git/qunit.css
  [get] To: 

 [copy] Copying 1 file to 


unittest:

test:

BUILD SUCCESSFUL
Total time: 9 seconds
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in py
make[2]: Entering directory 
`
/usr/bin/python setup.py build
running build
running build_py
running build_ext
make  check-local
make[3]: Entering directory 
`
/usr/bin/python setup.py build
running build
running build_py
running build_ext
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in erl
make[2]: Entering directory 
`
./rebar eunit
==> erl (eunit)
Compiled src/thrift_transport.erl
Compiled src/thrift_protocol.erl
Compiled src/thrift_service.erl
Compiled test/smallTest_types.erl
Compiled test/yowza_thrift.erl
Compiled test/test_disklog.erl
Compiled test/aService_thrift.erl
Compiled test/test_membuffer.erl
Compiled test/service_thrift.erl
Compiled test/stress_server.erl
Compiled test/thriftTest_thrift.erl
Compiled test/secondService_thrift.erl
Compiled test/test_thrift_1151.erl
Compile

[jira] [Closed] (THRIFT-1284) thrift: fix processor inheritance

2011-08-23 Thread Bryan Duxbury (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Duxbury closed THRIFT-1284.
-

   Resolution: Fixed
Fix Version/s: 0.8
 Assignee: Dave Watson

I just committed this.

>  thrift: fix processor inheritance

> ---
>
> Key: THRIFT-1284
> URL: https://issues.apache.org/jira/browse/THRIFT-1284
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Assignee: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 0013-thrift-fix-processor-inheritance.patch
>
>
> From fa7a7d7fb25f13e7f375f21b91ed119d84cebc04 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Sat, 3 Apr 2010 02:49:45 +
> Subject: [PATCH 13/33] thrift: fix processor inheritance
> Summary:
> I don't see any reason why all of the generated processor classes
> multiply inherit from TProcessor via all of their parent classes.
> This eliminates the virtual inheritance by changing the code so that
> only the first class in the heirarchy inherits from TProcessor or
> TAsyncProcessor.
> As part of this change, we now have to explicitly write
> "this->eventHandler_" instead of just "eventHandler_" so that the
> compiler can tell that this is an inherited member variable when we are
> generating template code.
> Test Plan:
> Built [internal fb thing] and a few other projects, and everything compiled 
> fine.
> I haven't done much actual RPC testing.
> Revert Plan:
> OK
> Conflicts:
>   compiler/cpp/src/generate/t_cpp_generator.cc
> ---
>  compiler/cpp/src/generate/t_cpp_generator.cc |   91 
> +-
>  1 files changed, 46 insertions(+), 45 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1283) thrift: wrap t_cpp_generator::generate_process_function() to 80

2011-08-23 Thread Bryan Duxbury (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Duxbury closed THRIFT-1283.
-

   Resolution: Fixed
Fix Version/s: 0.8
 Assignee: Dave Watson

I just committed this.

>  thrift: wrap t_cpp_generator::generate_process_function() to 80
> 
>
> Key: THRIFT-1283
> URL: https://issues.apache.org/jira/browse/THRIFT-1283
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Assignee: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 
> 0012-thrift-wrap-t_cpp_generator-generate_process_functio.patch
>
>
> From 91243efb4193412d54ccbd85ac991e035f80fa53 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Sat, 3 Apr 2010 02:49:43 +
> Subject: [PATCH 12/33] thrift: wrap
>  t_cpp_generator::generate_process_function() to 80
>  chars
> Summary:
> I'm planning on making some other changes to this function, and it will
> be easier to review them if the line-wrapping fixes are done separately.
> Test Plan:
> Built [three facebook projects] both with and without
> these changes, and made sure the resulting files were identical.
> Revert Plan:
> OK
> Conflicts:
>   compiler/cpp/src/generate/t_cpp_generator.cc
> ---
>  compiler/cpp/src/generate/t_cpp_generator.cc |  149 +
>  1 files changed, 101 insertions(+), 48 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (THRIFT-369) sets and maps break equality

2011-08-23 Thread Ilya Maykov (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ilya Maykov reassigned THRIFT-369:
--

Assignee: Ilya Maykov

> sets and maps break equality
> 
>
> Key: THRIFT-369
> URL: https://issues.apache.org/jira/browse/THRIFT-369
> Project: Thrift
>  Issue Type: Bug
>  Components: Ruby - Library
>Reporter: Bryan Duxbury
>Assignee: Ilya Maykov
>Priority: Minor
>
> I've found that two structs that have value-equivalent sets or maps as values 
> for some reason cause struct's == to fail. This is inconsistent with other 
> languages.
> For example, this struct: 
> {code}
> struct {
>   set_byte_map: 2} }>,
>   map_byte_map: { {1=>1} => 1 }
> }
> {code}
> created twice independently will not be ==.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1123) Patch to compile Thrift server and client for vc++ 9.0 and 10.0

2011-08-23 Thread Deepak Muley (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089752#comment-13089752
 ] 

Deepak Muley commented on THRIFT-1123:
--

Has anybody faced following issue while using the windows port:

When I compile the thrift file in x64 config, server using this file compile 
properly but when in x86 config, I have to explicitly add following code in 
autogenerated code to be able to make it compilable 

class MyServerProcessor : virtual public ::apache::thrift::TProcessor, public 
facebook::fb303::FacebookServiceProcessor {

...
  bool process(boost::shared_ptr<::apache::thrift::protocol::TProtocol> in,
  boost::shared_ptr<::apache::thrift::protocol::TProtocol> out,
  void* connectionContext){
  return process(in,out);
  }
...

else I get following error

 error C2259: 'MyServerProcessor' : cannot instantiate abstract class

when i call as follows:

boost::shared_ptr processor(new MyServerProcessor(handler));


Why does it happen only for x86 and not for x64? and how to fix it at the root 
else this is a manual steps for me all the time. Tried to compile the same with 
0.6.1 windows thrift compiler as well but same behavior.

> Patch to compile Thrift server and client for vc++ 9.0 and 10.0
> ---
>
> Key: THRIFT-1123
> URL: https://issues.apache.org/jira/browse/THRIFT-1123
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
> Environment: Windows XP 32bit, vc++ 9.0, 10.0
>Reporter: Dragan Okiljevic
>Priority: Trivial
> Fix For: 0.8
>
> Attachments: 
> additional_thrift_cpp_visual_studio_2008_and_2010_endians_patch(concerning_ticket_1123_and_possibly_1031_patches).patch,
>  thrift_msvc_client_and_server.patch
>
>
> Extension of THRIFT-1031 patch published by James Dickson
> This patch is intended to provide Thrift C/C++ functionality on WIN32 
> platforms.
> The implementation is built on top of the patch "Patch to compile Thrift for 
> vc++ 9.0 and 10.0" by James Dickson published as THRIFT-1031. I just used 
> this code and ported more Thrieft C/C++ to WIN32 and added them to original 
> VC projects created in THRIFT-1031.
> I express my gratitude to Mr. Dickson as his post gave me the roadmap how to 
> do the additional changes, that I hope, would be useful for the rest of the 
> community too.
> Besides client capabilities enabled in THRIFT-1031, the library can now be 
> used for building Thrift servers and using concurrency features. The dir/file 
> structure from THRIFT-1031 and usage of Config.h header for providing support 
> for both WIN32 and *NIX remains.
> The implementation was tested briefly on MSVC2008, MSVC2010 and Ubuntu, 
> communicating between C/C++ clients and servers and Java clients and servers. 
> As the author needs all of this functionality for one of his projects, the 
> testing and debugging will continue.
> Revision 1086435 from March, 28, 2011. was used for development and creation 
> of patch, but it should be possible to apply it on current trunk revision as 
> long as no changes are made to patched files in trunk.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1278) javadoc warnings - compilation

2011-08-23 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089742#comment-13089742
 ] 

Hudson commented on THRIFT-1278:


Integrated in Thrift #229 (See [https://builds.apache.org/job/Thrift/229/])
THRIFT-1278 javadoc warnings - compilation
Patch: Aravind Srini

roger : http://svn.apache.org/viewvc/?view=rev&rev=1160883
Files : 
* /thrift/trunk/lib/java/src/org/apache/thrift/transport/TFileTransport.java
* 
/thrift/trunk/lib/java/src/org/apache/thrift/transport/TSSLTransportFactory.java
* /thrift/trunk/lib/java/src/org/apache/thrift/TServiceClient.java
* /thrift/trunk/lib/java/src/org/apache/thrift/TUnion.java
* /thrift/trunk/lib/java/src/org/apache/thrift/transport/TTransport.java
* /thrift/trunk/lib/java/src/org/apache/thrift/protocol/TTupleProtocol.java
* /thrift/trunk/lib/java/src/org/apache/thrift/transport/TFileProcessor.java
* /thrift/trunk/lib/java/src/org/apache/thrift/TServiceClientFactory.java
* /thrift/trunk/lib/java/src/org/apache/thrift/async/TAsyncClient.java


> javadoc warnings - compilation 
> ---
>
> Key: THRIFT-1278
> URL: https://issues.apache.org/jira/browse/THRIFT-1278
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Library
>Affects Versions: 0.7
>Reporter: Aravind Srini
>Assignee: Aravind Srini
> Fix For: 0.8
>
> Attachments: THRIFT-1278.patch
>
>
> The following javadoc warnings were encountered when building 0.7.0 from 
> scratch. 
> Building tree for all the packages and classes...
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/TServiceClient.java:49:
>  warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/TServiceClient.java:57:
>  warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/TServiceClientFactory.java:35:
>  warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/TServiceClientFactory.java:44:
>  warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/TUnion.java:184: 
> warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/async/TAsyncClient.java:71:
>  warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/async/TAsyncClient.java:63:
>  warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/transport/TTransport.java:132:
>  warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/transport/TTransport.java:141:
>  warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/transport/TTransport.java:150:
>  warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/transport/TFileProcessor.java:100:
>  warning - @param argument "lastChunkNum" is not a parameter name.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/transport/TFileTransport.java:424:
>  warning - @param argument "inputFile_" is not a parameter name.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/transport/TSSLTransportFactory.java:328:
>  warning - @param argument "auth" is not a parameter name.
> It would be nice to be devoid of them. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Build failed in Jenkins: Thrift #229

2011-08-23 Thread Apache Jenkins Server 
See 

Changes:

[roger] THRIFT-1278 javadoc warnings - compilation
Patch: Aravind Srini

--
[...truncated 2095 lines...]
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in js/test
make[2]: Entering directory 
`
make  check-local
make[3]: Entering directory 
`
/home/hudson/tools/ant/latest/bin/ant -Dtest.junit.output.format=xml test
Buildfile: 


generate:

check-gjslint:
 [echo] check if gjslint is available:
 [exec] Execute failed: java.io.IOException: Cannot run program "gjslint": 
java.io.IOException: error=2, No such file or directory

gjslint:

resolve:
 [copy] Copying 36 files to 


jslint:

lint:

dependencies:

init:
[mkdir] Created dir: 

[mkdir] Created dir: 

[mkdir] Created dir: 

[mkdir] Created dir: 


xvfb:
 [echo] check if Xvfb is available:
 [exec] Execute failed: java.io.IOException: Cannot run program "Xvfb": 
java.io.IOException: error=2, No such file or directory

phantomjs:

compile:
[javac] Compiling 21 source files to 

[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] Compiling 1 source file to 

[javac] Note: 

 uses unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.

jstest:
  [jar] Building jar: 


proxy:

jslibs:
  [get] Getting: http://code.jquery.com/jquery-1.5.2.js
  [get] To: 

  [get] Getting: 
http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/equiv.js
  [get] To: 

  [get] Getting: 
http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/QUnitAdapter.js
  [get] To: 

  [get] Getting: http://code.jquery.com/qunit/git/qunit.js
  [get] To: 

  [get] Getting: http://code.jquery.com/qunit/git/qunit.css
  [get] To: 

 [copy] Copying 1 file to 


unittest:

test:

BUILD SUCCESSFUL
Total time: 10 seconds
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in py
make[2]: Entering directory 
`
/usr/bin/python setup.py build
running build
running build_py
running build_ext
make  check-local
make[3]: Entering directory 
`
/usr/bin/python setup.py build
running build
running build_py
running build_ext
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in erl
make[2]: Entering directory 
`
./rebar eunit
==> erl (eunit)
Compiled src/thrift_transport.erl
Compiled src/thrift_protocol.erl
Compiled src/thrift_service.erl
Compiled test/smallTest_types.erl
Compiled test/yowza_thrift.erl
Compiled test/test_disklog.erl
Compiled test/aService_thrift.erl
Compiled test/test_membuffer.erl
Compiled test/service_thrift.erl
Compiled test/thriftTest_thrift.erl
Compiled test/stress_server.erl
Compiled test/secondService_thrift.erl
Compiled test/test_thrift_1151.erl
Compiled test/thriftTest_types.erl
Compiled test/serviceForExceptionWithAMap_thrift.erl
Compiled test/test_server.erl
Compiled test/debugProtoTest_types.erl
Compiled test/smallService

[jira] [Commented] (THRIFT-1267) Node.js can't throw exceptions.

2011-08-23 Thread Wade Simmons (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089730#comment-13089730
 ] 

Wade Simmons commented on THRIFT-1267:
--

It looks like Russell Haering has a good example of how this should look:

https://gist.github.com/1098395

I'll start working on a patch for this next week if no-one jumps in.

> Node.js can't throw exceptions. 
> 
>
> Key: THRIFT-1267
> URL: https://issues.apache.org/jira/browse/THRIFT-1267
> Project: Thrift
>  Issue Type: Improvement
>  Components: JavaScript - Compiler
>Affects Versions: 0.7
>Reporter: Hans Duedal
>  Labels: compiler, javascript, node, nodejs
> Fix For: 0.8
>
> Attachments: nodejs-exception.patch
>
>
> There is no way as far as I can tell for node.js servers to throw thrift 
> exceptions.
> I have made a patch to allow it to throw exceptions. It lets the node.js 
> server implementation give params directly to the result object, thereby 
> being able to specify the exception. It doesn't affect normal (non exception) 
> return data.
> Test case: https://gist.github.com/1151782
> Install thrift module "npm install thrift", generate thrift "thrift --gen 
> js:node test.thrift" and run server then client.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (THRIFT-1278) javadoc warnings - compilation

2011-08-23 Thread Roger Meier (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roger Meier resolved THRIFT-1278.
-

Resolution: Fixed
  Assignee: Aravind Srini

Thanks Aravind, committed!

> javadoc warnings - compilation 
> ---
>
> Key: THRIFT-1278
> URL: https://issues.apache.org/jira/browse/THRIFT-1278
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Library
>Affects Versions: 0.7
>Reporter: Aravind Srini
>Assignee: Aravind Srini
> Fix For: 0.8
>
> Attachments: THRIFT-1278.patch
>
>
> The following javadoc warnings were encountered when building 0.7.0 from 
> scratch. 
> Building tree for all the packages and classes...
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/TServiceClient.java:49:
>  warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/TServiceClient.java:57:
>  warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/TServiceClientFactory.java:35:
>  warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/TServiceClientFactory.java:44:
>  warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/TUnion.java:184: 
> warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/async/TAsyncClient.java:71:
>  warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/async/TAsyncClient.java:63:
>  warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/transport/TTransport.java:132:
>  warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/transport/TTransport.java:141:
>  warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/transport/TTransport.java:150:
>  warning - @return tag has no arguments.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/transport/TFileProcessor.java:100:
>  warning - @param argument "lastChunkNum" is not a parameter name.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/transport/TFileTransport.java:424:
>  warning - @param argument "inputFile_" is not a parameter name.
>   [javadoc] 
> ~/workspace/thrift-0.7.0/lib/java/src/org/apache/thrift/transport/TSSLTransportFactory.java:328:
>  warning - @param argument "auth" is not a parameter name.
> It would be nice to be devoid of them. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1267) Node.js can't throw exceptions.

2011-08-23 Thread Paul Querna (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089710#comment-13089710
 ] 

Paul Querna commented on THRIFT-1267:
-

+1 to incompatible change to use the node.js style of callback(err, result);  
All of our existing code uses this style, and it is essential when dealing with 
async handlers in a service.

> Node.js can't throw exceptions. 
> 
>
> Key: THRIFT-1267
> URL: https://issues.apache.org/jira/browse/THRIFT-1267
> Project: Thrift
>  Issue Type: Improvement
>  Components: JavaScript - Compiler
>Affects Versions: 0.7
>Reporter: Hans Duedal
>  Labels: compiler, javascript, node, nodejs
> Fix For: 0.8
>
> Attachments: nodejs-exception.patch
>
>
> There is no way as far as I can tell for node.js servers to throw thrift 
> exceptions.
> I have made a patch to allow it to throw exceptions. It lets the node.js 
> server implementation give params directly to the result object, thereby 
> being able to specify the exception. It doesn't affect normal (non exception) 
> return data.
> Test case: https://gist.github.com/1151782
> Install thrift module "npm install thrift", generate thrift "thrift --gen 
> js:node test.thrift" and run server then client.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1285) Stable 0.7.0 Windows compiler exe available on the webside is not the good one

2011-08-23 Thread JIRA 
Stable 0.7.0 Windows compiler exe available on the webside is not the good one
--

 Key: THRIFT-1285
 URL: https://issues.apache.org/jira/browse/THRIFT-1285
 Project: Thrift
  Issue Type: Bug
  Components: Website
Affects Versions: 0.7
Reporter: Raphaël Bartement
Priority: Blocker


On the main Thrift web site, in [the download 
section|http://thrift.apache.org/download/], the Release link to "Thrift 
compiler for Windows" do not lead to the tagged 0.7.0 stable release version of 
the compiler.

I think this is a trunk snapshot binary instead.


Running {{monospacedthrift-0.7.0.exe -version}}
returns {{Thrift version 0.7.0-dev}}.


Before, I tested Java generation.
With this file:
{code:title=Test.thrift}
namespace java org.test
struct Foo {}
{code} 
I get:
{code:java|:title=Foo.java} 
/**
 * Autogenerated by Thrift Compiler (0.7.0-dev)
 *
 * DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
 */
package org.test;

import org.apache.thrift.scheme.IScheme;
import org.apache.thrift.scheme.SchemeFactory;
import org.apache.thrift.scheme.StandardScheme;
...
{code}
I checked in subversion, the "Scheme"-related code has been introduced into the 
trunk, but is not part of 0.7.x branch and 0.7.0 tag.
Thus, the generator code won't compile with the 0.7.0 java lib.


May you check this binary?
I'd like to use the official stable one.
Thanks.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1284) thrift: fix processor inheritance

2011-08-23 Thread Dave Watson (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1284:


Attachment: 0013-thrift-fix-processor-inheritance.patch

>  thrift: fix processor inheritance

> ---
>
> Key: THRIFT-1284
> URL: https://issues.apache.org/jira/browse/THRIFT-1284
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: 0013-thrift-fix-processor-inheritance.patch
>
>
> From fa7a7d7fb25f13e7f375f21b91ed119d84cebc04 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Sat, 3 Apr 2010 02:49:45 +
> Subject: [PATCH 13/33] thrift: fix processor inheritance
> Summary:
> I don't see any reason why all of the generated processor classes
> multiply inherit from TProcessor via all of their parent classes.
> This eliminates the virtual inheritance by changing the code so that
> only the first class in the heirarchy inherits from TProcessor or
> TAsyncProcessor.
> As part of this change, we now have to explicitly write
> "this->eventHandler_" instead of just "eventHandler_" so that the
> compiler can tell that this is an inherited member variable when we are
> generating template code.
> Test Plan:
> Built [internal fb thing] and a few other projects, and everything compiled 
> fine.
> I haven't done much actual RPC testing.
> Revert Plan:
> OK
> Conflicts:
>   compiler/cpp/src/generate/t_cpp_generator.cc
> ---
>  compiler/cpp/src/generate/t_cpp_generator.cc |   91 
> +-
>  1 files changed, 46 insertions(+), 45 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1283) thrift: wrap t_cpp_generator::generate_process_function() to 80

2011-08-23 Thread Dave Watson (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1283:


Attachment: 0012-thrift-wrap-t_cpp_generator-generate_process_functio.patch

>  thrift: wrap t_cpp_generator::generate_process_function() to 80
> 
>
> Key: THRIFT-1283
> URL: https://issues.apache.org/jira/browse/THRIFT-1283
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: 
> 0012-thrift-wrap-t_cpp_generator-generate_process_functio.patch
>
>
> From 91243efb4193412d54ccbd85ac991e035f80fa53 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Sat, 3 Apr 2010 02:49:43 +
> Subject: [PATCH 12/33] thrift: wrap
>  t_cpp_generator::generate_process_function() to 80
>  chars
> Summary:
> I'm planning on making some other changes to this function, and it will
> be easier to review them if the line-wrapping fixes are done separately.
> Test Plan:
> Built [three facebook projects] both with and without
> these changes, and made sure the resulting files were identical.
> Revert Plan:
> OK
> Conflicts:
>   compiler/cpp/src/generate/t_cpp_generator.cc
> ---
>  compiler/cpp/src/generate/t_cpp_generator.cc |  149 +
>  1 files changed, 101 insertions(+), 48 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1284) thrift: fix processor inheritance

2011-08-23 Thread Dave Watson (JIRA) 
 thrift: fix processor inheritance

---

 Key: THRIFT-1284
 URL: https://issues.apache.org/jira/browse/THRIFT-1284
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Reporter: Dave Watson
Priority: Minor


>From fa7a7d7fb25f13e7f375f21b91ed119d84cebc04 Mon Sep 17 00:00:00 2001
From: Adam Simpkins 
Date: Sat, 3 Apr 2010 02:49:45 +
Subject: [PATCH 13/33] thrift: fix processor inheritance

Summary:
I don't see any reason why all of the generated processor classes
multiply inherit from TProcessor via all of their parent classes.
This eliminates the virtual inheritance by changing the code so that
only the first class in the heirarchy inherits from TProcessor or
TAsyncProcessor.

As part of this change, we now have to explicitly write
"this->eventHandler_" instead of just "eventHandler_" so that the
compiler can tell that this is an inherited member variable when we are
generating template code.

Test Plan:
Built [internal fb thing] and a few other projects, and everything compiled 
fine.
I haven't done much actual RPC testing.

Revert Plan:
OK


Conflicts:

compiler/cpp/src/generate/t_cpp_generator.cc
---
 compiler/cpp/src/generate/t_cpp_generator.cc |   91 +-
 1 files changed, 46 insertions(+), 45 deletions(-)



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1283) thrift: wrap t_cpp_generator::generate_process_function() to 80

2011-08-23 Thread Dave Watson (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1283:


Patch Info: [Patch Available]
   Summary:  thrift: wrap t_cpp_generator::generate_process_function() to 
80  (was:  thrift: wrap
)

>  thrift: wrap t_cpp_generator::generate_process_function() to 80
> 
>
> Key: THRIFT-1283
> URL: https://issues.apache.org/jira/browse/THRIFT-1283
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
>
> From 91243efb4193412d54ccbd85ac991e035f80fa53 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Sat, 3 Apr 2010 02:49:43 +
> Subject: [PATCH 12/33] thrift: wrap
>  t_cpp_generator::generate_process_function() to 80
>  chars
> Summary:
> I'm planning on making some other changes to this function, and it will
> be easier to review them if the line-wrapping fixes are done separately.
> Test Plan:
> Built [three facebook projects] both with and without
> these changes, and made sure the resulting files were identical.
> Revert Plan:
> OK
> Conflicts:
>   compiler/cpp/src/generate/t_cpp_generator.cc
> ---
>  compiler/cpp/src/generate/t_cpp_generator.cc |  149 +
>  1 files changed, 101 insertions(+), 48 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1283) thrift: wrap

2011-08-23 Thread Dave Watson (JIRA) 
 thrift: wrap

--

 Key: THRIFT-1283
 URL: https://issues.apache.org/jira/browse/THRIFT-1283
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Reporter: Dave Watson
Priority: Minor


>From 91243efb4193412d54ccbd85ac991e035f80fa53 Mon Sep 17 00:00:00 2001
From: Adam Simpkins 
Date: Sat, 3 Apr 2010 02:49:43 +
Subject: [PATCH 12/33] thrift: wrap
 t_cpp_generator::generate_process_function() to 80
 chars

Summary:
I'm planning on making some other changes to this function, and it will
be easier to review them if the line-wrapping fixes are done separately.

Test Plan:
Built [three facebook projects] both with and without
these changes, and made sure the resulting files were identical.

Revert Plan:
OK


Conflicts:

compiler/cpp/src/generate/t_cpp_generator.cc
---
 compiler/cpp/src/generate/t_cpp_generator.cc |  149 +
 1 files changed, 101 insertions(+), 48 deletions(-)



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1282) Upgrade httpclient to 4.1.2 (from 4.0.1)

2011-08-23 Thread Aravind Srini (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aravind Srini updated THRIFT-1282:
--

Summary: Upgrade httpclient to 4.1.2 (from 4.0.1)   (was: Upgrade 
httpclient to 4.1.2 (from 4.0.1, as it is now ) )

> Upgrade httpclient to 4.1.2 (from 4.0.1) 
> -
>
> Key: THRIFT-1282
> URL: https://issues.apache.org/jira/browse/THRIFT-1282
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Library
>Affects Versions: 0.7
>Reporter: Aravind Srini
> Fix For: 0.8
>
> Attachments: THRIFT-1282.patch
>
>
> httpclient 4.1.x contains a lot of goodies compared to the httpclient 4.0.x 
> codeline, that thrift uses as of now. 
> Upgrading version of httpclient to 4.1.2 .  (And explicitly specifying 
> httpcore to be 4.1.3 , as well, the latter being an emergency fix). 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira