[jira] [Commented] (THRIFT-1334) Add more info to IllegalStateException

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100982#comment-13100982
 ] 

Hudson commented on THRIFT-1334:


Integrated in Thrift #254 (See [https://builds.apache.org/job/Thrift/254/])
Thrift-1334: Add more info to IllegalStateException
Client cpp
Patch: Dave Watson

Add support for the message field in IllegalStateException


>  Add more info to IllegalStateException

> 
>
> Key: THRIFT-1334
> URL: https://issues.apache.org/jira/browse/THRIFT-1334
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 0030-Add-more-info-to-IllegalStateException.patch
>
>
> From bb3ebfa1f6483e6cf6ca3e264b24505194155842 Mon Sep 17 00:00:00 2001
> From: Joshua Redstone 
> Date: Tue, 20 Apr 2010 22:56:15 +
> Subject: [PATCH 30/33] Add more info to IllegalStateException
> Summary:
> Add support for the message field in IllegalStateException
> Test Plan:
> ran tests in thrift/lib/cpp/concurrency/test
> Revert Plan:
> OK
> ---
>  lib/cpp/src/concurrency/Exception.h   |6 +-
>  lib/cpp/src/concurrency/ThreadManager.cpp |9 ++---
>  2 files changed, 11 insertions(+), 4 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1333) Make RWGuard not copyable

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100981#comment-13100981
 ] 

Hudson commented on THRIFT-1333:


Integrated in Thrift #254 (See [https://builds.apache.org/job/Thrift/254/])
THRIFT-1333: Make RWGuard not copyable
Client: cpp
Patch: Dave Watson

Copying would cause contained mutex to unlock twice, changing to noncopyable.

jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1166996
Files : 
* /thrift/trunk/lib/cpp/src/concurrency/Mutex.h


>  Make RWGuard not copyable

> ---
>
> Key: THRIFT-1333
> URL: https://issues.apache.org/jira/browse/THRIFT-1333
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 0029-Make-RWGuard-not-copyable.patch
>
>
> From aca289c602251bbfe7f6543ce037ac795be273e0 Mon Sep 17 00:00:00 2001
> From: Jordan DeLong 
> Date: Tue, 20 Apr 2010 19:35:56 +
> Subject: [PATCH 29/33] Make RWGuard not copyable
> Summary:
> Copying this class would cause its contained mutex to
> unlock twice.  Mark it noncopyable.
> Test Plan:
> Compiled [internal fb thing].
> Revert Plan:
> OK
> ---
>  lib/cpp/src/concurrency/Mutex.h |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1333) Make RWGuard not copyable

[Jake Farrell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell closed THRIFT-1333.


   Resolution: Fixed
Fix Version/s: 0.8

Committed, thanks Dave

>  Make RWGuard not copyable

> ---
>
> Key: THRIFT-1333
> URL: https://issues.apache.org/jira/browse/THRIFT-1333
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 0029-Make-RWGuard-not-copyable.patch
>
>
> From aca289c602251bbfe7f6543ce037ac795be273e0 Mon Sep 17 00:00:00 2001
> From: Jordan DeLong 
> Date: Tue, 20 Apr 2010 19:35:56 +
> Subject: [PATCH 29/33] Make RWGuard not copyable
> Summary:
> Copying this class would cause its contained mutex to
> unlock twice.  Mark it noncopyable.
> Test Plan:
> Compiled [internal fb thing].
> Revert Plan:
> OK
> ---
>  lib/cpp/src/concurrency/Mutex.h |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1334) Add more info to IllegalStateException

[Jake Farrell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell closed THRIFT-1334.


   Resolution: Fixed
Fix Version/s: 0.8

Committed, thanks Dave 

>  Add more info to IllegalStateException

> 
>
> Key: THRIFT-1334
> URL: https://issues.apache.org/jira/browse/THRIFT-1334
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 0030-Add-more-info-to-IllegalStateException.patch
>
>
> From bb3ebfa1f6483e6cf6ca3e264b24505194155842 Mon Sep 17 00:00:00 2001
> From: Joshua Redstone 
> Date: Tue, 20 Apr 2010 22:56:15 +
> Subject: [PATCH 30/33] Add more info to IllegalStateException
> Summary:
> Add support for the message field in IllegalStateException
> Test Plan:
> ran tests in thrift/lib/cpp/concurrency/test
> Revert Plan:
> OK
> ---
>  lib/cpp/src/concurrency/Exception.h   |6 +-
>  lib/cpp/src/concurrency/ThreadManager.cpp |9 ++---
>  2 files changed, 11 insertions(+), 4 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (THRIFT-1285) Stable 0.7.0 Windows compiler exe available on the webside is not the good one

[Jake Farrell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell reassigned THRIFT-1285:


Assignee: Jake Farrell

> Stable 0.7.0 Windows compiler exe available on the webside is not the good one
> --
>
> Key: THRIFT-1285
> URL: https://issues.apache.org/jira/browse/THRIFT-1285
> Project: Thrift
>  Issue Type: Bug
>  Components: Website
>Affects Versions: 0.7
>Reporter: Raphaël Bartement
>Assignee: Jake Farrell
>Priority: Blocker
>
> On the main Thrift web site, in [the download 
> section|http://thrift.apache.org/download/], the Release link to "Thrift 
> compiler for Windows" do not lead to the tagged 0.7.0 stable release version 
> of the compiler.
> I think this is a trunk snapshot binary instead.
> Running {{monospacedthrift-0.7.0.exe -version}}
> returns {{Thrift version 0.7.0-dev}}.
> Before, I tested Java generation.
> With this file:
> {code:title=Test.thrift}
> namespace java org.test
> struct Foo {}
> {code} 
> I get:
> {code:java|:title=Foo.java} 
> /**
>  * Autogenerated by Thrift Compiler (0.7.0-dev)
>  *
>  * DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
>  */
> package org.test;
> import org.apache.thrift.scheme.IScheme;
> import org.apache.thrift.scheme.SchemeFactory;
> import org.apache.thrift.scheme.StandardScheme;
> ...
> {code}
> I checked in subversion, the "Scheme"-related code has been introduced into 
> the trunk, but is not part of 0.7.x branch and 0.7.0 tag.
> Thus, the generator code won't compile with the 0.7.0 java lib.
> May you check this binary?
> I'd like to use the official stable one.
> Thanks.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1337) thrift: support maximum frame size in

[Dave Watson (JIRA)]

 thrift: support maximum frame size in

---

 Key: THRIFT-1337
 URL: https://issues.apache.org/jira/browse/THRIFT-1337
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Reporter: Dave Watson
Priority: Minor
 Attachments: 
0033-thrift-support-maximum-frame-size-in-TNonblockingSer.patch

>From 0dc0b12d1b00f9036407283315e9019a1f9f3b58 Mon Sep 17 00:00:00 2001
From: Adam Simpkins 
Date: Mon, 26 Apr 2010 19:47:59 +
Subject: [PATCH 33/33] thrift: support maximum frame size in
 TNonblockingServer

Summary:
This prevents the C++ TNonblockingServer from trying to allocate a giant
buffer when a client sends a huge frame size.  Usually if this occurs,
if is because a client is simply sending garbage data to the server.

For now, it defaults to 256MB.  Hopefully this value is large enough not
to cause problems for legitimate service requests.  Services that do
actually have messages larger than this value will need to update their
code to set a larger value than the default.

Test Plan:
Ran the tests in thrift/lib/cpp/processor/test.
Also ran thrift/lib/cpp/server/test/TNonblockingServerTest.cpp,
and tested sending garbage frame sizes to it.

Revert Plan:
OK

---
 lib/cpp/src/server/TNonblockingServer.cpp |   14 +++---
 lib/cpp/src/server/TNonblockingServer.h   |   28 
 2 files changed, 39 insertions(+), 3 deletions(-)



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1337) thrift: support maximum frame size in

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1337:


Attachment: 0033-thrift-support-maximum-frame-size-in-TNonblockingSer.patch

>  thrift: support maximum frame size in

> ---
>
> Key: THRIFT-1337
> URL: https://issues.apache.org/jira/browse/THRIFT-1337
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: 
> 0033-thrift-support-maximum-frame-size-in-TNonblockingSer.patch
>
>
> From 0dc0b12d1b00f9036407283315e9019a1f9f3b58 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Mon, 26 Apr 2010 19:47:59 +
> Subject: [PATCH 33/33] thrift: support maximum frame size in
>  TNonblockingServer
> Summary:
> This prevents the C++ TNonblockingServer from trying to allocate a giant
> buffer when a client sends a huge frame size.  Usually if this occurs,
> if is because a client is simply sending garbage data to the server.
> For now, it defaults to 256MB.  Hopefully this value is large enough not
> to cause problems for legitimate service requests.  Services that do
> actually have messages larger than this value will need to update their
> code to set a larger value than the default.
> Test Plan:
> Ran the tests in thrift/lib/cpp/processor/test.
> Also ran thrift/lib/cpp/server/test/TNonblockingServerTest.cpp,
> and tested sending garbage frame sizes to it.
> Revert Plan:
> OK
> ---
>  lib/cpp/src/server/TNonblockingServer.cpp |   14 +++---
>  lib/cpp/src/server/TNonblockingServer.h   |   28 
>  2 files changed, 39 insertions(+), 3 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1336) thrift: added server and processor test code

[Dave Watson (JIRA)]

 thrift: added server and processor test code

--

 Key: THRIFT-1336
 URL: https://issues.apache.org/jira/browse/THRIFT-1336
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Reporter: Dave Watson
Priority: Minor
 Attachments: 0032-thrift-added-server-and-processor-test-code.patch

davejwatson: 
Internally FB uses a different build system.  I added stuff to the Makefile.am
for these tests, but I'm not a makefile master, it would be nice to have
a second set of eyes here

>From 2f30313189df5d5886298c96fcd6dfdf0e126d77 Mon Sep 17 00:00:00 2001
From: Adam Simpkins 
Date: Fri, 23 Apr 2010 04:19:18 +
Subject: [PATCH 32/33] thrift: added server and processor test code

Summary:
This code tests that the TServerEventHandler and TProcessorEventHandler
hooks are invoked correctly by the server and event code.  The test
cases all start a server in a separate thread, then make some calls
against it.  The TServerEventHandler and TProcessorEventHandler record
each time they are called, and the test code checks to make sure that
the recorded calls match what is expected.

Test Plan:
Ran it.

Currently it fails for several reasons.  Several of the servers don't
implement stop() properly, causing tests to hang trying to shutdown
their server.  TNonblockingServer also doesn't invoke the
TProcessorEventHandler correctly when not using a ThreadManager.
I have fixes for all of these, which I'll submit as separate diffs.

Revert Plan:
OK

---
 lib/cpp/Makefile.am  |   47 ++-
 lib/cpp/src/processor/test/EventLog.cpp  |  129 
 lib/cpp/src/processor/test/EventLog.h|   94 +++
 lib/cpp/src/processor/test/Handlers.h|  341 ++
 lib/cpp/src/processor/test/ProcessorTest.cpp |  941 ++
 lib/cpp/src/processor/test/ServerThread.cpp  |  148 
 lib/cpp/src/processor/test/ServerThread.h|  143 
 lib/cpp/src/processor/test/proc.thrift   |   22 +
 8 files changed, 1863 insertions(+), 2 deletions(-)
 create mode 100644 lib/cpp/src/processor/test/EventLog.cpp
 create mode 100644 lib/cpp/src/processor/test/EventLog.h
 create mode 100644 lib/cpp/src/processor/test/Handlers.h
 create mode 100644 lib/cpp/src/processor/test/ProcessorTest.cpp
 create mode 100644 lib/cpp/src/processor/test/ServerThread.cpp
 create mode 100644 lib/cpp/src/processor/test/ServerThread.h
 create mode 100644 lib/cpp/src/processor/test/proc.thrift



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1336) thrift: added server and processor test code

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1336:


Attachment: 0032-thrift-added-server-and-processor-test-code.patch

>  thrift: added server and processor test code

> --
>
> Key: THRIFT-1336
> URL: https://issues.apache.org/jira/browse/THRIFT-1336
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: 0032-thrift-added-server-and-processor-test-code.patch
>
>
> davejwatson: 
> Internally FB uses a different build system.  I added stuff to the Makefile.am
> for these tests, but I'm not a makefile master, it would be nice to have
> a second set of eyes here
> From 2f30313189df5d5886298c96fcd6dfdf0e126d77 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Fri, 23 Apr 2010 04:19:18 +
> Subject: [PATCH 32/33] thrift: added server and processor test code
> Summary:
> This code tests that the TServerEventHandler and TProcessorEventHandler
> hooks are invoked correctly by the server and event code.  The test
> cases all start a server in a separate thread, then make some calls
> against it.  The TServerEventHandler and TProcessorEventHandler record
> each time they are called, and the test code checks to make sure that
> the recorded calls match what is expected.
> Test Plan:
> Ran it.
> Currently it fails for several reasons.  Several of the servers don't
> implement stop() properly, causing tests to hang trying to shutdown
> their server.  TNonblockingServer also doesn't invoke the
> TProcessorEventHandler correctly when not using a ThreadManager.
> I have fixes for all of these, which I'll submit as separate diffs.
> Revert Plan:
> OK
> ---
>  lib/cpp/Makefile.am  |   47 ++-
>  lib/cpp/src/processor/test/EventLog.cpp  |  129 
>  lib/cpp/src/processor/test/EventLog.h|   94 +++
>  lib/cpp/src/processor/test/Handlers.h|  341 ++
>  lib/cpp/src/processor/test/ProcessorTest.cpp |  941 
> ++
>  lib/cpp/src/processor/test/ServerThread.cpp  |  148 
>  lib/cpp/src/processor/test/ServerThread.h|  143 
>  lib/cpp/src/processor/test/proc.thrift   |   22 +
>  8 files changed, 1863 insertions(+), 2 deletions(-)
>  create mode 100644 lib/cpp/src/processor/test/EventLog.cpp
>  create mode 100644 lib/cpp/src/processor/test/EventLog.h
>  create mode 100644 lib/cpp/src/processor/test/Handlers.h
>  create mode 100644 lib/cpp/src/processor/test/ProcessorTest.cpp
>  create mode 100644 lib/cpp/src/processor/test/ServerThread.cpp
>  create mode 100644 lib/cpp/src/processor/test/ServerThread.h
>  create mode 100644 lib/cpp/src/processor/test/proc.thrift

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1335) Add accept timeout to TServerSocket

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1335:


Attachment: 0031-Improve-pusher_serverrr.patch

>  Add accept timeout to TServerSocket

> -
>
> Key: THRIFT-1335
> URL: https://issues.apache.org/jira/browse/THRIFT-1335
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: 0031-Improve-pusher_serverrr.patch
>
>
> From d07e47a771d9cca8111b2773c8e3436a5e9442ae Mon Sep 17 00:00:00 2001
> From: Wei Chen 
> Date: Wed, 21 Apr 2010 21:12:34 +
> Subject: [PATCH 31/33] Add accept timeout to TServerSocket
> Summary:
> Added an accept timeout to the TServerSocket poll loop
> Test Plan:
> I run the servers in testing rack and verified it works both for intra rack 
> and
> inter rack transfer.
> scottstraw, simpkins, weichen, thrift-team@lists
> Revert Plan:
> OK
> ---
>  lib/cpp/src/transport/TServerSocket.cpp |   12 +++-
>  lib/cpp/src/transport/TServerSocket.h   |3 +++
>  2 files changed, 14 insertions(+), 1 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1335) Add accept timeout to TServerSocket

[Dave Watson (JIRA)]

 Add accept timeout to TServerSocket

-

 Key: THRIFT-1335
 URL: https://issues.apache.org/jira/browse/THRIFT-1335
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Reporter: Dave Watson
Priority: Minor
 Attachments: 0031-Improve-pusher_serverrr.patch

>From d07e47a771d9cca8111b2773c8e3436a5e9442ae Mon Sep 17 00:00:00 2001
From: Wei Chen 
Date: Wed, 21 Apr 2010 21:12:34 +
Subject: [PATCH 31/33] Add accept timeout to TServerSocket

Summary:
Added an accept timeout to the TServerSocket poll loop

Test Plan:
I run the servers in testing rack and verified it works both for intra rack and
inter rack transfer.

scottstraw, simpkins, weichen, thrift-team@lists
Revert Plan:
OK

---
 lib/cpp/src/transport/TServerSocket.cpp |   12 +++-
 lib/cpp/src/transport/TServerSocket.h   |3 +++
 2 files changed, 14 insertions(+), 1 deletions(-)



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1334) Add more info to IllegalStateException

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1334:


Attachment: 0030-Add-more-info-to-IllegalStateException.patch

>  Add more info to IllegalStateException

> 
>
> Key: THRIFT-1334
> URL: https://issues.apache.org/jira/browse/THRIFT-1334
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: 0030-Add-more-info-to-IllegalStateException.patch
>
>
> From bb3ebfa1f6483e6cf6ca3e264b24505194155842 Mon Sep 17 00:00:00 2001
> From: Joshua Redstone 
> Date: Tue, 20 Apr 2010 22:56:15 +
> Subject: [PATCH 30/33] Add more info to IllegalStateException
> Summary:
> Add support for the message field in IllegalStateException
> Test Plan:
> ran tests in thrift/lib/cpp/concurrency/test
> Revert Plan:
> OK
> ---
>  lib/cpp/src/concurrency/Exception.h   |6 +-
>  lib/cpp/src/concurrency/ThreadManager.cpp |9 ++---
>  2 files changed, 11 insertions(+), 4 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1333) Make RWGuard not copyable

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1333:


Attachment: 0029-Make-RWGuard-not-copyable.patch

>  Make RWGuard not copyable

> ---
>
> Key: THRIFT-1333
> URL: https://issues.apache.org/jira/browse/THRIFT-1333
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: 0029-Make-RWGuard-not-copyable.patch
>
>
> From aca289c602251bbfe7f6543ce037ac795be273e0 Mon Sep 17 00:00:00 2001
> From: Jordan DeLong 
> Date: Tue, 20 Apr 2010 19:35:56 +
> Subject: [PATCH 29/33] Make RWGuard not copyable
> Summary:
> Copying this class would cause its contained mutex to
> unlock twice.  Mark it noncopyable.
> Test Plan:
> Compiled [internal fb thing].
> Revert Plan:
> OK
> ---
>  lib/cpp/src/concurrency/Mutex.h |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1333) Make RWGuard not copyable

[Dave Watson (JIRA)]

 Make RWGuard not copyable

---

 Key: THRIFT-1333
 URL: https://issues.apache.org/jira/browse/THRIFT-1333
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Reporter: Dave Watson
Priority: Minor
 Attachments: 0029-Make-RWGuard-not-copyable.patch

>From aca289c602251bbfe7f6543ce037ac795be273e0 Mon Sep 17 00:00:00 2001
From: Jordan DeLong 
Date: Tue, 20 Apr 2010 19:35:56 +
Subject: [PATCH 29/33] Make RWGuard not copyable

Summary:
Copying this class would cause its contained mutex to
unlock twice.  Mark it noncopyable.

Test Plan:
Compiled [internal fb thing].

Revert Plan:
OK

---
 lib/cpp/src/concurrency/Mutex.h |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1334) Add more info to IllegalStateException

[Dave Watson (JIRA)]

 Add more info to IllegalStateException



 Key: THRIFT-1334
 URL: https://issues.apache.org/jira/browse/THRIFT-1334
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Reporter: Dave Watson
Priority: Minor
 Attachments: 0030-Add-more-info-to-IllegalStateException.patch

>From bb3ebfa1f6483e6cf6ca3e264b24505194155842 Mon Sep 17 00:00:00 2001
From: Joshua Redstone 
Date: Tue, 20 Apr 2010 22:56:15 +
Subject: [PATCH 30/33] Add more info to IllegalStateException

Summary:
Add support for the message field in IllegalStateException

Test Plan:
ran tests in thrift/lib/cpp/concurrency/test

Revert Plan:
OK

---
 lib/cpp/src/concurrency/Exception.h   |6 +-
 lib/cpp/src/concurrency/ThreadManager.cpp |9 ++---
 2 files changed, 11 insertions(+), 4 deletions(-)



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1285) Stable 0.7.0 Windows compiler exe available on the webside is not the good one

[Jake Farrell (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100611#comment-13100611
 ] 

Jake Farrell commented on THRIFT-1285:
--

I just placed a new build of the windows compiler which does print out the 
correct header versions. It is available at 
http://people.apache.org/~jfarrell/thrift/0.7.0/windows/ . Can you please try 
it and let me know if you have any problems with it

> Stable 0.7.0 Windows compiler exe available on the webside is not the good one
> --
>
> Key: THRIFT-1285
> URL: https://issues.apache.org/jira/browse/THRIFT-1285
> Project: Thrift
>  Issue Type: Bug
>  Components: Website
>Affects Versions: 0.7
>Reporter: Raphaël Bartement
>Priority: Blocker
>
> On the main Thrift web site, in [the download 
> section|http://thrift.apache.org/download/], the Release link to "Thrift 
> compiler for Windows" do not lead to the tagged 0.7.0 stable release version 
> of the compiler.
> I think this is a trunk snapshot binary instead.
> Running {{monospacedthrift-0.7.0.exe -version}}
> returns {{Thrift version 0.7.0-dev}}.
> Before, I tested Java generation.
> With this file:
> {code:title=Test.thrift}
> namespace java org.test
> struct Foo {}
> {code} 
> I get:
> {code:java|:title=Foo.java} 
> /**
>  * Autogenerated by Thrift Compiler (0.7.0-dev)
>  *
>  * DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
>  */
> package org.test;
> import org.apache.thrift.scheme.IScheme;
> import org.apache.thrift.scheme.SchemeFactory;
> import org.apache.thrift.scheme.StandardScheme;
> ...
> {code}
> I checked in subversion, the "Scheme"-related code has been introduced into 
> the trunk, but is not part of 0.7.x branch and 0.7.0 tag.
> Thus, the generator code won't compile with the 0.7.0 java lib.
> May you check this binary?
> I'd like to use the official stable one.
> Thanks.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1332) TSSLTransportParameters class uses hard coded value keyManagerType: SunX509

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100476#comment-13100476
 ] 

Hudson commented on THRIFT-1332:


Integrated in Thrift #253 (See [https://builds.apache.org/job/Thrift/253/])
THRIFT-1332: TSSLTransportParameters class uses hard coded value 
keyManagerType: SunX509
Client: java
Patch: Vladimir Zhilyaev

Convert Keymanger and TrustManager over to using detected jvm values rather 
than hard coded.

jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1166798
Files : 
* 
/thrift/trunk/lib/java/src/org/apache/thrift/transport/TSSLTransportFactory.java


> TSSLTransportParameters class uses hard coded value keyManagerType: SunX509
> ---
>
> Key: THRIFT-1332
> URL: https://issues.apache.org/jira/browse/THRIFT-1332
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Library
>Affects Versions: 0.6, 0.6.1, 0.7
>Reporter: Vladimir Zhilyaev
>Assignee: Vladimir Zhilyaev
>Priority: Minor
> Fix For: 0.8
>
> Attachments: TSSLTransportFactory.java.diff
>
>
> TSSLTransportParameters class uses hard coded value keyManagerType. The value 
> in use: "SunX509". This value is valid only for Sun JVM.
> Proposed solution: use KeyManagerFactory.getDefaultAlgorithm() and 
> TrustManagerFactory.getDefaultAlgorithm(), which return appropriate values 
> for each JVM.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Build failed in Jenkins: Thrift-cpp #154

[Apache Jenkins Server]

See 

Changes:

[jfarrell] THRIFT-1332: TSSLTransportParameters class uses hard coded value 
keyManagerType: SunX509
Client: java
Patch: Vladimir Zhilyaev

Convert Keymanger and TrustManager over to using detected jvm values rather 
than hard coded.

--
[...truncated 1691 lines...]
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall 
-Wextra -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overflow -Werror 
-Wall -Wall -Wextra -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overflow 
-Werror -MT THttpTransport.lo -MD -MP -MF .deps/THttpTransport.Tpo -c 
src/transport/THttpTransport.cpp -o THttpTransport.o >/dev/null 2>&1
mv -f .deps/THttpTransport.Tpo .deps/THttpTransport.Plo
/bin/bash ../../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. 
-I../..  -I/usr/include -I./src -Wall -Wextra -pedantic -Wno-long-long 
-Wno-variadic-macros -Wno-overflow -Werror -Wall -Wall -Wextra -pedantic 
-Wno-long-long -Wno-variadic-macros -Wno-overflow -Werror -MT THttpClient.lo 
-MD -MP -MF .deps/THttpClient.Tpo -c -o THttpClient.lo `test -f 
'src/transport/THttpClient.cpp' || echo './'`src/transport/THttpClient.cpp
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall 
-Wextra -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overflow -Werror 
-Wall -Wall -Wextra -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overflow 
-Werror -MT THttpClient.lo -MD -MP -MF .deps/THttpClient.Tpo -c 
src/transport/THttpClient.cpp  -fPIC -DPIC -o .libs/THttpClient.o
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall 
-Wextra -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overflow -Werror 
-Wall -Wall -Wextra -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overflow 
-Werror -MT THttpClient.lo -MD -MP -MF .deps/THttpClient.Tpo -c 
src/transport/THttpClient.cpp -o THttpClient.o >/dev/null 2>&1
mv -f .deps/THttpClient.Tpo .deps/THttpClient.Plo
/bin/bash ../../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. 
-I../..  -I/usr/include -I./src -Wall -Wextra -pedantic -Wno-long-long 
-Wno-variadic-macros -Wno-overflow -Werror -Wall -Wall -Wextra -pedantic 
-Wno-long-long -Wno-variadic-macros -Wno-overflow -Werror -MT THttpServer.lo 
-MD -MP -MF .deps/THttpServer.Tpo -c -o THttpServer.lo `test -f 
'src/transport/THttpServer.cpp' || echo './'`src/transport/THttpServer.cpp
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall 
-Wextra -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overflow -Werror 
-Wall -Wall -Wextra -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overflow 
-Werror -MT THttpServer.lo -MD -MP -MF .deps/THttpServer.Tpo -c 
src/transport/THttpServer.cpp  -fPIC -DPIC -o .libs/THttpServer.o
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall 
-Wextra -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overflow -Werror 
-Wall -Wall -Wextra -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overflow 
-Werror -MT THttpServer.lo -MD -MP -MF .deps/THttpServer.Tpo -c 
src/transport/THttpServer.cpp -o THttpServer.o >/dev/null 2>&1
mv -f .deps/THttpServer.Tpo .deps/THttpServer.Plo
/bin/bash ../../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. 
-I../..  -I/usr/include -I./src -Wall -Wextra -pedantic -Wno-long-long 
-Wno-variadic-macros -Wno-overflow -Werror -Wall -Wall -Wextra -pedantic 
-Wno-long-long -Wno-variadic-macros -Wno-overflow -Werror -MT TSocket.lo -MD 
-MP -MF .deps/TSocket.Tpo -c -o TSocket.lo `test -f 'src/transport/TSocket.cpp' 
|| echo './'`src/transport/TSocket.cpp
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall 
-Wextra -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overflow -Werror 
-Wall -Wall -Wextra -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overflow 
-Werror -MT TSocket.lo -MD -MP -MF .deps/TSocket.Tpo -c 
src/transport/TSocket.cpp  -fPIC -DPIC -o .libs/TSocket.o
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall 
-Wextra -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overflow -Werror 
-Wall -Wall -Wextra -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overflow 
-Werror -MT TSocket.lo -MD -MP -MF .deps/TSocket.Tpo -c 
src/transport/TSocket.cpp -o TSocket.o >/dev/null 2>&1
mv -f .deps/TSocket.Tpo .deps/TSocket.Plo
/bin/bash ../../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. 
-I../..  -I/usr/include -I./src -Wall -Wextra -pedantic -Wno-long-long 
-Wno-variadic-macros -Wno-overflow -Werror -Wall -Wall -Wextra -pedantic 
-Wno-long-long -Wno-variadic-macros -Wno-overflow -Werror -MT TSSLSocket.lo -MD 
-MP -MF .deps/TSSLSocket.Tpo -c -o TSSLSocket.lo `test -f 
'src/transport/TSSLSocket.cpp' || echo './'`src/transport/TSSLSocket.cpp
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I/usr/include -I./src -Wall 
-Wextra -pedantic -Wno-long-long -Wno-variadic

[jira] [Closed] (THRIFT-1332) TSSLTransportParameters class uses hard coded value keyManagerType: SunX509

[Jake Farrell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell closed THRIFT-1332.


   Resolution: Fixed
Fix Version/s: 0.8
 Assignee: Vladimir Zhilyaev

Thanks for  the patch, committed.

> TSSLTransportParameters class uses hard coded value keyManagerType: SunX509
> ---
>
> Key: THRIFT-1332
> URL: https://issues.apache.org/jira/browse/THRIFT-1332
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Library
>Affects Versions: 0.6, 0.6.1, 0.7
>Reporter: Vladimir Zhilyaev
>Assignee: Vladimir Zhilyaev
>Priority: Minor
> Fix For: 0.8
>
> Attachments: TSSLTransportFactory.java.diff
>
>
> TSSLTransportParameters class uses hard coded value keyManagerType. The value 
> in use: "SunX509". This value is valid only for Sun JVM.
> Proposed solution: use KeyManagerFactory.getDefaultAlgorithm() and 
> TrustManagerFactory.getDefaultAlgorithm(), which return appropriate values 
> for each JVM.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1332) TSSLTransportParameters class uses hard coded value keyManagerType: SunX509

[Vladimir Zhilyaev (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Zhilyaev updated THRIFT-1332:
--

Attachment: TSSLTransportFactory.java.diff

> TSSLTransportParameters class uses hard coded value keyManagerType: SunX509
> ---
>
> Key: THRIFT-1332
> URL: https://issues.apache.org/jira/browse/THRIFT-1332
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Library
>Affects Versions: 0.6, 0.6.1, 0.7
>Reporter: Vladimir Zhilyaev
>Priority: Minor
> Attachments: TSSLTransportFactory.java.diff
>
>
> TSSLTransportParameters class uses hard coded value keyManagerType. The value 
> in use: "SunX509". This value is valid only for Sun JVM.
> Proposed solution: use KeyManagerFactory.getDefaultAlgorithm() and 
> TrustManagerFactory.getDefaultAlgorithm(), which return appropriate values 
> for each JVM.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1332) TSSLTransportParameters class uses hard coded value keyManagerType: SunX509

[Vladimir Zhilyaev (JIRA)]

TSSLTransportParameters class uses hard coded value keyManagerType: SunX509
---

 Key: THRIFT-1332
 URL: https://issues.apache.org/jira/browse/THRIFT-1332
 Project: Thrift
  Issue Type: Improvement
  Components: Java - Library
Affects Versions: 0.7, 0.6.1, 0.6
Reporter: Vladimir Zhilyaev
Priority: Minor


TSSLTransportParameters class uses hard coded value keyManagerType. The value 
in use: "SunX509". This value is valid only for Sun JVM.

Proposed solution: use KeyManagerFactory.getDefaultAlgorithm() and 
TrustManagerFactory.getDefaultAlgorithm(), which return appropriate values for 
each JVM.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira