[jira] [Commented] (THRIFT-1341) TProtocol.h endian detection wrong with boost

2011-09-12 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103162#comment-13103162
 ] 

Hudson commented on THRIFT-1341:


Integrated in Thrift #261 (See [https://builds.apache.org/job/Thrift/261/])
THRIFT-1341 TProtocol.h endian detection wrong with boost
Patch: alexandre parenteau

roger : http://svn.apache.org/viewvc/?view=rev&rev=1169963
Files : 
* /thrift/trunk/lib/cpp/src/protocol/TProtocol.h


> TProtocol.h endian detection wrong with boost
> -
>
> Key: THRIFT-1341
> URL: https://issues.apache.org/jira/browse/THRIFT-1341
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Affects Versions: 0.7, 0.8
> Environment: Windows
>Reporter: alexandre parenteau
>Priority: Trivial
>  Labels: patch
> Fix For: 0.8
>
> Attachments: THRIFT-1341.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When compiling on platforms without /usr/include/endian.h (e.g. Windows.h), 
> TProtocol.h uses boost to detect the endianess, but does it wrong: boost's 
> endian.hpp will only #define BOOST_LITTLE_ENDIAN with no value (unlike 
> endian.h)
> Attached is a patch against trunk which fixes the code that uses boost. 
> Tested on Windows, boost 1.44.0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Resolved] (THRIFT-1341) TProtocol.h endian detection wrong with boost

2011-09-12 Thread Roger Meier (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roger Meier resolved THRIFT-1341.
-

Resolution: Fixed

Thanks Alexandre!

> TProtocol.h endian detection wrong with boost
> -
>
> Key: THRIFT-1341
> URL: https://issues.apache.org/jira/browse/THRIFT-1341
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Affects Versions: 0.7, 0.8
> Environment: Windows
>Reporter: alexandre parenteau
>Priority: Trivial
>  Labels: patch
> Fix For: 0.8
>
> Attachments: THRIFT-1341.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When compiling on platforms without /usr/include/endian.h (e.g. Windows.h), 
> TProtocol.h uses boost to detect the endianess, but does it wrong: boost's 
> endian.hpp will only #define BOOST_LITTLE_ENDIAN with no value (unlike 
> endian.h)
> Attached is a patch against trunk which fixes the code that uses boost. 
> Tested on Windows, boost 1.44.0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (THRIFT-1342) Compilation problem on Windows of fastbinary.c

2011-09-12 Thread alexandre parenteau (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

alexandre parenteau updated THRIFT-1342:


Attachment: THRIFT-1342.patch

patch to compile on Windows / Visual C++ 9.0.

Note: stdint.h for Visual C++ comes from http://code.google.com/p/msinttypes/ 
(License new BSD)

> Compilation problem on Windows of fastbinary.c
> --
>
> Key: THRIFT-1342
> URL: https://issues.apache.org/jira/browse/THRIFT-1342
> Project: Thrift
>  Issue Type: Bug
>  Components: Python - Library
>Affects Versions: 0.7, 0.8
> Environment: Windows, Visual C++ 9.0, python 2.X
>Reporter: alexandre parenteau
>Priority: Minor
>  Labels: tag
> Fix For: 0.8
>
> Attachments: THRIFT-1342.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Compilation problem when inside fastbinary.c when doing 'python setup.py 
> build'.
> Tested on Windows python 2.x 64/32

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (THRIFT-1342) Compilation problem on Windows of fastbinary.c

2011-09-12 Thread alexandre parenteau (JIRA)
Compilation problem on Windows of fastbinary.c
--

 Key: THRIFT-1342
 URL: https://issues.apache.org/jira/browse/THRIFT-1342
 Project: Thrift
  Issue Type: Bug
  Components: Python - Library
Affects Versions: 0.7, 0.8
 Environment: Windows, Visual C++ 9.0, python 2.X
Reporter: alexandre parenteau
Priority: Minor
 Fix For: 0.8


Compilation problem when inside fastbinary.c when doing 'python setup.py build'.

Tested on Windows python 2.x 64/32

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (THRIFT-1341) TProtocol.h endian detection wrong with boost

2011-09-12 Thread alexandre parenteau (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

alexandre parenteau updated THRIFT-1341:


Attachment: THRIFT-1341.patch

Fix boost endianness detection

> TProtocol.h endian detection wrong with boost
> -
>
> Key: THRIFT-1341
> URL: https://issues.apache.org/jira/browse/THRIFT-1341
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Affects Versions: 0.7, 0.8
> Environment: Windows
>Reporter: alexandre parenteau
>Priority: Trivial
>  Labels: patch
> Fix For: 0.8
>
> Attachments: THRIFT-1341.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When compiling on platforms without /usr/include/endian.h (e.g. Windows.h), 
> TProtocol.h uses boost to detect the endianess, but does it wrong: boost's 
> endian.hpp will only #define BOOST_LITTLE_ENDIAN with no value (unlike 
> endian.h)
> Attached is a patch against trunk which fixes the code that uses boost. 
> Tested on Windows, boost 1.44.0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (THRIFT-1341) TProtocol.h endian detection wrong with boost

2011-09-12 Thread alexandre parenteau (JIRA)
TProtocol.h endian detection wrong with boost
-

 Key: THRIFT-1341
 URL: https://issues.apache.org/jira/browse/THRIFT-1341
 Project: Thrift
  Issue Type: Bug
  Components: C++ - Library
Affects Versions: 0.7, 0.8
 Environment: Windows
Reporter: alexandre parenteau
Priority: Trivial
 Fix For: 0.8
 Attachments: THRIFT-1341.patch

When compiling on platforms without /usr/include/endian.h (e.g. Windows.h), 
TProtocol.h uses boost to detect the endianess, but does it wrong: boost's 
endian.hpp will only #define BOOST_LITTLE_ENDIAN with no value (unlike endian.h)

Attached is a patch against trunk which fixes the code that uses boost. Tested 
on Windows, boost 1.44.0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Closed] (THRIFT-1285) Stable 0.7.0 Windows compiler exe available on the webside is not the good one

2011-09-12 Thread Jake Farrell (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell closed THRIFT-1285.


   Resolution: Fixed
Fix Version/s: 0.7

> Stable 0.7.0 Windows compiler exe available on the webside is not the good one
> --
>
> Key: THRIFT-1285
> URL: https://issues.apache.org/jira/browse/THRIFT-1285
> Project: Thrift
>  Issue Type: Bug
>  Components: Website
>Affects Versions: 0.7
>Reporter: Raphaƫl Bartement
>Assignee: Jake Farrell
>Priority: Blocker
> Fix For: 0.7
>
>
> On the main Thrift web site, in [the download 
> section|http://thrift.apache.org/download/], the Release link to "Thrift 
> compiler for Windows" do not lead to the tagged 0.7.0 stable release version 
> of the compiler.
> I think this is a trunk snapshot binary instead.
> Running {{monospacedthrift-0.7.0.exe -version}}
> returns {{Thrift version 0.7.0-dev}}.
> Before, I tested Java generation.
> With this file:
> {code:title=Test.thrift}
> namespace java org.test
> struct Foo {}
> {code} 
> I get:
> {code:java|:title=Foo.java} 
> /**
>  * Autogenerated by Thrift Compiler (0.7.0-dev)
>  *
>  * DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
>  */
> package org.test;
> import org.apache.thrift.scheme.IScheme;
> import org.apache.thrift.scheme.SchemeFactory;
> import org.apache.thrift.scheme.StandardScheme;
> ...
> {code}
> I checked in subversion, the "Scheme"-related code has been introduced into 
> the trunk, but is not part of 0.7.x branch and 0.7.0 tag.
> Thus, the generator code won't compile with the 0.7.0 java lib.
> May you check this binary?
> I'd like to use the official stable one.
> Thanks.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira