[jira] [Commented] (THRIFT-1350) Go library code does not build as of r60 (most recent release)

2011-09-19 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108286#comment-13108286
 ] 

Hudson commented on THRIFT-1350:


Integrated in Thrift #268 (See [https://builds.apache.org/job/Thrift/268/])
THRIFT-1350: Go library code does not build against latest release
Client: go
Patch: Kyle Consalus

Go has moved it's URL-handling code into a "url" package, patch updates for 
these new changes.

jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1172901
Files : 
* /thrift/trunk/lib/go/thrift/thttp_client.go
* /thrift/trunk/lib/go/thrift/tsimple_json_protocol_test.go


> Go library code does not build as of r60 (most recent release)
> --
>
> Key: THRIFT-1350
> URL: https://issues.apache.org/jira/browse/THRIFT-1350
> Project: Thrift
>  Issue Type: Bug
>  Components: Go - Library
>Reporter: Kyle Consalus
>Assignee: Kyle Consalus
> Fix For: 0.8
>
> Attachments: patch.diff
>
>
> Go has moved it's URL-handling code into a "url" package.
> Also, strings.Split no longer takes a 3rd parameter.
> Not sure how I attach a patch, but here's a diff:
> http://pastie.org/2559636
> Or, a simple run of "gofix" should probably handle it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Build failed in Jenkins: Thrift #268

2011-09-19 Thread Apache Jenkins Server 
See 

Changes:

[jfarrell] THRIFT-1350: Go library code does not build against latest release
Client: go
Patch: Kyle Consalus

Go has moved it's URL-handling code into a "url" package, patch updates for 
these new changes.

--
[...truncated 2011 lines...]
[WARNING::197]
 64-bit constant "9223372036854775807" may not work in all languages.

[WARNING::204]
 64-bit constant "9223372036854775807" may not work in all languages.

[WARNING::41]
 64-bit constant "100" may not work in all languages.

[WARNING::169]
 64-bit constant "1099511627775" may not work in all languages.

[WARNING::179]
 64-bit constant "4294967295" may not work in all languages.

[WARNING::179]
 64-bit constant "1099511627775" may not work in all languages.

[WARNING::179]
 64-bit constant "281474976710655" may not work in all languages.

[WARNING::179]
 64-bit constant "72057594037927935" may not work in all languages.

[WARNING::179]
 64-bit constant "9223372036854775807" may not work in all languages.

[WARNING::188]
 64-bit constant "4294967295" may not work in all languages.

[WARNING::188]
 64-bit constant "1099511627775" may not work in all languages.

[WARNING::188]
 64-bit constant "281474976710655" may not work in all languages.

[WARNING::188]
 64-bit constant "72057594037927935" may not work in all languages.

[WARNING::188]
 64-bit constant "9223372036854775807" may not work in all languages.

[WARNING::197]
 64-bit constant "9223372036854775807" may not work in all languages.

[WARNING::204]
 64-bit constant "9223372036854775807" may not work in all languages.

/bin/bash ../../../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. 
-I../../.. -I../../../lib/cpp/src -I/usr/include  -Wall -g -O2 -MT 
DebugProtoTest_types.lo -MD -MP -MF .deps/DebugProtoTest_types.Tpo -c -o 
DebugProtoTest_types.lo `test -f 'gen-cpp/DebugProtoTest_types.cpp' || echo 
'./'`gen-cpp/DebugProtoTest_types.cpp
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src 
-I/usr/include -Wall -g -O2 -MT DebugProtoTest_types.lo -MD -MP -MF 
.deps/DebugProtoTest_types.Tpo -c gen-cpp/DebugProtoTest_types.cpp  -fPIC -DPIC 
-o .libs/DebugProtoTest_types.o
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src 
-I/usr/include -Wall -g -O2 -MT DebugProtoTest_types.lo -MD -MP -MF 
.deps/DebugProtoTest_types.Tpo -c gen-cpp/DebugProtoTest_types.cpp -o 
DebugProtoTest_types.o >/dev/null 2>&1
mv -f .deps/DebugProtoTest_types.Tpo .deps/DebugProtoTest_types.Plo
../../../compiler/cpp/thrift --gen cpp:dense 
../../../test/OptionalRequiredTest.thrift
/bin/bash ../../../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. 
-I../../.. -I../../../lib/cpp/src -I/usr/include  -Wall -g -O2 -MT 
OptionalRequiredTest_types.lo -MD -MP -MF .deps/OptionalRequiredTest_types.Tpo 
-c -o OptionalRequiredTest_types.lo `test -f 
'gen-cpp/OptionalRequiredTest_types.cpp' || echo 
'./'`gen-cpp/OptionalRequiredTest_types.cpp
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src 
-I/usr/include -Wall -g -O2 -MT OptionalRequiredTest_types.lo -MD -MP -MF 
.deps/OptionalRequiredTest_types.Tpo -c gen-cpp/OptionalRequiredTest_types.cpp  
-fPIC -DPIC -o .libs/OptionalRequiredTest_types.o
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../../.. -I../../../lib/cpp/src 
-I/usr/include -Wall -g -O2 -MT OptionalRequiredTest_types.lo -MD -MP -MF 
.deps/OptionalRequiredTest_types.Tpo -c gen-cpp/OptionalRequiredTest_types.cpp 
-o OptionalRequiredTest_types.o >/dev/null 2>&1
mv -f .deps/OptionalRequiredTest_types.Tpo .deps/OptionalRequiredTest_types.Plo
../../../compiler/cpp/thrift --gen cpp:dense ../../../test/ThriftTest.thrift
/bin/bash ../../../libtool  --tag=

[jira] [Closed] (THRIFT-1350) Go library code does not build as of r60 (most recent release)

2011-09-19 Thread Jake Farrell (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell closed THRIFT-1350.


   Resolution: Fixed
Fix Version/s: 0.8
 Assignee: Kyle Consalus

Thanks for the patch, committed

> Go library code does not build as of r60 (most recent release)
> --
>
> Key: THRIFT-1350
> URL: https://issues.apache.org/jira/browse/THRIFT-1350
> Project: Thrift
>  Issue Type: Bug
>  Components: Go - Library
>Reporter: Kyle Consalus
>Assignee: Kyle Consalus
> Fix For: 0.8
>
> Attachments: patch.diff
>
>
> Go has moved it's URL-handling code into a "url" package.
> Also, strings.Split no longer takes a 3rd parameter.
> Not sure how I attach a patch, but here's a diff:
> http://pastie.org/2559636
> Or, a simple run of "gofix" should probably handle it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1350) Go library code does not build as of r60 (most recent release)

2011-09-19 Thread Kyle Consalus (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108207#comment-13108207
 ] 

Kyle Consalus commented on THRIFT-1350:
---

Yep, this is for the newest release version, r60 
(http://golang.org/doc/devel/release.html#r60)

And yes, good targeting releases is a good idea. That's what various distros 
will be carrying, what AppEngine runs, and what users are encouraged to use. 
Most breakages between releases can be fixed with a simple "gofix" tool that 
rewrites known changes.

> Go library code does not build as of r60 (most recent release)
> --
>
> Key: THRIFT-1350
> URL: https://issues.apache.org/jira/browse/THRIFT-1350
> Project: Thrift
>  Issue Type: Bug
>  Components: Go - Library
>Reporter: Kyle Consalus
> Attachments: patch.diff
>
>
> Go has moved it's URL-handling code into a "url" package.
> Also, strings.Split no longer takes a 3rd parameter.
> Not sure how I attach a patch, but here's a diff:
> http://pastie.org/2559636
> Or, a simple run of "gofix" should probably handle it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1350) Go library code does not build as of r60 (most recent release)

2011-09-19 Thread Jake Farrell (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108193#comment-13108193
 ] 

Jake Farrell commented on THRIFT-1350:
--

Kyle, is this in the GO trunk or the latest released version of GO? We ran into 
a problem like this before where GO changed how they handled a library in their 
trunk version and broke compatibility with our current release. We opted to 
keep the driver current with the latest released version of GO and not their 
trunk. If this is latest released GO version I'll gladly add it. Thanks for the 
patch, if you have any questions about contributing please see 
http://wiki.apache.org/thrift/HowToContribute or feel free to email our dev 
mailing list with any questions at dev@thrift.apache.org

> Go library code does not build as of r60 (most recent release)
> --
>
> Key: THRIFT-1350
> URL: https://issues.apache.org/jira/browse/THRIFT-1350
> Project: Thrift
>  Issue Type: Bug
>  Components: Go - Library
>Reporter: Kyle Consalus
> Attachments: patch.diff
>
>
> Go has moved it's URL-handling code into a "url" package.
> Also, strings.Split no longer takes a 3rd parameter.
> Not sure how I attach a patch, but here's a diff:
> http://pastie.org/2559636
> Or, a simple run of "gofix" should probably handle it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1350) Go library code does not build as of r60 (most recent release)

2011-09-19 Thread Kyle Consalus (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kyle Consalus updated THRIFT-1350:
--

Attachment: patch.diff

Diff from head of trunk.

> Go library code does not build as of r60 (most recent release)
> --
>
> Key: THRIFT-1350
> URL: https://issues.apache.org/jira/browse/THRIFT-1350
> Project: Thrift
>  Issue Type: Bug
>  Components: Go - Library
>Reporter: Kyle Consalus
> Attachments: patch.diff
>
>
> Go has moved it's URL-handling code into a "url" package.
> Also, strings.Split no longer takes a 3rd parameter.
> Not sure how I attach a patch, but here's a diff:
> http://pastie.org/2559636

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1350) Go library code does not build as of r60 (most recent release)

2011-09-19 Thread Kyle Consalus (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kyle Consalus updated THRIFT-1350:
--

Description: 
Go has moved it's URL-handling code into a "url" package.
Also, strings.Split no longer takes a 3rd parameter.


Not sure how I attach a patch, but here's a diff:

http://pastie.org/2559636

Or, a simple run of "gofix" should probably handle it.

  was:
Go has moved it's URL-handling code into a "url" package.
Also, strings.Split no longer takes a 3rd parameter.


Not sure how I attach a patch, but here's a diff:

http://pastie.org/2559636


> Go library code does not build as of r60 (most recent release)
> --
>
> Key: THRIFT-1350
> URL: https://issues.apache.org/jira/browse/THRIFT-1350
> Project: Thrift
>  Issue Type: Bug
>  Components: Go - Library
>Reporter: Kyle Consalus
> Attachments: patch.diff
>
>
> Go has moved it's URL-handling code into a "url" package.
> Also, strings.Split no longer takes a 3rd parameter.
> Not sure how I attach a patch, but here's a diff:
> http://pastie.org/2559636
> Or, a simple run of "gofix" should probably handle it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1350) Go library code does not build as of r60 (most recent release)

2011-09-19 Thread Kyle Consalus (JIRA) 
Go library code does not build as of r60 (most recent release)
--

 Key: THRIFT-1350
 URL: https://issues.apache.org/jira/browse/THRIFT-1350
 Project: Thrift
  Issue Type: Bug
  Components: Go - Library
Reporter: Kyle Consalus


Go has moved it's URL-handling code into a "url" package.
Also, strings.Split no longer takes a 3rd parameter.


Not sure how I attach a patch, but here's a diff:

http://pastie.org/2559636

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-582) C implementation of Thrift

2011-09-19 Thread Michael Lum (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108117#comment-13108117
 ] 

Michael Lum commented on THRIFT-582:


there shouldn't be any obstacles to using GSocket, just some time to implement 
it.
when i get some time i'll have a look at my msys/mingw environment

> C implementation of Thrift
> --
>
> Key: THRIFT-582
> URL: https://issues.apache.org/jira/browse/THRIFT-582
> Project: Thrift
>  Issue Type: New Feature
>  Components: C glib - Compiler, C glib - Library
>Reporter: David Reiss
>Assignee: Anatol Pomozov
>Priority: Minor
> Fix For: 0.6
>
> Attachments: c_glib_bindings.patch, t_c_generator.cc, 
> thrift_582_c_glib_bindings.patch, thrift_582_c_glib_bindings_20100927.patch, 
> thrift_582_c_glib_bindings_20101012.patch, 
> thrift_582_c_glib_bindings_20101026.patch
>
>
> Create a usable implementation of Thrift that uses only C at runtime, no C++. 
>  The code is at 
> http://svn.apache.org/repos/asf/incubator/thrift/branches/c-bindings/.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Issue Comment Edited] (THRIFT-1343) no_auto_import min/2 to avoid compile warning

2011-09-19 Thread Knut O. Hellan (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107673#comment-13107673
 ] 

Knut O. Hellan edited comment on THRIFT-1343 at 9/19/11 8:10 AM:
-

Compiling and running https://gist.github.com/1226130 with Erlang R13B03 does 
not give errors and the exported test function works as a min function. Adding 
the directive should not cause problems for R13B04 either.

That being said, using erlang:min/2 would have made more sense unless the point 
of the internal functions is to be very visible reminders that they should be 
removed at some point

  was (Author: khellan):
Compiling and running https://gist.github.com/1226130 with Erlang R13B03 
does not give errors and the exported test function works as a min function. 
Adding the directive should not cause problems for R13B04 either.

That being said, using erlang:min/2 would have made more sense unless the point 
of this is to works as reminders.
  
> no_auto_import min/2 to avoid compile warning
> -
>
> Key: THRIFT-1343
> URL: https://issues.apache.org/jira/browse/THRIFT-1343
> Project: Thrift
>  Issue Type: Improvement
>  Components: Erlang - Library
> Environment: I see the warnings when compiling with rebar and Erlang 
> R14B03 on Ubuntu
>Reporter: Knut O. Hellan
>Assignee: Anthony Molinaro
>Priority: Trivial
>  Labels: patch
> Attachments: no_auto_import_min_2
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The compiler issues a warning that is easily avoided with the provided patch

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1343) no_auto_import min/2 to avoid compile warning

2011-09-19 Thread Knut O. Hellan (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107673#comment-13107673
 ] 

Knut O. Hellan commented on THRIFT-1343:


Compiling and running https://gist.github.com/1226130 with Erlang R13B03 does 
not give errors and the exported test function works as a min function. Adding 
the directive should not cause problems for R13B04 either.

That being said, using erlang:min/2 would have made more sense unless the point 
of this is to works as reminders.

> no_auto_import min/2 to avoid compile warning
> -
>
> Key: THRIFT-1343
> URL: https://issues.apache.org/jira/browse/THRIFT-1343
> Project: Thrift
>  Issue Type: Improvement
>  Components: Erlang - Library
> Environment: I see the warnings when compiling with rebar and Erlang 
> R14B03 on Ubuntu
>Reporter: Knut O. Hellan
>Assignee: Anthony Molinaro
>Priority: Trivial
>  Labels: patch
> Attachments: no_auto_import_min_2
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The compiler issues a warning that is easily avoided with the provided patch

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira