[jira] [Commented] (THRIFT-1365) TupleProtocol#writeBitSet unintentionally writes a variable length byte array
[ https://issues.apache.org/jira/browse/THRIFT-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114981#comment-13114981 ] Hudson commented on THRIFT-1365: Integrated in Thrift #282 (See [https://builds.apache.org/job/Thrift/282/]) THRIFT-1365. java: TupleProtocol#writeBitSet unintentionally writes a variable length byte array bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1176072 Files : * /thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc * /thrift/trunk/lib/java/src/org/apache/thrift/protocol/TTupleProtocol.java * /thrift/trunk/lib/java/test/org/apache/thrift/protocol/TestTTupleProtocol.java * /thrift/trunk/test/DebugProtoTest.thrift > TupleProtocol#writeBitSet unintentionally writes a variable length byte array > - > > Key: THRIFT-1365 > URL: https://issues.apache.org/jira/browse/THRIFT-1365 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler, Java - Library >Reporter: Bryan Duxbury >Assignee: Bryan Duxbury > Fix For: 0.8 > > Attachments: thrift-1365.patch > > > BitSet.length() only returns the highest-set-bit, meaning that if you have > more than 8 optional fields, and the 9+th optional field is unset, then only > the first byte's worth of bits will be serialized. This leads to a problem on > the read side, where the bit vector is assumed to be fixed width, and > arbitrary deserialization occurs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1365) TupleProtocol#writeBitSet unintentionally writes a variable length byte array
[ https://issues.apache.org/jira/browse/THRIFT-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury closed THRIFT-1365. - Resolution: Fixed > TupleProtocol#writeBitSet unintentionally writes a variable length byte array > - > > Key: THRIFT-1365 > URL: https://issues.apache.org/jira/browse/THRIFT-1365 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler, Java - Library >Reporter: Bryan Duxbury >Assignee: Bryan Duxbury > Fix For: 0.8 > > Attachments: thrift-1365.patch > > > BitSet.length() only returns the highest-set-bit, meaning that if you have > more than 8 optional fields, and the 9+th optional field is unset, then only > the first byte's worth of bits will be serialized. This leads to a problem on > the read side, where the bit vector is assumed to be fixed width, and > arbitrary deserialization occurs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1365) TupleProtocol#writeBitSet unintentionally writes a variable length byte array
[ https://issues.apache.org/jira/browse/THRIFT-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-1365: -- Attachment: thrift-1365.patch This patch includes a test and fixes to the library and the compiler. > TupleProtocol#writeBitSet unintentionally writes a variable length byte array > - > > Key: THRIFT-1365 > URL: https://issues.apache.org/jira/browse/THRIFT-1365 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler, Java - Library >Reporter: Bryan Duxbury >Assignee: Bryan Duxbury > Fix For: 0.8 > > Attachments: thrift-1365.patch > > > BitSet.length() only returns the highest-set-bit, meaning that if you have > more than 8 optional fields, and the 9+th optional field is unset, then only > the first byte's worth of bits will be serialized. This leads to a problem on > the read side, where the bit vector is assumed to be fixed width, and > arbitrary deserialization occurs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (THRIFT-1365) TupleProtocol#writeBitSet unintentionally writes a variable length byte array
TupleProtocol#writeBitSet unintentionally writes a variable length byte array - Key: THRIFT-1365 URL: https://issues.apache.org/jira/browse/THRIFT-1365 Project: Thrift Issue Type: Bug Components: Java - Compiler, Java - Library Reporter: Bryan Duxbury Assignee: Bryan Duxbury Fix For: 0.8 BitSet.length() only returns the highest-set-bit, meaning that if you have more than 8 optional fields, and the 9+th optional field is unset, then only the first byte's worth of bits will be serialized. This leads to a problem on the read side, where the bit vector is assumed to be fixed width, and arbitrary deserialization occurs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (THRIFT-1364) Fully separate CompactProtocol and TupleProtocol
Fully separate CompactProtocol and TupleProtocol Key: THRIFT-1364 URL: https://issues.apache.org/jira/browse/THRIFT-1364 Project: Thrift Issue Type: Improvement Components: Java - Library Reporter: Bryan Duxbury Assignee: Bryan Duxbury Fix For: 0.8 They're not really the same protocol, so Tuple shouldn't extend Compact. I think it makes sense to factor out some common helper/encoding methods. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (THRIFT-1363) StandardSchemeFactory should return a static scheme
StandardSchemeFactory should return a static scheme --- Key: THRIFT-1363 URL: https://issues.apache.org/jira/browse/THRIFT-1363 Project: Thrift Issue Type: Improvement Components: Java - Compiler Reporter: Bryan Duxbury Fix For: 0.8 It's stateless. Everyone should be able to use just the one. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (THRIFT-1362) Once we've looked up the Scheme once, there's no need to look it up again
Once we've looked up the Scheme once, there's no need to look it up again - Key: THRIFT-1362 URL: https://issues.apache.org/jira/browse/THRIFT-1362 Project: Thrift Issue Type: Improvement Components: Java - Compiler Affects Versions: 0.8 Reporter: Bryan Duxbury Assignee: Bryan Duxbury Priority: Minor Fix For: 0.8 The first object that has the TProtocol version of write() or read() called should do the lookup, but after that, the scheme is known. Let's generate some overloads to write() and read() that take, for instance, TTupleProtocol so that we don't have to bother with doing the map lookup. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1031) Patch to compile Thrift for vc++ 9.0 and 10.0
[ https://issues.apache.org/jira/browse/THRIFT-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114788#comment-13114788 ] alexandre parenteau commented on THRIFT-1031: - @james: thanks for the link, it looks very nice! Unfortunately it does not compile with Thrift at the moment, I wrote a comment on the page. > Patch to compile Thrift for vc++ 9.0 and 10.0 > - > > Key: THRIFT-1031 > URL: https://issues.apache.org/jira/browse/THRIFT-1031 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Environment: Windows XP 32bit, vc++ 9.0, 10.0 >Reporter: James Dickson >Assignee: Roger Meier >Priority: Trivial > Fix For: 0.8 > > Attachments: thrift_msvc.patch, thrift_msvc_v0_1.patch, > thrift_msvc_v0_2.patch, thrift_msvc_v0_3.patch, thrift_msvc_v0_4.patch, > thrift_msvc_v0_5.patch, thrift_msvc_v0_6.patch, thrift_msvc_v0_7.patch > > > At our company we need clients running on Windows being able to connect to > our linux servers running hypertable. The attached patch enables the parts > needed by Hypertable to be compiled on Windows using either the VC++ 9.0 or > 10.0 compilers. > Having read previous posts about ports using boost::asio we found these to be > too intrusive for our needs. This version uses pthreads_win32 and winsock2 > and is as designed to be as un-intrusive as is possible to the original unix > code base. It is mostly #defines between unix sockets and winsock2 sockets. > We also tried to follow the folder structuring of the C# runtime that has > visual studio solutions to be consistent. > More details are in the README as not all the functionality of the original > unix code base is available to windows users. We will add the missing > functionality, we just wanted to share what we had as for a Windows based > client for us it is sufficient. > The patch is based on the latest revision in SVN, we would love feedback and > any code reviews. If there is any possibility of this being added to the main > trunk then that would be much appreciated, however we don't expect that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1357) Erlang Dependency breaks build
[
https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114745#comment-13114745
]
Hudson commented on THRIFT-1357:
Integrated in Thrift #280 (See [https://builds.apache.org/job/Thrift/280/])
THRIFT-1357: Erlang dependency breaks build
Client: erl
Patch: Peter Neumark
Updates json protocol to work with JSX 0.9.
jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1175906
Files :
* /thrift/trunk/lib/erl/src/thrift_json_protocol.erl
> Erlang Dependency breaks build
> --
>
> Key: THRIFT-1357
> URL: https://issues.apache.org/jira/browse/THRIFT-1357
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
> Environment: Apache build Infrastructure based on Ubuntu lucid
> {noformat}
> ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP virtual machine and base applicat
> ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP cryprographic modules
> ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP development libraries and headers
> ii erlang-eunit1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP module for unit testing
> ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP modules for handling abstract Erl
> ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP virtual machine and base applicat
> ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP cryprographic modules
> ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP development libraries and headers
> ii erlang-eunit1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP module for unit testing
> ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP modules for handling abstract Erl
> {noformat}
>Reporter: Roger Meier
>Assignee: Jake Farrell
> Attachments:
> 0001-Fixed-thrift_json_protocol.erl-to-work-with-JSX-v0.9.patch,
> 0001-updated-JSX-version.patch
>
>
> THRIFT-1227 introduced JSON for erlang,
> however the Ubuntu build infrastructur does not support this...
> {noformat}
> ./rebar get-deps
> ==> erl (get-deps)
> Pulling jsx from {git,"git://github.com/talentdeficit/jsx.git",{tag,"v0.9.0"}}
> Initialized empty Git repository in
> /home/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl/deps/jsx/.git/
> ==> nicefloats (get-deps)
> ==> jsx (get-deps)
> ./rebar compile
> ==> nicefloats (compile)
> Compiled src/nicefloats.erl
> ==> jsx (compile)
> ./include/jsx_common.hrl:34: type jsx_opt() undefined
> ./include/jsx_common.hrl:66: type jsx_parser_result() undefined
> ./include/jsx_common.hrl:82: type eep0018_array() undefined
> ./include/jsx_common.hrl:82: type eep0018_object() undefined
> ./include/jsx_common.hrl:84: type eep0018_term() undefined
> ./include/jsx_common.hrl:85: type eep0018_key() undefined
> ./include/jsx_common.hrl:85: type eep0018_term() undefined
> ./include/jsx_common.hrl:91: type eep0018_string() undefined
> ./include/jsx_common.hrl:92: type eep0018_number() undefined
> ./include/jsx_common.hrl:100: type encoder_opt() undefined
> ./include/jsx_common.hrl:109: type decoder_opt() undefined
> ./include/jsx_common.hrl:117: type verify_opt() undefined
> ./include/jsx_common.hrl:123: type format_opt() undefined
> make[3]: *** [all] Error 1
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1357) Erlang Dependency breaks build
[
https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114723#comment-13114723
]
Jake Farrell commented on THRIFT-1357:
--
Peter, I committed your changes. I am leaving this ticket open until i add the
erlang version check to configure to help guarantee a known env for erlang.
> Erlang Dependency breaks build
> --
>
> Key: THRIFT-1357
> URL: https://issues.apache.org/jira/browse/THRIFT-1357
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
> Environment: Apache build Infrastructure based on Ubuntu lucid
> {noformat}
> ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP virtual machine and base applicat
> ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP cryprographic modules
> ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP development libraries and headers
> ii erlang-eunit1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP module for unit testing
> ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP modules for handling abstract Erl
> ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP virtual machine and base applicat
> ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP cryprographic modules
> ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP development libraries and headers
> ii erlang-eunit1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP module for unit testing
> ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP modules for handling abstract Erl
> {noformat}
>Reporter: Roger Meier
>Assignee: Jake Farrell
> Attachments:
> 0001-Fixed-thrift_json_protocol.erl-to-work-with-JSX-v0.9.patch,
> 0001-updated-JSX-version.patch
>
>
> THRIFT-1227 introduced JSON for erlang,
> however the Ubuntu build infrastructur does not support this...
> {noformat}
> ./rebar get-deps
> ==> erl (get-deps)
> Pulling jsx from {git,"git://github.com/talentdeficit/jsx.git",{tag,"v0.9.0"}}
> Initialized empty Git repository in
> /home/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl/deps/jsx/.git/
> ==> nicefloats (get-deps)
> ==> jsx (get-deps)
> ./rebar compile
> ==> nicefloats (compile)
> Compiled src/nicefloats.erl
> ==> jsx (compile)
> ./include/jsx_common.hrl:34: type jsx_opt() undefined
> ./include/jsx_common.hrl:66: type jsx_parser_result() undefined
> ./include/jsx_common.hrl:82: type eep0018_array() undefined
> ./include/jsx_common.hrl:82: type eep0018_object() undefined
> ./include/jsx_common.hrl:84: type eep0018_term() undefined
> ./include/jsx_common.hrl:85: type eep0018_key() undefined
> ./include/jsx_common.hrl:85: type eep0018_term() undefined
> ./include/jsx_common.hrl:91: type eep0018_string() undefined
> ./include/jsx_common.hrl:92: type eep0018_number() undefined
> ./include/jsx_common.hrl:100: type encoder_opt() undefined
> ./include/jsx_common.hrl:109: type decoder_opt() undefined
> ./include/jsx_common.hrl:117: type verify_opt() undefined
> ./include/jsx_common.hrl:123: type format_opt() undefined
> make[3]: *** [all] Error 1
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1357) Erlang Dependency breaks build
[
https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Neumark updated THRIFT-1357:
--
Attachment: 0001-Fixed-thrift_json_protocol.erl-to-work-with-JSX-v0.9.patch
My apologies, 0001-Fixed-thrift_json_protocol.erl-to-work-with-JSX-v0.9.patch
should apply cleanly to trunk.
> Erlang Dependency breaks build
> --
>
> Key: THRIFT-1357
> URL: https://issues.apache.org/jira/browse/THRIFT-1357
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
> Environment: Apache build Infrastructure based on Ubuntu lucid
> {noformat}
> ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP virtual machine and base applicat
> ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP cryprographic modules
> ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP development libraries and headers
> ii erlang-eunit1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP module for unit testing
> ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP modules for handling abstract Erl
> ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP virtual machine and base applicat
> ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP cryprographic modules
> ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP development libraries and headers
> ii erlang-eunit1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP module for unit testing
> ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP modules for handling abstract Erl
> {noformat}
>Reporter: Roger Meier
>Assignee: Jake Farrell
> Attachments:
> 0001-Fixed-thrift_json_protocol.erl-to-work-with-JSX-v0.9.patch,
> 0001-updated-JSX-version.patch
>
>
> THRIFT-1227 introduced JSON for erlang,
> however the Ubuntu build infrastructur does not support this...
> {noformat}
> ./rebar get-deps
> ==> erl (get-deps)
> Pulling jsx from {git,"git://github.com/talentdeficit/jsx.git",{tag,"v0.9.0"}}
> Initialized empty Git repository in
> /home/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl/deps/jsx/.git/
> ==> nicefloats (get-deps)
> ==> jsx (get-deps)
> ./rebar compile
> ==> nicefloats (compile)
> Compiled src/nicefloats.erl
> ==> jsx (compile)
> ./include/jsx_common.hrl:34: type jsx_opt() undefined
> ./include/jsx_common.hrl:66: type jsx_parser_result() undefined
> ./include/jsx_common.hrl:82: type eep0018_array() undefined
> ./include/jsx_common.hrl:82: type eep0018_object() undefined
> ./include/jsx_common.hrl:84: type eep0018_term() undefined
> ./include/jsx_common.hrl:85: type eep0018_key() undefined
> ./include/jsx_common.hrl:85: type eep0018_term() undefined
> ./include/jsx_common.hrl:91: type eep0018_string() undefined
> ./include/jsx_common.hrl:92: type eep0018_number() undefined
> ./include/jsx_common.hrl:100: type encoder_opt() undefined
> ./include/jsx_common.hrl:109: type decoder_opt() undefined
> ./include/jsx_common.hrl:117: type verify_opt() undefined
> ./include/jsx_common.hrl:123: type format_opt() undefined
> make[3]: *** [all] Error 1
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1357) Erlang Dependency breaks build
[
https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114708#comment-13114708
]
Jake Farrell commented on THRIFT-1357:
--
Peter, this patch does not apply cleanly against trunk. What version was it
made against?
> Erlang Dependency breaks build
> --
>
> Key: THRIFT-1357
> URL: https://issues.apache.org/jira/browse/THRIFT-1357
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
> Environment: Apache build Infrastructure based on Ubuntu lucid
> {noformat}
> ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP virtual machine and base applicat
> ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP cryprographic modules
> ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP development libraries and headers
> ii erlang-eunit1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP module for unit testing
> ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP modules for handling abstract Erl
> ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP virtual machine and base applicat
> ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP cryprographic modules
> ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP development libraries and headers
> ii erlang-eunit1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP module for unit testing
> ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP modules for handling abstract Erl
> {noformat}
>Reporter: Roger Meier
>Assignee: Jake Farrell
> Attachments: 0001-updated-JSX-version.patch
>
>
> THRIFT-1227 introduced JSON for erlang,
> however the Ubuntu build infrastructur does not support this...
> {noformat}
> ./rebar get-deps
> ==> erl (get-deps)
> Pulling jsx from {git,"git://github.com/talentdeficit/jsx.git",{tag,"v0.9.0"}}
> Initialized empty Git repository in
> /home/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl/deps/jsx/.git/
> ==> nicefloats (get-deps)
> ==> jsx (get-deps)
> ./rebar compile
> ==> nicefloats (compile)
> Compiled src/nicefloats.erl
> ==> jsx (compile)
> ./include/jsx_common.hrl:34: type jsx_opt() undefined
> ./include/jsx_common.hrl:66: type jsx_parser_result() undefined
> ./include/jsx_common.hrl:82: type eep0018_array() undefined
> ./include/jsx_common.hrl:82: type eep0018_object() undefined
> ./include/jsx_common.hrl:84: type eep0018_term() undefined
> ./include/jsx_common.hrl:85: type eep0018_key() undefined
> ./include/jsx_common.hrl:85: type eep0018_term() undefined
> ./include/jsx_common.hrl:91: type eep0018_string() undefined
> ./include/jsx_common.hrl:92: type eep0018_number() undefined
> ./include/jsx_common.hrl:100: type encoder_opt() undefined
> ./include/jsx_common.hrl:109: type decoder_opt() undefined
> ./include/jsx_common.hrl:117: type verify_opt() undefined
> ./include/jsx_common.hrl:123: type format_opt() undefined
> make[3]: *** [all] Error 1
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1357) Erlang Dependency breaks build
[
https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Neumark updated THRIFT-1357:
--
Attachment: 0001-updated-JSX-version.patch
This patch fixes the compilation issue, which is due to the fact, that the JSX
api changed slightly with version 0.9.0
> Erlang Dependency breaks build
> --
>
> Key: THRIFT-1357
> URL: https://issues.apache.org/jira/browse/THRIFT-1357
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
> Environment: Apache build Infrastructure based on Ubuntu lucid
> {noformat}
> ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP virtual machine and base applicat
> ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP cryprographic modules
> ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP development libraries and headers
> ii erlang-eunit1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP module for unit testing
> ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP modules for handling abstract Erl
> ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP virtual machine and base applicat
> ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP cryprographic modules
> ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP development libraries and headers
> ii erlang-eunit1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP module for unit testing
> ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
> Erlang/OTP modules for handling abstract Erl
> {noformat}
>Reporter: Roger Meier
>Assignee: Jake Farrell
> Attachments: 0001-updated-JSX-version.patch
>
>
> THRIFT-1227 introduced JSON for erlang,
> however the Ubuntu build infrastructur does not support this...
> {noformat}
> ./rebar get-deps
> ==> erl (get-deps)
> Pulling jsx from {git,"git://github.com/talentdeficit/jsx.git",{tag,"v0.9.0"}}
> Initialized empty Git repository in
> /home/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl/deps/jsx/.git/
> ==> nicefloats (get-deps)
> ==> jsx (get-deps)
> ./rebar compile
> ==> nicefloats (compile)
> Compiled src/nicefloats.erl
> ==> jsx (compile)
> ./include/jsx_common.hrl:34: type jsx_opt() undefined
> ./include/jsx_common.hrl:66: type jsx_parser_result() undefined
> ./include/jsx_common.hrl:82: type eep0018_array() undefined
> ./include/jsx_common.hrl:82: type eep0018_object() undefined
> ./include/jsx_common.hrl:84: type eep0018_term() undefined
> ./include/jsx_common.hrl:85: type eep0018_key() undefined
> ./include/jsx_common.hrl:85: type eep0018_term() undefined
> ./include/jsx_common.hrl:91: type eep0018_string() undefined
> ./include/jsx_common.hrl:92: type eep0018_number() undefined
> ./include/jsx_common.hrl:100: type encoder_opt() undefined
> ./include/jsx_common.hrl:109: type decoder_opt() undefined
> ./include/jsx_common.hrl:117: type verify_opt() undefined
> ./include/jsx_common.hrl:123: type format_opt() undefined
> make[3]: *** [all] Error 1
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Assigned] (THRIFT-1357) Erlang Dependency breaks build
Hi!
The issue is not that JSX requires a specific verison of erlang.
Instead, we are faced with the fact that v0.9.0 has a slightly
different interface than what thrift_json_protocol.erl expects.
The attached patch resolves this issue.
As long as we use jsx 0.9.0, the problem should not resurface.
Regards,
Peter
On Fri, Sep 23, 2011 at 5:48 PM, Jake Farrell (JIRA) wrote:
>
> [
> https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Jake Farrell reassigned THRIFT-1357:
>
>
> Assignee: Jake Farrell
>
>> Erlang Dependency breaks build
>> --
>>
>> Key: THRIFT-1357
>> URL: https://issues.apache.org/jira/browse/THRIFT-1357
>> Project: Thrift
>> Issue Type: Bug
>> Components: Erlang - Library
>> Environment: Apache build Infrastructure based on Ubuntu lucid
>> {noformat}
>> ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
>> Erlang/OTP virtual machine and base applicat
>> ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
>> Erlang/OTP cryprographic modules
>> ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
>> Erlang/OTP development libraries and headers
>> ii erlang-eunit 1:13.b.3-dfsg-2ubuntu2.1
>> Erlang/OTP module for unit testing
>> ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
>> Erlang/OTP modules for handling abstract Erl
>> ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
>> Erlang/OTP virtual machine and base applicat
>> ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
>> Erlang/OTP cryprographic modules
>> ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
>> Erlang/OTP development libraries and headers
>> ii erlang-eunit 1:13.b.3-dfsg-2ubuntu2.1
>> Erlang/OTP module for unit testing
>> ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
>> Erlang/OTP modules for handling abstract Erl
>> {noformat}
>> Reporter: Roger Meier
>> Assignee: Jake Farrell
>>
>> THRIFT-1227 introduced JSON for erlang,
>> however the Ubuntu build infrastructur does not support this...
>> {noformat}
>> ./rebar get-deps
>> ==> erl (get-deps)
>> Pulling jsx from
>> {git,"git://github.com/talentdeficit/jsx.git",{tag,"v0.9.0"}}
>> Initialized empty Git repository in
>> /home/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl/deps/jsx/.git/
>> ==> nicefloats (get-deps)
>> ==> jsx (get-deps)
>> ./rebar compile
>> ==> nicefloats (compile)
>> Compiled src/nicefloats.erl
>> ==> jsx (compile)
>> ./include/jsx_common.hrl:34: type jsx_opt() undefined
>> ./include/jsx_common.hrl:66: type jsx_parser_result() undefined
>> ./include/jsx_common.hrl:82: type eep0018_array() undefined
>> ./include/jsx_common.hrl:82: type eep0018_object() undefined
>> ./include/jsx_common.hrl:84: type eep0018_term() undefined
>> ./include/jsx_common.hrl:85: type eep0018_key() undefined
>> ./include/jsx_common.hrl:85: type eep0018_term() undefined
>> ./include/jsx_common.hrl:91: type eep0018_string() undefined
>> ./include/jsx_common.hrl:92: type eep0018_number() undefined
>> ./include/jsx_common.hrl:100: type encoder_opt() undefined
>> ./include/jsx_common.hrl:109: type decoder_opt() undefined
>> ./include/jsx_common.hrl:117: type verify_opt() undefined
>> ./include/jsx_common.hrl:123: type format_opt() undefined
>> make[3]: *** [all] Error 1
>> {noformat}
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
[jira] [Commented] (THRIFT-1031) Patch to compile Thrift for vc++ 9.0 and 10.0
[ https://issues.apache.org/jira/browse/THRIFT-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114597#comment-13114597 ] James Dickson commented on THRIFT-1031: --- @alexandre: I will add that change back, I forgot to after testing it on XP. As regards the POSIX and 64bit issue I came across this: http://locklessinc.com/articles/pthreads_on_windows/ The implementation seems quite good and wondered what your thoughts were? It has a licence that I believe would be compatible. > Patch to compile Thrift for vc++ 9.0 and 10.0 > - > > Key: THRIFT-1031 > URL: https://issues.apache.org/jira/browse/THRIFT-1031 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Environment: Windows XP 32bit, vc++ 9.0, 10.0 >Reporter: James Dickson >Assignee: Roger Meier >Priority: Trivial > Fix For: 0.8 > > Attachments: thrift_msvc.patch, thrift_msvc_v0_1.patch, > thrift_msvc_v0_2.patch, thrift_msvc_v0_3.patch, thrift_msvc_v0_4.patch, > thrift_msvc_v0_5.patch, thrift_msvc_v0_6.patch, thrift_msvc_v0_7.patch > > > At our company we need clients running on Windows being able to connect to > our linux servers running hypertable. The attached patch enables the parts > needed by Hypertable to be compiled on Windows using either the VC++ 9.0 or > 10.0 compilers. > Having read previous posts about ports using boost::asio we found these to be > too intrusive for our needs. This version uses pthreads_win32 and winsock2 > and is as designed to be as un-intrusive as is possible to the original unix > code base. It is mostly #defines between unix sockets and winsock2 sockets. > We also tried to follow the folder structuring of the C# runtime that has > visual studio solutions to be consistent. > More details are in the README as not all the functionality of the original > unix code base is available to windows users. We will add the missing > functionality, we just wanted to share what we had as for a Windows based > client for us it is sufficient. > The patch is based on the latest revision in SVN, we would love feedback and > any code reviews. If there is any possibility of this being added to the main > trunk then that would be much appreciated, however we don't expect that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
