[jira] [Resolved] (THRIFT-1336) thrift: added server and processor test code
[ https://issues.apache.org/jira/browse/THRIFT-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-1336. - Resolution: Fixed Assignee: Dave Watson did some rework to fit new layout and committed thrift: added server and processor test code -- Key: THRIFT-1336 URL: https://issues.apache.org/jira/browse/THRIFT-1336 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Assignee: Dave Watson Priority: Minor Attachments: 0032-thrift-added-server-and-processor-test-code.patch davejwatson: Internally FB uses a different build system. I added stuff to the Makefile.am for these tests, but I'm not a makefile master, it would be nice to have a second set of eyes here From 2f30313189df5d5886298c96fcd6dfdf0e126d77 Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Fri, 23 Apr 2010 04:19:18 + Subject: [PATCH 32/33] thrift: added server and processor test code Summary: This code tests that the TServerEventHandler and TProcessorEventHandler hooks are invoked correctly by the server and event code. The test cases all start a server in a separate thread, then make some calls against it. The TServerEventHandler and TProcessorEventHandler record each time they are called, and the test code checks to make sure that the recorded calls match what is expected. Test Plan: Ran it. Currently it fails for several reasons. Several of the servers don't implement stop() properly, causing tests to hang trying to shutdown their server. TNonblockingServer also doesn't invoke the TProcessorEventHandler correctly when not using a ThreadManager. I have fixes for all of these, which I'll submit as separate diffs. Revert Plan: OK --- lib/cpp/Makefile.am | 47 ++- lib/cpp/src/processor/test/EventLog.cpp | 129 lib/cpp/src/processor/test/EventLog.h| 94 +++ lib/cpp/src/processor/test/Handlers.h| 341 ++ lib/cpp/src/processor/test/ProcessorTest.cpp | 941 ++ lib/cpp/src/processor/test/ServerThread.cpp | 148 lib/cpp/src/processor/test/ServerThread.h| 143 lib/cpp/src/processor/test/proc.thrift | 22 + 8 files changed, 1863 insertions(+), 2 deletions(-) create mode 100644 lib/cpp/src/processor/test/EventLog.cpp create mode 100644 lib/cpp/src/processor/test/EventLog.h create mode 100644 lib/cpp/src/processor/test/Handlers.h create mode 100644 lib/cpp/src/processor/test/ProcessorTest.cpp create mode 100644 lib/cpp/src/processor/test/ServerThread.cpp create mode 100644 lib/cpp/src/processor/test/ServerThread.h create mode 100644 lib/cpp/src/processor/test/proc.thrift -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Build failed in Jenkins: Thrift-cpp #339
See https://builds.apache.org/job/Thrift-cpp/339/changes Changes: [roger] THRIFT-1336 thrift: added server and processor test code Patch: Dave Watson - rework made by roger -- [...truncated 254 lines...] checking for working fork... yes checking for working vfork... (cached) yes checking for stdlib.h... (cached) yes checking for GNU libc compatible malloc... yes checking for working memcmp... yes checking for stdlib.h... (cached) yes checking for GNU libc compatible realloc... yes checking sys/select.h usability... yes checking sys/select.h presence... yes checking for sys/select.h... yes checking for sys/socket.h... (cached) yes checking types of arguments for select... int,fd_set *,struct timeval * checking whether lstat correctly handles trailing slash... yes checking whether stat accepts an empty string... no checking whether strerror_r is declared... yes checking for strerror_r... yes checking whether strerror_r returns char *... yes checking for strftime... yes checking for vprintf... yes checking for _doprnt... no checking for strtoul... yes checking for bzero... yes checking for ftruncate... yes checking for gethostbyname... yes checking for gettimeofday... yes checking for memmove... yes checking for memset... yes checking for mkdir... yes checking for realpath... yes checking for select... yes checking for socket... yes checking for strchr... yes checking for strdup... yes checking for strerror... yes checking for strstr... yes checking for strtol... yes checking for sqrt... yes checking for alarm... yes checking for clock_gettime... yes checking for sched_get_priority_min... yes checking for sched_get_priority_max... yes checking the behavior of a signed right shift... arithmetic configure: creating ./config.status config.status: creating Makefile config.status: creating compiler/cpp/Makefile config.status: creating compiler/cpp/version.h config.status: creating lib/Makefile config.status: creating lib/cpp/Makefile config.status: creating lib/cpp/test/Makefile config.status: creating lib/cpp/thrift-nb.pc config.status: creating lib/cpp/thrift-z.pc config.status: creating lib/cpp/thrift-qt.pc config.status: creating lib/cpp/thrift.pc config.status: creating lib/c_glib/Makefile config.status: creating lib/c_glib/thrift_c_glib.pc config.status: creating lib/c_glib/test/Makefile config.status: creating lib/csharp/Makefile config.status: creating lib/d/Makefile config.status: creating lib/d/test/Makefile config.status: creating lib/erl/Makefile config.status: creating lib/hs/Makefile config.status: creating lib/java/Makefile config.status: creating lib/js/test/Makefile config.status: creating lib/perl/Makefile config.status: creating lib/perl/test/Makefile config.status: creating lib/php/Makefile config.status: creating lib/php/test/Makefile config.status: creating lib/py/Makefile config.status: creating lib/rb/Makefile config.status: creating test/Makefile config.status: creating test/cpp/Makefile config.status: creating test/hs/Makefile config.status: creating test/nodejs/Makefile config.status: creating test/php/Makefile config.status: creating test/perl/Makefile config.status: creating test/py/Makefile config.status: creating test/py.twisted/Makefile config.status: creating test/rb/Makefile config.status: creating config.h config.status: executing depfiles commands config.status: executing libtool commands thrift 0.9.0-dev Building code generators . : Building C++ Library . : no Building C (GLib) Library : no Building Java Library : no Building C# Library .. : no Building Python Library .. : no Building Ruby Library : no Building Haskell Library . : no Building Perl Library : no Building PHP Library . : no Building Erlang Library .. : no Building Go Library .. : no Building D Library ... : no If something is missing that you think should be present, please skim the output of configure to find the missing component. Details are present in config.log. + make make all-recursive make[1]: Entering directory `https://builds.apache.org/job/Thrift-cpp/ws/thrift' Making all in compiler/cpp make[2]: Entering directory `https://builds.apache.org/job/Thrift-cpp/ws/thrift/compiler/cpp' make all-am make[3]: Entering directory `https://builds.apache.org/job/Thrift-cpp/ws/thrift/compiler/cpp' \ \ /bin/bash ../../ylwrap `test -f 'src/thrifty.yy' || echo './'`src/thrifty.yy y.tab.c thrifty.cc y.tab.h thrifty.h y.output thrifty.output -- bison -y -d updating thrifty.h g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wno-long-long -Wno-variadic-macros -Wno-overflow -Werror -Wall -Wno-sign-compare -Wno-unused -Wno-long-long -Wno-variadic-macros -Wno-overflow -Werror -MT libparse_a-thrifty.o -MD -MP -MF .deps/libparse_a-thrifty.Tpo -c -o libparse_a-thrifty.o `test -f 'thrifty.cc' || echo './'`thrifty.cc mv -f .deps/libparse_a-thrifty.Tpo
Build failed in Jenkins: Thrift-Debian-Packages #226
See https://builds.apache.org/job/Thrift-Debian-Packages/226/changes Changes: [roger] THRIFT-1336 thrift: added server and processor test code Patch: Dave Watson - rework made by roger -- [...truncated 866 lines...] libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I/include/boost-0 -I./src -I./src/thrift -Wall -g -O2 -MT TDenseProtocol.lo -MD -MP -MF .deps/TDenseProtocol.Tpo -c src/thrift/protocol/TDenseProtocol.cpp -o TDenseProtocol.o /dev/null 21 mv -f .deps/TDenseProtocol.Tpo .deps/TDenseProtocol.Plo /bin/bash ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I../.. -I/include/boost-0 -I./src -I./src/thrift -Wall -g -O2 -MT TJSONProtocol.lo -MD -MP -MF .deps/TJSONProtocol.Tpo -c -o TJSONProtocol.lo `test -f 'src/thrift/protocol/TJSONProtocol.cpp' || echo './'`src/thrift/protocol/TJSONProtocol.cpp libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I/include/boost-0 -I./src -I./src/thrift -Wall -g -O2 -MT TJSONProtocol.lo -MD -MP -MF .deps/TJSONProtocol.Tpo -c src/thrift/protocol/TJSONProtocol.cpp -fPIC -DPIC -o .libs/TJSONProtocol.o libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I/include/boost-0 -I./src -I./src/thrift -Wall -g -O2 -MT TJSONProtocol.lo -MD -MP -MF .deps/TJSONProtocol.Tpo -c src/thrift/protocol/TJSONProtocol.cpp -o TJSONProtocol.o /dev/null 21 mv -f .deps/TJSONProtocol.Tpo .deps/TJSONProtocol.Plo /bin/bash ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I../.. -I/include/boost-0 -I./src -I./src/thrift -Wall -g -O2 -MT TBase64Utils.lo -MD -MP -MF .deps/TBase64Utils.Tpo -c -o TBase64Utils.lo `test -f 'src/thrift/protocol/TBase64Utils.cpp' || echo './'`src/thrift/protocol/TBase64Utils.cpp libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I/include/boost-0 -I./src -I./src/thrift -Wall -g -O2 -MT TBase64Utils.lo -MD -MP -MF .deps/TBase64Utils.Tpo -c src/thrift/protocol/TBase64Utils.cpp -fPIC -DPIC -o .libs/TBase64Utils.o libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I/include/boost-0 -I./src -I./src/thrift -Wall -g -O2 -MT TBase64Utils.lo -MD -MP -MF .deps/TBase64Utils.Tpo -c src/thrift/protocol/TBase64Utils.cpp -o TBase64Utils.o /dev/null 21 mv -f .deps/TBase64Utils.Tpo .deps/TBase64Utils.Plo /bin/bash ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I../.. -I/include/boost-0 -I./src -I./src/thrift -Wall -g -O2 -MT TTransportException.lo -MD -MP -MF .deps/TTransportException.Tpo -c -o TTransportException.lo `test -f 'src/thrift/transport/TTransportException.cpp' || echo './'`src/thrift/transport/TTransportException.cpp libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I/include/boost-0 -I./src -I./src/thrift -Wall -g -O2 -MT TTransportException.lo -MD -MP -MF .deps/TTransportException.Tpo -c src/thrift/transport/TTransportException.cpp -fPIC -DPIC -o .libs/TTransportException.o libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I/include/boost-0 -I./src -I./src/thrift -Wall -g -O2 -MT TTransportException.lo -MD -MP -MF .deps/TTransportException.Tpo -c src/thrift/transport/TTransportException.cpp -o TTransportException.o /dev/null 21 mv -f .deps/TTransportException.Tpo .deps/TTransportException.Plo /bin/bash ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I../.. -I/include/boost-0 -I./src -I./src/thrift -Wall -g -O2 -MT TFDTransport.lo -MD -MP -MF .deps/TFDTransport.Tpo -c -o TFDTransport.lo `test -f 'src/thrift/transport/TFDTransport.cpp' || echo './'`src/thrift/transport/TFDTransport.cpp libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I/include/boost-0 -I./src -I./src/thrift -Wall -g -O2 -MT TFDTransport.lo -MD -MP -MF .deps/TFDTransport.Tpo -c src/thrift/transport/TFDTransport.cpp -fPIC -DPIC -o .libs/TFDTransport.o libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I/include/boost-0 -I./src -I./src/thrift -Wall -g -O2 -MT TFDTransport.lo -MD -MP -MF .deps/TFDTransport.Tpo -c src/thrift/transport/TFDTransport.cpp -o TFDTransport.o /dev/null 21 mv -f .deps/TFDTransport.Tpo .deps/TFDTransport.Plo /bin/bash ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I../.. -I/include/boost-0 -I./src -I./src/thrift -Wall -g -O2 -MT TFileTransport.lo -MD -MP -MF .deps/TFileTransport.Tpo -c -o TFileTransport.lo `test -f 'src/thrift/transport/TFileTransport.cpp' || echo './'`src/thrift/transport/TFileTransport.cpp libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I/include/boost-0 -I./src -I./src/thrift -Wall -g -O2 -MT TFileTransport.lo -MD -MP -MF .deps/TFileTransport.Tpo -c src/thrift/transport/TFileTransport.cpp -fPIC -DPIC -o .libs/TFileTransport.o src/thrift/transport/TFileTransport.cpp: In member function 'void apache::thrift::transport::TFileTransport::writerThread()': src/thrift/transport/TFileTransport.cpp:357: warning: ignoring return value of 'int ftruncate(int, __off_t)', declared with attribute warn_unused_result src/thrift/transport/TFileTransport.cpp: In member
Build failed in Jenkins: Thrift #459
See https://builds.apache.org/job/Thrift/459/changes Changes: [roger] THRIFT-1336 thrift: added server and processor test code Patch: Dave Watson - rework made by roger -- [...truncated 12981 lines...] [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:183] 64-bit constant 1099511627775 may not work in all languages. [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:183] 64-bit constant 281474976710655 may not work in all languages. [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:183] 64-bit constant 72057594037927935 may not work in all languages. [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:183] 64-bit constant 9223372036854775807 may not work in all languages. [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:192] 64-bit constant 4294967295 may not work in all languages. [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:192] 64-bit constant 1099511627775 may not work in all languages. [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:192] 64-bit constant 281474976710655 may not work in all languages. [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:192] 64-bit constant 72057594037927935 may not work in all languages. [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:192] 64-bit constant 9223372036854775807 may not work in all languages. [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:201] 64-bit constant 9223372036854775807 may not work in all languages. [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:208] 64-bit constant 9223372036854775807 may not work in all languages. [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:355] No field key specified for field1, resulting protocol may have conflicts or not be backwards compatible! [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:356] No field key specified for field2, resulting protocol may have conflicts or not be backwards compatible! [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:357] No field key specified for field3, resulting protocol may have conflicts or not be backwards compatible! [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:358] No field key specified for field4, resulting protocol may have conflicts or not be backwards compatible! [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:359] No field key specified for field5, resulting protocol may have conflicts or not be backwards compatible! [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:360] No field key specified for field6, resulting protocol may have conflicts or not be backwards compatible! [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:361] No field key specified for field7, resulting protocol may have conflicts or not be backwards compatible! [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:362] No field key specified for field8, resulting protocol may have conflicts or not be backwards compatible! [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:363] No field key specified for field9, resulting protocol may have conflicts or not be backwards compatible! [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:364] No field key specified for field10, resulting protocol may have conflicts or not be backwards compatible! [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:365] No field key specified for field11, resulting protocol may have conflicts or not be backwards compatible! [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:366] No field key specified for field12, resulting protocol may have conflicts or not be backwards compatible! ../../compiler/cpp/thrift --gen hs ../ThriftTest.thrift sh run-test.sh ConstantsDemo Generating bindings... Running test... SERVER: Ready... SERVER: SERVER: Got blingity SERVER: SERVER: Got blangity CLIENT: 31 SUCCESS sh run-test.sh DebugProtoTest Generating bindings... [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:41] 64-bit constant 100 may not work in all languages. [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:173] 64-bit constant 1099511627775 may not work in all languages. [WARNING:https://builds.apache.org/job/Thrift/ws/thrift/test/DebugProtoTest.thrift:183] 64-bit constant 4294967295 may not work
[jira] [Commented] (THRIFT-1336) thrift: added server and processor test code
[ https://issues.apache.org/jira/browse/THRIFT-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272324#comment-13272324 ] Hudson commented on THRIFT-1336: Integrated in Thrift #459 (See [https://builds.apache.org/job/Thrift/459/]) THRIFT-1336 thrift: added server and processor test code Patch: Dave Watson - rework made by roger (Revision 1336544) Result = FAILURE roger : http://svn.apache.org/viewvc/?view=revrev=1336544 Files : * /thrift/trunk/lib/cpp/Makefile.am * /thrift/trunk/lib/cpp/src/thrift/processor/test * /thrift/trunk/lib/cpp/src/thrift/processor/test/EventLog.cpp * /thrift/trunk/lib/cpp/src/thrift/processor/test/EventLog.h * /thrift/trunk/lib/cpp/src/thrift/processor/test/Handlers.h * /thrift/trunk/lib/cpp/src/thrift/processor/test/ProcessorTest.cpp * /thrift/trunk/lib/cpp/src/thrift/processor/test/ServerThread.cpp * /thrift/trunk/lib/cpp/src/thrift/processor/test/ServerThread.h * /thrift/trunk/lib/cpp/src/thrift/processor/test/proc.thrift thrift: added server and processor test code -- Key: THRIFT-1336 URL: https://issues.apache.org/jira/browse/THRIFT-1336 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Assignee: Dave Watson Priority: Minor Attachments: 0032-thrift-added-server-and-processor-test-code.patch davejwatson: Internally FB uses a different build system. I added stuff to the Makefile.am for these tests, but I'm not a makefile master, it would be nice to have a second set of eyes here From 2f30313189df5d5886298c96fcd6dfdf0e126d77 Mon Sep 17 00:00:00 2001 From: Adam Simpkins simpk...@fb.com Date: Fri, 23 Apr 2010 04:19:18 + Subject: [PATCH 32/33] thrift: added server and processor test code Summary: This code tests that the TServerEventHandler and TProcessorEventHandler hooks are invoked correctly by the server and event code. The test cases all start a server in a separate thread, then make some calls against it. The TServerEventHandler and TProcessorEventHandler record each time they are called, and the test code checks to make sure that the recorded calls match what is expected. Test Plan: Ran it. Currently it fails for several reasons. Several of the servers don't implement stop() properly, causing tests to hang trying to shutdown their server. TNonblockingServer also doesn't invoke the TProcessorEventHandler correctly when not using a ThreadManager. I have fixes for all of these, which I'll submit as separate diffs. Revert Plan: OK --- lib/cpp/Makefile.am | 47 ++- lib/cpp/src/processor/test/EventLog.cpp | 129 lib/cpp/src/processor/test/EventLog.h| 94 +++ lib/cpp/src/processor/test/Handlers.h| 341 ++ lib/cpp/src/processor/test/ProcessorTest.cpp | 941 ++ lib/cpp/src/processor/test/ServerThread.cpp | 148 lib/cpp/src/processor/test/ServerThread.h| 143 lib/cpp/src/processor/test/proc.thrift | 22 + 8 files changed, 1863 insertions(+), 2 deletions(-) create mode 100644 lib/cpp/src/processor/test/EventLog.cpp create mode 100644 lib/cpp/src/processor/test/EventLog.h create mode 100644 lib/cpp/src/processor/test/Handlers.h create mode 100644 lib/cpp/src/processor/test/ProcessorTest.cpp create mode 100644 lib/cpp/src/processor/test/ServerThread.cpp create mode 100644 lib/cpp/src/processor/test/ServerThread.h create mode 100644 lib/cpp/src/processor/test/proc.thrift -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (THRIFT-1602) PHP C Extension is not Compatible with PHP 5.4
Tyler Hobbs created THRIFT-1602:
---
Summary: PHP C Extension is not Compatible with PHP 5.4
Key: THRIFT-1602
URL: https://issues.apache.org/jira/browse/THRIFT-1602
Project: Thrift
Issue Type: Bug
Components: PHP - Library
Affects Versions: 0.8
Reporter: Tyler Hobbs
When running make with php 5.4, you'll get:
{{...thrift/ext/thrift_protocol/php_thrift_protocol.cpp:95:8: error:
'function_entry' does not name a type}}
This is caused by {{function_entry}} being replaced by {{zend_function_entry}}
https://bugs.php.net/bug.php?id=60016
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Jenkins build is back to normal : Thrift-cpp #340
See https://builds.apache.org/job/Thrift-cpp/340/changes
Build failed in Jenkins: Thrift-Debian-Packages #227
See https://builds.apache.org/job/Thrift-Debian-Packages/227/changes Changes: [roger] fix broken build introduced with THRIFT-1336 -- [...truncated 788 lines...] g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_java_generator.o -MD -MP -MF .deps/thrift-t_java_generator.Tpo -c -o thrift-t_java_generator.o `test -f 'src/generate/t_java_generator.cc' || echo './'`src/generate/t_java_generator.cc mv -f .deps/thrift-t_java_generator.Tpo .deps/thrift-t_java_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_as3_generator.o -MD -MP -MF .deps/thrift-t_as3_generator.Tpo -c -o thrift-t_as3_generator.o `test -f 'src/generate/t_as3_generator.cc' || echo './'`src/generate/t_as3_generator.cc mv -f .deps/thrift-t_as3_generator.Tpo .deps/thrift-t_as3_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_csharp_generator.o -MD -MP -MF .deps/thrift-t_csharp_generator.Tpo -c -o thrift-t_csharp_generator.o `test -f 'src/generate/t_csharp_generator.cc' || echo './'`src/generate/t_csharp_generator.cc mv -f .deps/thrift-t_csharp_generator.Tpo .deps/thrift-t_csharp_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_py_generator.o -MD -MP -MF .deps/thrift-t_py_generator.Tpo -c -o thrift-t_py_generator.o `test -f 'src/generate/t_py_generator.cc' || echo './'`src/generate/t_py_generator.cc mv -f .deps/thrift-t_py_generator.Tpo .deps/thrift-t_py_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_rb_generator.o -MD -MP -MF .deps/thrift-t_rb_generator.Tpo -c -o thrift-t_rb_generator.o `test -f 'src/generate/t_rb_generator.cc' || echo './'`src/generate/t_rb_generator.cc mv -f .deps/thrift-t_rb_generator.Tpo .deps/thrift-t_rb_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_perl_generator.o -MD -MP -MF .deps/thrift-t_perl_generator.Tpo -c -o thrift-t_perl_generator.o `test -f 'src/generate/t_perl_generator.cc' || echo './'`src/generate/t_perl_generator.cc mv -f .deps/thrift-t_perl_generator.Tpo .deps/thrift-t_perl_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_php_generator.o -MD -MP -MF .deps/thrift-t_php_generator.Tpo -c -o thrift-t_php_generator.o `test -f 'src/generate/t_php_generator.cc' || echo './'`src/generate/t_php_generator.cc mv -f .deps/thrift-t_php_generator.Tpo .deps/thrift-t_php_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_erl_generator.o -MD -MP -MF .deps/thrift-t_erl_generator.Tpo -c -o thrift-t_erl_generator.o `test -f 'src/generate/t_erl_generator.cc' || echo './'`src/generate/t_erl_generator.cc mv -f .deps/thrift-t_erl_generator.Tpo .deps/thrift-t_erl_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_cocoa_generator.o -MD -MP -MF .deps/thrift-t_cocoa_generator.Tpo -c -o thrift-t_cocoa_generator.o `test -f 'src/generate/t_cocoa_generator.cc' || echo './'`src/generate/t_cocoa_generator.cc mv -f .deps/thrift-t_cocoa_generator.Tpo .deps/thrift-t_cocoa_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_st_generator.o -MD -MP -MF .deps/thrift-t_st_generator.Tpo -c -o thrift-t_st_generator.o `test -f 'src/generate/t_st_generator.cc' || echo './'`src/generate/t_st_generator.cc mv -f .deps/thrift-t_st_generator.Tpo .deps/thrift-t_st_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_ocaml_generator.o -MD -MP -MF .deps/thrift-t_ocaml_generator.Tpo -c -o thrift-t_ocaml_generator.o `test -f 'src/generate/t_ocaml_generator.cc' || echo './'`src/generate/t_ocaml_generator.cc mv -f .deps/thrift-t_ocaml_generator.Tpo .deps/thrift-t_ocaml_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_hs_generator.o -MD -MP -MF .deps/thrift-t_hs_generator.Tpo -c -o thrift-t_hs_generator.o `test -f 'src/generate/t_hs_generator.cc' || echo './'`src/generate/t_hs_generator.cc mv -f .deps/thrift-t_hs_generator.Tpo .deps/thrift-t_hs_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_xsd_generator.o -MD -MP -MF .deps/thrift-t_xsd_generator.Tpo -c -o thrift-t_xsd_generator.o `test -f 'src/generate/t_xsd_generator.cc' || echo './'`src/generate/t_xsd_generator.cc mv -f .deps/thrift-t_xsd_generator.Tpo .deps/thrift-t_xsd_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_html_generator.o -MD -MP -MF .deps/thrift-t_html_generator.Tpo -c -o thrift-t_html_generator.o `test -f 'src/generate/t_html_generator.cc' || echo './'`src/generate/t_html_generator.cc mv -f .deps/thrift-t_html_generator.Tpo .deps/thrift-t_html_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_js_generator.o -MD -MP -MF .deps/thrift-t_js_generator.Tpo -c -o thrift-t_js_generator.o `test -f 'src/generate/t_js_generator.cc' || echo
Jenkins build is back to normal : Thrift #460
See https://builds.apache.org/job/Thrift/460/changes
[jira] [Reopened] (THRIFT-1574) Apache project branding requirements: DOAP file [PATCH]
[ https://issues.apache.org/jira/browse/THRIFT-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell reopened THRIFT-1574: -- Apache project branding requirements: DOAP file [PATCH] --- Key: THRIFT-1574 URL: https://issues.apache.org/jira/browse/THRIFT-1574 Project: Thrift Issue Type: Improvement Reporter: Shane Curcuru Assignee: Roger Meier Labels: branding Attachments: doap_thrift.rdf Attached. Re: http://www.apache.org/foundation/marks/pmcs See Also: http://projects.apache.org/create.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1079) Support i64 in AS3
[ https://issues.apache.org/jira/browse/THRIFT-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272989#comment-13272989 ] Jake Farrell commented on THRIFT-1079: -- reverted until this can be reworked to not break the release Support i64 in AS3 -- Key: THRIFT-1079 URL: https://issues.apache.org/jira/browse/THRIFT-1079 Project: Thrift Issue Type: Improvement Components: AS3 - Compiler Reporter: Rowan Kerr Assignee: Jake Farrell Priority: Minor Attachments: THRIFT-1079_64_bit_support_in_as3.patch Would be nice to have i64 support for AS3. Although it's not straight forward. Found a previous bit of discussion about AS3 i64 support here: http://mail-archives.apache.org/mod_mbox/incubator-thrift-dev/201002.mbox/%3cdfc1ae6d1002091950s3eb71f6dl1381ea1bece3a...@mail.gmail.com%3e -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Build failed in Jenkins: Thrift-Debian-Packages #228
See https://builds.apache.org/job/Thrift-Debian-Packages/228/changes Changes: [jfarrell] Thrift-1079:Support i64 in AS3 Client: as3 Patch: Reverting Reverting patch due to usage of non public library which breaks ability to export as3 client to maven central during a release. -- [...truncated 711 lines...] g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_java_generator.o -MD -MP -MF .deps/thrift-t_java_generator.Tpo -c -o thrift-t_java_generator.o `test -f 'src/generate/t_java_generator.cc' || echo './'`src/generate/t_java_generator.cc mv -f .deps/thrift-t_java_generator.Tpo .deps/thrift-t_java_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_as3_generator.o -MD -MP -MF .deps/thrift-t_as3_generator.Tpo -c -o thrift-t_as3_generator.o `test -f 'src/generate/t_as3_generator.cc' || echo './'`src/generate/t_as3_generator.cc mv -f .deps/thrift-t_as3_generator.Tpo .deps/thrift-t_as3_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_csharp_generator.o -MD -MP -MF .deps/thrift-t_csharp_generator.Tpo -c -o thrift-t_csharp_generator.o `test -f 'src/generate/t_csharp_generator.cc' || echo './'`src/generate/t_csharp_generator.cc mv -f .deps/thrift-t_csharp_generator.Tpo .deps/thrift-t_csharp_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_py_generator.o -MD -MP -MF .deps/thrift-t_py_generator.Tpo -c -o thrift-t_py_generator.o `test -f 'src/generate/t_py_generator.cc' || echo './'`src/generate/t_py_generator.cc mv -f .deps/thrift-t_py_generator.Tpo .deps/thrift-t_py_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_rb_generator.o -MD -MP -MF .deps/thrift-t_rb_generator.Tpo -c -o thrift-t_rb_generator.o `test -f 'src/generate/t_rb_generator.cc' || echo './'`src/generate/t_rb_generator.cc mv -f .deps/thrift-t_rb_generator.Tpo .deps/thrift-t_rb_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_perl_generator.o -MD -MP -MF .deps/thrift-t_perl_generator.Tpo -c -o thrift-t_perl_generator.o `test -f 'src/generate/t_perl_generator.cc' || echo './'`src/generate/t_perl_generator.cc mv -f .deps/thrift-t_perl_generator.Tpo .deps/thrift-t_perl_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_php_generator.o -MD -MP -MF .deps/thrift-t_php_generator.Tpo -c -o thrift-t_php_generator.o `test -f 'src/generate/t_php_generator.cc' || echo './'`src/generate/t_php_generator.cc mv -f .deps/thrift-t_php_generator.Tpo .deps/thrift-t_php_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_erl_generator.o -MD -MP -MF .deps/thrift-t_erl_generator.Tpo -c -o thrift-t_erl_generator.o `test -f 'src/generate/t_erl_generator.cc' || echo './'`src/generate/t_erl_generator.cc mv -f .deps/thrift-t_erl_generator.Tpo .deps/thrift-t_erl_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_cocoa_generator.o -MD -MP -MF .deps/thrift-t_cocoa_generator.Tpo -c -o thrift-t_cocoa_generator.o `test -f 'src/generate/t_cocoa_generator.cc' || echo './'`src/generate/t_cocoa_generator.cc mv -f .deps/thrift-t_cocoa_generator.Tpo .deps/thrift-t_cocoa_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_st_generator.o -MD -MP -MF .deps/thrift-t_st_generator.Tpo -c -o thrift-t_st_generator.o `test -f 'src/generate/t_st_generator.cc' || echo './'`src/generate/t_st_generator.cc mv -f .deps/thrift-t_st_generator.Tpo .deps/thrift-t_st_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_ocaml_generator.o -MD -MP -MF .deps/thrift-t_ocaml_generator.Tpo -c -o thrift-t_ocaml_generator.o `test -f 'src/generate/t_ocaml_generator.cc' || echo './'`src/generate/t_ocaml_generator.cc mv -f .deps/thrift-t_ocaml_generator.Tpo .deps/thrift-t_ocaml_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_hs_generator.o -MD -MP -MF .deps/thrift-t_hs_generator.Tpo -c -o thrift-t_hs_generator.o `test -f 'src/generate/t_hs_generator.cc' || echo './'`src/generate/t_hs_generator.cc mv -f .deps/thrift-t_hs_generator.Tpo .deps/thrift-t_hs_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_xsd_generator.o -MD -MP -MF .deps/thrift-t_xsd_generator.Tpo -c -o thrift-t_xsd_generator.o `test -f 'src/generate/t_xsd_generator.cc' || echo './'`src/generate/t_xsd_generator.cc mv -f .deps/thrift-t_xsd_generator.Tpo .deps/thrift-t_xsd_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_html_generator.o -MD -MP -MF .deps/thrift-t_html_generator.Tpo -c -o thrift-t_html_generator.o `test -f 'src/generate/t_html_generator.cc' || echo './'`src/generate/t_html_generator.cc mv -f .deps/thrift-t_html_generator.Tpo .deps/thrift-t_html_generator.Po g++ -DHAVE_CONFIG_H -I. -I../.. -I./src -Wall -g -O2 -MT thrift-t_js_generator.o -MD -MP
[jira] [Commented] (THRIFT-1598) Update Haskell generated code to use Text, Hash{Map,Set}, Vector
[
https://issues.apache.org/jira/browse/THRIFT-1598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272993#comment-13272993
]
Jake Farrell commented on THRIFT-1598:
--
please create a patch and attach with asf inclusion. If you have any questions
see http://thrift.apache.org/docs/HowToContribute/ for submitting patches
Update Haskell generated code to use Text, Hash{Map,Set}, Vector
Key: THRIFT-1598
URL: https://issues.apache.org/jira/browse/THRIFT-1598
Project: Thrift
Issue Type: Improvement
Components: Haskell - Compiler
Affects Versions: 0.9
Reporter: Itai Zukerman
Priority: Minor
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1599) Fixing HTTP client
[ https://issues.apache.org/jira/browse/THRIFT-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272992#comment-13272992 ] Jake Farrell commented on THRIFT-1599: -- please create a patch and attach with asf inclusion. If you have any questions see http://thrift.apache.org/docs/HowToContribute/ for submitting patches Fixing HTTP client -- Key: THRIFT-1599 URL: https://issues.apache.org/jira/browse/THRIFT-1599 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.8 Reporter: Tomas Correct way of using Net::HTTP (ruby 1.8.x, 1.9.x) https://github.com/apache/thrift/pull/12 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1079) Support i64 in AS3
[ https://issues.apache.org/jira/browse/THRIFT-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272998#comment-13272998 ] Hudson commented on THRIFT-1079: Integrated in Thrift #461 (See [https://builds.apache.org/job/Thrift/461/]) Thrift-1079:Support i64 in AS3 Client: as3 Patch: Reverting Reverting patch due to usage of non public library which breaks ability to export as3 client to maven central during a release. (Revision 1337007) Result = SUCCESS Support i64 in AS3 -- Key: THRIFT-1079 URL: https://issues.apache.org/jira/browse/THRIFT-1079 Project: Thrift Issue Type: Improvement Components: AS3 - Compiler Reporter: Rowan Kerr Assignee: Jake Farrell Priority: Minor Attachments: THRIFT-1079_64_bit_support_in_as3.patch Would be nice to have i64 support for AS3. Although it's not straight forward. Found a previous bit of discussion about AS3 i64 support here: http://mail-archives.apache.org/mod_mbox/incubator-thrift-dev/201002.mbox/%3cdfc1ae6d1002091950s3eb71f6dl1381ea1bece3a...@mail.gmail.com%3e -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1544) Create correct Ruby namespace directories
[
https://issues.apache.org/jira/browse/THRIFT-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273010#comment-13273010
]
Jake Farrell commented on THRIFT-1544:
--
tested on os x lion, got the following error with default system ruby 1.8.7.
thrift/trunk/lib/rb/spec/../test/debug_proto/gen-rb/srv.rb:8:in `require': no
such file to load -- /debug_proto_test_types (LoadError)
Create correct Ruby namespace directories
-
Key: THRIFT-1544
URL: https://issues.apache.org/jira/browse/THRIFT-1544
Project: Thrift
Issue Type: Improvement
Components: Ruby - Compiler
Affects Versions: 0.8
Reporter: Adam Stegman
Assignee: Jake Farrell
Priority: Minor
Labels: compiler, namespaces, patch, ruby
Fix For: 0.9
Attachments: Namespace-generated-Ruby-files-correctly.patch
Creating correct Ruby namespace directories, very similar to how Java creates
package directories. e.g. {noformat}namespace java com.example.my_lib
namespace rb com.example.my_lib{noformat} should both result in
gen-{rb,java}/com/example/my_lib/my_lib_service.{rb,java}.
Patch attached.
See also [THRIFT-474|https://issues.apache.org/jira/browse/THRIFT-474] where
a similar patch was included intermingled with a patch for a different issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1602) PHP C Extension is not Compatible with PHP 5.4
[
https://issues.apache.org/jira/browse/THRIFT-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-1602.
Resolution: Duplicate
Fix Version/s: 0.9
Duplicates THRIFT-1577
PHP C Extension is not Compatible with PHP 5.4
--
Key: THRIFT-1602
URL: https://issues.apache.org/jira/browse/THRIFT-1602
Project: Thrift
Issue Type: Bug
Components: PHP - Library
Affects Versions: 0.8
Reporter: Tyler Hobbs
Assignee: Jake Farrell
Fix For: 0.9
When running make with php 5.4, you'll get:
{{...thrift/ext/thrift_protocol/php_thrift_protocol.cpp:95:8: error:
'function_entry' does not name a type}}
This is caused by {{function_entry}} being replaced by
{{zend_function_entry}} https://bugs.php.net/bug.php?id=60016
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
