Re: [VOTE] Release Apache Thrift 0.9.0
Belated +1, and also a big *Thank You* for helping move thrift forward another step. We've come a long way! -w -- Will Pierce On Mon, Oct 15, 2012 at 7:18 AM, Jake Farrell wrote: > With 3 binding +1's, 1 other +1 and no -1's the 0.9.0 release candidate > passes. I'll get it ready and start distributing the release shortly. > > Thanks to all who contributed to this release > -Jake
[jira] [Commented] (THRIFT-1708) Add event handlers for processor events
[ https://issues.apache.org/jira/browse/THRIFT-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476564#comment-13476564 ] Diwaker Gupta commented on THRIFT-1708: --- I'd love to see this in the next 0.9.x release! [~andrewcox79] consider splitting the patch in two: one that adds TServerEventHandler support to the non-blocking servers, and then add ProcessorEventHandler support in a subsequent patch. > Add event handlers for processor events > --- > > Key: THRIFT-1708 > URL: https://issues.apache.org/jira/browse/THRIFT-1708 > Project: Thrift > Issue Type: New Feature > Components: Java - Library >Affects Versions: 0.9 > Environment: all >Reporter: Andrew Cox >Assignee: Andrew Cox >Priority: Minor > Fix For: 1.0 > > Attachments: thrift-1708-processor-event-handlers.patch > > > Integrates some code we've been using (here at facebook) to add event > handlers that can handle processor events with the server event handlers in > apache thrift. > Processor events include: preRead (before reading arguments), postRead (after > reading arguments), preWrite (before writing results), postWrite (after > writing results), and processorError (when a non-IDL exception is thrown as a > result of an error handling the request). The processor handler is given the > method name and input and output protocol that will be used to process the > request, and can inspect arguments on postRead, and results on pre/postWrite > events. > This change also enables event handlers for non-blocking servers. > Some unit tests are included to exercise the new processor event handlers, > and demonstrate how they can connect with server event handlers. > It also fixes a minor bug I found while testing, where FrameBuffers on > non-blocking servers could have been close()'d more than once. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (THRIFT-1732) Thrift should provide deep-validation of structures
Avi Flamholz created THRIFT-1732: Summary: Thrift should provide deep-validation of structures Key: THRIFT-1732 URL: https://issues.apache.org/jira/browse/THRIFT-1732 Project: Thrift Issue Type: New Feature Components: Python - Compiler Affects Versions: 0.9 Environment: All. Reporter: Avi Flamholz Priority: Minor The validate() method in Python does extremely shallow validation: it checks only that required fields are not None. It does not check that field values have the correct type or that embedded structures or collections are valid. This is paltry validation as compared to IsInitialized() in the Python Protocol Buffers implementation, which descends into embedded structures and checks that they are valid. Not to mention that ProtocolBuffers also check value types on assignment. It is fairly simple to generate a deep_validate() method that will recursively descend into structures and collections and call validate() on those which can be validated. I've written something of the sort and I'm curious if it would be a welcome addition to the Python generated code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [VOTE] Release Apache Thrift 0.9.0
With 3 binding +1's, 1 other +1 and no -1's the 0.9.0 release candidate passes. I'll get it ready and start distributing the release shortly. Thanks to all who contributed to this release -Jake On Thu, Oct 11, 2012 at 9:15 PM, Jake Farrell wrote: > All, > I propose that we accept > http://people.apache.org/~jfarrell/thrift/0.9.0/thrift-0.9.0-rc.tar.gz > as the official Thrift 0.9.0 release. > > The release candidate is created from > http://svn.apache.org/repos/asf/thrift/branches/0.9.x > > The GPG signature can be found at: > http://people.apache.org/~jfarrell/thrift/0.9.0/thrift-0.9.0-rc.tar.gz.asc > It has an MD5 sum of a42c37b645a9103192ad7dfabe4f0086 > > The CHANGES list for this release if available at: > http://svn.apache.org/repos/asf/thrift/branches/0.9.x/CHANGES > > The Java artifacts for libthrift, libthrift-as3 and libfb303 are available > at: > http://people.apache.org/~jfarrell/thrift/0.9.0/lib/java > http://people.apache.org/~jfarrell/thrift/0.9.0/lib/as3 > http://people.apache.org/~jfarrell/thrift/0.9.0/contrib/fb303/java > > The debian packages, windows compiler, and packaged clients are > available at: > http://people.apache.org/~jfarrell/thrift/0.9.0/ > > Please download, verify sig/sum, and install/test the libraries of your > choice. > > This vote closes in 72 hours. > > -Jake >
