[jira] [Commented] (THRIFT-1713) Named and Anonymous Pipe transport (Delphi)
[ https://issues.apache.org/jira/browse/THRIFT-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479071#comment-13479071 ] Kenjiro Fukumitsu commented on THRIFT-1713: --- Thanks, Jens! +1 > Named and Anonymous Pipe transport (Delphi) > --- > > Key: THRIFT-1713 > URL: https://issues.apache.org/jira/browse/THRIFT-1713 > Project: Thrift > Issue Type: Bug > Components: Delphi - Library > Environment: Windows >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 1.0 > > Attachments: > TRHIFT-1713_Named_and_Anonymous_Pipe_transport_Delphi_02_refactoring_rev3.patch, > TRHIFT-1713_Named_and_Anonymous_Pipe_transport_Delphi.patch > > > Adds pipe support similar to THRIFT-1558 (in fact, most of the code is based > on that version, many thanks Peace!). > The implementation has been successfully tested using the standard test > server/client, appropriate switches have been added to both programs. > However, the code has neither been tested against another language > implementation, nor under strict security settings for the pipes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1734) Front webpage is still advertising v0.8 as current release
[ https://issues.apache.org/jira/browse/THRIFT-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479009#comment-13479009 ] Chris Stylianou commented on THRIFT-1734: - Gah! All of my web browser had the front page cached, sorry for raising a non-issue. > Front webpage is still advertising v0.8 as current release > -- > > Key: THRIFT-1734 > URL: https://issues.apache.org/jira/browse/THRIFT-1734 > Project: Thrift > Issue Type: Bug > Components: Website >Reporter: Chris Stylianou >Assignee: Jake Farrell >Priority: Trivial > Labels: release, releasegeneration, website > Fix For: 1.0 > > > The front webpage of http://thrift.apache.org is still displaying the current > release version as v0.8, instead of the newly released v0.9 as displayed on > the downloads page. > I presume this is because the instructions at > http://thrift.apache.org/docs/committers/HowToPublish do not specify that > this page needs updating as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1734) Front webpage is still advertising v0.8 as current release
[ https://issues.apache.org/jira/browse/THRIFT-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1734. Resolution: Not A Problem Fix Version/s: 1.0 This is all autoversioned via the config file, not seeing 0.8.0 anywhere on the main page of http://thrift.apache.org > Front webpage is still advertising v0.8 as current release > -- > > Key: THRIFT-1734 > URL: https://issues.apache.org/jira/browse/THRIFT-1734 > Project: Thrift > Issue Type: Bug > Components: Website >Reporter: Chris Stylianou >Assignee: Jake Farrell >Priority: Trivial > Labels: release, releasegeneration, website > Fix For: 1.0 > > > The front webpage of http://thrift.apache.org is still displaying the current > release version as v0.8, instead of the newly released v0.9 as displayed on > the downloads page. > I presume this is because the instructions at > http://thrift.apache.org/docs/committers/HowToPublish do not specify that > this page needs updating as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-1734) Front webpage is still advertising v0.8 as current release
[ https://issues.apache.org/jira/browse/THRIFT-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell reassigned THRIFT-1734: Assignee: Jake Farrell > Front webpage is still advertising v0.8 as current release > -- > > Key: THRIFT-1734 > URL: https://issues.apache.org/jira/browse/THRIFT-1734 > Project: Thrift > Issue Type: Bug > Components: Website >Reporter: Chris Stylianou >Assignee: Jake Farrell >Priority: Trivial > Labels: release, releasegeneration, website > > The front webpage of http://thrift.apache.org is still displaying the current > release version as v0.8, instead of the newly released v0.9 as displayed on > the downloads page. > I presume this is because the instructions at > http://thrift.apache.org/docs/committers/HowToPublish do not specify that > this page needs updating as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (THRIFT-1734) Front webpage is still advertising v0.8 as current release
Chris Stylianou created THRIFT-1734: --- Summary: Front webpage is still advertising v0.8 as current release Key: THRIFT-1734 URL: https://issues.apache.org/jira/browse/THRIFT-1734 Project: Thrift Issue Type: Bug Components: Website Reporter: Chris Stylianou Priority: Trivial The front webpage of http://thrift.apache.org is still displaying the current release version as v0.8, instead of the newly released v0.9 as displayed on the downloads page. I presume this is because the instructions at http://thrift.apache.org/docs/committers/HowToPublish do not specify that this page needs updating as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
AW: [jira] [Commented] (THRIFT-1727) Ruby-1.9: data loss: "binary" fields are re-encoded
It's not to sat that binary is not supported at all. It's about the
inconsistencies.
Von: Jens Geyer
Gesendet: 18.10.2012 08:59
An: dev@thrift.apache.org
Betreff: AW: [jira] [Commented] (THRIFT-1727) Ruby-1.9: data loss: "binary"
fields are re-encoded
Hi Nathan,
I referred to the binary data type.
This one is in a semi-defined state, and IIRC there exist slightly different
ways how binary fields are handled throughout the various languages. A ticket
with some discussion already exists, can't remember the number right now.
The web site says ( or did say in the past) something to the effect that that
binary is intended to become a fully supported real data type some day in the
future.
Greetings,
Jens
Von: Nathan Beyer
Gesendet: 18.10.2012 03:13
An: dev@thrift.apache.org
Betreff: Re: [jira] [Commented] (THRIFT-1727) Ruby-1.9: data loss: "binary"
fields are re-encoded
Jens, Can you elaborate on the clean up that you'd like to see? I
missed your previous comments, but would like to read them if you can
put them up again or post some links.
On Fri, Oct 12, 2012 at 2:03 AM, Jens Geyer wrote:
> Again I would propose to clean that up in general. Same confusion happens at
> other places too.
>
> $0,02
> Jens
>
> Von: XB (JIRA)
> Gesendet: 12.10.2012 00:15
> An: dev@thrift.apache.org
> Betreff: [jira] [Commented] (THRIFT-1727) Ruby-1.9: data loss: "binary"
> fields are re-encoded
>
>
> [
> https://issues.apache.org/jira/browse/THRIFT-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474556#comment-13474556
> ]
>
> XB commented on THRIFT-1727:
>
>
> The problem lies within the confusion between thrift "binary" fields and
> thrift "string" fields. Typically, "string" fields (sequences of characters)
> are reduced to "binary" fields (sequence of bytes). However, in the current
> Thrift Ruby implementation, the converse is done: sequences of bytes are
> reduced to sequences of characters (represented by the Ruby String type). The
> problem is that the higher layers do the reduction from sequences of bytes to
> sequences of characters, but the lower layers do not recognize sequences of
> bytes at all anymore, and just know sequences of characters. Then, these
> sequences of characters are in turn converted into sequences of bytes (for
> the wire-format).
>
> This patch solves the problem:
>
> {noformat}
> diff --git a/lib/rb/ext/binary_protocol_accelerated.c
> b/lib/rb/ext/binary_protocol_accelerated.c
> index a8ebe7f..b75acf5 100644
> --- a/lib/rb/ext/binary_protocol_accelerated.c
> +++ b/lib/rb/ext/binary_protocol_accelerated.c
> @@ -81,7 +81,7 @@ static void write_string_direct(VALUE trans, VALUE str) {
>if (TYPE(str) != T_STRING) {
> rb_raise(rb_eStandardError, "Value should be a string");
>}
> - str = convert_to_utf8_byte_buffer(str);
> + str = convert_to_byte_buffer(str);
>write_i32_direct(trans, RSTRING_LEN(str));
>rb_funcall(trans, write_method_id, 1, str);
> }
> diff --git a/lib/rb/ext/bytes.c b/lib/rb/ext/bytes.c
> index 8a6fac4..d767cf4 100644
> --- a/lib/rb/ext/bytes.c
> +++ b/lib/rb/ext/bytes.c
> @@ -27,8 +27,8 @@ VALUE force_binary_encoding(VALUE buffer) {
>return rb_funcall(thrift_bytes_module, force_binary_encoding_id, 1,
> buffer);
> }
>
> -VALUE convert_to_utf8_byte_buffer(VALUE string) {
> - return rb_funcall(thrift_bytes_module, convert_to_utf8_byte_buffer_id, 1,
> string);
> +VALUE convert_to_byte_buffer(VALUE string) {
> + return rb_funcall(thrift_bytes_module, convert_to_byte_buffer_id, 1,
> string);
> }
>
> VALUE convert_to_string(VALUE utf8_buffer) {
> diff --git a/lib/rb/ext/bytes.h b/lib/rb/ext/bytes.h
> index 7108d83..a74b2c4 100644
> --- a/lib/rb/ext/bytes.h
> +++ b/lib/rb/ext/bytes.h
> @@ -27,5 +27,5 @@
> */
>
> VALUE force_binary_encoding(VALUE buffer);
> -VALUE convert_to_utf8_byte_buffer(VALUE string);
> +VALUE convert_to_byte_buffer(VALUE string);
> VALUE convert_to_string(VALUE utf8_buffer);
> diff --git a/lib/rb/ext/compact_protocol.c b/lib/rb/ext/compact_protocol.c
> index 0c05481..513c379 100644
> --- a/lib/rb/ext/compact_protocol.c
> +++ b/lib/rb/ext/compact_protocol.c
> @@ -306,7 +306,7 @@ VALUE rb_thrift_compact_proto_write_double(VALUE self,
> VALUE dub) {
>
> VALUE rb_thrift_compact_proto_write_string(VALUE self, VALUE str) {
>VALUE transport = GET_TRANSPORT(self);
> - str = convert_to_utf8_byte_buffer(str);
> + str = convert_to_byte_buffer(str);
>write_varint32(transport, RSTRING_LEN(str));
>WRITE(transport, RSTRING_PTR(str), RSTRING_LEN(str));
>return Qnil;
> diff --git a/lib/rb/ext/constants.h b/lib/rb/ext/constants.h
> index 3bfac88..499734c 100644
> --- a/lib/rb/ext/constants.h
> +++ b/lib/rb/ext/constants.h
> @@ -77,7 +77,7 @@ extern ID read_all_method_id;
> extern ID read_into_buffer_method_id;
> extern ID nat
