[jira] [Commented] (THRIFT-1353) Switch to performance branch, get rid of BinaryParser
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484622#comment-13484622 ] Jake Farrell commented on THRIFT-1353: -- Sorry John, didnt understand what your comment was implying. Henrique can you please take a look at this as you where the committer > Switch to performance branch, get rid of BinaryParser > - > > Key: THRIFT-1353 > URL: https://issues.apache.org/jira/browse/THRIFT-1353 > Project: Thrift > Issue Type: Improvement > Components: Node.js - Library >Affects Versions: 0.7 >Reporter: Hans Duedal >Assignee: Henrique Mendonca > Labels: node, nodejs > Fix For: 1.0 > > Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch > > > I vote that the thrift library switches to the performance branch at > https://github.com/wadey/node-thrift/tree/performance > I much prefer using the node.js buffers over the BinaryParser class, the > performance branch seems focused on this very issue. Also it includes the > excellent int64 implementation from broofa. What's not to like? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get rid of BinaryParser
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484550#comment-13484550 ] John Eckhart commented on THRIFT-1353: -- I appreciate that you can't copy that file without following your process; however, I am pointing out that your most recent merge missed a file and therefore broke the node client. The missing file is also in the patch that the original author attached to the ticket after following the contribution process. > Switch to performance branch, get rid of BinaryParser > - > > Key: THRIFT-1353 > URL: https://issues.apache.org/jira/browse/THRIFT-1353 > Project: Thrift > Issue Type: Improvement > Components: Node.js - Library >Affects Versions: 0.7 >Reporter: Hans Duedal >Assignee: Henrique Mendonca > Labels: node, nodejs > Fix For: 1.0 > > Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch > > > I vote that the thrift library switches to the performance branch at > https://github.com/wadey/node-thrift/tree/performance > I much prefer using the node.js buffers over the BinaryParser class, the > performance branch seems focused on this very issue. Also it includes the > excellent int64 implementation from broofa. What's not to like? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get rid of BinaryParser
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484542#comment-13484542 ] Jake Farrell commented on THRIFT-1353: -- John, We can not copy files from github and just add them to the codebase due to legal rights, please see http://thrift.apache.org/docs/HowToContribute/ for details on making contributions > Switch to performance branch, get rid of BinaryParser > - > > Key: THRIFT-1353 > URL: https://issues.apache.org/jira/browse/THRIFT-1353 > Project: Thrift > Issue Type: Improvement > Components: Node.js - Library >Affects Versions: 0.7 >Reporter: Hans Duedal >Assignee: Henrique Mendonca > Labels: node, nodejs > Fix For: 1.0 > > Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch > > > I vote that the thrift library switches to the performance branch at > https://github.com/wadey/node-thrift/tree/performance > I much prefer using the node.js buffers over the BinaryParser class, the > performance branch seems focused on this very issue. Also it includes the > excellent int64 implementation from broofa. What's not to like? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get rid of BinaryParser
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484508#comment-13484508 ] John Eckhart commented on THRIFT-1353: -- Looks like you missed a file (binary.js) which is not the same as binary_parser.js that is in the release branch. Here's a link to the original file: https://raw.github.com/wadey/node-thrift/performance/lib/thrift/binary.js > Switch to performance branch, get rid of BinaryParser > - > > Key: THRIFT-1353 > URL: https://issues.apache.org/jira/browse/THRIFT-1353 > Project: Thrift > Issue Type: Improvement > Components: Node.js - Library >Affects Versions: 0.7 >Reporter: Hans Duedal >Assignee: Henrique Mendonca > Labels: node, nodejs > Fix For: 1.0 > > Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch > > > I vote that the thrift library switches to the performance branch at > https://github.com/wadey/node-thrift/tree/performance > I much prefer using the node.js buffers over the BinaryParser class, the > performance branch seems focused on this very issue. Also it includes the > excellent int64 implementation from broofa. What's not to like? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (THRIFT-1742) Optionally implement hashcode and equals in c#
T Jake Luciani created THRIFT-1742: -- Summary: Optionally implement hashcode and equals in c# Key: THRIFT-1742 URL: https://issues.apache.org/jira/browse/THRIFT-1742 Project: Thrift Issue Type: Improvement Components: C# - Compiler Reporter: T Jake Luciani It would be very helpful to have a compiler flag that implements hashCode and equals for c# generated structs. Java has this capability. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
thrift pull request: Fix for service inheritance. The service was always ex...
GitHub user eamonnmoloney opened a pull request: https://github.com/apache/thrift/pull/28 Fix for service inheritance. The service was always extending NSObject. ... ...It will now extend the superclass if it exists You can merge this pull request into a Git repository by running: $ git pull https://github.com/eamonnmoloney/thrift trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/28.patch commit 1388edb6f3dfdef30baf495c0306d6dfcaf63fdc Author: Eamonn Moloney Date: 2012-10-25T02:53:17-07:00 Fix for service inheritance. The service was always extending NSObject. It will now extend the superclass if it exists
Re: Python JSON protocol implementation
And C# -Ursprüngliche Nachricht- From: Henrique Mendonça Sent: Wednesday, October 24, 2012 11:33 PM To: dev@thrift.apache.org Subject: Re: Python JSON protocol implementation Hi Frederic, This is awesome news! It would be really great if you could add a little inline web server to test it against the JavaScript version. But that's totally up to you, at least Java and C++ implement this protocol already. Merci! Henrique On 24 October 2012 23:25, Frederic Delbos wrote: Thank for the answer, I'll get back to you soon. 2012/10/24 Roger Meier > Cool! > > lib/py/test unit test => some languages have this within test/py > test/py/ThriftTest.thrift client and server > test/test.shcross language test suite > tutorial/py tutorial.thrift implementation > > http://thrift.apache.org/docs/HowToContribute/ > > thanks > -roger > ;-r > > > -Ursprüngliche Nachricht- > > Von: Frederic Delbos [mailto:fred.del...@gmail.com] > > Gesendet: Mittwoch, 24. Oktober 2012 22:56 > > An: dev@thrift.apache.org > > Betreff: Python JSON protocol implementation > > > > Hello, > > > > I have written a python JSON protocol implementation : > > https://gist.github.com/3948701 > > > > I'm in the process of testing it... > > > > If the Thrift team is interested I would like to integrate it to the > project. What > > are the requirements (test, code...) ? > > > > > > bye > > > > -- > > Frederic DELBOS > > -- Frederic DELBOS
Re: Python JSON protocol implementation
Not to mention Delphi :-) -Ursprüngliche Nachricht- From: Henrique Mendonça Sent: Wednesday, October 24, 2012 11:33 PM To: dev@thrift.apache.org Subject: Re: Python JSON protocol implementation Hi Frederic, This is awesome news! It would be really great if you could add a little inline web server to test it against the JavaScript version. But that's totally up to you, at least Java and C++ implement this protocol already. Merci! Henrique On 24 October 2012 23:25, Frederic Delbos wrote: Thank for the answer, I'll get back to you soon. 2012/10/24 Roger Meier > Cool! > > lib/py/test unit test => some languages have this within test/py > test/py/ThriftTest.thrift client and server > test/test.shcross language test suite > tutorial/py tutorial.thrift implementation > > http://thrift.apache.org/docs/HowToContribute/ > > thanks > -roger > ;-r > > > -Ursprüngliche Nachricht- > > Von: Frederic Delbos [mailto:fred.del...@gmail.com] > > Gesendet: Mittwoch, 24. Oktober 2012 22:56 > > An: dev@thrift.apache.org > > Betreff: Python JSON protocol implementation > > > > Hello, > > > > I have written a python JSON protocol implementation : > > https://gist.github.com/3948701 > > > > I'm in the process of testing it... > > > > If the Thrift team is interested I would like to integrate it to the > project. What > > are the requirements (test, code...) ? > > > > > > bye > > > > -- > > Frederic DELBOS > > -- Frederic DELBOS
