[jira] [Commented] (THRIFT-1708) Add event handlers for processor events
[ https://issues.apache.org/jira/browse/THRIFT-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609963#comment-13609963 ] George Cao commented on THRIFT-1708: Is this patch accepted or rejected? Any progress? > Add event handlers for processor events > --- > > Key: THRIFT-1708 > URL: https://issues.apache.org/jira/browse/THRIFT-1708 > Project: Thrift > Issue Type: New Feature > Components: Java - Library >Affects Versions: 0.9 > Environment: all >Reporter: Andrew Cox >Assignee: Andrew Cox >Priority: Minor > Fix For: 1.0 > > Attachments: thrift-1708-processor-event-handlers.patch > > > Integrates some code we've been using (here at facebook) to add event > handlers that can handle processor events with the server event handlers in > apache thrift. > Processor events include: preRead (before reading arguments), postRead (after > reading arguments), preWrite (before writing results), postWrite (after > writing results), and processorError (when a non-IDL exception is thrown as a > result of an error handling the request). The processor handler is given the > method name and input and output protocol that will be used to process the > request, and can inspect arguments on postRead, and results on pre/postWrite > events. > This change also enables event handlers for non-blocking servers. > Some unit tests are included to exercise the new processor event handlers, > and demonstrate how they can connect with server event handlers. > It also fixes a minor bug I found while testing, where FrameBuffers on > non-blocking servers could have been close()'d more than once. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1895) Delphi: reserved variable name "result" not detected properly
[ https://issues.apache.org/jira/browse/THRIFT-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-1895. Resolution: Fixed > Delphi: reserved variable name "result" not detected properly > - > > Key: THRIFT-1895 > URL: https://issues.apache.org/jira/browse/THRIFT-1895 > Project: Thrift > Issue Type: Bug > Components: Delphi - Compiler >Affects Versions: 0.9 >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Trivial > Fix For: 1.0 > > Attachments: > THRIFT-1895_Delphi_reserved_variable_name_result_not_detected_properly.patch > > > Struct members named "result" lead to uncompileable code in the > ToString()-methods. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1895) Delphi: reserved variable name "result" not detected properly
[ https://issues.apache.org/jira/browse/THRIFT-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609224#comment-13609224 ] Jens Geyer commented on THRIFT-1895: Committed. > Delphi: reserved variable name "result" not detected properly > - > > Key: THRIFT-1895 > URL: https://issues.apache.org/jira/browse/THRIFT-1895 > Project: Thrift > Issue Type: Bug > Components: Delphi - Compiler >Affects Versions: 0.9 >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Trivial > Fix For: 1.0 > > Attachments: > THRIFT-1895_Delphi_reserved_variable_name_result_not_detected_properly.patch > > > Struct members named "result" lead to uncompileable code in the > ToString()-methods. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1777) TPipeServer is UNSTOPPABLE
[ https://issues.apache.org/jira/browse/THRIFT-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-1777. Resolution: Fixed Resolved in THRIFT-1890 > TPipeServer is UNSTOPPABLE > -- > > Key: THRIFT-1777 > URL: https://issues.apache.org/jira/browse/THRIFT-1777 > Project: Thrift > Issue Type: Bug > Components: C++ - Library > Environment: Windows >Reporter: Ben Craig > Fix For: 1.0 > > > Most TServer stop methods call interrupt on their underlying server > transports. TPipeServer::interrupt() doesn't cause acceptImpl to wake up if > it is blocked on ConnectNamedPipe. This means the stop method on TServer > variants blocks. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1890) C++: Make named pipes server work asynchronously
[ https://issues.apache.org/jira/browse/THRIFT-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-1890. Resolution: Fixed Committed. > C++: Make named pipes server work asynchronously > - > > Key: THRIFT-1890 > URL: https://issues.apache.org/jira/browse/THRIFT-1890 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Environment: Windows >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 1.0 > > Attachments: addNumbers.thrift, pipeStopTest.cpp, > THRIFT-1890_Cpp_Make_named_pipes_server_work_asynchronously-v3.patch, > TPipeServer.cpp > > > Currently the named pipe server cannot be stopped gracefully due to the way > ConnectNamedPipe() works for synchronous named pipes. The recommended > solution is to run the pipe in "overlapped" mode, allowing the transport to > be closed cleanly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1890) C++: Make named pipes server work asynchronously
[ https://issues.apache.org/jira/browse/THRIFT-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608915#comment-13608915 ] Ben Craig commented on THRIFT-1890: --- Changes look good to me. Ship It! > C++: Make named pipes server work asynchronously > - > > Key: THRIFT-1890 > URL: https://issues.apache.org/jira/browse/THRIFT-1890 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Environment: Windows >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 1.0 > > Attachments: addNumbers.thrift, pipeStopTest.cpp, > THRIFT-1890_Cpp_Make_named_pipes_server_work_asynchronously-v3.patch, > TPipeServer.cpp > > > Currently the named pipe server cannot be stopped gracefully due to the way > ConnectNamedPipe() works for synchronous named pipes. The recommended > solution is to run the pipe in "overlapped" mode, allowing the transport to > be closed cleanly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
AW: [jira] [Updated] (THRIFT-1890) C++: Make named pipes server work asynchronously
Ben, if you agree with the latest patch, I commit it. Von: Jens Geyer (JIRA) Gesendet: 19.03.2013 22:51 An: dev@thrift.apache.org Betreff: [jira] [Updated] (THRIFT-1890) C++: Make named pipes server work asynchronously [ https://issues.apache.org/jira/browse/THRIFT-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-1890: --- Attachment: THRIFT-1890_Cpp_Make_named_pipes_server_work_asynchronously-v3.patch Patch v3 * merged Bens changes > C++: Make named pipes server work asynchronously > - > > Key: THRIFT-1890 > URL: https://issues.apache.org/jira/browse/THRIFT-1890 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Environment: Windows >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 1.0 > > Attachments: addNumbers.thrift, pipeStopTest.cpp, > THRIFT-1890_Cpp_Make_named_pipes_server_work_asynchronously-v3.patch, > TPipeServer.cpp > > > Currently the named pipe server cannot be stopped gracefully due to the way > ConnectNamedPipe() works for synchronous named pipes. The recommended > solution is to run the pipe in "overlapped" mode, allowing the transport to > be closed cleanly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
