[jira] [Commented] (THRIFT-3885) PHP: Error when readI64 in TCompactProtocol

2016-07-20 Thread James E. King, III (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387149#comment-15387149
 ] 

James E. King, III commented on THRIFT-3885:


Does the bug end up causing us to disable some "make cross" tests for PHP?  If 
so, if we fix the defect we should attempt to re-enable as many php tests as we 
can to see if they start working?

> PHP: Error when readI64 in TCompactProtocol
> ---
>
> Key: THRIFT-3885
> URL: https://issues.apache.org/jira/browse/THRIFT-3885
> Project: Thrift
>  Issue Type: Bug
>  Components: PHP - Library
>Affects Versions: 0.7, 0.8, 0.9, 0.9.1, 0.9.2, 0.9.3
> Environment: all
>Reporter: Chen Zhiming
>  Labels: patch
>
> In line 618 of readI64 of TCompactProtocol, the number of shift bit is error. 
> It must be
> $hi |= (($byte & 0x7f) >> (7 - ($shift - 25)));



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift issue #1022: THRIFT-3845

2016-07-20 Thread RobberPhex 
Github user RobberPhex commented on the issue:

https://github.com/apache/thrift/pull/1022
  
@jeking3 rebased


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-3845) TBinaryProtocolAccelerated cannot use thrift_protocol ext

2016-07-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387142#comment-15387142
 ] 

ASF GitHub Bot commented on THRIFT-3845:


Github user RobberPhex commented on the issue:

https://github.com/apache/thrift/pull/1022
  
@jeking3 rebased


> TBinaryProtocolAccelerated cannot use thrift_protocol ext
> -
>
> Key: THRIFT-3845
> URL: https://issues.apache.org/jira/browse/THRIFT-3845
> Project: Thrift
>  Issue Type: Improvement
>  Components: PHP - Compiler, PHP - Library
>Affects Versions: 0.9.3
> Environment: PHP7 with thrift 0.9.3, with thrift_protocol, at OS X 
> 10.11
>Reporter: Robert Lu
>Priority: Minor
>
> compiler generate phpcode:
>  instanceof TBinaryProtocolAccelerated
> to indicate use thrift_protocol, but when TBinaryProtocolAccelerated warped 
> in TMultiplexedProtocol, thrift_protocol doesn't used, because 
> TMultiplexedProtocol isn't TBinaryProtocolAccelerated's instence.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

THRIFT-3855 - Ready to Merge

2016-07-20 Thread Jim King 
Ready to merge and code reviewed:

THRIFT-3855: (go) fix the blocked bug when call Stop() twice or more #1028
  https://issues.apache.org/jira/browse/THRIFT-3855
  https://github.com/apache/thrift/pull/1028


James E. King, III
Architect
8 Technology Drive, 2nd Floor
Westborough, MA 01581-1756
Ph: 855-SVT-INFO
---
PRIVACY STATEMENT:
This message is a PRIVATE communication.  This message and all attachments are 
a private communication sent by SimpliVity and are considered to be 
confidential or protected by privilege. If you are not the intended recipient, 
you are hereby notified that any disclosure, copying, distribution or use of 
the information contained in or attached to this message is strictly 
prohibited.  Please notify the sender of the delivery error by replying to this 
message, and then delete it from your system.
---

[GitHub] thrift pull request #1028: MOD: fix the blocked bug when call Stop() twice o...

2016-07-20 Thread jeking3 
Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1028#discussion_r71641738
  
--- Diff: lib/go/thrift/simple_server.go ---
@@ -149,8 +151,10 @@ func (p *TSimpleServer) Serve() error {
 }
 
 func (p *TSimpleServer) Stop() error {
-   p.quit <- struct{}{}
-   p.serverTransport.Interrupt()
+   if atomic.CompareAndSwapInt64(, 0, 1) {
--- End diff --

Okay the example makes it clear.  I thought I found documentation that said 
it returns the previous value... I guess not!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (THRIFT-3885) PHP: Error when readI64 in TCompactProtocol

2016-07-20 Thread Chen Zhiming (JIRA) 
Chen Zhiming created THRIFT-3885:


 Summary: PHP: Error when readI64 in TCompactProtocol
 Key: THRIFT-3885
 URL: https://issues.apache.org/jira/browse/THRIFT-3885
 Project: Thrift
  Issue Type: Bug
  Components: PHP - Library
Affects Versions: 0.9.3, 0.9.2, 0.9.1, 0.9, 0.8, 0.7
 Environment: all
Reporter: Chen Zhiming


In line 618 of readI64 of TCompactProtocol, the number of shift bit is error. 
It must be
$hi |= (($byte & 0x7f) >> (7 - ($shift - 25)));



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift pull request #1028: MOD: fix the blocked bug when call Stop() twice o...

2016-07-20 Thread huaiyun 
Github user huaiyun commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1028#discussion_r71634947
  
--- Diff: lib/go/thrift/simple_server.go ---
@@ -149,8 +151,10 @@ func (p *TSimpleServer) Serve() error {
 }
 
 func (p *TSimpleServer) Stop() error {
-   p.quit <- struct{}{}
-   p.serverTransport.Interrupt()
+   if atomic.CompareAndSwapInt64(, 0, 1) {
--- End diff --

@jeking3 
The CompareAndSwapInt64 will return true of false to mark if the counter 
has been swapped.

the golang doc:
// The compare-and-swap operation, implemented by the CompareAndSwapT
// functions, is the atomic equivalent of:
//
//  if *addr == old {
//  *addr = new
//  return true
//  }
//  return false

At the first call, it returns true. Because the counter is 0 as 
initialized, and will be swapped to 1.
At the second call or more, it will return false. Because the counter is 
already 1, not 0.
So this make the Stop() only works at the first call. The more will be 
skipped.

a simple function is here:
https://play.golang.org/p/s-yHhQHG_O


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-2156) TServerSocket::listen() is throwing exceptions with misleading information

2016-07-20 Thread James E. King, III (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386559#comment-15386559
 ] 

James E. King, III commented on THRIFT-2156:


The code as-is is correct, even if a bit odd, but the style of code was already 
in that file so I followed it.
My intention was not to refactor odd code, but to apply the patch that was 
provided and correct it for master.
Therefore I would request that it be merged as-is.

> TServerSocket::listen() is throwing exceptions with misleading information
> --
>
> Key: THRIFT-2156
> URL: https://issues.apache.org/jira/browse/THRIFT-2156
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Affects Versions: 0.9
>Reporter: Frank Meerkoetter
>Assignee: James E. King, III
>Priority: Minor
> Attachments: errno_copy.patch
>
>
> Due to a problem with bind() an exception was thrown.
> The text was:
> "Could not bind: Transport endpoint is not connected"
> which doesn't make sense.
> It turned out that errno had been overwritten.
> The correct text would have been:
> "Could not bind: Address already in use"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (THRIFT-2156) TServerSocket::listen() is throwing exceptions with misleading information

2016-07-20 Thread Jens Geyer (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386530#comment-15386530
 ] 

Jens Geyer edited comment on THRIFT-2156 at 7/20/16 8:13 PM:
-

{code}
char port[sizeof("65535")];
std::memset(, 0, sizeof(hints));
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
snprintf(port, sizeof("65535"), "%d", port_);
{code}

why not

{code}
const size_t bufsize = sizeof("65535");
char port[bufsize];
snprintf(port, bufsize, "%d", port_);

std::memset(, 0, sizeof(hints));
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
{code}

seems less prone to error and less confusing to me.
I have not tested this, so it may not even compile.

{code}
snprintf(port, sizeof(port), "%d", port_);
{code}

may be even better. Same with errbuf below, where the literal 1024 is involved 
multiple times. If someone changes one of these and forgets about the other, we 
get a nice buffer overflow.





was (Author: jensg):
{code}
char port[sizeof("65535")];
std::memset(, 0, sizeof(hints));
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
snprintf(port, sizeof("65535"), "%d", port_);
{code}

why not

{code}
const size_t bufsize = sizeof("65535");
char port[bufsize];
snprintf(port, bufsize, "%d", port_);

std::memset(, 0, sizeof(hints));
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
{code}

seems less prone to error and less confusing to me.
I have not tested this, so it may not even compile.

{code}
snprintf(port, sizeof(port), "%d", port_);
{code}

may be even better. Same with errbuf below, where twice the literal 1024 is 
multiple times involved. If someone changes one of These and forgets about the 
other, we get a nice buffer overflow.




> TServerSocket::listen() is throwing exceptions with misleading information
> --
>
> Key: THRIFT-2156
> URL: https://issues.apache.org/jira/browse/THRIFT-2156
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Affects Versions: 0.9
>Reporter: Frank Meerkoetter
>Assignee: James E. King, III
>Priority: Minor
> Attachments: errno_copy.patch
>
>
> Due to a problem with bind() an exception was thrown.
> The text was:
> "Could not bind: Transport endpoint is not connected"
> which doesn't make sense.
> It turned out that errno had been overwritten.
> The correct text would have been:
> "Could not bind: Address already in use"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (THRIFT-2156) TServerSocket::listen() is throwing exceptions with misleading information

2016-07-20 Thread Jens Geyer (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386530#comment-15386530
 ] 

Jens Geyer edited comment on THRIFT-2156 at 7/20/16 8:13 PM:
-

{code}
char port[sizeof("65535")];
std::memset(, 0, sizeof(hints));
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
snprintf(port, sizeof("65535"), "%d", port_);
{code}

why not

{code}
const size_t bufsize = sizeof("65535");
char port[bufsize];
snprintf(port, bufsize, "%d", port_);

std::memset(, 0, sizeof(hints));
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
{code}

seems less prone to error and less confusing to me.
I have not tested this, so it may not even compile.

{code}
snprintf(port, sizeof(port), "%d", port_);
{code}

may be even better. Same with errbuf below, where twice the literal 1024 is 
multiple times involved. If someone changes one of These and forgets about the 
other, we get a nice buffer overflow.





was (Author: jensg):
{code}
char port[sizeof("65535")];
std::memset(, 0, sizeof(hints));
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
snprintf(port, sizeof("65535"), "%d", port_);
{code}

why not

{code}
const size_t bufsize = sizeof("65535");
char port[bufsize];
snprintf(port, bufsize, "%d", port_);

std::memset(, 0, sizeof(hints));
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
{code}

seems less prone to error and less confusing to me.
I have not tested this, so it may not even compile.

{code}
snprintf(port, sizeof(port), "%d", port_);
{code}

may be even better.

> TServerSocket::listen() is throwing exceptions with misleading information
> --
>
> Key: THRIFT-2156
> URL: https://issues.apache.org/jira/browse/THRIFT-2156
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Affects Versions: 0.9
>Reporter: Frank Meerkoetter
>Assignee: James E. King, III
>Priority: Minor
> Attachments: errno_copy.patch
>
>
> Due to a problem with bind() an exception was thrown.
> The text was:
> "Could not bind: Transport endpoint is not connected"
> which doesn't make sense.
> It turned out that errno had been overwritten.
> The correct text would have been:
> "Could not bind: Address already in use"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (THRIFT-2156) TServerSocket::listen() is throwing exceptions with misleading information

2016-07-20 Thread Jens Geyer (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386530#comment-15386530
 ] 

Jens Geyer edited comment on THRIFT-2156 at 7/20/16 8:11 PM:
-

{code}
char port[sizeof("65535")];
std::memset(, 0, sizeof(hints));
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
snprintf(port, sizeof("65535"), "%d", port_);
{code}

why not

{code}
const size_t bufsize = sizeof("65535");
char port[bufsize];
snprintf(port, bufsize, "%d", port_);

std::memset(, 0, sizeof(hints));
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
{code}

seems less prone to error and less confusing to me.
I have not tested this, so it may not even compile.

{code}
snprintf(port, sizeof(port), "%d", port_);
{code}

may be even better.


was (Author: jensg):
{code}
char port[sizeof("65535")];
std::memset(, 0, sizeof(hints));
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
snprintf(port, sizeof("65535"), "%d", port_);
{code}

why not

{code}
const size_t bufsize = sizeof("65535");
char port[bufsize];
snprintf(port, bufsize, "%d", port_);

std::memset(, 0, sizeof(hints));
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
{code}

seems less prone to error and less confusing to me.
I have not tested this, so it may not even compile.

> TServerSocket::listen() is throwing exceptions with misleading information
> --
>
> Key: THRIFT-2156
> URL: https://issues.apache.org/jira/browse/THRIFT-2156
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Affects Versions: 0.9
>Reporter: Frank Meerkoetter
>Assignee: James E. King, III
>Priority: Minor
> Attachments: errno_copy.patch
>
>
> Due to a problem with bind() an exception was thrown.
> The text was:
> "Could not bind: Transport endpoint is not connected"
> which doesn't make sense.
> It turned out that errno had been overwritten.
> The correct text would have been:
> "Could not bind: Address already in use"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (THRIFT-2156) TServerSocket::listen() is throwing exceptions with misleading information

2016-07-20 Thread Jens Geyer (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386530#comment-15386530
 ] 

Jens Geyer edited comment on THRIFT-2156 at 7/20/16 8:10 PM:
-

{code}
char port[sizeof("65535")];
std::memset(, 0, sizeof(hints));
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
snprintf(port, sizeof("65535"), "%d", port_);
{code}

why not

{code}
const size_t bufsize = sizeof("65535");
char port[bufsize];
snprintf(port, bufsize, "%d", port_);

std::memset(, 0, sizeof(hints));
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
{code}

seems less prone to error and less confusing to me.
I have not tested this, so it may not even compile.


was (Author: jensg):
{code}
char port[sizeof("65535")];
std::memset(, 0, sizeof(hints));
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
snprintf(port, sizeof("65535"), "%d", port_);
{code}

why not

{code}
const size_t bufsize = sizeof("65535");
char port[bufsize];
snprintf(port, bufsize, "%d", port_);

std::memset(, 0, sizeof(hints));
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
{code}

seems less prone to error to me.
I have not tested this, so it may not even compile.

> TServerSocket::listen() is throwing exceptions with misleading information
> --
>
> Key: THRIFT-2156
> URL: https://issues.apache.org/jira/browse/THRIFT-2156
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Affects Versions: 0.9
>Reporter: Frank Meerkoetter
>Assignee: James E. King, III
>Priority: Minor
> Attachments: errno_copy.patch
>
>
> Due to a problem with bind() an exception was thrown.
> The text was:
> "Could not bind: Transport endpoint is not connected"
> which doesn't make sense.
> It turned out that errno had been overwritten.
> The correct text would have been:
> "Could not bind: Address already in use"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (THRIFT-2156) TServerSocket::listen() is throwing exceptions with misleading information

2016-07-20 Thread Jens Geyer (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386530#comment-15386530
 ] 

Jens Geyer commented on THRIFT-2156:


{code}
char port[sizeof("65535")];
std::memset(, 0, sizeof(hints));
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
snprintf(port, sizeof("65535"), "%d", port_);
{code}

why not

{code}
const size_t bufsize = sizeof("65535");
char port[bufsize];
snprintf(port, bufsize, "%d", port_);

std::memset(, 0, sizeof(hints));
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
{code}

seems less prone to error to me.
I have not tested this, so it may not even compile.

> TServerSocket::listen() is throwing exceptions with misleading information
> --
>
> Key: THRIFT-2156
> URL: https://issues.apache.org/jira/browse/THRIFT-2156
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Affects Versions: 0.9
>Reporter: Frank Meerkoetter
>Assignee: James E. King, III
>Priority: Minor
> Attachments: errno_copy.patch
>
>
> Due to a problem with bind() an exception was thrown.
> The text was:
> "Could not bind: Transport endpoint is not connected"
> which doesn't make sense.
> It turned out that errno had been overwritten.
> The correct text would have been:
> "Could not bind: Address already in use"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

2016-07-20 Thread James E. King, III (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386261#comment-15386261
 ] 

James E. King, III commented on THRIFT-3855:


Hi, sorry, I used this thrift ticket number in an example - please ignore that.

> In the go simple server, if Stop() is called multiple times it hangs
> 
>
> Key: THRIFT-3855
> URL: https://issues.apache.org/jira/browse/THRIFT-3855
> Project: Thrift
>  Issue Type: Bug
>  Components: Go - Library
>Affects Versions: 0.9.3
>Reporter: James E. King, III
>Priority: Minor
>
> From the submitter huaiwan:
> {quote}
> huaiyun commented 18 hours ago
> When Stop() is called twice or more, and no new connection accepted from 
> AcceptLoop(), the Stop() will be blocked because the quit channel is full.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift issue #1052: fix bug of TCompactProtocol of php

2016-07-20 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1052
  
I'm also wondering if this was causing any "make cross" errors that have 
been ignored and whether we can re-enable some of those tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

2016-07-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386259#comment-15386259
 ] 

ASF GitHub Bot commented on THRIFT-3855:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1052
  
Please create an Apache Jira ticket in the THRIFT project to cover the 
defect, and put a link to the pull request in there.  In the future if you open 
a ticket first and put the name of the Jira item (like THRIFT-3855) into the 
pull request comments, it will get linked to the Jira ticket automatically.


> In the go simple server, if Stop() is called multiple times it hangs
> 
>
> Key: THRIFT-3855
> URL: https://issues.apache.org/jira/browse/THRIFT-3855
> Project: Thrift
>  Issue Type: Bug
>  Components: Go - Library
>Affects Versions: 0.9.3
>Reporter: James E. King, III
>Priority: Minor
>
> From the submitter huaiwan:
> {quote}
> huaiyun commented 18 hours ago
> When Stop() is called twice or more, and no new connection accepted from 
> AcceptLoop(), the Stop() will be blocked because the quit channel is full.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift issue #1052: fix bug of TCompactProtocol of php

2016-07-20 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1052
  
Please create an Apache Jira ticket in the THRIFT project to cover the 
defect, and put a link to the pull request in there.  In the future if you open 
a ticket first and put the name of the Jira item (like THRIFT-3855) into the 
pull request comments, it will get linked to the Jira ticket automatically.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Pull Requests that can be merged

2016-07-20 Thread Jim King 
The following pull requests passed CI builds and have been code reviewed:

THRIFT-2156: (C++) fix errno handling in server socket #1033
  https://issues.apache.org/jira/browse/THRIFT-2156
  https://github.com/apache/thrift/pull/1033

THRIFT-3038: (C++) fix up some volatiles in cpp #981
  https://issues.apache.org/jira/browse/THRIFT-3038
  https://github.com/apache/thrift/pull/981


The following pull requests passed CI builds and have not yet had a code review:

THRIFT-3873: (C++) fix compiler warnings on windows with VS2010 #1044
  https://issues.apache.org/jira/browse/THRIFT-3873
  https://github.com/apache/thrift/pull/1044


James E. King, III
Architect
8 Technology Drive, 2nd Floor
Westborough, MA 01581-1756
Ph: 855-SVT-INFO
---
PRIVACY STATEMENT:
This message is a PRIVATE communication.  This message and all attachments are 
a private communication sent by SimpliVity and are considered to be 
confidential or protected by privilege. If you are not the intended recipient, 
you are hereby notified that any disclosure, copying, distribution or use of 
the information contained in or attached to this message is strictly 
prohibited.  Please notify the sender of the delivery error by replying to this 
message, and then delete it from your system.
---

[GitHub] thrift pull request #1052: fix bug of TCompactProtocol of php

2016-07-20 Thread czm1989 
GitHub user czm1989 opened a pull request:

https://github.com/apache/thrift/pull/1052

fix bug of TCompactProtocol of php

fix bug when readI64 in TCompactProtocol of php.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/czm1989/thrift master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1052.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1052


commit 6ce420568aeba9afd8a272ec1618a26b7af26a87
Author: chenzhiming 
Date:   2016-07-20T14:20:35Z

fix bug of TCompactProtocol of php




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1016: change one conn per goroutine to one request per ...

2016-07-20 Thread zeayes 
Github user zeayes closed the pull request at:

https://github.com/apache/thrift/pull/1016


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-3088) TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket

2016-07-20 Thread James E. King, III (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385821#comment-15385821
 ] 

James E. King, III commented on THRIFT-3088:


The pull request for this issue is still open - please close it.

> TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket
> ---
>
> Key: THRIFT-3088
> URL: https://issues.apache.org/jira/browse/THRIFT-3088
> Project: Thrift
>  Issue Type: Bug
>  Components: Java - Library
>Affects Versions: 0.9
>Reporter: Winger Pun
> Fix For: 0.9.3
>
>
> Start TThreadPoolServer to server with TSaslServerTransport.Factory as 
> transportFactory. While using nc to test the specified port whether 
> reachable, it will leak CLOSE_WAIT socket.That's because nc will close socket 
> at once while successful connect TThreadPoolServer, but the server still try 
> using sasl protocol to build an inputTransport which of course failed at 
> once. However inputTransport is null which makes it can't close socket 
> properly which lead to CLOSE_WAIT socket.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (THRIFT-3090) cmake build is broken on MacOSX

2016-07-20 Thread James E. King, III (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385816#comment-15385816
 ] 

James E. King, III commented on THRIFT-3090:


The pull request is still open - could someone close it?

https://github.com/apache/thrift/pull/434

> cmake build is broken on MacOSX
> ---
>
> Key: THRIFT-3090
> URL: https://issues.apache.org/jira/browse/THRIFT-3090
> Project: Thrift
>  Issue Type: Bug
> Environment: Mac OS X 10.10.3
> C++ compiler: Apple system compiler (clang), Apple LLVM version 6.0 
> (clang-600.0.57) (based on LLVM 3.5svn)
> boost 1.57
> cmake 3.2.1
>Reporter: Marco Molteni
> Fix For: 0.9.3
>
>
> A current version of apache/thrift on github as of 2015-04-10 doesn't build 
> with cmake due to multiple errors:
> - some C++ targets fail to link with missing symbols, because they do not 
> link against the `thrift` library
> - the c_glib test targets fail to build because the reference to `shared_ptr` 
> is considered ambiguous by the compiler (it resolves to both boost and stdlib 
> shared_ptr)
> See pull request https://github.com/apache/thrift/pull/434



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (THRIFT-3830) Add detail exception message between server-side and client-side

2016-07-20 Thread James E. King, III (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385812#comment-15385812
 ] 

James E. King, III commented on THRIFT-3830:


[~jensg] or [~jfarrell] the pull request for this is still open - can someone 
decline it?

> Add  detail exception message between server-side and  client-side
> --
>
> Key: THRIFT-3830
> URL: https://issues.apache.org/jira/browse/THRIFT-3830
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Library
>Affects Versions: 0.9.3
>Reporter: Dongchao Ding
>Priority: Minor
>
> At present，when one TExcpetion occurs at server-side,  we just get one same 
> error tip like "Internal error processing ${invoke-method-name}", the detail 
> exception(exception message and exception stack) was gone.
> I think it's better to send detail  error info to client .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (THRIFT-3880) Erlang Compact protocol - boolean values inverted

2016-07-20 Thread James E. King, III (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-3880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III updated THRIFT-3880:
---
Assignee: Aki Sukegawa

> Erlang Compact protocol - boolean values inverted
> -
>
> Key: THRIFT-3880
> URL: https://issues.apache.org/jira/browse/THRIFT-3880
> Project: Thrift
>  Issue Type: Bug
>  Components: Erlang - Library
>Reporter: Vince Foley
>Assignee: Aki Sukegawa
> Fix For: 0.10.0
>
>
> Upon using thrift's erlang compact protocol, I noticed that all of the 
> boolean values are inverted.
> It turns out that the binary values used for thrift boolean values are set 
> wrong, and don't match those used by other languages.
> I've prepared a PR for this issue: https://github.com/apache/thrift/pull/1049



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift issue #1011: Fix bug for php close socket

2016-07-20 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1011
  
@caty please open an Apache Thrift Jira ticket for this issue and rebase 
the pull request against master so we get a clean CI build.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-3830) Add detail exception message between server-side and client-side

2016-07-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385801#comment-15385801
 ] 

ASF GitHub Bot commented on THRIFT-3830:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1012
  
This fix was declined per the thrift discussion due to security concerns.  
Please decline this pull request.


> Add  detail exception message between server-side and  client-side
> --
>
> Key: THRIFT-3830
> URL: https://issues.apache.org/jira/browse/THRIFT-3830
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Library
>Affects Versions: 0.9.3
>Reporter: Dongchao Ding
>Priority: Minor
>
> At present，when one TExcpetion occurs at server-side,  we just get one same 
> error tip like "Internal error processing ${invoke-method-name}", the detail 
> exception(exception message and exception stack) was gone.
> I think it's better to send detail  error info to client .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift issue #1012: THRIFT-3830

2016-07-20 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1012
  
This fix was declined per the thrift discussion due to security concerns.  
Please decline this pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1014: Thrift 3839

2016-07-20 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1014
  
Yes, continue to rebase against master and force push until it passes; if 
there are no changes to pick up add an extra blank line to the end of one of 
the files, commit, rebase/fixup and force push.  That will kick another build.  
We do have builds passing now (not 100% - there are still environmental issues, 
but we're getting better).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1015: Update connection.js

2016-07-20 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1015
  
This needs an Apache Jira ticket in the Thrift project, and needs to be 
rebased against master so that it gets a clean CI build.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-3845) TBinaryProtocolAccelerated cannot use thrift_protocol ext

2016-07-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385790#comment-15385790
 ] 

ASF GitHub Bot commented on THRIFT-3845:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1022
  
@RobberPhex could you rebase this against master so we can get a build that 
passes all tests?


> TBinaryProtocolAccelerated cannot use thrift_protocol ext
> -
>
> Key: THRIFT-3845
> URL: https://issues.apache.org/jira/browse/THRIFT-3845
> Project: Thrift
>  Issue Type: Improvement
>  Components: PHP - Compiler, PHP - Library
>Affects Versions: 0.9.3
> Environment: PHP7 with thrift 0.9.3, with thrift_protocol, at OS X 
> 10.11
>Reporter: Robert Lu
>Priority: Minor
>
> compiler generate phpcode:
>  instanceof TBinaryProtocolAccelerated
> to indicate use thrift_protocol, but when TBinaryProtocolAccelerated warped 
> in TMultiplexedProtocol, thrift_protocol doesn't used, because 
> TMultiplexedProtocol isn't TBinaryProtocolAccelerated's instence.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift issue #1016: change one conn per goroutine to one request per gorouti...

2016-07-20 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1016
  
This needs to be rebased against master to get a good CI build, and needs a 
Thrift project Jira ticket.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1022: THRIFT-3845

2016-07-20 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1022
  
@RobberPhex could you rebase this against master so we can get a build that 
passes all tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-3844) thrift_protocol cannot compile in 7.0.7

2016-07-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385785#comment-15385785
 ] 

ASF GitHub Bot commented on THRIFT-3844:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1021
  
@RobberPhex could you rebase this against master and re-submit to get a 
build that passes CI tests?


> thrift_protocol cannot compile in 7.0.7
> ---
>
> Key: THRIFT-3844
> URL: https://issues.apache.org/jira/browse/THRIFT-3844
> Project: Thrift
>  Issue Type: Bug
>  Components: PHP - Library
>Affects Versions: 1.0
> Environment: PHP 7.0.7, x86-64, OS-X 10.11
>Reporter: Robert Lu
>
> When compile thrift_protocol extension with php7.0.7 in OS X 10.11,
> Report error:
> php_thrift_protocol7.cpp:290:27: error: no member named 'min' in namespace 
> 'std'; did you mean 'fmin'?
> and
> zend_hash.h:168:30: note: candidate function not viable: no known conversion 
> from 'unsigned long *' to 'zend_ulong *' (aka 'unsigned long long *') for 3rd 
> argument
> ZEND_API int   ZEND_FASTCALL zend_hash_get_current_key_ex(const HashTable 
> *ht, zend_string **str_index, zend_ulong *num_index, HashPosition *pos);
> *And I find someone in github solved this problom, but no one notice it, so I 
> create this issue*



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift issue #1021: Fix THRIFT-3844

2016-07-20 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1021
  
@RobberPhex could you rebase this against master and re-submit to get a 
build that passes CI tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1028: MOD: fix the blocked bug when call Stop() twice o...

2016-07-20 Thread jeking3 
Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1028#discussion_r71516249
  
--- Diff: lib/go/thrift/simple_server.go ---
@@ -149,8 +151,10 @@ func (p *TSimpleServer) Serve() error {
 }
 
 func (p *TSimpleServer) Stop() error {
-   p.quit <- struct{}{}
-   p.serverTransport.Interrupt()
+   if atomic.CompareAndSwapInt64(, 0, 1) {
--- End diff --

@huaiyun need you to look at this again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-3876) haxe js/nodejs client

2016-07-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385778#comment-15385778
 ] 

ASF GitHub Bot commented on THRIFT-3876:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1045
  
Was this set of changes tested with "make cross" as part of the build?


> haxe js/nodejs client
> -
>
> Key: THRIFT-3876
> URL: https://issues.apache.org/jira/browse/THRIFT-3876
> Project: Thrift
>  Issue Type: Improvement
>  Components: Haxe - Library
>Reporter: Oleksii Prudkyi
>Assignee: Oleksii Prudkyi
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] thrift issue #1045: THRIFT-3876 haxe js/nodejs client

2016-07-20 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1045
  
Was this set of changes tested with "make cross" as part of the build?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (THRIFT-3232) Cannot deserialize json messages created with fieldNamesAsString

2016-07-20 Thread Jens Geyer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer updated THRIFT-3232:
---
Summary: Cannot deserialize json messages created with fieldNamesAsString   
(was: Cannot deserialize json messages created with )

> Cannot deserialize json messages created with fieldNamesAsString 
> -
>
> Key: THRIFT-3232
> URL: https://issues.apache.org/jira/browse/THRIFT-3232
> Project: Thrift
>  Issue Type: Bug
>  Components: Java - Library
>Affects Versions: 0.9.2
>Reporter: Jelmer Kuperus
>Assignee: Aki Sukegawa
> Fix For: 0.10.0
>
>
> THRIFT-2535 introduced the fieldNamesAsString argument on 
> TJSONProtocol.Factory
> When you use it to serialize messages to json , the resulting output cannot 
> be deserialized back to an object when using the same protocolfactory
> Example :
> {noformat}
> TJSONProtocol.Factory factory = new TJSONProtocol.Factory(true);
> TSerializer tSerializer = new TSerializer(factory);
> foo foo1 = new Foo();
> String value = tSerializer.toString(foo1, "utf-8");
> TDeserializer tDeserializer = new TDeserializer(factory);
> foo foo2 = new foo();
> tDeserializer.fromString(foo2, value);
> {noformat}
> Will give you Exception in thread "main" 
> org.apache.thrift.protocol.TProtocolException: Unexpected character:



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (THRIFT-3232) Cannot deserialize json messages created with fieldNamesAsString

2016-07-20 Thread Jens Geyer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer closed THRIFT-3232.
--
Resolution: Fixed

> Cannot deserialize json messages created with fieldNamesAsString 
> -
>
> Key: THRIFT-3232
> URL: https://issues.apache.org/jira/browse/THRIFT-3232
> Project: Thrift
>  Issue Type: Bug
>  Components: Java - Library
>Affects Versions: 0.9.2
>Reporter: Jelmer Kuperus
>Assignee: Aki Sukegawa
> Fix For: 0.10.0
>
>
> THRIFT-2535 introduced the fieldNamesAsString argument on 
> TJSONProtocol.Factory
> When you use it to serialize messages to json , the resulting output cannot 
> be deserialized back to an object when using the same protocolfactory
> Example :
> {noformat}
> TJSONProtocol.Factory factory = new TJSONProtocol.Factory(true);
> TSerializer tSerializer = new TSerializer(factory);
> foo foo1 = new Foo();
> String value = tSerializer.toString(foo1, "utf-8");
> TDeserializer tDeserializer = new TDeserializer(factory);
> foo foo2 = new foo();
> tDeserializer.fromString(foo2, value);
> {noformat}
> Will give you Exception in thread "main" 
> org.apache.thrift.protocol.TProtocolException: Unexpected character:



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Reopened] (THRIFT-3232) Cannot deserialize json messages created with

2016-07-20 Thread Jens Geyer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer reopened THRIFT-3232:


> Cannot deserialize json messages created with 
> --
>
> Key: THRIFT-3232
> URL: https://issues.apache.org/jira/browse/THRIFT-3232
> Project: Thrift
>  Issue Type: Bug
>  Components: Java - Library
>Affects Versions: 0.9.2
>Reporter: Jelmer Kuperus
>Assignee: Aki Sukegawa
> Fix For: 0.10.0
>
>
> THRIFT-2535 introduced the fieldNamesAsString argument on 
> TJSONProtocol.Factory
> When you use it to serialize messages to json , the resulting output cannot 
> be deserialized back to an object when using the same protocolfactory
> Example :
> {noformat}
> TJSONProtocol.Factory factory = new TJSONProtocol.Factory(true);
> TSerializer tSerializer = new TSerializer(factory);
> foo foo1 = new Foo();
> String value = tSerializer.toString(foo1, "utf-8");
> TDeserializer tDeserializer = new TDeserializer(factory);
> foo foo2 = new foo();
> tDeserializer.fromString(foo2, value);
> {noformat}
> Will give you Exception in thread "main" 
> org.apache.thrift.protocol.TProtocolException: Unexpected character:



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)