[jira] [Comment Edited] (THRIFT-3928) CPP generator doesn`t generate implementations of constructors, operators and setters for function helpers
[
https://issues.apache.org/jira/browse/THRIFT-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15492544#comment-15492544
]
Denis edited comment on THRIFT-3928 at 9/15/16 6:46 AM:
-
Yes, it is insufficient. We got error "undefined reference" when used these
methods.
Constructors are compiler-supplied when it doesn`t declared in header or when
exists 'default' statement.
For example:
{code}
class Foo
{
public:
Foo();
};
int main()
{
Foo f;
return 0;
}
{code}
If we try to compile this code, we will get error “undefined reference to
`Foo::Foo()'”.
was (Author: denis.korovyakovs...@gmail.com):
Yes, it is insufficient. We got error "undefined reference" when used these
methods.
Constructors are compiler-supplied when it doesn`t declared in header or when
exists 'default' statement.
For example:
{code}
class Foo
{
public:
Foo();
};
int main()
{
Foo f;
return 0;
}
{code}
If we try compile this code, we will get error “undefined reference to
`Foo::Foo()'”.
> CPP generator doesn`t generate implementations of constructors, operators and
> setters for function helpers
> --
>
> Key: THRIFT-3928
> URL: https://issues.apache.org/jira/browse/THRIFT-3928
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler
>Affects Versions: 0.9.3
>Reporter: Denis
> Labels: easyfix
> Attachments: thrift_cpp_generator.patch
>
>
> cpp generator doesn`t generate implementations of constructors, operators
> for function and service helpers in *Service.cpp
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-3928) CPP generator doesn`t generate implementations of constructors, operators and setters for function helpers
[
https://issues.apache.org/jira/browse/THRIFT-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15492544#comment-15492544
]
Denis edited comment on THRIFT-3928 at 9/15/16 6:45 AM:
-
Yes, it is insufficient. We got error "undefined reference" when used these
methods.
Constructors are compiler-supplied when it doesn`t declared in header or when
exists 'default' statement.
For example:
{code}
class Foo
{
public:
Foo();
};
int main()
{
Foo f;
return 0;
}
{code}
If we try compile this code, we will get error “undefined reference to
`Foo::Foo()'”.
was (Author: denis.korovyakovs...@gmail.com):
Yes, it is insufficient. We got error "undefined reference" when used these
methods.
Constructors are compiler-supplied when it doesn`t declared in header or when
exists 'default' statement.
For example:
class Foo
{
public:
Foo();
};
int main()
{
Foo f;
return 0;
}
If we try compile this code, we will get error “undefined reference to
`Foo::Foo()'”.
> CPP generator doesn`t generate implementations of constructors, operators and
> setters for function helpers
> --
>
> Key: THRIFT-3928
> URL: https://issues.apache.org/jira/browse/THRIFT-3928
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler
>Affects Versions: 0.9.3
>Reporter: Denis
> Labels: easyfix
> Attachments: thrift_cpp_generator.patch
>
>
> cpp generator doesn`t generate implementations of constructors, operators
> for function and service helpers in *Service.cpp
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3928) CPP generator doesn`t generate implementations of constructors, operators and setters for function helpers
[
https://issues.apache.org/jira/browse/THRIFT-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15492544#comment-15492544
]
Denis commented on THRIFT-3928:
Yes, it is insufficient. We got error "undefined reference" when used these
methods.
Constructors are compiler-supplied when it doesn`t declared in header or when
exists 'default' statement.
For example:
class Foo
{
public:
Foo();
};
int main()
{
Foo f;
return 0;
}
If we try compile this code, we will get error “undefined reference to
`Foo::Foo()'”.
> CPP generator doesn`t generate implementations of constructors, operators and
> setters for function helpers
> --
>
> Key: THRIFT-3928
> URL: https://issues.apache.org/jira/browse/THRIFT-3928
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler
>Affects Versions: 0.9.3
>Reporter: Denis
> Labels: easyfix
> Attachments: thrift_cpp_generator.patch
>
>
> cpp generator doesn`t generate implementations of constructors, operators
> for function and service helpers in *Service.cpp
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-3928) CPP generator doesn`t generate implementations of constructors, operators and setters for function helpers
[
https://issues.apache.org/jira/browse/THRIFT-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15492544#comment-15492544
]
Denis edited comment on THRIFT-3928 at 9/15/16 6:42 AM:
-
Yes, it is insufficient. We got error "undefined reference" when used these
methods.
Constructors are compiler-supplied when it doesn`t declared in header or when
exists 'default' statement.
For example:
class Foo
{
public:
Foo();
};
int main()
{
Foo f;
return 0;
}
If we try compile this code, we will get error “undefined reference to
`Foo::Foo()'”.
was (Author: denis.korovyakovs...@gmail.com):
Yes, it is insufficient. We got error "undefined reference" when used these
methods.
Constructors are compiler-supplied when it doesn`t declared in header or when
exists 'default' statement.
For example:
class Foo
{
public:
Foo();
};
int main()
{
Foo f;
return 0;
}
If we try compile this code, we will get error “undefined reference to
`Foo::Foo()'”.
> CPP generator doesn`t generate implementations of constructors, operators and
> setters for function helpers
> --
>
> Key: THRIFT-3928
> URL: https://issues.apache.org/jira/browse/THRIFT-3928
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler
>Affects Versions: 0.9.3
>Reporter: Denis
> Labels: easyfix
> Attachments: thrift_cpp_generator.patch
>
>
> cpp generator doesn`t generate implementations of constructors, operators
> for function and service helpers in *Service.cpp
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3929) PHP "nsglobal" Option Results in Syntax Error in Generated Code (Trailing Backslash)
[
https://issues.apache.org/jira/browse/THRIFT-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15492143#comment-15492143
]
ASF GitHub Bot commented on THRIFT-3929:
GitHub user RobberPhex opened a pull request:
https://github.com/apache/thrift/pull/1089
THRIFT-3929 php namespace remove tail "\\"
when namespace is empty, and global namespace is not empty, don't add tail
"\\"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RobberPhex/thrift THRIFT-3929
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1089.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1089
commit d2a8c366f0d99ce20c434d7210ca8cdd289ff910
Author: Robert Lu
Date: 2016-09-15T02:48:16Z
THRIFT-3929 php namespace remove tail "\\"
> PHP "nsglobal" Option Results in Syntax Error in Generated Code (Trailing
> Backslash)
>
>
> Key: THRIFT-3929
> URL: https://issues.apache.org/jira/browse/THRIFT-3929
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Compiler
>Affects Versions: 1.0
> Environment: Distributor ID: Ubuntu
> Description:Ubuntu 14.04.4 LTS
> Release:14.04
> Codename: trusty
>Reporter: Ben Meynell
> Labels: easyfix
> Fix For: 1.0
>
>
> thrift --gen php:server,psr4,oop,validate,json,nsglobal="My\Special\Place"
> -out ./src my.thrift
> Results in PHP files with namespaces defined as:
> namespace My\Special\Place\;
> Note the trailing backslash ("\"). This results in unparseable PHP:
> $ php -l src/My/Special/Place/Data.php
> Errors parsing src/My/Special/Place/Data.php
> The fix is to simply omit the trailing backslash from the generated code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] thrift pull request #1089: THRIFT-3929 php namespace remove tail "\\"
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1089 THRIFT-3929 php namespace remove tail "\\" when namespace is empty, and global namespace is not empty, don't add tail "\\" You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift THRIFT-3929 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1089.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1089 commit d2a8c366f0d99ce20c434d7210ca8cdd289ff910 Author: Robert Lu Date: 2016-09-15T02:48:16Z THRIFT-3929 php namespace remove tail "\\" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1088: Microsoft .Net Core library port and generator fo...
GitHub user vgotra opened a pull request: https://github.com/apache/thrift/pull/1088 Microsoft .Net Core library port and generator for this library Here is port of csharp library to .Net core and also generator for it (t_netcore_generator.cc) All information in README.md files in subfolders with source code and samples. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vgotra/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1088.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1088 commit 0cf8fc3c5793a3553172745579082e9cd36e Author: Volodymyr Gotra Date: 2016-09-15T00:18:48Z Initial commit of changes commit e184a9a2f3c3b93e6221f4ee097598e5b5875460 Author: Volodymyr Gotra Date: 2016-09-15T00:29:43Z Added changes to thriftl.ll for netcore lib --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (THRIFT-3929) PHP "nsglobal" Option Results in Syntax Error in Generated Code (Trailing Backslash)
Ben Meynell created THRIFT-3929:
---
Summary: PHP "nsglobal" Option Results in Syntax Error in
Generated Code (Trailing Backslash)
Key: THRIFT-3929
URL: https://issues.apache.org/jira/browse/THRIFT-3929
Project: Thrift
Issue Type: Bug
Components: PHP - Compiler
Affects Versions: 1.0
Environment: Distributor ID: Ubuntu
Description:Ubuntu 14.04.4 LTS
Release:14.04
Codename: trusty
Reporter: Ben Meynell
Fix For: 1.0
thrift --gen php:server,psr4,oop,validate,json,nsglobal="My\Special\Place" -out
./src my.thrift
Results in PHP files with namespaces defined as:
namespace My\Special\Place\;
Note the trailing backslash ("\"). This results in unparseable PHP:
$ php -l src/My/Special/Place/Data.php
Errors parsing src/My/Special/Place/Data.php
The fix is to simply omit the trailing backslash from the generated code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (THRIFT-3927) Emit an error instead of throw an error in the async callback
[ https://issues.apache.org/jira/browse/THRIFT-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3927: --- Component/s: Node.js - Library > Emit an error instead of throw an error in the async callback > - > > Key: THRIFT-3927 > URL: https://issues.apache.org/jira/browse/THRIFT-3927 > Project: Thrift > Issue Type: Improvement > Components: Node.js - Library >Reporter: 李飛 > > because the data event of a connection is async handled, throw an exception > can not tell the code the error. emit the error should be the correct way to > handle the errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3928) CPP generator doesn`t generate implementations of constructors, operators and setters for function helpers
[ https://issues.apache.org/jira/browse/THRIFT-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3928: --- Priority: Major (was: Critical) > CPP generator doesn`t generate implementations of constructors, operators and > setters for function helpers > -- > > Key: THRIFT-3928 > URL: https://issues.apache.org/jira/browse/THRIFT-3928 > Project: Thrift > Issue Type: Bug > Components: C++ - Compiler >Affects Versions: 0.9.3 >Reporter: Denis > Labels: easyfix > Attachments: thrift_cpp_generator.patch > > > cpp generator doesn`t generate implementations of constructors, operators > for function and service helpers in *Service.cpp -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3928) CPP generator doesn`t generate implementations of constructors, operators and setters for function helpers
[ https://issues.apache.org/jira/browse/THRIFT-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15490437#comment-15490437 ] James E. King, III commented on THRIFT-3928: Are the compiler-supplied methods (when one is not specified in the implementation) insufficient? > CPP generator doesn`t generate implementations of constructors, operators and > setters for function helpers > -- > > Key: THRIFT-3928 > URL: https://issues.apache.org/jira/browse/THRIFT-3928 > Project: Thrift > Issue Type: Bug > Components: C++ - Compiler >Affects Versions: 0.9.3 >Reporter: Denis >Priority: Critical > Labels: easyfix > Attachments: thrift_cpp_generator.patch > > > cpp generator doesn`t generate implementations of constructors, operators > for function and service helpers in *Service.cpp -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3928) CPP generator doesn`t generate implementations of constructors, operators and setters for function helpers
[ https://issues.apache.org/jira/browse/THRIFT-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denis updated THRIFT-3928: --- Description: cpp generator doesn`t generate implementations of constructors, operators for function and service helpers in *Service.cpp (was: cpp generator doesn`t generate implementations of constructors, operators in *Service.cpp ) Summary: CPP generator doesn`t generate implementations of constructors, operators and setters for function helpers (was: CPP generator doesn`t generate implementations of constructors, operators and setters for classes with wrap functions ) > CPP generator doesn`t generate implementations of constructors, operators and > setters for function helpers > -- > > Key: THRIFT-3928 > URL: https://issues.apache.org/jira/browse/THRIFT-3928 > Project: Thrift > Issue Type: Bug > Components: C++ - Compiler >Affects Versions: 0.9.3 >Reporter: Denis >Priority: Critical > Labels: easyfix > Attachments: thrift_cpp_generator.patch > > > cpp generator doesn`t generate implementations of constructors, operators > for function and service helpers in *Service.cpp -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3928) CPP generator doesn`t generate implementations of constructors, operators and setters for classes with wrap functions
[ https://issues.apache.org/jira/browse/THRIFT-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15490396#comment-15490396 ] Denis commented on THRIFT-3928: In method generate_function_helpers doesn`t exists call for generate_copy_constructor, generate_move_constructor, generate_assignment_operator, generate_move_assignment_operator. And need call generate_struct_declaration with parameter 'setters' = true, for generate implamentation setters. > CPP generator doesn`t generate implementations of constructors, operators and > setters for classes with wrap functions > > > Key: THRIFT-3928 > URL: https://issues.apache.org/jira/browse/THRIFT-3928 > Project: Thrift > Issue Type: Bug > Components: C++ - Compiler >Affects Versions: 0.9.3 >Reporter: Denis >Priority: Critical > Labels: easyfix > Attachments: thrift_cpp_generator.patch > > > cpp generator doesn`t generate implementations of constructors, operators > in *Service.cpp -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3928) CPP generator doesn`t generate implementations of constructors, operators and setters for classes with wrap functions
[ https://issues.apache.org/jira/browse/THRIFT-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denis updated THRIFT-3928: --- Attachment: thrift_cpp_generator.patch Patch for this bug > CPP generator doesn`t generate implementations of constructors, operators and > setters for classes with wrap functions > > > Key: THRIFT-3928 > URL: https://issues.apache.org/jira/browse/THRIFT-3928 > Project: Thrift > Issue Type: Bug > Components: C++ - Compiler >Affects Versions: 0.9.3 >Reporter: Denis >Priority: Critical > Labels: easyfix > Attachments: thrift_cpp_generator.patch > > > cpp generator doesn`t generate implementations of constructors, operators > in *Service.cpp -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-3928) CPP generator doesn`t generate implementations of constructors, operators and setters for classes with wrap functions
Denis created THRIFT-3928: -- Summary: CPP generator doesn`t generate implementations of constructors, operators and setters for classes with wrap functions Key: THRIFT-3928 URL: https://issues.apache.org/jira/browse/THRIFT-3928 Project: Thrift Issue Type: Bug Components: C++ - Compiler Affects Versions: 0.9.3 Reporter: Denis Priority: Critical cpp generator doesn`t generate implementations of constructors, operators in *Service.cpp -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3927) Emit an error instead of throw an error in the async callback
[ https://issues.apache.org/jira/browse/THRIFT-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15490078#comment-15490078 ] ASF GitHub Bot commented on THRIFT-3927: GitHub user lifei opened a pull request: https://github.com/apache/thrift/pull/1087 THRIFT-3927 Emitting an error instead of throwing in the async callback Because the data event of a connection is async handled, throw an exception can not tell the code the error. emit the error should be the correct way to handle the errors. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lifei/thrift fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1087.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1087 commit f0b1d5eaf3a6ae7d006edda26cf0c13df524d044 Author: lifei Date: 2016-09-14T10:18:32Z THRIFT-3927 Emit an error instead of throw an error in the async callback > Emit an error instead of throw an error in the async callback > - > > Key: THRIFT-3927 > URL: https://issues.apache.org/jira/browse/THRIFT-3927 > Project: Thrift > Issue Type: Improvement >Reporter: 李飛 > > because the data event of a connection is async handled, throw an exception > can not tell the code the error. emit the error should be the correct way to > handle the errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request #1087: THRIFT-3927 Emitting an error instead of throwing...
GitHub user lifei opened a pull request: https://github.com/apache/thrift/pull/1087 THRIFT-3927 Emitting an error instead of throwing in the async callback Because the data event of a connection is async handled, throw an exception can not tell the code the error. emit the error should be the correct way to handle the errors. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lifei/thrift fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1087.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1087 commit f0b1d5eaf3a6ae7d006edda26cf0c13df524d044 Author: lifei Date: 2016-09-14T10:18:32Z THRIFT-3927 Emit an error instead of throw an error in the async callback --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (THRIFT-3927) Emit an error instead of throw an error in the async callback
[ https://issues.apache.org/jira/browse/THRIFT-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 李飛 updated THRIFT-3927: --- Summary: Emit an error instead of throw an error in the async callback (was: Emit an error instead of throw an error) > Emit an error instead of throw an error in the async callback > - > > Key: THRIFT-3927 > URL: https://issues.apache.org/jira/browse/THRIFT-3927 > Project: Thrift > Issue Type: Improvement >Reporter: 李飛 > > because the data event of a connection is async handled, throw an exception > can not tell the code the error. emit the error should be the correct way to > handle the errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-3927) Emit an error instead of throw an error
李飛 created THRIFT-3927: -- Summary: Emit an error instead of throw an error Key: THRIFT-3927 URL: https://issues.apache.org/jira/browse/THRIFT-3927 Project: Thrift Issue Type: Improvement Reporter: 李飛 because the data event of a connection is async handled, throw an exception can not tell the code the error. emit the error should be the correct way to handle the errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3926) There should be an error emitted when http status code is not 200
[ https://issues.apache.org/jira/browse/THRIFT-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15490024#comment-15490024 ] ASF GitHub Bot commented on THRIFT-3926: GitHub user lifei opened a pull request: https://github.com/apache/thrift/pull/1086 THRIFT-3926 Emit an error for bad http status code Sometimes the thrift servers is not ready to serve requests from the client. The status code of response from the services is 40x or 50x. But the client is never telled in this version of http_connections. There is no error at all even when the response protocol is bad. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lifei/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1086.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1086 commit a92f27c3174b405dabd92562602cf075742569bc Author: lifei Date: 2016-09-14T09:38:47Z THRIFT-3926 Emit an error for bad http status code > There should be an error emitted when http status code is not 200 > -- > > Key: THRIFT-3926 > URL: https://issues.apache.org/jira/browse/THRIFT-3926 > Project: Thrift > Issue Type: Improvement >Reporter: 李飛 >Assignee: 李飛 > > Sometimes the thrift servers is not ready to serve requests from the client. > The status code of response from the services is 40x or 50x. But the client > is never telled in this version of http_connections. There is no error at all > even when the response protocol is bad. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request #1086: THRIFT-3926 Emit an error for bad http status cod...
GitHub user lifei opened a pull request: https://github.com/apache/thrift/pull/1086 THRIFT-3926 Emit an error for bad http status code Sometimes the thrift servers is not ready to serve requests from the client. The status code of response from the services is 40x or 50x. But the client is never telled in this version of http_connections. There is no error at all even when the response protocol is bad. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lifei/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1086.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1086 commit a92f27c3174b405dabd92562602cf075742569bc Author: lifei Date: 2016-09-14T09:38:47Z THRIFT-3926 Emit an error for bad http status code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (THRIFT-3926) there should be an error emitted when http status code is not 200
李飛 created THRIFT-3926: -- Summary: there should be an error emitted when http status code is not 200 Key: THRIFT-3926 URL: https://issues.apache.org/jira/browse/THRIFT-3926 Project: Thrift Issue Type: Improvement Reporter: 李飛 Assignee: 李飛 Sometimes the thrift servers is not ready to serve requests from the client. The status code of response from the services is 40x or 50x. But the client is never telled in this version of http_connections. There is no error at all even when the response protocol is bad. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-3926) There should be an error emitted when http status code is not 200
[ https://issues.apache.org/jira/browse/THRIFT-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 李飛 updated THRIFT-3926: --- Summary: There should be an error emitted when http status code is not 200 (was: there should be an error emitted when http status code is not 200 ) > There should be an error emitted when http status code is not 200 > -- > > Key: THRIFT-3926 > URL: https://issues.apache.org/jira/browse/THRIFT-3926 > Project: Thrift > Issue Type: Improvement >Reporter: 李飛 >Assignee: 李飛 > > Sometimes the thrift servers is not ready to serve requests from the client. > The status code of response from the services is 40x or 50x. But the client > is never telled in this version of http_connections. There is no error at all > even when the response protocol is bad. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
