[jira] [Updated] (THRIFT-3923) Maybe remove Aereo from the "Powered by" list

2016-09-21 Thread Jens Geyer (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer updated THRIFT-3923:
---
Attachment: THRIFT-3923.patch

> Maybe remove Aereo from the "Powered by" list
> -
>
> Key: THRIFT-3923
> URL: https://issues.apache.org/jira/browse/THRIFT-3923
> Project: Thrift
>  Issue Type: Wish
>  Components: Website
>Reporter: Nevo Hed
>Priority: Minor
> Fix For: 0.10.0
>
> Attachments: THRIFT-3923.patch
>
>
> Back in 2012 I asked for addition of Aereo to the "Powered by" list 
> (THRIFT-1685).  In the summer of 2014 Aereo was handed a fatal defeat by the 
> Supreme Court, which led to the closing of the company before years end.  
> Certain assets such as the name, domain, customer list were sold to Tivo - 
> this purchase did not include any software - since Tivo, to the best f my 
> knowledge does not use Thrift I wonder if this listing should be removed.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (THRIFT-3923) Maybe remove Aereo from the "Powered by" list

2016-09-21 Thread Jens Geyer (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer resolved THRIFT-3923.

   Resolution: Fixed
 Assignee: Jens Geyer
Fix Version/s: 0.10.0

Committed.

> Maybe remove Aereo from the "Powered by" list
> -
>
> Key: THRIFT-3923
> URL: https://issues.apache.org/jira/browse/THRIFT-3923
> Project: Thrift
>  Issue Type: Wish
>  Components: Website
>Reporter: Nevo Hed
>Assignee: Jens Geyer
>Priority: Minor
> Fix For: 0.10.0
>
> Attachments: THRIFT-3923.patch
>
>
> Back in 2012 I asked for addition of Aereo to the "Powered by" list 
> (THRIFT-1685).  In the summer of 2014 Aereo was handed a fatal defeat by the 
> Supreme Court, which led to the closing of the company before years end.  
> Certain assets such as the name, domain, customer list were sold to Tivo - 
> this purchase did not include any software - since Tivo, to the best f my 
> knowledge does not use Thrift I wonder if this listing should be removed.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] thrift issue #1088: Microsoft .Net Core library port and generator for this ...

2016-09-21 Thread Jens-G
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1088
  
### General

All code files etc. need an ASF header on top. Please have a look at the 
existing code if you are unsure, what, where and how to apply.

### using Serilog;  

We don't like external dependencies that much. Thrift supports about 20+ 
languages and dialects, each additional dependency has the potential to quickly 
become a PITA. So we avoid them wherever possible.

### lib/netcore/src/Samples

If that is the Thrift Test Suite client/server pair, that part should be 
move to /test/netcore. All other tests should remain under /lib/netcore. In 
addition to that, we have a [standardized set of arguments and exit 
codes](https://thrift.apache.org/test/). I haven't checked how close these 
program(s) already adhere to them, but from a first quick glance it may not 
100%. 

### Compatibility I

Have you tested the code against at least one other language, preferably 
C++, Java or C#?

### Compatibility II

Can at least the Thrift Test Suite .NET Core Application  code be built on 
Linux and/or Mac? 

### AssemblyInfo.cs

Should be set up according to the existing C# code.

### /lib/netcore/src/Samples/.../Calculator.cs

The Tutorial code belongs under /tutorial/netcore. The code is later to be 
[included on the web site](https://thrift.apache.org/tutorial/) automagically 
from that folder. 

Next, generated code should generally not be put into the source tree. Part 
of the tutorial is to create these files from the IDL file.

### Summary

Great work, looks promising! But as I said, only a first look, however 
still plenty of room for improvement ;-) Have you seen [that 
document](https://thrift.apache.org/docs/HowToNewLanguage)?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (THRIFT-3775) 0.10.0 release candidate

2016-09-21 Thread James E. King, III (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15511222#comment-15511222
 ] 

James E. King, III commented on THRIFT-3775:


How are we looking on putting out a release candidate?

> 0.10.0 release candidate
> 
>
> Key: THRIFT-3775
> URL: https://issues.apache.org/jira/browse/THRIFT-3775
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Reporter: Jake Farrell
>Assignee: Jake Farrell
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] thrift issue #1088: Microsoft .Net Core library port and generator for this ...

2016-09-21 Thread Jens-G
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1088
  
Could you please file a JIRA ticket according to our [contrib 
guidelines](http://thrift.apache.org/docs/HowToContribute)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Resolved] (THRIFT-3867) Specify BinaryProtocol and CompactProtocol

2016-09-21 Thread Jens Geyer (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer resolved THRIFT-3867.

   Resolution: Fixed
 Assignee: Erik van Oosten
Fix Version/s: 0.10.0

{quote}
Github user erikvanoosten commented on the issue:
https://github.com/apache/thrift/pull/1036
Feel free to take it. I won't support it anymore though.
{quote}

Thank you very much, committed.

> Specify BinaryProtocol and CompactProtocol
> --
>
> Key: THRIFT-3867
> URL: https://issues.apache.org/jira/browse/THRIFT-3867
> Project: Thrift
>  Issue Type: Documentation
>  Components: Documentation
>Reporter: Erik van Oosten
>Assignee: Erik van Oosten
> Fix For: 0.10.0
>
>
> It would be nice when the protocol(s) would be specified somewhere. This 
> should improve communication between developers, but also opens the way for 
> alternative implementations so that Thrift can thrive even better.
> I have a fairly complete description of the BinaryProtocol and 
> CompactProtocol which I will submit as a patch for further review and 
> discussion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (THRIFT-1667) Client side SASL transport for C++

2016-09-21 Thread Jens Geyer (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510428#comment-15510428
 ] 

Jens Geyer commented on THRIFT-1667:


Yes, sending a PR via Github is perfectly fine. Name the pull request after the 
ticket, i.e. THRIFT-1667 and the PR will automatically be linked to the ticket. 
[More details available over here|http://thrift.apache.org/docs/HowToContribute]

> Will anyone review this patch?

Sure. Sometimes we are a bit short on available manpower these days, but we are 
working on that. So it may take some time, depends on the patch (patch size, 
how complicated, etc)(.


> Client side SASL transport for C++
> --
>
> Key: THRIFT-1667
> URL: https://issues.apache.org/jira/browse/THRIFT-1667
> Project: Thrift
>  Issue Type: Sub-task
>  Components: C++ - Library
>Reporter: Prasad Mujumdar
>  Labels: C++, client, sasl
> Attachments: Thrift-1667-patch-1.tar
>
>
> This ticket addresses the client side functionality of the C++ SASL transport.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (THRIFT-3929) PHP "nsglobal" Option Results in Syntax Error in Generated Code (Trailing Backslash)

2016-09-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510218#comment-15510218
 ] 

ASF GitHub Bot commented on THRIFT-3929:


Github user bmeynell commented on the issue:

https://github.com/apache/thrift/pull/1089
  
FWIW I tested to use case described in `THRIFT-3929` locally and it worked 
as expected.


> PHP "nsglobal" Option Results in Syntax Error in Generated Code (Trailing 
> Backslash)
> 
>
> Key: THRIFT-3929
> URL: https://issues.apache.org/jira/browse/THRIFT-3929
> Project: Thrift
>  Issue Type: Bug
>  Components: PHP - Compiler
>Affects Versions: 1.0
> Environment: Distributor ID: Ubuntu
> Description:Ubuntu 14.04.4 LTS
> Release:14.04
> Codename:   trusty
>Reporter: Ben Meynell
>  Labels: easyfix
> Fix For: 1.0
>
>
> thrift --gen php:server,psr4,oop,validate,json,nsglobal="My\Special\Place" 
> -out ./src my.thrift
> Results in PHP files with namespaces defined as:
> namespace My\Special\Place\;
> Note the trailing backslash ("\"). This results in unparseable PHP:
> $ php -l src/My/Special/Place/Data.php
> Errors parsing src/My/Special/Place/Data.php
> The fix is to simply omit the trailing backslash from the generated code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] thrift issue #1089: THRIFT-3929 php namespace remove tail "\\"

2016-09-21 Thread bmeynell
Github user bmeynell commented on the issue:

https://github.com/apache/thrift/pull/1089
  
FWIW I tested to use case described in `THRIFT-3929` locally and it worked 
as expected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Updated] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-09-21 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Buğra Gedik updated THRIFT-3932:

Description: 
{{ThreadManger::join}} calls {{stopImpl(true)}}, which in turn calls 
{{removeWorker(workerCount_);}}. The latter waits until {{while (workerCount_ 
!= workerMaxCount_)}}. Within the {{run}} method of the workers, the last 
thread that detects {{workerCount_ == workerMaxCount_}} notifies 
{{removeWorker}}. The {{run}} method has the following additional code that is 
executed at the very end:

{code}
{
  Synchronized s(manager_->workerMonitor_);
  manager_->deadWorkers_.insert(this->thread());
  if (notifyManager) {
manager_->workerMonitor_.notify();
  }
}
{code}

This is an independent synchronized block. Now assume 2 threads. One of them 
has {{notifyManager=true}} as it detected the {{workerCount_ == 
workerMaxCount_}} condition earlier. It is possible that this thread gets to 
execute  the above code block first, {{ThreadManager}}'s {{removeWorker}} 
method unblocks, and eventually {{ThreadManager}}'s {{join}} returns and the 
object is destructed. When the other thread reaches the synchronized block 
above, it will crash, as the manager is not around anymore.

Besides, {{ThreadManager}} never joins its threads.

Attached is a small fix that addresses these problems.

  was:
{{ThreadManger::join}} calls {{stopImpl(true)}}, which in turn calls 
{{removeWorker(workerCount_);}}. The latter waits until {{while (workerCount_ 
!= workerMaxCount_)}}. Within the {{run}} method of the workers, the last 
thread that detects {{workerCount_ == workerMaxCount_}} notifies 
{{removeWorker}}. The {{run}} method has the following additional code that is 
executed at the very end:

{code}
{
  Synchronized s(manager_->workerMonitor_);
  manager_->deadWorkers_.insert(this->thread());
  if (notifyManager) {
manager_->workerMonitor_.notify();
  }
}
{code}

This is an independent synchronized block. Now assume 2 threads. One of them 
has {{notifyManager=true}} as it detected the {{workerCount_ == 
workerMaxCount_}} condition earlier. It is possible that this thread gets to 
execute  the above code block first, {{ThreadManager}}'s {{removeWorker}} 
method unblocks, and eventually {{ThreadManage}}r's {{join}} returns and the 
object is destructed. When the other thread reaches the synchronized block 
above, it will crash, as the manager is not around anymore.

Besides, {{ThreadManager}} never joins its threads.

Attached is a small fix that addresses these problems.


> C++ ThreadManager has a rare termination race
> -
>
> Key: THRIFT-3932
> URL: https://issues.apache.org/jira/browse/THRIFT-3932
> Project: Thrift
>  Issue Type: Bug
>Reporter: Buğra Gedik
> Attachments: thrift-patch
>
>
> {{ThreadManger::join}} calls {{stopImpl(true)}}, which in turn calls 
> {{removeWorker(workerCount_);}}. The latter waits until {{while (workerCount_ 
> != workerMaxCount_)}}. Within the {{run}} method of the workers, the last 
> thread that detects {{workerCount_ == workerMaxCount_}} notifies 
> {{removeWorker}}. The {{run}} method has the following additional code that 
> is executed at the very end:
> {code}
> {
>   Synchronized s(manager_->workerMonitor_);
>   manager_->deadWorkers_.insert(this->thread());
>   if (notifyManager) {
> manager_->workerMonitor_.notify();
>   }
> }
> {code}
> This is an independent synchronized block. Now assume 2 threads. One of them 
> has {{notifyManager=true}} as it detected the {{workerCount_ == 
> workerMaxCount_}} condition earlier. It is possible that this thread gets to 
> execute  the above code block first, {{ThreadManager}}'s {{removeWorker}} 
> method unblocks, and eventually {{ThreadManager}}'s {{join}} returns and the 
> object is destructed. When the other thread reaches the synchronized block 
> above, it will crash, as the manager is not around anymore.
> Besides, {{ThreadManager}} never joins its threads.
> Attached is a small fix that addresses these problems.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] thrift issue #1089: THRIFT-3929 php namespace remove tail "\\"

2016-09-21 Thread RobberPhex
Github user RobberPhex commented on the issue:

https://github.com/apache/thrift/pull/1089
  
@jfarrell Can you review this pr?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (THRIFT-3929) PHP "nsglobal" Option Results in Syntax Error in Generated Code (Trailing Backslash)

2016-09-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509335#comment-15509335
 ] 

ASF GitHub Bot commented on THRIFT-3929:


Github user RobberPhex commented on the issue:

https://github.com/apache/thrift/pull/1089
  
@jfarrell Can you review this pr?


> PHP "nsglobal" Option Results in Syntax Error in Generated Code (Trailing 
> Backslash)
> 
>
> Key: THRIFT-3929
> URL: https://issues.apache.org/jira/browse/THRIFT-3929
> Project: Thrift
>  Issue Type: Bug
>  Components: PHP - Compiler
>Affects Versions: 1.0
> Environment: Distributor ID: Ubuntu
> Description:Ubuntu 14.04.4 LTS
> Release:14.04
> Codename:   trusty
>Reporter: Ben Meynell
>  Labels: easyfix
> Fix For: 1.0
>
>
> thrift --gen php:server,psr4,oop,validate,json,nsglobal="My\Special\Place" 
> -out ./src my.thrift
> Results in PHP files with namespaces defined as:
> namespace My\Special\Place\;
> Note the trailing backslash ("\"). This results in unparseable PHP:
> $ php -l src/My/Special/Place/Data.php
> Errors parsing src/My/Special/Place/Data.php
> The fix is to simply omit the trailing backslash from the generated code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (THRIFT-1667) Client side SASL transport for C++

2016-09-21 Thread Fan Yang (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509306#comment-15509306
 ] 

Fan Yang edited comment on THRIFT-1667 at 9/21/16 9:13 AM:
---

Hi [~jensg] and [~roger.meier],

I think I'm able to take over the work and make a patch for this issue. I just 
managed to make thrift work with SASL based on existing work. However I'm new 
to JIRA. Is it fine that I just make a pull request through GitHub? Will anyone 
review this patch? Thanks!

Best Regards,
Fan


was (Author: ddmbr):
[~jensg][~roger.meier]

Hi,

I think I'm able to take over the work and make a patch for this issue. I just 
managed to make thrift work with SASL based on existing work. However I'm new 
to JIRA. Is it fine that I just make a pull request through GitHub? Will anyone 
review this patch? Thanks!

Best Regards,
Fan

> Client side SASL transport for C++
> --
>
> Key: THRIFT-1667
> URL: https://issues.apache.org/jira/browse/THRIFT-1667
> Project: Thrift
>  Issue Type: Sub-task
>  Components: C++ - Library
>Reporter: Prasad Mujumdar
>  Labels: C++, client, sasl
> Attachments: Thrift-1667-patch-1.tar
>
>
> This ticket addresses the client side functionality of the C++ SASL transport.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (THRIFT-1667) Client side SASL transport for C++

2016-09-21 Thread Fan Yang (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509306#comment-15509306
 ] 

Fan Yang commented on THRIFT-1667:
--

[~jensg][~roger.meier]

Hi,

I think I'm able to take over the work and make a patch for this issue. I just 
managed to make thrift work with SASL based on existing work. However I'm new 
to JIRA. Is it fine that I just make a pull request through GitHub? Will anyone 
review this patch? Thanks!

Best Regards,
Fan

> Client side SASL transport for C++
> --
>
> Key: THRIFT-1667
> URL: https://issues.apache.org/jira/browse/THRIFT-1667
> Project: Thrift
>  Issue Type: Sub-task
>  Components: C++ - Library
>Reporter: Prasad Mujumdar
>  Labels: C++, client, sasl
> Attachments: Thrift-1667-patch-1.tar
>
>
> This ticket addresses the client side functionality of the C++ SASL transport.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] thrift issue #1036: THRIFT-3867 Specify BinaryProtocol and CompactProtocol

2016-09-21 Thread erikvanoosten
Github user erikvanoosten commented on the issue:

https://github.com/apache/thrift/pull/1036
  
The feedback cycle took more then a month. This is too long for me. I do 
not have the mental capacity to keep work in my head for that long.

Kind regards,
 Erik.



Op 20-09-16 om 21:49 schreef Jens Geyer:
>
> Why?
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub 
> , 
> or mute the thread 
> 
.
>




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (THRIFT-3867) Specify BinaryProtocol and CompactProtocol

2016-09-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509144#comment-15509144
 ] 

ASF GitHub Bot commented on THRIFT-3867:


Github user erikvanoosten commented on the issue:

https://github.com/apache/thrift/pull/1036
  
The feedback cycle took more then a month. This is too long for me. I do 
not have the mental capacity to keep work in my head for that long.

Kind regards,
 Erik.



Op 20-09-16 om 21:49 schreef Jens Geyer:
>
> Why?
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub 
> , 
> or mute the thread 
> 
.
>




> Specify BinaryProtocol and CompactProtocol
> --
>
> Key: THRIFT-3867
> URL: https://issues.apache.org/jira/browse/THRIFT-3867
> Project: Thrift
>  Issue Type: Documentation
>  Components: Documentation
>Reporter: Erik van Oosten
>
> It would be nice when the protocol(s) would be specified somewhere. This 
> should improve communication between developers, but also opens the way for 
> alternative implementations so that Thrift can thrive even better.
> I have a fairly complete description of the BinaryProtocol and 
> CompactProtocol which I will submit as a patch for further review and 
> discussion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] thrift issue #1036: THRIFT-3867 Specify BinaryProtocol and CompactProtocol

2016-09-21 Thread erikvanoosten
Github user erikvanoosten commented on the issue:

https://github.com/apache/thrift/pull/1036
  
Feel free to take it. I won't support it anymore though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (THRIFT-3867) Specify BinaryProtocol and CompactProtocol

2016-09-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509129#comment-15509129
 ] 

ASF GitHub Bot commented on THRIFT-3867:


Github user erikvanoosten commented on the issue:

https://github.com/apache/thrift/pull/1036
  
Feel free to take it. I won't support it anymore though.


> Specify BinaryProtocol and CompactProtocol
> --
>
> Key: THRIFT-3867
> URL: https://issues.apache.org/jira/browse/THRIFT-3867
> Project: Thrift
>  Issue Type: Documentation
>  Components: Documentation
>Reporter: Erik van Oosten
>
> It would be nice when the protocol(s) would be specified somewhere. This 
> should improve communication between developers, but also opens the way for 
> alternative implementations so that Thrift can thrive even better.
> I have a fairly complete description of the BinaryProtocol and 
> CompactProtocol which I will submit as a patch for further review and 
> discussion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)