[GitHub] thrift issue #1153: fix a bug in windows
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1153 Tracked in THRIFT-4038 @GZShi: next time please have a look at our [contrib guidelines](http://thrift.apache.org/docs/HowToContribute) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (THRIFT-4038) socket check: checking an unsigned number against >= 0 never fails
Jens Geyer created THRIFT-4038: -- Summary: socket check: checking an unsigned number against >= 0 never fails Key: THRIFT-4038 URL: https://issues.apache.org/jira/browse/THRIFT-4038 Project: Thrift Issue Type: Bug Environment: Windows Reporter: Jens Geyer The SOCKET type is defined as a unsigned number in windows, the evutil_socket_t variables are always large than zero, therefore the condition not work well here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-4038) socket check: checking an unsigned number against >= 0 never fails
[ https://issues.apache.org/jira/browse/THRIFT-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833460#comment-15833460 ] ASF GitHub Bot commented on THRIFT-4038: Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1153 Tracked in THRIFT-4038 @GZShi: next time please have a look at our [contrib guidelines](http://thrift.apache.org/docs/HowToContribute) > socket check: checking an unsigned number against >= 0 never fails > -- > > Key: THRIFT-4038 > URL: https://issues.apache.org/jira/browse/THRIFT-4038 > Project: Thrift > Issue Type: Bug > Environment: Windows >Reporter: Jens Geyer > > The SOCKET type is defined as a unsigned number in windows, the > evutil_socket_t variables are always large than zero, therefore the > condition not work well here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-4038) socket check: checking an unsigned number against >= 0 never fails
[ https://issues.apache.org/jira/browse/THRIFT-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833485#comment-15833485 ] Jens Geyer commented on THRIFT-4038: fix a bug in windows The `SOCKET` type is defined as a unsigned number in windows, the `evutil_socket_t` variables are always large than zero, therefore the condition not work well here. You can merge this pull request into a Git repository by running: $ git pull https://github.com/GZShi/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1153.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1153 commit 46d73d3d0e0819d6d95805f4b228e3e3c8408082 Author: gzshi Date: 2017-01-06T02:47:03Z fix a bug in windows The `SOCKET` type is defined as a unsigned number in windows, the `evutil_socket_t` variables are always large than zero, therefore the condition not work well here. > socket check: checking an unsigned number against >= 0 never fails > -- > > Key: THRIFT-4038 > URL: https://issues.apache.org/jira/browse/THRIFT-4038 > Project: Thrift > Issue Type: Bug > Environment: Windows >Reporter: Jens Geyer > > The SOCKET type is defined as a unsigned number in windows, the > evutil_socket_t variables are always large than zero, therefore the > condition not work well here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request #1153: fix a bug in windows
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1153 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (THRIFT-4038) socket check: checking an unsigned number against >= 0 never fails
[ https://issues.apache.org/jira/browse/THRIFT-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-4038. Resolution: Fixed Assignee: Jens Geyer Fix Version/s: 0.11.0 Committed. > socket check: checking an unsigned number against >= 0 never fails > -- > > Key: THRIFT-4038 > URL: https://issues.apache.org/jira/browse/THRIFT-4038 > Project: Thrift > Issue Type: Bug > Environment: Windows >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.11.0 > > > The SOCKET type is defined as a unsigned number in windows, the > evutil_socket_t variables are always large than zero, therefore the > condition not work well here. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2945) Implement support for Rust language
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833497#comment-15833497 ] ASF GitHub Bot commented on THRIFT-2945: Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1147 @anatol Code has been updated with the following changes: - All usage of `try!` converted to `?` - Fix all but two clippy lint warnings (I thought the existing code was clearer) > Implement support for Rust language > --- > > Key: THRIFT-2945 > URL: https://issues.apache.org/jira/browse/THRIFT-2945 > Project: Thrift > Issue Type: New Feature > Components: Wish List >Reporter: Maksim Golov >Assignee: Jeremy Fitzhardinge > > Work on implementing support for Rust is in progress: > https://github.com/maximg/thrift by Simon Génier and myself. > It will probably take quite some time to complete. Please keep us updated if > there are changes related to our work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift issue #1147: THRIFT-2945 Add Rust support
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1147 @anatol Code has been updated with the following changes: - All usage of `try!` converted to `?` - Fix all but two clippy lint warnings (I thought the existing code was clearer) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1147: THRIFT-2945 Add Rust support
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1147 More updates: - Minor cleanups to Rust code generators - Confirmed that all Rust code does not trigger any clippy lint warnings --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2945) Implement support for Rust language
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833537#comment-15833537 ] ASF GitHub Bot commented on THRIFT-2945: Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1147 More updates: - Minor cleanups to Rust code generators - Confirmed that all Rust code does not trigger any clippy lint warnings > Implement support for Rust language > --- > > Key: THRIFT-2945 > URL: https://issues.apache.org/jira/browse/THRIFT-2945 > Project: Thrift > Issue Type: New Feature > Components: Wish List >Reporter: Maksim Golov >Assignee: Jeremy Fitzhardinge > > Work on implementing support for Rust is in progress: > https://github.com/maximg/thrift by Simon Génier and myself. > It will probably take quite some time to complete. Please keep us updated if > there are changes related to our work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift issue #1161: THRIFT-4034 CMake doesn't work to build compiler
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1161 All ci have passed, finally. Please merge this pr. :) --- change list: * appveyor have installed openssl, removed installation of openssl * remove HACK of `thrifty.hh` rename to `thrifty.h` * **thrift-compiler can build by cmake, `compiler/cpp/README.md` can work.** --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4034) CMake doesn't work to build compiler
[
https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833618#comment-15833618
]
ASF GitHub Bot commented on THRIFT-4034:
Github user RobberPhex commented on the issue:
https://github.com/apache/thrift/pull/1161
All ci have passed, finally.
Please merge this pr. :)
---
change list:
* appveyor have installed openssl, removed installation of openssl
* remove HACK of `thrifty.hh` rename to `thrifty.h`
* **thrift-compiler can build by cmake, `compiler/cpp/README.md` can work.**
> CMake doesn't work to build compiler
>
>
> Key: THRIFT-4034
> URL: https://issues.apache.org/jira/browse/THRIFT-4034
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
>Affects Versions: 0.10.0
> Environment: macOS Sierra + CMake 3.7.2
>Reporter: Robert Lu
>Assignee: Robert Lu
> Labels: beginner
> Fix For: 0.11.0
>
>
> AS
> [document|https://github.com/apache/thrift/blob/0.10.0/compiler/cpp/README.md#build-compiler-using-cmake]
> said.
> When I ran {{cmake ..}} in {{/thrift/compiler/cpp/cmake-build}}, CMake
> reports error as below:
> {quote}
> -- The C compiler identification is AppleClang 8.0.0.842
> -- The CXX compiler identification is AppleClang 8.0.0.842
> -- Check for working C compiler:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
> -- Check for working C compiler:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
> -- works
> -- Detecting C compiler ABI info
> -- Detecting C compiler ABI info - done
> -- Detecting C compile features
> -- Detecting C compile features - done
> -- Check for working CXX compiler:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
> -- Check for working CXX compiler:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
> -- works
> -- Detecting CXX compiler ABI info
> -- Detecting CXX compiler ABI info - done
> -- Detecting CXX compile features
> -- Detecting CXX compile features - done
> -- Found FLEX: /usr/bin/flex (found version "2.5.35")
> -- Found BISON: /usr/local/bin/bison (found version "3.0.4")
> CMake Error at CMakeLists.txt:152 (install):
> install TARGETS given no RUNTIME DESTINATION for executable target
> "thrift-compiler".
> CMake Warning (dev) in CMakeLists.txt:
> No cmake_minimum_required command is present. A line of code such as
> cmake_minimum_required(VERSION 3.7)
> should be added at the top of the file. The version specified may be lower
> if you wish to support older CMake versions for this project. For more
> information run "cmake --help-policy CMP".
> This warning is for project developers. Use -Wno-dev to suppress it.
> -- Configuring incomplete, errors occurred!
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] thrift pull request #1163: Update of Apache Thrift .Net Core lib
GitHub user vgotra opened a pull request: https://github.com/apache/thrift/pull/1163 Update of Apache Thrift .Net Core lib Changes to library: - Updated tutorial (added samples of usage of multiplexed protocol to server and client side and other) - Added framed transport to client side and implementation of framed transport to server - Updated information related to build of thrift application with CMake, Visual Studio 2017, XCode - Updated information related to build and usage of Thrift .Net Core library - Added SDK versions to project for easy usage of different versions of .NET Core SDK You can merge this pull request into a Git repository by running: $ git pull https://github.com/vgotra/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1163.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1163 commit 078c88e407bc1273ff9336373e7e29b3c87e808a Author: Volodymyr Gotra Date: 2017-01-16T00:34:28Z Added framed transport, updated docs, updated global.json with SDKversion commit 9dfef2c263c16b603cb15f81eb7acb2262598c8d Author: Volodymyr Gotra Date: 2017-01-16T01:59:28Z Added usage to multiplexer to tutorial commit d4b6f44fb3497d2cdc934a4cebb98c4d971bbc49 Author: Volodymyr Gotra Date: 2017-01-16T02:03:15Z Changed sdk to current sdk 1.0.0-preview2-1-003177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1163: Update of Apache Thrift .Net Core lib
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1163 http://thrift.apache.org/docs/HowToContribute --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (THRIFT-4039) Update of Apache Thrift .Net Core lib
Volodymyr Gotra created THRIFT-4039: --- Summary: Update of Apache Thrift .Net Core lib Key: THRIFT-4039 URL: https://issues.apache.org/jira/browse/THRIFT-4039 Project: Thrift Issue Type: New Feature Components: .NETCore - Library, Build Process, Documentation, Tutorial Reporter: Volodymyr Gotra Changes to library: Updated tutorial (added samples of usage of multiplexed protocol to server and client side and other) Added framed transport to client side and implementation of framed transport to server Updated information related to build of thrift application with CMake, Visual Studio 2017, XCode Updated information related to build and usage of Thrift .Net Core library Added SDK versions to project for easy usage of different versions of .NET Core SDK -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift issue #1163: THRIFT-4039: Update of Apache Thrift .Net Core lib
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1163 Hi @Jens-G Added pull request with changes described in Jira task and in pull request. Later after stabilizing and release of .NET Standard 2.0 I will create new request with migration to latest stable .NET Core SDK. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4039) Update of Apache Thrift .Net Core lib
[ https://issues.apache.org/jira/browse/THRIFT-4039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833626#comment-15833626 ] ASF GitHub Bot commented on THRIFT-4039: Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1163 Hi @Jens-G Added pull request with changes described in Jira task and in pull request. Later after stabilizing and release of .NET Standard 2.0 I will create new request with migration to latest stable .NET Core SDK. Thanks > Update of Apache Thrift .Net Core lib > -- > > Key: THRIFT-4039 > URL: https://issues.apache.org/jira/browse/THRIFT-4039 > Project: Thrift > Issue Type: New Feature > Components: .NETCore - Library, Build Process, Documentation, > Tutorial >Reporter: Volodymyr Gotra > > Changes to library: > Updated tutorial (added samples of usage of multiplexed protocol to > server and client side and other) > Added framed transport to client side and implementation of framed > transport to server > Updated information related to build of thrift application with CMake, > Visual Studio 2017, XCode > Updated information related to build and usage of Thrift .Net Core library > Added SDK versions to project for easy usage of different versions of > .NET Core SDK -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-4039) Update of Apache Thrift .Net Core lib
[ https://issues.apache.org/jira/browse/THRIFT-4039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833634#comment-15833634 ] Jens Geyer commented on THRIFT-4039: GitHub user vgotra opened a pull request: https://github.com/apache/thrift/pull/1163 Update of Apache Thrift .Net Core lib Changes to library: - Updated tutorial (added samples of usage of multiplexed protocol to server and client side and other) - Added framed transport to client side and implementation of framed transport to server - Updated information related to build of thrift application with CMake, Visual Studio 2017, XCode - Updated information related to build and usage of Thrift .Net Core library - Added SDK versions to project for easy usage of different versions of .NET Core SDK You can merge this pull request into a Git repository by running: $ git pull https://github.com/vgotra/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1163.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1163 commit 078c88e407bc1273ff9336373e7e29b3c87e808a Author: Volodymyr Gotra Date: 2017-01-16T00:34:28Z Added framed transport, updated docs, updated global.json with SDKversion commit 9dfef2c263c16b603cb15f81eb7acb2262598c8d Author: Volodymyr Gotra Date: 2017-01-16T01:59:28Z Added usage to multiplexer to tutorial commit d4b6f44fb3497d2cdc934a4cebb98c4d971bbc49 Author: Volodymyr Gotra Date: 2017-01-16T02:03:15Z Changed sdk to current sdk 1.0.0-preview2-1-003177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- > Update of Apache Thrift .Net Core lib > -- > > Key: THRIFT-4039 > URL: https://issues.apache.org/jira/browse/THRIFT-4039 > Project: Thrift > Issue Type: New Feature > Components: .NETCore - Library, Build Process, Documentation, > Tutorial >Reporter: Volodymyr Gotra > > Changes to library: > Updated tutorial (added samples of usage of multiplexed protocol to > server and client side and other) > Added framed transport to client side and implementation of framed > transport to server > Updated information related to build of thrift application with CMake, > Visual Studio 2017, XCode > Updated information related to build and usage of Thrift .Net Core library > Added SDK versions to project for easy usage of different versions of > .NET Core SDK -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (THRIFT-4039) Update of Apache Thrift .Net Core lib
[ https://issues.apache.org/jira/browse/THRIFT-4039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-4039: -- Assignee: Jens Geyer > Update of Apache Thrift .Net Core lib > -- > > Key: THRIFT-4039 > URL: https://issues.apache.org/jira/browse/THRIFT-4039 > Project: Thrift > Issue Type: New Feature > Components: .NETCore - Library, Build Process, Documentation, > Tutorial >Reporter: Volodymyr Gotra >Assignee: Jens Geyer > > Changes to library: > Updated tutorial (added samples of usage of multiplexed protocol to > server and client side and other) > Added framed transport to client side and implementation of framed > transport to server > Updated information related to build of thrift application with CMake, > Visual Studio 2017, XCode > Updated information related to build and usage of Thrift .Net Core library > Added SDK versions to project for easy usage of different versions of > .NET Core SDK -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift issue #1147: THRIFT-2945 Add Rust support
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1147 Fixed makefile errors with `make distdir` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2945) Implement support for Rust language
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833725#comment-15833725 ] ASF GitHub Bot commented on THRIFT-2945: Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1147 Fixed makefile errors with `make distdir` > Implement support for Rust language > --- > > Key: THRIFT-2945 > URL: https://issues.apache.org/jira/browse/THRIFT-2945 > Project: Thrift > Issue Type: New Feature > Components: Wish List >Reporter: Maksim Golov >Assignee: Jeremy Fitzhardinge > > Work on implementing support for Rust is in progress: > https://github.com/maximg/thrift by Simon Génier and myself. > It will probably take quite some time to complete. Please keep us updated if > there are changes related to our work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift issue #1147: THRIFT-2945 Add Rust support
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1147 Yay! Build passed :) Any thoughts on whether this is OK to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2945) Implement support for Rust language
[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833757#comment-15833757 ] ASF GitHub Bot commented on THRIFT-2945: Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1147 Yay! Build passed :) Any thoughts on whether this is OK to merge? > Implement support for Rust language > --- > > Key: THRIFT-2945 > URL: https://issues.apache.org/jira/browse/THRIFT-2945 > Project: Thrift > Issue Type: New Feature > Components: Wish List >Reporter: Maksim Golov >Assignee: Jeremy Fitzhardinge > > Work on implementing support for Rust is in progress: > https://github.com/maximg/thrift by Simon Génier and myself. > It will probably take quite some time to complete. Please keep us updated if > there are changes related to our work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request #1161: THRIFT-4034 CMake doesn't work to build compiler
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1161#discussion_r97247885
--- Diff: compiler/cpp/CMakeLists.txt ---
@@ -53,6 +53,7 @@ set(compiler_core
set(thrift-compiler_SOURCES
src/thrift/main.cc
src/thrift/audit/t_audit.cpp
+${compiler_core}
--- End diff --
This will still break the thrift compiler plug-in module support, won't it?
The compiler_core modules must be conditionally added depending on the
WITH_PLUGIN setting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (THRIFT-4034) CMake doesn't work to build compiler
[
https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833864#comment-15833864
]
ASF GitHub Bot commented on THRIFT-4034:
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1161#discussion_r97247885
--- Diff: compiler/cpp/CMakeLists.txt ---
@@ -53,6 +53,7 @@ set(compiler_core
set(thrift-compiler_SOURCES
src/thrift/main.cc
src/thrift/audit/t_audit.cpp
+${compiler_core}
--- End diff --
This will still break the thrift compiler plug-in module support, won't it?
The compiler_core modules must be conditionally added depending on the
WITH_PLUGIN setting.
> CMake doesn't work to build compiler
>
>
> Key: THRIFT-4034
> URL: https://issues.apache.org/jira/browse/THRIFT-4034
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
>Affects Versions: 0.10.0
> Environment: macOS Sierra + CMake 3.7.2
>Reporter: Robert Lu
>Assignee: Robert Lu
> Labels: beginner
> Fix For: 0.11.0
>
>
> AS
> [document|https://github.com/apache/thrift/blob/0.10.0/compiler/cpp/README.md#build-compiler-using-cmake]
> said.
> When I ran {{cmake ..}} in {{/thrift/compiler/cpp/cmake-build}}, CMake
> reports error as below:
> {quote}
> -- The C compiler identification is AppleClang 8.0.0.842
> -- The CXX compiler identification is AppleClang 8.0.0.842
> -- Check for working C compiler:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
> -- Check for working C compiler:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
> -- works
> -- Detecting C compiler ABI info
> -- Detecting C compiler ABI info - done
> -- Detecting C compile features
> -- Detecting C compile features - done
> -- Check for working CXX compiler:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
> -- Check for working CXX compiler:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
> -- works
> -- Detecting CXX compiler ABI info
> -- Detecting CXX compiler ABI info - done
> -- Detecting CXX compile features
> -- Detecting CXX compile features - done
> -- Found FLEX: /usr/bin/flex (found version "2.5.35")
> -- Found BISON: /usr/local/bin/bison (found version "3.0.4")
> CMake Error at CMakeLists.txt:152 (install):
> install TARGETS given no RUNTIME DESTINATION for executable target
> "thrift-compiler".
> CMake Warning (dev) in CMakeLists.txt:
> No cmake_minimum_required command is present. A line of code such as
> cmake_minimum_required(VERSION 3.7)
> should be added at the top of the file. The version specified may be lower
> if you wish to support older CMake versions for this project. For more
> information run "cmake --help-policy CMP".
> This warning is for project developers. Use -Wno-dev to suppress it.
> -- Configuring incomplete, errors occurred!
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] thrift issue #1161: THRIFT-4034 CMake doesn't work to build compiler
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1161 @jeking3 fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4034) CMake doesn't work to build compiler
[
https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833919#comment-15833919
]
ASF GitHub Bot commented on THRIFT-4034:
Github user RobberPhex commented on the issue:
https://github.com/apache/thrift/pull/1161
@jeking3 fixed
> CMake doesn't work to build compiler
>
>
> Key: THRIFT-4034
> URL: https://issues.apache.org/jira/browse/THRIFT-4034
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
>Affects Versions: 0.10.0
> Environment: macOS Sierra + CMake 3.7.2
>Reporter: Robert Lu
>Assignee: Robert Lu
> Labels: beginner
> Fix For: 0.11.0
>
>
> AS
> [document|https://github.com/apache/thrift/blob/0.10.0/compiler/cpp/README.md#build-compiler-using-cmake]
> said.
> When I ran {{cmake ..}} in {{/thrift/compiler/cpp/cmake-build}}, CMake
> reports error as below:
> {quote}
> -- The C compiler identification is AppleClang 8.0.0.842
> -- The CXX compiler identification is AppleClang 8.0.0.842
> -- Check for working C compiler:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
> -- Check for working C compiler:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
> -- works
> -- Detecting C compiler ABI info
> -- Detecting C compiler ABI info - done
> -- Detecting C compile features
> -- Detecting C compile features - done
> -- Check for working CXX compiler:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
> -- Check for working CXX compiler:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
> -- works
> -- Detecting CXX compiler ABI info
> -- Detecting CXX compiler ABI info - done
> -- Detecting CXX compile features
> -- Detecting CXX compile features - done
> -- Found FLEX: /usr/bin/flex (found version "2.5.35")
> -- Found BISON: /usr/local/bin/bison (found version "3.0.4")
> CMake Error at CMakeLists.txt:152 (install):
> install TARGETS given no RUNTIME DESTINATION for executable target
> "thrift-compiler".
> CMake Warning (dev) in CMakeLists.txt:
> No cmake_minimum_required command is present. A line of code such as
> cmake_minimum_required(VERSION 3.7)
> should be added at the top of the file. The version specified may be lower
> if you wish to support older CMake versions for this project. For more
> information run "cmake --help-policy CMP".
> This warning is for project developers. Use -Wno-dev to suppress it.
> -- Configuring incomplete, errors occurred!
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] thrift issue #1161: THRIFT-4034 CMake doesn't work to build compiler
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1161 @jeking3 I think `/CMakeList.txt` is the only entrance, we can just improve document, to fix this issue, is it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4034) CMake doesn't work to build compiler
[
https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833942#comment-15833942
]
ASF GitHub Bot commented on THRIFT-4034:
Github user RobberPhex commented on the issue:
https://github.com/apache/thrift/pull/1161
@jeking3 I think `/CMakeList.txt` is the only entrance, we can just improve
document, to fix this issue, is it?
> CMake doesn't work to build compiler
>
>
> Key: THRIFT-4034
> URL: https://issues.apache.org/jira/browse/THRIFT-4034
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
>Affects Versions: 0.10.0
> Environment: macOS Sierra + CMake 3.7.2
>Reporter: Robert Lu
>Assignee: Robert Lu
> Labels: beginner
> Fix For: 0.11.0
>
>
> AS
> [document|https://github.com/apache/thrift/blob/0.10.0/compiler/cpp/README.md#build-compiler-using-cmake]
> said.
> When I ran {{cmake ..}} in {{/thrift/compiler/cpp/cmake-build}}, CMake
> reports error as below:
> {quote}
> -- The C compiler identification is AppleClang 8.0.0.842
> -- The CXX compiler identification is AppleClang 8.0.0.842
> -- Check for working C compiler:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
> -- Check for working C compiler:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
> -- works
> -- Detecting C compiler ABI info
> -- Detecting C compiler ABI info - done
> -- Detecting C compile features
> -- Detecting C compile features - done
> -- Check for working CXX compiler:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
> -- Check for working CXX compiler:
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
> -- works
> -- Detecting CXX compiler ABI info
> -- Detecting CXX compiler ABI info - done
> -- Detecting CXX compile features
> -- Detecting CXX compile features - done
> -- Found FLEX: /usr/bin/flex (found version "2.5.35")
> -- Found BISON: /usr/local/bin/bison (found version "3.0.4")
> CMake Error at CMakeLists.txt:152 (install):
> install TARGETS given no RUNTIME DESTINATION for executable target
> "thrift-compiler".
> CMake Warning (dev) in CMakeLists.txt:
> No cmake_minimum_required command is present. A line of code such as
> cmake_minimum_required(VERSION 3.7)
> should be added at the top of the file. The version specified may be lower
> if you wish to support older CMake versions for this project. For more
> information run "cmake --help-policy CMP".
> This warning is for project developers. Use -Wno-dev to suppress it.
> -- Configuring incomplete, errors occurred!
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
