[GitHub] thrift pull request #1175: Update node library dependencies

[zertosh]

GitHub user zertosh opened a pull request:

https://github.com/apache/thrift/pull/1175

Update node library dependencies

* The changes to node-int64 and Q are small:
  - https://github.com/broofa/node-int64/compare/v0.3.3...v0.4.0
  - https://github.com/kriskowal/q/compare/v1.0.1...v1.4.1
* ws under went a rewrite between 0.4.32 and 2.0.1 
(https://github.com/websockets/ws/compare/0.4.32...2.0.1). The API as used by 
thrift is backwards compatible. However, ws now uses ES6 syntax, so it requires 
at least Node 4.
  - Most notable change here is that ws no longer tries to install binary 
modules.
* Node 4 is now the minimally required version of Node, due to ws' 
requirement.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zertosh/thrift THRIFT-4064

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1175.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1175


commit face8c95163fc1b382ce7522b64334547fd43eca
Author: Andres Suarez 
Date:   2017-02-01T19:37:45Z

Update node library dependencies

* The changes to node-int64 and Q are small:
  - https://github.com/broofa/node-int64/compare/v0.3.3...v0.4.0
  - https://github.com/kriskowal/q/compare/v1.0.1...v1.4.1
* ws under went a rewrite between 0.4.32 and 2.0.1 
(https://github.com/websockets/ws/compare/0.4.32...2.0.1). The API as used by 
thrift is backwards compatible. However, ws now uses ES6 syntax, so it requires 
at least Node 4.
  - Most notable change here is that ws no longer tries to install binary 
modules.
* Node 4 is now the minimally required version of Node, due to ws' 
requirement.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-4064) Update node library dependencies

[Jake Farrell (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848744#comment-15848744
 ] 

Jake Farrell commented on THRIFT-4064:
--

We typically try and stay with the latest versions available that comes with 
support in the current common latest LTS, which have nodejs versions of

ubuntu:16.04 - v4.2.6
centos:7 - v6.9.1
debian:8 - v0.10.29

would probably go with ws@2.x.x since 2/3 OS versions are defaulting node 4+, 
will have to update the Dockerfile for debian to install a newer version so 
tests continue to pass

> Update node library dependencies
> 
>
> Key: THRIFT-4064
> URL: https://issues.apache.org/jira/browse/THRIFT-4064
> Project: Thrift
>  Issue Type: Improvement
>  Components: Node.js - Library
>Affects Versions: 0.10.0
>Reporter: Andres Suarez
>
> ws@0.4.32 is really old and presents issues for users using modern versions 
> of Node (see 
> https://github.com/apache/thrift/pull/672#issuecomment-276678791). Its should 
> be updated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4063) Sources for libthrift 0.10.0 are missing from Maven Central

[Zac Bentley (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848611#comment-15848611
 ] 

Zac Bentley commented on THRIFT-4063:
-

Thanks so much!

> Sources for libthrift 0.10.0 are missing from Maven Central
> ---
>
> Key: THRIFT-4063
> URL: https://issues.apache.org/jira/browse/THRIFT-4063
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.10.0
>Reporter: Zac Bentley
>Assignee: Jake Farrell
>Priority: Minor
>
> The other versions of libthrift have source JARs on Maven Central; 0.10.0 
> does not.
> Could sources be published?
> Alternatively, is there some way to wire up the Git repository as a source 
> JAR, using e.g. jitpack.io's maven dependency-from-git-repo converter?
> Tentatively classifying this as a bug, since it seems inconsistent with all 
> the other releases on Central.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4064) Update node library dependencies

[Andres Suarez (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848580#comment-15848580
 ] 

Andres Suarez commented on THRIFT-4064:
---

[~jfarrell] I have two choices for versions of ws: I can go with 1.x.x which 
requires at least node 0.12.0, or I can go with 2.x.x which requires at least 
node 4.0.0.

> Update node library dependencies
> 
>
> Key: THRIFT-4064
> URL: https://issues.apache.org/jira/browse/THRIFT-4064
> Project: Thrift
>  Issue Type: Improvement
>  Components: Node.js - Library
>Affects Versions: 0.10.0
>Reporter: Andres Suarez
>
> ws@0.4.32 is really old and presents issues for users using modern versions 
> of Node (see 
> https://github.com/apache/thrift/pull/672#issuecomment-276678791). Its should 
> be updated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (THRIFT-4064) Update node library dependencies

[Andres Suarez (JIRA)]

Andres Suarez created THRIFT-4064:
-

 Summary: Update node library dependencies
 Key: THRIFT-4064
 URL: https://issues.apache.org/jira/browse/THRIFT-4064
 Project: Thrift
  Issue Type: Improvement
  Components: Node.js - Library
Affects Versions: 0.10.0
Reporter: Andres Suarez


ws@0.4.32 is really old and presents issues for users using modern versions of 
Node (see https://github.com/apache/thrift/pull/672#issuecomment-276678791). 
Its should be updated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4064) Update node library dependencies

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848577#comment-15848577
 ] 

ASF GitHub Bot commented on THRIFT-4064:


Github user zertosh commented on the issue:

https://github.com/apache/thrift/pull/672
  
@jfarrell will do. Made an issue 
https://issues.apache.org/jira/browse/THRIFT-4064


> Update node library dependencies
> 
>
> Key: THRIFT-4064
> URL: https://issues.apache.org/jira/browse/THRIFT-4064
> Project: Thrift
>  Issue Type: Improvement
>  Components: Node.js - Library
>Affects Versions: 0.10.0
>Reporter: Andres Suarez
>
> ws@0.4.32 is really old and presents issues for users using modern versions 
> of Node (see 
> https://github.com/apache/thrift/pull/672#issuecomment-276678791). Its should 
> be updated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift issue #672: Fix package.json to include only the needed files

[zertosh]

Github user zertosh commented on the issue:

https://github.com/apache/thrift/pull/672
  
@jfarrell will do. Made an issue 
https://issues.apache.org/jira/browse/THRIFT-4064


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-4032) no libthrift 0.10.0 in https://repo1.maven.org/maven2/org/apache/thrift/libthrift/

[Jake Farrell (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848569#comment-15848569
 ] 

Jake Farrell commented on THRIFT-4032:
--

0.10.0 now has jar, sources, and javadoc on repository.apache.org. This should 
get mirrored over to Maven Central in the next 24 hours

https://repository.apache.org/#nexus-search;quick~org.apache.thrift

> no libthrift 0.10.0 in 
> https://repo1.maven.org/maven2/org/apache/thrift/libthrift/
> --
>
> Key: THRIFT-4032
> URL: https://issues.apache.org/jira/browse/THRIFT-4032
> Project: Thrift
>  Issue Type: Bug
>  Components: Java - Library
>Affects Versions: 0.10.0
>Reporter: Xiaoshuang LU
>Assignee: Jake Farrell
> Fix For: 0.10.0
>
>
> https://repo1.maven.org/maven2/org/apache/thrift/libthrift/
> {code}
> Index of /maven2/org/apache/thrift/libthrift/
> ../
> 0.6.1/ 2011-04-25 08:54   
>  -
> 0.7.0/ 2011-08-13 17:27   
>  -
> 0.8.0/ 2011-11-29 18:34   
>  -
> 0.9.0/ 2012-10-15 21:50   
>  -
> 0.9.1/ 2013-08-23 10:26   
>  -
> 0.9.2/ 2014-11-18 12:19   
>  -
> 0.9.3/ 2015-10-11 21:19   
>  -
> maven-metadata.xml 2015-10-11 21:19   
>519
> maven-metadata.xml.md5 2015-10-11 21:19   
> 32
> maven-metadata.xml.sha12015-10-11 21:19   
> 40
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (THRIFT-4063) Sources for libthrift 0.10.0 are missing from Maven Central

[Jake Farrell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell closed THRIFT-4063.

Resolution: Fixed

0.10.0 now has jar, sources, and javadoc on repository.apache.org. This should 
get mirrored over to Maven Central in the next 24 hours

https://repository.apache.org/#nexus-search;quick~org.apache.thrift


> Sources for libthrift 0.10.0 are missing from Maven Central
> ---
>
> Key: THRIFT-4063
> URL: https://issues.apache.org/jira/browse/THRIFT-4063
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.10.0
>Reporter: Zac Bentley
>Assignee: Jake Farrell
>Priority: Minor
>
> The other versions of libthrift have source JARs on Maven Central; 0.10.0 
> does not.
> Could sources be published?
> Alternatively, is there some way to wire up the Git repository as a source 
> JAR, using e.g. jitpack.io's maven dependency-from-git-repo converter?
> Tentatively classifying this as a bug, since it seems inconsistent with all 
> the other releases on Central.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4032) no libthrift 0.10.0 in https://repo1.maven.org/maven2/org/apache/thrift/libthrift/

[Jake Farrell (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848526#comment-15848526
 ] 

Jake Farrell commented on THRIFT-4032:
--

sources should not be required to mirror jars over to maven central, the 
thrift-maven-plugin was mirrored over successfully [1] and it does not contain 
a sources jar, looking into this

[1]: 
https://search.maven.org/#artifactdetails%7Corg.apache.thrift%7Cthrift-maven-plugin%7C0.10.0%7Cmaven-plugin

> no libthrift 0.10.0 in 
> https://repo1.maven.org/maven2/org/apache/thrift/libthrift/
> --
>
> Key: THRIFT-4032
> URL: https://issues.apache.org/jira/browse/THRIFT-4032
> Project: Thrift
>  Issue Type: Bug
>  Components: Java - Library
>Affects Versions: 0.10.0
>Reporter: Xiaoshuang LU
>Assignee: Jake Farrell
> Fix For: 0.10.0
>
>
> https://repo1.maven.org/maven2/org/apache/thrift/libthrift/
> {code}
> Index of /maven2/org/apache/thrift/libthrift/
> ../
> 0.6.1/ 2011-04-25 08:54   
>  -
> 0.7.0/ 2011-08-13 17:27   
>  -
> 0.8.0/ 2011-11-29 18:34   
>  -
> 0.9.0/ 2012-10-15 21:50   
>  -
> 0.9.1/ 2013-08-23 10:26   
>  -
> 0.9.2/ 2014-11-18 12:19   
>  -
> 0.9.3/ 2015-10-11 21:19   
>  -
> maven-metadata.xml 2015-10-11 21:19   
>519
> maven-metadata.xml.md5 2015-10-11 21:19   
> 32
> maven-metadata.xml.sha12015-10-11 21:19   
> 40
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Issue Comment Deleted] (THRIFT-4063) Sources for libthrift 0.10.0 are missing from Maven Central

[Zac Bentley (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zac Bentley updated THRIFT-4063:

Comment: was deleted

(was: The 0.10.0 release is not visible on the main version list on Central 
either; that may be related? 

https://mvnrepository.com/artifact/org.apache.thrift/libthrift

However, it can still be downloaded by Maven per the instructions on 
https://thrift.apache.org/download, so it appears to at least be available in 
that way.

I don't know Maven hardly at all, though, so this may all be misguided.)

> Sources for libthrift 0.10.0 are missing from Maven Central
> ---
>
> Key: THRIFT-4063
> URL: https://issues.apache.org/jira/browse/THRIFT-4063
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.10.0
>Reporter: Zac Bentley
>Assignee: Jake Farrell
>Priority: Minor
>
> The other versions of libthrift have source JARs on Maven Central; 0.10.0 
> does not.
> Could sources be published?
> Alternatively, is there some way to wire up the Git repository as a source 
> JAR, using e.g. jitpack.io's maven dependency-from-git-repo converter?
> Tentatively classifying this as a bug, since it seems inconsistent with all 
> the other releases on Central.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4063) Sources for libthrift 0.10.0 are missing from Maven Central

[Zac Bentley (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848514#comment-15848514
 ] 

Zac Bentley commented on THRIFT-4063:
-

The 0.10.0 release is not visible on the main version list on Central either; 
that may be related? 

https://mvnrepository.com/artifact/org.apache.thrift/libthrift

However, it can still be downloaded by Maven per the instructions on 
https://thrift.apache.org/download, so it appears to at least be available in 
that way.

I don't know Maven hardly at all, though, so this may all be misguided.

> Sources for libthrift 0.10.0 are missing from Maven Central
> ---
>
> Key: THRIFT-4063
> URL: https://issues.apache.org/jira/browse/THRIFT-4063
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.10.0
>Reporter: Zac Bentley
>Assignee: Jake Farrell
>Priority: Minor
>
> The other versions of libthrift have source JARs on Maven Central; 0.10.0 
> does not.
> Could sources be published?
> Alternatively, is there some way to wire up the Git repository as a source 
> JAR, using e.g. jitpack.io's maven dependency-from-git-repo converter?
> Tentatively classifying this as a bug, since it seems inconsistent with all 
> the other releases on Central.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift issue #672: Fix package.json to include only the needed files

[jfarrell]

Github user jfarrell commented on the issue:

https://github.com/apache/thrift/pull/672
  
@zertosh if you can submit a patch to update the version of ws in use we 
can look at turning around a 0.11.0 to help out  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-4060) Thrift printTo ostream overload mechanism breaks down when types are nested

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848469#comment-15848469
 ] 

ASF GitHub Bot commented on THRIFT-4060:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1172
  
So job #2 failed strangely in c_glib which is unrelated to this change.
I pushed an empty change to kick a rebuild.  I expect it to clear...
Here's the job that failed:
https://travis-ci.org/apache/thrift/jobs/197100291


> Thrift printTo ostream overload mechanism breaks down when types are nested
> ---
>
> Key: THRIFT-4060
> URL: https://issues.apache.org/jira/browse/THRIFT-4060
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Compiler
>Affects Versions: 0.9.3, 0.10.0
> Environment: Ubuntu 14.04 LTS
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> I'm in the middle of converting a project that provides some ostream 
> operators (for logging purposes) for a number of thrift structures.  The 
> project was using 0.8.0 and in 0.9.3 some ostream operator overloads were 
> added with THRIFT-3336.  The solution that was provided here runs into 
> complications if a thrift structure is contained within another one.  Take 
> this simple example:
> h4. Thrift
> {noformat}
> namespace cpp example.detail
> struct Lower {
>1: binary lowerBinary
> }
> struct Higher {
> 1: set lowers
> }
> {noformat}
> h4. C++
> {noformat}
> namespace example {
> class Lower : public detail::Lower
> {
> virtual void printTo(std::ostream& os) const override;
> }
> class Higher : public detail::Higher
> {
> virtual void printTo(std::ostream& os) const override
> {
> os << lowers;   // WHOOPS!
> // I cannot say os << lowers, since lowers is an example::detail 
> concept
> // it will print the thrift operator output here
> }
> }
> }
> {noformat}
> I'm considering adding an anotation to the thrift IDL that the compiler will 
> recognize that allows someone to say, "I am going to provide my own 
> operator<< for this structure, don't generate one".
> This will allow existing projects with this issue to maintain compatibility 
> without major refactoring.  Here is an example:
> {noformat}
> namespace cpp example.detail
> struct Lower {
>1: binary lowerBinary
> } (cpp.customostream)
> struct Higher {
> 1: set lowers
> }
> {noformat}
> For Lower, this would omit any operator << by the compiler, and thus also 
> would not emit a printTo override for Lower.  It would be up to the 
> implementation building against the generated code to provide an operator <<.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift issue #1172: THRIFT-4060 add better support in the cpp generator for ...

[jeking3]

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1172
  
So job #2 failed strangely in c_glib which is unrelated to this change.
I pushed an empty change to kick a rebuild.  I expect it to clear...
Here's the job that failed:
https://travis-ci.org/apache/thrift/jobs/197100291


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #672: Fix package.json to include only the needed files

[zertosh]

Github user zertosh commented on the issue:

https://github.com/apache/thrift/pull/672
  
Thanks @jfarrell!

@modocache, unfortunately we still can't use this lib. The version of `ws` 
that it uses is crazy old (v0.4.32 from Aug 2014). Any version prior to 
[ws@1.0.0](https://github.com/websockets/ws/releases/tag/1.0.0) requires that 
you compile a few of its third-party deps - major blocker for using internally 
at FB (toolchain problems, node ABI issues, etc).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-1567) Thrift/cpp: Allow alternate classes to be used for

[James E. King, III (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848431#comment-15848431
 ] 

James E. King, III commented on THRIFT-1567:


I tried modifying AnnotationTest.thrift, adding a string to the foo structure; 
and even adding a "cpp.type" annotation to the string I added (the struct has a 
cpp.type annotation already, which I am not sure makes any sense).  I tried 
compiling this with ``--gen cpp:templates`` as there is a discussion about 
needing templatized read/write here.  None of the resulting files leverages the 
custom type(s) that I have tried.  There is no mention of "DenseFoo" anywhere 
in generated code.

Could someone explain how this feature is supposed to be used?

> Thrift/cpp: Allow alternate classes to be used for 
> ---
>
> Key: THRIFT-1567
> URL: https://issues.apache.org/jira/browse/THRIFT-1567
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Affects Versions: 0.9
>Reporter: Dave Watson
>Assignee: David Reiss
>Priority: Minor
> Fix For: 0.9
>
> Attachments: 
> 0009-Thrift-cpp-Allow-alternate-classes-to-be-used-for-Th.patch, 
> thrift-1567-on-trunk.txt, thrift-types-demo.patch
>
>
> From 826d3646f47cb856f22a10087350f551bfc8b834 Mon Sep 17 00:00:00 2001
> From: David Reiss 
> Date: Fri, 10 Sep 2010 04:03:48 +
> Subject: [PATCH 09/12] Thrift/cpp: Allow alternate classes to be used for
>  Thrift strings
> Summary:
> The goal of this diff is to allow Thrift strings to be used without
> depending on std::string, since it looks like we're starting to move
> away from std::string instead of moving to a better implementation.
> The challenge here is the protocol read code.  Structs normally pass
> std::string references to TProtocol::readString, which then populates
> the string with the appropriate data.  However, this can't be done with
> an arbitrary class.  TProtocol::readString cannot be a template function
> because it is virtual.  One option would be to make
> TProtocol::readString take a shim object with virtual members for
> populating the actual string.  Another would be to require services that
> use nonstandard string classes to only use template-style Thrift code.
> This diff does the latter.
> - Recognize templates=only as a generator option to skip the generic
>   process function implementations (actually just the pointers).
> - Recognize "cpp.type" as a type annotation on strings to force the C++
>   type used to represent them.
> - Make TBinaryProtocol::readString a template method.
> Test Plan:
> - Ran the server under valgrind and called both methods.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift pull request #1113: Updated Stop by comment from Patrick Benett

[jfarrell]

Github user jfarrell closed the pull request at:

https://github.com/apache/thrift/pull/1113


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #672: Fix package.json to include only the needed files

[jfarrell]

Github user jfarrell commented on the issue:

https://github.com/apache/thrift/pull/672
  
done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-3207) Enable build with OpenSSL 1.1.0 series

[James E. King, III (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848415#comment-15848415
 ] 

James E. King, III commented on THRIFT-3207:


Given THRIFT-3736 was fixed in 0.10.0, is this one mislabeled as fixed in 
0.11.0?

> Enable build with OpenSSL 1.1.0 series
> --
>
> Key: THRIFT-3207
> URL: https://issues.apache.org/jira/browse/THRIFT-3207
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Affects Versions: 0.9.2
>Reporter: Paweł Janicki
>Assignee: Jens Geyer
>Priority: Minor
>  Labels: easyfix
> Fix For: 0.11.0
>
> Attachments: THRIFT-3207.patch
>
>
> As thrift requires OpenSSL v1.1.0 there are still some problems with 
> compiling latest official releases on Visual Studio 2013. We falled back to 
> other OpenSSL releases that source version can be compiled without problems.
> Unfortunately Thrift can not be build against OpenSSL pre 1.1.0 due to 
> missing TLSv1_1_method() and TLSv1_2_method().
> While OpenSSL in version 0.9.8 and 1.0.0 is supported till 
> [2015-12-31|https://www.openssl.org/about/releasestrat.html] and Open SSL in 
> version 1.0.1 and 1.0.2 is supported till 
> [2016-12-31|https://www.openssl.org/about/releasestrat.html] we found 
> reasonable to enable this releases to be used for Thrift builds.
> The proposed patch enables Thrift support of TLS 1.1 and 1.2 only when build 
> with OpenSSL 1.1.0 or newer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (THRIFT-3190) In perl, a thrift set<> type should use a more proper native implementation

[James E. King, III (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III updated THRIFT-3190:
---
Description: 
Currently a set<> type in Thrift equates to a hash where the value of each type 
is set to 1.  The keys are interpreted as strings and therefore lose their 
ordering.  The TestClient for cpp sends:

The TestServer for perl (which I am writing to verify SSL server refactoring) 
receives:

$thing  HASH(0x35da228)={ -1 => '1', -2 => '1', 0 => '1', 1 => '1', 2 => '1' }  

Note how -1 and -2 are transposed.  Further, there are no set manipulations 
available.

Recommend the use of Set::Scalar as a required perl dependency for proper set 
operations.
The old behavior could be preserved through a compiler flag for perl ensuring 
that existing products that rely on the current implementation don't have to 
change.

  was:
Currently a set<> type in Thrift equates to a hash where the value of each type 
is set to 1.  The keys are interpreted as strings and therefore lose their 
ordering.  The TestClient for cpp sends:

The TestServer for perl (which I am writing to verify SSL server refactoring) 
receives:

$thing  HASH(0x35da228)={ -1 => '1', -2 => '1', 0 => '1', 1 => '1', 2 => '1' }  

Note how -1 and -2 are transposed.  Further, there are no set manipulations 
available.

Recommend the use of Set::Scalar as a required perl dependency for proper set 
operation.  This would be a breaking change but necessary to achieve proper set 
semantics and operations from the native thrift type.


> In perl, a thrift set<> type should use a more proper native implementation
> ---
>
> Key: THRIFT-3190
> URL: https://issues.apache.org/jira/browse/THRIFT-3190
> Project: Thrift
>  Issue Type: Improvement
>  Components: Perl - Library
>Affects Versions: 0.9.2
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Minor
>
> Currently a set<> type in Thrift equates to a hash where the value of each 
> type is set to 1.  The keys are interpreted as strings and therefore lose 
> their ordering.  The TestClient for cpp sends:
> The TestServer for perl (which I am writing to verify SSL server refactoring) 
> receives:
> $thingHASH(0x35da228)={ -1 => '1', -2 => '1', 0 => '1', 1 => '1', 2 
> => '1' }  
> Note how -1 and -2 are transposed.  Further, there are no set manipulations 
> available.
> Recommend the use of Set::Scalar as a required perl dependency for proper set 
> operations.
> The old behavior could be preserved through a compiler flag for perl ensuring 
> that existing products that rely on the current implementation don't have to 
> change.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (THRIFT-3190) In perl, a thrift set<> type should use a more proper native implementation

[James E. King, III (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III reassigned THRIFT-3190:
--

Assignee: James E. King, III

> In perl, a thrift set<> type should use a more proper native implementation
> ---
>
> Key: THRIFT-3190
> URL: https://issues.apache.org/jira/browse/THRIFT-3190
> Project: Thrift
>  Issue Type: Improvement
>  Components: Perl - Library
>Affects Versions: 0.9.2
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Minor
>
> Currently a set<> type in Thrift equates to a hash where the value of each 
> type is set to 1.  The keys are interpreted as strings and therefore lose 
> their ordering.  The TestClient for cpp sends:
> The TestServer for perl (which I am writing to verify SSL server refactoring) 
> receives:
> $thingHASH(0x35da228)={ -1 => '1', -2 => '1', 0 => '1', 1 => '1', 2 
> => '1' }  
> Note how -1 and -2 are transposed.  Further, there are no set manipulations 
> available.
> Recommend the use of Set::Scalar as a required perl dependency for proper set 
> operation.  This would be a breaking change but necessary to achieve proper 
> set semantics and operations from the native thrift type.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (THRIFT-4063) Sources for libthrift 0.10.0 are missing from Maven Central

[James E. King, III (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III reassigned THRIFT-4063:
--

Assignee: Jake Farrell

> Sources for libthrift 0.10.0 are missing from Maven Central
> ---
>
> Key: THRIFT-4063
> URL: https://issues.apache.org/jira/browse/THRIFT-4063
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.10.0
>Reporter: Zac Bentley
>Assignee: Jake Farrell
>Priority: Minor
>
> The other versions of libthrift have source JARs on Maven Central; 0.10.0 
> does not.
> Could sources be published?
> Alternatively, is there some way to wire up the Git repository as a source 
> JAR, using e.g. jitpack.io's maven dependency-from-git-repo converter?
> Tentatively classifying this as a bug, since it seems inconsistent with all 
> the other releases on Central.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4043) thrift perl debian package is placing files in the wrong place

[James E. King, III (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848343#comment-15848343
 ] 

James E. King, III commented on THRIFT-4043:


Without the mkdir, perl5 was being moved to /usr/lib directly, rather than 
being moved INTO /usr/lib. This caused perl to go into /usr/lib/Thrift.pm and 
/usr/lib/Thrift/... instead.  Submitted a PR.

> thrift perl debian package is placing files in the wrong place
> --
>
> Key: THRIFT-4043
> URL: https://issues.apache.org/jira/browse/THRIFT-4043
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process, Perl - Library
>Affects Versions: 0.10.0
> Environment: Ubuntu docker build environment, installing on Ubuntu 
> 14.04 LTS
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> The libthrift-perl-0.10.0 package is installing things into /usr/lib, when it 
> should be going into /usr/share/perl5.
> This means "Thrift.pm" is being dropped directly into /usr/lib/Thrift.pm 
> right now.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4043) thrift perl debian package is placing files in the wrong place

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848341#comment-15848341
 ] 

ASF GitHub Bot commented on THRIFT-4043:


GitHub user jeking3 opened a pull request:

https://github.com/apache/thrift/pull/1174

THRIFT-4043 ensure perl files do not end up in /usr/lib/Thrift

Without the mkdir, perl5 was being moved to /usr/lib directly, rather than 
being moved INTO /usr/lib.  This caused perl to go into /usr/lib/Thrift.pm and 
/usr/lib/Thrift/... instead.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jeking3/thrift THRIFT-4043

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1174


commit 881cb70e0011a82b7a950238b5ab5a5327d303a3
Author: James E. King, III 
Date:   2017-02-01T12:52:21Z

THRIFT-4043 ensure perl files do not end up in /usr/lib/Thrift




> thrift perl debian package is placing files in the wrong place
> --
>
> Key: THRIFT-4043
> URL: https://issues.apache.org/jira/browse/THRIFT-4043
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process, Perl - Library
>Affects Versions: 0.10.0
> Environment: Ubuntu docker build environment, installing on Ubuntu 
> 14.04 LTS
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> The libthrift-perl-0.10.0 package is installing things into /usr/lib, when it 
> should be going into /usr/share/perl5.
> This means "Thrift.pm" is being dropped directly into /usr/lib/Thrift.pm 
> right now.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift pull request #1174: THRIFT-4043 ensure perl files do not end up in /u...

[jeking3]

GitHub user jeking3 opened a pull request:

https://github.com/apache/thrift/pull/1174

THRIFT-4043 ensure perl files do not end up in /usr/lib/Thrift

Without the mkdir, perl5 was being moved to /usr/lib directly, rather than 
being moved INTO /usr/lib.  This caused perl to go into /usr/lib/Thrift.pm and 
/usr/lib/Thrift/... instead.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jeking3/thrift THRIFT-4043

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1174


commit 881cb70e0011a82b7a950238b5ab5a5327d303a3
Author: James E. King, III 
Date:   2017-02-01T12:52:21Z

THRIFT-4043 ensure perl files do not end up in /usr/lib/Thrift




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (THRIFT-4043) thrift perl debian package is placing files in the wrong place

[James E. King, III (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III reassigned THRIFT-4043:
--

Assignee: James E. King, III

> thrift perl debian package is placing files in the wrong place
> --
>
> Key: THRIFT-4043
> URL: https://issues.apache.org/jira/browse/THRIFT-4043
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process, Perl - Library
>Affects Versions: 0.10.0
> Environment: Ubuntu docker build environment, installing on Ubuntu 
> 14.04 LTS
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> The libthrift-perl-0.10.0 package is installing things into /usr/lib, when it 
> should be going into /usr/share/perl5.
> This means "Thrift.pm" is being dropped directly into /usr/lib/Thrift.pm 
> right now.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (THRIFT-4007) Micro-optimization of TTransport.py

[James E. King, III (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III reassigned THRIFT-4007:
--

Assignee: James E. King, III

> Micro-optimization of TTransport.py
> ---
>
> Key: THRIFT-4007
> URL: https://issues.apache.org/jira/browse/THRIFT-4007
> Project: Thrift
>  Issue Type: Improvement
>  Components: Python - Library
>Reporter: Nathan Jensen
>Assignee: James E. King, III
>Priority: Trivial
>  Labels: easyfix, performance
> Fix For: 0.11.0
>
>
> Method readAll(self, sz) in class TTransportBase in TTransport.py can be 
> optimized to only call len(chunk) once.  It currently calls len(chunk) twice, 
> i.e.
> {code}
> def readAll(self, sz):
> buff = b''
> have = 0
> while (have < sz):
> chunk = self.read(sz - have) 
> have += len(chunk)
> buff += chunk
> if len(chunk) == 0:
> raise EOFError()
> return buff
> {code}
> That results in two method invocations to len(chunk) but it can be reduced to 
> one method invocation to len(chunk).  Depending on the amount of data being 
> read, the extra len(chunk) method invocations can add up to slightly slower 
> performance.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4007) Micro-optimization of TTransport.py

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848301#comment-15848301
 ] 

ASF GitHub Bot commented on THRIFT-4007:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1121


> Micro-optimization of TTransport.py
> ---
>
> Key: THRIFT-4007
> URL: https://issues.apache.org/jira/browse/THRIFT-4007
> Project: Thrift
>  Issue Type: Improvement
>  Components: Python - Library
>Reporter: Nathan Jensen
>Assignee: James E. King, III
>Priority: Trivial
>  Labels: easyfix, performance
> Fix For: 0.11.0
>
>
> Method readAll(self, sz) in class TTransportBase in TTransport.py can be 
> optimized to only call len(chunk) once.  It currently calls len(chunk) twice, 
> i.e.
> {code}
> def readAll(self, sz):
> buff = b''
> have = 0
> while (have < sz):
> chunk = self.read(sz - have) 
> have += len(chunk)
> buff += chunk
> if len(chunk) == 0:
> raise EOFError()
> return buff
> {code}
> That results in two method invocations to len(chunk) but it can be reduced to 
> one method invocation to len(chunk).  Depending on the amount of data being 
> read, the extra len(chunk) method invocations can add up to slightly slower 
> performance.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (THRIFT-4007) Micro-optimization of TTransport.py

[James E. King, III (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III resolved THRIFT-4007.

   Resolution: Fixed
Fix Version/s: 0.11.0

Committed - thanks!

> Micro-optimization of TTransport.py
> ---
>
> Key: THRIFT-4007
> URL: https://issues.apache.org/jira/browse/THRIFT-4007
> Project: Thrift
>  Issue Type: Improvement
>  Components: Python - Library
>Reporter: Nathan Jensen
>Assignee: James E. King, III
>Priority: Trivial
>  Labels: easyfix, performance
> Fix For: 0.11.0
>
>
> Method readAll(self, sz) in class TTransportBase in TTransport.py can be 
> optimized to only call len(chunk) once.  It currently calls len(chunk) twice, 
> i.e.
> {code}
> def readAll(self, sz):
> buff = b''
> have = 0
> while (have < sz):
> chunk = self.read(sz - have) 
> have += len(chunk)
> buff += chunk
> if len(chunk) == 0:
> raise EOFError()
> return buff
> {code}
> That results in two method invocations to len(chunk) but it can be reduced to 
> one method invocation to len(chunk).  Depending on the amount of data being 
> read, the extra len(chunk) method invocations can add up to slightly slower 
> performance.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift pull request #1121: THRIFT-4007: TTransport.py micro-optimization: do...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1121


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---