[jira] [Created] (THRIFT-4110) The debian build files do not produce a "-dbg" package for debug symbols
James E. King, III created THRIFT-4110: -- Summary: The debian build files do not produce a "-dbg" package for debug symbols Key: THRIFT-4110 URL: https://issues.apache.org/jira/browse/THRIFT-4110 Project: Thrift Issue Type: Improvement Components: C++ - Library Affects Versions: 0.10.0 Environment: Ubuntu Docker Reporter: James E. King, III Assignee: James E. King, III There is no libthrift0-dbg package being created at debian build time. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #1209: THRIFT-4110: add libthrift0-dbg debug symbols pac...
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1209 THRIFT-4110: add libthrift0-dbg debug symbols package to debian build process for symbolic debugging You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift THRIFT-4110 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1209.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1209 commit 6a716f3bc018137463b4913d36f7014765444b93 Author: James E. King, III Date: 2017-03-08T14:22:40Z THRIFT-4110: add libthrift0-dbg debug symbols package to debian build process for symbolic debugging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4110) The debian build files do not produce a "-dbg" package for debug symbols
[ https://issues.apache.org/jira/browse/THRIFT-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901327#comment-15901327 ] ASF GitHub Bot commented on THRIFT-4110: GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1209 THRIFT-4110: add libthrift0-dbg debug symbols package to debian build process for symbolic debugging You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift THRIFT-4110 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1209.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1209 commit 6a716f3bc018137463b4913d36f7014765444b93 Author: James E. King, III Date: 2017-03-08T14:22:40Z THRIFT-4110: add libthrift0-dbg debug symbols package to debian build process for symbolic debugging > The debian build files do not produce a "-dbg" package for debug symbols > > > Key: THRIFT-4110 > URL: https://issues.apache.org/jira/browse/THRIFT-4110 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library >Affects Versions: 0.10.0 > Environment: Ubuntu Docker >Reporter: James E. King, III >Assignee: James E. King, III > > There is no libthrift0-dbg package being created at debian build time. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4104) Add a CI build job that runs without libevent, openssl, or zlib
[ https://issues.apache.org/jira/browse/THRIFT-4104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4104: --- Priority: Critical (was: Minor) > Add a CI build job that runs without libevent, openssl, or zlib > --- > > Key: THRIFT-4104 > URL: https://issues.apache.org/jira/browse/THRIFT-4104 > Project: Thrift > Issue Type: Improvement > Components: Build Process, C++ - Library >Affects Versions: 0.10.0 >Reporter: James E. King, III >Priority: Critical > > After THRIFT-3369 was committed (passed CI tests) it was found to rely on > openssl being around. Since we support builds without libevent, openssl, and > zlib then we should have a CI build job that builds without them and make > sure build and test still work. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (THRIFT-4104) Add a CI build job that runs without libevent, openssl, or zlib
[ https://issues.apache.org/jira/browse/THRIFT-4104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4104: -- Assignee: James E. King, III > Add a CI build job that runs without libevent, openssl, or zlib > --- > > Key: THRIFT-4104 > URL: https://issues.apache.org/jira/browse/THRIFT-4104 > Project: Thrift > Issue Type: Improvement > Components: Build Process, C++ - Library >Affects Versions: 0.10.0 >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Critical > > After THRIFT-3369 was committed (passed CI tests) it was found to rely on > openssl being around. Since we support builds without libevent, openssl, and > zlib then we should have a CI build job that builds without them and make > sure build and test still work. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4029) Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
[
https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901840#comment-15901840
]
Chandler May commented on THRIFT-4029:
--
Dunno if I consider myself a SME but I believe the build works. I am attaching
a bash script that fails before the patch and works after it, demonstrating the
patch's resolution of the packaging issue. It would be fantastic if this could
be added as an integration test (in a greatly cleaned-up form), but I haven't
looked at the Python test framework in a while so I'm not sure what the best
way is to do that.
> Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
>
>
> Key: THRIFT-4029
> URL: https://issues.apache.org/jira/browse/THRIFT-4029
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.10.0
>Reporter: Chandler May
>Assignee: Jake Farrell
>
> The thrift 0.10.0 distribution on PyPI does not include extension headers and
> a C++ (template) file, preventing the accelerated protocols from being built.
> {{pip install}} reports a brief error:
> {code}
> Running thrift-0.10.0/setup.py -q bdist_egg --dist-dir
> /tmp/easy_install-bVU8VN/thrift-0.10.0/egg-dist-tmp-ghJzGL
> cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for
> C/ObjC but not for C++
> src/ext/module.cpp:21:19: fatal error: types.h: No such file or directory
> #include "types.h"
>^
> compilation terminated.
> ()
>
> An error occurred while trying to compile with the C extension enabled
> Attempting to build without the extension now
>
> ()
> {code}
> The list of files that is not included in the distribution is as follows. In
> addition to the headers and source file mentioned above, there's a Windows
> compatibility header missing and a couple of test files missing. It looks
> like there was a file extension filter (accidentally) applied to the C++
> files at least:
> {code}
> src/ext/binary.h
> src/ext/compact.h
> src/ext/endian.h
> src/ext/protocol.h
> src/ext/protocol.tcc
> src/ext/types.h
> compat/win32/stdint.h
> test/_import_local_thrift.py
> test/thrift_json.py
> {code}
> [~jfarrell] were you who made the release? Is it possible to hotfix? My
> team has been waiting on the release of the accelerated compact protocol for
> a while, this discovery is saddening for us.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (THRIFT-4029) Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
[
https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chandler May updated THRIFT-4029:
-
Attachment: test-thrift.bash
Test of accelerated protocol packaging issue. When run from the top of the
thrift repository, this script fails before the patch is applied and succeeds
after the patch is applied.
> Accelerated protocols do not build from thrift-py 0.10.0 on PyPI
>
>
> Key: THRIFT-4029
> URL: https://issues.apache.org/jira/browse/THRIFT-4029
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.10.0
>Reporter: Chandler May
>Assignee: Jake Farrell
> Attachments: test-thrift.bash
>
>
> The thrift 0.10.0 distribution on PyPI does not include extension headers and
> a C++ (template) file, preventing the accelerated protocols from being built.
> {{pip install}} reports a brief error:
> {code}
> Running thrift-0.10.0/setup.py -q bdist_egg --dist-dir
> /tmp/easy_install-bVU8VN/thrift-0.10.0/egg-dist-tmp-ghJzGL
> cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for
> C/ObjC but not for C++
> src/ext/module.cpp:21:19: fatal error: types.h: No such file or directory
> #include "types.h"
>^
> compilation terminated.
> ()
>
> An error occurred while trying to compile with the C extension enabled
> Attempting to build without the extension now
>
> ()
> {code}
> The list of files that is not included in the distribution is as follows. In
> addition to the headers and source file mentioned above, there's a Windows
> compatibility header missing and a couple of test files missing. It looks
> like there was a file extension filter (accidentally) applied to the C++
> files at least:
> {code}
> src/ext/binary.h
> src/ext/compact.h
> src/ext/endian.h
> src/ext/protocol.h
> src/ext/protocol.tcc
> src/ext/types.h
> compat/win32/stdint.h
> test/_import_local_thrift.py
> test/thrift_json.py
> {code}
> [~jfarrell] were you who made the release? Is it possible to hotfix? My
> team has been waiting on the release of the accelerated compact protocol for
> a while, this discovery is saddening for us.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift issue #1205: THRIFT-4081: appveyor retooling - build both MSVC2015 an...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1205 I removed the artifact capture on every build - it might cost money to do this over time (unsure) and the benefit is negligible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4081) Provide a MinGW 64-bit Appveyor CI build for better pull request validation
[ https://issues.apache.org/jira/browse/THRIFT-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902037#comment-15902037 ] ASF GitHub Bot commented on THRIFT-4081: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1205 I removed the artifact capture on every build - it might cost money to do this over time (unsure) and the benefit is negligible. > Provide a MinGW 64-bit Appveyor CI build for better pull request validation > --- > > Key: THRIFT-4081 > URL: https://issues.apache.org/jira/browse/THRIFT-4081 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.10.0 > Environment: Appveyor >Reporter: James E. King, III >Assignee: James E. King, III > > We currently build in Visual Studio 2015 on Appveyor. We do not use the > Windows CI environment to verify that MinGW still builds successfully (there > is a 32-bit job on linux, #16, which runs on every pull request). I would > recommend that we add a CI build job to Appveyor and/or extend the existing > job to build with the latest MinGW 64-bit environment which includes > gcc-6.3.0; we could perhaps remove Travis job #16 which is using 32-bit mingw > on linux as a result? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
