[jira] [Resolved] (THRIFT-4198) Ruby should log Thrift internal errors to global logger

[Jens Geyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer resolved THRIFT-4198.

   Resolution: Fixed
Fix Version/s: 0.11.0

Committed.

> Ruby should log Thrift internal errors to global logger
> ---
>
> Key: THRIFT-4198
> URL: https://issues.apache.org/jira/browse/THRIFT-4198
> Project: Thrift
>  Issue Type: Improvement
>  Components: Ruby - Library
>Reporter: Jens Geyer
>Assignee: James E. King, III
>Priority: Minor
> Fix For: 0.11.0
>
>
>  Logging server-side exception message on 
> ApplicationException::INTERNAL_ERROR as discussed in 
> https://github.com/apache/thrift/pull/1267



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift pull request #1252: [Ruby] Logging server-side exception message on A...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1252


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-4198) Ruby should log Thrift internal errors to global logger

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008807#comment-16008807
 ] 

ASF GitHub Bot commented on THRIFT-4198:


Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1252
  
Tracked in THRIFT-4198. See [our contrib 
guide](http://thrift.apache.org/docs/HowToContribute) for details.


> Ruby should log Thrift internal errors to global logger
> ---
>
> Key: THRIFT-4198
> URL: https://issues.apache.org/jira/browse/THRIFT-4198
> Project: Thrift
>  Issue Type: Improvement
>  Components: Ruby - Library
>Reporter: Jens Geyer
>Assignee: James E. King, III
>Priority: Minor
>
>  Logging server-side exception message on 
> ApplicationException::INTERNAL_ERROR as discussed in 
> https://github.com/apache/thrift/pull/1267



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift issue #1252: [Ruby] Logging server-side exception message on Applicat...

[Jens-G]

Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1252
  
Tracked in THRIFT-4198. See [our contrib 
guide](http://thrift.apache.org/docs/HowToContribute) for details.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (THRIFT-4198) Ruby should log Thrift internal errors to global logger

[Jens Geyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer updated THRIFT-4198:
---
Component/s: (was: C++ - Compiler)
 (was: C++ - Library)
 Ruby - Library

> Ruby should log Thrift internal errors to global logger
> ---
>
> Key: THRIFT-4198
> URL: https://issues.apache.org/jira/browse/THRIFT-4198
> Project: Thrift
>  Issue Type: Improvement
>  Components: Ruby - Library
>Reporter: Jens Geyer
>Assignee: James E. King, III
>Priority: Minor
>
> Thrift exceptions are somewhat difficult to trace from debug logs. I'd like 
> to add __FILE__AND__LINE__ as a second parameter to some exceptions to make 
> them easier to find.
> For example:
> Every time a required field is not set, the exception that gets generated is 
> a very generic
> throw TProtocolException(TProtocolException::INVALID_DATA)
> see - 
> https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=compiler/cpp/src/generate/t_cpp_generator.cc;h=298096d3265baa1f008501eb7c26bb4ae96ffa4b;hb=HEAD#l1372
> I think I'll start with patching up TProtocolExcpetion in the compiler and if 
> people like this I can make a separate issue and patch for other exceptions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (THRIFT-4198) Ruby should log Thrift internal errors to global logger

[Jens Geyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer updated THRIFT-4198:
---
Labels:   (was: newbie)

> Ruby should log Thrift internal errors to global logger
> ---
>
> Key: THRIFT-4198
> URL: https://issues.apache.org/jira/browse/THRIFT-4198
> Project: Thrift
>  Issue Type: Improvement
>  Components: Ruby - Library
>Reporter: Jens Geyer
>Assignee: James E. King, III
>Priority: Minor
>
> Thrift exceptions are somewhat difficult to trace from debug logs. I'd like 
> to add __FILE__AND__LINE__ as a second parameter to some exceptions to make 
> them easier to find.
> For example:
> Every time a required field is not set, the exception that gets generated is 
> a very generic
> throw TProtocolException(TProtocolException::INVALID_DATA)
> see - 
> https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=compiler/cpp/src/generate/t_cpp_generator.cc;h=298096d3265baa1f008501eb7c26bb4ae96ffa4b;hb=HEAD#l1372
> I think I'll start with patching up TProtocolExcpetion in the compiler and if 
> people like this I can make a separate issue and patch for other exceptions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (THRIFT-4198) Ruby should log Thrift internal errors to global logger

[Jens Geyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer updated THRIFT-4198:
---
Fix Version/s: (was: 0.10.0)

> Ruby should log Thrift internal errors to global logger
> ---
>
> Key: THRIFT-4198
> URL: https://issues.apache.org/jira/browse/THRIFT-4198
> Project: Thrift
>  Issue Type: Improvement
>  Components: Ruby - Library
>Reporter: Jens Geyer
>Assignee: James E. King, III
>Priority: Minor
>
> Thrift exceptions are somewhat difficult to trace from debug logs. I'd like 
> to add __FILE__AND__LINE__ as a second parameter to some exceptions to make 
> them easier to find.
> For example:
> Every time a required field is not set, the exception that gets generated is 
> a very generic
> throw TProtocolException(TProtocolException::INVALID_DATA)
> see - 
> https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=compiler/cpp/src/generate/t_cpp_generator.cc;h=298096d3265baa1f008501eb7c26bb4ae96ffa4b;hb=HEAD#l1372
> I think I'll start with patching up TProtocolExcpetion in the compiler and if 
> people like this I can make a separate issue and patch for other exceptions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (THRIFT-4198) Ruby should log Thrift internal errors to global logger

[Jens Geyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer updated THRIFT-4198:
---
Description: 
 Logging server-side exception message on ApplicationException::INTERNAL_ERROR 
as discussed in https://github.com/apache/thrift/pull/1267


  was:
Thrift exceptions are somewhat difficult to trace from debug logs. I'd like to 
add __FILE__AND__LINE__ as a second parameter to some exceptions to make them 
easier to find.

For example:

Every time a required field is not set, the exception that gets generated is a 
very generic
throw TProtocolException(TProtocolException::INVALID_DATA)

see - 
https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=compiler/cpp/src/generate/t_cpp_generator.cc;h=298096d3265baa1f008501eb7c26bb4ae96ffa4b;hb=HEAD#l1372


I think I'll start with patching up TProtocolExcpetion in the compiler and if 
people like this I can make a separate issue and patch for other exceptions


> Ruby should log Thrift internal errors to global logger
> ---
>
> Key: THRIFT-4198
> URL: https://issues.apache.org/jira/browse/THRIFT-4198
> Project: Thrift
>  Issue Type: Improvement
>  Components: Ruby - Library
>Reporter: Jens Geyer
>Assignee: James E. King, III
>Priority: Minor
>
>  Logging server-side exception message on 
> ApplicationException::INTERNAL_ERROR as discussed in 
> https://github.com/apache/thrift/pull/1267



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (THRIFT-4198) Ruby should log Thrift internal errors to global logger

[Jens Geyer (JIRA)]

Jens Geyer created THRIFT-4198:
--

 Summary: Ruby should log Thrift internal errors to global logger
 Key: THRIFT-4198
 URL: https://issues.apache.org/jira/browse/THRIFT-4198
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Compiler, C++ - Library
Reporter: Jens Geyer
Assignee: James E. King, III
Priority: Minor
 Fix For: 0.10.0


Thrift exceptions are somewhat difficult to trace from debug logs. I'd like to 
add __FILE__AND__LINE__ as a second parameter to some exceptions to make them 
easier to find.

For example:

Every time a required field is not set, the exception that gets generated is a 
very generic
throw TProtocolException(TProtocolException::INVALID_DATA)

see - 
https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=compiler/cpp/src/generate/t_cpp_generator.cc;h=298096d3265baa1f008501eb7c26bb4ae96ffa4b;hb=HEAD#l1372


I think I'll start with patching up TProtocolExcpetion in the compiler and if 
people like this I can make a separate issue and patch for other exceptions



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (THRIFT-4196) Cannot generate recursive Rust types

[Jens Geyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Geyer resolved THRIFT-4196.

   Resolution: Fixed
Fix Version/s: 0.11.0

LGTM, committed.

> Cannot generate recursive Rust types
> 
>
> Key: THRIFT-4196
> URL: https://issues.apache.org/jira/browse/THRIFT-4196
> Project: Thrift
>  Issue Type: Bug
>  Components: Rust - Compiler
>Reporter: Allen George
>Assignee: Allen George
> Fix For: 0.11.0
>
>
> Pretty simple: I attempted to generate code for a recursive type described in 
> test/recursive.thrift and the rust code generator promptly failed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4196) Cannot generate recursive Rust types

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008788#comment-16008788
 ] 

ASF GitHub Bot commented on THRIFT-4196:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1267


> Cannot generate recursive Rust types
> 
>
> Key: THRIFT-4196
> URL: https://issues.apache.org/jira/browse/THRIFT-4196
> Project: Thrift
>  Issue Type: Bug
>  Components: Rust - Compiler
>Reporter: Allen George
>Assignee: Allen George
>
> Pretty simple: I attempted to generate code for a recursive type described in 
> test/recursive.thrift and the rust code generator promptly failed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4190) improve C# TThreadPoolServer defaults

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008724#comment-16008724
 ] 

ASF GitHub Bot commented on THRIFT-4190:


GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1268

THRIFT-4190 Improve C# TThreadPoolServer defaults (part 2 of 2)

Client: C#
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4190

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1268.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1268


commit 6f1a3c23744d573488dc64c196ba4e8932c33d3b
Author: Jens Geyer 
Date:   2017-05-12T20:49:57Z

THRIFT-4190 Improve C# TThreadPoolServer defaults (part 2 of 2)
Client: C#
Patch: Jens Geyer




> improve C# TThreadPoolServer defaults
> -
>
> Key: THRIFT-4190
> URL: https://issues.apache.org/jira/browse/THRIFT-4190
> Project: Thrift
>  Issue Type: Improvement
>  Components: C# - Library
>Reporter: Jens Geyer
>Assignee: Jens Geyer
>
> The TThreadPoolServer uses hardcoded values to specify min/max number of 
> threads, if the caller does not specify them. This is rather unexpected in my 
> opinion, since the global C# ThreadPool (which is used internally) comes with 
> its own defaults for all 4 values - yes, 4, not 2: there are different 
> settings for the number of threads on one hand and the number of asyn IO 
> completion ports on the other, and they are not necessary identical numbers. 
> For example, on my machine I get these numbers by default:
> - min 4 threads and 4 I/O completion ports
> - max 37267 threads and 1000 I/O completion ports
> There are several *problems* with this approach:
> # There is really no way to bypass the defaults of min 10/10 and max 100/100 
> that are hard-coded into TThreadPoolServer and use the defaults provided by 
> the NET framework instead, since we can only pass number which is then used 
> for threads AND io ports. In my example, no matter what value I pass, 37267 
> or 1000, it will be something other than the defaults.
> # It is rather unexpected to have Thrift override the default settings of the 
> global thread pool object if I don't even provide values by calling one of 
> the simpler TThreadPoolServer  CTORs.
> # I'm not sure where the defaults are come from. Both numbers look like wild 
> guesswork to me. The defaults provided by the runtime make much more sense, 
> as they automatically adapt to the machine's capabilities.
> My *proposal* to solve it comes in two parts:
> # Change  the CTOR in a way that interprets 0 or negative values as intention 
> to stick with the NET default settings. I think that is the best way to 
> handle it, as the current implementation would just throw in a very defined 
> way, so we don't get any compatibility conflicts here that pass undetectedly.
> # Additionally make the default values {{DEFAULT_MAX_THREADS}} and 
> {{DEFAULT_MIN_THREADS}} both 0 (or negative) to enforce the system's 
> defaults. Since this will be a breaking change, as it changes the current 
> default behaviour, I'd like to know the opinions of the community before I 
> commit that part of the changes.
> Further reference
> - [SetMinThreads 
> method|https://msdn.microsoft.com/en-us/library/system.threading.threadpool.setminthreads(v=vs.110).aspx]
> - [SetMaxThreads 
> method|https://msdn.microsoft.com/en-us/library/system.threading.threadpool.setmaxthreads(v=vs.110).aspx]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift pull request #1268: THRIFT-4190 Improve C# TThreadPoolServer defaults...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1268

THRIFT-4190 Improve C# TThreadPoolServer defaults (part 2 of 2)

Client: C#
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4190

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1268.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1268


commit 6f1a3c23744d573488dc64c196ba4e8932c33d3b
Author: Jens Geyer 
Date:   2017-05-12T20:49:57Z

THRIFT-4190 Improve C# TThreadPoolServer defaults (part 2 of 2)
Client: C#
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-4195) Compilation to GO produces broken code

[Allen George (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008613#comment-16008613
 ] 

Allen George commented on THRIFT-4195:
--

AFAICT, this no longer exists in master. The code is generated correctly with 
the type being wrapped (i.e. converted) to its alias.

> Compilation to GO produces broken code
> --
>
> Key: THRIFT-4195
> URL: https://issues.apache.org/jira/browse/THRIFT-4195
> Project: Thrift
>  Issue Type: Bug
>  Components: Go - Compiler
>Affects Versions: 0.10.0
> Environment: MacOS 10.12.4 (16E195)
> go version go1.8.1 darwin/amd64
>Reporter: Stanislav Baranov
>Priority: Critical
> Attachments: GoUnusedProtection__.go, sample-consts.go, sample.go, 
> sample.thrift
>
>
> Sample source file (see attached sample.thrift):
> {code}
> namespace go reports
> typedef string ReportState
> const ReportState ReportStateQueued = "QUEUED";
> const ReportState ReportStateCalculating = "CALCULATING";
> const ReportState ReportStateImporting = "IMPORTING";
> const ReportState ReportStateFinished = "FINISHED";
> const ReportState ReportStateFailed = "FAILED";
> struct ReportFilter {
> 1: i64 quantity,
> 2: i64 dataVersion,
> 3: string subscriptionID,
> 4: optional string principalID,
> 5: optional string createdOn,
> 6: optional list states,
> }
> {code}
> after compilation as:
> {{thrift -r -v -o ./ -out ./go --gen go:package_prefix="git.4tree.de/" 
> ./sample.thrift}}
> Produces code (see attached sample.go) which contains:
> {code}
> func (p *ReportFilter)  ReadField6(iprot thrift.TProtocol) error {
>   _, size, err := iprot.ReadListBegin()
>   if err != nil {
> return thrift.PrependError("error reading list begin: ", err)
>   }
>   tSlice := make([]ReportState, 0, size)
>   p.States =  tSlice
>   for i := 0; i < size; i ++ {
> var _elem0 string
> if v, err := iprot.ReadString(); err != nil {
> return thrift.PrependError("error reading field 0: ", err)
> } else {
> _elem0 = v
> }
> p.States = append(p.States, _elem0)
>   }
>   if err := iprot.ReadListEnd(); err != nil {
> return thrift.PrependError("error reading list end: ", err)
>   }
>   return nil
> }
> {code}
> When trying to compile this code, GO triggers an error:
> {code}
> cannot use _elem0 (type string) as type ReportState in append
> {code}
> at line:
> {code}
>  p.States = append(p.States, _elem0)
> {code}
> This code compiles normal using  thrift 0.9.3



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4197) Implement transparent gzip compression for HTTP transport

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008586#comment-16008586
 ] 

ASF GitHub Bot commented on THRIFT-4197:


Github user dcelasun commented on the issue:

https://github.com/apache/thrift/pull/1266
  
>  I have a life besides Thrift, you know ;-)

As do we all :)

> Don't panic

No panic here, or in the code! :)


> Implement transparent gzip compression for HTTP transport
> -
>
> Key: THRIFT-4197
> URL: https://issues.apache.org/jira/browse/THRIFT-4197
> Project: Thrift
>  Issue Type: Improvement
>  Components: Go - Library
>Affects Versions: 0.10.0
>Reporter: Can Celasun
>Assignee: Can Celasun
>Priority: Minor
>
> HTTP transport should check if the client supports gzip compressed responses 
> and do transparent compression if it does.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift issue #1266: THRIFT-4197 [Go] Transparent gzip support for HTTP trans...

[dcelasun]

Github user dcelasun commented on the issue:

https://github.com/apache/thrift/pull/1266
  
>  I have a life besides Thrift, you know ;-)

As do we all :)

> Don't panic

No panic here, or in the code! :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-4197) Implement transparent gzip compression for HTTP transport

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008577#comment-16008577
 ] 

ASF GitHub Bot commented on THRIFT-4197:


Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1266
  
Don't panic, I already planned to look into this. I have a life 
besidesThrift, you know ;-)


> Implement transparent gzip compression for HTTP transport
> -
>
> Key: THRIFT-4197
> URL: https://issues.apache.org/jira/browse/THRIFT-4197
> Project: Thrift
>  Issue Type: Improvement
>  Components: Go - Library
>Affects Versions: 0.10.0
>Reporter: Can Celasun
>Assignee: Can Celasun
>Priority: Minor
>
> HTTP transport should check if the client supports gzip compressed responses 
> and do transparent compression if it does.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift issue #1266: THRIFT-4197 [Go] Transparent gzip support for HTTP trans...

[Jens-G]

Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1266
  
Don't panic, I already planned to look into this. I have a life 
besidesThrift, you know ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-4196) Cannot generate recursive Rust types

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008525#comment-16008525
 ] 

ASF GitHub Bot commented on THRIFT-4196:


Github user allengeorge commented on the issue:

https://github.com/apache/thrift/pull/1267
  
@Jens-G Any chance this could go in? Thank you?


> Cannot generate recursive Rust types
> 
>
> Key: THRIFT-4196
> URL: https://issues.apache.org/jira/browse/THRIFT-4196
> Project: Thrift
>  Issue Type: Bug
>  Components: Rust - Compiler
>Reporter: Allen George
>Assignee: Allen George
>
> Pretty simple: I attempted to generate code for a recursive type described in 
> test/recursive.thrift and the rust code generator promptly failed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift issue #1267: THRIFT-4196 Support recursive types in Rust

[allengeorge]

Github user allengeorge commented on the issue:

https://github.com/apache/thrift/pull/1267
  
@Jens-G Any chance this could go in? Thank you?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-2642) Recursive structs don't work in python

[Igor Rogozhin (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008348#comment-16008348
 ] 

Igor Rogozhin commented on THRIFT-2642:
---

Actualy my team switched to java, but if you need help you can contact with me.
Dont think, that i totaly forget python for 6mo

> Recursive structs don't work in python
> --
>
> Key: THRIFT-2642
> URL: https://issues.apache.org/jira/browse/THRIFT-2642
> Project: Thrift
>  Issue Type: Bug
>  Components: Python - Compiler, Python - Library
>Affects Versions: 0.9.2
>Reporter: Igor Kostenko
>
> Recursive structs in 0.9.2 work fine in c++ & c#, but not in python, because 
> generated code trying to use objects which not constructed yet.
> Struct:
> {code}
> struct Recursive {
> 1: list Children
> }
> {code}
> Python code:
> {code}
> class Recursive:
>   thrift_spec = (
> None, # 0
> (1, TType.LIST, 'Children', (TType.STRUCT,(Recursive, 
> Recursive.thrift_spec)), None, ), # 1
>   )
> {code}
> Error message:
> {code}
> Traceback (most recent call last):
>   File "ttypes.py", line 20, in 
> class Recursive:
>   File "ttypes.py", line 28, in Recursive
> (1, TType.LIST, 'Children', (TType.STRUCT,(Recursive, 
> Recursive.thrift_spec)), None, ), # 1
> NameError: name 'Recursive' is not defined
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (THRIFT-2642) Recursive structs don't work in python

[julien greard (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

julien greard updated THRIFT-2642:
--

Hello,

I agree with Jens and I'm available for giving my opinion even if I don't
know much about thrift architecture.

Wish you luck !

Julien




> Recursive structs don't work in python
> --
>
> Key: THRIFT-2642
> URL: https://issues.apache.org/jira/browse/THRIFT-2642
> Project: Thrift
>  Issue Type: Bug
>  Components: Python - Compiler, Python - Library
>Affects Versions: 0.9.2
>Reporter: Igor Kostenko
>
> Recursive structs in 0.9.2 work fine in c++ & c#, but not in python, because 
> generated code trying to use objects which not constructed yet.
> Struct:
> {code}
> struct Recursive {
> 1: list Children
> }
> {code}
> Python code:
> {code}
> class Recursive:
>   thrift_spec = (
> None, # 0
> (1, TType.LIST, 'Children', (TType.STRUCT,(Recursive, 
> Recursive.thrift_spec)), None, ), # 1
>   )
> {code}
> Error message:
> {code}
> Traceback (most recent call last):
>   File "ttypes.py", line 20, in 
> class Recursive:
>   File "ttypes.py", line 28, in Recursive
> (1, TType.LIST, 'Children', (TType.STRUCT,(Recursive, 
> Recursive.thrift_spec)), None, ), # 1
> NameError: name 'Recursive' is not defined
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (THRIFT-2642) Recursive structs don't work in python

[Jens Geyer (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008223#comment-16008223
 ] 

Jens Geyer edited comment on THRIFT-2642 at 5/12/17 2:40 PM:
-

[~allengeorge], 

I am fine with it as long as 
- the proposed changes are local to Python stuff (.i.e. there are no changes 
necessary that affect other languages or question the infrastructure in 
general) 
- [~lyschoening], [~myTalala], [~econner724], [~isanych] and [~juliengreard] 
agree with your pull request
- all builds are fine

I can surely do a general review, but my Python expertise is limited, so I 
would not rely on my own opinion alone. Especially not with such a topic. But 
if you 5 guys come to someething you are happy with as a group, we should have 
enough backing to get it merged.  At the end, this is open source.



was (Author: jensg):
[~allengeorge], 

I am fine with it as long as 
a) the proposed changes are local to Python stuff (.i.e. there are no changes 
necessary that affect other languages or question the infrastructure in 
general) 
b) if [~lyschoening], [~myTalala], [~econner724] and [~juliengreard] agree with 
your pull request
c) all builds are fine

I can surely do a general review, but my Python expertise is limited, so I 
would not rely on my own opinion alone. Especially not with such a topic. But 
if you 5 guys come to someething you are happy with as a group, we should have 
enough backing to get it merged.  At the end, this is open source.


> Recursive structs don't work in python
> --
>
> Key: THRIFT-2642
> URL: https://issues.apache.org/jira/browse/THRIFT-2642
> Project: Thrift
>  Issue Type: Bug
>  Components: Python - Compiler, Python - Library
>Affects Versions: 0.9.2
>Reporter: Igor Kostenko
>
> Recursive structs in 0.9.2 work fine in c++ & c#, but not in python, because 
> generated code trying to use objects which not constructed yet.
> Struct:
> {code}
> struct Recursive {
> 1: list Children
> }
> {code}
> Python code:
> {code}
> class Recursive:
>   thrift_spec = (
> None, # 0
> (1, TType.LIST, 'Children', (TType.STRUCT,(Recursive, 
> Recursive.thrift_spec)), None, ), # 1
>   )
> {code}
> Error message:
> {code}
> Traceback (most recent call last):
>   File "ttypes.py", line 20, in 
> class Recursive:
>   File "ttypes.py", line 28, in Recursive
> (1, TType.LIST, 'Children', (TType.STRUCT,(Recursive, 
> Recursive.thrift_spec)), None, ), # 1
> NameError: name 'Recursive' is not defined
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-2642) Recursive structs don't work in python

[Jens Geyer (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008223#comment-16008223
 ] 

Jens Geyer commented on THRIFT-2642:


[~allengeorge], 

I am fine with it as long as 
a) the proposed changes are local to Python stuff (.i.e. there are no changes 
necessary that affect other languages or question the infrastructure in 
general) 
b) if [~lyschoening], [~myTalala], [~econner724] and [~juliengreard] agree with 
your pull request
c) all builds are fine

I can surely do a general review, but my Python expertise is limited, so I 
would not rely on my own opinion alone. Especially not with such a topic. But 
if you 5 guys come to someething you are happy with as a group, we should have 
enough backing to get it merged.  At the end, this is open source.


> Recursive structs don't work in python
> --
>
> Key: THRIFT-2642
> URL: https://issues.apache.org/jira/browse/THRIFT-2642
> Project: Thrift
>  Issue Type: Bug
>  Components: Python - Compiler, Python - Library
>Affects Versions: 0.9.2
>Reporter: Igor Kostenko
>
> Recursive structs in 0.9.2 work fine in c++ & c#, but not in python, because 
> generated code trying to use objects which not constructed yet.
> Struct:
> {code}
> struct Recursive {
> 1: list Children
> }
> {code}
> Python code:
> {code}
> class Recursive:
>   thrift_spec = (
> None, # 0
> (1, TType.LIST, 'Children', (TType.STRUCT,(Recursive, 
> Recursive.thrift_spec)), None, ), # 1
>   )
> {code}
> Error message:
> {code}
> Traceback (most recent call last):
>   File "ttypes.py", line 20, in 
> class Recursive:
>   File "ttypes.py", line 28, in Recursive
> (1, TType.LIST, 'Children', (TType.STRUCT,(Recursive, 
> Recursive.thrift_spec)), None, ), # 1
> NameError: name 'Recursive' is not defined
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4197) Implement transparent gzip compression for HTTP transport

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007931#comment-16007931
 ] 

ASF GitHub Bot commented on THRIFT-4197:


GitHub user dcelasun reopened a pull request:

https://github.com/apache/thrift/pull/1266

THRIFT-4197 [Go] Transparent gzip support for HTTP transport

Check if the client supports gzip compressed responses and compress the 
response if it does.

@Jens-G thoughts?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dcelasun/thrift go-gzip-support

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1266.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1266


commit b434d2d59b98f457600d0928e519b400462dee4a
Author: D. Can Celasun 
Date:   2017-05-11T10:04:01Z

[Go] Transparent gzip support for HTTP transport

Check if the client supports gzip compressed responses and compress
the response if it does.




> Implement transparent gzip compression for HTTP transport
> -
>
> Key: THRIFT-4197
> URL: https://issues.apache.org/jira/browse/THRIFT-4197
> Project: Thrift
>  Issue Type: Improvement
>  Components: Go - Library
>Affects Versions: 0.10.0
>Reporter: Can Celasun
>Assignee: Can Celasun
>Priority: Minor
>
> HTTP transport should check if the client supports gzip compressed responses 
> and do transparent compression if it does.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4197) Implement transparent gzip compression for HTTP transport

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007930#comment-16007930
 ] 

ASF GitHub Bot commented on THRIFT-4197:


Github user dcelasun closed the pull request at:

https://github.com/apache/thrift/pull/1266


> Implement transparent gzip compression for HTTP transport
> -
>
> Key: THRIFT-4197
> URL: https://issues.apache.org/jira/browse/THRIFT-4197
> Project: Thrift
>  Issue Type: Improvement
>  Components: Go - Library
>Affects Versions: 0.10.0
>Reporter: Can Celasun
>Assignee: Can Celasun
>Priority: Minor
>
> HTTP transport should check if the client supports gzip compressed responses 
> and do transparent compression if it does.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift pull request #1266: THRIFT-4197 [Go] Transparent gzip support for HTT...

[dcelasun]

Github user dcelasun closed the pull request at:

https://github.com/apache/thrift/pull/1266


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1266: THRIFT-4197 [Go] Transparent gzip support for HTT...

[dcelasun]

GitHub user dcelasun reopened a pull request:

https://github.com/apache/thrift/pull/1266

THRIFT-4197 [Go] Transparent gzip support for HTTP transport

Check if the client supports gzip compressed responses and compress the 
response if it does.

@Jens-G thoughts?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dcelasun/thrift go-gzip-support

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1266.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1266


commit b434d2d59b98f457600d0928e519b400462dee4a
Author: D. Can Celasun 
Date:   2017-05-11T10:04:01Z

[Go] Transparent gzip support for HTTP transport

Check if the client supports gzip compressed responses and compress
the response if it does.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-3080) C++ TNonblockingServer connection leak while accept huge number connections.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007699#comment-16007699
 ] 

ASF GitHub Bot commented on THRIFT-3080:


Github user lyhuzi commented on the issue:

https://github.com/apache/thrift/pull/422
  
why not use ul_swriteo_ms_ex2


> C++ TNonblockingServer connection leak while accept huge number connections.
> 
>
> Key: THRIFT-3080
> URL: https://issues.apache.org/jira/browse/THRIFT-3080
> Project: Thrift
>  Issue Type: Bug
>Affects Versions: 0.9.2
>Reporter: Lei FW
>Assignee: Roger Meier
>Priority: Critical
> Fix For: 0.9.3
>
>
> while huge number connections are accepted, the send() syscall on the unix 
> socket for the IO Thread may fail and return EAGAIN, but no one care about 
> the failed sent fd, neither retry nor clean.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift issue #422: THRIFT-3080: fix connection leak of C++ Nonblocking Serve...

[lyhuzi]

Github user lyhuzi commented on the issue:

https://github.com/apache/thrift/pull/422
  
why not use ul_swriteo_ms_ex2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-3080) C++ TNonblockingServer connection leak while accept huge number connections.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007697#comment-16007697
 ] 

ASF GitHub Bot commented on THRIFT-3080:


Github user lyhuzi commented on the issue:

https://github.com/apache/thrift/pull/422
  
为什么不用ul_swriteo_ms_ex2


> C++ TNonblockingServer connection leak while accept huge number connections.
> 
>
> Key: THRIFT-3080
> URL: https://issues.apache.org/jira/browse/THRIFT-3080
> Project: Thrift
>  Issue Type: Bug
>Affects Versions: 0.9.2
>Reporter: Lei FW
>Assignee: Roger Meier
>Priority: Critical
> Fix For: 0.9.3
>
>
> while huge number connections are accepted, the send() syscall on the unix 
> socket for the IO Thread may fail and return EAGAIN, but no one care about 
> the failed sent fd, neither retry nor clean.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift issue #422: THRIFT-3080: fix connection leak of C++ Nonblocking Serve...

[lyhuzi]

Github user lyhuzi commented on the issue:

https://github.com/apache/thrift/pull/422
  
为什么不用ul_swriteo_ms_ex2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---