[jira] [Created] (THRIFT-4205) c_glib is not linking against glib + gobject
Gonzalo Aguilar created THRIFT-4205:
---
Summary: c_glib is not linking against glib + gobject
Key: THRIFT-4205
URL: https://issues.apache.org/jira/browse/THRIFT-4205
Project: Thrift
Issue Type: Improvement
Components: C glib - Library
Affects Versions: 1.0
Reporter: Gonzalo Aguilar
Assignee: Gonzalo Aguilar
Priority: Critical
Fix For: 1.0
The library is not linking against glib and gobject depedencies. It means that
it will work if the library is linked against a program that uses that
libraries but it will fail in environments like Android.
Since the reference to gobject (for example) will not be there and in
System.Loadlibrary('libthrift_c_glib') it will fail to load because missing
symbols.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift pull request #1272: THRIFT-4205: Set flags for glib+gobject on compil...
GitHub user gadLinux opened a pull request: https://github.com/apache/thrift/pull/1272 THRIFT-4205: Set flags for glib+gobject on compilation Set flags for glib+gobject on compilation so systems like Android doesn't blow up. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gadLinux/thrift THRIFT-4205 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1272.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1272 commit 94968a7db10d4b95bec62d33bed66868eebfbc38 Author: Gonzalo Aguilar Delgado Date: 2017-05-23T15:22:44Z THRIFT-4205: Make sure gobject+glib are correctly linked commit fb518bebec7666953fc69a540db9a56973b9bab5 Author: Gonzalo Aguilar Delgado Date: 2017-05-23T15:24:54Z Fix lib for glib --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4205) c_glib is not linking against glib + gobject
[
https://issues.apache.org/jira/browse/THRIFT-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021321#comment-16021321
]
ASF GitHub Bot commented on THRIFT-4205:
GitHub user gadLinux opened a pull request:
https://github.com/apache/thrift/pull/1272
THRIFT-4205: Set flags for glib+gobject on compilation
Set flags for glib+gobject on compilation so systems like Android doesn't
blow up.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gadLinux/thrift THRIFT-4205
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1272.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1272
commit 94968a7db10d4b95bec62d33bed66868eebfbc38
Author: Gonzalo Aguilar Delgado
Date: 2017-05-23T15:22:44Z
THRIFT-4205: Make sure gobject+glib are correctly linked
commit fb518bebec7666953fc69a540db9a56973b9bab5
Author: Gonzalo Aguilar Delgado
Date: 2017-05-23T15:24:54Z
Fix lib for glib
> c_glib is not linking against glib + gobject
>
>
> Key: THRIFT-4205
> URL: https://issues.apache.org/jira/browse/THRIFT-4205
> Project: Thrift
> Issue Type: Improvement
> Components: C glib - Library
>Affects Versions: 1.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
>Priority: Critical
> Labels: build
> Fix For: 1.0
>
>
> The library is not linking against glib and gobject depedencies. It means
> that it will work if the library is linked against a program that uses that
> libraries but it will fail in environments like Android.
> Since the reference to gobject (for example) will not be there and in
> System.Loadlibrary('libthrift_c_glib') it will fail to load because missing
> symbols.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift pull request #1273: Fix decoding of strings in containers with py:dyn...
GitHub user elprans opened a pull request: https://github.com/apache/thrift/pull/1273 Fix decoding of strings in containers with py:dynamic and py:utf8strings _read_by_ttype and _write_by_ttype must be using the *element* spec and not the container spec when determining the correct read/write handler. You can merge this pull request into a Git repository by running: $ git pull https://github.com/elprans/thrift py-strings-in-containers Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1273.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1273 commit 6edf57c5073e4b452bb1752a9e493c9b779bb24a Author: Elvis Pranskevichus Date: 2017-05-23T15:36:23Z Fix decoding of strings in containers with py:dynamic and py:utf8strings _read_by_ttype and _write_by_ttype must be using the *element* spec and not the container spec when determining the correct read/write handler. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (THRIFT-4206) Strings in container fields are not decoded properly with py:dynamic and py:utf8strings
Elvis Pranskevichus created THRIFT-4206:
---
Summary: Strings in container fields are not decoded properly with
py:dynamic and py:utf8strings
Key: THRIFT-4206
URL: https://issues.apache.org/jira/browse/THRIFT-4206
Project: Thrift
Issue Type: Bug
Components: Python - Library
Affects Versions: 0.10.0
Reporter: Elvis Pranskevichus
Fix For: 0.11.0
{{_read_by_ttype}} and {{_write_by_ttype}} must be using the *element* spec
and not the container spec when determining the correct read/write
handler.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (THRIFT-4206) Strings in container fields are not decoded properly with py:dynamic and py:utf8strings
[
https://issues.apache.org/jira/browse/THRIFT-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elvis Pranskevichus updated THRIFT-4206:
Flags: Patch
Patch Info: Patch Available
> Strings in container fields are not decoded properly with py:dynamic and
> py:utf8strings
> ---
>
> Key: THRIFT-4206
> URL: https://issues.apache.org/jira/browse/THRIFT-4206
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.10.0
>Reporter: Elvis Pranskevichus
> Fix For: 0.11.0
>
>
> {{_read_by_ttype}} and {{_write_by_ttype}} must be using the *element* spec
> and not the container spec when determining the correct read/write
> handler.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (THRIFT-4207) Accelerated version of TBinaryProtocol allows invalid input to string fields.
Elvis Pranskevichus created THRIFT-4207:
---
Summary: Accelerated version of TBinaryProtocol allows invalid
input to string fields.
Key: THRIFT-4207
URL: https://issues.apache.org/jira/browse/THRIFT-4207
Project: Thrift
Issue Type: Bug
Components: Python - Library
Affects Versions: 0.10.0
Reporter: Elvis Pranskevichus
Fix For: 0.11.0
{{TBinaryProtocolAccelerated}} and {{TCompactProtocolAccelerated}} currently
accept arbitrary bytes as input to string fields even when {{py:utf8strings}}
is on.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift pull request #1274: THRIFT-4207: Make sure Python Accelerated protoco...
GitHub user elprans opened a pull request: https://github.com/apache/thrift/pull/1274 THRIFT-4207: Make sure Python Accelerated protocol does not allow invalid UTF-8 The accelerated version of Binary and Compact protocol fails to validate the input string for UTF-8 fields. You can merge this pull request into a Git repository by running: $ git pull https://github.com/elprans/thrift python-fastbinary-utf8-validation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1274.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1274 commit e030430e90ec5d7dff1db8dd98f36b6171c9a866 Author: Elvis Pranskevichus Date: 2017-05-23T15:50:38Z THRIFT-4207: Make sure Python Accelerated protocol does not allow invalid UTF-8 in. The accelerated version of Binary and Compact protocol fails to validate the input string for UTF-8 fields. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4207) Accelerated version of TBinaryProtocol allows invalid input to string fields.
[
https://issues.apache.org/jira/browse/THRIFT-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021439#comment-16021439
]
ASF GitHub Bot commented on THRIFT-4207:
GitHub user elprans opened a pull request:
https://github.com/apache/thrift/pull/1274
THRIFT-4207: Make sure Python Accelerated protocol does not allow invalid
UTF-8
The accelerated version of Binary and Compact protocol fails to validate
the input string for UTF-8 fields.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/elprans/thrift
python-fastbinary-utf8-validation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1274.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1274
commit e030430e90ec5d7dff1db8dd98f36b6171c9a866
Author: Elvis Pranskevichus
Date: 2017-05-23T15:50:38Z
THRIFT-4207: Make sure Python Accelerated protocol does not allow invalid
UTF-8 in.
The accelerated version of Binary and Compact protocol fails to validate
the input string for UTF-8 fields.
> Accelerated version of TBinaryProtocol allows invalid input to string fields.
> -
>
> Key: THRIFT-4207
> URL: https://issues.apache.org/jira/browse/THRIFT-4207
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.10.0
>Reporter: Elvis Pranskevichus
> Fix For: 0.11.0
>
>
> {{TBinaryProtocolAccelerated}} and {{TCompactProtocolAccelerated}} currently
> accept arbitrary bytes as input to string fields even when {{py:utf8strings}}
> is on.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (THRIFT-4206) Strings in container fields are not decoded properly with py:dynamic and py:utf8strings
[
https://issues.apache.org/jira/browse/THRIFT-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021816#comment-16021816
]
Jens Geyer commented on THRIFT-4206:
GitHub user elprans opened a pull request:
https://github.com/apache/thrift/pull/1273
Fix decoding of strings in containers with py:dynamic and py:utf8strings
_read_by_ttype and _write_by_ttype must be using the *element* spec
and not the container spec when determining the correct read/write
handler.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/elprans/thrift py-strings-in-containers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1273.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1273
commit 6edf57c5073e4b452bb1752a9e493c9b779bb24a
Author: Elvis Pranskevichus
Date: 2017-05-23T15:36:23Z
Fix decoding of strings in containers with py:dynamic and py:utf8strings
_read_by_ttype and _write_by_ttype must be using the *element* spec
and not the container spec when determining the correct read/write
handler.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
> Strings in container fields are not decoded properly with py:dynamic and
> py:utf8strings
> ---
>
> Key: THRIFT-4206
> URL: https://issues.apache.org/jira/browse/THRIFT-4206
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.10.0
>Reporter: Elvis Pranskevichus
> Fix For: 0.11.0
>
>
> {{_read_by_ttype}} and {{_write_by_ttype}} must be using the *element* spec
> and not the container spec when determining the correct read/write
> handler.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
