[GitHub] thrift pull request #1287: THRIFT-4219 Refactor Go HTTP Client
GitHub user dcelasun opened a pull request: https://github.com/apache/thrift/pull/1287 THRIFT-4219 Refactor Go HTTP Client As discussed in THRIFT-4219, this commit removes support for one-off GET requests, which brings the Go HTTP client inline with implementations in other languages. Constructor functions with "Post" in their names are all deprecated using the proper format [0] as all constructors now have the POST behaviour. Fixes THRIFT-4219. [0] https://github.com/golang/go/issues/10909#issuecomment-136492606 You can merge this pull request into a Git repository by running: $ git pull https://github.com/dcelasun/thrift THRIFT-4219 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1287.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1287 commit fdbf25f5f802fc9fde926b61c0fd31f95e39d000 Author: D. Can Celasun Date: 2017-06-10T14:37:47Z THRIFT-4219 Refactor Go HTTP Client As discussed in THRIFT-4219, this commit removes support for one-off GET requests, which brings the Go HTTP client inline with implementations in other languages. Constructor functions with "Post" in their names are all deprecated using the proper format [0] as all constructors now have the POST behaviour. Fixes THRIFT-4219. [0] https://github.com/golang/go/issues/10909#issuecomment-136492606 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4219) Golang HTTP clients created with Nil buffer
[
https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045586#comment-16045586
]
ASF GitHub Bot commented on THRIFT-4219:
GitHub user dcelasun opened a pull request:
https://github.com/apache/thrift/pull/1287
THRIFT-4219 Refactor Go HTTP Client
As discussed in THRIFT-4219, this commit removes support for one-off GET
requests, which brings the Go HTTP client inline with implementations in
other languages.
Constructor functions with "Post" in their names are all deprecated
using the proper format [0] as all constructors now have the POST
behaviour.
Fixes THRIFT-4219.
[0] https://github.com/golang/go/issues/10909#issuecomment-136492606
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dcelasun/thrift THRIFT-4219
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1287.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1287
commit fdbf25f5f802fc9fde926b61c0fd31f95e39d000
Author: D. Can Celasun
Date: 2017-06-10T14:37:47Z
THRIFT-4219 Refactor Go HTTP Client
As discussed in THRIFT-4219, this commit removes support for one-off GET
requests, which brings the Go HTTP client inline with implementations in
other languages.
Constructor functions with "Post" in their names are all deprecated
using the proper format [0] as all constructors now have the POST
behaviour.
Fixes THRIFT-4219.
[0] https://github.com/golang/go/issues/10909#issuecomment-136492606
> Golang HTTP clients created with Nil buffer
> ---
>
> Key: THRIFT-4219
> URL: https://issues.apache.org/jira/browse/THRIFT-4219
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
>Reporter: James Mouradian
>Assignee: Can Celasun
>
> As of 2b1b32c,
> [{{NewTHttpClientWithOptions}}|https://github.com/apache/thrift/blob/master/lib/go/thrift/http_client.go#L93]
> creates a {{THttpClient}} instance with a nil {{requestBuffer}}. This causes
> a panic when the instance attempts to write to the buffer.
> A patch probably fits well with THRIFT-4215 and THRIFT-4216.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift issue #1287: THRIFT-4219 Refactor Go HTTP Client
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1287 Travis failures are unrelated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4219) Golang HTTP clients created with Nil buffer
[
https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045613#comment-16045613
]
ASF GitHub Bot commented on THRIFT-4219:
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1287
Travis failures are unrelated.
> Golang HTTP clients created with Nil buffer
> ---
>
> Key: THRIFT-4219
> URL: https://issues.apache.org/jira/browse/THRIFT-4219
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
>Reporter: James Mouradian
>Assignee: Can Celasun
>
> As of 2b1b32c,
> [{{NewTHttpClientWithOptions}}|https://github.com/apache/thrift/blob/master/lib/go/thrift/http_client.go#L93]
> creates a {{THttpClient}} instance with a nil {{requestBuffer}}. This causes
> a panic when the instance attempts to write to the buffer.
> A patch probably fits well with THRIFT-4215 and THRIFT-4216.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
