[jira] [Commented] (THRIFT-4239) Latest thrift breaks java build with handleRuntimeExceptions

2017-06-28 Thread Mario Emmenlauer (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067241#comment-16067241
 ] 

Mario Emmenlauer commented on THRIFT-4239:
--

The exact error message is pointing to the @Override of 
handleRuntimeExceptions():
{code}
[...]/APIAccess.java:398: error: method does not override or implement a method 
from a supertype
  @Override
  ^
{code}


> Latest thrift breaks java build with handleRuntimeExceptions
> 
>
> Key: THRIFT-4239
> URL: https://issues.apache.org/jira/browse/THRIFT-4239
> Project: Thrift
>  Issue Type: Bug
>  Components: Java - Compiler
>Affects Versions: 0.11.0
> Environment: Ubuntu 16.04 LTS with Oracle Java 1.8 JDK
>Reporter: Mario Emmenlauer
>
> With the latest trunk I can no longer build my Java thrift example. I get an 
> error that handleRuntimeExceptions does not Override. It seems related to 
> these new additions in the generated Java code:
> {code}
> -  @Override
> -  protected boolean handleRuntimeExceptions() {
> -return false;
> -  }
> {code}
> With thrift 0.10.0 the method handleRuntimeExceptions (and the error) are not 
> present.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4219) Golang HTTP clients created with Nil buffer

2017-06-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067174#comment-16067174
 ] 

ASF GitHub Bot commented on THRIFT-4219:


Github user dcelasun commented on the issue:

https://github.com/apache/thrift/pull/1287
  
@Jens-G Thoughts?


> Golang HTTP clients created with Nil buffer
> ---
>
> Key: THRIFT-4219
> URL: https://issues.apache.org/jira/browse/THRIFT-4219
> Project: Thrift
>  Issue Type: Bug
>  Components: Go - Library
>Reporter: James Mouradian
>Assignee: Can Celasun
>
> As of 2b1b32c, 
> [{{NewTHttpClientWithOptions}}|https://github.com/apache/thrift/blob/master/lib/go/thrift/http_client.go#L93]
>  creates a {{THttpClient}} instance with a nil {{requestBuffer}}. This causes 
> a panic when the instance attempts to write to the buffer.
> A patch probably fits well with THRIFT-4215 and THRIFT-4216.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1287: THRIFT-4219 Refactor Go HTTP Client

2017-06-28 Thread dcelasun 
Github user dcelasun commented on the issue:

https://github.com/apache/thrift/pull/1287
  
@Jens-G Thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---