[jira] [Resolved] (THRIFT-4319) command line switch for "evhttp" incorrectly resolved to anon pipes
[
https://issues.apache.org/jira/browse/THRIFT-4319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-4319.
Resolution: Fixed
Fix Version/s: 0.11.0
Committed.
> command line switch for "evhttp" incorrectly resolved to anon pipes
> ---
>
> Key: THRIFT-4319
> URL: https://issues.apache.org/jira/browse/THRIFT-4319
> Project: Thrift
> Issue Type: Bug
> Components: Delphi - Library
>Reporter: Jens Geyer
>Assignee: Jens Geyer
>Priority: Trivial
> Fix For: 0.11.0
>
> Attachments:
> 0001-THRIFT-4319-command-line-switch-for-evhttp-incorrect.patch
>
>
> The {{--transport evhttp}} switch in the TestSuite Delphi client is resolved
> to anon pipes which is just wrong.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (THRIFT-4319) command line switch for "evhttp" incorrectly resolved to anon pipes
[
https://issues.apache.org/jira/browse/THRIFT-4319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-4319:
---
Attachment: 0001-THRIFT-4319-command-line-switch-for-evhttp-incorrect.patch
> command line switch for "evhttp" incorrectly resolved to anon pipes
> ---
>
> Key: THRIFT-4319
> URL: https://issues.apache.org/jira/browse/THRIFT-4319
> Project: Thrift
> Issue Type: Bug
> Components: Delphi - Library
>Reporter: Jens Geyer
>Assignee: Jens Geyer
>Priority: Trivial
> Attachments:
> 0001-THRIFT-4319-command-line-switch-for-evhttp-incorrect.patch
>
>
> The {{--transport evhttp}} switch in the TestSuite Delphi client is resolved
> to anon pipes which is just wrong.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (THRIFT-4319) command line switch for "evhttp" incorrectly resolved to anon pipes
Jens Geyer created THRIFT-4319:
--
Summary: command line switch for "evhttp" incorrectly resolved to
anon pipes
Key: THRIFT-4319
URL: https://issues.apache.org/jira/browse/THRIFT-4319
Project: Thrift
Issue Type: Bug
Components: Delphi - Library
Reporter: Jens Geyer
Assignee: Jens Geyer
Priority: Trivial
The {{--transport evhttp}} switch in the TestSuite Delphi client is resolved to
anon pipes which is just wrong.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (THRIFT-4318) Delphi performance improvements
[
https://issues.apache.org/jira/browse/THRIFT-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-4318.
Resolution: Fixed
Fix Version/s: 0.11.0
Committed.
> Delphi performance improvements
> ---
>
> Key: THRIFT-4318
> URL: https://issues.apache.org/jira/browse/THRIFT-4318
> Project: Thrift
> Issue Type: Improvement
> Components: Delphi - Compiler
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Labels: perfomance
> Fix For: 0.11.0
>
>
> Misc. improvents for the Delphi implementation w/regard to overall
> performance. In the testcase used to develop this a performance boost of 20%
> or more has been observed esepcially with the binary protocol.
> Note that my testcase is not part of the patch for several reasons and the
> total gains are also highly dependent on the data structures and the exact
> setup of the protocol/transport stack, so mileage may (and will) vary.
> *Important*: The patch affects both compiler and library and is a breaking
> change vis-á-vis certain library structures (e.g. the interface {{IField}} is
> now a record called {{TThriftField}}). Therefore, *all Thrift-generated
> Delphi code must be re-generated from the IDL* to match the new library,
> otherwise compilation will not succeed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4318) Delphi performance improvements
[
https://issues.apache.org/jira/browse/THRIFT-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157566#comment-16157566
]
ASF GitHub Bot commented on THRIFT-4318:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1348
> Delphi performance improvements
> ---
>
> Key: THRIFT-4318
> URL: https://issues.apache.org/jira/browse/THRIFT-4318
> Project: Thrift
> Issue Type: Improvement
> Components: Delphi - Compiler
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Labels: perfomance
>
> Misc. improvents for the Delphi implementation w/regard to overall
> performance. In the testcase used to develop this a performance boost of 20%
> or more has been observed esepcially with the binary protocol.
> Note that my testcase is not part of the patch for several reasons and the
> total gains are also highly dependent on the data structures and the exact
> setup of the protocol/transport stack, so mileage may (and will) vary.
> *Important*: The patch affects both compiler and library and is a breaking
> change vis-á-vis certain library structures (e.g. the interface {{IField}} is
> now a record called {{TThriftField}}). Therefore, *all Thrift-generated
> Delphi code must be re-generated from the IDL* to match the new library,
> otherwise compilation will not succeed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift pull request #1348: THRIFT-4318 Delphi performance improvements
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1348 ---
[jira] [Updated] (THRIFT-4318) Delphi performance improvements
[
https://issues.apache.org/jira/browse/THRIFT-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-4318:
---
Description:
Misc. improvents for the Delphi implementation w/regard to overall performance.
In the testcase used to develop this a performance boost of 20% or more has
been observed esepcially with the binary protocol.
Note that my testcase is not part of the patch for several reasons and the
total gains are also highly dependent on the data structures and the exact
setup of the protocol/transport stack, so mileage may (and will) vary.
*Important*: The patch affects both compiler and library and is a breaking
change vis-á-vis certain library structures (e.g. the interface {{IField}} is
now a record called {{TThriftField}}). Therefore, *all Thrift-generated Delphi
code must be re-generated from the IDL* to match the new library, otherwise
compilation will not succeed.
was:
Misc. improvents for the Delphi implementation w/regard to overall performance.
In the testcase used to develop this a performance boost of 20% or more has
been observed, depending on what protocol you use.
Note that my testcase is not part of the patch for several reasons and the
total gains are also highly dependent on the data structures, so mileage may
(and will) vary.
*Important*: The patch affects both compiler and library and is a breaking
change vis-á-vis certain library structures (e.g. the interface {{IField}} is
now a record called {{TThriftField}}). Therefore, *all Thrift-generated Delphi
code must be re-generated from the IDL* to match the new library, otherwise
compilation will not succeed.
> Delphi performance improvements
> ---
>
> Key: THRIFT-4318
> URL: https://issues.apache.org/jira/browse/THRIFT-4318
> Project: Thrift
> Issue Type: Improvement
> Components: Delphi - Compiler
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Labels: perfomance
>
> Misc. improvents for the Delphi implementation w/regard to overall
> performance. In the testcase used to develop this a performance boost of 20%
> or more has been observed esepcially with the binary protocol.
> Note that my testcase is not part of the patch for several reasons and the
> total gains are also highly dependent on the data structures and the exact
> setup of the protocol/transport stack, so mileage may (and will) vary.
> *Important*: The patch affects both compiler and library and is a breaking
> change vis-á-vis certain library structures (e.g. the interface {{IField}} is
> now a record called {{TThriftField}}). Therefore, *all Thrift-generated
> Delphi code must be re-generated from the IDL* to match the new library,
> otherwise compilation will not succeed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (THRIFT-4318) Delphi performance improvements
[
https://issues.apache.org/jira/browse/THRIFT-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-4318:
---
Description:
Misc. improvents for the Delphi implementation w/regard to overall performance.
In the testcase used to develop this a performance boost of 20% or more has
been observed, depending on what protocol you use.
Note that my testcase is not part of the patch for several reasons and the
total gains are also highly dependent on the data structures, so mileage may
(and will) vary.
*Important*: The patch affects both compiler and library and is a breaking
change vis-á-vis certain library structures (e.g. the interface {{IField}} is
now a record called {{TThriftField}}). Therefore, *all Thrift-generated Delphi
code must be re-generated from the IDL* to match the new library, otherwise
compilation will not succeed.
was:
Misc. improvents for the Delphi implementation w/regard to overall performance.
In the testcase used to develop this a performance boost of 20% or more has
been observed, depending on what protocol you use.
Note that my testcase is not part of the patch for several reasons and the
total gains are also highly dependent on the data structures, so mileage may
(and will) vary.
> Delphi performance improvements
> ---
>
> Key: THRIFT-4318
> URL: https://issues.apache.org/jira/browse/THRIFT-4318
> Project: Thrift
> Issue Type: Improvement
> Components: Delphi - Compiler
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Labels: perfomance
>
> Misc. improvents for the Delphi implementation w/regard to overall
> performance. In the testcase used to develop this a performance boost of 20%
> or more has been observed, depending on what protocol you use.
> Note that my testcase is not part of the patch for several reasons and the
> total gains are also highly dependent on the data structures, so mileage may
> (and will) vary.
> *Important*: The patch affects both compiler and library and is a breaking
> change vis-á-vis certain library structures (e.g. the interface {{IField}} is
> now a record called {{TThriftField}}). Therefore, *all Thrift-generated
> Delphi code must be re-generated from the IDL* to match the new library,
> otherwise compilation will not succeed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4318) Delphi performance improvements
[ https://issues.apache.org/jira/browse/THRIFT-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157520#comment-16157520 ] ASF GitHub Bot commented on THRIFT-4318: GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/1348 THRIFT-4318 Delphi performance improvements Client: Delphi Patch: Jens Geyer You can merge this pull request into a Git repository by running: $ git pull https://github.com/Jens-G/thrift THRIFT-4318 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1348.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1348 commit 11c887f1a61c367c83cf7e90d28f74d06a81b17f Author: Jens Geyer Date: 2017-09-05T18:31:27Z THRIFT-4318 Delphi performance improvements Client: Delphi Patch: Jens Geyer > Delphi performance improvements > --- > > Key: THRIFT-4318 > URL: https://issues.apache.org/jira/browse/THRIFT-4318 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Compiler >Reporter: Jens Geyer >Assignee: Jens Geyer > Labels: perfomance > > Misc. improvents for the Delphi implementation w/regard to overall > performance. In the testcase used to develop this a performance boost of 20% > or more has been observed, depending on what protocol you use. > Note that my testcase is not part of the patch for several reasons and the > total gains are also highly dependent on the data structures, so mileage may > (and will) vary. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1348: THRIFT-4318 Delphi performance improvements
GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/1348 THRIFT-4318 Delphi performance improvements Client: Delphi Patch: Jens Geyer You can merge this pull request into a Git repository by running: $ git pull https://github.com/Jens-G/thrift THRIFT-4318 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1348.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1348 commit 11c887f1a61c367c83cf7e90d28f74d06a81b17f Author: Jens Geyer Date: 2017-09-05T18:31:27Z THRIFT-4318 Delphi performance improvements Client: Delphi Patch: Jens Geyer ---
[jira] [Created] (THRIFT-4318) Delphi performance improvements
Jens Geyer created THRIFT-4318: -- Summary: Delphi performance improvements Key: THRIFT-4318 URL: https://issues.apache.org/jira/browse/THRIFT-4318 Project: Thrift Issue Type: Improvement Components: Delphi - Compiler Reporter: Jens Geyer Assignee: Jens Geyer Misc. improvents for the Delphi implementation w/regard to overall performance. In the testcase used to develop this a performance boost of 20% or more has been observed, depending on what protocol you use. Note that my testcase is not part of the patch for several reasons and the total gains are also highly dependent on the data structures, so mileage may (and will) vary. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (THRIFT-2889) stable release 0.9.2, erlang tutorial broken
[ https://issues.apache.org/jira/browse/THRIFT-2889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-2889: --- Priority: Minor (was: Major) > stable release 0.9.2, erlang tutorial broken > > > Key: THRIFT-2889 > URL: https://issues.apache.org/jira/browse/THRIFT-2889 > Project: Thrift > Issue Type: Bug > Components: Tutorial >Affects Versions: 0.9.2, 0.9.3 > Environment: Linux Xu 3.16.0-23-generic #31-Ubuntu SMP Tue Oct 21 > 17:56:17 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux >Reporter: skypexu >Assignee: James E. King, III >Priority: Minor > Fix For: 0.11.0 > > > stable release 0.9.2's erlang tutorial is simply broken: > #cd thrift-0.9.2/tutorial/erl/ > #~/thrift-0.9.2/tutorial/erl$ ./server.sh > client.erl:47: undefined macro 'tutorial_Operation_SUBTRACT' > client.erl:24: function t/0 undefined > client.erl:26: Warning: function p/1 is unused -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (THRIFT-2889) stable release 0.9.2, erlang tutorial broken
[ https://issues.apache.org/jira/browse/THRIFT-2889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-2889. Resolution: Fixed Assignee: James E. King, III Fix Version/s: 0.11.0 I applied THRIFT-4313 and ran the tutorial and it worked without the errors noted. > stable release 0.9.2, erlang tutorial broken > > > Key: THRIFT-2889 > URL: https://issues.apache.org/jira/browse/THRIFT-2889 > Project: Thrift > Issue Type: Bug > Components: Tutorial >Affects Versions: 0.9.2, 0.9.3 > Environment: Linux Xu 3.16.0-23-generic #31-Ubuntu SMP Tue Oct 21 > 17:56:17 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux >Reporter: skypexu >Assignee: James E. King, III > Fix For: 0.11.0 > > > stable release 0.9.2's erlang tutorial is simply broken: > #cd thrift-0.9.2/tutorial/erl/ > #~/thrift-0.9.2/tutorial/erl$ ./server.sh > client.erl:47: undefined macro 'tutorial_Operation_SUBTRACT' > client.erl:24: function t/0 undefined > client.erl:26: Warning: function p/1 is unused -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157408#comment-16157408 ] James E. King, III commented on THRIFT-2289: [~weinmann] To resolve this I would recommend adding json protocol support to the cross test. If you look in ``test/tests.json`` you will see that the "erl" test block does not advertise protocols "json". I assume that if json is working properly, that could be added and therefore verified? > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157366#comment-16157366
]
ASF GitHub Bot commented on THRIFT-4273:
Github user walter-weinmann commented on the issue:
https://github.com/apache/thrift/pull/1346
@jeking3 please have a look at THRIFT-2289 and THRIFT-2889 - I suppose both
can be closed.
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Affects Versions: 0.10.0
>Reporter: Jens Geyer
>Assignee: James E. King, III
>Priority: Minor
> Fix For: 0.11.0
>
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1346 @jeking3 please have a look at THRIFT-2289 and THRIFT-2889 - I suppose both can be closed. ---
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157341#comment-16157341
]
ASF GitHub Bot commented on THRIFT-4273:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1346
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Affects Versions: 0.10.0
>Reporter: Jens Geyer
>Assignee: James E. King, III
>Priority: Minor
> Fix For: 0.11.0
>
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4273.
Resolution: Fixed
Assignee: James E. King, III
Fix Version/s: 0.11.0
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Affects Versions: 0.10.0
>Reporter: Jens Geyer
>Assignee: James E. King, III
>Priority: Minor
> Fix For: 0.11.0
>
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift pull request #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1346 ---
[jira] [Updated] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4273:
---
Affects Version/s: 0.10.0
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Affects Versions: 0.10.0
>Reporter: Jens Geyer
>Priority: Minor
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157333#comment-16157333
]
ASF GitHub Bot commented on THRIFT-4273:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1346
Building Appveyor right now probably not, since I don't think we do erlang
on windows in our CI right now. In order to get there, we need erlang support
in the cmake build environment. The travis builds are the important ones,
although as we discovered with the tutorials rotting, a build is only as good
as what it tests. Hopefully we have enough tests to cover these changes.
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Reporter: Jens Geyer
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4273:
---
Priority: Minor (was: Major)
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Reporter: Jens Geyer
>Priority: Minor
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1346 Building Appveyor right now probably not, since I don't think we do erlang on windows in our CI right now. In order to get there, we need erlang support in the cmake build environment. The travis builds are the important ones, although as we discovered with the tutorials rotting, a build is only as good as what it tests. Hopefully we have enough tests to cover these changes. ---
[jira] [Commented] (THRIFT-4251) Epoll Selector Bug
[ https://issues.apache.org/jira/browse/THRIFT-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157313#comment-16157313 ] ASF GitHub Bot commented on THRIFT-4251: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1313 I'd like additional feedback from folks who use Thrift with Java on this. It seems like the wrong place to fix the issue, but it sounds like many projects are implementing their own fix for it. I've never seen it happen. > Epoll Selector Bug > -- > > Key: THRIFT-4251 > URL: https://issues.apache.org/jira/browse/THRIFT-4251 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler, Java - Library >Affects Versions: 0.10.0 > Environment: Linux version 3.10.0-327.el7.x86_64 > (buil...@kbuilder.dev.centos.org) > java version "1.8.0_131" >Reporter: JohnnyLiao > Labels: epoll, jdk, selector > > Thrift java unsolve the infamous epoll bug. It's consum 100% cpu resource > when this occured. It seems to affect any NIO based Java server applications > running in the specified environment. Some projects provide workarounds for > similar JDK bugs, for example replaces the current Selector of this > SelectorThread.select with newly created Selector. > Stack Trace： > "Thread-46" #95 prio=5 os_prio=0 tid=0x7fc79cd02800 nid=0xb1 runnable > [0x7fc580bd1000] >java.lang.Thread.State: RUNNABLE > at sun.nio.ch.EPollArrayWrapper.epollWait(Native Method) > at sun.nio.ch.EPollArrayWrapper.poll(EPollArrayWrapper.java:269) > at sun.nio.ch.EPollSelectorImpl.doSelect(EPollSelectorImpl.java:93) > at sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:86) > - locked <0x8012f748> (a sun.nio.ch.Util$3) > - locked <0x8012f738> (a > java.util.Collections$UnmodifiableSet) > - locked <0x80120f58> (a sun.nio.ch.EPollSelectorImpl) > at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:97) > at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:101) > at > org.apache.thrift.server.TThreadedSelectorServer$SelectorThread.select(TThreadedSelectorServer.java:570) > at > org.apache.thrift.server.TThreadedSelectorServer$SelectorThread.run(TThreadedSelectorServer.java:541) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1313 I'd like additional feedback from folks who use Thrift with Java on this. It seems like the wrong place to fix the issue, but it sounds like many projects are implementing their own fix for it. I've never seen it happen. ---
[jira] [Commented] (THRIFT-3657) D TFileWriterTransport close should use non-priority send
[ https://issues.apache.org/jira/browse/THRIFT-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157304#comment-16157304 ] ASF GitHub Bot commented on THRIFT-3657: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/884 @nsuke a reminder to rebase and resubmit > D TFileWriterTransport close should use non-priority send > - > > Key: THRIFT-3657 > URL: https://issues.apache.org/jira/browse/THRIFT-3657 > Project: Thrift > Issue Type: Bug > Components: D - Library >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa >Priority: Trivial > > prioritySend is used in TFileWriterTransport close method. > A possible problem with this is that even synchronized calls that are > strictly before close call can be ignored in rare occasions. > The author has put a comment "FIXME: Should use normal send here" and there's > no reason not to. > I suspect it is a remnant of old implementation or local debug stuff. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #884: THRIFT-3657 D TFileWriterTransport close should use non-p...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/884 @nsuke a reminder to rebase and resubmit ---
[jira] [Commented] (THRIFT-3600) Make TTwisted server send exception on unexpected handler error
[ https://issues.apache.org/jira/browse/THRIFT-3600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157301#comment-16157301 ] ASF GitHub Bot commented on THRIFT-3600: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/838 @nsuke a reminder to rebase and resubmit > Make TTwisted server send exception on unexpected handler error > --- > > Key: THRIFT-3600 > URL: https://issues.apache.org/jira/browse/THRIFT-3600 > Project: Thrift > Issue Type: Bug > Components: Python - Compiler >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa > > When unspecified exception occurs inside handler, TTwisted server disconnects > the client. > Many other languages and non TTwisted/Tornado servers sends > TApplicationException in such cases. > There is even a test case that tries to assert this behavior for TTwisted but > the test is broken in a way it fails to detect the failure. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-3602) Make Tornado server send exception on unexpected handler error
[ https://issues.apache.org/jira/browse/THRIFT-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157302#comment-16157302 ] ASF GitHub Bot commented on THRIFT-3602: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/839 @nsuke a reminder to rebase and resubmit > Make Tornado server send exception on unexpected handler error > -- > > Key: THRIFT-3602 > URL: https://issues.apache.org/jira/browse/THRIFT-3602 > Project: Thrift > Issue Type: Bug > Components: Python - Compiler >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #839: THRIFT-3602 Make Tornado server send exception on unexpec...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/839 @nsuke a reminder to rebase and resubmit ---
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157298#comment-16157298
]
ASF GitHub Bot commented on THRIFT-4273:
Github user walter-weinmann commented on the issue:
https://github.com/apache/thrift/pull/1346
The `erlang:timestamp/0` method seems to be a very old kernel methods -
from the [release notes](http://erlang.org/doc/apps/kernel/notes.html) (current
kernel release is 5.3):
> 1.42 Kernel 2.13.2
>
> Fixed Bugs and Malfunctions
>
> A bug when doing io:get_line (among other calls) from a file opened with
encoding other than latin1, causing false unicode errors to occur, is now
corrected.
>
> Own Id: OTP-7974
>
> Improvements and New Features
>
> Added functionality to get higher resolution timestamp from system. The
erlang:now function returns a timestamp that's not always consistent with the
actual operating system time (due to resilience against large time changes in
the operating system). The function os:timestamp/0 is added to get a similar
timestamp as the one being returned by erlang:now, but untouched by Erlangs
time correcting and smoothing algorithms. The timestamp returned by
os:timestamp is always consistent with the operating systems view of time, like
the calendar functions for getting wall clock time, but with higher resolution.
Example of usage can be found in the os manual page.
>
> Own Id: OTP-7971
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Reporter: Jens Geyer
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1346 The `erlang:timestamp/0` method seems to be a very old kernel methods - from the [release notes](http://erlang.org/doc/apps/kernel/notes.html) (current kernel release is 5.3): > 1.42 Kernel 2.13.2 > > Fixed Bugs and Malfunctions > > A bug when doing io:get_line (among other calls) from a file opened with encoding other than latin1, causing false unicode errors to occur, is now corrected. > > Own Id: OTP-7974 > > Improvements and New Features > > Added functionality to get higher resolution timestamp from system. The erlang:now function returns a timestamp that's not always consistent with the actual operating system time (due to resilience against large time changes in the operating system). The function os:timestamp/0 is added to get a similar timestamp as the one being returned by erlang:now, but untouched by Erlangs time correcting and smoothing algorithms. The timestamp returned by os:timestamp is always consistent with the operating systems view of time, like the calendar functions for getting wall clock time, but with higher resolution. Example of usage can be found in the os manual page. > > Own Id: OTP-7971 ---
[GitHub] thrift issue #838: THRIFT-3600 Make TTwisted server send exception on unexpe...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/838 @nsuke a reminder to rebase and resubmit ---
[jira] [Resolved] (THRIFT-4290) C# nullable option generates invalid code for non-required enum field with default value
[
https://issues.apache.org/jira/browse/THRIFT-4290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4290.
Resolution: Fixed
Assignee: James E. King, III
Fix Version/s: 0.11.0
> C# nullable option generates invalid code for non-required enum field with
> default value
>
>
> Key: THRIFT-4290
> URL: https://issues.apache.org/jira/browse/THRIFT-4290
> Project: Thrift
> Issue Type: Bug
> Components: C# - Compiler
>Affects Versions: 0.9.3, 0.10.0
> Environment: Windows
>Reporter: Dirk Sandbrink
>Assignee: James E. King, III
>Priority: Minor
> Fix For: 0.11.0
>
>
> When generating C# code with the nullable option invalid setter code is
> generated for enum fields which have a default value (and thus still need an
> isset flag).
> For example use the Work struct from tutorial.thrift and add a default value
> to the enum field:
> {code:none}
> struct Work {
> 1: i32 num1 = 0,
> 2: i32 num2,
> 3: Operation op = Operation.ADD,
> 4: optional string comment,
> }
> {code}
> Then the generated code in Work.cs looks like this:
> {code:none}
> public Operation? Op
> {
> get
> {
> return _op;
> }
> set
> {
> __isset.op = true;
> this._op = value;
> }
> }
> {code}
> This code is invalid, because value is of type _Operation?_, the correct code
> should be:
> {code:none}
> public Operation? Op
> {
> get
> {
> return _op;
> }
> set
> {
> __isset.op = value.HasValue;
> if (value.HasValue) this._op = value.Value;
> }
> }
> {code}
> I believe the error is located in file t_csharp_generator.cc in function
> t_csharp_generator::generate_csharp_property:
> {code:none}
> if (ttype->is_base_type()) {
> use_nullable = ((t_base_type*)ttype)->get_base() !=
> t_base_type::TYPE_STRING;
> }
> {code}
> Here use_nullable is set to true for all base types other then string, but
> not for enums.
> A quick fix might be to add
> {code:none}
> else if (ttype->is_enum()) {
> use_nullable = true;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4290) C# nullable option generates invalid code for non-required enum field with default value
[
https://issues.apache.org/jira/browse/THRIFT-4290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157291#comment-16157291
]
ASF GitHub Bot commented on THRIFT-4290:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1347
> C# nullable option generates invalid code for non-required enum field with
> default value
>
>
> Key: THRIFT-4290
> URL: https://issues.apache.org/jira/browse/THRIFT-4290
> Project: Thrift
> Issue Type: Bug
> Components: C# - Compiler
>Affects Versions: 0.9.3, 0.10.0
> Environment: Windows
>Reporter: Dirk Sandbrink
>Assignee: James E. King, III
>Priority: Minor
> Fix For: 0.11.0
>
>
> When generating C# code with the nullable option invalid setter code is
> generated for enum fields which have a default value (and thus still need an
> isset flag).
> For example use the Work struct from tutorial.thrift and add a default value
> to the enum field:
> {code:none}
> struct Work {
> 1: i32 num1 = 0,
> 2: i32 num2,
> 3: Operation op = Operation.ADD,
> 4: optional string comment,
> }
> {code}
> Then the generated code in Work.cs looks like this:
> {code:none}
> public Operation? Op
> {
> get
> {
> return _op;
> }
> set
> {
> __isset.op = true;
> this._op = value;
> }
> }
> {code}
> This code is invalid, because value is of type _Operation?_, the correct code
> should be:
> {code:none}
> public Operation? Op
> {
> get
> {
> return _op;
> }
> set
> {
> __isset.op = value.HasValue;
> if (value.HasValue) this._op = value.Value;
> }
> }
> {code}
> I believe the error is located in file t_csharp_generator.cc in function
> t_csharp_generator::generate_csharp_property:
> {code:none}
> if (ttype->is_base_type()) {
> use_nullable = ((t_base_type*)ttype)->get_base() !=
> t_base_type::TYPE_STRING;
> }
> {code}
> Here use_nullable is set to true for all base types other then string, but
> not for enums.
> A quick fix might be to add
> {code:none}
> else if (ttype->is_enum()) {
> use_nullable = true;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift pull request #1347: THRIFT-4290: Fixed csharp:nullable code generatio...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1347 ---
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157287#comment-16157287
]
ASF GitHub Bot commented on THRIFT-4273:
Github user walter-weinmann commented on the issue:
https://github.com/apache/thrift/pull/1346
The problems were with Travis with varying reasons. I think it would be
interesting to look into it. There may be a couple of pull request with bad
results in Travis based on Travis internal problems. Similar observations wit
Appveyor - is it really useful to run both ?
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Reporter: Jens Geyer
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1346 The problems were with Travis with varying reasons. I think it would be interesting to look into it. There may be a couple of pull request with bad results in Travis based on Travis internal problems. Similar observations wit Appveyor - is it really useful to run both ? ---
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157283#comment-16157283
]
ASF GitHub Bot commented on THRIFT-4273:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1346
What versions of Erlang would this change eliminate as usable with Thrift?
I am finding it hard to locate the erlang release where the timestamp method
was introduced.
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Reporter: Jens Geyer
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1346 What versions of Erlang would this change eliminate as usable with Thrift? I am finding it hard to locate the erlang release where the timestamp method was introduced. ---
Re: Thrift backward compatibility checker
It works. Thank you! Have a good day : ) On Thu, Sep 7, 2017 at 12:13 AM, Jens Geyer wrote: > Hi, > > the compiler has a builtin auditing utility. Enter > > thrift -h > > and look for "audit". > > If this is not what you mean please explain. > > Sent from mobile device, please ignore spelling mistakes. > > Von: w yishigan > Gesendet: 07.09.2017 06:53 > An: dev@thrift.apache.org > Betreff: Thrift backward compatibility checker > > Hi folks, > I'm looking for a tool to check the backward compatibility of thrift files. > Is there any existing tool that I could use? Thank you! >
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157273#comment-16157273
]
ASF GitHub Bot commented on THRIFT-4273:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1346
@walter-weinmann what was failing - Appveyor or Travis? There are some
known build issues lurking about. I just eliminated one that popped up
occasionally with concurrency_test in C++, however I just found that on
Appveyor haskell is failing dependency checks sometimes.
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Reporter: Jens Geyer
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1346 @walter-weinmann what was failing - Appveyor or Travis? There are some known build issues lurking about. I just eliminated one that popped up occasionally with concurrency_test in C++, however I just found that on Appveyor haskell is failing dependency checks sometimes. ---
[jira] [Commented] (THRIFT-2733) Erlang coding standards
[ https://issues.apache.org/jira/browse/THRIFT-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157269#comment-16157269 ] ASF GitHub Bot commented on THRIFT-2733: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1345 > Erlang coding standards > --- > > Key: THRIFT-2733 > URL: https://issues.apache.org/jira/browse/THRIFT-2733 > Project: Thrift > Issue Type: Sub-task > Components: Erlang - Library >Reporter: Konrad Grochowski >Assignee: James E. King, III > Fix For: 0.11.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1345: THRIFT-2733 Erlang coding standards
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1345 ---
[jira] [Resolved] (THRIFT-2733) Erlang coding standards
[ https://issues.apache.org/jira/browse/THRIFT-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-2733. Resolution: Fixed Assignee: James E. King, III Fix Version/s: 0.11.0 > Erlang coding standards > --- > > Key: THRIFT-2733 > URL: https://issues.apache.org/jira/browse/THRIFT-2733 > Project: Thrift > Issue Type: Sub-task > Components: Erlang - Library >Reporter: Konrad Grochowski >Assignee: James E. King, III > Fix For: 0.11.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4106) concurrency_test fails randomly
[ https://issues.apache.org/jira/browse/THRIFT-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157259#comment-16157259 ] ASF GitHub Bot commented on THRIFT-4106: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1343 > concurrency_test fails randomly > --- > > Key: THRIFT-4106 > URL: https://issues.apache.org/jira/browse/THRIFT-4106 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.10.0 > Environment: MinGW (appveyor), travis CI >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Critical > Fix For: 0.11.0 > > > While adding Appveyor build support for MinGW (THRIFT-4081), this test failed > periodically. It would throw an exception in ThreadFactoryTest reapTest > where it calls monitor.wait(1000). It is reproducible locally as well if you > have msys2/mingw64 and can use the instructions in the msys2 readme in > build/cmake. The test has been disabled in mingw appveyor builds for now > (those builds are new...) > Travis CI builds are also showing an occasional failure in the test. > Need to root cause, fix, and re-enable in any CI builds where it was disabled. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (THRIFT-4106) concurrency_test fails randomly
[ https://issues.apache.org/jira/browse/THRIFT-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4106. Resolution: Fixed Fix Version/s: 0.11.0 > concurrency_test fails randomly > --- > > Key: THRIFT-4106 > URL: https://issues.apache.org/jira/browse/THRIFT-4106 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.10.0 > Environment: MinGW (appveyor), travis CI >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Critical > Fix For: 0.11.0 > > > While adding Appveyor build support for MinGW (THRIFT-4081), this test failed > periodically. It would throw an exception in ThreadFactoryTest reapTest > where it calls monitor.wait(1000). It is reproducible locally as well if you > have msys2/mingw64 and can use the instructions in the msys2 readme in > build/cmake. The test has been disabled in mingw appveyor builds for now > (those builds are new...) > Travis CI builds are also showing an occasional failure in the test. > Need to root cause, fix, and re-enable in any CI builds where it was disabled. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1343: THRIFT-4106: fix errors concurrency_test was iden...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1343 ---
[jira] [Created] (THRIFT-4317) Windows Appveyor CI builds are failing on Haskell dependency resolution
James E. King, III created THRIFT-4317:
--
Summary: Windows Appveyor CI builds are failing on Haskell
dependency resolution
Key: THRIFT-4317
URL: https://issues.apache.org/jira/browse/THRIFT-4317
Project: Thrift
Issue Type: Bug
Components: Build Process
Affects Versions: 0.11.0
Environment: Appveyor
Reporter: James E. King, III
https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/build/1.0.0-dev.1534/job/v8a5sia4lwu1e8j4
{noformat}
CustomBuild:
Building Custom Rule C:/projects/thrift/lib/hs/CMakeLists.txt
CMake does not need to re-run because
C:/projects/thrift/local-thrift-build/lib/hs/CMakeFiles/generate.stamp is
up-to-date.
Building Haskell library
Config file path source is default config file.
Config file C:\Users\appveyor\AppData\Roaming\cabal\config not found.
Writing default configuration to
C:\Users\appveyor\AppData\Roaming\cabal\config
Downloading the latest package list from hackage.haskell.org
Resolving dependencies...
cabal.exe: Could not resolve dependencies:
trying: thrift-1.0.0 (user goal)
trying: hspec-2.4.4 (dependency of thrift-1.0.0:*test)
next goal: hspec-core (dependency of thrift-1.0.0)
rejecting: hspec-core-2.4.4, hspec-core-2.4.3, hspec-core-2.4.2,
hspec-core-2.4.1, hspec-core-2.4.0 (conflict: thrift => hspec-core<2.4.0)
rejecting: hspec-core-2.3.2, hspec-core-2.3.1, hspec-core-2.3.0,
hspec-core-2.2.4, hspec-core-2.2.3, hspec-core-2.2.2, hspec-core-2.2.1,
hspec-core-2.2.0, hspec-core-2.1.10, hspec-core-2.1.9, hspec-core-2.1.8,
hspec-core-2.1.7, hspec-core-2.1.6, hspec-core-2.1.5, hspec-core-2.1.4,
hspec-core-2.1.3, hspec-core-2.1.2, hspec-core-2.1.1, hspec-core-2.1.0,
hspec-core-2.0.2, hspec-core-2.0.1, hspec-core-2.0.0 (conflict: hspec =>
hspec-core==2.4.4)
After searching the rest of the dependency tree exhaustively, these were the
goals I've had most trouble fulfilling: hspec-core, thrift, base
C:\Program Files
(x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(151,5): error
MSB6006: "cmd.exe" exited with code 1.
[C:\projects\thrift\local-thrift-build\lib\hs\haskell_library.vcxproj]
Done Building Project
"C:\projects\thrift\local-thrift-build\lib\hs\haskell_library.vcxproj" (default
targets) -- FAILED.
{noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-3775) 0.10.0 release candidate
[ https://issues.apache.org/jira/browse/THRIFT-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157233#comment-16157233 ] ASF GitHub Bot commented on THRIFT-3775: Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1323 > 0.10.0 release candidate > > > Key: THRIFT-3775 > URL: https://issues.apache.org/jira/browse/THRIFT-3775 > Project: Thrift > Issue Type: Bug > Components: Build Process >Reporter: Jake Farrell >Assignee: Jake Farrell > Fix For: 0.10.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1323: THRIFT-3775: 0.10.0 release
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1323 ---
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157001#comment-16157001
]
ASF GitHub Bot commented on THRIFT-4273:
Github user walter-weinmann commented on the issue:
https://github.com/apache/thrift/pull/1346
The checks are really tedious - I needed 5 attempts until everything had
gone through without any problems.
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Reporter: Jens Geyer
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1346 The checks are really tedious - I needed 5 attempts until everything had gone through without any problems. ---
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156913#comment-16156913
]
ASF GitHub Bot commented on THRIFT-4273:
GitHub user walter-weinmann reopened a pull request:
https://github.com/apache/thrift/pull/1346
THRIFT-4273 erlang:now/0: Deprecated BIF.
Simply following the recommendations here:
[3.7 New Time
API](http://erlang.org/doc/apps/erts/time_correction.html#id79939): How to Work
with the New API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/walter-weinmann/thrift THRIFT-4273
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1346.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1346
commit ed5ae5d0659b53e2030535469a20e46364dc2a32
Author: walter-weinmann
Date: 2017-09-07T04:14:28Z
THRIFT-4273 erlang:now/0: Deprecated BIF.
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Reporter: Jens Geyer
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156912#comment-16156912
]
ASF GitHub Bot commented on THRIFT-4273:
Github user walter-weinmann closed the pull request at:
https://github.com/apache/thrift/pull/1346
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Reporter: Jens Geyer
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156911#comment-16156911
]
ASF GitHub Bot commented on THRIFT-4273:
Github user walter-weinmann commented on the issue:
https://github.com/apache/thrift/pull/1346
Restarting the checks.
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Reporter: Jens Geyer
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1346 Restarting the checks. ---
[GitHub] thrift pull request #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1346 THRIFT-4273 erlang:now/0: Deprecated BIF. Simply following the recommendations here: [3.7 New Time API](http://erlang.org/doc/apps/erts/time_correction.html#id79939): How to Work with the New API You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-4273 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1346.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1346 commit ed5ae5d0659b53e2030535469a20e46364dc2a32 Author: walter-weinmann Date: 2017-09-07T04:14:28Z THRIFT-4273 erlang:now/0: Deprecated BIF. ---
[GitHub] thrift pull request #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1346 ---
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156857#comment-16156857
]
ASF GitHub Bot commented on THRIFT-4273:
GitHub user walter-weinmann reopened a pull request:
https://github.com/apache/thrift/pull/1346
THRIFT-4273 erlang:now/0: Deprecated BIF.
Simply following the recommendations here:
[3.7 New Time
API](http://erlang.org/doc/apps/erts/time_correction.html#id79939): How to Work
with the New API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/walter-weinmann/thrift THRIFT-4273
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1346.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1346
commit ed5ae5d0659b53e2030535469a20e46364dc2a32
Author: walter-weinmann
Date: 2017-09-07T04:14:28Z
THRIFT-4273 erlang:now/0: Deprecated BIF.
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Reporter: Jens Geyer
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156855#comment-16156855
]
ASF GitHub Bot commented on THRIFT-4273:
Github user walter-weinmann commented on the issue:
https://github.com/apache/thrift/pull/1346
Restarting the checks.
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Reporter: Jens Geyer
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156856#comment-16156856
]
ASF GitHub Bot commented on THRIFT-4273:
Github user walter-weinmann closed the pull request at:
https://github.com/apache/thrift/pull/1346
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Reporter: Jens Geyer
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift pull request #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1346 THRIFT-4273 erlang:now/0: Deprecated BIF. Simply following the recommendations here: [3.7 New Time API](http://erlang.org/doc/apps/erts/time_correction.html#id79939): How to Work with the New API You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-4273 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1346.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1346 commit ed5ae5d0659b53e2030535469a20e46364dc2a32 Author: walter-weinmann Date: 2017-09-07T04:14:28Z THRIFT-4273 erlang:now/0: Deprecated BIF. ---
[GitHub] thrift pull request #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1346 ---
[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1346 Restarting the checks. ---
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156754#comment-16156754
]
ASF GitHub Bot commented on THRIFT-4273:
Github user walter-weinmann commented on the issue:
https://github.com/apache/thrift/pull/1346
Restarting the checks.
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Reporter: Jens Geyer
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156755#comment-16156755
]
ASF GitHub Bot commented on THRIFT-4273:
Github user walter-weinmann closed the pull request at:
https://github.com/apache/thrift/pull/1346
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Reporter: Jens Geyer
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156756#comment-16156756
]
ASF GitHub Bot commented on THRIFT-4273:
GitHub user walter-weinmann reopened a pull request:
https://github.com/apache/thrift/pull/1346
THRIFT-4273 erlang:now/0: Deprecated BIF.
Simply following the recommendations here:
[3.7 New Time
API](http://erlang.org/doc/apps/erts/time_correction.html#id79939): How to Work
with the New API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/walter-weinmann/thrift THRIFT-4273
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1346.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1346
commit ed5ae5d0659b53e2030535469a20e46364dc2a32
Author: walter-weinmann
Date: 2017-09-07T04:14:28Z
THRIFT-4273 erlang:now/0: Deprecated BIF.
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Reporter: Jens Geyer
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift pull request #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1346 ---
[GitHub] thrift pull request #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1346 THRIFT-4273 erlang:now/0: Deprecated BIF. Simply following the recommendations here: [3.7 New Time API](http://erlang.org/doc/apps/erts/time_correction.html#id79939): How to Work with the New API You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-4273 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1346.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1346 commit ed5ae5d0659b53e2030535469a20e46364dc2a32 Author: walter-weinmann Date: 2017-09-07T04:14:28Z THRIFT-4273 erlang:now/0: Deprecated BIF. ---
[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1346 Restarting the checks. ---
[jira] [Commented] (THRIFT-4290) C# nullable option generates invalid code for non-required enum field with default value
[
https://issues.apache.org/jira/browse/THRIFT-4290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156750#comment-16156750
]
ASF GitHub Bot commented on THRIFT-4290:
GitHub user dsandbrink opened a pull request:
https://github.com/apache/thrift/pull/1347
THRIFT-4290: Fixed csharp:nullable code generation for non-required e…
…num fields with default values
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dsandbrink/thrift THRIFT-4290
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1347.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1347
commit 2ecf6c4631e1283b68a61f485fd57f32c2dbf0a4
Author: Dirk Sandbrink
Date: 2017-09-06T19:04:26Z
THRIFT-4290: Fixed csharp:nullable code generation for non-required enum
fields with default values
> C# nullable option generates invalid code for non-required enum field with
> default value
>
>
> Key: THRIFT-4290
> URL: https://issues.apache.org/jira/browse/THRIFT-4290
> Project: Thrift
> Issue Type: Bug
> Components: C# - Compiler
>Affects Versions: 0.9.3, 0.10.0
> Environment: Windows
>Reporter: Dirk Sandbrink
>Priority: Minor
>
> When generating C# code with the nullable option invalid setter code is
> generated for enum fields which have a default value (and thus still need an
> isset flag).
> For example use the Work struct from tutorial.thrift and add a default value
> to the enum field:
> {code:none}
> struct Work {
> 1: i32 num1 = 0,
> 2: i32 num2,
> 3: Operation op = Operation.ADD,
> 4: optional string comment,
> }
> {code}
> Then the generated code in Work.cs looks like this:
> {code:none}
> public Operation? Op
> {
> get
> {
> return _op;
> }
> set
> {
> __isset.op = true;
> this._op = value;
> }
> }
> {code}
> This code is invalid, because value is of type _Operation?_, the correct code
> should be:
> {code:none}
> public Operation? Op
> {
> get
> {
> return _op;
> }
> set
> {
> __isset.op = value.HasValue;
> if (value.HasValue) this._op = value.Value;
> }
> }
> {code}
> I believe the error is located in file t_csharp_generator.cc in function
> t_csharp_generator::generate_csharp_property:
> {code:none}
> if (ttype->is_base_type()) {
> use_nullable = ((t_base_type*)ttype)->get_base() !=
> t_base_type::TYPE_STRING;
> }
> {code}
> Here use_nullable is set to true for all base types other then string, but
> not for enums.
> A quick fix might be to add
> {code:none}
> else if (ttype->is_enum()) {
> use_nullable = true;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift pull request #1347: THRIFT-4290: Fixed csharp:nullable code generatio...
GitHub user dsandbrink opened a pull request: https://github.com/apache/thrift/pull/1347 THRIFT-4290: Fixed csharp:nullable code generation for non-required e⦠â¦num fields with default values You can merge this pull request into a Git repository by running: $ git pull https://github.com/dsandbrink/thrift THRIFT-4290 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1347.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1347 commit 2ecf6c4631e1283b68a61f485fd57f32c2dbf0a4 Author: Dirk Sandbrink Date: 2017-09-06T19:04:26Z THRIFT-4290: Fixed csharp:nullable code generation for non-required enum fields with default values ---
[jira] [Comment Edited] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156609#comment-16156609 ] Walter Weinmann edited comment on THRIFT-2289 at 9/7/17 7:30 AM: - This seems to be resolved by THRIFT-2288 and should be closed. was (Author: wwe): This seems to be resolved and should be closed. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156609#comment-16156609 ] Walter Weinmann commented on THRIFT-2289: - This seems to be resolved and should be closed. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (THRIFT-2889) stable release 0.9.2, erlang tutorial broken
[ https://issues.apache.org/jira/browse/THRIFT-2889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156603#comment-16156603 ] Walter Weinmann edited comment on THRIFT-2889 at 9/7/17 7:19 AM: - THRIFT-4313 solves the problems. was (Author: wwe): This solves the problems. > stable release 0.9.2, erlang tutorial broken > > > Key: THRIFT-2889 > URL: https://issues.apache.org/jira/browse/THRIFT-2889 > Project: Thrift > Issue Type: Bug > Components: Tutorial >Affects Versions: 0.9.2, 0.9.3 > Environment: Linux Xu 3.16.0-23-generic #31-Ubuntu SMP Tue Oct 21 > 17:56:17 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux >Reporter: skypexu > > stable release 0.9.2's erlang tutorial is simply broken: > #cd thrift-0.9.2/tutorial/erl/ > #~/thrift-0.9.2/tutorial/erl$ ./server.sh > client.erl:47: undefined macro 'tutorial_Operation_SUBTRACT' > client.erl:24: function t/0 undefined > client.erl:26: Warning: function p/1 is unused -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2889) stable release 0.9.2, erlang tutorial broken
[ https://issues.apache.org/jira/browse/THRIFT-2889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156603#comment-16156603 ] Walter Weinmann commented on THRIFT-2889: - This solves the problems. > stable release 0.9.2, erlang tutorial broken > > > Key: THRIFT-2889 > URL: https://issues.apache.org/jira/browse/THRIFT-2889 > Project: Thrift > Issue Type: Bug > Components: Tutorial >Affects Versions: 0.9.2, 0.9.3 > Environment: Linux Xu 3.16.0-23-generic #31-Ubuntu SMP Tue Oct 21 > 17:56:17 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux >Reporter: skypexu > > stable release 0.9.2's erlang tutorial is simply broken: > #cd thrift-0.9.2/tutorial/erl/ > #~/thrift-0.9.2/tutorial/erl$ ./server.sh > client.erl:47: undefined macro 'tutorial_Operation_SUBTRACT' > client.erl:24: function t/0 undefined > client.erl:26: Warning: function p/1 is unused -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Issue Comment Deleted] (THRIFT-2889) stable release 0.9.2, erlang tutorial broken
[ https://issues.apache.org/jira/browse/THRIFT-2889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walter Weinmann updated THRIFT-2889: Comment: was deleted (was: This should be solved with [THRIFT-4313|https://issues.apache.org/jira/browse/THRIFT-4313?filter=12341894].) > stable release 0.9.2, erlang tutorial broken > > > Key: THRIFT-2889 > URL: https://issues.apache.org/jira/browse/THRIFT-2889 > Project: Thrift > Issue Type: Bug > Components: Tutorial >Affects Versions: 0.9.2, 0.9.3 > Environment: Linux Xu 3.16.0-23-generic #31-Ubuntu SMP Tue Oct 21 > 17:56:17 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux >Reporter: skypexu > > stable release 0.9.2's erlang tutorial is simply broken: > #cd thrift-0.9.2/tutorial/erl/ > #~/thrift-0.9.2/tutorial/erl$ ./server.sh > client.erl:47: undefined macro 'tutorial_Operation_SUBTRACT' > client.erl:24: function t/0 undefined > client.erl:26: Warning: function p/1 is unused -- This message was sent by Atlassian JIRA (v6.4.14#64029)
AW: Thrift backward compatibility checker
Hi, the compiler has a builtin auditing utility. Enter thrift -h and look for "audit". If this is not what you mean please explain. Sent from mobile device, please ignore spelling mistakes. Von: w yishigan Gesendet: 07.09.2017 06:53 An: dev@thrift.apache.org Betreff: Thrift backward compatibility checker Hi folks, I'm looking for a tool to check the backward compatibility of thrift files. Is there any existing tool that I could use? Thank you!
[jira] [Commented] (THRIFT-2889) stable release 0.9.2, erlang tutorial broken
[ https://issues.apache.org/jira/browse/THRIFT-2889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156595#comment-16156595 ] Walter Weinmann commented on THRIFT-2889: - This should be solved with [THRIFT-4313|https://issues.apache.org/jira/browse/THRIFT-4313?filter=12341894]. > stable release 0.9.2, erlang tutorial broken > > > Key: THRIFT-2889 > URL: https://issues.apache.org/jira/browse/THRIFT-2889 > Project: Thrift > Issue Type: Bug > Components: Tutorial >Affects Versions: 0.9.2, 0.9.3 > Environment: Linux Xu 3.16.0-23-generic #31-Ubuntu SMP Tue Oct 21 > 17:56:17 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux >Reporter: skypexu > > stable release 0.9.2's erlang tutorial is simply broken: > #cd thrift-0.9.2/tutorial/erl/ > #~/thrift-0.9.2/tutorial/erl$ ./server.sh > client.erl:47: undefined macro 'tutorial_Operation_SUBTRACT' > client.erl:24: function t/0 undefined > client.erl:26: Warning: function p/1 is unused -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156582#comment-16156582
]
ASF GitHub Bot commented on THRIFT-4273:
Github user walter-weinmann commented on the issue:
https://github.com/apache/thrift/pull/1346
Restarting the checks.
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Reporter: Jens Geyer
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156584#comment-16156584
]
ASF GitHub Bot commented on THRIFT-4273:
GitHub user walter-weinmann reopened a pull request:
https://github.com/apache/thrift/pull/1346
THRIFT-4273 erlang:now/0: Deprecated BIF.
Simply following the recommendations here:
[3.7 New Time
API](http://erlang.org/doc/apps/erts/time_correction.html#id79939): How to Work
with the New API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/walter-weinmann/thrift THRIFT-4273
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1346.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1346
commit ed5ae5d0659b53e2030535469a20e46364dc2a32
Author: walter-weinmann
Date: 2017-09-07T04:14:28Z
THRIFT-4273 erlang:now/0: Deprecated BIF.
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Reporter: Jens Geyer
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4273) erlang:now/0: Deprecated BIF.
[
https://issues.apache.org/jira/browse/THRIFT-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156583#comment-16156583
]
ASF GitHub Bot commented on THRIFT-4273:
Github user walter-weinmann closed the pull request at:
https://github.com/apache/thrift/pull/1346
> erlang:now/0: Deprecated BIF.
> --
>
> Key: THRIFT-4273
> URL: https://issues.apache.org/jira/browse/THRIFT-4273
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
>Reporter: Jens Geyer
>
> {code}
> Compiled src/thrift_memory_buffer.erl
> src/thrift_reconnecting_client.erl:229: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> src/thrift_reconnecting_client.erl:231: Warning: erlang:now/0: Deprecated
> BIF. See the "Time and Time Correction in Erlang" chapter of the ERTS User's
> Guide for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift issue #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1346 Restarting the checks. ---
[GitHub] thrift pull request #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1346 THRIFT-4273 erlang:now/0: Deprecated BIF. Simply following the recommendations here: [3.7 New Time API](http://erlang.org/doc/apps/erts/time_correction.html#id79939): How to Work with the New API You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-4273 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1346.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1346 commit ed5ae5d0659b53e2030535469a20e46364dc2a32 Author: walter-weinmann Date: 2017-09-07T04:14:28Z THRIFT-4273 erlang:now/0: Deprecated BIF. ---
[GitHub] thrift pull request #1346: THRIFT-4273 erlang:now/0: Deprecated BIF.
Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1346 ---
