[GitHub] thrift issue #687: THRIFT-2974 fix optional writeToParcel
Github user coveralls commented on the issue: https://github.com/apache/thrift/pull/687 [](https://coveralls.io/builds/13246571) Changes Unknown when pulling **fb9aec028a47f14ad8377799425277f4c77a7cfe on maxspencer:patch-1** into ** on apache:master**. ---
[jira] [Commented] (THRIFT-2974) writeToParcel throws NPE for optional enum fields
[ https://issues.apache.org/jira/browse/THRIFT-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164169#comment-16164169 ] ASF GitHub Bot commented on THRIFT-2974: Github user coveralls commented on the issue: https://github.com/apache/thrift/pull/687 [](https://coveralls.io/builds/13246571) Changes Unknown when pulling **fb9aec028a47f14ad8377799425277f4c77a7cfe on maxspencer:patch-1** into ** on apache:master**. > writeToParcel throws NPE for optional enum fields > - > > Key: THRIFT-2974 > URL: https://issues.apache.org/jira/browse/THRIFT-2974 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler >Affects Versions: 0.9.2, 0.9.3 >Reporter: David Li >Assignee: Max Spencer > Fix For: 0.10.0 > > > The recent change to the Java compiler added generated Android compatible, > parcelable Thrift objects. > https://github.com/apache/thrift/commit/f9b8f5e64137248ea2a1b95312916491d23ab94a#diff-80220be8df49fb98fe5f899544d8368dR1569 > However, for optional enum fields that are null, getValue() will throw an NPE > because no checks are made that the enum is set before being written. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4260) Go context generation issue. Context is parameter in Interface not in implementation
[
https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164084#comment-16164084
]
ASF GitHub Bot commented on THRIFT-4260:
Github user taozle commented on the issue:
https://github.com/apache/thrift/pull/1312
You must use the generator compiled from the master branch.
> Go context generation issue. Context is parameter in Interface not in
> implementation
>
>
> Key: THRIFT-4260
> URL: https://issues.apache.org/jira/browse/THRIFT-4260
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.11.0
>Reporter: Bas van Beek
>Assignee: taozle
>Priority: Blocker
> Fix For: 0.11.0
>
>
> Unfortunately the Go library was updated before a new Compiler was released.
> Having thrift compiled code be part in a project prior to the thrift context
> library addition breaks due to the dependency on the thrift go library. See:
> https://github.com/openzipkin/zipkin-go-opentracing/issues/68
> I tried to resolve be installing compiler from latest source but found the
> generated source to be incorrect. The generated Go interface for the service
> client includes context.Context as the first parameter of the service method.
> The generated client implementation however does not.
> The following thrift code:
> {code:none}
> enum ResultCode
> {
> OK,
> TRY_LATER
> }
> struct LogEntry
> {
> 1: string category,
> 2: string message
> }
> service Scribe
> {
> ResultCode Log(1: list messages);
> }
> {code}
> Generated the following Go code:
> {code:none}
> type Scribe interface {
> // Parameters:
> // - Messages
> Log(ctx context.Context, messages []*LogEntry) (r ResultCode, err error)
> }
> ...
> // Parameters:
> // - Messages
> func (p *ScribeClient) Log(messages []*LogEntry) (r ResultCode, err error) {
> if err = p.sendLog(messages); err != nil {
> return
> }
> return p.recvLog()
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift issue #1312: THRIFT-4260: Add context as first arg for client method.
Github user taozle commented on the issue: https://github.com/apache/thrift/pull/1312 You must use the generator compiled from the master branch. ---
[jira] [Commented] (THRIFT-4328) Travis CI builds are timing out (job 1) and haxe builds are failing since 9/11
[ https://issues.apache.org/jira/browse/THRIFT-4328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164018#comment-16164018 ] James E. King, III commented on THRIFT-4328: [~jensg] The issue is that hxcpp 3.4.185 which came out on 9/11 no longer includes static libraries, my guess. Something about socket_init__0 not found. I pinned it to 3.4.64 which seems to have resolved it in the ubuntu-xenial image. It isn't in the centos image since centos doesn't have haxe in their repo (not that I could find anyway). This fixed the appveyor CI builds as evidenced by the appveyor PR history for apache/thrift. > Travis CI builds are timing out (job 1) and haxe builds are failing since 9/11 > -- > > Key: THRIFT-4328 > URL: https://issues.apache.org/jira/browse/THRIFT-4328 > Project: Thrift > Issue Type: Bug > Components: Build Process >Affects Versions: 0.11.0 > Environment: travis CI >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Blocker > Fix For: 0.11.0 > > > Need to split binary protocol cross tests to a new build job (previous > combination of build jobs was too aggressive). > Need to fix haxe problem with builds that starts on 9/11. Looks like a new > version of hxcpp is to blame, and pinning to the previous one resolves it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4328) Travis CI builds are timing out (job 1) and haxe builds are failing since 9/11
[ https://issues.apache.org/jira/browse/THRIFT-4328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163959#comment-16163959 ] ASF GitHub Bot commented on THRIFT-4328: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1351 Okay, I fixed concurrency_test, and it failed again! Maintaining a build system is a full time job! > Travis CI builds are timing out (job 1) and haxe builds are failing since 9/11 > -- > > Key: THRIFT-4328 > URL: https://issues.apache.org/jira/browse/THRIFT-4328 > Project: Thrift > Issue Type: Bug > Components: Build Process >Affects Versions: 0.11.0 > Environment: travis CI >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Blocker > Fix For: 0.11.0 > > > Need to split binary protocol cross tests to a new build job (previous > combination of build jobs was too aggressive). > Need to fix haxe problem with builds that starts on 9/11. Looks like a new > version of hxcpp is to blame, and pinning to the previous one resolves it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1351: THRIFT-4328: fix broken travis CI builds, enable newly r...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1351 Okay, I fixed concurrency_test, and it failed again! Maintaining a build system is a full time job! ---
[jira] [Commented] (THRIFT-4328) Travis CI builds are timing out (job 1) and haxe builds are failing since 9/11
[ https://issues.apache.org/jira/browse/THRIFT-4328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163835#comment-16163835 ] ASF GitHub Bot commented on THRIFT-4328: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1351 I tried but I can't figure that out without learning the whole ecosystem so I am going to mark the ubsan build as "failure allowed" until someone can fix THRIFT-4064. > Travis CI builds are timing out (job 1) and haxe builds are failing since 9/11 > -- > > Key: THRIFT-4328 > URL: https://issues.apache.org/jira/browse/THRIFT-4328 > Project: Thrift > Issue Type: Bug > Components: Build Process >Affects Versions: 0.11.0 > Environment: travis CI >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Blocker > Fix For: 0.11.0 > > > Need to split binary protocol cross tests to a new build job (previous > combination of build jobs was too aggressive). > Need to fix haxe problem with builds that starts on 9/11. Looks like a new > version of hxcpp is to blame, and pinning to the previous one resolves it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1351: THRIFT-4328: fix broken travis CI builds, enable newly r...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1351 I tried but I can't figure that out without learning the whole ecosystem so I am going to mark the ubsan build as "failure allowed" until someone can fix THRIFT-4064. ---
[jira] [Commented] (THRIFT-4260) Go context generation issue. Context is parameter in Interface not in implementation
[
https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163820#comment-16163820
]
ASF GitHub Bot commented on THRIFT-4260:
Github user domino14 commented on the issue:
https://github.com/apache/thrift/pull/1312
Is this in the latest version of thrift? It seems that auto-generated code
does not have `context` in its function signatures, but thrift itself requires
them, so auto-generated code does not compile with the version of thrift that
generated it!
> Go context generation issue. Context is parameter in Interface not in
> implementation
>
>
> Key: THRIFT-4260
> URL: https://issues.apache.org/jira/browse/THRIFT-4260
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.11.0
>Reporter: Bas van Beek
>Assignee: taozle
>Priority: Blocker
> Fix For: 0.11.0
>
>
> Unfortunately the Go library was updated before a new Compiler was released.
> Having thrift compiled code be part in a project prior to the thrift context
> library addition breaks due to the dependency on the thrift go library. See:
> https://github.com/openzipkin/zipkin-go-opentracing/issues/68
> I tried to resolve be installing compiler from latest source but found the
> generated source to be incorrect. The generated Go interface for the service
> client includes context.Context as the first parameter of the service method.
> The generated client implementation however does not.
> The following thrift code:
> {code:none}
> enum ResultCode
> {
> OK,
> TRY_LATER
> }
> struct LogEntry
> {
> 1: string category,
> 2: string message
> }
> service Scribe
> {
> ResultCode Log(1: list messages);
> }
> {code}
> Generated the following Go code:
> {code:none}
> type Scribe interface {
> // Parameters:
> // - Messages
> Log(ctx context.Context, messages []*LogEntry) (r ResultCode, err error)
> }
> ...
> // Parameters:
> // - Messages
> func (p *ScribeClient) Log(messages []*LogEntry) (r ResultCode, err error) {
> if err = p.sendLog(messages); err != nil {
> return
> }
> return p.recvLog()
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift issue #1312: THRIFT-4260: Add context as first arg for client method.
Github user domino14 commented on the issue: https://github.com/apache/thrift/pull/1312 Is this in the latest version of thrift? It seems that auto-generated code does not have `context` in its function signatures, but thrift itself requires them, so auto-generated code does not compile with the version of thrift that generated it! ---
[jira] [Commented] (THRIFT-3351) Publishing Dart Bindings for Thrift to Pub (pub.dartlang.org)
[ https://issues.apache.org/jira/browse/THRIFT-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163718#comment-16163718 ] Jake Farrell commented on THRIFT-3351: -- [~markerickson-wk] Does publishing to dart still require a gmail address or can we use our @apache.org email addresses for artifact publishing? > Publishing Dart Bindings for Thrift to Pub (pub.dartlang.org) > - > > Key: THRIFT-3351 > URL: https://issues.apache.org/jira/browse/THRIFT-3351 > Project: Thrift > Issue Type: Story > Components: Dart - Library >Reporter: Evan Weible >Assignee: Jake Farrell > > The thrift library for Dart has been released in 0.10.0 > In order for developers to actually make use of the library, the Dart package > needs to be published to https://pub.dartlang.org. The current workaround is > to create a new GitHub repo with a copy of the Dart thrift library, and > reference that in consuming Dart code via a Git reference, which is not ideal. > This may become a little better with Dart 1.25.0 (not released yet), which > [adds the > ability|https://github.com/dart-lang/sdk/blob/1.25.0-dev.16.3/CHANGELOG.md#tool-changes] > to reference a library in a subdirectory via git. But it would still be > better to explicitly publish releases for Dart to pub.dartlang.org. > More information here: > - https://www.dartlang.org/tools/pub/publishing > - https://www.dartlang.org/tools/pub/cmd/pub-lish.html > Since we're creating the Dart bindings for Thrift, we are also more than > willing to publish them to Pub - but we wanted to give the apache thrift team > the opportunity to handle this process. Ownership of the publishing process > can be shared by adding multiple email addresses to the uploader list, and > the uploader list can be updated at any time. It does require a Google email > address (gmail or Google Apps) to perform the upload. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1351: THRIFT-4328: fix broken travis CI builds, enable newly r...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1351 Nice, looks like this and the PR for updating the node.js versions might end up converging... ---
[jira] [Commented] (THRIFT-4328) Travis CI builds are timing out (job 1) and haxe builds are failing since 9/11
[ https://issues.apache.org/jira/browse/THRIFT-4328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163678#comment-16163678 ] ASF GitHub Bot commented on THRIFT-4328: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1351 Not sure why UBSan is failing in some javascript deploy, and still waiting for Appveyor... > Travis CI builds are timing out (job 1) and haxe builds are failing since 9/11 > -- > > Key: THRIFT-4328 > URL: https://issues.apache.org/jira/browse/THRIFT-4328 > Project: Thrift > Issue Type: Bug > Components: Build Process >Affects Versions: 0.11.0 > Environment: travis CI >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Blocker > Fix For: 0.11.0 > > > Need to split binary protocol cross tests to a new build job (previous > combination of build jobs was too aggressive). > Need to fix haxe problem with builds that starts on 9/11. Looks like a new > version of hxcpp is to blame, and pinning to the previous one resolves it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1351: THRIFT-4328: fix broken travis CI builds, enable newly r...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1351 Not sure why UBSan is failing in some javascript deploy, and still waiting for Appveyor... ---
[GitHub] thrift issue #1355: Minimal C# library version for .NET Standard 1.4, 1.6, ....
Github user gideonkorir commented on the issue: https://github.com/apache/thrift/pull/1355 @aloneguid I actually need 1.4 so if the rest of the guys here agree then we can target 1.4 as the minumum. I suggested 1.1 do that you wouldn't need to cross compile ---
[GitHub] thrift issue #1355: Minimal C# library version for .NET Standard 1.4, 1.6, ....
Github user aloneguid commented on the issue: https://github.com/apache/thrift/pull/1355 @gideonkorir 1.1 is fine unless we hit some limitations. Generally 1.4 is the "safe" version of .net standard, which can be used on embedded devices, clusters, desktops etc. However, it's not compatible with .NET 4.5, which by itself reached end of support stage, and is a pain in the neck in terms of security and compatibility. If you need to support .NET 4.5 it's generally better to cross-compile to .net standard and .net 4.5 instead of just targeting .net standard, currently I do this in https://github.com/elastacloud/parquet-dotnet ---
[jira] [Commented] (THRIFT-4328) Travis CI builds are timing out (job 1) and haxe builds are failing since 9/11
[
https://issues.apache.org/jira/browse/THRIFT-4328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163576#comment-16163576
]
Jens Geyer commented on THRIFT-4328:
{quote}haxe builds failing{quote}
Details? Can't reproduce on Suse.
> Travis CI builds are timing out (job 1) and haxe builds are failing since 9/11
> --
>
> Key: THRIFT-4328
> URL: https://issues.apache.org/jira/browse/THRIFT-4328
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.11.0
> Environment: travis CI
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Blocker
> Fix For: 0.11.0
>
>
> Need to split binary protocol cross tests to a new build job (previous
> combination of build jobs was too aggressive).
> Need to fix haxe problem with builds that starts on 9/11. Looks like a new
> version of hxcpp is to blame, and pinning to the previous one resolves it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift issue #1355: Minimal C# library version for .NET Standard 1.4, 1.6, ....
Github user gideonkorir commented on the issue: https://github.com/apache/thrift/pull/1355 @jeking3 netstandard 2.0 only targets .net framework 461 and .net core 2.0 only [see](https://github.com/dotnet/standard/blob/master/docs/versions.md). Targeting 1.1 targets a bigger audience also I think (unless I got you wrong) there is a difference between netstandard (which is a versioned set of APIs) and .net core (with is the cross platform runtime). ---
[GitHub] thrift pull request #1355: Minimal C# library version for .NET Standard 1.4,...
Github user aloneguid commented on a diff in the pull request: https://github.com/apache/thrift/pull/1355#discussion_r138439390 --- Diff: lib/csharp/src/Thrift.sln --- @@ -1,6 +1,8 @@  -Microsoft Visual Studio Solution File, Format Version 11.00 -# Visual Studio 2010 +Microsoft Visual Studio Solution File, Format Version 12.00 +# Visual Studio 15 --- End diff -- is there any strong reason for this? ---
[GitHub] thrift pull request #1355: Minimal C# library version for .NET Standard 1.4,...
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1355#discussion_r138436653 --- Diff: lib/csharp/src/Thrift.sln --- @@ -1,6 +1,8 @@  -Microsoft Visual Studio Solution File, Format Version 11.00 -# Visual Studio 2010 +Microsoft Visual Studio Solution File, Format Version 12.00 +# Visual Studio 15 --- End diff -- Note that sometime in the future we're going to remove all provided static solution files and rely solely on project creation that comes with cmake, at which point you'll pick what you want at cmake generation time. ---
[GitHub] thrift issue #1355: Minimal C# library version for .NET Standard 1.4, 1.6, ....
Github user gideonkorir commented on the issue: https://github.com/apache/thrift/pull/1355 @aloneguid can we target [netstandard 1.1](https://github.com/dotnet/standard/blob/master/docs/versions/netstandard1.1.md)? it covers .net 4.5 ---
[GitHub] thrift issue #1355: Minimal C# library version for .NET Standard 1.4, 1.6, ....
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1355 Jake does that. ---
[jira] [Resolved] (THRIFT-4317) Windows Appveyor CI builds are failing on Haskell dependency resolution
[
https://issues.apache.org/jira/browse/THRIFT-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4317.
Resolution: Duplicate
Assignee: James E. King, III
> Windows Appveyor CI builds are failing on Haskell dependency resolution
> ---
>
> Key: THRIFT-4317
> URL: https://issues.apache.org/jira/browse/THRIFT-4317
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.11.0
> Environment: Appveyor
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/build/1.0.0-dev.1534/job/v8a5sia4lwu1e8j4
> {noformat}
> CustomBuild:
> Building Custom Rule C:/projects/thrift/lib/hs/CMakeLists.txt
> CMake does not need to re-run because
> C:/projects/thrift/local-thrift-build/lib/hs/CMakeFiles/generate.stamp is
> up-to-date.
> Building Haskell library
> Config file path source is default config file.
> Config file C:\Users\appveyor\AppData\Roaming\cabal\config not found.
> Writing default configuration to
> C:\Users\appveyor\AppData\Roaming\cabal\config
> Downloading the latest package list from hackage.haskell.org
> Resolving dependencies...
> cabal.exe: Could not resolve dependencies:
> trying: thrift-1.0.0 (user goal)
> trying: hspec-2.4.4 (dependency of thrift-1.0.0:*test)
> next goal: hspec-core (dependency of thrift-1.0.0)
> rejecting: hspec-core-2.4.4, hspec-core-2.4.3, hspec-core-2.4.2,
> hspec-core-2.4.1, hspec-core-2.4.0 (conflict: thrift => hspec-core<2.4.0)
> rejecting: hspec-core-2.3.2, hspec-core-2.3.1, hspec-core-2.3.0,
> hspec-core-2.2.4, hspec-core-2.2.3, hspec-core-2.2.2, hspec-core-2.2.1,
> hspec-core-2.2.0, hspec-core-2.1.10, hspec-core-2.1.9, hspec-core-2.1.8,
> hspec-core-2.1.7, hspec-core-2.1.6, hspec-core-2.1.5, hspec-core-2.1.4,
> hspec-core-2.1.3, hspec-core-2.1.2, hspec-core-2.1.1, hspec-core-2.1.0,
> hspec-core-2.0.2, hspec-core-2.0.1, hspec-core-2.0.0 (conflict: hspec =>
> hspec-core==2.4.4)
> After searching the rest of the dependency tree exhaustively, these were the
> goals I've had most trouble fulfilling: hspec-core, thrift, base
> C:\Program Files
> (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(151,5): error
> MSB6006: "cmd.exe" exited with code 1.
> [C:\projects\thrift\local-thrift-build\lib\hs\haskell_library.vcxproj]
> Done Building Project
> "C:\projects\thrift\local-thrift-build\lib\hs\haskell_library.vcxproj"
> (default targets) -- FAILED.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4317) Windows Appveyor CI builds are failing on Haskell dependency resolution
[
https://issues.apache.org/jira/browse/THRIFT-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163476#comment-16163476
]
James E. King, III commented on THRIFT-4317:
Need to change to hspec != 2.4.0 or something, since that was buggy.
> Windows Appveyor CI builds are failing on Haskell dependency resolution
> ---
>
> Key: THRIFT-4317
> URL: https://issues.apache.org/jira/browse/THRIFT-4317
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.11.0
> Environment: Appveyor
>Reporter: James E. King, III
>
> https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/build/1.0.0-dev.1534/job/v8a5sia4lwu1e8j4
> {noformat}
> CustomBuild:
> Building Custom Rule C:/projects/thrift/lib/hs/CMakeLists.txt
> CMake does not need to re-run because
> C:/projects/thrift/local-thrift-build/lib/hs/CMakeFiles/generate.stamp is
> up-to-date.
> Building Haskell library
> Config file path source is default config file.
> Config file C:\Users\appveyor\AppData\Roaming\cabal\config not found.
> Writing default configuration to
> C:\Users\appveyor\AppData\Roaming\cabal\config
> Downloading the latest package list from hackage.haskell.org
> Resolving dependencies...
> cabal.exe: Could not resolve dependencies:
> trying: thrift-1.0.0 (user goal)
> trying: hspec-2.4.4 (dependency of thrift-1.0.0:*test)
> next goal: hspec-core (dependency of thrift-1.0.0)
> rejecting: hspec-core-2.4.4, hspec-core-2.4.3, hspec-core-2.4.2,
> hspec-core-2.4.1, hspec-core-2.4.0 (conflict: thrift => hspec-core<2.4.0)
> rejecting: hspec-core-2.3.2, hspec-core-2.3.1, hspec-core-2.3.0,
> hspec-core-2.2.4, hspec-core-2.2.3, hspec-core-2.2.2, hspec-core-2.2.1,
> hspec-core-2.2.0, hspec-core-2.1.10, hspec-core-2.1.9, hspec-core-2.1.8,
> hspec-core-2.1.7, hspec-core-2.1.6, hspec-core-2.1.5, hspec-core-2.1.4,
> hspec-core-2.1.3, hspec-core-2.1.2, hspec-core-2.1.1, hspec-core-2.1.0,
> hspec-core-2.0.2, hspec-core-2.0.1, hspec-core-2.0.0 (conflict: hspec =>
> hspec-core==2.4.4)
> After searching the rest of the dependency tree exhaustively, these were the
> goals I've had most trouble fulfilling: hspec-core, thrift, base
> C:\Program Files
> (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(151,5): error
> MSB6006: "cmd.exe" exited with code 1.
> [C:\projects\thrift\local-thrift-build\lib\hs\haskell_library.vcxproj]
> Done Building Project
> "C:\projects\thrift\local-thrift-build\lib\hs\haskell_library.vcxproj"
> (default targets) -- FAILED.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift issue #1355: Minimal C# library version for .NET Standard 1.4, 1.6, ....
Github user aloneguid commented on the issue: https://github.com/apache/thrift/pull/1355 I'm more than happy to do that. @Jens-G in .net ecosystem nuget package manager is quite popular, do you have any guidance how we can automatically publish this as you do with Maven? ---
[GitHub] thrift issue #1351: THRIFT-4328: fix broken travis CI builds, enable newly r...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1351 This is blocking #1349, among others... ---
[jira] [Created] (THRIFT-4328) Travis CI builds are timing out (job 1) and haxe builds are failing since 9/11
James E. King, III created THRIFT-4328: -- Summary: Travis CI builds are timing out (job 1) and haxe builds are failing since 9/11 Key: THRIFT-4328 URL: https://issues.apache.org/jira/browse/THRIFT-4328 Project: Thrift Issue Type: Bug Components: Build Process Affects Versions: 0.11.0 Environment: travis CI Reporter: James E. King, III Assignee: James E. King, III Priority: Blocker Fix For: 0.11.0 Need to split binary protocol cross tests to a new build job (previous combination of build jobs was too aggressive). Need to fix haxe problem with builds that starts on 9/11. Looks like a new version of hxcpp is to blame, and pinning to the previous one resolves it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1355: Minimal C# library version for .NET Standard 1.4, 1.6, ....
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1355 I'm fine with combining both flavours into one single c# library etc, as long as you don't break the c# library. The netcore lib is quite new and there's a lot of movement so we surely can throw it out and replace it by sth else. I don't see any conflicts here. Would you say that you two guys able to do that as a team and provide a suitable PR that meets that goal? ---
[GitHub] thrift issue #1355: Minimal C# library version for .NET Standard 1.4, 1.6, ....
Github user aloneguid commented on the issue: https://github.com/apache/thrift/pull/1355 @gideonkorir from what I can see .net core lib was created in times when .net core was in early stages, has some classes renamed and doesn't align with existing csharp project. There is no need to have that library, just cross-compile csharp library with modern .net core sdk. ---
[GitHub] thrift issue #1355: Minimal C# library version for .NET Standard 1.4, 1.6, ....
Github user aloneguid commented on the issue: https://github.com/apache/thrift/pull/1355 @Jens-G THRIFTCORE is a simple pre-processor directive which when set excludes files which require dependency on external libraries in .NET Standard, essentially producing a minimal library of Thrift. At the moment you have csharp library for .NET 3.5 and 4.5. Then, there is another library for .NET Core which to be honest is completely useless as it downloads so many dependencies that it's impossible to use in any web project as they quickly become conflicting. Ideally there must be just one single .NET project which cross-compiles to both .NET classic and .NET Standard. There is no need for .NET Core as .NET Standard covers it (is it maybe coming from misunderstanding of library creators in differences between .net core and .net standard?). All I'm adding is a new project referencing all existing files. The project simply excludes stuff which is not covered by least common denominator of .NET Standard 1.4, 1.6 and .NET 4.5, but allows you to use Thrift on any device. This can be carefully extended further to support all Thrift features. however it's more complicated with .NET Standard as unlike .NET it doesn't have all socketing, networking etc. built in and needs external references. I would suggest though having 1 main package with core functionality as I just did, and adding more libraries which implement specific features (sockets, web http etc.) as they require specific dependencies. ---
[GitHub] thrift issue #1355: Minimal C# library version for .NET Standard 1.4, 1.6, ....
Github user gideonkorir commented on the issue: https://github.com/apache/thrift/pull/1355 I'm also interested in a .net core lib can we upgrade the netcore project to netstandard? ---
[GitHub] thrift issue #1355: Minimal C# library version for .NET Standard 1.4, 1.6, ....
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1355 What is THRIFTCORE? Is this intended tom become another netcore library? What about the existing one? Please explain. ---
[GitHub] thrift issue #1175: THRIFT-4064 Update node library dependencies
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1175 @zertosh We're on a new build environment based on ubuntu-xenial and it's more stable, perhaps you could resurrect your work here and complete it? ---
[GitHub] thrift pull request #1175: THRIFT-4064 Update node library dependencies
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1175#discussion_r138415134
--- Diff: package.json ---
@@ -32,20 +32,22 @@
},
"main": "./lib/nodejs/lib/thrift",
"engines": {
-"node": ">= 0.2.4"
+"node": ">= 0.12.0"
},
"dependencies": {
-"node-int64": "~0.3.0",
-"q": "1.0.x",
-"ws": "~0.4.32"
+"node-int64": "^0.4.0",
+"q": "^1.0.0",
+"ws": "^1.0.0"
--- End diff --
@ledara1 I'm pretty sure this work was abandoned. We've since moved most
of the build targets to more recent distributions, but this file wasn't
updated. There is a new ubuntu-xenial docker image which, if you would be able
to update the package.json file to match, would be useful.
---
[GitHub] thrift issue #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1349 hxcpp 3.4.185 was released on 9/11 and it busted haxe builds, probably because it doesn't include static libraries any more. I will push something soon that should resolve. ---
[jira] [Commented] (THRIFT-4064) Update node library dependencies
[
https://issues.apache.org/jira/browse/THRIFT-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163280#comment-16163280
]
ASF GitHub Bot commented on THRIFT-4064:
Github user ledara1 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1175#discussion_r138406960
--- Diff: package.json ---
@@ -32,20 +32,22 @@
},
"main": "./lib/nodejs/lib/thrift",
"engines": {
-"node": ">= 0.2.4"
+"node": ">= 0.12.0"
},
"dependencies": {
-"node-int64": "~0.3.0",
-"q": "1.0.x",
-"ws": "~0.4.32"
+"node-int64": "^0.4.0",
+"q": "^1.0.0",
+"ws": "^1.0.0"
--- End diff --
It should be >=1.1.1. In this version most of security issues were fixed.
> Update node library dependencies
>
>
> Key: THRIFT-4064
> URL: https://issues.apache.org/jira/browse/THRIFT-4064
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
>Affects Versions: 0.10.0
>Reporter: Andres Suarez
> Labels: security-issue
>
> ws@0.4.32 is really old and presents issues for users using modern versions
> of Node (see
> https://github.com/apache/thrift/pull/672#issuecomment-276678791). Its should
> be updated.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift pull request #1175: THRIFT-4064 Update node library dependencies
Github user ledara1 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1175#discussion_r138406960
--- Diff: package.json ---
@@ -32,20 +32,22 @@
},
"main": "./lib/nodejs/lib/thrift",
"engines": {
-"node": ">= 0.2.4"
+"node": ">= 0.12.0"
},
"dependencies": {
-"node-int64": "~0.3.0",
-"q": "1.0.x",
-"ws": "~0.4.32"
+"node-int64": "^0.4.0",
+"q": "^1.0.0",
+"ws": "^1.0.0"
--- End diff --
It should be >=1.1.1. In this version most of security issues were fixed.
---
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163186#comment-16163186 ] ASF GitHub Bot commented on THRIFT-2289: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1349 As I said, working on it here: #1351 so you can track it. I have item 1 fixed; the others are a haxe issue I didn't see when I did the original docker image refresh and I am looking at it. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1349 As I said, working on it here: #1351 so you can track it. I have item 1 fixed; the others are a haxe issue I didn't see when I did the original docker image refresh and I am looking at it. ---
[jira] [Updated] (THRIFT-3351) Publishing Dart Bindings for Thrift to Pub (pub.dartlang.org)
[ https://issues.apache.org/jira/browse/THRIFT-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Erickson updated THRIFT-3351: -- Description: The thrift library for Dart has been released in 0.10.0 In order for developers to actually make use of the library, the Dart package needs to be published to https://pub.dartlang.org. The current workaround is to create a new GitHub repo with a copy of the Dart thrift library, and reference that in consuming Dart code via a Git reference, which is not ideal. This may become a little better with Dart 1.25.0 (not released yet), which [adds the ability|https://github.com/dart-lang/sdk/blob/1.25.0-dev.16.3/CHANGELOG.md#tool-changes] to reference a library in a subdirectory via git. But it would still be better to explicitly publish releases for Dart to pub.dartlang.org. More information here: - https://www.dartlang.org/tools/pub/publishing - https://www.dartlang.org/tools/pub/cmd/pub-lish.html Since we're creating the Dart bindings for Thrift, we are also more than willing to publish them to Pub - but we wanted to give the apache thrift team the opportunity to handle this process. Ownership of the publishing process can be shared by adding multiple email addresses to the uploader list, and the uploader list can be updated at any time. It does require a Google email address (gmail or Google Apps) to perform the upload. was: The thrift library for Dart has been released in 0.10.0 In order for developers to actually make use of the library, the Dart package needs to be published to https://pub.dartlang.org. The current workaround is to create a new GitHub repo with a copy of the Dart thrift library, and reference that in consuming Dart code via a Git reference, which is not ideal. More information here: - https://www.dartlang.org/tools/pub/publishing - https://www.dartlang.org/tools/pub/cmd/pub-lish.html Since we're creating the Dart bindings for Thrift, we are also more than willing to publish them to Pub - but we wanted to give the apache thrift team the opportunity to handle this process. Ownership of the publishing process can be shared by adding multiple email addresses to the uploader list, and the uploader list can be updated at any time. It does require a Google email address (gmail or Google Apps) to perform the upload. > Publishing Dart Bindings for Thrift to Pub (pub.dartlang.org) > - > > Key: THRIFT-3351 > URL: https://issues.apache.org/jira/browse/THRIFT-3351 > Project: Thrift > Issue Type: Story > Components: Dart - Library >Reporter: Evan Weible >Assignee: Jake Farrell > > The thrift library for Dart has been released in 0.10.0 > In order for developers to actually make use of the library, the Dart package > needs to be published to https://pub.dartlang.org. The current workaround is > to create a new GitHub repo with a copy of the Dart thrift library, and > reference that in consuming Dart code via a Git reference, which is not ideal. > This may become a little better with Dart 1.25.0 (not released yet), which > [adds the > ability|https://github.com/dart-lang/sdk/blob/1.25.0-dev.16.3/CHANGELOG.md#tool-changes] > to reference a library in a subdirectory via git. But it would still be > better to explicitly publish releases for Dart to pub.dartlang.org. > More information here: > - https://www.dartlang.org/tools/pub/publishing > - https://www.dartlang.org/tools/pub/cmd/pub-lish.html > Since we're creating the Dart bindings for Thrift, we are also more than > willing to publish them to Pub - but we wanted to give the apache thrift team > the opportunity to handle this process. Ownership of the publishing process > can be shared by adding multiple email addresses to the uploader list, and > the uploader list can be updated at any time. It does require a Google email > address (gmail or Google Apps) to perform the upload. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly...
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Problem step 1: ==  Problem step 4: ==  Problem step 11: ===  ---
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163143#comment-16163143 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Problem step 1: ==  Problem step 4: ==  Problem step 11: ===  > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4321) Migrate to new project format and enable CI
[ https://issues.apache.org/jira/browse/THRIFT-4321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163087#comment-16163087 ] Ivan commented on THRIFT-4321: -- Raised a PR for this https://github.com/apache/thrift/pull/1355 > Migrate to new project format and enable CI > --- > > Key: THRIFT-4321 > URL: https://issues.apache.org/jira/browse/THRIFT-4321 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Library >Reporter: Ivan > > Current library is still using old project structure (project.json) which is > slightly outdated and needs to be migrated to new MSBuild format. > In addition to that, I'd like to have separate packages build for different > .NET Standard versions starting from 1.4 (UWP) and up to 2.0 with full > feature set. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1355: Minimal C# library version for .NET Standard 1.4,...
GitHub user aloneguid opened a pull request: https://github.com/apache/thrift/pull/1355 Minimal C# library version for .NET Standard 1.4, 1.6, .NET 4.5.1 This adds another project type to C# library which allows it to be build for .NET Standard 1.4, 1.6 and .NET 4.5.1. The project turns off all dependencies (only the new project, existing ones are untouched) to build the core thrift library. You can merge this pull request into a Git repository by running: $ git pull https://github.com/aloneguid/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1355.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1355 commit 6f46cdd2379eaf128108f5caad731ceb30e352d0 Author: Ivan Gavryliuk Date: 2017-09-12T14:52:41Z Create a minimal C# library version for .NET Standard 1.4, 1.6 and .NET 4.5.1 ---
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162991#comment-16162991 ] ASF GitHub Bot commented on THRIFT-2289: GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1349 THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expec… …ts true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1349 commit 09a5ccec4e4640a07035b42ae747a5f408429560 Author: walter-weinmann Date: 2017-09-07T19:25:49Z THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol ...
GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1349 THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expec⦠â¦ts true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1349 commit 09a5ccec4e4640a07035b42ae747a5f408429560 Author: walter-weinmann Date: 2017-09-07T19:25:49Z THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools ---
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162979#comment-16162979 ] ASF GitHub Bot commented on THRIFT-2289: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1349 Working on it here: #1351 so you can track it. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1349 Working on it here: #1351 so you can track it. ---
[GitHub] thrift issue #1351: enable reliable cross tests (ran 5 times clean)
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1351 I split the binary cross tests out into a separate job to resolve the timeout on build job 1. I am looking at the haxe issues as well and will likely push another update. ---
[jira] [Updated] (THRIFT-3351) Publishing Dart Bindings for Thrift to Pub (pub.dartlang.org)
[ https://issues.apache.org/jira/browse/THRIFT-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Erickson updated THRIFT-3351: -- Description: The thrift library for Dart has been released in 0.10.0 In order for developers to actually make use of the library, the Dart package needs to be published to https://pub.dartlang.org. The current workaround is to create a new GitHub repo with a copy of the Dart thrift library, and reference that in consuming Dart code via a Git reference, which is not ideal. More information here: - https://www.dartlang.org/tools/pub/publishing - https://www.dartlang.org/tools/pub/cmd/pub-lish.html Since we're creating the Dart bindings for Thrift, we are also more than willing to publish them to Pub - but we wanted to give the apache thrift team the opportunity to handle this process. Ownership of the publishing process can be shared by adding multiple email addresses to the uploader list, and the uploader list can be updated at any time. It does require a Google email address (gmail or Google Apps) to perform the upload. was: The thrift library for Dart has been released in 0.10.0 In order for developers to actually make use of the library, the Dart package needs to be published to https://pub.dartlang.org. More information here: - https://www.dartlang.org/tools/pub/publishing - https://www.dartlang.org/tools/pub/cmd/pub-lish.html Since we're creating the Dart bindings for Thrift, we are also more than willing to publish them to Pub - but we wanted to give the apache thrift team the opportunity to handle this process. Ownership of the publishing process can be shared by adding multiple email addresses to the uploader list, and the uploader list can be updated at any time. It does require a Google email address (gmail or Google Apps) to perform the upload. > Publishing Dart Bindings for Thrift to Pub (pub.dartlang.org) > - > > Key: THRIFT-3351 > URL: https://issues.apache.org/jira/browse/THRIFT-3351 > Project: Thrift > Issue Type: Story > Components: Dart - Library >Reporter: Evan Weible >Assignee: Jake Farrell > > The thrift library for Dart has been released in 0.10.0 > In order for developers to actually make use of the library, the Dart package > needs to be published to https://pub.dartlang.org. The current workaround is > to create a new GitHub repo with a copy of the Dart thrift library, and > reference that in consuming Dart code via a Git reference, which is not ideal. > More information here: > - https://www.dartlang.org/tools/pub/publishing > - https://www.dartlang.org/tools/pub/cmd/pub-lish.html > Since we're creating the Dart bindings for Thrift, we are also more than > willing to publish them to Pub - but we wanted to give the apache thrift team > the opportunity to handle this process. Ownership of the publishing process > can be shared by adding multiple email addresses to the uploader list, and > the uploader list can be updated at any time. It does require a Google email > address (gmail or Google Apps) to perform the upload. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (THRIFT-3351) Publishing Dart Bindings for Thrift to Pub (pub.dartlang.org)
[ https://issues.apache.org/jira/browse/THRIFT-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Erickson updated THRIFT-3351: -- Description: The thrift library for Dart has been released in 0.10.0 In order for developers to actually make use of the library, the Dart package needs to be published to https://pub.dartlang.org. More information here: - https://www.dartlang.org/tools/pub/publishing - https://www.dartlang.org/tools/pub/cmd/pub-lish.html Since we're creating the Dart bindings for Thrift, we are also more than willing to publish them to Pub - but we wanted to give the apache thrift team the opportunity to handle this process. Ownership of the publishing process can be shared by adding multiple email addresses to the uploader list, and the uploader list can be updated at any time. It does require a Google email address (gmail or Google Apps) to perform the upload. was: The thrift bindings for the Dart language are in progress here: https://github.com/apache/thrift/pull/608 In order to utilize them in Dart, the Dart package would need to be published to https://pub.dartlang.org. This is a relatively simple process - from the `thrift/lib/dart/` directory it would only require running `pub publish`. More information here: - https://www.dartlang.org/tools/pub/publishing - https://www.dartlang.org/tools/pub/cmd/pub-lish.html Since we're creating the Dart bindings for Thrift, we are also more than willing to publish them to Pub - but we wanted to give the apache thrift team the opportunity to handle this process. Ownership of the publishing process can be shared by adding multiple email addresses to the uploader list, and said list can be updated at any time. How do you wish to proceed with this? > Publishing Dart Bindings for Thrift to Pub (pub.dartlang.org) > - > > Key: THRIFT-3351 > URL: https://issues.apache.org/jira/browse/THRIFT-3351 > Project: Thrift > Issue Type: Story > Components: Dart - Library >Reporter: Evan Weible >Assignee: Jake Farrell > > The thrift library for Dart has been released in 0.10.0 > In order for developers to actually make use of the library, the Dart package > needs to be published to https://pub.dartlang.org. > More information here: > - https://www.dartlang.org/tools/pub/publishing > - https://www.dartlang.org/tools/pub/cmd/pub-lish.html > Since we're creating the Dart bindings for Thrift, we are also more than > willing to publish them to Pub - but we wanted to give the apache thrift team > the opportunity to handle this process. Ownership of the publishing process > can be shared by adding multiple email addresses to the uploader list, and > the uploader list can be updated at any time. It does require a Google email > address (gmail or Google Apps) to perform the upload. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (THRIFT-3351) Publishing Dart Bindings for Thrift to Pub (pub.dartlang.org)
[ https://issues.apache.org/jira/browse/THRIFT-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Erickson updated THRIFT-3351: -- Description: The thrift bindings for the Dart language are in progress here: https://github.com/apache/thrift/pull/608 In order to utilize them in Dart, the Dart package would need to be published to https://pub.dartlang.org. This is a relatively simple process - from the `thrift/lib/dart/` directory it would only require running `pub publish`. More information here: - https://www.dartlang.org/tools/pub/publishing - https://www.dartlang.org/tools/pub/cmd/pub-lish.html Since we're creating the Dart bindings for Thrift, we are also more than willing to publish them to Pub - but we wanted to give the apache thrift team the opportunity to handle this process. Ownership of the publishing process can be shared by adding multiple email addresses to the uploader list, and said list can be updated at any time. How do you wish to proceed with this? was: The thrift bindings for the Dart language are in progress here: https://github.com/apache/thrift/pull/608 In order to utilize them in Dart, the Dart package would need to be published to https://pub.dartlang.org. This is a relatively simple process - from the `thrift/lib/dart/` directory it would only require running `pub publish`. More information here: https://www.dartlang.org/tools/pub/cmd/pub-lish.html Since we're creating the Dart bindings for Thrift, we are also more than willing to publish them to Pub - but we wanted to give the apache thrift team the opportunity to handle this process. Ownership of the publishing process can be shared by adding multiple email addresses to the uploader list, and said list can be updated at any time. How do you wish to proceed with this? > Publishing Dart Bindings for Thrift to Pub (pub.dartlang.org) > - > > Key: THRIFT-3351 > URL: https://issues.apache.org/jira/browse/THRIFT-3351 > Project: Thrift > Issue Type: Story > Components: Dart - Library >Reporter: Evan Weible >Assignee: Jake Farrell > > The thrift bindings for the Dart language are in progress here: > https://github.com/apache/thrift/pull/608 > In order to utilize them in Dart, the Dart package would need to be published > to https://pub.dartlang.org. This is a relatively simple process - from the > `thrift/lib/dart/` directory it would only require running `pub publish`. > More information here: > - https://www.dartlang.org/tools/pub/publishing > - https://www.dartlang.org/tools/pub/cmd/pub-lish.html > Since we're creating the Dart bindings for Thrift, we are also more than > willing to publish them to Pub - but we wanted to give the apache thrift team > the opportunity to handle this process. Ownership of the publishing process > can be shared by adding multiple email addresses to the uploader list, and > said list can be updated at any time. > How do you wish to proceed with this? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1327: make thrift error:class ‘apache::thrift::transp...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1327 ---
[GitHub] thrift issue #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly...
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Waiting for configuration changes in Travis. ---
[GitHub] thrift pull request #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol ...
Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1349 ---
[GitHub] thrift issue #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1349 I recently combined too many cross tests into Job #1. I have to split one of the protocols (probably binary) out to its own job in order to resolve the timing out cross test. I'll have a PR submitted for that shortly. In the meantime please stop making new builds. I'll let you know when you can rebase. ---
[jira] [Comment Edited] (THRIFT-4320) Use interface instead of strict http.Client type in THttpClientOptions
[
https://issues.apache.org/jira/browse/THRIFT-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162813#comment-16162813
]
Can Celasun edited comment on THRIFT-4320 at 9/12/17 11:29 AM:
---
On second thought, this isn't necessary. In {{http_client.go}} we have a type,
{{THttpClientOptions}}, which can be used to pass a custom a client. You can
also choose to override the exported {{DefaultHttpClient}}.
[~jensg] wontfix?
was (Author: calcifer):
On second thought, this isn't necessary. In {{http_client.go}} we have a type,
{{THttpClientOptions}}, which can be used to pass a custom a client. You can
also choose to override the exported {{DefaultHttpClient}}.
> Use interface instead of strict http.Client type in THttpClientOptions
> --
>
> Key: THRIFT-4320
> URL: https://issues.apache.org/jira/browse/THRIFT-4320
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Library
>Reporter: Marek Brysa
>Priority: Minor
>
> {{THttpClientOptions}} (http_client.go) takes a strict {{http.Client}} type
> which disallows developers from customizing http.Client or providing their
> own implementation. I propose to replace this with an interface such as:
> {code}
> type HttpClient interface {
> Do(req *http.Request) (*http.Response, error)
> }
> {code}
> {{Do()}} is the only function of http.Client that is used (in
> {{THttpClient.Flush()}}).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (THRIFT-4320) Use interface instead of strict http.Client type in THttpClientOptions
[
https://issues.apache.org/jira/browse/THRIFT-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Can Celasun reassigned THRIFT-4320:
---
Assignee: (was: Can Celasun)
> Use interface instead of strict http.Client type in THttpClientOptions
> --
>
> Key: THRIFT-4320
> URL: https://issues.apache.org/jira/browse/THRIFT-4320
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Library
>Reporter: Marek Brysa
>Priority: Minor
>
> {{THttpClientOptions}} (http_client.go) takes a strict {{http.Client}} type
> which disallows developers from customizing http.Client or providing their
> own implementation. I propose to replace this with an interface such as:
> {code}
> type HttpClient interface {
> Do(req *http.Request) (*http.Response, error)
> }
> {code}
> {{Do()}} is the only function of http.Client that is used (in
> {{THttpClient.Flush()}}).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4320) Use interface instead of strict http.Client type in THttpClientOptions
[
https://issues.apache.org/jira/browse/THRIFT-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162813#comment-16162813
]
Can Celasun commented on THRIFT-4320:
-
On second thought, this isn't necessary. In {{http_client.go}} we have a type,
{{THttpClientOptions}}, which can be used to pass a custom a client. You can
also choose to override the exported {{DefaultHttpClient}}.
> Use interface instead of strict http.Client type in THttpClientOptions
> --
>
> Key: THRIFT-4320
> URL: https://issues.apache.org/jira/browse/THRIFT-4320
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Library
>Reporter: Marek Brysa
>Assignee: Can Celasun
>Priority: Minor
>
> {{THttpClientOptions}} (http_client.go) takes a strict {{http.Client}} type
> which disallows developers from customizing http.Client or providing their
> own implementation. I propose to replace this with an interface such as:
> {code}
> type HttpClient interface {
> Do(req *http.Request) (*http.Response, error)
> }
> {code}
> {{Do()}} is the only function of http.Client that is used (in
> {{THttpClient.Flush()}}).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift pull request #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol ...
GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1349 THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expec⦠â¦ts true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1349 commit 09a5ccec4e4640a07035b42ae747a5f408429560 Author: walter-weinmann Date: 2017-09-07T19:25:49Z THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools ---
[GitHub] thrift issue #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly...
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Restarting checks. ---
[GitHub] thrift pull request #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol ...
Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1349 ---
[GitHub] thrift issue #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly...
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Restarting checks. ---
[GitHub] thrift pull request #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol ...
GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1349 THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expec⦠â¦ts true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1349 commit 09a5ccec4e4640a07035b42ae747a5f408429560 Author: walter-weinmann Date: 2017-09-07T19:25:49Z THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools ---
[GitHub] thrift pull request #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol ...
Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1349 ---
[GitHub] thrift pull request #1292: Using PHP56 const property for contant variables.
Github user Skarlso closed the pull request at: https://github.com/apache/thrift/pull/1292 ---
[GitHub] thrift pull request #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol ...
Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1349 ---
[GitHub] thrift issue #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly...
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Restarting checks. ---
[GitHub] thrift pull request #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol ...
GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1349 THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expec⦠â¦ts true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1349 commit 09a5ccec4e4640a07035b42ae747a5f408429560 Author: walter-weinmann Date: 2017-09-07T19:25:49Z THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools ---
[GitHub] thrift pull request #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol ...
Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1349 ---
[GitHub] thrift issue #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly...
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Restarting checks. ---
[GitHub] thrift pull request #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol ...
GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1349 THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expec⦠â¦ts true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1349 commit 09a5ccec4e4640a07035b42ae747a5f408429560 Author: walter-weinmann Date: 2017-09-07T19:25:49Z THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools ---
[GitHub] thrift pull request #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol ...
GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1349 THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expec⦠â¦ts true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1349 commit 09a5ccec4e4640a07035b42ae747a5f408429560 Author: walter-weinmann Date: 2017-09-07T19:25:49Z THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools ---
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162620#comment-16162620 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Restarting checks. > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol ...
Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1349 ---
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162622#comment-16162622 ] ASF GitHub Bot commented on THRIFT-2289: GitHub user walter-weinmann reopened a pull request: https://github.com/apache/thrift/pull/1349 THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expec… …ts true/false for bools You can merge this pull request into a Git repository by running: $ git pull https://github.com/walter-weinmann/thrift THRIFT-2289 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1349.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1349 commit 09a5ccec4e4640a07035b42ae747a5f408429560 Author: walter-weinmann Date: 2017-09-07T19:25:49Z THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-2289) Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for bools
[ https://issues.apache.org/jira/browse/THRIFT-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162621#comment-16162621 ] ASF GitHub Bot commented on THRIFT-2289: Github user walter-weinmann closed the pull request at: https://github.com/apache/thrift/pull/1349 > Erlang impl of Thrift JSON protocol wrongly writes/expects true/false for > bools > --- > > Key: THRIFT-2289 > URL: https://issues.apache.org/jira/browse/THRIFT-2289 > Project: Thrift > Issue Type: Bug > Components: Erlang - Library >Affects Versions: 0.9.1 >Reporter: Jens Geyer > > Some implementations of Thrift JSON protocol wrongly write and expect > true/false for bools, instead of 0/1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1349: THRIFT-2289: Erlang impl of Thrift JSON protocol wrongly...
Github user walter-weinmann commented on the issue: https://github.com/apache/thrift/pull/1349 Restarting checks. ---
