[jira] [Commented] (THRIFT-4049) Skip() should throw TProtocolException.INVALID_DATA on unknown data types

2017-09-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178074#comment-16178074
 ] 

ASF GitHub Bot commented on THRIFT-4049:


GitHub user jeking3 opened a pull request:

https://github.com/apache/thrift/pull/1371

THRIFT-4049, THRIFT-4053: when skipping, if field type is invalid thr…

…ow a protocol exception of invalid data instead of doing nothing

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jeking3/thrift THRIFT-4049

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1371.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1371


commit 67e2884cf582064490f9a90cc68fd34ef4c106fb
Author: James E. King, III 
Date:   2017-09-24T04:20:08Z

THRIFT-4049, THRIFT-4053: when skipping, if field type is invalid throw a 
protocol exception of invalid data instead of doing nothing




> Skip() should throw TProtocolException.INVALID_DATA on unknown data types
> -
>
> Key: THRIFT-4049
> URL: https://issues.apache.org/jira/browse/THRIFT-4049
> Project: Thrift
>  Issue Type: Sub-task
>  Components: C++ - Library
>Reporter: Jens Geyer
>Assignee: James E. King, III
> Fix For: 0.11.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift pull request #1371: THRIFT-4049, THRIFT-4053: when skipping, if field...

2017-09-23 Thread jeking3 
GitHub user jeking3 opened a pull request:

https://github.com/apache/thrift/pull/1371

THRIFT-4049, THRIFT-4053: when skipping, if field type is invalid thr…

…ow a protocol exception of invalid data instead of doing nothing

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jeking3/thrift THRIFT-4049

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1371.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1371


commit 67e2884cf582064490f9a90cc68fd34ef4c106fb
Author: James E. King, III 
Date:   2017-09-24T04:20:08Z

THRIFT-4049, THRIFT-4053: when skipping, if field type is invalid throw a 
protocol exception of invalid data instead of doing nothing




---

[jira] [Assigned] (THRIFT-4049) Skip() should throw TProtocolException.INVALID_DATA on unknown data types

2017-09-23 Thread James E. King, III (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III reassigned THRIFT-4049:
--

Assignee: James E. King, III

> Skip() should throw TProtocolException.INVALID_DATA on unknown data types
> -
>
> Key: THRIFT-4049
> URL: https://issues.apache.org/jira/browse/THRIFT-4049
> Project: Thrift
>  Issue Type: Sub-task
>  Components: C++ - Library
>Reporter: Jens Geyer
>Assignee: James E. King, III
> Fix For: 0.11.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (THRIFT-4050) Skip() should throw TProtocolException.INVALID_DATA on unknown data types

2017-09-23 Thread James E. King, III (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III reassigned THRIFT-4050:
--

Assignee: Gonzalo Aguilar

> Skip() should throw TProtocolException.INVALID_DATA on unknown data types
> -
>
> Key: THRIFT-4050
> URL: https://issues.apache.org/jira/browse/THRIFT-4050
> Project: Thrift
>  Issue Type: Sub-task
>  Components: C glib - Library
>Reporter: Jens Geyer
>Assignee: Gonzalo Aguilar
> Fix For: 0.11.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4050) Skip() should throw TProtocolException.INVALID_DATA on unknown data types

2017-09-23 Thread James E. King, III (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178073#comment-16178073
 ] 

James E. King, III commented on THRIFT-4050:


[~gad] would you be able to add the necessary change here for c_glib?

> Skip() should throw TProtocolException.INVALID_DATA on unknown data types
> -
>
> Key: THRIFT-4050
> URL: https://issues.apache.org/jira/browse/THRIFT-4050
> Project: Thrift
>  Issue Type: Sub-task
>  Components: C glib - Library
>Reporter: Jens Geyer
> Fix For: 0.11.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (THRIFT-4053) Skip() should throw TProtocolException.INVALID_DATA on unknown data types

2017-09-23 Thread James E. King, III (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III reassigned THRIFT-4053:
--

Assignee: James E. King, III

> Skip() should throw TProtocolException.INVALID_DATA on unknown data types
> -
>
> Key: THRIFT-4053
> URL: https://issues.apache.org/jira/browse/THRIFT-4053
> Project: Thrift
>  Issue Type: Sub-task
>  Components: Java - Library
>Reporter: Jens Geyer
>Assignee: James E. King, III
> Fix For: 0.11.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4207) Accelerated version of TBinaryProtocol allows invalid input to string fields.

2017-09-23 Thread James E. King, III (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178070#comment-16178070
 ] 

James E. King, III commented on THRIFT-4207:


You didn't enable push rights for committers so I cannot refresh your pull 
request for you, so if you could do it I would appreciate it.

> Accelerated version of TBinaryProtocol allows invalid input to string fields.
> -
>
> Key: THRIFT-4207
> URL: https://issues.apache.org/jira/browse/THRIFT-4207
> Project: Thrift
>  Issue Type: Bug
>  Components: Python - Library
>Affects Versions: 0.10.0
>Reporter: Elvis Pranskevichus
> Fix For: 0.11.0
>
>
> {{TBinaryProtocolAccelerated}} and {{TCompactProtocolAccelerated}} currently 
> accept arbitrary bytes as input to string fields even when {{py:utf8strings}} 
> is on.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4229) Make thrift-maven-plugin threadSafe

2017-09-23 Thread James E. King, III (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178068#comment-16178068
 ] 

James E. King, III commented on THRIFT-4229:


Does anyone have a patch to provide to resolve this, perhaps?

> Make thrift-maven-plugin threadSafe
> ---
>
> Key: THRIFT-4229
> URL: https://issues.apache.org/jira/browse/THRIFT-4229
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.9.3, 0.10.0
> Environment: Maven 3.5
> org.apache.thrift:thrift-maven-plugin:0.9.3
>  org.apache.thrift
>  thrift-maven-plugin
>  0.9.3
>Reporter: Ahmet Bolac
>  Labels: Third-party
> Attachments: screenshot-1.png
>
>
> We are seeing a warning in our build using Maven 3.5 as following:
> {noformat}
> [WARNING] *
> [WARNING] * Your build is requesting parallel execution, but project  *
> [WARNING] * contains the following plugin(s) that have goals not marked   *
> [WARNING] * as @threadSafe to support parallel building.  *
> [WARNING] * While this /may/ work fine, please look for plugin updates*
> [WARNING] * and/or request plugins be made thread-safe.   *
> [WARNING] * If reporting an issue, report it against the plugin in*
> [WARNING] * question, not against maven-core  *
> [WARNING] *
> [WARNING] The following plugins are not marked @threadSafe in drive-thrift:
> [WARNING] org.apache.thrift.tools:maven-thrift-plugin:0.1.11
> [WARNING] Enable debug to see more precisely which goals are not marked 
> @threadSafe.
> [WARNING] *
> {noformat}
> which indicates the plugin is not thread-safe.
> Is it possible to address this in the next version so it is thread-safe (and 
> marked as such) and does not trigger this warning anymore?
> Thanks



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (THRIFT-4229) Make thrift-maven-plugin threadSafe

2017-09-23 Thread James E. King, III (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III updated THRIFT-4229:
---
Affects Version/s: (was: 0.11.0)

> Make thrift-maven-plugin threadSafe
> ---
>
> Key: THRIFT-4229
> URL: https://issues.apache.org/jira/browse/THRIFT-4229
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.9.3, 0.10.0
> Environment: Maven 3.5
> org.apache.thrift:thrift-maven-plugin:0.9.3
>  org.apache.thrift
>  thrift-maven-plugin
>  0.9.3
>Reporter: Ahmet Bolac
>  Labels: Third-party
> Attachments: screenshot-1.png
>
>
> We are seeing a warning in our build using Maven 3.5 as following:
> {noformat}
> [WARNING] *
> [WARNING] * Your build is requesting parallel execution, but project  *
> [WARNING] * contains the following plugin(s) that have goals not marked   *
> [WARNING] * as @threadSafe to support parallel building.  *
> [WARNING] * While this /may/ work fine, please look for plugin updates*
> [WARNING] * and/or request plugins be made thread-safe.   *
> [WARNING] * If reporting an issue, report it against the plugin in*
> [WARNING] * question, not against maven-core  *
> [WARNING] *
> [WARNING] The following plugins are not marked @threadSafe in drive-thrift:
> [WARNING] org.apache.thrift.tools:maven-thrift-plugin:0.1.11
> [WARNING] Enable debug to see more precisely which goals are not marked 
> @threadSafe.
> [WARNING] *
> {noformat}
> which indicates the plugin is not thread-safe.
> Is it possible to address this in the next version so it is thread-safe (and 
> marked as such) and does not trigger this warning anymore?
> Thanks



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (THRIFT-4229) Make thrift-maven-plugin threadSafe

2017-09-23 Thread James E. King, III (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III updated THRIFT-4229:
---
Fix Version/s: (was: 0.11.0)

> Make thrift-maven-plugin threadSafe
> ---
>
> Key: THRIFT-4229
> URL: https://issues.apache.org/jira/browse/THRIFT-4229
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.9.3, 0.10.0
> Environment: Maven 3.5
> org.apache.thrift:thrift-maven-plugin:0.9.3
>  org.apache.thrift
>  thrift-maven-plugin
>  0.9.3
>Reporter: Ahmet Bolac
>  Labels: Third-party
> Attachments: screenshot-1.png
>
>
> We are seeing a warning in our build using Maven 3.5 as following:
> {noformat}
> [WARNING] *
> [WARNING] * Your build is requesting parallel execution, but project  *
> [WARNING] * contains the following plugin(s) that have goals not marked   *
> [WARNING] * as @threadSafe to support parallel building.  *
> [WARNING] * While this /may/ work fine, please look for plugin updates*
> [WARNING] * and/or request plugins be made thread-safe.   *
> [WARNING] * If reporting an issue, report it against the plugin in*
> [WARNING] * question, not against maven-core  *
> [WARNING] *
> [WARNING] The following plugins are not marked @threadSafe in drive-thrift:
> [WARNING] org.apache.thrift.tools:maven-thrift-plugin:0.1.11
> [WARNING] Enable debug to see more precisely which goals are not marked 
> @threadSafe.
> [WARNING] *
> {noformat}
> which indicates the plugin is not thread-safe.
> Is it possible to address this in the next version so it is thread-safe (and 
> marked as such) and does not trigger this warning anymore?
> Thanks



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (THRIFT-4229) Make thrift-maven-plugin threadSafe

2017-09-23 Thread James E. King, III (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III updated THRIFT-4229:
---
Component/s: Build Process

> Make thrift-maven-plugin threadSafe
> ---
>
> Key: THRIFT-4229
> URL: https://issues.apache.org/jira/browse/THRIFT-4229
> Project: Thrift
>  Issue Type: Bug
>  Components: Build Process
>Affects Versions: 0.9.3, 0.10.0
> Environment: Maven 3.5
> org.apache.thrift:thrift-maven-plugin:0.9.3
>  org.apache.thrift
>  thrift-maven-plugin
>  0.9.3
>Reporter: Ahmet Bolac
>  Labels: Third-party
> Attachments: screenshot-1.png
>
>
> We are seeing a warning in our build using Maven 3.5 as following:
> {noformat}
> [WARNING] *
> [WARNING] * Your build is requesting parallel execution, but project  *
> [WARNING] * contains the following plugin(s) that have goals not marked   *
> [WARNING] * as @threadSafe to support parallel building.  *
> [WARNING] * While this /may/ work fine, please look for plugin updates*
> [WARNING] * and/or request plugins be made thread-safe.   *
> [WARNING] * If reporting an issue, report it against the plugin in*
> [WARNING] * question, not against maven-core  *
> [WARNING] *
> [WARNING] The following plugins are not marked @threadSafe in drive-thrift:
> [WARNING] org.apache.thrift.tools:maven-thrift-plugin:0.1.11
> [WARNING] Enable debug to see more precisely which goals are not marked 
> @threadSafe.
> [WARNING] *
> {noformat}
> which indicates the plugin is not thread-safe.
> Is it possible to address this in the next version so it is thread-safe (and 
> marked as such) and does not trigger this warning anymore?
> Thanks



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4000) Add union test to Test Suite

2017-09-23 Thread James E. King, III (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178067#comment-16178067
 ] 

James E. King, III commented on THRIFT-4000:


Committed but reopened?

> Add union test to Test Suite
> 
>
> Key: THRIFT-4000
> URL: https://issues.apache.org/jira/browse/THRIFT-4000
> Project: Thrift
>  Issue Type: Improvement
>  Components: Test Suite
>Reporter: Jens Geyer
>Assignee: Jens Geyer
> Fix For: 0.11.0
>
>
> Thrift.test and all implementations lack a testcase for {{union}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4026) TSSLSocket doesn't work with Python < 2.7.9

2017-09-23 Thread James E. King, III (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178066#comment-16178066
 ] 

James E. King, III commented on THRIFT-4026:


Current CI job uses Python 2.7.12.

> TSSLSocket doesn't work with Python < 2.7.9
> ---
>
> Key: THRIFT-4026
> URL: https://issues.apache.org/jira/browse/THRIFT-4026
> Project: Thrift
>  Issue Type: Bug
>  Components: Python - Library
>Affects Versions: 0.10.0
> Environment: Python 2.7.5
>Reporter: Benoit Sigoure
>Assignee: Aki Sukegawa
> Fix For: 0.11.0
>
>
> As a result of a change made in THRIFT-3917, {{TSSLSocket}} now fails with a 
> {{TypeError}} in {{open()}}:
> {code}
>   File 
> "/bld/thrift/Artools-rpmbuild/thrift-0.10.0/lib/py/build/lib.linux-i686-2.7/thrift/transport/TSSLSocket.py",
>  line 293, in open
> self._validate_callback(self.peercert, self._server_hostname)
> TypeError: legacy_validate_callback() takes exactly 3 arguments (2 given)
> {code}
> Indeed, {{legacy_validate_callback()}} takes an extra {{self}} argument, 
> which cannot possibly be compatible with the signature of 
> [{{ssl.match_hostname()}}|https://docs.python.org/3/library/ssl.html#ssl.match_hostname]
>  (which was added in Python 3.2).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (THRIFT-4028) Please remove System.out.format from the source code

2017-09-23 Thread James E. King, III (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-4028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III closed THRIFT-4028.
--
Resolution: Duplicate
  Assignee: James E. King, III

> Please remove System.out.format from the source code
> 
>
> Key: THRIFT-4028
> URL: https://issues.apache.org/jira/browse/THRIFT-4028
> Project: Thrift
>  Issue Type: Task
>  Components: Java - Library
>Affects Versions: 0.10.0
>Reporter: Arthur Du
>Assignee: James E. King, III
>Priority: Trivial
> Fix For: 0.11.0
>
>
> thrift-0.10.0/lib/java/src/org/apache/thrift/TServiceClient.java
> line 84:
> System.out.format("Received %d%n", msg.seqid);



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (THRIFT-2740) Perl coding standards

2017-09-23 Thread James E. King, III (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III resolved THRIFT-2740.

   Resolution: Fixed
Fix Version/s: 0.11.0

> Perl coding standards
> -
>
> Key: THRIFT-2740
> URL: https://issues.apache.org/jira/browse/THRIFT-2740
> Project: Thrift
>  Issue Type: Sub-task
>  Components: Perl - Library
>Reporter: Konrad Grochowski
>Assignee: James E. King, III
>Priority: Minor
> Fix For: 0.11.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4309) All Python files should be compatible with Python 3

2017-09-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178008#comment-16178008
 ] 

ASF GitHub Bot commented on THRIFT-4309:


Github user cclauss commented on the issue:

https://github.com/apache/thrift/pull/1339
  
This makes sense to me.  Please merge this PR when you are ready but we 
must do further work in another PR before THRIFT-4309 is complete.

There are three alternative approaches to running the approiate tests that 
I must consider.


> All Python files should be compatible with Python 3
> ---
>
> Key: THRIFT-4309
> URL: https://issues.apache.org/jira/browse/THRIFT-4309
> Project: Thrift
>  Issue Type: Improvement
>  Components: Python - Compiler, Python - Library
>Reporter: cclauss
>Priority: Minor
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> Python 3 is now 8 years old and is the current and future of the language.  
> Examples and other Python files in this project should be compatible with 
> Python 3 and where possible also with Python 2.
> https://docs.python.org/3/howto/pyporting.html is one of many guides on the 
> topic.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1339: THRIFT-4309 Python print() function

2017-09-23 Thread cclauss 
Github user cclauss commented on the issue:

https://github.com/apache/thrift/pull/1339
  
This makes sense to me.  Please merge this PR when you are ready but we 
must do further work in another PR before THRIFT-4309 is complete.

There are three alternative approaches to running the approiate tests that 
I must consider.


---

[jira] [Commented] (THRIFT-4309) All Python files should be compatible with Python 3

2017-09-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177991#comment-16177991
 ] 

ASF GitHub Bot commented on THRIFT-4309:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1339
  
What you suggest is that our build process is insufficient to catch these 
things, and I would like to see our build process become sufficient and 
enhanced with whatever tools are needed to make thrift better.  At the very 
least we should run modernize on all of the lib/py files, although this PR is a 
start, it does not do enough to mark THRIFT-4309 complete.  I can merge it, but 
more work will be necessary to complete everything needed.


> All Python files should be compatible with Python 3
> ---
>
> Key: THRIFT-4309
> URL: https://issues.apache.org/jira/browse/THRIFT-4309
> Project: Thrift
>  Issue Type: Improvement
>  Components: Python - Compiler, Python - Library
>Reporter: cclauss
>Priority: Minor
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> Python 3 is now 8 years old and is the current and future of the language.  
> Examples and other Python files in this project should be compatible with 
> Python 3 and where possible also with Python 2.
> https://docs.python.org/3/howto/pyporting.html is one of many guides on the 
> topic.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1339: THRIFT-4309 Python print() function

2017-09-23 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1339
  
What you suggest is that our build process is insufficient to catch these 
things, and I would like to see our build process become sufficient and 
enhanced with whatever tools are needed to make thrift better.  At the very 
least we should run modernize on all of the lib/py files, although this PR is a 
start, it does not do enough to mark THRIFT-4309 complete.  I can merge it, but 
more work will be necessary to complete everything needed.


---

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

2017-09-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177989#comment-16177989
 ] 

ASF GitHub Bot commented on THRIFT-4329:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1361
  
multic is for compact and multi is for binary

they are backwards compatible so one can use a binary client against a
multi server (which is why you will see servers with "binary:multi" or
"multi:binary" (I forget the polarity).

On Sat, Sep 23, 2017 at 11:52 AM, Gonzalo Aguilar Delgado <
notificati...@github.com> wrote:

> What's multic and multi. What's the difference?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



> c_glib Doesn't have a multiplexed processor
> ---
>
> Key: THRIFT-4329
> URL: https://issues.apache.org/jira/browse/THRIFT-4329
> Project: Thrift
>  Issue Type: Bug
>  Components: C glib - Library
>Affects Versions: 0.10.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
>
> It seems that multiplexed protocol only implements 
> thrift_multiplexed_protocol_write_message_begin that's ok for sending 
> messages to a multiplexed server but not for the C server. We also need a 
> multiplexed processor for the server.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

2017-09-23 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1361
  
multic is for compact and multi is for binary

they are backwards compatible so one can use a binary client against a
multi server (which is why you will see servers with "binary:multi" or
"multi:binary" (I forget the polarity).

On Sat, Sep 23, 2017 at 11:52 AM, Gonzalo Aguilar Delgado <
notificati...@github.com> wrote:

> What's multic and multi. What's the difference?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---

[jira] [Commented] (THRIFT-4309) All Python files should be compatible with Python 3

2017-09-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177874#comment-16177874
 ] 

ASF GitHub Bot commented on THRIFT-4309:


Github user cclauss commented on the issue:

https://github.com/apache/thrift/pull/1339
  
@jeking3 All of the __print() is a function__ changes are ESSENTIAL Python 
3 compatibility.  This is not optional.  See: 
https://docs.python.org/3/whatsnew/3.0.html

The reason that you are not seeing any problems in the build is because 
Python is a dynamic, interpreted language.  It does not have a separate compile 
step like C/C++ and other compiled languages have.  This in turn means that 
syntax errors are not found at "build" time but that they are only found at 
runtime.  This in turn explains why flake8 is better tool for spotting these 
problems than pylint.  flake8 uses the Abstract Syntax Tree process to do 
simulate runtime while pylint does not.


> All Python files should be compatible with Python 3
> ---
>
> Key: THRIFT-4309
> URL: https://issues.apache.org/jira/browse/THRIFT-4309
> Project: Thrift
>  Issue Type: Improvement
>  Components: Python - Compiler, Python - Library
>Reporter: cclauss
>Priority: Minor
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> Python 3 is now 8 years old and is the current and future of the language.  
> Examples and other Python files in this project should be compatible with 
> Python 3 and where possible also with Python 2.
> https://docs.python.org/3/howto/pyporting.html is one of many guides on the 
> topic.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1339: THRIFT-4309 Python print() function

2017-09-23 Thread cclauss 
Github user cclauss commented on the issue:

https://github.com/apache/thrift/pull/1339
  
@jeking3 All of the __print() is a function__ changes are ESSENTIAL Python 
3 compatibility.  This is not optional.  See: 
https://docs.python.org/3/whatsnew/3.0.html

The reason that you are not seeing any problems in the build is because 
Python is a dynamic, interpreted language.  It does not have a separate compile 
step like C/C++ and other compiled languages have.  This in turn means that 
syntax errors are not found at "build" time but that they are only found at 
runtime.  This in turn explains why flake8 is better tool for spotting these 
problems than pylint.  flake8 uses the Abstract Syntax Tree process to do 
simulate runtime while pylint does not.


---

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

2017-09-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177857#comment-16177857
 ] 

ASF GitHub Bot commented on THRIFT-4329:


Github user gadLinux commented on the issue:

https://github.com/apache/thrift/pull/1361
  
What's multic and multi. What's the difference?


> c_glib Doesn't have a multiplexed processor
> ---
>
> Key: THRIFT-4329
> URL: https://issues.apache.org/jira/browse/THRIFT-4329
> Project: Thrift
>  Issue Type: Bug
>  Components: C glib - Library
>Affects Versions: 0.10.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
>
> It seems that multiplexed protocol only implements 
> thrift_multiplexed_protocol_write_message_begin that's ok for sending 
> messages to a multiplexed server but not for the C server. We also need a 
> multiplexed processor for the server.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

2017-09-23 Thread gadLinux 
Github user gadLinux commented on the issue:

https://github.com/apache/thrift/pull/1361
  
What's multic and multi. What's the difference?


---

[jira] [Resolved] (THRIFT-4288) Implement logging levels properly for node.js

2017-09-23 Thread James E. King, III (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III resolved THRIFT-4288.

   Resolution: Fixed
Fix Version/s: 0.11.0

Committed - thanks!

> Implement logging levels properly for node.js
> -
>
> Key: THRIFT-4288
> URL: https://issues.apache.org/jira/browse/THRIFT-4288
> Project: Thrift
>  Issue Type: Improvement
>  Components: Node.js - Library
>Reporter: Kangcheng Wang
>Assignee: James E. King, III
>Priority: Minor
>  Labels: newbie
> Fix For: 0.11.0
>
>
> Implement log.js which was empty.
> Apply log.js to all existing log operations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift pull request #1334: THRIFT-4288: Implement log.js

2017-09-23 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1334


---

[jira] [Commented] (THRIFT-4288) Implement logging levels properly for node.js

2017-09-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177788#comment-16177788
 ] 

ASF GitHub Bot commented on THRIFT-4288:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1334


> Implement logging levels properly for node.js
> -
>
> Key: THRIFT-4288
> URL: https://issues.apache.org/jira/browse/THRIFT-4288
> Project: Thrift
>  Issue Type: Improvement
>  Components: Node.js - Library
>Reporter: Kangcheng Wang
>Assignee: James E. King, III
>Priority: Minor
>  Labels: newbie
> Fix For: 0.11.0
>
>
> Implement log.js which was empty.
> Apply log.js to all existing log operations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (THRIFT-4288) Implement logging levels properly for node.js

2017-09-23 Thread James E. King, III (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III reassigned THRIFT-4288:
--

Assignee: James E. King, III

> Implement logging levels properly for node.js
> -
>
> Key: THRIFT-4288
> URL: https://issues.apache.org/jira/browse/THRIFT-4288
> Project: Thrift
>  Issue Type: Improvement
>  Components: Node.js - Library
>Reporter: Kangcheng Wang
>Assignee: James E. King, III
>Priority: Minor
>  Labels: newbie
>
> Implement log.js which was empty.
> Apply log.js to all existing log operations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (THRIFT-4288) Implement logging levels properly for node.js

2017-09-23 Thread James E. King, III (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III updated THRIFT-4288:
---
Summary: Implement logging levels properly for node.js  (was: Implement 
logging properly for node.js (instead of using console))

> Implement logging levels properly for node.js
> -
>
> Key: THRIFT-4288
> URL: https://issues.apache.org/jira/browse/THRIFT-4288
> Project: Thrift
>  Issue Type: Improvement
>  Components: Node.js - Library
>Reporter: Kangcheng Wang
>Priority: Minor
>  Labels: newbie
>
> Implement log.js which was empty.
> Apply log.js to all existing log operations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (THRIFT-4288) Implement logging properly for node.js (instead of using console)

2017-09-23 Thread James E. King, III (JIRA) 

 [ 
https://issues.apache.org/jira/browse/THRIFT-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III updated THRIFT-4288:
---
Summary: Implement logging properly for node.js (instead of using console)  
(was: Implement log utilities.)

> Implement logging properly for node.js (instead of using console)
> -
>
> Key: THRIFT-4288
> URL: https://issues.apache.org/jira/browse/THRIFT-4288
> Project: Thrift
>  Issue Type: Improvement
>  Components: Node.js - Library
>Reporter: Kangcheng Wang
>Priority: Minor
>  Labels: newbie
>
> Implement log.js which was empty.
> Apply log.js to all existing log operations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4288) Implement log utilities.

2017-09-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177743#comment-16177743
 ] 

ASF GitHub Bot commented on THRIFT-4288:


Github user Equim-chan commented on the issue:

https://github.com/apache/thrift/pull/1334
  
@jeking3 done.


> Implement log utilities.
> 
>
> Key: THRIFT-4288
> URL: https://issues.apache.org/jira/browse/THRIFT-4288
> Project: Thrift
>  Issue Type: Improvement
>  Components: Node.js - Library
>Reporter: Kangcheng Wang
>Priority: Minor
>  Labels: newbie
>
> Implement log.js which was empty.
> Apply log.js to all existing log operations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1334: THRIFT-4288: Implement log.js

2017-09-23 Thread Equim-chan 
Github user Equim-chan commented on the issue:

https://github.com/apache/thrift/pull/1334
  
@jeking3 done.


---

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

2017-09-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177656#comment-16177656
 ] 

ASF GitHub Bot commented on THRIFT-4329:


Github user gadLinux commented on the issue:

https://github.com/apache/thrift/pull/1361
  
Now seems ok. This is another big change. So I will try to do cross tests 
after. Meanwhile I cross validated with Java. Already in production with this 
stuff...


> c_glib Doesn't have a multiplexed processor
> ---
>
> Key: THRIFT-4329
> URL: https://issues.apache.org/jira/browse/THRIFT-4329
> Project: Thrift
>  Issue Type: Bug
>  Components: C glib - Library
>Affects Versions: 0.10.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
>
> It seems that multiplexed protocol only implements 
> thrift_multiplexed_protocol_write_message_begin that's ok for sending 
> messages to a multiplexed server but not for the C server. We also need a 
> multiplexed processor for the server.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

2017-09-23 Thread gadLinux 
Github user gadLinux commented on the issue:

https://github.com/apache/thrift/pull/1361
  
Now seems ok. This is another big change. So I will try to do cross tests 
after. Meanwhile I cross validated with Java. Already in production with this 
stuff...


---

[jira] [Commented] (THRIFT-4251) Java Epoll Selector Bug

2017-09-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177649#comment-16177649
 ] 

ASF GitHub Bot commented on THRIFT-4251:


Github user xiaohu-zhang commented on the issue:

https://github.com/apache/thrift/pull/1313
  
Thank you ! honestly speaking , netty and lots of framework implementing 
this fix. I also doubt
It is useful in jdk7. I agree with you ,But if I was you , I will not 
change the original code,unless give
the unit test to prove it happend in jdk7


> Java Epoll Selector Bug
> ---
>
> Key: THRIFT-4251
> URL: https://issues.apache.org/jira/browse/THRIFT-4251
> Project: Thrift
>  Issue Type: Bug
>  Components: Java - Compiler, Java - Library
>Affects Versions: 0.10.0
> Environment: Linux version 3.10.0-327.el7.x86_64 
> (buil...@kbuilder.dev.centos.org)
> java version "1.8.0_131"
>Reporter: JohnnyLiao
>Assignee: James E. King, III
>  Labels: epoll, jdk, selector
> Fix For: 0.11.0
>
>
> Thrift java unsolve the infamous epoll bug. It's consum 100% cpu resource 
> when this occured. It seems to affect any NIO based Java server applications 
> running in the specified environment. Some projects provide workarounds for 
> similar JDK bugs, for example replaces the current Selector of this 
> SelectorThread.select with newly created Selector.
> Stack Trace：
> "Thread-46" #95 prio=5 os_prio=0 tid=0x7fc79cd02800 nid=0xb1 runnable 
> [0x7fc580bd1000]
>java.lang.Thread.State: RUNNABLE
> at sun.nio.ch.EPollArrayWrapper.epollWait(Native Method)
> at sun.nio.ch.EPollArrayWrapper.poll(EPollArrayWrapper.java:269)
> at sun.nio.ch.EPollSelectorImpl.doSelect(EPollSelectorImpl.java:93)
> at sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:86)
> - locked <0x8012f748> (a sun.nio.ch.Util$3)
> - locked <0x8012f738> (a 
> java.util.Collections$UnmodifiableSet)
> - locked <0x80120f58> (a sun.nio.ch.EPollSelectorImpl)
> at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:97)
> at sun.nio.ch.SelectorImpl.select(SelectorImpl.java:101)
> at 
> org.apache.thrift.server.TThreadedSelectorServer$SelectorThread.select(TThreadedSelectorServer.java:570)
> at 
> org.apache.thrift.server.TThreadedSelectorServer$SelectorThread.run(TThreadedSelectorServer.java:541)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...

2017-09-23 Thread xiaohu-zhang 
Github user xiaohu-zhang commented on the issue:

https://github.com/apache/thrift/pull/1313
  
Thank you ! honestly speaking , netty and lots of framework implementing 
this fix. I also doubt
It is useful in jdk7. I agree with you ,But if I was you , I will not 
change the original code,unless give
the unit test to prove it happend in jdk7


---