[GitHub] thrift pull request #1377: Revise contributing
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1377 Revise contributing You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift revise-contributing Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1377.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1377 commit 33b2eb8533a77a78bd9159c5995992ab8f483274 Author: James E. King, III Date: 2017-09-25T04:12:58Z Update the contribution guide, removed the older patch contribution instructions as they lead to significant delays, added recipes for handling github issues commit e03d5ac072a0ad99377088e22ced1d500b72f6e3 Author: James E. King, III Date: 2017-09-25T04:13:38Z build both ubuntu xenial as well as trusty to get more language level coverage, force C++98 in one of the C++ builds to guarantee compat, and update docker readme ---
[jira] [Commented] (THRIFT-4348) Perl HTTP Client custom HTTP headers
[ https://issues.apache.org/jira/browse/THRIFT-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180207#comment-16180207 ] ASF GitHub Bot commented on THRIFT-4348: GitHub user carwynmoore opened a pull request: https://github.com/apache/thrift/pull/1376 THRIFT-4348 - Allow custom HTTP headers to be set in Perl HTTP client. You can merge this pull request into a Git repository by running: $ git pull https://github.com/carwynmoore/thrift THRIFT-4348 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1376.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1376 commit c993656351147543da6f939cc8bf68aadd4c8f7d Author: Carwyn Moore Date: 2017-09-26T03:38:57Z THRIFT-4348 - Allow custom HTTP headers to be set in Perl HTTP client. > Perl HTTP Client custom HTTP headers > > > Key: THRIFT-4348 > URL: https://issues.apache.org/jira/browse/THRIFT-4348 > Project: Thrift > Issue Type: Proposal > Components: Perl - Library >Reporter: Carwyn Moore >Priority: Trivial > > Allow setting of HTTP headers on the perl HTTP client , similar to: > - PHP - addHeaders > > https://github.com/apache/thrift/blob/master/lib/php/lib/Thrift/Transport/THttpClient.php > - Go - SetHeader > https://github.com/apache/thrift/blob/master/lib/go/thrift/http_client.go -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1376: THRIFT-4348 - Allow custom HTTP headers to be set...
GitHub user carwynmoore opened a pull request: https://github.com/apache/thrift/pull/1376 THRIFT-4348 - Allow custom HTTP headers to be set in Perl HTTP client. You can merge this pull request into a Git repository by running: $ git pull https://github.com/carwynmoore/thrift THRIFT-4348 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1376.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1376 commit c993656351147543da6f939cc8bf68aadd4c8f7d Author: Carwyn Moore Date: 2017-09-26T03:38:57Z THRIFT-4348 - Allow custom HTTP headers to be set in Perl HTTP client. ---
[jira] [Created] (THRIFT-4348) Perl HTTP Client custom HTTP headers
Carwyn Moore created THRIFT-4348: Summary: Perl HTTP Client custom HTTP headers Key: THRIFT-4348 URL: https://issues.apache.org/jira/browse/THRIFT-4348 Project: Thrift Issue Type: Proposal Components: Perl - Library Reporter: Carwyn Moore Priority: Trivial Allow setting of HTTP headers on the perl HTTP client , similar to: - PHP - addHeaders https://github.com/apache/thrift/blob/master/lib/php/lib/Thrift/Transport/THttpClient.php - Go - SetHeader https://github.com/apache/thrift/blob/master/lib/go/thrift/http_client.go -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-1857) Python 3.X Support
[ https://issues.apache.org/jira/browse/THRIFT-1857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180045#comment-16180045 ] James E. King, III commented on THRIFT-1857: Hi folks, there was an additional PR that referenced this ticket. Please look it over. Trying to get it rebased so it passes CI. https://github.com/apache/thrift/pull/1289 > Python 3.X Support > -- > > Key: THRIFT-1857 > URL: https://issues.apache.org/jira/browse/THRIFT-1857 > Project: Thrift > Issue Type: Improvement > Components: Python - Compiler >Affects Versions: 0.9 >Reporter: Avi Saranga >Assignee: Aki Sukegawa > Fix For: 0.10.0 > > > add support for python 3.x -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (THRIFT-4206) Strings in container fields are not decoded properly with py:dynamic and py:utf8strings
[
https://issues.apache.org/jira/browse/THRIFT-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4206.
Resolution: Fixed
Committed - thanks.
> Strings in container fields are not decoded properly with py:dynamic and
> py:utf8strings
> ---
>
> Key: THRIFT-4206
> URL: https://issues.apache.org/jira/browse/THRIFT-4206
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.10.0
>Reporter: Elvis Pranskevichus
>Assignee: James E. King, III
> Fix For: 0.11.0
>
>
> {{_read_by_ttype}} and {{_write_by_ttype}} must be using the *element* spec
> and not the container spec when determining the correct read/write
> handler.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4206) Strings in container fields are not decoded properly with py:dynamic and py:utf8strings
[
https://issues.apache.org/jira/browse/THRIFT-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179989#comment-16179989
]
ASF GitHub Bot commented on THRIFT-4206:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1273
> Strings in container fields are not decoded properly with py:dynamic and
> py:utf8strings
> ---
>
> Key: THRIFT-4206
> URL: https://issues.apache.org/jira/browse/THRIFT-4206
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.10.0
>Reporter: Elvis Pranskevichus
>Assignee: James E. King, III
> Fix For: 0.11.0
>
>
> {{_read_by_ttype}} and {{_write_by_ttype}} must be using the *element* spec
> and not the container spec when determining the correct read/write
> handler.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift pull request #1273: THRIFT-4206: Fix decoding of strings in container...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1273 ---
[jira] [Assigned] (THRIFT-4206) Strings in container fields are not decoded properly with py:dynamic and py:utf8strings
[
https://issues.apache.org/jira/browse/THRIFT-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-4206:
--
Assignee: James E. King, III
> Strings in container fields are not decoded properly with py:dynamic and
> py:utf8strings
> ---
>
> Key: THRIFT-4206
> URL: https://issues.apache.org/jira/browse/THRIFT-4206
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.10.0
>Reporter: Elvis Pranskevichus
>Assignee: James E. King, III
> Fix For: 0.11.0
>
>
> {{_read_by_ttype}} and {{_write_by_ttype}} must be using the *element* spec
> and not the container spec when determining the correct read/write
> handler.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4207) Accelerated version of TBinaryProtocol allows invalid input to string fields.
[
https://issues.apache.org/jira/browse/THRIFT-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179930#comment-16179930
]
ASF GitHub Bot commented on THRIFT-4207:
Github user elprans commented on the issue:
https://github.com/apache/thrift/pull/1274
Rebased.
> Accelerated version of TBinaryProtocol allows invalid input to string fields.
> -
>
> Key: THRIFT-4207
> URL: https://issues.apache.org/jira/browse/THRIFT-4207
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.10.0
>Reporter: Elvis Pranskevichus
> Fix For: 0.11.0
>
>
> {{TBinaryProtocolAccelerated}} and {{TCompactProtocolAccelerated}} currently
> accept arbitrary bytes as input to string fields even when {{py:utf8strings}}
> is on.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift issue #1274: THRIFT-4207: Make sure Python Accelerated protocol does ...
Github user elprans commented on the issue: https://github.com/apache/thrift/pull/1274 Rebased. ---
[jira] [Commented] (THRIFT-4206) Strings in container fields are not decoded properly with py:dynamic and py:utf8strings
[
https://issues.apache.org/jira/browse/THRIFT-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179928#comment-16179928
]
ASF GitHub Bot commented on THRIFT-4206:
Github user elprans commented on the issue:
https://github.com/apache/thrift/pull/1273
Rebased.
> Strings in container fields are not decoded properly with py:dynamic and
> py:utf8strings
> ---
>
> Key: THRIFT-4206
> URL: https://issues.apache.org/jira/browse/THRIFT-4206
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.10.0
>Reporter: Elvis Pranskevichus
> Fix For: 0.11.0
>
>
> {{_read_by_ttype}} and {{_write_by_ttype}} must be using the *element* spec
> and not the container spec when determining the correct read/write
> handler.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift issue #1273: THRIFT-4206: Fix decoding of strings in containers with ...
Github user elprans commented on the issue: https://github.com/apache/thrift/pull/1273 Rebased. ---
[jira] [Updated] (THRIFT-4345) Create a docker build environment that uses the minimum supported language levels
[ https://issues.apache.org/jira/browse/THRIFT-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4345: --- Description: Following documentation of the supported language versions, we need to ensure there is a CI job that will build and run all the unit tests for all the minimum supported language levels. Some examples of non-conformance right now: ubuntu-trusty has perl 5.18.2 and xenial has 5.22.0, however all perl files state minimum of 5.10, so we should be building with 5.10. was:Following documentation of the supported language versions, we need to ensure there is a CI job that will build and run all the unit tests for all the minimum supported language levels. > Create a docker build environment that uses the minimum supported language > levels > - > > Key: THRIFT-4345 > URL: https://issues.apache.org/jira/browse/THRIFT-4345 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.10.0 > Environment: docker >Reporter: James E. King, III >Assignee: James E. King, III > > Following documentation of the supported language versions, we need to ensure > there is a CI job that will build and run all the unit tests for all the > minimum supported language levels. > Some examples of non-conformance right now: > ubuntu-trusty has perl 5.18.2 and xenial has 5.22.0, however all perl files > state minimum of 5.10, so we should be building with 5.10. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (THRIFT-4345) Create a docker build environment that uses the minimum supported language levels
[ https://issues.apache.org/jira/browse/THRIFT-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4345: --- Description: Following documentation of the supported language versions, we need to ensure there is a CI job that will build and run all the unit tests for all the minimum supported language levels. Some examples of non-conformance right now: ubuntu-trusty has perl 5.18.2 and xenial has 5.22.0, however all perl files state minimum of 5.10, so we should be building with 5.10 *or* move the minimum supported version up to 5.18.2. was: Following documentation of the supported language versions, we need to ensure there is a CI job that will build and run all the unit tests for all the minimum supported language levels. Some examples of non-conformance right now: ubuntu-trusty has perl 5.18.2 and xenial has 5.22.0, however all perl files state minimum of 5.10, so we should be building with 5.10. > Create a docker build environment that uses the minimum supported language > levels > - > > Key: THRIFT-4345 > URL: https://issues.apache.org/jira/browse/THRIFT-4345 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.10.0 > Environment: docker >Reporter: James E. King, III >Assignee: James E. King, III > > Following documentation of the supported language versions, we need to ensure > there is a CI job that will build and run all the unit tests for all the > minimum supported language levels. > Some examples of non-conformance right now: > ubuntu-trusty has perl 5.18.2 and xenial has 5.22.0, however all perl files > state minimum of 5.10, so we should be building with 5.10 *or* move the > minimum supported version up to 5.18.2. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4346) Allow Zlib transport factory to wrap other transports
[
https://issues.apache.org/jira/browse/THRIFT-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179800#comment-16179800
]
ASF GitHub Bot commented on THRIFT-4346:
Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1375#discussion_r140900375
--- Diff: lib/go/thrift/zlib_transport.go ---
@@ -39,12 +40,26 @@ type TZlibTransport struct {
// GetTransport constructs a new instance of NewTZlibTransport
func (p *TZlibTransportFactory) GetTransport(trans TTransport)
(TTransport, error) {
+ if p.factory != nil {
+ // wrap other factory
+ var err error
+ trans, err = p.factory.GetTransport(trans)
+ if err != nil {
+ return nil, err
+ }
+ }
return NewTZlibTransport(trans, p.level)
}
// NewTZlibTransportFactory constructs a new instance of
NewTZlibTransportFactory
func NewTZlibTransportFactory(level int) *TZlibTransportFactory {
- return &TZlibTransportFactory{level: level}
+ return &TZlibTransportFactory{level: level, factory: nil}
+}
+
+// NewTZlibTransportFactory constructs a new instance of
NewTZlibTransportFactory
--- End diff --
The second `NewTZlibTransportFactory` should be `TZlibTransportFactory`
> Allow Zlib transport factory to wrap other transports
> -
>
> Key: THRIFT-4346
> URL: https://issues.apache.org/jira/browse/THRIFT-4346
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Library
>Affects Versions: 0.10.0
> Environment: Any
>Reporter: Yuri Khrustalev
>Priority: Minor
> Labels: easyfix
>
> Thrift protocol allows to combine number of transports to transfer data, one
> of the examples is to use zlib transport on top of the framed transport.
> Turns out there is no such factory which could help building one for zlib
> transport.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift pull request #1375: THRIFT-4346: Allow ZlibTransportFactory to wrap o...
Github user dcelasun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1375#discussion_r140900375
--- Diff: lib/go/thrift/zlib_transport.go ---
@@ -39,12 +40,26 @@ type TZlibTransport struct {
// GetTransport constructs a new instance of NewTZlibTransport
func (p *TZlibTransportFactory) GetTransport(trans TTransport)
(TTransport, error) {
+ if p.factory != nil {
+ // wrap other factory
+ var err error
+ trans, err = p.factory.GetTransport(trans)
+ if err != nil {
+ return nil, err
+ }
+ }
return NewTZlibTransport(trans, p.level)
}
// NewTZlibTransportFactory constructs a new instance of
NewTZlibTransportFactory
func NewTZlibTransportFactory(level int) *TZlibTransportFactory {
- return &TZlibTransportFactory{level: level}
+ return &TZlibTransportFactory{level: level, factory: nil}
+}
+
+// NewTZlibTransportFactory constructs a new instance of
NewTZlibTransportFactory
--- End diff --
The second `NewTZlibTransportFactory` should be `TZlibTransportFactory`
---
[jira] [Comment Edited] (THRIFT-4344) Define and maintain the minimum language level for all languages in one place
[
https://issues.apache.org/jira/browse/THRIFT-4344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179725#comment-16179725
]
James E. King, III edited comment on THRIFT-4344 at 9/25/17 8:30 PM:
-
The closest thing we have to this right now would be the
[{{build/docker/README.md}}|https://github.com/apache/thrift/tree/master/build/docker]
file, however this only shows the versions in each docker image. Minimum
required versions is buried about in various readme files or build scripts.
was (Author: jking3):
The closest thing we have to this right now would be the
{{build/docker/README.md}} file, however this only shows the versions in each
docker image. Minimum required versions is buried about in various readme
files or build scripts.
> Define and maintain the minimum language level for all languages in one place
> -
>
> Key: THRIFT-4344
> URL: https://issues.apache.org/jira/browse/THRIFT-4344
> Project: Thrift
> Issue Type: Wish
> Components: Documentation
>Affects Versions: 0.10.0
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> We need a single location where the minimum supported version of every
> language is clearly documented for each release and publicly accessible. As
> we move the project forward we need to drop support for unsupported language
> levels to reduce the maintenance burden on the project.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (THRIFT-4346) Allow Zlib transport factory to wrap other transports
[ https://issues.apache.org/jira/browse/THRIFT-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179726#comment-16179726 ] ASF GitHub Bot commented on THRIFT-4346: GitHub user ykhrustalev opened a pull request: https://github.com/apache/thrift/pull/1375 THRIFT-4346: Allow ZlibTransportFactory to wrap other factories It is a case for when zlib is used with conjunction to other transport, for example framed transport. You can merge this pull request into a Git repository by running: $ git pull https://github.com/swiftserve/thrift THRIFT-4346 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1375.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1375 commit 6aaf908474e947399e80ee5d481fe4f1c678c64d Author: Yuri Khrustalev Date: 2017-09-25T20:22:33Z THRIFT-4346: Allow ZlibTransportFactory to wrap other factories It is a case for when zlib is used with conjunction to other transport, for example framed transport. > Allow Zlib transport factory to wrap other transports > - > > Key: THRIFT-4346 > URL: https://issues.apache.org/jira/browse/THRIFT-4346 > Project: Thrift > Issue Type: Improvement > Components: Go - Library >Affects Versions: 0.10.0 > Environment: Any >Reporter: Yuri Khrustalev >Priority: Minor > Labels: easyfix > > Thrift protocol allows to combine number of transports to transfer data, one > of the examples is to use zlib transport on top of the framed transport. > Turns out there is no such factory which could help building one for zlib > transport. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4344) Define and maintain the minimum language level for all languages in one place
[
https://issues.apache.org/jira/browse/THRIFT-4344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179725#comment-16179725
]
James E. King, III commented on THRIFT-4344:
The closest thing we have to this right now would be the
{{build/docker/README.md}} file, however this only shows the versions in each
docker image. Minimum required versions is buried about in various readme
files or build scripts.
> Define and maintain the minimum language level for all languages in one place
> -
>
> Key: THRIFT-4344
> URL: https://issues.apache.org/jira/browse/THRIFT-4344
> Project: Thrift
> Issue Type: Wish
> Components: Documentation
>Affects Versions: 0.10.0
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> We need a single location where the minimum supported version of every
> language is clearly documented for each release and publicly accessible. As
> we move the project forward we need to drop support for unsupported language
> levels to reduce the maintenance burden on the project.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] thrift pull request #1375: THRIFT-4346: Allow ZlibTransportFactory to wrap o...
GitHub user ykhrustalev opened a pull request: https://github.com/apache/thrift/pull/1375 THRIFT-4346: Allow ZlibTransportFactory to wrap other factories It is a case for when zlib is used with conjunction to other transport, for example framed transport. You can merge this pull request into a Git repository by running: $ git pull https://github.com/swiftserve/thrift THRIFT-4346 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1375.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1375 commit 6aaf908474e947399e80ee5d481fe4f1c678c64d Author: Yuri Khrustalev Date: 2017-09-25T20:22:33Z THRIFT-4346: Allow ZlibTransportFactory to wrap other factories It is a case for when zlib is used with conjunction to other transport, for example framed transport. ---
[jira] [Created] (THRIFT-4347) running build-thrift error when running tests
Gideon Korir created THRIFT-4347: Summary: running build-thrift error when running tests Key: THRIFT-4347 URL: https://issues.apache.org/jira/browse/THRIFT-4347 Project: Thrift Issue Type: Bug Components: Build Process, Test Suite Affects Versions: 0.10.0 Environment: - Following the instructions at [github|https://github.com/apache/thrift/tree/master/build/wincpp] to build Thrift on Windows 7. I'm a bit out of my league there but I followed all the instructions using: # Branch: master # Visual Studio 2017 Community # CMake 3.9.3 # WinFlexBison - latest # OpenSsl 1.1.0-rc # Zlib 1.2.9 # libevent 2.1.7-rc # ActivePerl 5.24.2.2403 x64 # Boost boost_1_62_0-msvc-14.0-32 Environment Variables: # ARCH = x86 # COMPILER = vc150 # GENERATOR = Visual Studio 15 2017 Reporter: Gideon Korir build-thrift.bat /NOTEST => SUCCESSFUL BUILD build-thrift.bat => ERROR SO FAR I've Isolated the error to the post-build event for RUN_TESTS project. There error message is: Error MSB3073 The command "setlocal "C:\Program Files\CMake\bin\ctest.exe" --force-new-ctest-process -C Debug if %errorlevel% neq 0 goto :cmEnd :cmEnd endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone :cmErrorLevel exit /b %1 :cmDone if %errorlevel% neq 0 goto :VCEnd :VCEnd" exited with code 8. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (THRIFT-4346) Allow Zlib transport factory to wrap other transports
Yuri Khrustalev created THRIFT-4346: --- Summary: Allow Zlib transport factory to wrap other transports Key: THRIFT-4346 URL: https://issues.apache.org/jira/browse/THRIFT-4346 Project: Thrift Issue Type: Improvement Components: Go - Library Affects Versions: 0.10.0 Environment: Any Reporter: Yuri Khrustalev Priority: Minor Thrift protocol allows to combine number of transports to transfer data, one of the examples is to use zlib transport on top of the framed transport. Turns out there is no such factory which could help building one for zlib transport. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4050) Skip() should throw TProtocolException.INVALID_DATA on unknown data types
[ https://issues.apache.org/jira/browse/THRIFT-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178683#comment-16178683 ] Gonzalo Aguilar commented on THRIFT-4050: - I don't know about this issue, can't see anything relevant on the issue, I don't know what's referring to. But if we must modify I'll do it. > Skip() should throw TProtocolException.INVALID_DATA on unknown data types > - > > Key: THRIFT-4050 > URL: https://issues.apache.org/jira/browse/THRIFT-4050 > Project: Thrift > Issue Type: Sub-task > Components: C glib - Library >Reporter: Jens Geyer >Assignee: Gonzalo Aguilar > Fix For: 0.11.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4050) Skip() should throw TProtocolException.INVALID_DATA on unknown data types
[ https://issues.apache.org/jira/browse/THRIFT-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178682#comment-16178682 ] Gonzalo Aguilar commented on THRIFT-4050: - I don't know about this issue, can't see anything relevant on the issue, I don't know what's referring to. But if we must modify I'll do it. > Skip() should throw TProtocolException.INVALID_DATA on unknown data types > - > > Key: THRIFT-4050 > URL: https://issues.apache.org/jira/browse/THRIFT-4050 > Project: Thrift > Issue Type: Sub-task > Components: C glib - Library >Reporter: Jens Geyer >Assignee: Gonzalo Aguilar > Fix For: 0.11.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
