[GitHub] thrift pull request #1397: change DOCKER_ env vars for travis integration to...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1397 ---
[GitHub] thrift issue #1395: THRIFT-4306 dlang: public imports for dependencies
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1395 @jfarrell please close this, it was merged in commit 44701e82ad351d7472101ad81aa13e775ffb7384 ---
[jira] [Commented] (THRIFT-4306) Thrift imports not replicated to D service output
[ https://issues.apache.org/jira/browse/THRIFT-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215573#comment-16215573 ] ASF GitHub Bot commented on THRIFT-4306: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1395 @jfarrell please close this, it was merged in commit 44701e82ad351d7472101ad81aa13e775ffb7384 > Thrift imports not replicated to D service output > - > > Key: THRIFT-4306 > URL: https://issues.apache.org/jira/browse/THRIFT-4306 > Project: Thrift > Issue Type: Improvement > Components: D - Compiler >Reporter: Neia Neutuladh >Assignee: Neia Neutuladh > Fix For: 0.11.0 > > Attachments: THRIFT-4306 dlang public imports for dependencies.diff > > > Looks like the code relies on a compiler bug that was eliminated a couple > years ago. Easy enough to fix. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1396: THRIFT-4305 Doc comments in dlang output
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1396 Manually inspecting the result in a sandbox. ---
[jira] [Assigned] (THRIFT-4305) Emit ddoc for generated items
[ https://issues.apache.org/jira/browse/THRIFT-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4305: -- Assignee: James E. King, III > Emit ddoc for generated items > - > > Key: THRIFT-4305 > URL: https://issues.apache.org/jira/browse/THRIFT-4305 > Project: Thrift > Issue Type: Improvement > Components: D - Compiler >Affects Versions: 0.10.0 >Reporter: Neia Neutuladh >Assignee: James E. King, III > Attachments: THRIFT-4305 dlang documentation comments.diff > > > Since Thrift IDL supports doc comments, and D supports doc comments, it would > be great if we would actually emit Thrift's doc comments in the generated D > code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4305) Emit ddoc for generated items
[ https://issues.apache.org/jira/browse/THRIFT-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215597#comment-16215597 ] ASF GitHub Bot commented on THRIFT-4305: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1396 Manually inspecting the result in a sandbox. > Emit ddoc for generated items > - > > Key: THRIFT-4305 > URL: https://issues.apache.org/jira/browse/THRIFT-4305 > Project: Thrift > Issue Type: Improvement > Components: D - Compiler >Affects Versions: 0.10.0 >Reporter: Neia Neutuladh > Attachments: THRIFT-4305 dlang documentation comments.diff > > > Since Thrift IDL supports doc comments, and D supports doc comments, it would > be great if we would actually emit Thrift's doc comments in the generated D > code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1396: THRIFT-4305 Doc comments in dlang output
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1396 ---
[GitHub] thrift pull request #1395: THRIFT-4306 dlang: public imports for dependencie...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1395 ---
[jira] [Commented] (THRIFT-4306) Thrift imports not replicated to D service output
[ https://issues.apache.org/jira/browse/THRIFT-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215643#comment-16215643 ] ASF GitHub Bot commented on THRIFT-4306: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1395 > Thrift imports not replicated to D service output > - > > Key: THRIFT-4306 > URL: https://issues.apache.org/jira/browse/THRIFT-4306 > Project: Thrift > Issue Type: Improvement > Components: D - Compiler >Reporter: Neia Neutuladh >Assignee: Neia Neutuladh > Fix For: 0.11.0 > > Attachments: THRIFT-4306 dlang public imports for dependencies.diff > > > Looks like the code relies on a compiler bug that was eliminated a couple > years ago. Easy enough to fix. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4305) Emit ddoc for generated items
[ https://issues.apache.org/jira/browse/THRIFT-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215642#comment-16215642 ] ASF GitHub Bot commented on THRIFT-4305: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1396 > Emit ddoc for generated items > - > > Key: THRIFT-4305 > URL: https://issues.apache.org/jira/browse/THRIFT-4305 > Project: Thrift > Issue Type: Improvement > Components: D - Compiler >Affects Versions: 0.10.0 >Reporter: Neia Neutuladh >Assignee: James E. King, III > Attachments: THRIFT-4305 dlang documentation comments.diff > > > Since Thrift IDL supports doc comments, and D supports doc comments, it would > be great if we would actually emit Thrift's doc comments in the generated D > code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4367) python TProcessor.process is missing "self"
[ https://issues.apache.org/jira/browse/THRIFT-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215674#comment-16215674 ] ASF GitHub Bot commented on THRIFT-4367: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1392 I opened THRIFT-4367 for this. > python TProcessor.process is missing "self" > --- > > Key: THRIFT-4367 > URL: https://issues.apache.org/jira/browse/THRIFT-4367 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.10.0 >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Critical > Fix For: 0.11.0 > > > Based on PR https://github.com/apache/thrift/pull/1392/files -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (THRIFT-4367) python TProcessor.process is missing "self"
James E. King, III created THRIFT-4367: -- Summary: python TProcessor.process is missing "self" Key: THRIFT-4367 URL: https://issues.apache.org/jira/browse/THRIFT-4367 Project: Thrift Issue Type: Bug Components: Python - Library Affects Versions: 0.10.0 Reporter: James E. King, III Assignee: James E. King, III Priority: Critical Fix For: 0.11.0 Based on PR https://github.com/apache/thrift/pull/1392/files -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1392: Fix missing positional argument
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1392 I opened THRIFT-4367 for this. ---
[jira] [Resolved] (THRIFT-4305) Emit ddoc for generated items
[ https://issues.apache.org/jira/browse/THRIFT-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4305. Resolution: Fixed Fix Version/s: 0.11.0 > Emit ddoc for generated items > - > > Key: THRIFT-4305 > URL: https://issues.apache.org/jira/browse/THRIFT-4305 > Project: Thrift > Issue Type: Improvement > Components: D - Compiler >Affects Versions: 0.10.0 >Reporter: Neia Neutuladh >Assignee: James E. King, III > Fix For: 0.11.0 > > Attachments: THRIFT-4305 dlang documentation comments.diff > > > Since Thrift IDL supports doc comments, and D supports doc comments, it would > be great if we would actually emit Thrift's doc comments in the generated D > code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (THRIFT-4305) Emit ddoc for generated items
[ https://issues.apache.org/jira/browse/THRIFT-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4305: --- Priority: Minor (was: Major) > Emit ddoc for generated items > - > > Key: THRIFT-4305 > URL: https://issues.apache.org/jira/browse/THRIFT-4305 > Project: Thrift > Issue Type: Improvement > Components: D - Compiler >Affects Versions: 0.10.0 >Reporter: Neia Neutuladh >Assignee: James E. King, III >Priority: Minor > Fix For: 0.11.0 > > Attachments: THRIFT-4305 dlang documentation comments.diff > > > Since Thrift IDL supports doc comments, and D supports doc comments, it would > be great if we would actually emit Thrift's doc comments in the generated D > code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4037) [CMake] Use a single build system for thrift to make development easier
[ https://issues.apache.org/jira/browse/THRIFT-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216225#comment-16216225 ] Robert Lu commented on THRIFT-4037: --- Personally, I'd like to migrate to cmake. But, I haven't see any final decision. *keep in autotools, remove cmake? or migrate to cmake, remove autotools? or keep cmake and autotools?* It's difficult to keep autotools *and* cmake works. > [CMake] Use a single build system for thrift to make development easier > --- > > Key: THRIFT-4037 > URL: https://issues.apache.org/jira/browse/THRIFT-4037 > Project: Thrift > Issue Type: Epic > Components: Build Process >Affects Versions: 0.10.0 > Environment: All >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Critical > > h1. Background > The thrift project currently carries two build systems. The original build > system is based on autoconf and is used to build a complete deliverable > including extensive cross-language testing. > The other build system was introduced a few years ago, with roots tracing > back to THRIFT-797. CMake allows thrift to build natively on multiple > platforms - unix and windows. Autoconf is no longer under active development > with the last release in 2012, and it does not allow for native windows > builds using native tools that are used by a majority of consumers. > Maintaining two build systems for a project incurs a lot of overhead. Every > change that touches the build system needs to be done twice, in two > completely different ways. We need twice as many CI jobs to verify that all > of the builds are working, whereas with a single cmake build environment we > could likely use a single CI build job per platform that does everything > using the docker image on linux and appveyor on windows. > h1. Proposal > We should officially deprecate autoconf in favor of cmake, and continue (more > aggressively) the effort to make the cmake build environment as functional as > the autoconf build environment. During this transition, folks will be > required to make changes to both build systems (which are proven out mostly > through the Travis CI build jobs; only CMake is used on AppVeyor). > h1. Acceptance Criteria > # All existing platforms, targets, and tests are converted to use cmake > ## Including cross-compilation > # All CI builds are converted to use cmake > # autoconf build environment is removed -- This message was sent by Atlassian JIRA (v6.4.14#64029)
PR to remove PHP5 support
Hi folks, There is a PR on the table that will remove PHP5 support in favor of PHP7 and fixing an crashing bug. I wanted to bring it up on the mailing list to gather any objections. https://github.com/apache/thrift/pull/1391 Thanks, Jim
[GitHub] thrift issue #1391: Fix segment fault at thrift_protocol extension
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1391 I posted a message on the developer mailing list about removing php5 support. We'll see what comes of it. php5 is currently still shipping so I have some reservations about removing support for it, but I want to hear if there are objections. If there are, can this fix be modified to deal with both? ---
Re: PR to remove PHP5 support
Hi, PHP library is still support PHP5 and PHP7 (>=5.3.0). but, PHP extension (thrift_protocol) will just support PHP7, doesn't support PHP5. -- Robert Lu On 10/24/17 11:16, James E. King, III wrote: Hi folks, There is a PR on the table that will remove PHP5 support in favor of PHP7 and fixing an crashing bug. I wanted to bring it up on the mailing list to gather any objections. https://github.com/apache/thrift/pull/1391 Thanks, Jim
[GitHub] thrift issue #1391: Fix segment fault at thrift_protocol extension
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1391 @jeking3 Currently, I just remove PHP5 support at PHP extension(thrift_protocol), PHP library is still support PHP5. So, I think this PR is good. --- If PHP5 support for extension is needed, I will add it back. ---
[jira] [Commented] (THRIFT-4062) Remove debug print from TServiceClient
[ https://issues.apache.org/jira/browse/THRIFT-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216272#comment-16216272 ] kenneth mcfarland commented on THRIFT-4062: --- Is there any chance this fix will be released soon based on popular demand? > Remove debug print from TServiceClient > -- > > Key: THRIFT-4062 > URL: https://issues.apache.org/jira/browse/THRIFT-4062 > Project: Thrift > Issue Type: Bug > Components: Java - Library >Affects Versions: 0.10.0 >Reporter: Jens Geyer >Assignee: Tom Davis >Priority: Critical > Fix For: 0.11.0 > > > GitHub user tdavis opened a pull request: > https://github.com/apache/thrift/pull/1173 > Remove debug print from TServiceClient > Client: Java > You can merge this pull request into a Git repository by running: > $ git pull https://github.com/tdavis/thrift patch-1 > Alternatively you can review and apply these changes as the patch at: > https://github.com/apache/thrift/pull/1173.patch > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > This closes #1173 > > > commit 670ad408b7f601798db7cf7b659ac231ba53c6a9 > Author: Tom Davis > Date: 2017-01-31T17:01:50Z > Remove debug print from TServiceClient > > Client: Java > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1306: Fix Nodejs generation to auto deal with args class insta...
Github user wenshin commented on the issue: https://github.com/apache/thrift/pull/1306 @jeking3 Thanks for your nice reply, it's duplicate of #1034, I'll close this one. ---
[GitHub] thrift pull request #1306: Fix Nodejs generation to auto deal with args clas...
Github user wenshin closed the pull request at: https://github.com/apache/thrift/pull/1306 ---
Please respond to THRIFT-4062
Could the Thrift developers please respond to the repeated requests from half a dozen different individuals to release a version 0.10.1 with the fix in https://issues.apache.org/jira/browse/THRIFT-4062 ? This is a critical issue, and need not wait until 0.11 or later. The fix is trivial, and all that is being requested is for a version to be released with that fix only. No other issues need to be addressed in the release. That should make it very easy to release, if the project is healthy enough to have a voting quorum in the PMC. Thanks.
