[GitHub] thrift pull request #1410: THRIFT-82: Add Common Lisp support
Github user jfarrell commented on a diff in the pull request: https://github.com/apache/thrift/pull/1410#discussion_r149655532 --- Diff: lib/cl/framed-transport.lisp --- @@ -0,0 +1,136 @@ +(in-package #:org.apache.thrift.implementation) + + Copyright 2017 Rigetti Computing --- End diff -- That would be great. is it possible fetch his work as a third party downloadable dependency or was it used as the basis for work you did on top of it? ---
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243811#comment-16243811 ] ASF GitHub Bot commented on THRIFT-82: -- Github user jfarrell commented on a diff in the pull request: https://github.com/apache/thrift/pull/1410#discussion_r149655532 --- Diff: lib/cl/framed-transport.lisp --- @@ -0,0 +1,136 @@ +(in-package #:org.apache.thrift.implementation) + + Copyright 2017 Rigetti Computing --- End diff -- That would be great. is it possible fetch his work as a third party downloadable dependency or was it used as the basis for work you did on top of it? > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1410: THRIFT-82: Add Common Lisp support
Github user dkochmanski commented on a diff in the pull request: https://github.com/apache/thrift/pull/1410#discussion_r149660082 --- Diff: lib/cl/framed-transport.lisp --- @@ -0,0 +1,136 @@ +(in-package #:org.apache.thrift.implementation) + + Copyright 2017 Rigetti Computing --- End diff -- I've send an email to Mr. Anderson â will let you know when / if I receive a reply. No, it is not possible, our work takes his repository[1] as base for further adjustments to meet the contribution requirements (missing protocols etc). [1] https://github.com/lisp/de.setf.thrift ---
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243842#comment-16243842 ] ASF GitHub Bot commented on THRIFT-82: -- Github user dkochmanski commented on a diff in the pull request: https://github.com/apache/thrift/pull/1410#discussion_r149660082 --- Diff: lib/cl/framed-transport.lisp --- @@ -0,0 +1,136 @@ +(in-package #:org.apache.thrift.implementation) + + Copyright 2017 Rigetti Computing --- End diff -- I've send an email to Mr. Anderson – will let you know when / if I receive a reply. No, it is not possible, our work takes his repository[1] as base for further adjustments to meet the contribution requirements (missing protocols etc). [1] https://github.com/lisp/de.setf.thrift > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243989#comment-16243989 ] ASF GitHub Bot commented on THRIFT-82: -- Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1410 @dkochmanski Travis support responded saying that no one from TurtleWarePL has logged into https://travis-ci.org/ ever and this is the reason this PR is not getting run within travis. From Travis support: > do you think one of their members could try to log into Travis CI at least once at https://travis-ci.org/ and try closing and reopen one of the rejected Pull Requests? > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1410: THRIFT-82: Add Common Lisp support
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1410 @dkochmanski Travis support responded saying that no one from TurtleWarePL has logged into https://travis-ci.org/ ever and this is the reason this PR is not getting run within travis. From Travis support: > do you think one of their members could try to log into Travis CI at least once at https://travis-ci.org/ and try closing and reopen one of the rejected Pull Requests? ---
[GitHub] thrift issue #1410: THRIFT-82: Add Common Lisp support
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1410 Why don't we close this PR and open a new one free of any copyright issues or inclusion of third party code. That should resolve the issue? ---
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243993#comment-16243993 ] ASF GitHub Bot commented on THRIFT-82: -- Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1410 Why don't we close this PR and open a new one free of any copyright issues or inclusion of third party code. That should resolve the issue? > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1410: THRIFT-82: Add Common Lisp support
Github user dkochmanski commented on the issue: https://github.com/apache/thrift/pull/1410 @jfarrell logged into travis a moment ago for the first time. @jeking3 I'm waiting for a response from @lisp if we can remove his copyright strings (we've removed ours). Should I close the PR and issue a new one before I receive a reply? ---
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244007#comment-16244007 ] ASF GitHub Bot commented on THRIFT-82: -- Github user dkochmanski commented on the issue: https://github.com/apache/thrift/pull/1410 @jfarrell logged into travis a moment ago for the first time. @jeking3 I'm waiting for a response from @lisp if we can remove his copyright strings (we've removed ours). Should I close the PR and issue a new one before I receive a reply? > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1410: THRIFT-82: Add Common Lisp support
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1410 Let's follow @jfarrell 's lead. Whatever he says, he's managing the travis interaction. ---
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244047#comment-16244047 ] ASF GitHub Bot commented on THRIFT-82: -- Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1410 Let's follow @jfarrell 's lead. Whatever he says, he's managing the travis interaction. > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1410: THRIFT-82: Add Common Lisp support
Github user dkochmanski commented on the issue: https://github.com/apache/thrift/pull/1410 closing, will reopen with squashed commits. ---
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244084#comment-16244084 ] ASF GitHub Bot commented on THRIFT-82: -- Github user dkochmanski commented on the issue: https://github.com/apache/thrift/pull/1410 closing, will reopen with squashed commits. > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1410: THRIFT-82: Add Common Lisp support
Github user uint closed the pull request at: https://github.com/apache/thrift/pull/1410 ---
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244086#comment-16244086 ] ASF GitHub Bot commented on THRIFT-82: -- Github user uint closed the pull request at: https://github.com/apache/thrift/pull/1410 > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1412: [THRIFT-82] Add Common Lisp support
GitHub user dkochmanski opened a pull request: https://github.com/apache/thrift/pull/1412 [THRIFT-82] Add Common Lisp support There's framed and buffered socket transport, binary protocol, multiplex, simple server, cross-tests, self-tests, tutorial, CL library, CL code generator. Only SBCL is supported for now. You can merge this pull request into a Git repository by running: $ git pull https://github.com/TurtleWarePL/thrift develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1412.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1412 commit c5f8973b32bcf251fa2cc9a83fedd01000148ef8 Author: Tomek Kurcz Date: 2017-09-19T07:16:43Z [THRIFT-82] Add Common Lisp support There's framed and buffered socket transport, binary protocol, multiplex, simple server, cross-tests, self-tests, tutorial, CL library, CL code generator. Only SBCL is supported for now. ---
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244094#comment-16244094 ] ASF GitHub Bot commented on THRIFT-82: -- GitHub user dkochmanski opened a pull request: https://github.com/apache/thrift/pull/1412 [THRIFT-82] Add Common Lisp support There's framed and buffered socket transport, binary protocol, multiplex, simple server, cross-tests, self-tests, tutorial, CL library, CL code generator. Only SBCL is supported for now. You can merge this pull request into a Git repository by running: $ git pull https://github.com/TurtleWarePL/thrift develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1412.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1412 commit c5f8973b32bcf251fa2cc9a83fedd01000148ef8 Author: Tomek Kurcz Date: 2017-09-19T07:16:43Z [THRIFT-82] Add Common Lisp support There's framed and buffered socket transport, binary protocol, multiplex, simple server, cross-tests, self-tests, tutorial, CL library, CL code generator. Only SBCL is supported for now. > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1412: [THRIFT-82] Add Common Lisp support
Github user dkochmanski commented on the issue: https://github.com/apache/thrift/pull/1412 squashed and rebased on top of the thrift master head. ---
[GitHub] thrift issue #1410: THRIFT-82: Add Common Lisp support
Github user dkochmanski commented on the issue: https://github.com/apache/thrift/pull/1410 see https://github.com/apache/thrift/pull/1412 ---
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244120#comment-16244120 ] ASF GitHub Bot commented on THRIFT-82: -- Github user dkochmanski commented on the issue: https://github.com/apache/thrift/pull/1410 see https://github.com/apache/thrift/pull/1412 > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244096#comment-16244096 ] ASF GitHub Bot commented on THRIFT-82: -- Github user dkochmanski commented on the issue: https://github.com/apache/thrift/pull/1412 squashed and rebased on top of the thrift master head. > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1410: THRIFT-82: Add Common Lisp support
Github user lisp commented on the issue: https://github.com/apache/thrift/pull/1410 good evening; this popped up in my mail due to mr kochmanski's reference. what are you waiting for from me? ---
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244139#comment-16244139 ] ASF GitHub Bot commented on THRIFT-82: -- Github user lisp commented on the issue: https://github.com/apache/thrift/pull/1410 good evening; this popped up in my mail due to mr kochmanski's reference. what are you waiting for from me? > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (THRIFT-4381) Wrong bitfield value after transmission
Nicolas V. created THRIFT-4381: -- Summary: Wrong bitfield value after transmission Key: THRIFT-4381 URL: https://issues.apache.org/jira/browse/THRIFT-4381 Project: Thrift Issue Type: Bug Components: Java - Library Affects Versions: 0.10.0 Environment: Linux Arch / Oracle JDK v1.8.0u152 and Windows 7 / Oracle JDK v1.8.0u151 Reporter: Nicolas V. Priority: Critical The bitfield field is set to true for every field after deserialization of a Thrift message structure. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1410: THRIFT-82: Add Common Lisp support
Github user dkochmanski commented on the issue: https://github.com/apache/thrift/pull/1410 Hello, I've send you an email a few hours ago with a question, if we can remove your "copyright" headers from the code found in de.setf.thrift, because that is what is required by Thrift team (I have included details in the email). Plese see: https://github.com/apache/thrift/pull/1410#discussion_r149655532 . ---
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244154#comment-16244154 ] ASF GitHub Bot commented on THRIFT-82: -- Github user dkochmanski commented on the issue: https://github.com/apache/thrift/pull/1410 Hello, I've send you an email a few hours ago with a question, if we can remove your "copyright" headers from the code found in de.setf.thrift, because that is what is required by Thrift team (I have included details in the email). Plese see: https://github.com/apache/thrift/pull/1410#discussion_r149655532 . > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1412: [THRIFT-82] Add Common Lisp support
Github user dkochmanski commented on the issue: https://github.com/apache/thrift/pull/1412 The bottom line is this: under the law of where mr. Anderson lives he can't yield the IP rights nor he sees a reason to do so, so we can't remove the copyrights put by him there. Code is licensed under the same license as the Thrift code though. ---
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244193#comment-16244193 ] ASF GitHub Bot commented on THRIFT-82: -- Github user dkochmanski commented on the issue: https://github.com/apache/thrift/pull/1412 The bottom line is this: under the law of where mr. Anderson lives he can't yield the IP rights nor he sees a reason to do so, so we can't remove the copyrights put by him there. Code is licensed under the same license as the Thrift code though. > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...
Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/1361 Rebased and lots of fixes added. Crossing fingers. I should opened a new issue but since all bug fixing were discovered while doing this incident I took the opportunity to fix everything here. ---
[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor
[ https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245257#comment-16245257 ] ASF GitHub Bot commented on THRIFT-4329: Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/1361 Rebased and lots of fixes added. Crossing fingers. I should opened a new issue but since all bug fixing were discovered while doing this incident I took the opportunity to fix everything here. > c_glib Doesn't have a multiplexed processor > --- > > Key: THRIFT-4329 > URL: https://issues.apache.org/jira/browse/THRIFT-4329 > Project: Thrift > Issue Type: Bug > Components: C glib - Library >Affects Versions: 0.10.0 >Reporter: Gonzalo Aguilar >Assignee: Gonzalo Aguilar > > It seems that multiplexed protocol only implements > thrift_multiplexed_protocol_write_message_begin that's ok for sending > messages to a multiplexed server but not for the C server. We also need a > multiplexed processor for the server. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
