[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253517#comment-16253517
 ] 

ASF GitHub Bot commented on THRIFT-4329:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1361
  
I also fail locally running in the docker container (but csharp does not, 
which is interesting):
```

===
*** Following 4 failures were unexpected ***:
If it is introduced by you, please fix it before submitting the code.

===
server-client:  protocol: transport:   result:
c_glib-rs   multi buffered-ip  
failure(timeout)
c_glib-rs   multi framed-ip
failure(timeout)
c_glib-rs   multicbuffered-ip  
failure(timeout)
c_glib-rs   multicframed-ip
failure(timeout)

===
Unexpected failures are logged to test/log/unexpected_failures.log
You can browse results at:
file:///thrift/src/test/index.html
# If you use Chrome, run:
#   cd /thrift/src
#   python -m http.server 8001
# then browse:
#   http://localhost:8001/test/
Full log for each test is here:
test/log/server_client_protocol_transport_client.log
test/log/server_client_protocol_transport_server.log
4 failed of 2590 tests in total.
Test execution took 887.2 seconds.
Wed Nov 15 14:08:42 2017
Makefile:1097: recipe for target 'cross-.*' failed
make: *** [cross-.*] Error 1

RET=$?
if [ $RET -ne 0 ]; then
  cat test/log/unexpected_failures.log
fi
TEST: [c_glib-rs_multi_buffered-ip]
*** server message ***
Wed Nov 15 13:54:58 2017
Executing: /thrift/src/test/c_glib/test_server --lt-debug --protocol=multi 
--transport=buffered --port=39553
Directory: /thrift/src/test/c_glib
config:delay: 5
config:timeout: 6

===
test_server:test_server:93: libtool wrapper (GNU libtool) 2.4.6 
Debian-2.4.6-0.1
test_server:test_server:114: newargv[0]: 
/thrift/src/test/c_glib/.libs/lt-test_server
test_server:test_server:104: newargv[1]: --protocol=multi
test_server:test_server:104: newargv[2]: --transport=buffered
test_server:test_server:104: newargv[3]: --port=39553
Starting "simple" server (buffered/binary:multi) listen on: 39553

(lt-test_server:36882): GLib-WARNING **: GError set over the top of a 
previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL 
before it's set.
The overwriting error message was: message type invalid for this processor

(lt-test_server:36882): GLib-WARNING **: GError set over the top of a 
previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL 
before it's set.
The overwriting error message was: failed to read 1 bytes - Success
** Message: thrift_simple_server_serve: failed to read 4 bytes - Success

Server process is successfully killed.

===
Process is killed.
Test execution took 6.2 seconds.
Wed Nov 15 13:55:04 2017

*** client message ***
Wed Nov 15 13:54:58 2017
Executing: /thrift/src/test/rs/bin/test_client --protocol=multi 
--transport=buffered --port=39553
Directory: /thrift/src/test/rs/bin
config:delay: 5
config:timeout: 6

===
INFO:test_client: connecting to 127.0.0.1:39553 with multi+buffered stack
INFO:test_client: testVoid
INFO:test_client: testString
INFO:test_client: testBool
INFO:test_client: testBool
INFO:test_client: testByte
INFO:test_client: testi32
INFO:test_client: testi64
INFO:test_client: testDouble
INFO:test_client: testTypedef
INFO:test_client: testEnum
INFO:test_client: testBinary
INFO:test_client: testStruct
INFO:test_client: testNest
INFO:test_client: SecondService blahBlah

===
Return code: -9
Test execution took 6.0 seconds.
Wed Nov 15 13:55:04 2017

**

TEST: [c_glib-rs_multi_framed-ip]
*** server message 

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253444#comment-16253444
 ] 

ASF GitHub Bot commented on THRIFT-4329:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1361
  
I cannot merge anything while the CI tests are failing due to language 
specific issues.
```

===
*** Following 8 failures were unexpected ***:
If it is introduced by you, please fix it before submitting the code.

===
server-client:  protocol: transport:   result:
c_glib-csharp   multi-binary  buffered-ip  
failure(timeout)
c_glib-csharp   multic-compactbuffered-ip  
failure(timeout)
c_glib-csharp   multic-compactframed-ip
failure(timeout)
c_glib-csharp   multi-binary  framed-ip
failure(timeout)
c_glib-rs   multicframed-ip
failure(timeout)
c_glib-rs   multicbuffered-ip  
failure(timeout)
c_glib-rs   multi framed-ip
failure(timeout)
c_glib-rs   multi buffered-ip  
failure(timeout)
```

This needs to be resolved.  Given that c_glib, csharp, and rs are the only 
three languages other than Java doing multi, and none of the multi tests are 
known failures, it looks like the c_glib server is misbehaving OR it is proving 
that the csharp and rs clients are misbehaving.  Do you know which is the case?


> c_glib Doesn't have a multiplexed processor
> ---
>
> Key: THRIFT-4329
> URL: https://issues.apache.org/jira/browse/THRIFT-4329
> Project: Thrift
>  Issue Type: Bug
>  Components: C glib - Library
>Affects Versions: 0.10.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
>
> It seems that multiplexed protocol only implements 
> thrift_multiplexed_protocol_write_message_begin that's ok for sending 
> messages to a multiplexed server but not for the C server. We also need a 
> multiplexed processor for the server.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

[jeking3]

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1361
  
I cannot merge anything while the CI tests are failing due to language 
specific issues.
```

===
*** Following 8 failures were unexpected ***:
If it is introduced by you, please fix it before submitting the code.

===
server-client:  protocol: transport:   result:
c_glib-csharp   multi-binary  buffered-ip  
failure(timeout)
c_glib-csharp   multic-compactbuffered-ip  
failure(timeout)
c_glib-csharp   multic-compactframed-ip
failure(timeout)
c_glib-csharp   multi-binary  framed-ip
failure(timeout)
c_glib-rs   multicframed-ip
failure(timeout)
c_glib-rs   multicbuffered-ip  
failure(timeout)
c_glib-rs   multi framed-ip
failure(timeout)
c_glib-rs   multi buffered-ip  
failure(timeout)
```

This needs to be resolved.  Given that c_glib, csharp, and rs are the only 
three languages other than Java doing multi, and none of the multi tests are 
known failures, it looks like the c_glib server is misbehaving OR it is proving 
that the csharp and rs clients are misbehaving.  Do you know which is the case?


---

[jira] [Commented] (THRIFT-82) Common Lisp support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253439#comment-16253439
 ] 

ASF GitHub Bot commented on THRIFT-82:
--

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1412
  
@jfarrell was going to take action either on contacting individuals or 
making decisions on this, so I'm waiting to see what the result of those 
efforts is.  I would much prefer the cl code for thrift be in the thrift 
project itself and not hosted somewhere else.


> Common Lisp support
> ---
>
> Key: THRIFT-82
> URL: https://issues.apache.org/jira/browse/THRIFT-82
> Project: Thrift
>  Issue Type: New Feature
>Reporter: Patrick Collison
>Assignee: James E. King, III
> Attachments: thrift-cl.patch
>
>
> Common Lisp support is attached



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1412: [THRIFT-82] Add Common Lisp support

[jeking3]

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1412
  
@jfarrell was going to take action either on contacting individuals or 
making decisions on this, so I'm waiting to see what the result of those 
efforts is.  I would much prefer the cl code for thrift be in the thrift 
project itself and not hosted somewhere else.


---

[jira] [Commented] (THRIFT-4366) upgrade thrift lib to 0.10 ,coredump at readMessageBegin

[xiaomingzhongguo (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253393#comment-16253393
 ] 

xiaomingzhongguo commented on THRIFT-4366:
--

https://issues.apache.org/jira/browse/THRIFT-4331
here has fixed the issue, i apply this patch ,no coredump 

> upgrade thrift lib to 0.10 ,coredump at readMessageBegin 
> -
>
> Key: THRIFT-4366
> URL: https://issues.apache.org/jira/browse/THRIFT-4366
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Compiler
>Affects Versions: 0.10.0
> Environment: thrift 0.10 CPP 
>Reporter: xiaomingzhongguo
>Priority: Critical
>  Labels: performance
>
> (gdb) bt
> #0  0x7f34d99c85ae in memcpy () from /lib64/libc.so.6
> #1  0x0100f9fb in std::basic_string std::allocator >::_M_replace_safe(unsigned long, unsigned long, char 
> const*, unsigned long) ()
> at 
> /data/davy/26lib_source/gcc-4.8.2/build/x86_64-linux-gnu/libstdc++-v3/include/bits/char_traits.h:271
> #2  0x009cec48 in unsigned int 
> apache::thrift::protocol::TBinaryProtocolT  
> apache::thrift::protocol::TNetworkBigEndian>::readStringBody  std::char_traits, std::allocator > >(std::basic_string std::char_traits, std::allocator >&, int) () at 
> /usr/local/include/thrift/protocol/TBinaryProtocol.tcc:441
> #3  0x009ce34f in 
> apache::thrift::protocol::TBinaryProtocolT  
> apache::thrift::protocol::TNetworkBigEndian>::readMessageBegin(std::basic_string  std::char_traits, std::allocator >&, 
> apache::thrift::protocol::TMessageType&, int&) () at 
> /usr/local/include/thrift/protocol/TBinaryProtocol.tcc:223
> #4  0x009cd798 in 
> apache::thrift::protocol::TVirtualProtocol  apache::thrift::protocol::TNetworkBigEndian>, 
> apache::thrift::protocol::TProtocolDefaults>::readMessageBegin_virt(std::basic_string  std::char_traits, std::allocator >&, 
> apache::thrift::protocol::TMessageType&, int&) () at 
> /usr/local/include/thrift/protocol/TVirtualProtocol.h:403
> #5  0x009d047c in 
> apache::thrift::protocol::TProtocol::readMessageBegin(std::basic_string std::char_traits, std::allocator >&, 
> apache::thrift::protocol::TMessageType&, int&) ()
> at /usr/local/include/thrift/protocol/TProtocol.h:436
> #6  0x009d09b9 in 
> apache::thrift::TDispatchProcessor::process(boost::shared_ptr,
>  boost::shared_ptr, void*) ()
> at /usr/local/include/thrift/TDispatchProcessor.h:114
> #7  0x00ddd96f in apache::thrift::server::TConnectedClient::run() () 
> at src/thrift/server/TConnectedClient.cpp:62
> #8  0x00dd6ef8 in 
> apache::thrift::server::TThreadedServer::TConnectedClientRunner::run() () at 
> src/thrift/server/TThreadedServer.cpp:147
> #9  0x00dd9891 in 
> apache::thrift::concurrency::PthreadThread::threadMain(void*) () at 
> src/thrift/concurrency/PosixThreadFactory.cpp:208
> #10 0x7f34da66d7f1 in start_thread () from /lib64/libpthread.so.0
> #11 0x7f34d9a25ccd in clone () from /lib64/libc.so.6



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253243#comment-16253243
 ] 

ASF GitHub Bot commented on THRIFT-4329:


Github user gadLinux commented on the issue:

https://github.com/apache/thrift/pull/1361
  
Hi @jeking3 can you merge please?



> c_glib Doesn't have a multiplexed processor
> ---
>
> Key: THRIFT-4329
> URL: https://issues.apache.org/jira/browse/THRIFT-4329
> Project: Thrift
>  Issue Type: Bug
>  Components: C glib - Library
>Affects Versions: 0.10.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
>
> It seems that multiplexed protocol only implements 
> thrift_multiplexed_protocol_write_message_begin that's ok for sending 
> messages to a multiplexed server but not for the C server. We also need a 
> multiplexed processor for the server.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

[gadLinux]

Github user gadLinux commented on the issue:

https://github.com/apache/thrift/pull/1361
  
Hi @jeking3 can you merge please?



---

[jira] [Commented] (THRIFT-4366) upgrade thrift lib to 0.10 ,coredump at readMessageBegin

[xiaomingzhongguo (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253202#comment-16253202
 ] 

xiaomingzhongguo commented on THRIFT-4366:
--

recv same content，some time will coredump .

> upgrade thrift lib to 0.10 ,coredump at readMessageBegin 
> -
>
> Key: THRIFT-4366
> URL: https://issues.apache.org/jira/browse/THRIFT-4366
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Compiler
>Affects Versions: 0.10.0
> Environment: thrift 0.10 CPP 
>Reporter: xiaomingzhongguo
>Priority: Critical
>  Labels: performance
>
> (gdb) bt
> #0  0x7f34d99c85ae in memcpy () from /lib64/libc.so.6
> #1  0x0100f9fb in std::basic_string std::allocator >::_M_replace_safe(unsigned long, unsigned long, char 
> const*, unsigned long) ()
> at 
> /data/davy/26lib_source/gcc-4.8.2/build/x86_64-linux-gnu/libstdc++-v3/include/bits/char_traits.h:271
> #2  0x009cec48 in unsigned int 
> apache::thrift::protocol::TBinaryProtocolT  
> apache::thrift::protocol::TNetworkBigEndian>::readStringBody  std::char_traits, std::allocator > >(std::basic_string std::char_traits, std::allocator >&, int) () at 
> /usr/local/include/thrift/protocol/TBinaryProtocol.tcc:441
> #3  0x009ce34f in 
> apache::thrift::protocol::TBinaryProtocolT  
> apache::thrift::protocol::TNetworkBigEndian>::readMessageBegin(std::basic_string  std::char_traits, std::allocator >&, 
> apache::thrift::protocol::TMessageType&, int&) () at 
> /usr/local/include/thrift/protocol/TBinaryProtocol.tcc:223
> #4  0x009cd798 in 
> apache::thrift::protocol::TVirtualProtocol  apache::thrift::protocol::TNetworkBigEndian>, 
> apache::thrift::protocol::TProtocolDefaults>::readMessageBegin_virt(std::basic_string  std::char_traits, std::allocator >&, 
> apache::thrift::protocol::TMessageType&, int&) () at 
> /usr/local/include/thrift/protocol/TVirtualProtocol.h:403
> #5  0x009d047c in 
> apache::thrift::protocol::TProtocol::readMessageBegin(std::basic_string std::char_traits, std::allocator >&, 
> apache::thrift::protocol::TMessageType&, int&) ()
> at /usr/local/include/thrift/protocol/TProtocol.h:436
> #6  0x009d09b9 in 
> apache::thrift::TDispatchProcessor::process(boost::shared_ptr,
>  boost::shared_ptr, void*) ()
> at /usr/local/include/thrift/TDispatchProcessor.h:114
> #7  0x00ddd96f in apache::thrift::server::TConnectedClient::run() () 
> at src/thrift/server/TConnectedClient.cpp:62
> #8  0x00dd6ef8 in 
> apache::thrift::server::TThreadedServer::TConnectedClientRunner::run() () at 
> src/thrift/server/TThreadedServer.cpp:147
> #9  0x00dd9891 in 
> apache::thrift::concurrency::PthreadThread::threadMain(void*) () at 
> src/thrift/concurrency/PosixThreadFactory.cpp:208
> #10 0x7f34da66d7f1 in start_thread () from /lib64/libpthread.so.0
> #11 0x7f34d9a25ccd in clone () from /lib64/libc.so.6



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)