[jira] [Commented] (THRIFT-2013) Integrate Multiplex tests into Thrift test suite

[James E. King, III (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257861#comment-16257861
 ] 

James E. King, III commented on THRIFT-2013:


I'm working on another PR to add multiplex to cpp tests.  I also got rid of 
that awful sleep(1) in the testOneway server implementation in cpp and now the 
cross tests run a lot faster (cpp anyway) and they error out less.  I found an 
issue handling SSL_read disconnect (return 0).  It wasn't throwing a transport 
exception (END_OF_FILE) which is used by the framework to signal a connection 
is gone.

> Integrate Multiplex tests into Thrift test suite
> 
>
> Key: THRIFT-2013
> URL: https://issues.apache.org/jira/browse/THRIFT-2013
> Project: Thrift
>  Issue Type: Improvement
>  Components: Test Suite
>Reporter: Jens Geyer
>  Labels: multiplex
>
> Roger wrote in THRIFT-1902:
> {quote}
> I would love to see an integrated test in our cross language test suite 
> started here:
> {code}
> sh bootstrap.sh
> ./configure
> make check
> sh test/test.sh
> {code}
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4062) Remove debug print from TServiceClient

[Christopher Tubbs (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257645#comment-16257645
 ] 

Christopher Tubbs commented on THRIFT-4062:
---

The role of PMC Chair is administrative, not leadership or decision-making. The 
PMC is responsible for decision-making as a collective, not just the chair. 
That said, of course, some projects' PMCs will delegate some responsibilities, 
but it does seem unusual for releases to be bottle-necked on any single 
individual on the PMC, chair or otherwise.

> Remove debug print from TServiceClient
> --
>
> Key: THRIFT-4062
> URL: https://issues.apache.org/jira/browse/THRIFT-4062
> Project: Thrift
>  Issue Type: Bug
>  Components: Java - Library
>Affects Versions: 0.10.0
>Reporter: Jens Geyer
>Assignee: Tom Davis
>Priority: Critical
> Fix For: 0.11.0
>
>
> GitHub user tdavis opened a pull request:
> https://github.com/apache/thrift/pull/1173
> Remove debug print from TServiceClient
> Client: Java
> You can merge this pull request into a Git repository by running:
> $ git pull https://github.com/tdavis/thrift patch-1
> Alternatively you can review and apply these changes as the patch at:
> https://github.com/apache/thrift/pull/1173.patch
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
> This closes #1173
> 
> 
> commit 670ad408b7f601798db7cf7b659ac231ba53c6a9
> Author: Tom Davis 
> Date:   2017-01-31T17:01:50Z
> Remove debug print from TServiceClient
> 
> Client: Java
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4062) Remove debug print from TServiceClient

[James E. King, III (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257635#comment-16257635
 ] 

James E. King, III commented on THRIFT-4062:


I'm a new PMC member for Thrift, but I think structural changes like release 
schedules and access to release systems have to go through the project chair.  
I posted a message on the PMC mailing list for Thrift directing attention to 
this Jira issue and the comments.

> Remove debug print from TServiceClient
> --
>
> Key: THRIFT-4062
> URL: https://issues.apache.org/jira/browse/THRIFT-4062
> Project: Thrift
>  Issue Type: Bug
>  Components: Java - Library
>Affects Versions: 0.10.0
>Reporter: Jens Geyer
>Assignee: Tom Davis
>Priority: Critical
> Fix For: 0.11.0
>
>
> GitHub user tdavis opened a pull request:
> https://github.com/apache/thrift/pull/1173
> Remove debug print from TServiceClient
> Client: Java
> You can merge this pull request into a Git repository by running:
> $ git pull https://github.com/tdavis/thrift patch-1
> Alternatively you can review and apply these changes as the patch at:
> https://github.com/apache/thrift/pull/1173.patch
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
> This closes #1173
> 
> 
> commit 670ad408b7f601798db7cf7b659ac231ba53c6a9
> Author: Tom Davis 
> Date:   2017-01-31T17:01:50Z
> Remove debug print from TServiceClient
> 
> Client: Java
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257498#comment-16257498
 ] 

ASF GitHub Bot commented on THRIFT-4329:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1361
  
Under THRIFT-2013 I am adding multiplexed cpp testing to the suite.  Will 
see how it interacts.  If only "rs" client is misbehaving, we can disable.


> c_glib Doesn't have a multiplexed processor
> ---
>
> Key: THRIFT-4329
> URL: https://issues.apache.org/jira/browse/THRIFT-4329
> Project: Thrift
>  Issue Type: Bug
>  Components: C glib - Library
>Affects Versions: 0.10.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
>
> It seems that multiplexed protocol only implements 
> thrift_multiplexed_protocol_write_message_begin that's ok for sending 
> messages to a multiplexed server but not for the C server. We also need a 
> multiplexed processor for the server.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

[jeking3]

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1361
  
Under THRIFT-2013 I am adding multiplexed cpp testing to the suite.  Will 
see how it interacts.  If only "rs" client is misbehaving, we can disable.


---

[jira] [Commented] (THRIFT-3877) C++: library don't work with HTTP.

[James E. King, III (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257487#comment-16257487
 ] 

James E. King, III commented on THRIFT-3877:


I'm raising the priority of this issue because there are 39 disabled 
cross-language tests with "cpp" and "http" in the test name, which indicates 
that this is fundamentally broken.  From a cursory analysis it looks like tests 
work well up to the "oneway" test.  Once the server receives "oneway" the 
client sends an i32(-1) and the client and server hang (this would be cpp-cpp 
http-ip or http-domain).  This represents over 16% of the known test failures 
in the cross test suite.

> C++: library don't work with HTTP.
> --
>
> Key: THRIFT-3877
> URL: https://issues.apache.org/jira/browse/THRIFT-3877
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Affects Versions: 0.9.3, 0.10.0
> Environment: Windows 7, Visual Studio 2013 (C#), Qt 5.7 (MSVC 12).
> Thrift from git repo, SHA-1: 5a3f855b4e6882184f13c698855c877241144a12 (master)
>Reporter: Sergey Fasman
>Priority: Critical
>
> Client on C++.
> Tested on C# HTTP server and client — work ideal.
> Then create client on C++. Client after request starts infinitly wait for 
> data.
> For example, JSON protocol read data symbol by symbol, when trying read: it 
> always try to call recv function (even all data already received).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (THRIFT-3877) C++: library don't work with HTTP.

[James E. King, III (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III updated THRIFT-3877:
---
Priority: Critical  (was: Major)

> C++: library don't work with HTTP.
> --
>
> Key: THRIFT-3877
> URL: https://issues.apache.org/jira/browse/THRIFT-3877
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Affects Versions: 0.9.3, 0.10.0
> Environment: Windows 7, Visual Studio 2013 (C#), Qt 5.7 (MSVC 12).
> Thrift from git repo, SHA-1: 5a3f855b4e6882184f13c698855c877241144a12 (master)
>Reporter: Sergey Fasman
>Priority: Critical
>
> Client on C++.
> Tested on C# HTTP server and client — work ideal.
> Then create client on C++. Client after request starts infinitly wait for 
> data.
> For example, JSON protocol read data symbol by symbol, when trying read: it 
> always try to call recv function (even all data already received).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (THRIFT-3877) C++: library don't work with HTTP.

[James E. King, III (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III updated THRIFT-3877:
---
Affects Version/s: (was: 1.0)
   0.10.0

> C++: library don't work with HTTP.
> --
>
> Key: THRIFT-3877
> URL: https://issues.apache.org/jira/browse/THRIFT-3877
> Project: Thrift
>  Issue Type: Bug
>  Components: C++ - Library
>Affects Versions: 0.9.3, 0.10.0
> Environment: Windows 7, Visual Studio 2013 (C#), Qt 5.7 (MSVC 12).
> Thrift from git repo, SHA-1: 5a3f855b4e6882184f13c698855c877241144a12 (master)
>Reporter: Sergey Fasman
>Priority: Critical
>
> Client on C++.
> Tested on C# HTTP server and client — work ideal.
> Then create client on C++. Client after request starts infinitly wait for 
> data.
> For example, JSON protocol read data symbol by symbol, when trying read: it 
> always try to call recv function (even all data already received).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257116#comment-16257116
 ] 

ASF GitHub Bot commented on THRIFT-4329:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1361
  
I cannot merge in a change that will knowingly break CI builds.

The tests that are failing need to be fixed (preferably) or disabled using 
the "test.py -U merge" I (hopefully) documented earlier.  Once the failing 
tests are disabled and the build passes we can merge.  We have a backlog of 
"known failing" test combinations that need attention and are not represented 
in the Jira backlog.


> c_glib Doesn't have a multiplexed processor
> ---
>
> Key: THRIFT-4329
> URL: https://issues.apache.org/jira/browse/THRIFT-4329
> Project: Thrift
>  Issue Type: Bug
>  Components: C glib - Library
>Affects Versions: 0.10.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
>
> It seems that multiplexed protocol only implements 
> thrift_multiplexed_protocol_write_message_begin that's ok for sending 
> messages to a multiplexed server but not for the C server. We also need a 
> multiplexed processor for the server.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

[jeking3]

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1361
  
I cannot merge in a change that will knowingly break CI builds.

The tests that are failing need to be fixed (preferably) or disabled using 
the "test.py -U merge" I (hopefully) documented earlier.  Once the failing 
tests are disabled and the build passes we can merge.  We have a backlog of 
"known failing" test combinations that need attention and are not represented 
in the Jira backlog.


---

Re: Updating web site help - markdown links

[James E. King, III]

Resending, since I got no responses the first time...

On Sat, Nov 11, 2017 at 9:58 AM, James E. King, III 
wrote:

> There are some markdown files in docs/ that link to markdown files in
> build/ and when they are published, it doesn't work properly.  For example
> the "continuous integration environments" link from this page:
>
> https://thrift.apache.org/docs/Languages
>
> which comes from:
>
> /LANGUAGES.md
>
> and refers to:
>
> build/docker/README.md
>
> How do I get these links to work?  The web site is in desparate need of a
> refresh on "how to build", including moving everyone on Windows over to the
> CMake based project generation system and away from the static projects
> (for C++).
>
> Thanks,
>
> Jim
>

[jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256909#comment-16256909
 ] 

ASF GitHub Bot commented on THRIFT-4285:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1382
  
Since it's just documentation if you want to add it as a patch to a ticket 
instead of putting it through CI, someone can merge it from there.


> Pull generated send/recv into library to allow behaviour to be customised
> -
>
> Key: THRIFT-4285
> URL: https://issues.apache.org/jira/browse/THRIFT-4285
> Project: Thrift
>  Issue Type: Improvement
>  Components: Go - Compiler, Go - Library
>Reporter: Chris Bannister
>Assignee: Can Celasun
> Fix For: 0.11.0
>
> Attachments: 0001-go-pull-generated-send-recv-into-lib-v6.patch, 
> 0001-go-pull-generated-send-recv-into-lib-v7.patch
>
>
> Currently it is difficult to change how thrift writes messages onto the 
> transport because they are in the generated code. Instead the generated 
> send/recv methods should be in the library. This will greatly simplify the 
> client code and remove many duplicate methods whilst allowing users more 
> flexibility to implement connection pools and other features such as THeader.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1382: THRIFT-4285 Move TX/RX methods from gen. code to library

[jeking3]

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1382
  
Since it's just documentation if you want to add it as a patch to a ticket 
instead of putting it through CI, someone can merge it from there.


---

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256671#comment-16256671
 ] 

ASF GitHub Bot commented on THRIFT-4329:


Github user gadLinux commented on the issue:

https://github.com/apache/thrift/pull/1361
  
But I don't know about the languages that are failing. This is why I told 
you to open other issue and merge this.


> c_glib Doesn't have a multiplexed processor
> ---
>
> Key: THRIFT-4329
> URL: https://issues.apache.org/jira/browse/THRIFT-4329
> Project: Thrift
>  Issue Type: Bug
>  Components: C glib - Library
>Affects Versions: 0.10.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
>
> It seems that multiplexed protocol only implements 
> thrift_multiplexed_protocol_write_message_begin that's ok for sending 
> messages to a multiplexed server but not for the C server. We also need a 
> multiplexed processor for the server.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

[gadLinux]

Github user gadLinux commented on the issue:

https://github.com/apache/thrift/pull/1361
  
But I don't know about the languages that are failing. This is why I told 
you to open other issue and merge this.


---