[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

2017-11-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16258932#comment-16258932
 ] 

ASF GitHub Bot commented on THRIFT-4329:


Github user gadLinux commented on the issue:

https://github.com/apache/thrift/pull/1361
  
Hi @jeking3 it was a hard feature to merge... Hope we will do finer next 
time. Thank you for your continued support.


> c_glib Doesn't have a multiplexed processor
> ---
>
> Key: THRIFT-4329
> URL: https://issues.apache.org/jira/browse/THRIFT-4329
> Project: Thrift
>  Issue Type: Bug
>  Components: C glib - Library
>Affects Versions: 0.10.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
> Fix For: 0.11.0
>
>
> It seems that multiplexed protocol only implements 
> thrift_multiplexed_protocol_write_message_begin that's ok for sending 
> messages to a multiplexed server but not for the C server. We also need a 
> multiplexed processor for the server.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

2017-11-20 Thread gadLinux
Github user gadLinux commented on the issue:

https://github.com/apache/thrift/pull/1361
  
Hi @jeking3 it was a hard feature to merge... Hope we will do finer next 
time. Thank you for your continued support.


---


[GitHub] thrift issue #1411: Fix remote client for HTTP transport

2017-11-20 Thread dcelasun
Github user dcelasun commented on the issue:

https://github.com/apache/thrift/pull/1411
  
@jeking3 LGTM


---


[jira] [Commented] (THRIFT-4085) Add .NET Core to the make cross standard test suite

2017-11-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259181#comment-16259181
 ] 

ASF GitHub Bot commented on THRIFT-4085:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1415


> Add .NET Core to the make cross standard test suite
> ---
>
> Key: THRIFT-4085
> URL: https://issues.apache.org/jira/browse/THRIFT-4085
> Project: Thrift
>  Issue Type: Improvement
>  Components: Test Suite
>Affects Versions: 0.10.0
> Environment: Docker Images, Travis CI
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> .NET Core is not part of a standard make cross.  It should be enabled and run 
> with every build once there is a docker image with it inside.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] thrift pull request #1415: THRIFT-4085: refresh docker for dotnet 2.0.3, add...

2017-11-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1415


---


[jira] [Commented] (THRIFT-4085) Add .NET Core to the make cross standard test suite

2017-11-20 Thread James E. King, III (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259185#comment-16259185
 ] 

James E. King, III commented on THRIFT-4085:


Leaving this open - netcore is integrated into cross test as a client, but not 
as a server.  There were issues when I tried to enable it, wasn't working 
properly.

> Add .NET Core to the make cross standard test suite
> ---
>
> Key: THRIFT-4085
> URL: https://issues.apache.org/jira/browse/THRIFT-4085
> Project: Thrift
>  Issue Type: Improvement
>  Components: Test Suite
>Affects Versions: 0.10.0
> Environment: Docker Images, Travis CI
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> .NET Core is not part of a standard make cross.  It should be enabled and run 
> with every build once there is a docker image with it inside.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (THRIFT-4085) Add .NET Core to the make cross standard test suite as a server

2017-11-20 Thread James E. King, III (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III updated THRIFT-4085:
---
Summary: Add .NET Core to the make cross standard test suite as a server  
(was: Add .NET Core to the make cross standard test suite)

> Add .NET Core to the make cross standard test suite as a server
> ---
>
> Key: THRIFT-4085
> URL: https://issues.apache.org/jira/browse/THRIFT-4085
> Project: Thrift
>  Issue Type: Improvement
>  Components: Test Suite
>Affects Versions: 0.10.0
> Environment: Docker Images, Travis CI
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> .NET Core is not part of a standard make cross.  It should be enabled and run 
> with every build once there is a docker image with it inside.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (THRIFT-4085) Add .NET Core to the make cross standard test suite

2017-11-20 Thread James E. King, III (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III updated THRIFT-4085:
---
Summary: Add .NET Core to the make cross standard test suite  (was: Add 
.NET Core to the make cross standard test suite as a server)

> Add .NET Core to the make cross standard test suite
> ---
>
> Key: THRIFT-4085
> URL: https://issues.apache.org/jira/browse/THRIFT-4085
> Project: Thrift
>  Issue Type: Improvement
>  Components: Test Suite
>Affects Versions: 0.10.0
> Environment: Docker Images, Travis CI
>Reporter: James E. King, III
>Assignee: James E. King, III
>
> .NET Core is not part of a standard make cross.  It should be enabled and run 
> with every build once there is a docker image with it inside.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (THRIFT-4085) Add .NET Core to the make cross standard test suite

2017-11-20 Thread James E. King, III (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III reassigned THRIFT-4085:
--

Assignee: (was: James E. King, III)

> Add .NET Core to the make cross standard test suite
> ---
>
> Key: THRIFT-4085
> URL: https://issues.apache.org/jira/browse/THRIFT-4085
> Project: Thrift
>  Issue Type: Improvement
>  Components: Test Suite
>Affects Versions: 0.10.0
> Environment: Docker Images, Travis CI
>Reporter: James E. King, III
>
> .NET Core is not part of a standard make cross.  It should be enabled and run 
> with every build once there is a docker image with it inside.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] thrift pull request #1411: Fix remote client for HTTP transport

2017-11-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1411


---


[jira] [Assigned] (THRIFT-4385) Go remote client -u flag is broken

2017-11-20 Thread James E. King, III (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III reassigned THRIFT-4385:
--

Assignee: James E. King, III

> Go remote client -u flag is broken
> --
>
> Key: THRIFT-4385
> URL: https://issues.apache.org/jira/browse/THRIFT-4385
> Project: Thrift
>  Issue Type: Bug
>  Components: Go - Compiler
>Reporter: Dylan Trotter
>Assignee: James E. King, III
>
> There are two separate but trivial bugs in the Go remote implementation:
> * The parseUrl local variable is always empty because the code that attempts 
> to assign to it actually assigns to a new scoped variable (`parsedUrl, err := 
> url.Parse(urlString)`). This means that the -u flag does not work and the 
> http.Get() call deep in the stack returns an obscure message about the URL 
> scheme being empty (actually the whole URL is empty).
> * -When using HTTP transport the tool uses a THttpClient which issues a GET. 
> The Go http library assumes an empty body for GET requests which means that 
> the request payload does not accompany the request. Instead of using 
> THttpClient the tools should use THttpPostClient so that the request payload 
> will accompany the request.-
> The second issue above has separately been resolved: THttpPostClient is 
> deprecated and is just an alias for THttpClient since 0dd8235.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (THRIFT-4385) Go remote client -u flag is broken

2017-11-20 Thread James E. King, III (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III resolved THRIFT-4385.

   Resolution: Fixed
Fix Version/s: 0.11.0

Committed - thanks.

> Go remote client -u flag is broken
> --
>
> Key: THRIFT-4385
> URL: https://issues.apache.org/jira/browse/THRIFT-4385
> Project: Thrift
>  Issue Type: Bug
>  Components: Go - Compiler
>Reporter: Dylan Trotter
>Assignee: James E. King, III
> Fix For: 0.11.0
>
>
> There are two separate but trivial bugs in the Go remote implementation:
> * The parseUrl local variable is always empty because the code that attempts 
> to assign to it actually assigns to a new scoped variable (`parsedUrl, err := 
> url.Parse(urlString)`). This means that the -u flag does not work and the 
> http.Get() call deep in the stack returns an obscure message about the URL 
> scheme being empty (actually the whole URL is empty).
> * -When using HTTP transport the tool uses a THttpClient which issues a GET. 
> The Go http library assumes an empty body for GET requests which means that 
> the request payload does not accompany the request. Instead of using 
> THttpClient the tools should use THttpPostClient so that the request payload 
> will accompany the request.-
> The second issue above has separately been resolved: THttpPostClient is 
> deprecated and is just an alias for THttpClient since 0dd8235.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] thrift pull request #979: THRIFT-3779 Qt Client Android and Windows QTcpSock...

2017-11-20 Thread Gjergj
Github user Gjergj closed the pull request at:

https://github.com/apache/thrift/pull/979


---


[GitHub] thrift issue #979: THRIFT-3779 Qt Client Android and Windows QTcpSocket

2017-11-20 Thread Gjergj
Github user Gjergj commented on the issue:

https://github.com/apache/thrift/pull/979
  
Indeed, compiling 0.9.3 on Android was a pain. I had to get the cross 
compile cmake file from another project.
Since I was using Qt fro Android development, using QSocket was an easier 
to cross compile thrift for Android.

However I am not interested anymore to take this any further.


---


[jira] [Commented] (THRIFT-3779) Qt Client Android and Windows QTcpSocket

2017-11-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259233#comment-16259233
 ] 

ASF GitHub Bot commented on THRIFT-3779:


Github user Gjergj commented on the issue:

https://github.com/apache/thrift/pull/979
  
Indeed, compiling 0.9.3 on Android was a pain. I had to get the cross 
compile cmake file from another project.
Since I was using Qt fro Android development, using QSocket was an easier 
to cross compile thrift for Android.

However I am not interested anymore to take this any further.


> Qt Client Android and Windows QTcpSocket
> 
>
> Key: THRIFT-3779
> URL: https://issues.apache.org/jira/browse/THRIFT-3779
> Project: Thrift
>  Issue Type: New Feature
>  Components: C++ - Library
> Environment: Qt Windows, Qt Android on windows
>Reporter: Gjergji Ramku
>Priority: Minor
>  Labels: features
>
> Thrift Client library based on QTcpSocket.
> QTcpSocket should help make a tcp socket client run on all platforms where Qt 
> runs.
> Is there such port?
> I already have a port that I have tested on Qt Android and Qt Windows clients.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (THRIFT-3779) Qt Client Android and Windows QTcpSocket

2017-11-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259234#comment-16259234
 ] 

ASF GitHub Bot commented on THRIFT-3779:


Github user Gjergj closed the pull request at:

https://github.com/apache/thrift/pull/979


> Qt Client Android and Windows QTcpSocket
> 
>
> Key: THRIFT-3779
> URL: https://issues.apache.org/jira/browse/THRIFT-3779
> Project: Thrift
>  Issue Type: New Feature
>  Components: C++ - Library
> Environment: Qt Windows, Qt Android on windows
>Reporter: Gjergji Ramku
>Priority: Minor
>  Labels: features
>
> Thrift Client library based on QTcpSocket.
> QTcpSocket should help make a tcp socket client run on all platforms where Qt 
> runs.
> Is there such port?
> I already have a port that I have tested on Qt Android and Qt Windows clients.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)