[jira] [Created] (THRIFT-4452) optimize Dockerfile (only onetime apt-get update)
Robert Lu created THRIFT-4452: - Summary: optimize Dockerfile (only onetime apt-get update) Key: THRIFT-4452 URL: https://issues.apache.org/jira/browse/THRIFT-4452 Project: Thrift Issue Type: Improvement Components: Build Process Affects Versions: 0.11.0 Reporter: Robert Lu Assignee: Robert Lu Priority: Minor When build [apache/thrift-build|https://github.com/apache/thrift/blob/a15060a/build/docker/ubuntu-trusty/Dockerfile], there are many times to run apt-get update. We can just run one time apt-get update after add all repo. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1464: THRIFT-4452: optimize Dockerfile
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1464 THRIFT-4452: optimize Dockerfile Docker build flow: 1. add all repo 2. `apt-get update` (only one time) 3. install dependencies You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift dockerfile Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1464.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1464 commit a15a2d9bc2e952d984d20a08b7750eac24a3fa09 Author: Robert Lu Date: 2018-01-05T05:44:38Z optimize Dockerfile ---
[jira] [Commented] (THRIFT-4452) optimize Dockerfile (only onetime apt-get update)
[ https://issues.apache.org/jira/browse/THRIFT-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323507#comment-16323507 ] ASF GitHub Bot commented on THRIFT-4452: GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1464 THRIFT-4452: optimize Dockerfile Docker build flow: 1. add all repo 2. `apt-get update` (only one time) 3. install dependencies You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift dockerfile Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1464.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1464 commit a15a2d9bc2e952d984d20a08b7750eac24a3fa09 Author: Robert Lu Date: 2018-01-05T05:44:38Z optimize Dockerfile > optimize Dockerfile (only onetime apt-get update) > - > > Key: THRIFT-4452 > URL: https://issues.apache.org/jira/browse/THRIFT-4452 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.11.0 >Reporter: Robert Lu >Assignee: Robert Lu >Priority: Minor > > When build > [apache/thrift-build|https://github.com/apache/thrift/blob/a15060a/build/docker/ubuntu-trusty/Dockerfile], > there are many times to run apt-get update. > We can just run one time apt-get update after add all repo. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323307#comment-16323307 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 @jeking3 - It seems that fix for csharp lib tests with Tls1.2 can take more time and investigation because of possible situation that mono implements Tls1 - 1.2 in very specific way. Few issues related to that: - https://bugzilla.xamarin.com/show_bug.cgi?id=42805 - https://forums.xamarin.com/discussion/57683/tls-1-2-support - http://www.mono-project.com/docs/about-mono/releases/4.8.0/#tls-12-support - https://boringssl.googlesource.com/boringssl/ So, the simplest fix - I just reused Tls1 for .Net Core tests (by default for .Net Core implementation uses Tls 1.2). At least, .Net Core client will be able to connect to old csharp server. But to fix a csharp client, a lot of checks should be done, also maybe some specific modification of build process (building of boringssl, etc.) should be done too. Updated known_failures_Linux.json with issues related to described problem. I think checking fix for this bug in csharp/mono is for another task and time. > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 @jeking3 - It seems that fix for csharp lib tests with Tls1.2 can take more time and investigation because of possible situation that mono implements Tls1 - 1.2 in very specific way. Few issues related to that: - https://bugzilla.xamarin.com/show_bug.cgi?id=42805 - https://forums.xamarin.com/discussion/57683/tls-1-2-support - http://www.mono-project.com/docs/about-mono/releases/4.8.0/#tls-12-support - https://boringssl.googlesource.com/boringssl/ So, the simplest fix - I just reused Tls1 for .Net Core tests (by default for .Net Core implementation uses Tls 1.2). At least, .Net Core client will be able to connect to old csharp server. But to fix a csharp client, a lot of checks should be done, also maybe some specific modification of build process (building of boringssl, etc.) should be done too. Updated known_failures_Linux.json with issues related to described problem. I think checking fix for this bug in csharp/mono is for another task and time. ---
[jira] [Commented] (THRIFT-4448) Golang: do something with context.Context
[ https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323163#comment-16323163 ] ASF GitHub Bot commented on THRIFT-4448: Github user johnboiles commented on the issue: https://github.com/apache/thrift/pull/1459 I think that's the right approach. It’s pretty easy/fast to install golang from a tar.gz distribution. I do it pretty frequently to pin a specific version of go in docker images. I'll take a stab at updating this hopefully tomorrow or early next week. > Golang: do something with context.Context > - > > Key: THRIFT-4448 > URL: https://issues.apache.org/jira/browse/THRIFT-4448 > Project: Thrift > Issue Type: Task > Components: Go - Library >Affects Versions: 0.11.0 >Reporter: John Boiles > > PR Here: https://github.com/apache/thrift/pull/1459 > This patch wires through {{context.Context}} such that it can be used in in > {{http.Request}}'s {{WithContext}} method. This allows Thrift HTTP requests > to canceled or timed out via the context. > This patch breaks support for go<1.7 so it's not ready to ship, but I'm > hoping to get some direction on this. When does Thrift expect to drop support > of go1.7? It looks like the current solution is to duplicate files that need > to use {{golang.org/x/net/context}} and add a {{// +build !go1.7}} but > duplication seems unsustainable as the {{context}} package is imported more > places. > Go 1.7 was released 15 August 2016. Given Golang has had significant > performance improvements in most dot releases, I suspect most production > services stay reasonably up to date. Here at Periscope/Twitter we're on > go1.9.1, and we're a fairly large organization. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1459: THRIFT-4448: Golang: do something with context.Context
Github user johnboiles commented on the issue: https://github.com/apache/thrift/pull/1459 I think that's the right approach. Itâs pretty easy/fast to install golang from a tar.gz distribution. I do it pretty frequently to pin a specific version of go in docker images. I'll take a stab at updating this hopefully tomorrow or early next week. ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322911#comment-16322911 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Will try to quickly find the problem with old .Net tests - maybe version of Tls in implementation of tests and will update pull request if this is possible to do that quickly > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Will try to quickly find the problem with old .Net tests - maybe version of Tls in implementation of tests and will update pull request if this is possible to do that quickly ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322708#comment-16322708 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Thank you - updated :) > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Thank you - updated :) ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322634#comment-16322634 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 Try this: ``` struct member_mapping_scope { public: member_mapping_scope() : scope_member(0) { } void* scope_member; map mapping_table; }; ``` ``` // begin new scope member_mapping_scopes.push_back(member_mapping_scope()); ``` > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 Try this: ``` struct member_mapping_scope { public: member_mapping_scope() : scope_member(0) { } void* scope_member; map mapping_table; }; ``` ``` // begin new scope member_mapping_scopes.push_back(member_mapping_scope()); ``` ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322522#comment-16322522 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 Sure thing, I will take a look. > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 Sure thing, I will take a look. ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322514#comment-16322514 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Yes, please - I tried almost everything to make it compiling (it seem that it doesn't support modern styles of initialization and instead of warning generates an error). It's hard to reproduce this locally - I need to create a lot of environments to check all compilations locally - maybe we can improve it later :) Just want to merge working changes to main repo - a lot of improvements in this pull request for .Net Core version and still a lot of things to do (integration and unit tests, improvement of CMake scripts, etc.) > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Yes, please - I tried almost everything to make it compiling (it seem that it doesn't support modern styles of initialization and instead of warning generates an error). It's hard to reproduce this locally - I need to create a lot of environments to check all compilations locally - maybe we can improve it later :) Just want to merge working changes to main repo - a lot of improvements in this pull request for .Net Core version and still a lot of things to do (integration and unit tests, improvement of CMake scripts, etc.) ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322502#comment-16322502 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 If you want to force another CI build without code changes, you can: $ git commit --amend --no-edit $ git push (you may need to force push?) That will trigger a new commit and therefore a new build. If you want help with getting MSVC2010 building I can help with that, by pulling your changes into my windows system and using cmake to generate a visual studio 2010 solution, and getting it to build. The I can post the diff back here. Let me know if you want me to do that. > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 If you want to force another CI build without code changes, you can: $ git commit --amend --no-edit $ git push (you may need to force push?) That will trigger a new commit and therefore a new build. If you want help with getting MSVC2010 building I can help with that, by pulling your changes into my windows system and using cmake to generate a visual studio 2010 solution, and getting it to build. The I can post the diff back here. Let me know if you want me to do that. ---
Re: Crazy TBinaryProtocol
I am consuming a message coming over RabbitMQ using Python. Something to this tune: trans1 = TTransport.TMemoryBuffer() trans1.open() trans = TTransport.TMemoryBuffer(body) trans.open() iprot = TBinaryProtocol.TBinaryProtocol(trans) oprot = TBinaryProtocol.TBinaryProtocol(trans1, strictWrite=False) tr = Processor(CommonService.CommonService.Iface()) tr.process(iprot, oprot) (thrift 0.10.0) On Thu, Jan 11, 2018 at 3:50 PM, Allen George wrote: > Which client and server are you trying to use? > > Allen > > > On January 11, 2018 at 10:40:14 AM, André Lemos (ale...@plux.info) wrote: > > Hi, > > > When parsing through a TBinaryProtocol, trying to get the readMessageBegin, > readI32, returns 16777216, which will raise an EOFError, because it's just > a too big of a value. If I use something like 25, I do get something pretty > closer to what I am trying to get, although I still get the initial bit of > the protocol, and not just the name I am trying to get. > > Any hints as to where I should be looking? > > > > Ps.: sorry for the cross-post, but feedback seems to be a little slim on > the user@ side of things > > > Thank you, > > André >
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322440#comment-16322440 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 How we can trigger checks? Is it possible to trigger them manually? > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 How we can trigger checks? Is it possible to trigger them manually? ---
Re: Crazy TBinaryProtocol
Which client and server are you trying to use? Allen On January 11, 2018 at 10:40:14 AM, André Lemos (ale...@plux.info) wrote: Hi, When parsing through a TBinaryProtocol, trying to get the readMessageBegin, readI32, returns 16777216, which will raise an EOFError, because it's just a too big of a value. If I use something like 25, I do get something pretty closer to what I am trying to get, although I still get the initial bit of the protocol, and not just the name I am trying to get. Any hints as to where I should be looking? Ps.: sorry for the cross-post, but feedback seems to be a little slim on the user@ side of things Thank you, André
Crazy TBinaryProtocol
Hi, When parsing through a TBinaryProtocol, trying to get the readMessageBegin, readI32, returns 16777216, which will raise an EOFError, because it's just a too big of a value. If I use something like 25, I do get something pretty closer to what I am trying to get, although I still get the initial bit of the protocol, and not just the name I am trying to get. Any hints as to where I should be looking? Ps.: sorry for the cross-post, but feedback seems to be a little slim on the user@ side of things Thank you, André
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322402#comment-16322402 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 @jeking3 - https://blogs.msdn.microsoft.com/vcblog/2017/11/02/visual-studio-build-tools-now-include-the-vs2017-and-vs2015-msvc-toolsets/ - hope this will help to move easier to VS2017 and with builds > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 @jeking3 - https://blogs.msdn.microsoft.com/vcblog/2017/11/02/visual-studio-build-tools-now-include-the-vs2017-and-vs2015-msvc-toolsets/ - hope this will help to move easier to VS2017 and with builds ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322394#comment-16322394 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 I work on a project that still uses 2010, but we're moving to 2017. So there are still folks using it. Boost supports back to Visual Studio 2008 in some cases, for example. I think Boost is going to tie support to EOL or EOS of the compiler. Extended support on Visual Studio lasts 10 years, so if we follow that we can reasonably drop 2010 support in 2020. :) > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 I work on a project that still uses 2010, but we're moving to 2017. So there are still folks using it. Boost supports back to Visual Studio 2008 in some cases, for example. I think Boost is going to tie support to EOL or EOS of the compiler. Extended support on Visual Studio lasts 10 years, so if we follow that we can reasonably drop 2010 support in 2020. :) ---
[jira] [Commented] (THRIFT-4448) Golang: do something with context.Context
[ https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322347#comment-16322347 ] ASF GitHub Bot commented on THRIFT-4448: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1459 My thoughts after sleeping on it are that we should support the current Ubuntu LTS. That said, I have no problem telling folks not to use the ancient golang included in the LTS and to use something newer from either an Ubuntu PPA or directly form golang sources. I also found evidence in a number of other projects that support for golang 1.6 was dropped. So if you want to fix this in the way suggested, you will need to update the ubuntu-xenial Dockerfile to use golang 1.7 instead, and you should update the top level LANGUAGES.md file, add a breaking change note into the lib/go README file, and update the build/docker/README.md file. Thanks. > Golang: do something with context.Context > - > > Key: THRIFT-4448 > URL: https://issues.apache.org/jira/browse/THRIFT-4448 > Project: Thrift > Issue Type: Task > Components: Go - Library >Affects Versions: 0.11.0 >Reporter: John Boiles > > PR Here: https://github.com/apache/thrift/pull/1459 > This patch wires through {{context.Context}} such that it can be used in in > {{http.Request}}'s {{WithContext}} method. This allows Thrift HTTP requests > to canceled or timed out via the context. > This patch breaks support for go<1.7 so it's not ready to ship, but I'm > hoping to get some direction on this. When does Thrift expect to drop support > of go1.7? It looks like the current solution is to duplicate files that need > to use {{golang.org/x/net/context}} and add a {{// +build !go1.7}} but > duplication seems unsustainable as the {{context}} package is imported more > places. > Go 1.7 was released 15 August 2016. Given Golang has had significant > performance improvements in most dot releases, I suspect most production > services stay reasonably up to date. Here at Periscope/Twitter we're on > go1.9.1, and we're a fairly large organization. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1459: THRIFT-4448: Golang: do something with context.Context
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1459 My thoughts after sleeping on it are that we should support the current Ubuntu LTS. That said, I have no problem telling folks not to use the ancient golang included in the LTS and to use something newer from either an Ubuntu PPA or directly form golang sources. I also found evidence in a number of other projects that support for golang 1.6 was dropped. So if you want to fix this in the way suggested, you will need to update the ubuntu-xenial Dockerfile to use golang 1.7 instead, and you should update the top level LANGUAGES.md file, add a breaking change note into the lib/go README file, and update the build/docker/README.md file. Thanks. ---
[jira] [Resolved] (THRIFT-4423) migrate php library to psr-4
[ https://issues.apache.org/jira/browse/THRIFT-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4423. Resolution: Fixed Fix Version/s: 0.12.0 Committed - thanks! > migrate php library to psr-4 > > > Key: THRIFT-4423 > URL: https://issues.apache.org/jira/browse/THRIFT-4423 > Project: Thrift > Issue Type: Improvement > Components: PHP - Library >Affects Versions: 0.11.0 >Reporter: Robert Lu >Assignee: James E. King, III > Fix For: 0.12.0 > > > The latest autoload standard is [http://www.php-fig.org/psr/psr-4/]. > So, I migrate thrift to PSR-4. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4423) migrate php library to psr-4
[ https://issues.apache.org/jira/browse/THRIFT-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322337#comment-16322337 ] ASF GitHub Bot commented on THRIFT-4423: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1445 > migrate php library to psr-4 > > > Key: THRIFT-4423 > URL: https://issues.apache.org/jira/browse/THRIFT-4423 > Project: Thrift > Issue Type: Improvement > Components: PHP - Library >Affects Versions: 0.11.0 >Reporter: Robert Lu >Assignee: James E. King, III > Fix For: 0.12.0 > > > The latest autoload standard is [http://www.php-fig.org/psr/psr-4/]. > So, I migrate thrift to PSR-4. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1445: THRIFT-4423 migrate to psr-4
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1445 ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322332#comment-16322332 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 No it cannot. Few different tries - it seems that we will have few fixes and few more builds for only MSVC2010 > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 No it cannot. Few different tries - it seems that we will have few fixes and few more builds for only MSVC2010 ---
[jira] [Assigned] (THRIFT-4423) migrate php library to psr-4
[ https://issues.apache.org/jira/browse/THRIFT-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4423: -- Assignee: James E. King, III > migrate php library to psr-4 > > > Key: THRIFT-4423 > URL: https://issues.apache.org/jira/browse/THRIFT-4423 > Project: Thrift > Issue Type: Improvement > Components: PHP - Library >Affects Versions: 0.11.0 >Reporter: Robert Lu >Assignee: James E. King, III > > The latest autoload standard is [http://www.php-fig.org/psr/psr-4/]. > So, I migrate thrift to PSR-4. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322319#comment-16322319 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Didn't imagine that we still support MSVC2010 - almost every compiler was able to build the source code but MSVC2010 cannot - hope people will move from this to something more modern and improved. Let check results of build for MSVC2010. > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Didn't imagine that we still support MSVC2010 - almost every compiler was able to build the source code but MSVC2010 cannot - hope people will move from this to something more modern and improved. Let check results of build for MSVC2010. ---
[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322312#comment-16322312 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 I noticed that we can update the Dockerfile for artful to use dotnet-sdk-2.1.4 and it will pull in netcore 2.0.5, as opposed to 2.0.2 which is currently used, however we use the xenial image for cross tests right now. I am working on rebuilding the artful image and re-enabling haxe to see if we can get as many languages into artful as in xenial, then we can cut the cross test over to artful for CI. > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS >Reporter: Volodymyr Gotra >Assignee: Volodymyr Gotra >Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 I noticed that we can update the Dockerfile for artful to use dotnet-sdk-2.1.4 and it will pull in netcore 2.0.5, as opposed to 2.0.2 which is currently used, however we use the xenial image for cross tests right now. I am working on rebuilding the artful image and re-enabling haxe to see if we can get as many languages into artful as in xenial, then we can cut the cross test over to artful for CI. ---
Thrift 0.11.0, Maven, Need Help
Looking for a Java / Maven expert to resolve this issue. Our current build process is ant based with a maven task plug-in which is no longer maintained. This was used to create the pom and distribute to a maven repo. I do not know enough about maven packging or the ecosystem to be really effective here, so someone needs to step up. Anyone who does work on this should: 1. Pull in https://github.com/apache/thrift/pull/1456/files 2. Simplify the list of developers simply to: 1. id = dev 2. name = Thrift Developers 3. email = dev@thrift.apache.org 3. Provide instructions on how to build and publish to maven. Please see: https://issues.apache.org/jira/browse/THRIFT-4413 I linked as many related issues to it as I can. It is blocking other Apache projects from moving forward. If possible also look at https://issues.apache.org/jira/browse/THRIFT-4120 If we switch how we package or build, that should also be resolved. - Jim
[jira] [Commented] (THRIFT-4259) Thrift does not compile due to Ant Maven task errors
[ https://issues.apache.org/jira/browse/THRIFT-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322262#comment-16322262 ] James E. King, III commented on THRIFT-4259: Root cause: The ant build used by thrift requires a plug-in for maven and pom packaging, [Maven Ant Tasks|http://maven.apache.org/ant-tasks/], which is no longer maintained and only support ant 1.8. There is no substitute. The build for java needs an overhaul and modernization. > Thrift does not compile due to Ant Maven task errors > > > Key: THRIFT-4259 > URL: https://issues.apache.org/jira/browse/THRIFT-4259 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler >Affects Versions: 0.9.3, 0.10.0, 0.11.0 > Environment: Fedora 25, Linux, any project docker image (all use ant > 1.9.x) >Reporter: Jacek Furmankiewicz >Priority: Blocker > > Cannot compile neither 0.9.3 nor 0.10.0 > They both fail with same errors in the Ant / Maven task > - > ./configure --without-ruby --without-cpp --without-nodejs --without-python > --without-go --without-c_glib > /usr/bin/ant > Buildfile: /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build.xml > setup.init: > mvn.ant.tasks.check: > proxy: > mvn.ant.tasks.download: > [get] Getting: > http://repo1.maven.org/maven2/org/apache/maven/maven-ant-tasks/2.1.3/maven-ant-tasks-2.1.3.jar > [get] To: > /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build/tools/maven-ant-tasks-2.1.3.jar > [get] Not modified - so not downloaded > mvn.init: > BUILD FAILED > /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build.xml:324: > java.lang.NoSuchMethodError: > org.apache.maven.settings.RuntimeInfo.(Lorg/apache/maven/settings/Settings;)V > at > org.apache.maven.artifact.ant.AbstractArtifactTask.loadSettings(AbstractArtifactTask.java:328) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.initSettings(AbstractArtifactTask.java:278) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getSettings(AbstractArtifactTask.java:223) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getDefaultLocalRepository(AbstractArtifactTask.java:212) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getLocalRepository(AbstractArtifactTask.java:700) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.createLocalArtifactRepository(AbstractArtifactTask.java:110) > at org.apache.maven.artifact.ant.Pom.getMavenProject(Pom.java:272) > at org.apache.maven.artifact.ant.Pom.setGroupId(Pom.java:560) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.IntrospectionHelper$AttributeSetter.setObject(IntrospectionHelper.java:1506) > at > org.apache.tools.ant.IntrospectionHelper.setAttribute(IntrospectionHelper.java:411) > at > org.apache.tools.ant.RuntimeConfigurable.maybeConfigure(RuntimeConfigurable.java:527) > at > org.apache.tools.ant.RuntimeConfigurable.maybeConfigure(RuntimeConfigurable.java:463) > at org.apache.tools.ant.Task.maybeConfigure(Task.java:202) > at > org.apache.tools.ant.UnknownElement.configure(UnknownElement.java:200) > at > org.apache.tools.ant.UnknownElement.maybeConfigure(UnknownElement.java:164) > at org.apache.tools.ant.Task.perform(Task.java:347) > at org.apache.tools.ant.Target.execute(Target.java:435) > at org.apache.tools.ant.Target.performTasks(Target.java:456) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1405) > at org.apache.tools.ant.Project.executeTarget(Project.java:1376) > at > org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) > at org.apache.tools.ant.Project.executeTargets(Project.java:1260) > at org.apache.tools.ant.Main.runBuild(Main.java:853) > at org.apache.tools.ant.Main.startAnt(Main.java:235) > at org.apache.tools.ant.launch.Launcher.run(Launcher.java:285) > at org.apache.tools.ant.launch.Launcher.main(Launcher.java:112) > Total time: 0 seconds > Totally blocked, cannot install Thrift on my box, critical for our > development. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (THRIFT-4259) Thrift does not compile due to Ant Maven task errors
[ https://issues.apache.org/jira/browse/THRIFT-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4259: --- Environment: Fedora 25, Linux, any project docker image (all use ant 1.9.x) (was: Fedora 25, Linux) > Thrift does not compile due to Ant Maven task errors > > > Key: THRIFT-4259 > URL: https://issues.apache.org/jira/browse/THRIFT-4259 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler >Affects Versions: 0.9.3, 0.10.0, 0.11.0 > Environment: Fedora 25, Linux, any project docker image (all use ant > 1.9.x) >Reporter: Jacek Furmankiewicz >Priority: Blocker > > Cannot compile neither 0.9.3 nor 0.10.0 > They both fail with same errors in the Ant / Maven task > - > ./configure --without-ruby --without-cpp --without-nodejs --without-python > --without-go --without-c_glib > /usr/bin/ant > Buildfile: /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build.xml > setup.init: > mvn.ant.tasks.check: > proxy: > mvn.ant.tasks.download: > [get] Getting: > http://repo1.maven.org/maven2/org/apache/maven/maven-ant-tasks/2.1.3/maven-ant-tasks-2.1.3.jar > [get] To: > /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build/tools/maven-ant-tasks-2.1.3.jar > [get] Not modified - so not downloaded > mvn.init: > BUILD FAILED > /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build.xml:324: > java.lang.NoSuchMethodError: > org.apache.maven.settings.RuntimeInfo.(Lorg/apache/maven/settings/Settings;)V > at > org.apache.maven.artifact.ant.AbstractArtifactTask.loadSettings(AbstractArtifactTask.java:328) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.initSettings(AbstractArtifactTask.java:278) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getSettings(AbstractArtifactTask.java:223) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getDefaultLocalRepository(AbstractArtifactTask.java:212) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getLocalRepository(AbstractArtifactTask.java:700) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.createLocalArtifactRepository(AbstractArtifactTask.java:110) > at org.apache.maven.artifact.ant.Pom.getMavenProject(Pom.java:272) > at org.apache.maven.artifact.ant.Pom.setGroupId(Pom.java:560) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.IntrospectionHelper$AttributeSetter.setObject(IntrospectionHelper.java:1506) > at > org.apache.tools.ant.IntrospectionHelper.setAttribute(IntrospectionHelper.java:411) > at > org.apache.tools.ant.RuntimeConfigurable.maybeConfigure(RuntimeConfigurable.java:527) > at > org.apache.tools.ant.RuntimeConfigurable.maybeConfigure(RuntimeConfigurable.java:463) > at org.apache.tools.ant.Task.maybeConfigure(Task.java:202) > at > org.apache.tools.ant.UnknownElement.configure(UnknownElement.java:200) > at > org.apache.tools.ant.UnknownElement.maybeConfigure(UnknownElement.java:164) > at org.apache.tools.ant.Task.perform(Task.java:347) > at org.apache.tools.ant.Target.execute(Target.java:435) > at org.apache.tools.ant.Target.performTasks(Target.java:456) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1405) > at org.apache.tools.ant.Project.executeTarget(Project.java:1376) > at > org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) > at org.apache.tools.ant.Project.executeTargets(Project.java:1260) > at org.apache.tools.ant.Main.runBuild(Main.java:853) > at org.apache.tools.ant.Main.startAnt(Main.java:235) > at org.apache.tools.ant.launch.Launcher.run(Launcher.java:285) > at org.apache.tools.ant.launch.Launcher.main(Launcher.java:112) > Total time: 0 seconds > Totally blocked, cannot install Thrift on my box, critical for our > development. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (THRIFT-4259) Thrift does not compile due to Ant Maven task errors
[ https://issues.apache.org/jira/browse/THRIFT-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4259: --- Affects Version/s: 0.11.0 > Thrift does not compile due to Ant Maven task errors > > > Key: THRIFT-4259 > URL: https://issues.apache.org/jira/browse/THRIFT-4259 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler >Affects Versions: 0.9.3, 0.10.0, 0.11.0 > Environment: Fedora 25, Linux >Reporter: Jacek Furmankiewicz >Priority: Blocker > > Cannot compile neither 0.9.3 nor 0.10.0 > They both fail with same errors in the Ant / Maven task > - > ./configure --without-ruby --without-cpp --without-nodejs --without-python > --without-go --without-c_glib > /usr/bin/ant > Buildfile: /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build.xml > setup.init: > mvn.ant.tasks.check: > proxy: > mvn.ant.tasks.download: > [get] Getting: > http://repo1.maven.org/maven2/org/apache/maven/maven-ant-tasks/2.1.3/maven-ant-tasks-2.1.3.jar > [get] To: > /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build/tools/maven-ant-tasks-2.1.3.jar > [get] Not modified - so not downloaded > mvn.init: > BUILD FAILED > /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build.xml:324: > java.lang.NoSuchMethodError: > org.apache.maven.settings.RuntimeInfo.(Lorg/apache/maven/settings/Settings;)V > at > org.apache.maven.artifact.ant.AbstractArtifactTask.loadSettings(AbstractArtifactTask.java:328) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.initSettings(AbstractArtifactTask.java:278) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getSettings(AbstractArtifactTask.java:223) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getDefaultLocalRepository(AbstractArtifactTask.java:212) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getLocalRepository(AbstractArtifactTask.java:700) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.createLocalArtifactRepository(AbstractArtifactTask.java:110) > at org.apache.maven.artifact.ant.Pom.getMavenProject(Pom.java:272) > at org.apache.maven.artifact.ant.Pom.setGroupId(Pom.java:560) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.IntrospectionHelper$AttributeSetter.setObject(IntrospectionHelper.java:1506) > at > org.apache.tools.ant.IntrospectionHelper.setAttribute(IntrospectionHelper.java:411) > at > org.apache.tools.ant.RuntimeConfigurable.maybeConfigure(RuntimeConfigurable.java:527) > at > org.apache.tools.ant.RuntimeConfigurable.maybeConfigure(RuntimeConfigurable.java:463) > at org.apache.tools.ant.Task.maybeConfigure(Task.java:202) > at > org.apache.tools.ant.UnknownElement.configure(UnknownElement.java:200) > at > org.apache.tools.ant.UnknownElement.maybeConfigure(UnknownElement.java:164) > at org.apache.tools.ant.Task.perform(Task.java:347) > at org.apache.tools.ant.Target.execute(Target.java:435) > at org.apache.tools.ant.Target.performTasks(Target.java:456) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1405) > at org.apache.tools.ant.Project.executeTarget(Project.java:1376) > at > org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) > at org.apache.tools.ant.Project.executeTargets(Project.java:1260) > at org.apache.tools.ant.Main.runBuild(Main.java:853) > at org.apache.tools.ant.Main.startAnt(Main.java:235) > at org.apache.tools.ant.launch.Launcher.run(Launcher.java:285) > at org.apache.tools.ant.launch.Launcher.main(Launcher.java:112) > Total time: 0 seconds > Totally blocked, cannot install Thrift on my box, critical for our > development. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4259) Thrift does not compile due to Ant Maven task errors
[ https://issues.apache.org/jira/browse/THRIFT-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322254#comment-16322254 ] James E. King, III commented on THRIFT-4259: I agree with your assessment. Someone with maven expertise needs to step up. > Thrift does not compile due to Ant Maven task errors > > > Key: THRIFT-4259 > URL: https://issues.apache.org/jira/browse/THRIFT-4259 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler >Affects Versions: 0.9.3, 0.10.0, 0.11.0 > Environment: Fedora 25, Linux >Reporter: Jacek Furmankiewicz >Priority: Blocker > > Cannot compile neither 0.9.3 nor 0.10.0 > They both fail with same errors in the Ant / Maven task > - > ./configure --without-ruby --without-cpp --without-nodejs --without-python > --without-go --without-c_glib > /usr/bin/ant > Buildfile: /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build.xml > setup.init: > mvn.ant.tasks.check: > proxy: > mvn.ant.tasks.download: > [get] Getting: > http://repo1.maven.org/maven2/org/apache/maven/maven-ant-tasks/2.1.3/maven-ant-tasks-2.1.3.jar > [get] To: > /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build/tools/maven-ant-tasks-2.1.3.jar > [get] Not modified - so not downloaded > mvn.init: > BUILD FAILED > /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build.xml:324: > java.lang.NoSuchMethodError: > org.apache.maven.settings.RuntimeInfo.(Lorg/apache/maven/settings/Settings;)V > at > org.apache.maven.artifact.ant.AbstractArtifactTask.loadSettings(AbstractArtifactTask.java:328) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.initSettings(AbstractArtifactTask.java:278) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getSettings(AbstractArtifactTask.java:223) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getDefaultLocalRepository(AbstractArtifactTask.java:212) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getLocalRepository(AbstractArtifactTask.java:700) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.createLocalArtifactRepository(AbstractArtifactTask.java:110) > at org.apache.maven.artifact.ant.Pom.getMavenProject(Pom.java:272) > at org.apache.maven.artifact.ant.Pom.setGroupId(Pom.java:560) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.IntrospectionHelper$AttributeSetter.setObject(IntrospectionHelper.java:1506) > at > org.apache.tools.ant.IntrospectionHelper.setAttribute(IntrospectionHelper.java:411) > at > org.apache.tools.ant.RuntimeConfigurable.maybeConfigure(RuntimeConfigurable.java:527) > at > org.apache.tools.ant.RuntimeConfigurable.maybeConfigure(RuntimeConfigurable.java:463) > at org.apache.tools.ant.Task.maybeConfigure(Task.java:202) > at > org.apache.tools.ant.UnknownElement.configure(UnknownElement.java:200) > at > org.apache.tools.ant.UnknownElement.maybeConfigure(UnknownElement.java:164) > at org.apache.tools.ant.Task.perform(Task.java:347) > at org.apache.tools.ant.Target.execute(Target.java:435) > at org.apache.tools.ant.Target.performTasks(Target.java:456) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1405) > at org.apache.tools.ant.Project.executeTarget(Project.java:1376) > at > org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) > at org.apache.tools.ant.Project.executeTargets(Project.java:1260) > at org.apache.tools.ant.Main.runBuild(Main.java:853) > at org.apache.tools.ant.Main.startAnt(Main.java:235) > at org.apache.tools.ant.launch.Launcher.run(Launcher.java:285) > at org.apache.tools.ant.launch.Launcher.main(Launcher.java:112) > Total time: 0 seconds > Totally blocked, cannot install Thrift on my box, critical for our > development. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (THRIFT-4259) Thrift does not compile due to Ant Maven task errors
[ https://issues.apache.org/jira/browse/THRIFT-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4259: -- Assignee: (was: James E. King, III) > Thrift does not compile due to Ant Maven task errors > > > Key: THRIFT-4259 > URL: https://issues.apache.org/jira/browse/THRIFT-4259 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler >Affects Versions: 0.9.3, 0.10.0 > Environment: Fedora 25, Linux >Reporter: Jacek Furmankiewicz >Priority: Blocker > > Cannot compile neither 0.9.3 nor 0.10.0 > They both fail with same errors in the Ant / Maven task > - > ./configure --without-ruby --without-cpp --without-nodejs --without-python > --without-go --without-c_glib > /usr/bin/ant > Buildfile: /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build.xml > setup.init: > mvn.ant.tasks.check: > proxy: > mvn.ant.tasks.download: > [get] Getting: > http://repo1.maven.org/maven2/org/apache/maven/maven-ant-tasks/2.1.3/maven-ant-tasks-2.1.3.jar > [get] To: > /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build/tools/maven-ant-tasks-2.1.3.jar > [get] Not modified - so not downloaded > mvn.init: > BUILD FAILED > /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build.xml:324: > java.lang.NoSuchMethodError: > org.apache.maven.settings.RuntimeInfo.(Lorg/apache/maven/settings/Settings;)V > at > org.apache.maven.artifact.ant.AbstractArtifactTask.loadSettings(AbstractArtifactTask.java:328) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.initSettings(AbstractArtifactTask.java:278) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getSettings(AbstractArtifactTask.java:223) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getDefaultLocalRepository(AbstractArtifactTask.java:212) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getLocalRepository(AbstractArtifactTask.java:700) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.createLocalArtifactRepository(AbstractArtifactTask.java:110) > at org.apache.maven.artifact.ant.Pom.getMavenProject(Pom.java:272) > at org.apache.maven.artifact.ant.Pom.setGroupId(Pom.java:560) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.IntrospectionHelper$AttributeSetter.setObject(IntrospectionHelper.java:1506) > at > org.apache.tools.ant.IntrospectionHelper.setAttribute(IntrospectionHelper.java:411) > at > org.apache.tools.ant.RuntimeConfigurable.maybeConfigure(RuntimeConfigurable.java:527) > at > org.apache.tools.ant.RuntimeConfigurable.maybeConfigure(RuntimeConfigurable.java:463) > at org.apache.tools.ant.Task.maybeConfigure(Task.java:202) > at > org.apache.tools.ant.UnknownElement.configure(UnknownElement.java:200) > at > org.apache.tools.ant.UnknownElement.maybeConfigure(UnknownElement.java:164) > at org.apache.tools.ant.Task.perform(Task.java:347) > at org.apache.tools.ant.Target.execute(Target.java:435) > at org.apache.tools.ant.Target.performTasks(Target.java:456) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1405) > at org.apache.tools.ant.Project.executeTarget(Project.java:1376) > at > org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) > at org.apache.tools.ant.Project.executeTargets(Project.java:1260) > at org.apache.tools.ant.Main.runBuild(Main.java:853) > at org.apache.tools.ant.Main.startAnt(Main.java:235) > at org.apache.tools.ant.launch.Launcher.run(Launcher.java:285) > at org.apache.tools.ant.launch.Launcher.main(Launcher.java:112) > Total time: 0 seconds > Totally blocked, cannot install Thrift on my box, critical for our > development. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (THRIFT-4259) Thrift does not compile due to Ant Maven task errors
[ https://issues.apache.org/jira/browse/THRIFT-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4259: -- Assignee: James E. King, III > Thrift does not compile due to Ant Maven task errors > > > Key: THRIFT-4259 > URL: https://issues.apache.org/jira/browse/THRIFT-4259 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler >Affects Versions: 0.9.3, 0.10.0 > Environment: Fedora 25, Linux >Reporter: Jacek Furmankiewicz >Assignee: James E. King, III >Priority: Blocker > > Cannot compile neither 0.9.3 nor 0.10.0 > They both fail with same errors in the Ant / Maven task > - > ./configure --without-ruby --without-cpp --without-nodejs --without-python > --without-go --without-c_glib > /usr/bin/ant > Buildfile: /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build.xml > setup.init: > mvn.ant.tasks.check: > proxy: > mvn.ant.tasks.download: > [get] Getting: > http://repo1.maven.org/maven2/org/apache/maven/maven-ant-tasks/2.1.3/maven-ant-tasks-2.1.3.jar > [get] To: > /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build/tools/maven-ant-tasks-2.1.3.jar > [get] Not modified - so not downloaded > mvn.init: > BUILD FAILED > /home/jfurmank/Downloads/thrift-0.10.0/lib/java/build.xml:324: > java.lang.NoSuchMethodError: > org.apache.maven.settings.RuntimeInfo.(Lorg/apache/maven/settings/Settings;)V > at > org.apache.maven.artifact.ant.AbstractArtifactTask.loadSettings(AbstractArtifactTask.java:328) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.initSettings(AbstractArtifactTask.java:278) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getSettings(AbstractArtifactTask.java:223) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getDefaultLocalRepository(AbstractArtifactTask.java:212) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.getLocalRepository(AbstractArtifactTask.java:700) > at > org.apache.maven.artifact.ant.AbstractArtifactTask.createLocalArtifactRepository(AbstractArtifactTask.java:110) > at org.apache.maven.artifact.ant.Pom.getMavenProject(Pom.java:272) > at org.apache.maven.artifact.ant.Pom.setGroupId(Pom.java:560) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.tools.ant.IntrospectionHelper$AttributeSetter.setObject(IntrospectionHelper.java:1506) > at > org.apache.tools.ant.IntrospectionHelper.setAttribute(IntrospectionHelper.java:411) > at > org.apache.tools.ant.RuntimeConfigurable.maybeConfigure(RuntimeConfigurable.java:527) > at > org.apache.tools.ant.RuntimeConfigurable.maybeConfigure(RuntimeConfigurable.java:463) > at org.apache.tools.ant.Task.maybeConfigure(Task.java:202) > at > org.apache.tools.ant.UnknownElement.configure(UnknownElement.java:200) > at > org.apache.tools.ant.UnknownElement.maybeConfigure(UnknownElement.java:164) > at org.apache.tools.ant.Task.perform(Task.java:347) > at org.apache.tools.ant.Target.execute(Target.java:435) > at org.apache.tools.ant.Target.performTasks(Target.java:456) > at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1405) > at org.apache.tools.ant.Project.executeTarget(Project.java:1376) > at > org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) > at org.apache.tools.ant.Project.executeTargets(Project.java:1260) > at org.apache.tools.ant.Main.runBuild(Main.java:853) > at org.apache.tools.ant.Main.startAnt(Main.java:235) > at org.apache.tools.ant.launch.Launcher.run(Launcher.java:285) > at org.apache.tools.ant.launch.Launcher.main(Launcher.java:112) > Total time: 0 seconds > Totally blocked, cannot install Thrift on my box, critical for our > development. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (THRIFT-487) ThreadManagerTests::blockTest errors
[ https://issues.apache.org/jira/browse/THRIFT-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-487. --- Resolution: Duplicate Assignee: James E. King, III Fix Version/s: 0.10.0 I am resolving this as fixed in version 0.10.0; there were significant ThreadManager changes to stabilize it (see THRIFT-3932). > ThreadManagerTests::blockTest errors > > > Key: THRIFT-487 > URL: https://issues.apache.org/jira/browse/THRIFT-487 > Project: Thrift > Issue Type: Bug > Components: Test Suite >Affects Versions: 0.1 > Environment: Mac OS X 10.5.6, Xcode >Reporter: Rush Manbert >Assignee: James E. King, III > Fix For: 0.10.0 > > Attachments: Tests.cpp.patch, ThreadManagerTests.h.patch > > > The ThreadManagerTests::blockTest() method and its associated > ThreadManagerTests::BlockTask class have errors and race conditions that > cause frequent failures in the test. Some failure modes return to the caller, > but others just hang the test forever. The main problem is that the test > function relies on indirect indications that its tasks have reached certain > known conditions. The indications that it sees are actually caused by the > ThreadManager's Workers, and this results in a number of race conditions > between the test function and the BlockTasks. > There are 2 patch files attached. One patches the ThreadManagerTests.h file > to fix the test. The other patches Tests.cpp so that it will run the > blockTest in a loop. In my experience, an unpatched version of > ThreadManagerTests.h generally fails within 100 iterations. After being > patched, the test will still fail unless a separate patch is applied to the > ThreadManager.cpp file. That patch is part of another issue that I haven't > entered yet (because it needs to refer to this one). When I know its number I > will add a comment. Anyway, if the patch is applied to ThreadManagerTests.h, > but not to ThreadManager.cpp, then the test will still fail, generally with > an assert, but sometimes with a Bus Error. > Test Procedure: > 1) Apply the Tests.cpp patch. This makes the thread-manager portion of the > test run ONLY the blockTest in an effectively infinite loop. > 2) Run a make in lib/cpp in order to rebuild concurrency-test > 3) Run concurrency test with the command line argument "thread-manager". This > will start the blockTest loop. It should fail in a fairly short time. > Repeated runs may fail different ways, including infinite hangs. > 4) Apply the patch to ThreadManagerTests.h. > 5) Run make in lib/cpp to rebuild concurrency-test > 6) Run concurrency_test as before. It should probably run for a longer period > of time. I have seen it run for an hour or more after beng patched. > Eventually it should fail either with an assert in Monitor.cpp while trying > to destroy a pthread_mutex_t, or it will get a Bus Error because it tried to > execute invalid memory. I have also seen it hang forever. > In order to resolve the remaining issues, a patch needs to be applied to > ThreadManager.cpp. I will add a comment about that as soon as the issue is > filed and the patch is available. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Closed] (THRIFT-487) ThreadManagerTests::blockTest errors
[ https://issues.apache.org/jira/browse/THRIFT-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-487. - > ThreadManagerTests::blockTest errors > > > Key: THRIFT-487 > URL: https://issues.apache.org/jira/browse/THRIFT-487 > Project: Thrift > Issue Type: Bug > Components: Test Suite >Affects Versions: 0.1 > Environment: Mac OS X 10.5.6, Xcode >Reporter: Rush Manbert >Assignee: James E. King, III > Fix For: 0.10.0 > > Attachments: Tests.cpp.patch, ThreadManagerTests.h.patch > > > The ThreadManagerTests::blockTest() method and its associated > ThreadManagerTests::BlockTask class have errors and race conditions that > cause frequent failures in the test. Some failure modes return to the caller, > but others just hang the test forever. The main problem is that the test > function relies on indirect indications that its tasks have reached certain > known conditions. The indications that it sees are actually caused by the > ThreadManager's Workers, and this results in a number of race conditions > between the test function and the BlockTasks. > There are 2 patch files attached. One patches the ThreadManagerTests.h file > to fix the test. The other patches Tests.cpp so that it will run the > blockTest in a loop. In my experience, an unpatched version of > ThreadManagerTests.h generally fails within 100 iterations. After being > patched, the test will still fail unless a separate patch is applied to the > ThreadManager.cpp file. That patch is part of another issue that I haven't > entered yet (because it needs to refer to this one). When I know its number I > will add a comment. Anyway, if the patch is applied to ThreadManagerTests.h, > but not to ThreadManager.cpp, then the test will still fail, generally with > an assert, but sometimes with a Bus Error. > Test Procedure: > 1) Apply the Tests.cpp patch. This makes the thread-manager portion of the > test run ONLY the blockTest in an effectively infinite loop. > 2) Run a make in lib/cpp in order to rebuild concurrency-test > 3) Run concurrency test with the command line argument "thread-manager". This > will start the blockTest loop. It should fail in a fairly short time. > Repeated runs may fail different ways, including infinite hangs. > 4) Apply the patch to ThreadManagerTests.h. > 5) Run make in lib/cpp to rebuild concurrency-test > 6) Run concurrency_test as before. It should probably run for a longer period > of time. I have seen it run for an hour or more after beng patched. > Eventually it should fail either with an assert in Monitor.cpp while trying > to destroy a pthread_mutex_t, or it will get a Bus Error because it tried to > execute invalid memory. I have also seen it hang forever. > In order to resolve the remaining issues, a patch needs to be applied to > ThreadManager.cpp. I will add a comment about that as soon as the issue is > filed and the patch is available. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4390) Rust binary protocol and buffered transport cannot handle writes above 4096 bytes
[ https://issues.apache.org/jira/browse/THRIFT-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322156#comment-16322156 ] ASF GitHub Bot commented on THRIFT-4390: Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1458 @jeking3 Thank you! So...updated the PR to re-add the three failing tests. Created [THRIFT-4451](https://issues.apache.org/jira/browse/THRIFT-4451) to track this. I'm going to fix up the framed transport first, circle back to 4451, and then handle dart/c++ issues. > Rust binary protocol and buffered transport cannot handle writes above 4096 > bytes > - > > Key: THRIFT-4390 > URL: https://issues.apache.org/jira/browse/THRIFT-4390 > Project: Thrift > Issue Type: Bug > Components: Rust - Library >Affects Versions: 0.10.0 > Environment: docker image ubuntu-artful >Reporter: James E. King, III >Assignee: Allen George >Priority: Critical > > While working on improving test coverage and fixing busted cross tests I > reworked the cpp test client to send binary in at size 0, 1, 2, 4, 6, 16, > ..., 131072 and after 4096 the rust server gave up. > {noformat} > 12, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, > 127, 128]) > WARN:thrift::server::threaded: processor completed with error: TransportError > { kind: Unknown, message: "failed to write whole buffer" } > Server process is successfully killed. > {noformat} > @gadLinux this may be the root cause of some of the issues you were seeing > with the interop against c_glib recently. It is the root cause of some (if > not all of) the rs-csharp test failures. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4423) migrate php library to psr-4
[ https://issues.apache.org/jira/browse/THRIFT-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322157#comment-16322157 ] ASF GitHub Bot commented on THRIFT-4423: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1445 That pesky concurrency test! > migrate php library to psr-4 > > > Key: THRIFT-4423 > URL: https://issues.apache.org/jira/browse/THRIFT-4423 > Project: Thrift > Issue Type: Improvement > Components: PHP - Library >Affects Versions: 0.11.0 >Reporter: Robert Lu > > The latest autoload standard is [http://www.php-fig.org/psr/psr-4/]. > So, I migrate thrift to PSR-4. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift issue #1445: THRIFT-4423 migrate to psr-4
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1445 That pesky concurrency test! ---
[GitHub] thrift issue #1458: THRIFT-4390: Fix bug where binary/buffered messages > 4K...
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1458 @jeking3 Thank you! So...updated the PR to re-add the three failing tests. Created [THRIFT-4451](https://issues.apache.org/jira/browse/THRIFT-4451) to track this. I'm going to fix up the framed transport first, circle back to 4451, and then handle dart/c++ issues. ---
[jira] [Created] (THRIFT-4451) Rust client fails to communicate with multiplexed perl/c_glib servers
Allen George created THRIFT-4451: Summary: Rust client fails to communicate with multiplexed perl/c_glib servers Key: THRIFT-4451 URL: https://issues.apache.org/jira/browse/THRIFT-4451 Project: Thrift Issue Type: Bug Components: Rust - Library Reporter: Allen George Assignee: Allen George As stated in description. Minimal case is to comment out everything in the Rust {{test_client}} leaving only the {{SecondService}} call behind. >From what I can tell the Rust socket isn't getting *any* bytes at all for the >response (i.e. it can't even get the first 4 bytes of the message header). >There is a {{flush()}} call on the remote side - so that's puzzling. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Planning to close all 2014 and 2015 pull requests
Sounds great! On January 10, 2018 at 11:56:56 PM, James E. King, III (jk...@apache.org) wrote: Tomorrow I plan on adding a comment to each of these pull requests and closing them by submitting an empty commit with github directives into the trunk. We're going to start getting more aggressive with maintaining the pull request backlog. Things cannot sit for 3 or 4 years. For items submitted in 2016 we're going to ask authors to refresh and get them passing, or we are going to close them out over the next couple months. We need to get the open PR list down to 10 or less. - Jim
Call for Presentations FOSS Backstage open
Hi, As announced on Berlin Buzzwords we (that is Isabel Drost-Fromm, Stefan Rudnitzki as well as the eventing team over at newthinking communications GmbH) are working on a new conference in summer in Berlin. The name of this new conference will be "FOSS Backstage". Backstage comprises all things FOSS governance, open collaboration and how to build and manage communities within the open source space. Submission URL: https://foss-backstage.de/call-papers The event will comprise presentations on all things FOSS governance, decentralised decision making, open collaboration. We invite you to submit talks on the topics: FOSS project governance, collaboration, community management. Asynchronous/ decentralised decision making. Vendor neutrality in FOSS, sustainable FOSS, cross team collaboration. Dealing with poisonous people. Project growth and hand-over. Trademarks. Strategic licensing. While it's primarily targeted at contributions from FOSS people, we would love to also learn more on how typical FOSS collaboration models work well within enterprises. Closely related topics not explicitly listed above are welcome. Important Dates (all dates in GMT +2) Submission deadline: February 18th, 2018. Conference: June, 13th/14th, 2018 High quality talks are called for, ranging from principles to practice. We are looking for real world case studies, background on the social architecture of specific projects and a deep dive into cross community collaboration. Acceptance notifications will be sent out soon after the submission deadline. Please include your name, bio and email, the title of the talk, a brief abstract in English language. We have drafted the submission form to allow for regular talks, each 45 min in length. However you are free to submit your own ideas on how to support the event: If you would like to take our attendees out to show them your favourite bar in Berlin, please submit this offer through the CfP form. If you are interested in sponsoring the event (e.g. we would be happy to provide videos after the event, free drinks for attendees as well as an after-show party), please contact us. Schedule and further updates on the event will be published soon on the event web page. Please re-distribute this CfP to people who might be interested. Contact us at: newthinking communications GmbH Schoenhauser Allee 6/7 10119 Berlin, Germany i...@foss-backstage.de Looking forward to meeting you all in person in summer :) I would love to see all those tracks filled with lots of valuable talks on the Apache Way, on how we work, on how the incubator works, on how being a 501(c3) influences how people get involved and projects are being run, on how being a member run organisation is different, on merit for life, on growing communities, on things gone great - and things gone entirely wrong in the ASF's history, on how to interact with Apache projects as a corporation and everything else you can think of. Isabel -- Sorry for any typos: Mail was typed in vim, written in mutt, via ssh (most likely involving some kind of mobile connection only.)