[jira] [Commented] (THRIFT-3773) Swift Library
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327475#comment-16327475 ] ASF GitHub Bot commented on THRIFT-3773: Github user apocolipse commented on the issue: https://github.com/apache/thrift/pull/1084 @jeking3 Squashed > Swift Library > - > > Key: THRIFT-3773 > URL: https://issues.apache.org/jira/browse/THRIFT-3773 > Project: Thrift > Issue Type: New Feature > Components: Swift - Library >Reporter: Thomas Bartelmess >Assignee: Chris Simpson >Priority: Major > > We already have the option to generate Swift code in the Cocoa compiler, > however large parts of the (Objective-C) Cocoa Library still depend on Cocoa > and Objective-C. > It would be good to have a native Swift library that doesn't depend on the > Cocoa libraries. > Design goals: > - Fully compatible with the code that is currently generated by the Cocoa > compiler (both Objective-C and Swift). > - Ability to run on Linux > - Pure Swift, no Objective-C code. > - No dependencies on closed source apple libraries > - Keep the same interface, so that the library is compatible with the code > the current cocoa compiler generates > - Better server support that the current Objective-C library. > - Follow the new Swift packaging format to be compatible with the Swift > Package manager -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library
Github user apocolipse commented on the issue: https://github.com/apache/thrift/pull/1084 @jeking3 Squashed ---
[jira] [Commented] (THRIFT-4460) php library use PSR-2
[ https://issues.apache.org/jira/browse/THRIFT-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327314#comment-16327314 ] ASF GitHub Bot commented on THRIFT-4460: Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1472 rebased and squashed > php library use PSR-2 > - > > Key: THRIFT-4460 > URL: https://issues.apache.org/jira/browse/THRIFT-4460 > Project: Thrift > Issue Type: Improvement > Components: PHP - Library >Affects Versions: 0.11.0 >Reporter: Robert Lu >Assignee: Robert Lu >Priority: Minor > > PHP Library can use [PSR-2|http://www.php-fig.org/psr/psr-2/] as code standard -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] thrift issue #1472: THRIFT-4460: PHP Library use PSR-2
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1472 rebased and squashed ---
[jira] [Commented] (THRIFT-4438) require php ^5.6 || ^7.0
[
https://issues.apache.org/jira/browse/THRIFT-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327189#comment-16327189
]
ASF GitHub Bot commented on THRIFT-4438:
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1451#discussion_r161777313
--- Diff: composer.json ---
@@ -16,12 +16,12 @@
"issues": "https://issues.apache.org/jira/browse/THRIFT";
},
"require": {
-"php": ">=5.3.0"
+"php": "^5.6 || ^7.0"
--- End diff --
Just looking at the changes here for dropping php 5.3 through 5.5, what's
the benefit? No php code actually changed to take advantage of this, so I'm
not sure I see a reason to do it?
> require php ^5.6 || ^7.0
>
>
> Key: THRIFT-4438
> URL: https://issues.apache.org/jira/browse/THRIFT-4438
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
>Affects Versions: 0.11.0
>Reporter: RobberPhex
>Priority: Major
>
> We can remove php5.3~php5.5 support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4438) require php ^5.6 || ^7.0
[ https://issues.apache.org/jira/browse/THRIFT-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327186#comment-16327186 ] ASF GitHub Bot commented on THRIFT-4438: Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1451#discussion_r161777001 --- Diff: build/docker/ubuntu-trusty/Dockerfile --- @@ -1,223 +0,0 @@ -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -# -# Apache Thrift Docker build environment for Ubuntu Trusty -# Using all stock Ubuntu Trusty packaging except for: -# - d: does not come with Ubuntu so we're installing 2.070.0 -# - dart: does not come with Ubuntu so we're installing 1.20.1 -# - dotnetcore, disabled because netcore is for 1.0.0-preview and 2.0.0 is out -# - haxe, disabled because the distro comes with 3.0.0 and it cores while installing -# - node.js, disabled because it is at 0.10.0 in the distro which is too old (need 4+) -# - ocaml, disabled because it fails to install properly -# --- End diff -- Recommend adding that php is disabled because we require 5.6 and Trusty comes with 5.5.9, and comment out the PHP lines, but not delete the whole thing. > require php ^5.6 || ^7.0 > > > Key: THRIFT-4438 > URL: https://issues.apache.org/jira/browse/THRIFT-4438 > Project: Thrift > Issue Type: Improvement > Components: PHP - Library >Affects Versions: 0.11.0 >Reporter: RobberPhex >Priority: Major > > We can remove php5.3~php5.5 support. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] thrift pull request #1451: THRIFT-4438: delete trusty and requrie php56
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1451#discussion_r161777313
--- Diff: composer.json ---
@@ -16,12 +16,12 @@
"issues": "https://issues.apache.org/jira/browse/THRIFT";
},
"require": {
-"php": ">=5.3.0"
+"php": "^5.6 || ^7.0"
--- End diff --
Just looking at the changes here for dropping php 5.3 through 5.5, what's
the benefit? No php code actually changed to take advantage of this, so I'm
not sure I see a reason to do it?
---
[GitHub] thrift pull request #1451: THRIFT-4438: delete trusty and requrie php56
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1451#discussion_r161777001 --- Diff: build/docker/ubuntu-trusty/Dockerfile --- @@ -1,223 +0,0 @@ -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -# -# Apache Thrift Docker build environment for Ubuntu Trusty -# Using all stock Ubuntu Trusty packaging except for: -# - d: does not come with Ubuntu so we're installing 2.070.0 -# - dart: does not come with Ubuntu so we're installing 1.20.1 -# - dotnetcore, disabled because netcore is for 1.0.0-preview and 2.0.0 is out -# - haxe, disabled because the distro comes with 3.0.0 and it cores while installing -# - node.js, disabled because it is at 0.10.0 in the distro which is too old (need 4+) -# - ocaml, disabled because it fails to install properly -# --- End diff -- Recommend adding that php is disabled because we require 5.6 and Trusty comes with 5.5.9, and comment out the PHP lines, but not delete the whole thing. ---
[jira] [Commented] (THRIFT-4460) php library use PSR-2
[ https://issues.apache.org/jira/browse/THRIFT-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327159#comment-16327159 ] ASF GitHub Bot commented on THRIFT-4460: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1472 Rebase on master as I merged THRIFT-4459. > php library use PSR-2 > - > > Key: THRIFT-4460 > URL: https://issues.apache.org/jira/browse/THRIFT-4460 > Project: Thrift > Issue Type: Improvement > Components: PHP - Library >Affects Versions: 0.11.0 >Reporter: Robert Lu >Assignee: Robert Lu >Priority: Minor > > PHP Library can use [PSR-2|http://www.php-fig.org/psr/psr-2/] as code standard -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] thrift issue #1472: THRIFT-4460: PHP Library use PSR-2
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1472 Rebase on master as I merged THRIFT-4459. ---
[jira] [Resolved] (THRIFT-4459) reduce php library directory depth
[ https://issues.apache.org/jira/browse/THRIFT-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4459. Resolution: Fixed Fix Version/s: 0.12.0 Committed - thanks! > reduce php library directory depth > -- > > Key: THRIFT-4459 > URL: https://issues.apache.org/jira/browse/THRIFT-4459 > Project: Thrift > Issue Type: Improvement >Reporter: Robert Lu >Assignee: Robert Lu >Priority: Minor > Fix For: 0.12.0 > > > The `lib/php` directory is too deep to navigate. > Before, `TBufferedTransport.php` is located at > `lib/php/lib/Thrift/Transport`, which is five level. and `lib/php/lib` has > only `Thrift` folder. So, I think it's unnecessary. > After, `lib/php/lib/Transport` is four level. > And ClassLoader works. > BTW, if the deep directory is necessary, I can add it back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4459) reduce php library directory depth
[ https://issues.apache.org/jira/browse/THRIFT-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327158#comment-16327158 ] ASF GitHub Bot commented on THRIFT-4459: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1471 > reduce php library directory depth > -- > > Key: THRIFT-4459 > URL: https://issues.apache.org/jira/browse/THRIFT-4459 > Project: Thrift > Issue Type: Improvement >Reporter: Robert Lu >Assignee: Robert Lu >Priority: Minor > Fix For: 0.12.0 > > > The `lib/php` directory is too deep to navigate. > Before, `TBufferedTransport.php` is located at > `lib/php/lib/Thrift/Transport`, which is five level. and `lib/php/lib` has > only `Thrift` folder. So, I think it's unnecessary. > After, `lib/php/lib/Transport` is four level. > And ClassLoader works. > BTW, if the deep directory is necessary, I can add it back. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] thrift pull request #1471: THRIFT-4459: reduce php library directory depth
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1471 ---
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326970#comment-16326970 ] ASF GitHub Bot commented on THRIFT-82: -- Github user uint commented on the issue: https://github.com/apache/thrift/pull/1412 @dkochmanski I confirmed I get the issue locally on SBCL 1.3.1, but 1.3.14 works fine. @jeking3 I don't think we can fix the issue with SBCL 1.3.1 (easily), as it seems like either Quicklisp or one of the library it pulls causes that, not the code we maintain. Would it be fine to just use Artful? Or do you need it to build on Xenial specifically for Travis integration? > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III >Priority: Major > Fix For: 0.12.0 > > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] thrift issue #1412: [THRIFT-82] Add Common Lisp support
Github user uint commented on the issue: https://github.com/apache/thrift/pull/1412 @dkochmanski I confirmed I get the issue locally on SBCL 1.3.1, but 1.3.14 works fine. @jeking3 I don't think we can fix the issue with SBCL 1.3.1 (easily), as it seems like either Quicklisp or one of the library it pulls causes that, not the code we maintain. Would it be fine to just use Artful? Or do you need it to build on Xenial specifically for Travis integration? ---
