[GitHub] thrift issue #1412: [THRIFT-82] Add Common Lisp support
Github user dkochmanski commented on the issue: https://github.com/apache/thrift/pull/1412 Basically SBCL 1.3.14 (artful) works fine locally on Docker (and 1.3.1 had a bug with base strings according to SBCL devs - xenial). So the problem is probably something on environment hosting docker. I've noticed that some languages doesn't have docker tests enabled at all, if this problem persists is it acceptable to skip it for CL too? @jeking3 can you try running tests on Docker on your host locally to confirm that? What steps do you suggest in order to move forward? ---
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343185#comment-16343185 ] ASF GitHub Bot commented on THRIFT-82: -- Github user dkochmanski commented on the issue: https://github.com/apache/thrift/pull/1412 Basically SBCL 1.3.14 (artful) works fine locally on Docker (and 1.3.1 had a bug with base strings according to SBCL devs - xenial). So the problem is probably something on environment hosting docker. I've noticed that some languages doesn't have docker tests enabled at all, if this problem persists is it acceptable to skip it for CL too? @jeking3 can you try running tests on Docker on your host locally to confirm that? What steps do you suggest in order to move forward? > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III >Priority: Major > Fix For: 0.12.0 > > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] thrift issue #1412: [THRIFT-82] Add Common Lisp support
Github user uint commented on the issue: https://github.com/apache/thrift/pull/1412 Rebased. ---
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343221#comment-16343221 ] ASF GitHub Bot commented on THRIFT-82: -- Github user uint commented on the issue: https://github.com/apache/thrift/pull/1412 Rebased. > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III >Priority: Major > Fix For: 0.12.0 > > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4426) repository should not include symbolic links
[ https://issues.apache.org/jira/browse/THRIFT-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343263#comment-16343263 ] Xiaoshuang LU commented on THRIFT-4426: --- Hi [~roger.meier], Would you please reviewing this patch? :) > repository should not include symbolic links > > > Key: THRIFT-4426 > URL: https://issues.apache.org/jira/browse/THRIFT-4426 > Project: Thrift > Issue Type: Bug > Components: Tutorial >Affects Versions: 0.11.0 >Reporter: Xiaoshuang LU >Priority: Major > Fix For: 0.12.0 > > Attachments: THRIFT-4426.patch > > > We probably need to let tutorial/erl/client.sh be a regular file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] thrift issue #1412: [THRIFT-82] Add Common Lisp support
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1412 Sorry I have been working on some other things - I will try to get back around to this as soon as I can. It's important to the project to have as many languages supported as possible. ---
[jira] [Commented] (THRIFT-82) Common Lisp support
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343539#comment-16343539 ] ASF GitHub Bot commented on THRIFT-82: -- Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1412 Sorry I have been working on some other things - I will try to get back around to this as soon as I can. It's important to the project to have as many languages supported as possible. > Common Lisp support > --- > > Key: THRIFT-82 > URL: https://issues.apache.org/jira/browse/THRIFT-82 > Project: Thrift > Issue Type: New Feature >Reporter: Patrick Collison >Assignee: James E. King, III >Priority: Major > Fix For: 0.12.0 > > Attachments: thrift-cl.patch > > > Common Lisp support is attached -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4308) D language docker images need demios for libevent and openssl fixed to re-enable make cross on dlang
[
https://issues.apache.org/jira/browse/THRIFT-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343899#comment-16343899
]
James E. King, III commented on THRIFT-4308:
Okay, so it turns out other people have reported issues with DMD's inability to
move link flags to the end of the command line.
I found that using the gold linker for D builds allowed me to re-enable the
openssl and libevent deimos extensions, so that's what the fix will be.
> D language docker images need demios for libevent and openssl fixed to
> re-enable make cross on dlang
>
>
> Key: THRIFT-4308
> URL: https://issues.apache.org/jira/browse/THRIFT-4308
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process, D - Library
>Affects Versions: 0.11.0
> Environment: docker:ubuntu-xenial
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Major
>
> I had to disable the deimos hooks for libevent and openssl because they were
> causing build failures in 0.11.0. A result of this change is that dlang is
> NOT tested in "make cross" at all, because the test executables are only
> generated if openssl support exists, and it does not.
> It turns out this is some sort of link ordering issue. On further diagnosis,
> the dmd command outputs this build line when you add -v:
> {noformat}
> root@f82a62661052:/thrift/src/lib/d/test# cc client_pool_test.o -o
> client_pool_test -m64 -levent -lssl -lcrypto -L/usr/lib/x86_64-linux-gnu
> -Xlinker --export-dynamic ../../../lib/d/libthriftd.a ../libthriftd-event.a
> ../libthriftd-ssl.a -Xlinker -Bstatic -lphobos2 -Xlinker -Bdynamic -lpthread
> -lm -lrt -ldl
> ../libthriftd-event.a(libevent_1_846.o): In function
> `_D6thrift5async8libevent21TLibeventAsyncManager6__ctorMFZC6thrift5async8libevent21TLibeventAsyncManager':
> src/thrift/async/libevent.d:(.text._D6thrift5async8libevent21TLibeventAsyncManager6__ctorMFZC6thrift5async8libevent21TLibeventAsyncManager+0x11):
> undefined reference to `event_base_new'
> src/thrift/async/libevent.d:(.text._D6thrift5async8libevent21TLibeventAsyncManager6__ctorMFZC6thrift5async8libevent21TLibeventAsyncManager+0xa3):
> undefined reference to `event_new'
> src/thrift/async/libevent.d:(.text._D6thrift5async8libevent21TLibeventAsyncManager6__ctorMFZC6thrift5async8libevent21TLibeventAsyncManager+0xb1):
> undefined reference to `event_add'
> {noformat}
> If you add -Wl,--start-group before the event library, OR move event, ssl,
> and crypto to the end of the library list, the link completes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] thrift pull request #1483: THRIFT-4308: re-enable dlang deimos build support...
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1483 THRIFT-4308: re-enable dlang deimos build support for libevent and openssl ... working around a dmd link order issue. https://issues.apache.org/jira/browse/THRIFT-4308 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift THRIFT-4308 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1483.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1483 commit 9357558278fb831a84cef42ded71887296b7e453 Author: James E. King III Date: 2018-01-29T19:51:24Z THRIFT-4308: re-enable dlang deimos build support for libevent and openssl, working around a dmd link order issue ---
[jira] [Commented] (THRIFT-4308) D language docker images need demios for libevent and openssl fixed to re-enable make cross on dlang
[
https://issues.apache.org/jira/browse/THRIFT-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343912#comment-16343912
]
ASF GitHub Bot commented on THRIFT-4308:
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1483
THRIFT-4308: re-enable dlang deimos build support for libevent and openssl
... working around a dmd link order issue.
https://issues.apache.org/jira/browse/THRIFT-4308
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4308
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1483.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1483
commit 9357558278fb831a84cef42ded71887296b7e453
Author: James E. King III
Date: 2018-01-29T19:51:24Z
THRIFT-4308: re-enable dlang deimos build support for libevent and openssl,
working around a dmd link order issue
> D language docker images need demios for libevent and openssl fixed to
> re-enable make cross on dlang
>
>
> Key: THRIFT-4308
> URL: https://issues.apache.org/jira/browse/THRIFT-4308
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process, D - Library
>Affects Versions: 0.11.0
> Environment: docker:ubuntu-xenial
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Major
>
> I had to disable the deimos hooks for libevent and openssl because they were
> causing build failures in 0.11.0. A result of this change is that dlang is
> NOT tested in "make cross" at all, because the test executables are only
> generated if openssl support exists, and it does not.
> It turns out this is some sort of link ordering issue. On further diagnosis,
> the dmd command outputs this build line when you add -v:
> {noformat}
> root@f82a62661052:/thrift/src/lib/d/test# cc client_pool_test.o -o
> client_pool_test -m64 -levent -lssl -lcrypto -L/usr/lib/x86_64-linux-gnu
> -Xlinker --export-dynamic ../../../lib/d/libthriftd.a ../libthriftd-event.a
> ../libthriftd-ssl.a -Xlinker -Bstatic -lphobos2 -Xlinker -Bdynamic -lpthread
> -lm -lrt -ldl
> ../libthriftd-event.a(libevent_1_846.o): In function
> `_D6thrift5async8libevent21TLibeventAsyncManager6__ctorMFZC6thrift5async8libevent21TLibeventAsyncManager':
> src/thrift/async/libevent.d:(.text._D6thrift5async8libevent21TLibeventAsyncManager6__ctorMFZC6thrift5async8libevent21TLibeventAsyncManager+0x11):
> undefined reference to `event_base_new'
> src/thrift/async/libevent.d:(.text._D6thrift5async8libevent21TLibeventAsyncManager6__ctorMFZC6thrift5async8libevent21TLibeventAsyncManager+0xa3):
> undefined reference to `event_new'
> src/thrift/async/libevent.d:(.text._D6thrift5async8libevent21TLibeventAsyncManager6__ctorMFZC6thrift5async8libevent21TLibeventAsyncManager+0xb1):
> undefined reference to `event_add'
> {noformat}
> If you add -Wl,--start-group before the event library, OR move event, ssl,
> and crypto to the end of the library list, the link completes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] thrift issue #1479: THRIFT-4474: generate PHP code use PSR-4 style default
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1479 Are these changes all backwards compatible? ---
[jira] [Commented] (THRIFT-4474) PHP generator use PSR-4 default
[
https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343915#comment-16343915
]
ASF GitHub Bot commented on THRIFT-4474:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1479
Are these changes all backwards compatible?
> PHP generator use PSR-4 default
> ---
>
> Key: THRIFT-4474
> URL: https://issues.apache.org/jira/browse/THRIFT-4474
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Compiler
>Reporter: Robert Lu
>Assignee: Robert Lu
>Priority: Major
>
> Before, PHP generator generate php files like {{Types.php}}, {{Service.php}}.
> Those can only be load via
> [{{classmap}}|https://getcomposer.org/doc/04-schema.md#classmap] method. The
> latest PSR about autoload is [PSR-4|http://www.php-fig.org/psr/psr-4/].
> thrift compiler can generate PSR-4 code default, if want old-style code(which
> can only load via classmap), add {{classmap}} option.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] thrift issue #1474: Recognize fbthrift TApplicationException codes
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1474 @jeking3 `Do we really need to ask for permission to add three additional error codes from fbthrift?` - yes, if there is something in Facebook fbthrift that someone wants to add to Apache Thrift it has to come as a contribution from Facebook. @Jens-G I cant recall a ticket for it either, but agree with having the common portion built into the generator to reduce updating many touch points in the code ---
[GitHub] thrift pull request #1482: THRIFT-4475: check lib/php/test for PSR-2
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1482 ---
[jira] [Resolved] (THRIFT-4475) lib/php/test should be checked for PSR-2
[
https://issues.apache.org/jira/browse/THRIFT-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4475.
Resolution: Fixed
Fix Version/s: 0.12.0
Committed - thanks.
> lib/php/test should be checked for PSR-2
>
>
> Key: THRIFT-4475
> URL: https://issues.apache.org/jira/browse/THRIFT-4475
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
>Affects Versions: 0.11.0
>Reporter: Robert Lu
>Assignee: Robert Lu
>Priority: Minor
> Fix For: 0.12.0
>
>
> The test code at {{lib/php/test}} should also be checked by phpcs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-4475) lib/php/test should be checked for PSR-2
[
https://issues.apache.org/jira/browse/THRIFT-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343993#comment-16343993
]
ASF GitHub Bot commented on THRIFT-4475:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1482
> lib/php/test should be checked for PSR-2
>
>
> Key: THRIFT-4475
> URL: https://issues.apache.org/jira/browse/THRIFT-4475
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
>Affects Versions: 0.11.0
>Reporter: Robert Lu
>Assignee: Robert Lu
>Priority: Minor
> Fix For: 0.12.0
>
>
> The test code at {{lib/php/test}} should also be checked by phpcs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] thrift issue #1474: Recognize fbthrift TApplicationException codes
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1474 @jfarrell from what I can see these error codes are inside contributed code in the fbthrift project, at least from the C++ side, in a file that contains the Apache license: https://github.com/facebook/fbthrift/blob/master/thrift/lib/cpp/transport/TTransportException.h Making error codes generated as part of the build process would actually be pretty cool; there would be some sort of top level directory to store common thrift (perhaps lib/common/) and inside a Transport.thrift file (or something like that) with an enumeration and a LOT of namespace directives... and the build would generate the language-specific output it needs to build the library. Sounds pretty cool. ---
[jira] [Created] (THRIFT-4477) TBufferedTransport must have underlying transport
Robert Lu created THRIFT-4477: - Summary: TBufferedTransport must have underlying transport Key: THRIFT-4477 URL: https://issues.apache.org/jira/browse/THRIFT-4477 Project: Thrift Issue Type: Bug Components: PHP - Library Affects Versions: 0.11.0 Reporter: Robert Lu Assignee: Robert Lu for TBufferedTransport, the underlying transport cannot be null. many methods used underlying transport directly, if it's null, will cause error. And a null as underlying transport for TBufferedTransport makes no sense. So, TBufferedTransport must have underlying transport -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1484 TBufferedTransport must have underlying transport ref: https://issues.apache.org/jira/browse/THRIFT-4477 You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift fix-TBufferedTransport Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1484.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1484 commit 3c72a16259b64c2fd38f160b67575b3b932c5e62 Author: Robert Lu Date: 2018-01-29T14:49:12Z TBufferedTransport must have underlying transport * add some type hinting ---
[jira] [Commented] (THRIFT-4477) TBufferedTransport must have underlying transport
[ https://issues.apache.org/jira/browse/THRIFT-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344421#comment-16344421 ] ASF GitHub Bot commented on THRIFT-4477: GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1484 TBufferedTransport must have underlying transport ref: https://issues.apache.org/jira/browse/THRIFT-4477 You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift fix-TBufferedTransport Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1484.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1484 commit 3c72a16259b64c2fd38f160b67575b3b932c5e62 Author: Robert Lu Date: 2018-01-29T14:49:12Z TBufferedTransport must have underlying transport * add some type hinting > TBufferedTransport must have underlying transport > - > > Key: THRIFT-4477 > URL: https://issues.apache.org/jira/browse/THRIFT-4477 > Project: Thrift > Issue Type: Bug > Components: PHP - Library >Affects Versions: 0.11.0 >Reporter: Robert Lu >Assignee: Robert Lu >Priority: Major > > for TBufferedTransport, > the underlying transport cannot be null. many methods used underlying > transport directly, if it's null, will cause error. And a null as underlying > transport for TBufferedTransport makes no sense. > So, TBufferedTransport must have underlying transport -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (THRIFT-4478) Thrift is not compatible with dlang 2.078 and later
James E. King, III created THRIFT-4478:
--
Summary: Thrift is not compatible with dlang 2.078 and later
Key: THRIFT-4478
URL: https://issues.apache.org/jira/browse/THRIFT-4478
Project: Thrift
Issue Type: Bug
Components: D - Compiler
Affects Versions: 0.11.0
Reporter: James E. King, III
I tried to move the ubuntu-artful dlang version up from 2.076.0 to 2.078.1 and
the build failed here:
{noformat}
dmd -L-fuse-ld=gold -L-levent ../libthriftd-event.a -L-fuse-ld=gold -L-lssl
-L-lcrypto ../libthriftd-ssl.a -w -wi -O -release -inline -I../../../lib/d/src
-Igen-d ../../../lib/d/libthriftd.a -ofserialization_benchmark
serialization_benchmark.d gen-d/DebugProtoTest_types.d
[1mthrift_test_client.d(128): [1;36mDeprecation: [mstruct
std.datetime.StopWatch is deprecated - Use std.datetime.stopwatch.StopWatch.
[1mthrift_test_client.d(128): [1;36mDeprecation: [mstruct
std.datetime.StopWatch is deprecated - Use std.datetime.stopwatch.StopWatch.
[1mserialization_benchmark.d(16): [1;36mDeprecation: [malias
std.datetime.AutoStart is deprecated - Use std.datetime.stopwatch.AutoStart.
[1mserialization_benchmark.d(16): [1;36mDeprecation: [malias
std.datetime.AutoStart is deprecated - Use std.datetime.stopwatch.AutoStart.
[1mserialization_benchmark.d(16): [1;36mDeprecation: [mstruct
std.datetime.StopWatch is deprecated - Use std.datetime.stopwatch.StopWatch.
[1mserialization_benchmark.d(16): [1;36mDeprecation: [mstruct
std.datetime.StopWatch is deprecated - Use std.datetime.stopwatch.StopWatch.
[1mthrift_test_client.d(338): [1;36mDeprecation: [mstruct
std.datetime.StopWatch is deprecated - Use std.datetime.stopwatch.StopWatch.
[1mthrift_test_client.d(338): [1;36mDeprecation: [malias
std.datetime.AutoStart is deprecated - Use std.datetime.stopwatch.AutoStart.
[1mthrift_test_client.d(338): [1;36mDeprecation: [mstruct
std.datetime.StopWatch is deprecated - Use std.datetime.stopwatch.StopWatch.
[1mserialization_benchmark.d(42): [1;36mDeprecation: [mstruct
std.datetime.StopWatch is deprecated - Use std.datetime.stopwatch.StopWatch.
[1mserialization_benchmark.d(60): [1;36mDeprecation: [mstruct
std.datetime.StopWatch is deprecated - Use std.datetime.stopwatch.StopWatch.
[1m/usr/include/dmd/druntime/import/object.d(3461): [1;31mError: [mno
property 'tupleof' for type
'const(HashSet!(string[immutable(Insanity)][])[int][immutable(HashSet!int)])'
[1m/usr/include/dmd/druntime/import/object.d(3461): [1;31mError: [mno
property 'tupleof' for type
'const(HashSet!(string[immutable(Insanity)][])[int][immutable(HashSet!int)])'
[1m../../../lib/d/src/thrift/codegen/base.d(466): [1;31mError: [mtemplate
instance
object.__equals!(const(HashSet!(string[immutable(Insanity)][])[int][immutable(HashSet!int)]),
const(HashSet!(string[immutable(Insanity)][])[int][immutable(HashSet!int)]))
error instantiating
[1m/usr/include/dmd/druntime/import/object.d(3461): [1;31mError: [mno
property 'tupleof' for type 'const(HashSet!string[int])'
[1m/usr/include/dmd/druntime/import/object.d(3461): [1;31mError: [mno
property 'tupleof' for type 'const(HashSet!string[int])'
[1m../../../lib/d/src/thrift/codegen/base.d(466): [1;31mError: [mtemplate
instance object.__equals!(const(HashSet!string[int]),
const(HashSet!string[int])) error instantiating
Makefile:803: recipe for target 'thrift_test_client' failed
make[5]: *** [thrift_test_client] Error 1
make[5]: *** Waiting for unfinished jobs
[1m/usr/include/dmd/druntime/import/object.d(3461): [1;31mError: [mno
property 'tupleof' for type
'const(HashSet!(string[immutable(Insanity)][])[int][immutable(HashSet!int)])'
[1m/usr/include/dmd/druntime/import/object.d(3461): [1;31mError: [mno
property 'tupleof' for type
'const(HashSet!(string[immutable(Insanity)][])[int][immutable(HashSet!int)])'
[1m../../../lib/d/src/thrift/codegen/base.d(466): [1;31mError: [mtemplate
instance
object.__equals!(const(HashSet!(string[immutable(Insanity)][])[int][immutable(HashSet!int)]),
const(HashSet!(string[immutable(Insanity)][])[int][immutable(HashSet!int)]))
error instantiating
[1m/usr/include/dmd/druntime/import/object.d(3461): [1;31mError: [mno
property 'tupleof' for type 'const(HashSet!string[int])'
[1m/usr/include/dmd/druntime/import/object.d(3461): [1;31mError: [mno
property 'tupleof' for type 'const(HashSet!string[int])'
[1m../../../lib/d/src/thrift/codegen/base.d(466): [1;31mError: [mtemplate
instance object.__equals!(const(HashSet!string[int]),
const(HashSet!string[int])) error instantiating
Makefile:806: recipe for target 'thrift_test_server' failed
make[5]: *** [thrift_test_server] Error 1
make[5]: Leaving directory '/thrift/src/lib/d/test'
{noformat}
When I backed it down to 2.077.1, things worked again.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] thrift issue #1483: THRIFT-4308: re-enable dlang deimos build support for li...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1483 Of course the lib/d certificates had to expire on January 29 too... ---
[jira] [Commented] (THRIFT-4308) D language docker images need demios for libevent and openssl fixed to re-enable make cross on dlang
[
https://issues.apache.org/jira/browse/THRIFT-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344438#comment-16344438
]
ASF GitHub Bot commented on THRIFT-4308:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1483
Of course the lib/d certificates had to expire on January 29 too...
> D language docker images need demios for libevent and openssl fixed to
> re-enable make cross on dlang
>
>
> Key: THRIFT-4308
> URL: https://issues.apache.org/jira/browse/THRIFT-4308
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process, D - Library
>Affects Versions: 0.11.0
> Environment: docker:ubuntu-xenial
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Major
>
> I had to disable the deimos hooks for libevent and openssl because they were
> causing build failures in 0.11.0. A result of this change is that dlang is
> NOT tested in "make cross" at all, because the test executables are only
> generated if openssl support exists, and it does not.
> It turns out this is some sort of link ordering issue. On further diagnosis,
> the dmd command outputs this build line when you add -v:
> {noformat}
> root@f82a62661052:/thrift/src/lib/d/test# cc client_pool_test.o -o
> client_pool_test -m64 -levent -lssl -lcrypto -L/usr/lib/x86_64-linux-gnu
> -Xlinker --export-dynamic ../../../lib/d/libthriftd.a ../libthriftd-event.a
> ../libthriftd-ssl.a -Xlinker -Bstatic -lphobos2 -Xlinker -Bdynamic -lpthread
> -lm -lrt -ldl
> ../libthriftd-event.a(libevent_1_846.o): In function
> `_D6thrift5async8libevent21TLibeventAsyncManager6__ctorMFZC6thrift5async8libevent21TLibeventAsyncManager':
> src/thrift/async/libevent.d:(.text._D6thrift5async8libevent21TLibeventAsyncManager6__ctorMFZC6thrift5async8libevent21TLibeventAsyncManager+0x11):
> undefined reference to `event_base_new'
> src/thrift/async/libevent.d:(.text._D6thrift5async8libevent21TLibeventAsyncManager6__ctorMFZC6thrift5async8libevent21TLibeventAsyncManager+0xa3):
> undefined reference to `event_new'
> src/thrift/async/libevent.d:(.text._D6thrift5async8libevent21TLibeventAsyncManager6__ctorMFZC6thrift5async8libevent21TLibeventAsyncManager+0xb1):
> undefined reference to `event_add'
> {noformat}
> If you add -Wl,--start-group before the event library, OR move event, ssl,
> and crypto to the end of the library list, the link completes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (THRIFT-4479) Enhance Windows CI build with 32/64 cygwin/mingw builds like in Boost.Format
James E. King, III created THRIFT-4479: -- Summary: Enhance Windows CI build with 32/64 cygwin/mingw builds like in Boost.Format Key: THRIFT-4479 URL: https://issues.apache.org/jira/browse/THRIFT-4479 Project: Thrift Issue Type: Improvement Components: Build Process Affects Versions: 0.11.0 Environment: Appveyor CI Reporter: James E. King, III Assignee: James E. King, III Carry the build logic from Boost.Format over so we can build cygwin32, cygwin64, mingw32 and mingw64 flavors of Thrift on Windows. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164632710 --- Diff: lib/php/lib/Transport/TTransport.php --- @@ -22,6 +22,7 @@ namespace Thrift\Transport; +use Thrift\Exception\TTransportException; --- End diff -- Why is this change needed? ---
[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164632409 --- Diff: lib/php/lib/Factory/TStringFuncFactory.php --- @@ -21,8 +21,9 @@ namespace Thrift\Factory; -use Thrift\StringFunc\Mbstring; use Thrift\StringFunc\Core; +use Thrift\StringFunc\Mbstring; --- End diff -- These changes seem unnecessary in order to change the line of documentation on line 53 below. ---
[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164632749 --- Diff: lib/php/lib/Transport/TBufferedTransport.php --- @@ -78,11 +69,26 @@ public function __construct($transport = null, $rBufSize = 512, $wBufSize = 512) */ protected $rBuf_ = ''; +/** + * Constructor. Creates a buffered transport around an underlying transport + */ +public function __construct($transport, $rBufSize = 512, $wBufSize = 512) --- End diff -- It would have been more obvious if the pull request changed only this line, removing the "= null". ---
[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164632507 --- Diff: lib/php/lib/Transport/TBufferedTransport.php --- @@ -22,6 +22,7 @@ namespace Thrift\Transport; +use Thrift\Exception\TTransportException; --- End diff -- I don't see where TTransportException is used in the changes you made. Is a "use" clause needed for the @inheritdoc directive to work? ---
[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport
Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164633402 --- Diff: lib/php/lib/Transport/TBufferedTransport.php --- @@ -78,11 +69,26 @@ public function __construct($transport = null, $rBufSize = 512, $wBufSize = 512) */ protected $rBuf_ = ''; +/** + * Constructor. Creates a buffered transport around an underlying transport + */ +public function __construct($transport, $rBufSize = 512, $wBufSize = 512) --- End diff -- Firstly, remove `=null` at class filed. And, `$transport=null` should also be removed at function `__construct`. Sometimes, called `new TBufferedTransport()` will cause $transport_ is null, which cause other funcion doesn't work(`open`, `read`, etc.) ---
[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport
Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164633628 --- Diff: lib/php/lib/Factory/TStringFuncFactory.php --- @@ -21,8 +21,9 @@ namespace Thrift\Factory; -use Thrift\StringFunc\Mbstring; use Thrift\StringFunc\Core; +use Thrift\StringFunc\Mbstring; --- End diff -- I sorted use alphabetically, is it unnecessary? Am I expected that change it back? ---
[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport
Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164633860 --- Diff: lib/php/lib/Transport/TBufferedTransport.php --- @@ -22,6 +22,7 @@ namespace Thrift\Transport; +use Thrift\Exception\TTransportException; --- End diff -- some function has doc comment `@throws TTransportException`, No one (and IDE) knows which TTransportException, so I think we should add use stmt. Or, We always use full classname at doc comment, is it? ---
[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport
Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164633942 --- Diff: lib/php/lib/Transport/TTransport.php --- @@ -22,6 +22,7 @@ namespace Thrift\Transport; +use Thrift\Exception\TTransportException; --- End diff -- There is doc comment `@throws TTransportException` at Line 45. No one (and IDE) knows which TTransportException. ---
