[jira] [Created] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

[Joshua (JIRA)]

Joshua created THRIFT-4529:
--

 Summary: Rust generation should include #![allow(non_snake_case)] 
or force conform to Rust style guidelines
 Key: THRIFT-4529
 URL: https://issues.apache.org/jira/browse/THRIFT-4529
 Project: Thrift
  Issue Type: Improvement
  Components: Rust - Compiler
Affects Versions: 0.11.0
Reporter: Joshua


Without this, building a project using a thrift file meant for multiple 
languages may end up with many compiler warnings similar to the following:
{code:sh}
warning: variant `EXAMPLE_NAME` should have a camel case name such as 
`ExampleName`
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-4527) Upgrade byteorder version in Rust lib

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408906#comment-16408906
 ] 

ASF GitHub Bot commented on THRIFT-4527:


Github user allengeorge commented on the issue:

https://github.com/apache/thrift/pull/1516
  
LGTM. @QuestofIranon just curious - why bump the version?


> Upgrade byteorder version in Rust lib
> -
>
> Key: THRIFT-4527
> URL: https://issues.apache.org/jira/browse/THRIFT-4527
> Project: Thrift
>  Issue Type: Dependency upgrade
>  Components: Rust - Library
>Affects Versions: 0.11.0
>Reporter: Joshua
>Priority: Major
>
> The Rust library was depending on byteorder v1.1.0, upgraded to v1.2.1 to 
> prevent dependency conflicts in a project I was working on, works fine and 
> would be useful for other users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] thrift issue #1516: THRIFT-4527 Upgrade byteorder in rust

[allengeorge]

Github user allengeorge commented on the issue:

https://github.com/apache/thrift/pull/1516
  
LGTM. @QuestofIranon just curious - why bump the version?


---

[jira] [Resolved] (THRIFT-4495) Erlang records should allow 'undefined' for non-required fields

[James E. King, III (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III resolved THRIFT-4495.

   Resolution: Fixed
Fix Version/s: 0.12.0

> Erlang records should allow 'undefined' for non-required fields
> ---
>
> Key: THRIFT-4495
> URL: https://issues.apache.org/jira/browse/THRIFT-4495
> Project: Thrift
>  Issue Type: Improvement
>  Components: Erlang - Compiler
>Affects Versions: 0.11.0
>Reporter: David Hull
>Assignee: David Hull
>Priority: Major
> Fix For: 0.12.0
>
>
> The Erlang records created by the Erlang code generator allow only the type 
> declared by the Thrift definition file. If a field is not required, however, 
> the Erlang record should also allow the value {{undefined}} (this is similar 
> to a null value in other languages).
> Erlang includes a tool, dialyzer, that does type analysis of Erlang code. 
> Until Erlang 19, dialyzer implicitly added `undefined` as an allowed type for 
> all record fields, but as of Erlang 19 it no longer does. This means that 
> dialyzer now emits error messages whenever a record is constructed and 
> initial values are not specified for all of its fields.
> So, for example, the following thrift definition
> {noformat}
> struct Test {
>   1: required i32 a
>   2: i32 b
>   3: optional i32 c
> }{noformat}
> currently produced the following Erlang record:
> {noformat}
> -record('Test', {'a' :: integer(),
>  'b' :: integer(),
>  'c' :: integer()}).{noformat}
>  However it should produce the following:
> {noformat}
> -record('Test', {'a' :: integer(),
>  'b' :: integer() | undefined,
>  'c' :: integer() | undefined}).{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (THRIFT-4497) Erlang records should use map() for map type

[James E. King, III (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III resolved THRIFT-4497.

   Resolution: Fixed
Fix Version/s: 0.12.0

> Erlang records should use map() for map type
> 
>
> Key: THRIFT-4497
> URL: https://issues.apache.org/jira/browse/THRIFT-4497
> Project: Thrift
>  Issue Type: Bug
>  Components: Erlang - Compiler
>Affects Versions: 0.11.0
>Reporter: David Hull
>Assignee: David Hull
>Priority: Major
> Fix For: 0.12.0
>
>
> When the Thrift Erlang code generator is given the "maps" option, it 
> generates records with #{} as the field type. However #{} is the type for an 
> empty map. The Erlang [Types and Function 
> Specifications|http://erlang.org/doc/reference_manual/typespec.html#id79546] 
> says:
> {quote}
> Notice that the syntactic representation of {{map()}} is {{#\{any() => 
> any()\}}} (or {{#\{_ => _\}}}), not #\{ \}. The notation #\{ \} specifies the 
> singleton type for the empty map.
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (THRIFT-4342) Support ruby rspec 3

[James E. King, III (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III reassigned THRIFT-4342:
--

Assignee: James E. King, III

> Support ruby rspec 3
> 
>
> Key: THRIFT-4342
> URL: https://issues.apache.org/jira/browse/THRIFT-4342
> Project: Thrift
>  Issue Type: Improvement
>  Components: Ruby - Library
>Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial (ruby 2.3.1)
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Major
>
> I don't know much about ruby.  Anybody who can assist is welcome to do so!  I 
> tried to update us to rspec 2.99.x to prepare for rspec 3 and got a lot of 
> errors.  We should be running the latest versions of test tools in 
> thrift.gemspec.  Also note the apache license in the gemspec is not quite 
> right...
> {noformat}
> Pending:
>   Client Thrift::Client should increment the sequence id when sending messages
> # it seems sequence ids are completely ignored right now
> # ./spec/client_spec.rb:55
> Failures:
>   1) BinaryProtocolAccelerated it should behave like a binary protocol should 
> write a byte
>  Failure/Error: @trans.rspec_verify
>  NoMethodError:
>undefined method `rspec_verify' for 
> #
>  Shared Example Group: "a binary protocol" called from 
> ./spec/binary_protocol_accelerated_spec.rb:28
>  # ./spec/binary_protocol_spec_shared.rb:112:in `block (2 levels) in  (required)>'
>   2) BinaryProtocol it should behave like a binary protocol should write a 
> byte
>  Failure/Error: @trans.rspec_verify
>  NoMethodError:
>undefined method `rspec_verify' for 
> #
>  Shared Example Group: "a binary protocol" called from 
> ./spec/binary_protocol_spec.rb:25
>  # ./spec/binary_protocol_spec_shared.rb:112:in `block (2 levels) in  (required)>'
> Deprecation Warnings:
> 
> The semantics of `RSpec::Core::Pending#pending` are changing in
> RSpec 3.  In RSpec 2.x, it caused the example to be skipped. In
> RSpec 3, the rest of the example will still be run but is expected
> to fail, and will be marked as a failure (rather than as pending)
> if the example passes.
> Any passed block will no longer be executed. This feature is being
> removed since it was semantically inconsistent, and the behaviour it
> offered is being made available with the other ways of marking an
> example pending.
> To keep the same skip semantics, change `pending` to `skip`.
> Otherwise, if you want the new RSpec 3 behavior, you can safely
> ignore this warning and continue to upgrade to RSpec 3 without
> addressing it.
> Called from /thrift/src/lib/rb/spec/client_spec.rb:56:in `block (3 levels) in 
> '.
> 
> `and_return { value }` is deprecated. Use `and_return(value)` or an 
> implementation block without `and_return` instead. Called from 
> /thrift/src/lib/rb/spec/client_spec.rb:79:in `block (3 levels) in  (required)>'.
> `and_return { value }` is deprecated. Use `and_return(value)` or an 
> implementation block without `and_return` instead. Called from 
> /thrift/src/lib/rb/spec/http_client_spec.rb:38:in `block (3 levels) in  (required)>'.
> `and_return { value }` is deprecated. Use `and_return(value)` or an 
> implementation block without `and_return` instead. Called from 
> /thrift/src/lib/rb/spec/http_client_spec.rb:41:in `block (5 levels) in  (required)>'.
> Too many uses of deprecated '`and_return { value }`'. Pass 
> `--deprecation-out` or set `config.deprecation_stream` to a file for full 
> output.
> `be_false` is deprecated. Use `be_falsey` (for Ruby's conditional semantics) 
> or `be false` (for exact `== false` equality) instead. Called from 
> /thrift/src/lib/rb/spec/base_transport_spec.rb:279:in `block (3 levels) in 
> '.
> `be_false` is deprecated. Use `be_falsey` (for Ruby's conditional semantics) 
> or `be false` (for exact `== false` equality) instead. Called from 
> /thrift/src/lib/rb/spec/struct_spec.rb:63:in `block (3 levels) in  (required)>'.
> `be_false` is deprecated. Use `be_falsey` (for Ruby's conditional semantics) 
> or `be false` (for exact `== false` equality) instead. Called from 
> /thrift/src/lib/rb/spec/struct_spec.rb:83:in `block (3 levels) in  (required)>'.
> Too many uses of deprecated '`be_false`'. Pass `--deprecation-out` or set 
> `config.deprecation_stream` to a file for full output.
> `be_true` is deprecated. Use `be_truthy` (for Ruby's conditional semantics) 
> or `be true` (for exact `== true` equality) instead. Called from 
> /thrift/src/lib/rb/spec/base_transport_spec.rb:44:in `block (4 levels) in 
> '.
> `be_true` is deprecated. Use `be_truthy` (for Ruby's conditional 

[GitHub] thrift issue #1515: add connect timeout, support accurate send timeout

[jeking3]

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1515
  
Fortunately these changes are confined to one file so reviewing it isn't 
too bad - hopefully they pass the new php formatting tests in the sca build.


---

[jira] [Updated] (THRIFT-4502) Cleanup "Known Test Failures" in order to improve quality

[James E. King, III (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III updated THRIFT-4502:
---
Issue Type: Epic  (was: Story)

> Cleanup "Known Test Failures" in order to improve quality
> -
>
> Key: THRIFT-4502
> URL: https://issues.apache.org/jira/browse/THRIFT-4502
> Project: Thrift
>  Issue Type: Epic
>  Components: Test Suite
>Affects Versions: 0.11.0
> Environment: ubuntu-artful
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Major
>
> There are a lot of combinations of server language + client language + 
> transport + protocol that fail the "cross test" suite.  These are exempted 
> from running or being counted as a build failure through the 
> `test/known_failures_Linux.json` file.  Currently there are 340 combinations 
> that fail to interop.  Given thrift's main purpose is to allow for 
> cross-language remote-procedure calls, cleaning up the errors in this list 
> should be considered a high priority.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] thrift pull request #1514: THRIFT-4525: add ruby cross test ssl support

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1514


---

[jira] [Commented] (THRIFT-4525) Add ssl socket option to ruby cross tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408852#comment-16408852
 ] 

ASF GitHub Bot commented on THRIFT-4525:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1514


> Add ssl socket option to ruby cross tests
> -
>
> Key: THRIFT-4525
> URL: https://issues.apache.org/jira/browse/THRIFT-4525
> Project: Thrift
>  Issue Type: Improvement
>  Components: Ruby - Library
>Affects Versions: 0.11.0
> Environment: ubuntu-artful
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Minor
> Fix For: 0.12.0
>
>
> There are no ssl based ruby cross tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (THRIFT-4525) Add ssl socket option to ruby cross tests

[James E. King, III (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III resolved THRIFT-4525.

   Resolution: Fixed
Fix Version/s: 0.12.0

> Add ssl socket option to ruby cross tests
> -
>
> Key: THRIFT-4525
> URL: https://issues.apache.org/jira/browse/THRIFT-4525
> Project: Thrift
>  Issue Type: Improvement
>  Components: Ruby - Library
>Affects Versions: 0.11.0
> Environment: ubuntu-artful
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Minor
> Fix For: 0.12.0
>
>
> There are no ssl based ruby cross tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (THRIFT-4358) Add unix domain sockets in ruby to cross test - code exists

[James E. King, III (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III resolved THRIFT-4358.

   Resolution: Fixed
Fix Version/s: 0.12.0

> Add unix domain sockets in ruby to cross test - code exists
> ---
>
> Key: THRIFT-4358
> URL: https://issues.apache.org/jira/browse/THRIFT-4358
> Project: Thrift
>  Issue Type: Test
>  Components: Test Suite
>Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial; autoconf
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Minor
> Fix For: 0.12.0
>
>
> I see a unix domain socket class in the ruby transport directory but no cross 
> test enabled for it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (THRIFT-4358) Add unix domain sockets in ruby to cross test - code exists

[James E. King, III (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III reassigned THRIFT-4358:
--

Assignee: James E. King, III

> Add unix domain sockets in ruby to cross test - code exists
> ---
>
> Key: THRIFT-4358
> URL: https://issues.apache.org/jira/browse/THRIFT-4358
> Project: Thrift
>  Issue Type: Test
>  Components: Test Suite
>Affects Versions: 0.10.0
> Environment: docker ubuntu-xenial; autoconf
>Reporter: James E. King, III
>Assignee: James E. King, III
>Priority: Minor
> Fix For: 0.12.0
>
>
> I see a unix domain socket class in the ruby transport directory but no cross 
> test enabled for it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (THRIFT-4528) Something wrong in either ruby server or cpp client with json processing

[James E. King, III (JIRA)]

James E. King, III created THRIFT-4528:
--

 Summary: Something wrong in either ruby server or cpp client with 
json processing
 Key: THRIFT-4528
 URL: https://issues.apache.org/jira/browse/THRIFT-4528
 Project: Thrift
  Issue Type: Bug
  Components: C++ - Library, Ruby - Library
Affects Versions: 0.11.0
Reporter: James E. King, III


To reproduce, use the ubuntu-artful container, make precross, and then:
{noformat}
root@610510ab65c8:/thrift/src# test/test.py --server rb --client cpp 
Apache Thrift - Integration Test Suite
Thu Mar 22 00:40:46 2018
===
server-client:  protocol: transport:   result:
rb-cpp  accel-binary  framed-ipsuccess
rb-cpp  accel-binary  buffered-domain  success
rb-cpp  accel-binary  buffered-ip  success
rb-cpp  accel-binary  framed-domainsuccess
rb-cpp  accel-binary  framed-ip-sslsuccess
rb-cpp  accel-binary  buffered-ip-ssl  success
rb-cpp  compact   buffered-ip-ssl  success
rb-cpp  compact   buffered-domain  success
rb-cpp  compact   framed-ip-sslsuccess
rb-cpp  compact   buffered-ip  success
rb-cpp  compact   framed-domainsuccess
rb-cpp  compact   framed-ipsuccess
rb-cpp  binarybuffered-ip  success
rb-cpp  binarybuffered-domain  success
rb-cpp  binaryframed-domainsuccess
rb-cpp  binarybuffered-ip-ssl  success
rb-cpp  binaryframed-ip-sslsuccess
rb-cpp  binaryframed-ipsuccess
rb-cpp  json  buffered-ip-ssl  
failure(timeout)
rb-cpp  json  buffered-domain  success
rb-cpp  json  buffered-ip  
failure(timeout)
rb-cpp  json  framed-domain
failure(timeout)
rb-cpp  json  framed-ip-ssl
failure(timeout)
rb-cpp  json  framed-ip
failure(timeout)
===
{noformat}




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (THRIFT-4527) Upgrade byteorder version in Rust lib

[Joshua (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joshua updated THRIFT-4527:
---
Description: The Rust library was depending on byteorder v1.1.0, upgraded 
to v1.2.1 to prevent dependency conflicts in a project I was working on, works 
fine and would be useful for other users.  (was: The Rust library was depending 
on byteorder v1.1.0, upgraded to v1.2.0 to prevent dependency conflicts in a 
project I was working on, works fine now.)

> Upgrade byteorder version in Rust lib
> -
>
> Key: THRIFT-4527
> URL: https://issues.apache.org/jira/browse/THRIFT-4527
> Project: Thrift
>  Issue Type: Dependency upgrade
>  Components: Rust - Library
>Affects Versions: 0.11.0
>Reporter: Joshua
>Priority: Major
>
> The Rust library was depending on byteorder v1.1.0, upgraded to v1.2.1 to 
> prevent dependency conflicts in a project I was working on, works fine and 
> would be useful for other users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-4527) Upgrade byteorder version in Rust lib

[Joshua (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408647#comment-16408647
 ] 

Joshua commented on THRIFT-4527:


see: https://github.com/apache/thrift/pull/1516

> Upgrade byteorder version in Rust lib
> -
>
> Key: THRIFT-4527
> URL: https://issues.apache.org/jira/browse/THRIFT-4527
> Project: Thrift
>  Issue Type: Dependency upgrade
>  Components: Rust - Library
>Affects Versions: 0.11.0
>Reporter: Joshua
>Priority: Major
>
> The Rust library was depending on byteorder v1.1.0, upgraded to v1.2.0 to 
> prevent dependency conflicts in a project I was working on, works fine now.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Issue Comment Deleted] (THRIFT-4527) Upgrade byteorder version in Rust lib

[Joshua (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joshua updated THRIFT-4527:
---
Comment: was deleted

(was: see: https://github.com/apache/thrift/pull/1516)

> Upgrade byteorder version in Rust lib
> -
>
> Key: THRIFT-4527
> URL: https://issues.apache.org/jira/browse/THRIFT-4527
> Project: Thrift
>  Issue Type: Dependency upgrade
>  Components: Rust - Library
>Affects Versions: 0.11.0
>Reporter: Joshua
>Priority: Major
>
> The Rust library was depending on byteorder v1.1.0, upgraded to v1.2.0 to 
> prevent dependency conflicts in a project I was working on, works fine now.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-4527) Upgrade byteorder version in Rust lib

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408646#comment-16408646
 ] 

ASF GitHub Bot commented on THRIFT-4527:


GitHub user QuestofIranon opened a pull request:

https://github.com/apache/thrift/pull/1516

THRIFT-4527 Upgrade byteorder in rust

updated byteorder 1.1.0 -> 1.2.1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/QuestofIranon/thrift master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1516.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1516


commit a0116e5cb37e8e804b2d9758950f58d6c8776054
Author: Josh 
Date:   2018-03-21T21:34:44Z

THRIFT-4527 bump byteorder version




> Upgrade byteorder version in Rust lib
> -
>
> Key: THRIFT-4527
> URL: https://issues.apache.org/jira/browse/THRIFT-4527
> Project: Thrift
>  Issue Type: Dependency upgrade
>  Components: Rust - Library
>Affects Versions: 0.11.0
>Reporter: Joshua
>Priority: Major
>
> The Rust library was depending on byteorder v1.1.0, upgraded to v1.2.0 to 
> prevent dependency conflicts in a project I was working on, works fine now.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] thrift pull request #1516: THRIFT-4527 Upgrade byteorder in rust

[QuestofIranon]

GitHub user QuestofIranon opened a pull request:

https://github.com/apache/thrift/pull/1516

THRIFT-4527 Upgrade byteorder in rust

updated byteorder 1.1.0 -> 1.2.1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/QuestofIranon/thrift master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1516.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1516


commit a0116e5cb37e8e804b2d9758950f58d6c8776054
Author: Josh 
Date:   2018-03-21T21:34:44Z

THRIFT-4527 bump byteorder version




---

[jira] [Created] (THRIFT-4527) Upgrade byteorder version in Rust lib

[Joshua (JIRA)]

Joshua created THRIFT-4527:
--

 Summary: Upgrade byteorder version in Rust lib
 Key: THRIFT-4527
 URL: https://issues.apache.org/jira/browse/THRIFT-4527
 Project: Thrift
  Issue Type: Dependency upgrade
  Components: Rust - Library
Affects Versions: 0.11.0
Reporter: Joshua


The Rust library was depending on byteorder v1.1.0, upgraded to v1.2.0 to 
prevent dependency conflicts in a project I was working on, works fine now.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] thrift issue #1515: add connect timeout, support accurate send timeout

[dcelasun]

Github user dcelasun commented on the issue:

https://github.com/apache/thrift/pull/1515
  
Please don't change the code style while you are doing unrelated changes, 
it makes it very hard to review what *actually* changed. Even with the changes, 
there are lots of style inconsistencies like opening braces for functions are 
sometimes on the same line, sometimes on a new line.

So please revert any style-only changes and follow the existing style. If 
you want to also change/improve code style, open a separate PR for that. Thank 
you.


---

[GitHub] thrift issue #1515: add connect timeout, support accurate send timeout

[jeking3]

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1515
  
Please squash your changes to a single commit if possible.  Thanks.


---

[jira] [Commented] (THRIFT-4171) PHP TSocket sendTimeout is being used as connectTimeout

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408389#comment-16408389
 ] 

ASF GitHub Bot commented on THRIFT-4171:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1515
  
THRIFT-4171


> PHP TSocket sendTimeout is being used as connectTimeout
> ---
>
> Key: THRIFT-4171
> URL: https://issues.apache.org/jira/browse/THRIFT-4171
> Project: Thrift
>  Issue Type: Bug
>  Components: PHP - Library
>Affects Versions: 0.9.3, 0.10.0
>Reporter: James E. King, III
>Priority: Minor
>
> Adding a Thirft Jira ticket for an old pull request that implements a 
> separate connect timeout:
> https://github.com/apache/thrift/pull/744/files



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] thrift issue #1515: add connect timeout, support accurate send timeout

[jeking3]

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1515
  
THRIFT-4171


---

[GitHub] thrift pull request #1515: add connect timeout, support accurate send timeou...

[lihanharry]

GitHub user lihanharry opened a pull request:

https://github.com/apache/thrift/pull/1515

add connect timeout, support accurate send timeout



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lihanharry/thrift master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1515.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1515


commit 4e5a2aa039f9a3edb33e18411750b74a39b9c454
Author: harry 
Date:   2015-12-15T10:10:50Z

update TSocket.php
add conntimeout
support accurate send timeout and write timeout

commit 93affda4d6aefcb88929cd53e2f29cd6287b4d3e
Author: harry 
Date:   2015-12-15T10:28:23Z

modify code style

commit 588200508ac14951cc472ea6de34651ae7a202aa
Author: harry 
Date:   2015-12-15T11:04:11Z

modify code style

commit 644d7314204baad808220c98ec054032ac48
Author: harry 
Date:   2015-12-15T11:06:37Z

modify code style

commit a8a2dbf326c0f35e79378722f2629e6805e57f84
Author: netbit 
Date:   2018-03-21T17:55:57Z

rm Thrift/Transport/TSocket.php

commit 565e2982635c03bb33139330e815598927bbc983
Author: netbit 
Date:   2018-03-21T17:58:34Z

add conntimeout
support accurate send timeout and write timeout

Please enter the commit message for your changes. Lines starting

commit 82faf6e23caf5477e7cdd8b419f9437598189121
Author: netbit 
Date:   2018-03-21T18:10:46Z

modify codestyle




---

[GitHub] thrift pull request #744: update TSocket.php

[lihanharry]

Github user lihanharry closed the pull request at:

https://github.com/apache/thrift/pull/744


---

Re: [VOTE]: Move from legacy asf git to Apache GitBox

[Jake Farrell]

+1

-Jake

On Wed, Mar 21, 2018 at 8:18 AM, James E. King, III 
wrote:

> Apache GitBox provides the Thrift project more control over the lifecycle
> of pull requests and improve the team's ability to get things done in a
> timely manner.  The goal is to improve team self-service in GitHub and
> integrated CI workflows.  One important improvement for committers is that
> it allows them to "Rebase and Merge" directly in GitHub, assuming the
> commit description meets published guidelines.It also allows for more
> control over GitHub features such as issues (note there are no plans to
> switch from Apache Hira to GitHub Issues right now), and it allows pull
> requests to be assigned to committers and labelled.
>
> I found one discussion link for reference from another Apache project
> considering conversion back in July 2017:
>
> http://apache-nifi.1125220.n5.nabble.com/DISCUSS-Apache-
> Gitbox-td18273.html
>
> Please VOTE:
>
> [ ] +1 Move to Apache GitBox
> [ ] +0
> [ ] -1 Don't move to  Apache  GitBox because...
>
> Voting will end in 72 hours (excluding the weekend), March 26, 2018 at
> 9:00:00 AM EDT
> https://www.timeanddate.com/countdown/to?iso=20180326T09
>
> - Jim King (PMC Member)
>

Re: [VOTE]: Move from legacy asf git to Apache GitBox

[Wang Xin]

+1

Xin Wang
lovep...@hotmail.com



在 2018年3月21日，下午9:51，Aki Sukegawa > 写道：

+1

On Wed, Mar 21, 2018, 10:27 PM Duru Can Celasun 
> wrote:

+1

On Wed, 21 Mar 2018, at 13:18, James E. King, III wrote:
Apache GitBox provides the Thrift project more control over the lifecycle
of pull requests and improve the team's ability to get things done in a
timely manner.  The goal is to improve team self-service in GitHub and
integrated CI workflows.  One important improvement for committers is
that
it allows them to "Rebase and Merge" directly in GitHub, assuming the
commit description meets published guidelines.It also allows for more
control over GitHub features such as issues (note there are no plans to
switch from Apache Hira to GitHub Issues right now), and it allows pull
requests to be assigned to committers and labelled.

I found one discussion link for reference from another Apache project
considering conversion back in July 2017:


http://apache-nifi.1125220.n5.nabble.com/DISCUSS-Apache-Gitbox-td18273.html

Please VOTE:

[ ] +1 Move to Apache GitBox
[ ] +0
[ ] -1 Don't move to  Apache  GitBox because...

Voting will end in 72 hours (excluding the weekend), March 26, 2018 at
9:00:00 AM EDT
https://www.timeanddate.com/countdown/to?iso=20180326T09

- Jim King (PMC Member)

Re: [VOTE]: Move from legacy asf git to Apache GitBox

[Aki Sukegawa]

+1

On Wed, Mar 21, 2018, 10:27 PM Duru Can Celasun  wrote:

> +1
>
> On Wed, 21 Mar 2018, at 13:18, James E. King, III wrote:
> > Apache GitBox provides the Thrift project more control over the lifecycle
> > of pull requests and improve the team's ability to get things done in a
> > timely manner.  The goal is to improve team self-service in GitHub and
> > integrated CI workflows.  One important improvement for committers is
> that
> > it allows them to "Rebase and Merge" directly in GitHub, assuming the
> > commit description meets published guidelines.It also allows for more
> > control over GitHub features such as issues (note there are no plans to
> > switch from Apache Hira to GitHub Issues right now), and it allows pull
> > requests to be assigned to committers and labelled.
> >
> > I found one discussion link for reference from another Apache project
> > considering conversion back in July 2017:
> >
> >
> http://apache-nifi.1125220.n5.nabble.com/DISCUSS-Apache-Gitbox-td18273.html
> >
> > Please VOTE:
> >
> > [ ] +1 Move to Apache GitBox
> > [ ] +0
> > [ ] -1 Don't move to  Apache  GitBox because...
> >
> > Voting will end in 72 hours (excluding the weekend), March 26, 2018 at
> > 9:00:00 AM EDT
> > https://www.timeanddate.com/countdown/to?iso=20180326T09
> >
> > - Jim King (PMC Member)
>

Re: [VOTE]: Move from legacy asf git to Apache GitBox

[Duru Can Celasun]

+1

On Wed, 21 Mar 2018, at 13:18, James E. King, III wrote:
> Apache GitBox provides the Thrift project more control over the lifecycle
> of pull requests and improve the team's ability to get things done in a
> timely manner.  The goal is to improve team self-service in GitHub and
> integrated CI workflows.  One important improvement for committers is that
> it allows them to "Rebase and Merge" directly in GitHub, assuming the
> commit description meets published guidelines.It also allows for more
> control over GitHub features such as issues (note there are no plans to
> switch from Apache Hira to GitHub Issues right now), and it allows pull
> requests to be assigned to committers and labelled.
> 
> I found one discussion link for reference from another Apache project
> considering conversion back in July 2017:
> 
> http://apache-nifi.1125220.n5.nabble.com/DISCUSS-Apache-Gitbox-td18273.html
> 
> Please VOTE:
> 
> [ ] +1 Move to Apache GitBox
> [ ] +0
> [ ] -1 Don't move to  Apache  GitBox because...
> 
> Voting will end in 72 hours (excluding the weekend), March 26, 2018 at
> 9:00:00 AM EDT
> https://www.timeanddate.com/countdown/to?iso=20180326T09
> 
> - Jim King (PMC Member)

[jira] [Commented] (THRIFT-4451) Rust client fails to communicate with multiplexed perl/c_glib servers

[Allen George (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407862#comment-16407862
 ] 

Allen George commented on THRIFT-4451:
--

Weirdly enough, here's the sequence of back and forth. The perl server is 
listening on 45773

{noformat}
< REQUEST
12:48:59.775728 IP (tos 0x0, ttl 64, id 57597, offset 0, flags [DF], proto TCP 
(6), length 113)
   [6/1830]
127.0.0.1.52408 > 127.0.0.1.45773: Flags [P.], cksum 0xfe65 (incorrect -> 
0xa11f), seq 1:62, ack 1, win 342, options [nop,nop,TS val 6743292 ecr 
6743292], length 61
E..q..@.@.[.N...zu.V.e.
.f...f..SecondService:secondtestString...test_string.

WHAT IS THIS?!
12:48:59.775740 IP (tos 0x0, ttl 64, id 14716, offset 0, flags [DF], proto TCP 
(6), length 52)
127.0.0.1.45773 > 127.0.0.1.52408: Flags [.], cksum 0xfe28 (incorrect -> 
0x81e0), seq 1, ack 62, win 342, options [nop,nop,TS val 6743292 ecr 6743292], 
length 0
E..49|@.@..Fzu..N..E...V.(.
.f...f..

WHAT IS THIS?
12:49:05.748396 IP (tos 0x0, ttl 64, id 57598, offset 0, flags [DF], proto TCP 
(6), length 52)
127.0.0.1.52408 > 127.0.0.1.45773: Flags [F.], cksum 0xfe28 (incorrect -> 
0x7f89), seq 62, ack 1, win 342, options [nop,nop,TS val 6743890 ecr 6743292], 
length 0
E..4..@.@.[.N..Ezu.V.(.
.f.R.f..

---> RESPONSE
12:49:05.752416 IP (tos 0x0, ttl 64, id 14717, offset 0, flags [DF], proto TCP 
(6), length 126)
127.0.0.1.45773 > 127.0.0.1.52408: Flags [P.], cksum 0xfe72 (incorrect -> 
0x2820), seq 1:75, ack 63, win 342, options [nop,nop,TS val 6743890 ecr 
6743890], length 74
E..~9}@.@...zu..N..F...V.r.
{noformat}

I'm assuming the "WHAT IS THIS" lines are TCP-level packets?

> Rust client fails to communicate with multiplexed perl/c_glib servers
> -
>
> Key: THRIFT-4451
> URL: https://issues.apache.org/jira/browse/THRIFT-4451
> Project: Thrift
>  Issue Type: Bug
>  Components: Rust - Library
>Reporter: Allen George
>Assignee: Allen George
>Priority: Major
>
> As stated in description. Minimal case is to comment out everything in the 
> Rust {{test_client}} leaving only the {{SecondService}} call behind.
> From what I can tell the Rust socket isn't getting *any* bytes at all for the 
> response (i.e. it can't even get the first 4 bytes of the message header). 
> There is a {{flush()}} call on the remote side - so that's puzzling.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (THRIFT-4451) Rust client fails to communicate with multiplexed perl/c_glib servers

[Allen George (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407860#comment-16407860
 ] 

Allen George commented on THRIFT-4451:
--

I'm noticing weird behavior where the rust client opens multiple tcp 
connections to the perl server (as an example).

 
{noformat}
E..<..@.@.<.U!..._k..0. 

 [49/1830]
.f...f..
12:48:59.767657 IP (tos 0x0, ttl 64, id 36675, offset 0, flags [DF], proto TCP 
(6), length 52)
127.0.0.1.52406 > 127.0.0.1.45773: Flags [.], cksum 0xfe28 (incorrect -> 
0xe90b), seq 1, ack 1, win 342, options [nop,nop,TS val 6743292 ecr 6743292], 
length 0
E..4.C@.@..~._k.U!.V.(.
.f...f..
12:48:59.767908 IP (tos 0x0, ttl 64, id 57595, offset 0, flags [DF], proto TCP 
(6), length 60)
127.0.0.1.52408 > 127.0.0.1.45773: Flags [S], cksum 0xfe30 (incorrect -> 
0xed41), seq 1325204487, win 43690, options [mss 65495,sackOK,TS val 6743292 
ecr 0,nop,wscale 7], length 0
E..<..@.@.[.N0.
.f..
12:48:59.767923 IP (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto TCP (6), 
length 60)
127.0.0.1.45773 > 127.0.0.1.52408: Flags [S.], cksum 0xfe30 (incorrect -> 
0xafd8), seq 2054544767, ack 1325204488, win 43690, options [mss 
65495,sackOK,TS val 6743292 ecr 6743292,nop,wscale 7], length 0
E..<..@.@.<.zu..N0.
.f...f..
12:48:59.767937 IP (tos 0x0, ttl 64, id 57596, offset 0, flags [DF], proto TCP 
(6), length 52)
127.0.0.1.52408 > 127.0.0.1.45773: Flags [.], cksum 0xfe28 (incorrect -> 
0x821d), seq 1, ack 1, win 342, options [nop,nop,TS val 6743292 ecr 6743292], 
length 0
E..4..@.@.[.N...zu.V.(.
.f...f..
12:48:59.769584 IP (tos 0x0, ttl 64, id 36676, offset 0, flags [DF], proto TCP 
(6), length 84)
127.0.0.1.52406 > 127.0.0.1.45773: Flags [P.], cksum 0xfe48 (incorrect -> 
0x8b06), seq 1:33, ack 1, win 342, options [nop,nop,TS val 6743292 ecr 
6743292], length 32
E..T.D@.@..]._k.U!.V.H.
.f...f..ThriftTest:testVoid.
12:48:59.769599 IP (tos 0x0, ttl 64, id 30002, offset 0, flags [DF], proto TCP 
(6), length 52)
127.0.0.1.45773 > 127.0.0.1.52406: Flags [.], cksum 0xfe28 (incorrect -> 
0xe8eb), seq 1, ack 33, win 342, options [nop,nop,TS val 6743292 ecr 6743292], 
length 0
E..4u2@.@...U!..._kV.(.
.f...f..
12:48:59.771085 IP (tos 0x0, ttl 64, id 30003, offset 0, flags [DF], proto TCP 
(6), length 73)
127.0.0.1.45773 > 127.0.0.1.52406: Flags [P.], cksum 0xfe3d (incorrect -> 
0xc114), seq 1:22, ack 33, win 342, options [nop,nop,TS val 6743292 ecr 
6743292], length 21
E..Iu3@.@..yU!..._kV.=.
.f...f..testVoid.
{noformat}

The above shows two different connections involved here. It's unclear if this 
is the cause of the issues, but it explains why bytes being flushed out of the 
perl server never seem to show up at the rust client.

FWIW, I *have* confirmed that the flushed bytes appear on the wire:

{noformat}
12:49:05.752416 IP (tos 0x0, ttl 64, id 14717, offset 0, flags [DF], proto TCP 
(6), length 126)
127.0.0.1.45773 > 127.0.0.1.52408: Flags [P.], cksum 0xfe72 (incorrect -> 
0x2820), seq 1:75, ack 63, win 342, options [nop,nop,TS val 6743890 ecr 
6743890], length 74
E..~9}@.@...zu..N..F...V.r.
.f.R.f.RsecondtestString..("test_string").
{noformat}

> Rust client fails to communicate with multiplexed perl/c_glib servers
> -
>
> Key: THRIFT-4451
> URL: https://issues.apache.org/jira/browse/THRIFT-4451
> Project: Thrift
>  Issue Type: Bug
>  Components: Rust - Library
>Reporter: Allen George
>Assignee: Allen George
>Priority: Major
>
> As stated in description. Minimal case is to comment out everything in the 
> Rust {{test_client}} leaving only the {{SecondService}} call behind.
> From what I can tell the Rust socket isn't getting *any* bytes at all for the 
> response (i.e. it can't even get the first 4 bytes of the message header). 
> There is a {{flush()}} call on the remote side - so that's puzzling.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[VOTE]: Move from legacy asf git to Apache GitBox

[James E. King, III]

Apache GitBox provides the Thrift project more control over the lifecycle
of pull requests and improve the team's ability to get things done in a
timely manner.  The goal is to improve team self-service in GitHub and
integrated CI workflows.  One important improvement for committers is that
it allows them to "Rebase and Merge" directly in GitHub, assuming the
commit description meets published guidelines.It also allows for more
control over GitHub features such as issues (note there are no plans to
switch from Apache Hira to GitHub Issues right now), and it allows pull
requests to be assigned to committers and labelled.

I found one discussion link for reference from another Apache project
considering conversion back in July 2017:

http://apache-nifi.1125220.n5.nabble.com/DISCUSS-Apache-Gitbox-td18273.html

Please VOTE:

[ ] +1 Move to Apache GitBox
[ ] +0
[ ] -1 Don't move to  Apache  GitBox because...

Voting will end in 72 hours (excluding the weekend), March 26, 2018 at
9:00:00 AM EDT
https://www.timeanddate.com/countdown/to?iso=20180326T09

- Jim King (PMC Member)

[jira] [Commented] (THRIFT-4489) Unix domain socket support for NodeJS client

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407782#comment-16407782
 ] 

ASF GitHub Bot commented on THRIFT-4489:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1491


> Unix domain socket support for NodeJS client
> 
>
> Key: THRIFT-4489
> URL: https://issues.apache.org/jira/browse/THRIFT-4489
> Project: Thrift
>  Issue Type: Improvement
>  Components: Node.js - Library
>Affects Versions: 0.11.0
>Reporter: Daniel Shih
>Assignee: James E. King, III
>Priority: Major
> Fix For: 0.12.0
>
>
> I would like to use Unix domain sockets for NodeJS client,
> Here is the proposed PR: https://github.com/apache/thrift/pull/1491



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (THRIFT-4489) Unix domain socket support for NodeJS client

[James E. King, III (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III resolved THRIFT-4489.

   Resolution: Fixed
Fix Version/s: 0.12.0

Committed - thanks.

> Unix domain socket support for NodeJS client
> 
>
> Key: THRIFT-4489
> URL: https://issues.apache.org/jira/browse/THRIFT-4489
> Project: Thrift
>  Issue Type: Improvement
>  Components: Node.js - Library
>Affects Versions: 0.11.0
>Reporter: Daniel Shih
>Assignee: James E. King, III
>Priority: Major
> Fix For: 0.12.0
>
>
> I would like to use Unix domain sockets for NodeJS client,
> Here is the proposed PR: https://github.com/apache/thrift/pull/1491



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] thrift pull request #1491: THRIFT-4489: Add UDS support for nodejs thrift cl...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1491


---