[jira] [Commented] (THRIFT-4676) CL tutorial build fails sporadically

2018-11-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/THRIFT-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705306#comment-16705306
 ] 

ASF GitHub Bot commented on THRIFT-4676:


allengeorge commented on issue #1639: THRIFT-4676: Prevent CL tutorial 
server/client being built in parallel
URL: https://github.com/apache/thrift/pull/1639#issuecomment-443347279
 
 
   Second try: it appears that executing the builds sequentially doesn't help 
because the same path is being used for the compiler cache? I think? So I'll 
try disabling it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CL tutorial build fails sporadically
> 
>
> Key: THRIFT-4676
> URL: https://issues.apache.org/jira/browse/THRIFT-4676
> Project: Thrift
>  Issue Type: Task
>  Components: Build Process
>Reporter: Allen George
>Assignee: Allen George
>Priority: Minor
>
> Many of the CI failures are caused by the CL tutorial build failing. This 
> isn't because the CL code is wrong, it's simply because of a race condition 
> _somewhere_.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (THRIFT-4676) CL tutorial build fails sporadically

2018-11-30 Thread Allen George (JIRA)


[ 
https://issues.apache.org/jira/browse/THRIFT-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705295#comment-16705295
 ] 

Allen George commented on THRIFT-4676:
--

[sigh]

Now it crashes because of something 
[different|https://api.travis-ci.org/v3/job/461948388/log.txt]

{noformat}
; 
/root/.cache/common-lisp/sbcl-1.4.12-linux-x64/thrift/src/lib/cl/externals/software/clon-1.0b24/core/src/context-tmp73HU0RPK.fasl
 written
; compilation finished in 0:00:00.528
Unhandled SIMPLE-ERROR in thread #:
  Couldn't execute 
"/root/.cache/common-lisp/sbcl-1.4.12-linux-x64/thrift/src/lib/cl/externals/software/clon-1.0b24/termio/sbcl/a.out":
 Permission denied

Backtrace for: #
0: (SB-DEBUG::DEBUGGER-DISABLED-HOOK # # :QUIT T)
1: (SB-DEBUG::RUN-HOOK *INVOKE-DEBUGGER-HOOK* #)
2: (INVOKE-DEBUGGER #)
3: (ERROR "Couldn't execute ~S: ~A" 
"/root/.cache/common-lisp/sbcl-1.4.12-linux-x64/thrift/src/lib/cl/externals/software/clon-1.0b24/termio/sbcl/a.out"
 "Permission denied")
4: (RUN-PROGRAM 
"/root/.cache/common-lisp/sbcl-1.4.12-linux-x64/thrift/src/lib/cl/externals/software/clon-1.0b24/termio/sbcl/a.out"
 
("/root/.cache/common-lisp/sbcl-1.4.12-linux-x64/thrift/src/lib/cl/externals/software/clon-1.0b24/termio/sbcl/constants.lisp-temp")
 :ENV NIL :ENVIRONMENT NIL :WAIT T :SEARCH NIL :PTY NIL :INPUT NIL 
:IF-INPUT-DOES-NOT-EXIST NIL :OUTPUT # :IF-OUTPUT-EXISTS :ERROR :ERROR :OUTPUT :IF-ERROR-EXISTS :ERROR 
:STATUS-HOOK NIL :EXTERNAL-FORMAT :DEFAULT :DIRECTORY NIL)
5: ((:METHOD ASDF/ACTION:PERFORM (ASDF/LISP-ACTION:COMPILE-OP 
SB-GROVEL:GROVEL-CONSTANTS-FILE)) # 
#) [fast-method]
6: ((SB-PCL::EMF ASDF/ACTION:PERFORM) # # 
# #)
7: ((LAMBDA NIL :IN ASDF/ACTION:CALL-WHILE-VISITING-ACTION))
8: ((:METHOD ASDF/ACTION:PERFORM-WITH-RESTARTS :AROUND (T T)) 
# #) [fast-method]
9: ((:METHOD ASDF/PLAN:PERFORM-PLAN (T)) #) [fast-method]
10: ((FLET SB-C::WITH-IT :IN SB-C::%WITH-COMPILATION-UNIT))
11: ((:METHOD ASDF/PLAN:PERFORM-PLAN :AROUND (T)) #) [fast-method]
12: ((:METHOD ASDF/OPERATE:OPERATE (ASDF/OPERATION:OPERATION 
ASDF/COMPONENT:COMPONENT)) # # :PLAN-CLASS NIL :PLAN-OPTIONS NIL) [fast-method]
13: ((SB-PCL::EMF ASDF/OPERATE:OPERATE) # # 
# #)
14: ((LAMBDA NIL :IN ASDF/OPERATE:OPERATE))
15: ((:METHOD ASDF/OPERATE:OPERATE :AROUND (T T)) # 
#) [fast-method]
16: ((SB-PCL::EMF ASDF/OPERATE:OPERATE) # # 
ASDF/LISP-ACTION:LOAD-OP :NET.DIDIERVERNA.CLON)
17: ((LAMBDA NIL :IN ASDF/OPERATE:OPERATE))
18: ((:METHOD ASDF/OPERATE:OPERATE :AROUND (T T)) ASDF/LISP-ACTION:LOAD-OP 
:NET.DIDIERVERNA.CLON) [fast-method]
19: (ASDF/SESSION:CALL-WITH-ASDF-SESSION # :OVERRIDE T :KEY NIL :OVERRIDE-CACHE T 
:OVERRIDE-FORCING NIL)
20: ((LAMBDA NIL :IN ASDF/OPERATE:OPERATE))
21: (ASDF/SESSION:CALL-WITH-ASDF-SESSION # :OVERRIDE NIL :KEY NIL :OVERRIDE-CACHE NIL 
:OVERRIDE-FORCING NIL)
22: ((:METHOD ASDF/OPERATE:OPERATE :AROUND (T T)) ASDF/LISP-ACTION:LOAD-OP 
:NET.DIDIERVERNA.CLON) [fast-method]
23: (ASDF/OPERATE:LOAD-SYSTEM :NET.DIDIERVERNA.CLON)
24: (SB-INT:SIMPLE-EVAL-IN-LEXENV (ASDF/OPERATE:LOAD-SYSTEM 
:NET.DIDIERVERNA.CLON) #)
25: (EVAL-TLF (ASDF/OPERATE:LOAD-SYSTEM :NET.DIDIERVERNA.CLON) 3 NIL)
26: ((LABELS SB-FASL::EVAL-FORM :IN SB-INT:LOAD-AS-SOURCE) 
(ASDF/OPERATE:LOAD-SYSTEM :NET.DIDIERVERNA.CLON) 3)
27: ((LAMBDA (SB-KERNEL:FORM  :CURRENT-INDEX ) :IN 
SB-INT:LOAD-AS-SOURCE) (ASDF/OPERATE:LOAD-SYSTEM :NET.DIDIERVERNA.CLON) 
:CURRENT-INDEX 3)
28: (SB-C::%DO-FORMS-FROM-INFO # 
# SB-C::INPUT-ERROR-IN-LOAD)
29: (SB-INT:LOAD-AS-SOURCE # :VERBOSE NIL :PRINT 
NIL :CONTEXT "loading")
30: ((FLET SB-FASL::THUNK :IN LOAD))
31: (SB-FASL::CALL-WITH-LOAD-BINDINGS # #)
32: ((FLET SB-FASL::LOAD-STREAM :IN LOAD) # NIL)
33: (LOAD # :VERBOSE NIL :PRINT 
NIL :IF-DOES-NOT-EXIST T :EXTERNAL-FORMAT :DEFAULT)
34: ((FLET SB-IMPL::LOAD-SCRIPT :IN SB-IMPL::PROCESS-SCRIPT) #)
35: ((FLET SB-UNIX::BODY :IN SB-IMPL::PROCESS-SCRIPT))
36: ((FLET "WITHOUT-INTERRUPTS-BODY-2" :IN SB-IMPL::PROCESS-SCRIPT))
37: (SB-IMPL::PROCESS-SCRIPT "make-test-server.lisp")
38: (SB-IMPL::TOPLEVEL-INIT)
39: ((FLET SB-UNIX::BODY :IN SAVE-LISP-AND-DIE))
40: ((FLET "WITHOUT-INTERRUPTS-BODY-27" :IN SAVE-LISP-AND-DIE))
41: ((LABELS SB-IMPL::RESTART-LISP :IN SAVE-LISP-AND-DIE))

unhandled condition in --disable-debugger mode, quitting
{noformat}

> CL tutorial build fails sporadically
> 
>
> Key: THRIFT-4676
> URL: https://issues.apache.org/jira/browse/THRIFT-4676
> Project: Thrift
>  Issue Type: Task
>  Components: Build Process
>Reporter: Allen George
>Assignee: Allen George
>Priority: Minor
>
> Many of the CI failures are caused by the CL tutorial build failing. This 
> isn't because the CL code is wrong, it's simply because of a race condition 
> _somewhere_.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (THRIFT-4676) CL tutorial build fails sporadically

2018-11-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/THRIFT-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705294#comment-16705294
 ] 

ASF GitHub Bot commented on THRIFT-4676:


allengeorge commented on issue #1639: THRIFT-4676: Prevent CL tutorial 
server/client being built in parallel
URL: https://github.com/apache/thrift/pull/1639#issuecomment-443343701
 
 
   Amazing. Now the CL build is failing with another error, specifically that 
it doesn't have permissions to write an out file...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CL tutorial build fails sporadically
> 
>
> Key: THRIFT-4676
> URL: https://issues.apache.org/jira/browse/THRIFT-4676
> Project: Thrift
>  Issue Type: Task
>  Components: Build Process
>Reporter: Allen George
>Assignee: Allen George
>Priority: Minor
>
> Many of the CI failures are caused by the CL tutorial build failing. This 
> isn't because the CL code is wrong, it's simply because of a race condition 
> _somewhere_.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (THRIFT-4676) CL tutorial build fails sporadically

2018-11-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/THRIFT-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705228#comment-16705228
 ] 

ASF GitHub Bot commented on THRIFT-4676:


allengeorge opened a new pull request #1639: THRIFT-4676: Prevent CL tutorial 
server/client being built in parallel
URL: https://github.com/apache/thrift/pull/1639
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CL tutorial build fails sporadically
> 
>
> Key: THRIFT-4676
> URL: https://issues.apache.org/jira/browse/THRIFT-4676
> Project: Thrift
>  Issue Type: Task
>  Components: Build Process
>Reporter: Allen George
>Assignee: Allen George
>Priority: Minor
>
> Many of the CI failures are caused by the CL tutorial build failing. This 
> isn't because the CL code is wrong, it's simply because of a race condition 
> _somewhere_.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (THRIFT-3143) add typescript directory support

2018-11-30 Thread James E. King III (JIRA)


[ 
https://issues.apache.org/jira/browse/THRIFT-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704934#comment-16704934
 ] 

James E. King III commented on THRIFT-3143:
---

It's possible.  The 0.12.0 release train already started, but stalled, and we 
might restart it, in which case it would get included.

> add typescript directory support
> 
>
> Key: THRIFT-3143
> URL: https://issues.apache.org/jira/browse/THRIFT-3143
> Project: Thrift
>  Issue Type: New Feature
>  Components: Node.js - Compiler
>Reporter: Kazuki Yasufuku
>Assignee: James E. King III
>Priority: Major
> Fix For: 1.0
>
>
> Current typescript support is only work for browser, and generated d.ts uses 
> internal module.
> So, it's hard to use for typescript in node.js.
> To solve probrem, I make a pull request that generate typescript code 
> directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (THRIFT-3143) add typescript directory support

2018-11-30 Thread JIRA


[ 
https://issues.apache.org/jira/browse/THRIFT-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704884#comment-16704884
 ] 

Mustafa Şenol Coşar commented on THRIFT-3143:
-

Hi [~jking3],

Are this changes going to be included in the next release?

Thanks, -Mustafa

> add typescript directory support
> 
>
> Key: THRIFT-3143
> URL: https://issues.apache.org/jira/browse/THRIFT-3143
> Project: Thrift
>  Issue Type: New Feature
>  Components: Node.js - Compiler
>Reporter: Kazuki Yasufuku
>Assignee: James E. King III
>Priority: Major
> Fix For: 1.0
>
>
> Current typescript support is only work for browser, and generated d.ts uses 
> internal module.
> So, it's hard to use for typescript in node.js.
> To solve probrem, I make a pull request that generate typescript code 
> directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (THRIFT-4677) UnicodeDecodeError in Python3

2018-11-30 Thread Jarry Shaw (JIRA)
Jarry Shaw created THRIFT-4677:
--

 Summary: UnicodeDecodeError in Python3
 Key: THRIFT-4677
 URL: https://issues.apache.org/jira/browse/THRIFT-4677
 Project: Thrift
  Issue Type: Bug
  Components: Python - Library
 Environment: Operating System: Windows 10 Pro (Simplified Chinese)

Python Interpreter: Python 3.6.6

{{osquery}} Version: 3.3.0

{{osquery-python}} Version: 3.0.5

 
Reporter: Jarry Shaw
 Attachments: compat.py

This is an issue occurred when using 
[osquery-python|https://github.com/osquery/osquery-python] (Python binding of 
[osquery|https://osquery.io/] by Facebook).

When querying, {{UnicodeDecodeError}} raised with error message: "{{'utf-8' 
codec can't decode byte 0xc3 in position 0: invalid continuation byte}}" from 
{{thrift.compat.binary_to_str}}, which is because the encoding of {{bin_val}} 
parameter should be "{{gbk}}".

Possible approaches are:
 * add a parameter for user to determine encodings
 * get the system encoding through {{locale.getpreferredencoding()}}
 * call {{bin_val.decode}} with {{errors='replace'}} or {{errors='ignore'}} 
parameter
 * introduce {{chardet}} to try and resolve encoding problems

The attachment is my hack solution to this issue (through not perfect).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (THRIFT-4676) CL tutorial build fails sporadically

2018-11-30 Thread Allen George (JIRA)


[ 
https://issues.apache.org/jira/browse/THRIFT-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704655#comment-16704655
 ] 

Allen George commented on THRIFT-4676:
--

This is the clearest example of the problem I've found to date:

[Travis Build Log for Job 
454293219|https://api.travis-ci.org/v3/job/454293219/log.txt]

Relevant section:
{noformat}
make[2]: Entering directory '/thrift/src/tutorial/cl'
/thrift/src/compiler/cpp/thrift --gen cl -r ../../tutorial/tutorial.thrift
/usr/local/bin/sbcl --script make-tutorial-client.lisp
/usr/local/bin/sbcl --script make-tutorial-server.lisp
WARNING: System definition file 
#P"/thrift/src/lib/cl/externals/software/puri-20180228-git/puri.asd" contains 
definition for system "puri-tests". Please only define "puri" and secondary 
systems with a name starting with "puri/" (e.g. "puri/test") in that file.
WARNING: System definition file 
#P"/thrift/src/lib/cl/externals/software/puri-20180228-git/puri.asd" contains 
definition for system "puri-tests". Please only define "puri" and secondary 
systems with a name starting with "puri/" (e.g. "puri/test") in that file.
WARNING: System definition file 
#P"/thrift/src/lib/cl/externals/software/trivial-utf-8-20111001-darcs/trivial-utf-8.asd"
 contains definition for system "trivial-utf-8-tests". Please only define 
"trivial-utf-8" and secondary systems with a name starting with 
"trivial-utf-8/" (e.g. "trivial-utf-8/test") in that file.
WARNING: System definition file 
#P"/thrift/src/lib/cl/externals/software/ieee-floats-20170830-git/ieee-floats.asd"
 contains definition for system "ieee-floats-tests". Please only define 
"ieee-floats" and secondary systems with a name starting with "ieee-floats/" 
(e.g. "ieee-floats/test") in that file.
WARNING: System definition file 
#P"/thrift/src/lib/cl/externals/software/trivial-utf-8-20111001-darcs/trivial-utf-8.asd"
 contains definition for system "trivial-utf-8-tests". Please only define 
"trivial-utf-8" and secondary systems with a name starting with 
"trivial-utf-8/" (e.g. "trivial-utf-8/test") in that file.
WARNING: System definition file 
#P"/thrift/src/lib/cl/externals/software/ieee-floats-20170830-git/ieee-floats.asd"
 contains definition for system "ieee-floats-tests". Please only define 
"ieee-floats" and secondary systems with a name starting with "ieee-floats/" 
(e.g. "ieee-floats/test") in that file.
WARNING: Deprecated recursive use of (OPERATE 'LOAD-OP '("sb-grovel")) while 
visiting (LOAD-OP "net.didierverna.clon.setup/termio") - please use proper 
dependencies instead
WARNING: Deprecated recursive use of (OPERATE 'LOAD-OP '("sb-grovel")) while 
visiting (LOAD-OP "net.didierverna.clon.setup/termio") - please use proper 
dependencies instead
WARNING: PARSE-VERSION: "1.0b24" doesn't follow asdf version numbering 
convention
WARNING: Invalid :version specifier "1.0b24" for component 
"net.didierverna.clon" from file 
#P"/thrift/src/lib/cl/externals/software/clon-1.0b24/net.didierverna.clon.asd", 
using NIL instead
WARNING: Invalid :version specifier "1.0b24" for component 
"net.didierverna.clon" from file 
#P"/thrift/src/lib/cl/externals/software/clon-1.0b24/net.didierverna.clon.asd", 
using NIL instead
WARNING: PARSE-VERSION: "1.0b24" doesn't follow asdf version numbering 
convention
WARNING: Invalid :version specifier "1.0b24" for component 
"net.didierverna.clon" from file 
#P"/thrift/src/lib/cl/externals/software/clon-1.0b24/net.didierverna.clon.asd", 
using NIL instead
WARNING: Invalid :version specifier "1.0b24" for component 
"net.didierverna.clon" from file 
#P"/thrift/src/lib/cl/externals/software/clon-1.0b24/net.didierverna.clon.asd", 
using NIL instead
WARNING: PARSE-VERSION: "1.0b24" doesn't follow asdf version numbering 
convention
WARNING: Invalid :version specifier "1.0b24" for component 
"net.didierverna.clon.core" from file 
#P"/thrift/src/lib/cl/externals/software/clon-1.0b24/core/net.didierverna.clon.core.asd",
 using NIL instead
WARNING: Invalid :version specifier "1.0b24" for component 
"net.didierverna.clon.core" from file 
#P"/thrift/src/lib/cl/externals/software/clon-1.0b24/core/net.didierverna.clon.core.asd",
 using NIL instead
WARNING: PARSE-VERSION: "1.0b24" doesn't follow asdf version numbering 
convention
WARNING: Invalid :version specifier "1.0b24" for component 
"net.didierverna.clon.core" from file 
#P"/thrift/src/lib/cl/externals/software/clon-1.0b24/core/net.didierverna.clon.core.asd",
 using NIL instead
WARNING: Invalid :version specifier "1.0b24" for component 
"net.didierverna.clon.core" from file 
#P"/thrift/src/lib/cl/externals/software/clon-1.0b24/core/net.didierverna.clon.core.asd",
 using NIL instead
WARNING: PARSE-VERSION: "1.0b24" doesn't follow asdf version numbering 
convention
WARNING: Invalid :version specifier "1.0b24" for component 
"net.didierverna.clon.termio" from file 

[jira] [Comment Edited] (THRIFT-4676) CL tutorial build fails sporadically

2018-11-30 Thread Allen George (JIRA)


[ 
https://issues.apache.org/jira/browse/THRIFT-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704643#comment-16704643
 ] 

Allen George edited comment on THRIFT-4676 at 11/30/18 12:14 PM:
-

I've been trying to track down the SBCL failures for a while. I've been able to 
isolate it to the {{TutorialServer}}, {{TutorialClient}} build, and something 
about the generated .fasl files not existing in the SBCL compile cache. I'm 
pretty sure this is because of a race between two build jobs.


was (Author: allengeorge):
I've been trying to track down the SBCL failures for a while. I've been able to 
isolate it to the {TutorialServer}, {TutorialClient} build, and something about 
the generated .fasl files not existing in the SBCL compile cache. I'm pretty 
sure this is because of a race between two build jobs.

> CL tutorial build fails sporadically
> 
>
> Key: THRIFT-4676
> URL: https://issues.apache.org/jira/browse/THRIFT-4676
> Project: Thrift
>  Issue Type: Task
>  Components: Build Process
>Reporter: Allen George
>Assignee: Allen George
>Priority: Minor
>
> Many of the CI failures are caused by the CL tutorial build failing. This 
> isn't because the CL code is wrong, it's simply because of a race condition 
> _somewhere_.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (THRIFT-4676) CL tutorial build fails sporadically

2018-11-30 Thread Allen George (JIRA)


[ 
https://issues.apache.org/jira/browse/THRIFT-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704643#comment-16704643
 ] 

Allen George commented on THRIFT-4676:
--

I've been trying to track down the SBCL failures for a while. I've been able to 
isolate it to the {TutorialServer}, {TutorialClient} build, and something about 
the generated .fasl files not existing in the SBCL compile cache. I'm pretty 
sure this is because of a race between two build jobs.

> CL tutorial build fails sporadically
> 
>
> Key: THRIFT-4676
> URL: https://issues.apache.org/jira/browse/THRIFT-4676
> Project: Thrift
>  Issue Type: Task
>  Components: Build Process
>Reporter: Allen George
>Assignee: Allen George
>Priority: Minor
>
> Many of the CI failures are caused by the CL tutorial build failing. This 
> isn't because the CL code is wrong, it's simply because of a race condition 
> _somewhere_.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (THRIFT-4676) CL tutorial build fails sporadically

2018-11-30 Thread Allen George (JIRA)
Allen George created THRIFT-4676:


 Summary: CL tutorial build fails sporadically
 Key: THRIFT-4676
 URL: https://issues.apache.org/jira/browse/THRIFT-4676
 Project: Thrift
  Issue Type: Task
  Components: Build Process
Reporter: Allen George
Assignee: Allen George


Many of the CI failures are caused by the CL tutorial build failing. This isn't 
because the CL code is wrong, it's simply because of a race condition 
_somewhere_.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (THRIFT-3143) add typescript directory support

2018-11-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/THRIFT-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704409#comment-16704409
 ] 

ASF GitHub Bot commented on THRIFT-3143:


mustafa-cosar commented on issue #1630: THRIFT-3143: Add nodets support
URL: https://github.com/apache/thrift/pull/1630#issuecomment-443130971
 
 
   Thanks for merging it.
   
   Here is the necessary info (the cross test covers the following cases):
   - nodets
   - since: 0.12.0 (next release, I guess)
   - lang/lib levels: Min: TypeScript 3.1.6
   - Low level transports: Socket
   - Transport wrappers: TLS
   - Protocols: binary
   - Servers: Simple
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> add typescript directory support
> 
>
> Key: THRIFT-3143
> URL: https://issues.apache.org/jira/browse/THRIFT-3143
> Project: Thrift
>  Issue Type: New Feature
>  Components: Node.js - Compiler
>Reporter: Kazuki Yasufuku
>Assignee: James E. King III
>Priority: Major
> Fix For: 1.0
>
>
> Current typescript support is only work for browser, and generated d.ts uses 
> internal module.
> So, it's hard to use for typescript in node.js.
> To solve probrem, I make a pull request that generate typescript code 
> directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)