Re: Why is load-locally.lisp required for the CL library?

2018-12-01 Thread Allen George
I think I puzzled through a lot of it, though it’s definitely unexpected.

>From what I can tell, ensure-externals.sh:

1. Creates and sets up a quicklisp environment in "lib/cl"
2. Downloads all the dependencies for the CL thrift library into a
subdirectory called “externals”
3. Downloads the _actual thrift lib_ into another subdirectory called “lib”
(so, yup, the actual CL thrift lib isn’t in-tree)

And, load-locally.lisp:

1. Loads all the dependencies of the CL thrift lib from “externals”
2. Loads the CL thrift lib itself from “lib”

Allen


On December 1, 2018 at 21:57:09, James E. King III (jk...@apache.org) wrote:
Recommended contacting the original authors for insight.

On Sat, Dec 1, 2018, 1:03 PM Allen George  I’m trying to fix the spurious build failures in the CL tutorial
> build. I don’t know anything about CL, so I’m confused about a couple
> of things:
>
> 1. What is load-locally.lisp?
> 2. What is ensure-externals.sh? (AFAICT it’s downloading the required
> lisp libraries; can’t that be done during docker image setup or
> something?)
> 3. Is there any downside to ensure-externals being executed in the
> tutorial/cl directory? i.e. does it need to be in the lib/cl
> directory?
>
> Thanks
>


Re: Why is load-locally.lisp required for the CL library?

2018-12-01 Thread James E. King III
Recommended contacting the original authors for insight.

On Sat, Dec 1, 2018, 1:03 PM Allen George  I’m trying to fix the spurious build failures in the CL tutorial
> build. I don’t know anything about CL, so I’m confused about a couple
> of things:
>
> 1. What is load-locally.lisp?
> 2. What is ensure-externals.sh? (AFAICT it’s downloading the required
> lisp libraries; can’t that be done during docker image setup or
> something?)
> 3. Is there any downside to ensure-externals being executed in the
> tutorial/cl directory? i.e. does it need to be in the lib/cl
> directory?
>
> Thanks
>


Why is load-locally.lisp required for the CL library?

2018-12-01 Thread Allen George
I’m trying to fix the spurious build failures in the CL tutorial
build. I don’t know anything about CL, so I’m confused about a couple
of things:

1. What is load-locally.lisp?
2. What is ensure-externals.sh? (AFAICT it’s downloading the required
lisp libraries; can’t that be done during docker image setup or
something?)
3. Is there any downside to ensure-externals being executed in the
tutorial/cl directory? i.e. does it need to be in the lib/cl
directory?

Thanks


[jira] [Commented] (THRIFT-4676) CL tutorial build fails sporadically

2018-12-01 Thread Allen George (JIRA)


[ 
https://issues.apache.org/jira/browse/THRIFT-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705945#comment-16705945
 ] 

Allen George commented on THRIFT-4676:
--

Now failing with a different error:

{noformat}
; /thrift/src/lib/cl/externals/software/puri-20180228-git/src-tmpGHU3ALSV.fasl 
written
; compilation finished in 0:00:00.462
While evaluating the form starting at line 23, column 0
  of #P"/thrift/src/tutorial/cl/../../lib/cl/load-locally.lisp":
Unhandled SB-INT:SIMPLE-FILE-ERROR in thread #:
  Failed to find the TRUENAME of 
/thrift/src/lib/cl/externals/software/puri-20180228-git/src.fasl:
Unknown error 2049

Backtrace for: #
0: (SB-DEBUG::DEBUGGER-DISABLED-HOOK #" {10041D39B3}> # :QUIT T)
1: (SB-DEBUG::RUN-HOOK *INVOKE-DEBUGGER-HOOK* #" {10041D39B3}>)
2: (INVOKE-DEBUGGER #" 
{10041D39B3}>)
3: (ERROR SB-INT:SIMPLE-FILE-ERROR :PATHNAME 
#P"/thrift/src/lib/cl/externals/software/puri-20180228-git/src.fasl" 
:FORMAT-CONTROL "~@<~?~@[: ~2I~_~A~]~:>" :FORMAT-ARGUMENTS ("Failed to find the 
~*~A~2:* of ~A" 
(#P"/thrift/src/lib/cl/externals/software/puri-20180228-git/src.fasl" 
:TRUENAME) "Unknown error 2049"))
4: ((LABELS SB-IMPL::RESOLVE-PROBLEMATIC-SYMLINK :IN 
SB-IMPL::%QUERY-FILE-SYSTEM) 
"/thrift/src/lib/cl/externals/software/puri-20180228-git/src.fasl" 2049 T)
5: (SB-IMPL::%QUERY-FILE-SYSTEM 
#P"/thrift/src/lib/cl/externals/software/puri-20180228-git/src.fasl" :TRUENAME 
T)
6: (TRUENAME 
#P"/thrift/src/lib/cl/externals/software/puri-20180228-git/src.fasl")
7: (RENAME-FILE 
#P"/thrift/src/lib/cl/externals/software/puri-20180228-git/src-tmpGHU3ALSV.fasl"
 #P"/thrift/src/lib/cl/externals/software/puri-20180228-git/src.fasl")
8: (UIOP/LISP-BUILD:COMPILE-FILE* 
#P"/thrift/src/lib/cl/externals/software/puri-20180228-git/src.lisp" 
:OUTPUT-FILE 
#P"/thrift/src/lib/cl/externals/software/puri-20180228-git/src.fasl" 
:EXTERNAL-FORMAT :UTF-8 :WARNINGS-FILE NIL)
9: (ASDF/LISP-ACTION:PERFORM-LISP-COMPILATION # 
#)
10: ((SB-PCL::EMF ASDF/ACTION:PERFORM) # # 
# #)
11: ((LAMBDA NIL :IN ASDF/ACTION:CALL-WHILE-VISITING-ACTION))
12: ((:METHOD ASDF/ACTION:PERFORM-WITH-RESTARTS :AROUND (T T)) 
# #) [fast-method]
13: ((:METHOD ASDF/PLAN:PERFORM-PLAN (T)) #) [fast-method]
14: ((FLET SB-C::WITH-IT :IN SB-C::%WITH-COMPILATION-UNIT))
15: ((:METHOD ASDF/PLAN:PERFORM-PLAN :AROUND (T)) #) [fast-method]
16: ((:METHOD ASDF/OPERATE:OPERATE (ASDF/OPERATION:OPERATION 
ASDF/COMPONENT:COMPONENT)) # # :PLAN-CLASS NIL :PLAN-OPTIONS NIL) [fast-method]
17: ((SB-PCL::EMF ASDF/OPERATE:OPERATE) # # 
# #)
18: ((LAMBDA NIL :IN ASDF/OPERATE:OPERATE))
19: ((:METHOD ASDF/OPERATE:OPERATE :AROUND (T T)) # 
#) [fast-method]
20: ((SB-PCL::EMF ASDF/OPERATE:OPERATE) # # 
ASDF/LISP-ACTION:LOAD-OP :THRIFT)
21: ((LAMBDA NIL :IN ASDF/OPERATE:OPERATE))
22: ((:METHOD ASDF/OPERATE:OPERATE :AROUND (T T)) ASDF/LISP-ACTION:LOAD-OP 
:THRIFT) [fast-method]
23: (ASDF/SESSION:CALL-WITH-ASDF-SESSION # :OVERRIDE T :KEY NIL :OVERRIDE-CACHE T 
:OVERRIDE-FORCING NIL)
24: ((LAMBDA NIL :IN ASDF/OPERATE:OPERATE))
25: (ASDF/SESSION:CALL-WITH-ASDF-SESSION # :OVERRIDE NIL :KEY NIL :OVERRIDE-CACHE NIL 
:OVERRIDE-FORCING NIL)
26: ((:METHOD ASDF/OPERATE:OPERATE :AROUND (T T)) ASDF/LISP-ACTION:LOAD-OP 
:THRIFT) [fast-method]
27: (ASDF/OPERATE:LOAD-SYSTEM :THRIFT)
28: (SB-INT:SIMPLE-EVAL-IN-LEXENV (ASDF/OPERATE:LOAD-SYSTEM :THRIFT) 
#)
29: (EVAL-TLF (ASDF/OPERATE:LOAD-SYSTEM :THRIFT) 4 NIL)
30: ((LABELS SB-FASL::EVAL-FORM :IN SB-INT:LOAD-AS-SOURCE) 
(ASDF/OPERATE:LOAD-SYSTEM :THRIFT) 4)
31: ((LAMBDA (SB-KERNEL:FORM  :CURRENT-INDEX ) :IN 
SB-INT:LOAD-AS-SOURCE) (ASDF/OPERATE:LOAD-SYSTEM :THRIFT) :CURRENT-INDEX 4)
32: (SB-C::%DO-FORMS-FROM-INFO # 
# SB-C::INPUT-ERROR-IN-LOAD)
33: (SB-INT:LOAD-AS-SOURCE # :VERBOSE NIL :PRINT NIL 
:CONTEXT "loading")
34: ((FLET SB-FASL::THUNK :IN LOAD))
35: (SB-FASL::CALL-WITH-LOAD-BINDINGS # #)
36: ((FLET SB-FASL::LOAD-STREAM :IN LOAD) # NIL)
37: (LOAD #P"/thrift/src/tutorial/cl/../../lib/cl/load-locally.lisp" :VERBOSE 
NIL :PRINT NIL :IF-DOES-NOT-EXIST T :EXTERNAL-FORMAT :DEFAULT)
38: (SB-INT:SIMPLE-EVAL-IN-LEXENV (LOAD (MERGE-PATHNAMES 
"../../lib/cl/load-locally.lisp" *LOAD-TRUENAME*)) #)
39: (EVAL-TLF (LOAD (MERGE-PATHNAMES "../../lib/cl/load-locally.lisp" 
*LOAD-TRUENAME*)) 3 NIL)
40: ((LABELS SB-FASL::EVAL-FORM :IN SB-INT:LOAD-AS-SOURCE) (LOAD 
(MERGE-PATHNAMES "../../lib/cl/load-locally.lisp" *LOAD-TRUENAME*)) 3)
41: ((LAMBDA (SB-KERNEL:FORM  :CURRENT-INDEX ) :IN 
SB-INT:LOAD-AS-SOURCE) (LOAD (MERGE-PATHNAMES "../../lib/cl/load-locally.lisp" 
*LOAD-TRUENAME*)) :CURRENT-INDEX 3)
42: (SB-C::%DO-FORMS-FROM-INFO # 
# SB-C::INPUT-ERROR-IN-LOAD)
43: (SB-INT:LOAD-AS-SOURCE # :VERBOSE NIL 
:PRINT NIL :CONTEXT "loading")
44: ((FLET SB-FASL::THUNK :IN LOAD))
45: (SB-FASL::CALL-WITH-LOAD-BINDINGS # #)
46: ((FLET SB-FASL::LOAD-STREAM :IN LOAD) # NIL)
47: (LOAD # :VERBOSE NIL 
:PRINT NIL :IF-DOES-NOT-EXIST T :EXTERNAL-FORMAT :DEFAULT)
48: ((FLET SB-IMPL::LOAD-SCRIPT :IN 

[jira] [Commented] (THRIFT-4676) CL tutorial build fails sporadically

2018-12-01 Thread Allen George (JIRA)


[ 
https://issues.apache.org/jira/browse/THRIFT-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705853#comment-16705853
 ] 

Allen George commented on THRIFT-4676:
--

It looks like turning off the compile cache worked. Now the CL build fails in a 
different place for a different reason (still while building 
{{TutorialClient}}):

{noformat}

; 
/thrift/src/lib/cl/externals/software/trivial-utf-8-20111001-darcs/trivial-utf-8-tmpQ371UGSU.fasl
 written
; compilation finished in 0:00:00.134


; 
/thrift/src/lib/cl/externals/software/trivial-utf-8-20111001-darcs/trivial-utf-8-tmpQ371UGST.fasl
 written
; compilation finished in 0:00:00.141
While evaluating the form starting at line 23, column 0
  of #P"/thrift/src/tutorial/cl/../../lib/cl/load-locally.lisp":
Unhandled SB-INT:SIMPLE-FILE-ERROR in thread #:
  Couldn't load
  
#P"/thrift/src/lib/cl/externals/software/trivial-utf-8-20111001-darcs/trivial-utf-8.fasl":
  file does not exist.

Backtrace for: #
0: (SB-DEBUG::DEBUGGER-DISABLED-HOOK #" {100280F123}> # :QUIT T)
1: (SB-DEBUG::RUN-HOOK *INVOKE-DEBUGGER-HOOK* #" {100280F123}>)
2: (INVOKE-DEBUGGER #" {100280F123}>)
3: (ERROR SB-INT:SIMPLE-FILE-ERROR :PATHNAME 
#P"/thrift/src/lib/cl/externals/software/trivial-utf-8-20111001-darcs/trivial-utf-8.fasl"
 :FORMAT-CONTROL "~@" 
:FORMAT-ARGUMENTS 
(#P"/thrift/src/lib/cl/externals/software/trivial-utf-8-20111001-darcs/trivial-utf-8.fasl"))
4: (LOAD 
#P"/thrift/src/lib/cl/externals/software/trivial-utf-8-20111001-darcs/trivial-utf-8.fasl"
 :VERBOSE NIL :PRINT NIL :IF-DOES-NOT-EXIST T :EXTERNAL-FORMAT :DEFAULT)
5: (UIOP/UTILITY:CALL-WITH-MUFFLED-CONDITIONS # ("Overwriting already existing readtable 
~S." #(#:FINALIZERS-OFF-WARNING :ASDF-FINALIZERS)))
6: ((SB-PCL::EMF ASDF/ACTION:PERFORM) # # 
# #)
7: ((LAMBDA NIL :IN ASDF/ACTION:CALL-WHILE-VISITING-ACTION))
8: ((:METHOD ASDF/ACTION:PERFORM-WITH-RESTARTS (ASDF/LISP-ACTION:LOAD-OP 
ASDF/LISP-ACTION:CL-SOURCE-FILE)) # 
#) 
[fast-method]
9: ((:METHOD ASDF/ACTION:PERFORM-WITH-RESTARTS :AROUND (T T)) 
# #) [fast-method]
10: ((:METHOD ASDF/PLAN:PERFORM-PLAN (T)) #) [fast-method]
11: ((FLET SB-C::WITH-IT :IN SB-C::%WITH-COMPILATION-UNIT))
12: ((:METHOD ASDF/PLAN:PERFORM-PLAN :AROUND (T)) #) [fast-method]
13: ((:METHOD ASDF/OPERATE:OPERATE (ASDF/OPERATION:OPERATION 
ASDF/COMPONENT:COMPONENT)) # # :PLAN-CLASS NIL :PLAN-OPTIONS NIL) [fast-method]
14: ((SB-PCL::EMF ASDF/OPERATE:OPERATE) # # 
# #)
15: ((LAMBDA NIL :IN ASDF/OPERATE:OPERATE))
16: ((:METHOD ASDF/OPERATE:OPERATE :AROUND (T T)) # 
#) [fast-method]
17: ((SB-PCL::EMF ASDF/OPERATE:OPERATE) # # 
ASDF/LISP-ACTION:LOAD-OP :THRIFT)
18: ((LAMBDA NIL :IN ASDF/OPERATE:OPERATE))
19: ((:METHOD ASDF/OPERATE:OPERATE :AROUND (T T)) ASDF/LISP-ACTION:LOAD-OP 
:THRIFT) [fast-method]
20: (ASDF/SESSION:CALL-WITH-ASDF-SESSION # :OVERRIDE T :KEY NIL :OVERRIDE-CACHE T 
:OVERRIDE-FORCING NIL)
21: ((LAMBDA NIL :IN ASDF/OPERATE:OPERATE))
22: (ASDF/SESSION:CALL-WITH-ASDF-SESSION # :OVERRIDE NIL :KEY NIL :OVERRIDE-CACHE NIL 
:OVERRIDE-FORCING NIL)
23: ((:METHOD ASDF/OPERATE:OPERATE :AROUND (T T)) ASDF/LISP-ACTION:LOAD-OP 
:THRIFT) [fast-method]
24: (ASDF/OPERATE:LOAD-SYSTEM :THRIFT)
25: (SB-INT:SIMPLE-EVAL-IN-LEXENV (ASDF/OPERATE:LOAD-SYSTEM :THRIFT) 
#)
26: (EVAL-TLF (ASDF/OPERATE:LOAD-SYSTEM :THRIFT) 4 NIL)
27: ((LABELS SB-FASL::EVAL-FORM :IN SB-INT:LOAD-AS-SOURCE) 
(ASDF/OPERATE:LOAD-SYSTEM :THRIFT) 4)
28: ((LAMBDA (SB-KERNEL:FORM  :CURRENT-INDEX ) :IN 
SB-INT:LOAD-AS-SOURCE) (ASDF/OPERATE:LOAD-SYSTEM :THRIFT) :CURRENT-INDEX 4)
29: (SB-C::%DO-FORMS-FROM-INFO # 
# SB-C::INPUT-ERROR-IN-LOAD)
30: (SB-INT:LOAD-AS-SOURCE # :VERBOSE NIL :PRINT NIL 
:CONTEXT "loading")
31: ((FLET SB-FASL::THUNK :IN LOAD))
32: (SB-FASL::CALL-WITH-LOAD-BINDINGS # #)
33: ((FLET SB-FASL::LOAD-STREAM :IN LOAD) # NIL)
34: (LOAD #P"/thrift/src/tutorial/cl/../../lib/cl/load-locally.lisp" :VERBOSE 
NIL :PRINT NIL :IF-DOES-NOT-EXIST T :EXTERNAL-FORMAT :DEFAULT)
35: (SB-INT:SIMPLE-EVAL-IN-LEXENV (LOAD (MERGE-PATHNAMES 
"../../lib/cl/load-locally.lisp" *LOAD-TRUENAME*)) #)
36: (EVAL-TLF (LOAD (MERGE-PATHNAMES "../../lib/cl/load-locally.lisp" 
*LOAD-TRUENAME*)) 3 NIL)
37: ((LABELS SB-FASL::EVAL-FORM :IN SB-INT:LOAD-AS-SOURCE) (LOAD 
(MERGE-PATHNAMES "../../lib/cl/load-locally.lisp" *LOAD-TRUENAME*)) 3)
38: ((LAMBDA (SB-KERNEL:FORM  :CURRENT-INDEX ) :IN 
SB-INT:LOAD-AS-SOURCE) (LOAD (MERGE-PATHNAMES "../../lib/cl/load-locally.lisp" 
*LOAD-TRUENAME*)) :CURRENT-INDEX 3)
39: (SB-C::%DO-FORMS-FROM-INFO # 
# SB-C::INPUT-ERROR-IN-LOAD)
40: (SB-INT:LOAD-AS-SOURCE # :VERBOSE NIL 
:PRINT NIL :CONTEXT "loading")
41: ((FLET SB-FASL::THUNK :IN LOAD))
42: (SB-FASL::CALL-WITH-LOAD-BINDINGS # #)
43: ((FLET SB-FASL::LOAD-STREAM :IN LOAD) # NIL)
44: (LOAD # :VERBOSE NIL 
:PRINT NIL :IF-DOES-NOT-EXIST T :EXTERNAL-FORMAT :DEFAULT)
45: ((FLET SB-IMPL::LOAD-SCRIPT :IN SB-IMPL::PROCESS-SCRIPT) #)
46: ((FLET SB-UNIX::BODY :IN SB-IMPL::PROCESS-SCRIPT))
47: ((FLET 

[jira] [Commented] (THRIFT-4676) CL tutorial build fails sporadically

2018-12-01 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/THRIFT-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705827#comment-16705827
 ] 

ASF GitHub Bot commented on THRIFT-4676:


allengeorge edited a comment on issue #1639: THRIFT-4676: Disable ASDF compiler 
cache for CL tutorial server/client
URL: https://github.com/apache/thrift/pull/1639#issuecomment-443426550
 
 
   Going to force push a couple of times to kick off the builds and see if the 
SBCL error pops up. If it doesn't I can tentatively claim victory. The first 
run was successful, so...let's hope.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CL tutorial build fails sporadically
> 
>
> Key: THRIFT-4676
> URL: https://issues.apache.org/jira/browse/THRIFT-4676
> Project: Thrift
>  Issue Type: Task
>  Components: Build Process
>Reporter: Allen George
>Assignee: Allen George
>Priority: Minor
>
> Many of the CI failures are caused by the CL tutorial build failing. This 
> isn't because the CL code is wrong, it's simply because of a race condition 
> _somewhere_.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (THRIFT-4676) CL tutorial build fails sporadically

2018-12-01 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/THRIFT-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705826#comment-16705826
 ] 

ASF GitHub Bot commented on THRIFT-4676:


allengeorge commented on issue #1639: THRIFT-4676: Disable ASDF compiler cache 
for CL tutorial server/client
URL: https://github.com/apache/thrift/pull/1639#issuecomment-443426550
 
 
   Going to force push a couple of times to kick off the builds and see if the 
SBCL error pops up. If it doesn't I can tentatively claim victory.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CL tutorial build fails sporadically
> 
>
> Key: THRIFT-4676
> URL: https://issues.apache.org/jira/browse/THRIFT-4676
> Project: Thrift
>  Issue Type: Task
>  Components: Build Process
>Reporter: Allen George
>Assignee: Allen George
>Priority: Minor
>
> Many of the CI failures are caused by the CL tutorial build failing. This 
> isn't because the CL code is wrong, it's simply because of a race condition 
> _somewhere_.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)