[jira] [Commented] (THRIFT-4659) golang race detected when closing listener socket
[ https://issues.apache.org/jira/browse/THRIFT-4659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715706#comment-16715706 ] ASF GitHub Bot commented on THRIFT-4659: jgheewala opened a new pull request #1645: THRIFT-4659 golang race detected when closing listener socket URL: https://github.com/apache/thrift/pull/1645 Some helpful tips for a successful Apache Thrift PR: * Did you test your changes locally or using CI in your fork? Tested changes locally * Is the Apache Jira THRIFT ticket identifier in the PR title? Yes * Is the Apache Jira THRIFT ticket identifier in the commit message? Yes * Did you squash your changes to a single commit? Yes * Are these changes backwards compatible? (please say so in PR description) * Do you need to update the language-specific README? Client: [go] This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > golang race detected when closing listener socket > - > > Key: THRIFT-4659 > URL: https://issues.apache.org/jira/browse/THRIFT-4659 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Affects Versions: 0.11.0 >Reporter: Jay Gheewala >Assignee: Can Celasun >Priority: Major > Attachments: THRIFT-4659.diff > > > Race condition is deteced for following write/read > > git.apache.org/thrift.git/lib/go/thrift/server_socket.go:119 > git.apache.org/thrift.git/lib/go/thrift.(*TServerSocket).Close() > git.apache.org/thrift.git/lib/go/thrift/server_socket.go:122 > git.apache.org/thrift.git/lib/go/thrift.(*TServerSocket).Interrupt() > > git.apache.org/thrift.git/lib/go/thrift.(*TServerSocket).Accept() > git.apache.org/thrift.git/lib/go/thrift/server_socket.go:78 > git.apache.org/thrift.git/lib/go/thrift.(*TSimpleServer).innerAccept() > git.apache.org/thrift.git/lib/go/thrift/simple_server.go:129 > git.apache.org/thrift.git/lib/go/thrift.(*TSimpleServer).AcceptLoop() -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4679) Duplicate declaration of InputBufferUnderrunError in lib/nodejs/lib/thrift/json_protocol.js
[ https://issues.apache.org/jira/browse/THRIFT-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715016#comment-16715016 ] ASF GitHub Bot commented on THRIFT-4679: jeking3 commented on issue #1642: THRIFT-4679: Remove unused variable declaration URL: https://github.com/apache/thrift/pull/1642#issuecomment-445875450 When we complete the 0.12.0 release then we start pushing out to package managers. It's kind of ad-hoc for the project however. It looks like @jfarrell maintains the npmjs updates. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Duplicate declaration of InputBufferUnderrunError in > lib/nodejs/lib/thrift/json_protocol.js > --- > > Key: THRIFT-4679 > URL: https://issues.apache.org/jira/browse/THRIFT-4679 > Project: Thrift > Issue Type: Bug > Components: JavaScript - Library >Affects Versions: 0.11.0 >Reporter: Griffin Michl >Assignee: James E. King III >Priority: Minor > Labels: easyfix > Fix For: 1.0 > > Original Estimate: 10m > Remaining Estimate: 10m > > InputBufferUnderrunError is unnecessarily declared twice in > `lib/nodejs/lib/thrift/json_protocol.js`. This causes certain compilers to > break when they attempt to compile code that uses the node thrift library. We > should remove the first declaration, as it does not do anything. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4679) Duplicate declaration of InputBufferUnderrunError in lib/nodejs/lib/thrift/json_protocol.js
[ https://issues.apache.org/jira/browse/THRIFT-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715038#comment-16715038 ] ASF GitHub Bot commented on THRIFT-4679: griffinmichl commented on issue #1642: THRIFT-4679: Remove unused variable declaration URL: https://github.com/apache/thrift/pull/1642#issuecomment-445881713 Sounds good. I think my company also has some fixes to the browser serializer they want to get in (we use our own right now). I'll try to get that moving along so we can get it into that release as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Duplicate declaration of InputBufferUnderrunError in > lib/nodejs/lib/thrift/json_protocol.js > --- > > Key: THRIFT-4679 > URL: https://issues.apache.org/jira/browse/THRIFT-4679 > Project: Thrift > Issue Type: Bug > Components: JavaScript - Library >Affects Versions: 0.11.0 >Reporter: Griffin Michl >Assignee: James E. King III >Priority: Minor > Labels: easyfix > Fix For: 1.0 > > Original Estimate: 10m > Remaining Estimate: 10m > > InputBufferUnderrunError is unnecessarily declared twice in > `lib/nodejs/lib/thrift/json_protocol.js`. This causes certain compilers to > break when they attempt to compile code that uses the node thrift library. We > should remove the first declaration, as it does not do anything. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4679) Duplicate declaration of InputBufferUnderrunError in lib/nodejs/lib/thrift/json_protocol.js
[ https://issues.apache.org/jira/browse/THRIFT-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715002#comment-16715002 ] ASF GitHub Bot commented on THRIFT-4679: griffinmichl commented on issue #1642: THRIFT-4679: Remove unused variable declaration URL: https://github.com/apache/thrift/pull/1642#issuecomment-445871911 Any idea how I can get this merged into the thrift npm package? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Duplicate declaration of InputBufferUnderrunError in > lib/nodejs/lib/thrift/json_protocol.js > --- > > Key: THRIFT-4679 > URL: https://issues.apache.org/jira/browse/THRIFT-4679 > Project: Thrift > Issue Type: Bug > Components: JavaScript - Library >Affects Versions: 0.11.0 >Reporter: Griffin Michl >Assignee: James E. King III >Priority: Minor > Labels: easyfix > Fix For: 1.0 > > Original Estimate: 10m > Remaining Estimate: 10m > > InputBufferUnderrunError is unnecessarily declared twice in > `lib/nodejs/lib/thrift/json_protocol.js`. This causes certain compilers to > break when they attempt to compile code that uses the node thrift library. We > should remove the first declaration, as it does not do anything. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
