[jira] [Resolved] (THRIFT-5781) implement full deprecation support
[ https://issues.apache.org/jira/browse/THRIFT-5781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5781. Fix Version/s: 0.21.0 Resolution: Fixed > implement full deprecation support > -- > > Key: THRIFT-5781 > URL: https://issues.apache.org/jira/browse/THRIFT-5781 > Project: Thrift > Issue Type: Improvement > Components: netstd - Compiler >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Minor > Fix For: 0.21.0 > > Attachments: deprecated.thrift > > Time Spent: 20m > Remaining Estimate: 0h > > Currently netstd only checks service methods for deprecation markers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] THRIFT-5781 implement full deprecation support [thrift]
Jens-G merged PR #2966: URL: https://github.com/apache/thrift/pull/2966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] THRIFT-5781 implement full deprecation support [thrift]
Jens-G opened a new pull request, #2966: URL: https://github.com/apache/thrift/pull/2966 Client: netstd Patch: Jens Geyer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (THRIFT-5781) implement full deprecation support
[ https://issues.apache.org/jira/browse/THRIFT-5781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5781: --- Attachment: deprecated.thrift > implement full deprecation support > -- > > Key: THRIFT-5781 > URL: https://issues.apache.org/jira/browse/THRIFT-5781 > Project: Thrift > Issue Type: Improvement > Components: netstd - Compiler >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Minor > Attachments: deprecated.thrift > > > Currently netstd only checks service methods for deprecation markers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (THRIFT-5781) implement full deprecation support
Jens Geyer created THRIFT-5781: -- Summary: implement full deprecation support Key: THRIFT-5781 URL: https://issues.apache.org/jira/browse/THRIFT-5781 Project: Thrift Issue Type: Improvement Components: netstd - Compiler Reporter: Jens Geyer Assignee: Jens Geyer Currently netstd only checks service methods for deprecation markers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (THRIFT-640) Support deprecation
[ https://issues.apache.org/jira/browse/THRIFT-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840810#comment-17840810 ] Jens Geyer commented on THRIFT-640: --- [Example of how it works can be found in optional_required_default.thrift|https://github.com/apache/thrift/blob/master/lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/optional_required_default.thrift] > Support deprecation > --- > > Key: THRIFT-640 > URL: https://issues.apache.org/jira/browse/THRIFT-640 > Project: Thrift > Issue Type: New Feature > Components: Java - Compiler >Reporter: Nathan Marz >Assignee: Daniel Wolf >Priority: Minor > Fix For: 0.10.0 > > Attachments: thrift-640-java-deprecation.patch > > > Sometimes we do schema migrations and it would be cool to be able to have > deprecation functionality from Thrift. At the most basic level, we should be > able to annotate a field as deprecated and have the compiler generate > "@Deprecated" annotations in the Java code. > Sometimes though, you may want creators of structs to be forced to use new > fields, but you still want to be able to read the old fields until you have > everything migrated over. In this case you could mark a field as > "strong-deprecated" and just not generate any setters for those fields (only > getters). This would force all users of the struct to migrate to new schema, > since the code won't compile otherwise. -- This message was sent by Atlassian Jira (v8.20.10#820010)
