[jira] [Commented] (THRIFT-1353) Switch to performance branch, get rid of BinaryParser
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485056#comment-13485056 ] John Eckhart commented on THRIFT-1353: -- Looks good now, thanks! > Switch to performance branch, get rid of BinaryParser > - > > Key: THRIFT-1353 > URL: https://issues.apache.org/jira/browse/THRIFT-1353 > Project: Thrift > Issue Type: Improvement > Components: Node.js - Library >Affects Versions: 0.7 >Reporter: Hans Duedal >Assignee: Henrique Mendonca > Labels: node, nodejs > Fix For: 1.0 > > Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch > > > I vote that the thrift library switches to the performance branch at > https://github.com/wadey/node-thrift/tree/performance > I much prefer using the node.js buffers over the BinaryParser class, the > performance branch seems focused on this very issue. Also it includes the > excellent int64 implementation from broofa. What's not to like? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get rid of BinaryParser
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484550#comment-13484550 ] John Eckhart commented on THRIFT-1353: -- I appreciate that you can't copy that file without following your process; however, I am pointing out that your most recent merge missed a file and therefore broke the node client. The missing file is also in the patch that the original author attached to the ticket after following the contribution process. > Switch to performance branch, get rid of BinaryParser > - > > Key: THRIFT-1353 > URL: https://issues.apache.org/jira/browse/THRIFT-1353 > Project: Thrift > Issue Type: Improvement > Components: Node.js - Library >Affects Versions: 0.7 >Reporter: Hans Duedal >Assignee: Henrique Mendonca > Labels: node, nodejs > Fix For: 1.0 > > Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch > > > I vote that the thrift library switches to the performance branch at > https://github.com/wadey/node-thrift/tree/performance > I much prefer using the node.js buffers over the BinaryParser class, the > performance branch seems focused on this very issue. Also it includes the > excellent int64 implementation from broofa. What's not to like? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1353) Switch to performance branch, get rid of BinaryParser
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484508#comment-13484508 ] John Eckhart commented on THRIFT-1353: -- Looks like you missed a file (binary.js) which is not the same as binary_parser.js that is in the release branch. Here's a link to the original file: https://raw.github.com/wadey/node-thrift/performance/lib/thrift/binary.js > Switch to performance branch, get rid of BinaryParser > - > > Key: THRIFT-1353 > URL: https://issues.apache.org/jira/browse/THRIFT-1353 > Project: Thrift > Issue Type: Improvement > Components: Node.js - Library >Affects Versions: 0.7 >Reporter: Hans Duedal >Assignee: Henrique Mendonca > Labels: node, nodejs > Fix For: 1.0 > > Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch > > > I vote that the thrift library switches to the performance branch at > https://github.com/wadey/node-thrift/tree/performance > I much prefer using the node.js buffers over the BinaryParser class, the > performance branch seems focused on this very issue. Also it includes the > excellent int64 implementation from broofa. What's not to like? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
