[GitHub] thrift issue #1516: THRIFT-4527 Upgrade byteorder in rust

2018-03-22 Thread QuestofIranon
Github user QuestofIranon commented on the issue:

https://github.com/apache/thrift/pull/1516
  
@allengeorge It creates dependency conflicts with other libraries that rely 
on the updated version of byteorder. For example, I couldn't build a project 
using Thrift because my other dependencies all used 1.2.1.

``
2:02 PMCargo project update failed:
Cargo execution failed (exit code 101).
/Users//.cargo/bin/cargo metadata --verbose 
--format-version 1 --all-features
stdout : Updating git repository 
`https://github.com/apache/thrift.git`
Updating registry 
`https://github.com/rust-lang/crates.io-index`
error: failed to select a version for `byteorder` (required 
by `thrift`):
all possible versions conflict with previously selected 
versions of `byteorder`
  version 1.2.1 in use by byteorder v1.2.1
  possible versions to select: 1.1.0



---


[GitHub] thrift pull request #1516: THRIFT-4527 Upgrade byteorder in rust

2018-03-21 Thread QuestofIranon
GitHub user QuestofIranon opened a pull request:

https://github.com/apache/thrift/pull/1516

THRIFT-4527 Upgrade byteorder in rust

updated byteorder 1.1.0 -> 1.2.1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/QuestofIranon/thrift master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1516.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1516


commit a0116e5cb37e8e804b2d9758950f58d6c8776054
Author: Josh 
Date:   2018-03-21T21:34:44Z

THRIFT-4527 bump byteorder version




---