[GitHub] thrift issue #1479: THRIFT-4474: generate PHP code use PSR-4 style default
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1479 @dcelasun squashed ---
[GitHub] thrift pull request #1479: THRIFT-4474: generate PHP code use PSR-4 style de...
Github user RobberPhex commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1479#discussion_r174337789
--- Diff: lib/php/README.md ---
@@ -20,34 +19,46 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-Using Thrift with PHP
-=
+# Using Thrift with PHP
Thrift requires PHP 5. Thrift makes as few assumptions about your PHP
environment as possible while trying to make some more advanced PHP
features (i.e. APC cacheing using asbolute path URLs) as simple as
possible.
To use Thrift in your PHP codebase, take the following steps:
-#1) Copy all of thrift/lib/php/lib into your PHP codebase
-#2) Configure Symfony Autoloader (or whatever you usually use)
+1. Copy all of thrift/lib/php/lib into your PHP codebase
+2. Configure Symfony Autoloader (or whatever you usually use)
After that, you have to manually include the Thrift package
created by the compiler:
+```
require_once 'packages/Service/Service.php';
require_once 'packages/Service/Types.php';
+```
-Dependencies
-
+# Dependencies
PHP_INT_SIZE
- This built-in signals whether your architecture is 32 or 64 bit and is
- used by the TBinaryProtocol to properly use pack() and unpack() to
- serialize data.
+This built-in signals whether your architecture is 32 or 64 bit and is
+used by the TBinaryProtocol to properly use pack() and unpack() to
+serialize data.
apc_fetch(), apc_store()
- APC cache is used by the TSocketPool class. If you do not have APC
installed,
- Thrift will fill in null stub function definitions.
+APC cache is used by the TSocketPool class. If you do not have APC
installed,
+Thrift will fill in null stub function definitions.
+
+# Breaking Changes
+
+## 0.12.0
+
+1. For thrift compiler, `psr4` flag is opened default, generated code
match psr4 code struct.
+
+If you want old-style directory struct, use `classmap` option. (i.e.
`-gen php:classmap`)
+
+2. For ThriftClassloader, if use psr4 code struct, must use
`$thriftClassLoader->registerNamespace('namespace', '')` to register
autoload.
--- End diff --
Thank you! It's better phrasing.
---
Fixed by amend comment.
---
[GitHub] thrift pull request #1498: THRIFT-4498: add phpcs back
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1498 THRIFT-4498: add phpcs back ref <https://issues.apache.org/jira/browse/THRIFT-4498> You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift phpcs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1498.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1498 commit 5e60bbbcaba9d4c1ef47fcb99ea8b1ef0bde8fc4 Author: Robert Lu <robberphex@...> Date: 2018-02-22T03:06:07Z add phpcs back ---
[GitHub] thrift issue #1479: THRIFT-4474: generate PHP code use PSR-4 style default
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1479 Personally, I think we can mark classmap/old-style PHP compiler deprecated. And can be removed in future. And, ThriftClassLoader can also be removed in future, to migrate composer autoloader. ---
[GitHub] thrift issue #1479: THRIFT-4474: generate PHP code use PSR-4 style default
Github user RobberPhex commented on the issue:
https://github.com/apache/thrift/pull/1479
There are some break changes:
1. for generated code, old struct is `Types.php` for all args, results,
`.php` for `ServiceIf`, `ServiceClient`, etc.
new struct is `.php` for ``. Maybe cause some code
analyzer doesn't work.
2. for ThriftClassloader. before, user use
`$loader->registerDefinition('namespace', '')`.
At new struct, **it doesn't work**. user can use
`$composerLoader->addPsr4('namespace', '')` or
`$thriftLoader->registerNamespace('namespace', '')`.
3. for composer loader, generated code loaded via classmap. With new
struct, composer's classmap can also load psr-4 code. (of cause psr-4 is
recommended).
---
[GitHub] thrift issue #1484: TBufferedTransport must have underlying transport
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1484 CI isn't stable. It's so headache. :( ---
[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport
Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164633942 --- Diff: lib/php/lib/Transport/TTransport.php --- @@ -22,6 +22,7 @@ namespace Thrift\Transport; +use Thrift\Exception\TTransportException; --- End diff -- There is doc comment `@throws TTransportException` at Line 45. No one (and IDE) knows which TTransportException. ---
[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport
Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164633860 --- Diff: lib/php/lib/Transport/TBufferedTransport.php --- @@ -22,6 +22,7 @@ namespace Thrift\Transport; +use Thrift\Exception\TTransportException; --- End diff -- some function has doc comment `@throws TTransportException`, No one (and IDE) knows which TTransportException, so I think we should add use stmt. Or, We always use full classname at doc comment, is it? ---
[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport
Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164633628 --- Diff: lib/php/lib/Factory/TStringFuncFactory.php --- @@ -21,8 +21,9 @@ namespace Thrift\Factory; -use Thrift\StringFunc\Mbstring; use Thrift\StringFunc\Core; +use Thrift\StringFunc\Mbstring; --- End diff -- I sorted use alphabetically, is it unnecessary? Am I expected that change it back? ---
[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport
Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164633402 --- Diff: lib/php/lib/Transport/TBufferedTransport.php --- @@ -78,11 +69,26 @@ public function __construct($transport = null, $rBufSize = 512, $wBufSize = 512) */ protected $rBuf_ = ''; +/** + * Constructor. Creates a buffered transport around an underlying transport + */ +public function __construct($transport, $rBufSize = 512, $wBufSize = 512) --- End diff -- Firstly, remove `=null` at class filed. And, `$transport=null` should also be removed at function `__construct`. Sometimes, called `new TBufferedTransport()` will cause $transport_ is null, which cause other funcion doesn't work(`open`, `read`, etc.) ---
[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1484 TBufferedTransport must have underlying transport ref: https://issues.apache.org/jira/browse/THRIFT-4477 You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift fix-TBufferedTransport Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1484.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1484 commit 3c72a16259b64c2fd38f160b67575b3b932c5e62 Author: Robert Lu <robberphex@...> Date: 2018-01-29T14:49:12Z TBufferedTransport must have underlying transport * add some type hinting ---
[GitHub] thrift pull request #1482: THRIFT-4475: check lib/php/test for PSR-2
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1482 THRIFT-4475: check lib/php/test for PSR-2 ref: https://issues.apache.org/jira/browse/THRIFT-4475 You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift psr-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1482.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1482 commit 8ffd8855c15ab8e04e1ad786d6062f837acdff2b Author: Robert Lu <robberphex@...> Date: 2018-01-25T15:19:41Z check lib/php/test ---
[GitHub] thrift pull request #1481: THRIFT-4475: check lib/php/test for PSR-2
Github user RobberPhex closed the pull request at: https://github.com/apache/thrift/pull/1481 ---
[GitHub] thrift pull request #1481: THRIFT-4475: check lib/php/test for PSR-2
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1481 THRIFT-4475: check lib/php/test for PSR-2 ref: https://issues.apache.org/jira/browse/THRIFT-4475 You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift psr-4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1481.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1481 commit df87634ba9fe1834616c918398dfea9fe8123b1b Author: Robert Lu <robberphex@...> Date: 2018-01-25T15:19:41Z check lib/php/test ---
[GitHub] thrift pull request #1479: THRIFT-4474: generate PHP code use PSR-4 style de...
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1479 THRIFT-4474: generate PHP code use PSR-4 style default ref: https://issues.apache.org/jira/browse/THRIFT-4474 You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift default-psr4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1479.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1479 commit a083deebd3977f68bf5fdfe1d2e88ea240f8183a Author: Robert Lu <robberphex@...> Date: 2018-01-17T11:40:39Z generate PHP code use PSR-4 style default ---
[GitHub] thrift issue #1451: THRIFT-4438: delete trusty and requrie php56
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1451 Considering that trusty haven't reached end of life, so I close this pr, and keep trusty in CI. ---
[GitHub] thrift pull request #1451: THRIFT-4438: delete trusty and requrie php56
Github user RobberPhex closed the pull request at: https://github.com/apache/thrift/pull/1451 ---
[GitHub] thrift pull request #1472: THRIFT-4460: PHP Library use PSR-2
Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1472#discussion_r163079208 --- Diff: build/docker/scripts/sca.sh --- @@ -49,6 +49,10 @@ flake8 --ignore=E501 test/test.py flake8 --ignore=E501,E722 test/crossrunner flake8 test/features +# PHP code style +composer install --quiet +./vendor/bin/phpcs --- End diff -- @jeking3 `phpcs` will check which PHP library match PSR-2.(like `flake8`) ---
[GitHub] thrift pull request #1473: generate PHP code match psr2
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1473 generate PHP code match psr2 ref: https://issues.apache.org/jira/browse/THRIFT-4463 You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift gen-psr2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1473.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1473 commit 6db7f11ee0c55f3aeb770926dbc988bc926f9cf6 Author: Robert Lu <robberphex@...> Date: 2018-01-17T12:35:35Z PHP ident with 4 space commit f3fda49e45790f5cfb2173aafb9bec9abbdb7275 Author: Robert Lu <robberphex@...> Date: 2018-01-17T12:51:56Z fix Processor to psr4 commit 3784a5ee0279bd5b21c4bd9b7f58597dcd06905b Author: Robert Lu <robberphex@...> Date: 2018-01-17T13:15:21Z fix client to psr4 commit a32fe66406bcfcfe81dba2eba69e4f737554a16a Author: Robert Lu <robberphex@...> Date: 2018-01-17T14:27:32Z match psr2 commit 3b518eb85126a9ff75ad1e42735be0cf5d7ad0d8 Author: Robert Lu <robberphex@...> Date: 2018-01-18T01:25:50Z fix classmap mode ---
[GitHub] thrift issue #1472: THRIFT-4460: PHP Library use PSR-2
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1472 rebased and squashed ---
[GitHub] thrift pull request #1472: THRIFT-4460: PHP Library use PSR-2
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1472 THRIFT-4460: PHP Library use PSR-2 ref https://issues.apache.org/jira/browse/THRIFT-4460 You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift psr-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1472.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1472 commit ee05eef38042bb462294055c084a382f0b93328b Author: Robert Lu <robberphex@...> Date: 2017-11-03T04:27:31Z reduce php library directory depth commit cebbf0468c33080c3de6cc3b34772d1fe9a59886 Author: Robert Lu <robberphex@...> Date: 2018-01-15T11:03:13Z 5.5.9 commit 63cf9186ecc8e7f97130ebcbabb0c61080722bce Author: Robert Lu <robberphex@...> Date: 2017-11-11T01:08:25Z add php_codesniffer * ignore composer.lock and vendor commit feea9044270124ec88f1cf92dfad90de553ac8a1 Author: Robert Lu <robberphex@...> Date: 2018-01-15T12:31:14Z add php to sca commit fc6e42109b7910e42e86b40def0158c707911ddd Author: Robert Lu <robberphex@...> Date: 2018-01-15T12:31:44Z psr2 format commit 21aeabb8088db59cb4bf8dcc30499335040fb911 Author: Robert Lu <robberphex@...> Date: 2018-01-16T05:32:35Z add coding_standards.md ---
[GitHub] thrift pull request #1464: THRIFT-4452: optimize Dockerfile
Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1464#discussion_r161216512 --- Diff: build/docker/ubuntu-artful/Dockerfile --- @@ -41,10 +43,21 @@ RUN apt-get update && \ # dotnet (core) RUN curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > /etc/apt/trusted.gpg.d/microsoft.gpg && \ -echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > /etc/apt/sources.list.d/dotnetdev.list +echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main" > \ +/etc/apt/sources.list.d/dotnetdev.list -# node.js (this step runs apt-get update internally) - if we ever want a later version -RUN curl -sL https://deb.nodesource.com/setup_8.x | bash - +# node.js +RUN curl -sL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | sudo apt-key add - \ +echo "deb https://deb.nodesource.com/node_8.x artful main" | sudo tee /etc/apt/sources.list.d/nodesource.list +# D +RUN apt-key adv --keyserver keyserver.ubuntu.com --recv-keys EBCF975E5BA24D5E && \ +wget http://master.dl.sourceforge.net/project/d-apt/files/d-apt.list -O /etc/apt/sources.list.d/d-apt.list && \ +wget -qO - https://dlang.org/d-keyring.gpg | apt-key add - + +# Dart +RUN curl https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add - && \ +curl https://storage.googleapis.com/download.dartlang.org/linux/debian/dart_stable.list > \ +/etc/apt/sources.list.d/dart_stable.list --- End diff -- `apt-get install nodejs` run at line 137 ---
[GitHub] thrift pull request #1464: THRIFT-4452: optimize Dockerfile
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1464 THRIFT-4452: optimize Dockerfile Docker build flow: 1. add all repo 2. `apt-get update` (only one time) 3. install dependencies You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift dockerfile Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1464.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1464 commit a15a2d9bc2e952d984d20a08b7750eac24a3fa09 Author: Robert Lu <robberphex@...> Date: 2018-01-05T05:44:38Z optimize Dockerfile ---
[jira] [Commented] (THRIFT-3983) libthrift is deployed on central with pom packaging instead of jar
[ https://issues.apache.org/jira/browse/THRIFT-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311420#comment-16311420 ] RobberPhex commented on THRIFT-3983: This issue can be closed. > libthrift is deployed on central with pom packaging instead of jar > -- > > Key: THRIFT-3983 > URL: https://issues.apache.org/jira/browse/THRIFT-3983 > Project: Thrift > Issue Type: Bug > Components: Java - Library >Affects Versions: 0.9.3 >Reporter: Stéphane Landelle >Priority: Blocker > > Hi, > libthrift is deployed with a "pom" packaging on maven central, see > https://repo1.maven.org/maven2/org/apache/thrift/libthrift/0.9.3/libthrift-0.9.3.pom > org.apache.thrift > libthrift > 0.9.3 > pom > Apache Thrift > This is very wrong. "pom" means "no jar, just a list of dependencies to be > pulled transitively". > As a consequence, some build tools, such as sbt, don't pull the libthrift jar > itself. > The pom should be be using a "jar" packaging, or even no packaging at all as > "jar" is the default value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (THRIFT-4442) release 0.11.0 to https://bintray.com/apache/thrift
RobberPhex created THRIFT-4442: -- Summary: release 0.11.0 to https://bintray.com/apache/thrift Key: THRIFT-4442 URL: https://issues.apache.org/jira/browse/THRIFT-4442 Project: Thrift Issue Type: Bug Components: Compiler (General) Affects Versions: 0.11.0 Reporter: RobberPhex Priority: Critical [https://www.apache.org/dist/thrift/debian/] redirects to [http://dl.bintray.com/apache/thrift/debian/], and [https://www.apache.org/dist/thrift/rpm/] redirects to [http://dl.bintray.com/apache/thrift/rpm/]. Actually, they are generated by [https://bintray.com/apache/thrift/repo]. But there is only 0.9.3 version. Cloud you put 0.11.0 version to [https://bintray.com/apache/thrift/repo] ? It will be convenient for ubuntu trusty users and centos 7 users (and centos 6.9 users, if centos6 supported) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (THRIFT-4425) Publish Thrift v0.11 to packagist.org
[ https://issues.apache.org/jira/browse/THRIFT-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311135#comment-16311135 ] RobberPhex commented on THRIFT-4425: 0.11.0 is appeared at https://packagist.org/packages/apache/thrift so we can close this. > Publish Thrift v0.11 to packagist.org > - > > Key: THRIFT-4425 > URL: https://issues.apache.org/jira/browse/THRIFT-4425 > Project: Thrift > Issue Type: Task > Components: PHP - Library >Reporter: Robert Lu >Assignee: Jake Farrell > Fix For: 0.11.0 > > > Please release 0.11.0 to [https://packagist.org/packages/apache/thrift] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1456: THRIFT-3983: Fix generated maven packaging
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1456 THRIFT-3983: Fix generated maven packaging ref <https://issues.apache.org/jira/projects/THRIFT/issues/THRIFT-3983> --- * The origin PR is <https://github.com/apache/thrift/pull/1430>, so this close #1430 * This PR depends on [THRIFT-4439](https://issues.apache.org/jira/browse/THRIFT-4439), to pass CI. You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1456.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1456 commit 04a82de2e328d026563fa725fa1ffb3a850cf91f Author: Robert Lu <robberphex@...> Date: 2017-12-28T20:14:38Z use dartlang repo commit e40c23539543ba353bc0368e7b3c5c25b1bf9846 Author: Stephane Landelle <slandelle@...> Date: 2017-11-30T23:08:56Z Fix generated maven packaging pom packaging is for empty modules. What you're deploying on maven central is a jar artifact. Your current invalid pom.xml causes build tools such as sbt to not be able to download your library! ---
[jira] [Commented] (THRIFT-4439) Shouldn't download dart.deb directly.
[ https://issues.apache.org/jira/browse/THRIFT-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309039#comment-16309039 ] RobberPhex commented on THRIFT-4439: [~jking3] Just retrigger ci, it's success at [apache repo|https://travis-ci.org/apache/thrift/builds/324407532] and [personal repo|https://travis-ci.org/RobberPhex/thrift/builds/324407500]. > Shouldn't download dart.deb directly. > - > > Key: THRIFT-4439 > URL: https://issues.apache.org/jira/browse/THRIFT-4439 > Project: Thrift > Issue Type: Bug > Components: Dart - Library >Affects Versions: 0.11.0 > Environment: travis-ci >Reporter: RobberPhex >Assignee: James E. King, III > > https://storage.googleapis.com/dart-archive/channels/stable/release/latest/linux_packages/dart_1.24.2-1_amd64.deb > is 404, > So, as https://www.dartlang.org/install/linux suggested, use source list. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (THRIFT-4440) rm `build/docker/ubuntu-trusty/Dockerfile.orig`
RobberPhex created THRIFT-4440: -- Summary: rm `build/docker/ubuntu-trusty/Dockerfile.orig` Key: THRIFT-4440 URL: https://issues.apache.org/jira/browse/THRIFT-4440 Project: Thrift Issue Type: Improvement Components: Build Process Affects Versions: 0.11.0 Reporter: RobberPhex Priority: Minor It seems like `build/docker/ubuntu-trusty/Dockerfile.orig` is useless. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1455: THRIFT-4440: cleanup *.orig
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1455 THRIFT-4440: cleanup *.orig It seems like `build/docker/ubuntu-trusty/Dockerfile.orig` is useless. You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift cleanup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1455.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1455 commit 18d422b2905f94352600bb765a388da0a3dc7a39 Author: Robert Lu <robberphex@...> Date: 2018-01-03T00:40:17Z cleanup *.orig ---
[jira] [Commented] (THRIFT-4361) cannot serialize set<map<i32, i64> > via extension
[ https://issues.apache.org/jira/browse/THRIFT-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307148#comment-16307148 ] RobberPhex commented on THRIFT-4361: This is fixed in version 0.11.0, Please close this. > cannot serialize set<map<i32, i64> > via extension > -- > > Key: THRIFT-4361 > URL: https://issues.apache.org/jira/browse/THRIFT-4361 > Project: Thrift > Issue Type: Bug > Components: PHP - Library >Affects Versions: 0.10.0 > Environment: macOS 10.13 > PHP 7.0.23 >Reporter: Robert Lu >Assignee: Robert Lu > > method is: > bool echoF(1: set<map<i32, i64> > arg) > but, when arg is [[1=>3,5=>7],[11=>13]] and serialize via extension, > it cause Segmentation fault: 11 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1453: THRIFT-4439: use dartlang repo instead of downloa...
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1453 THRIFT-4439: use dartlang repo instead of download dart.deb You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift dartlang Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1453.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1453 commit 154186cf93e70f9a50c7cebd7da71fc100b59e8e Author: Robert Lu <robberphex@...> Date: 2017-12-28T20:14:38Z use dartlang repo ---
[jira] [Created] (THRIFT-4439) Shouldn't download dart.deb directly.
RobberPhex created THRIFT-4439: -- Summary: Shouldn't download dart.deb directly. Key: THRIFT-4439 URL: https://issues.apache.org/jira/browse/THRIFT-4439 Project: Thrift Issue Type: Bug Components: Dart - Library Affects Versions: 0.11.0 Environment: travis-ci Reporter: RobberPhex https://storage.googleapis.com/dart-archive/channels/stable/release/latest/linux_packages/dart_1.24.2-1_amd64.deb is 404, So, as https://www.dartlang.org/install/linux suggested, use source list. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1451: THRIFT-4438: delete trusty and requrie php56
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1451 THRIFT-4438: delete trusty and requrie php56 * remove support php 5.3, 5.4 and 5.5 * remove test at ubuntu trusty(trusty only have php5.5, haven't php5.6) You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift php56 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1451.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1451 commit b960a1e447457d2eba98dad75e4ebf023b5504de Author: Robert Lu <robberphex@...> Date: 2017-12-28T10:07:08Z delete trusty and requrie php56 ---
[jira] [Commented] (THRIFT-4423) migrate php library to psr-4
[ https://issues.apache.org/jira/browse/THRIFT-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305333#comment-16305333 ] RobberPhex commented on THRIFT-4423: Finally, all test passed. [~jking3] Is this pull request OK? > migrate php library to psr-4 > > > Key: THRIFT-4423 > URL: https://issues.apache.org/jira/browse/THRIFT-4423 > Project: Thrift > Issue Type: Improvement > Components: PHP - Library >Affects Versions: 0.11.0 >Reporter: Robert Lu > > The latest autoload standard is [http://www.php-fig.org/psr/psr-4/]. > So, I migrate thrift to PSR-4. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (THRIFT-4438) require php ^5.6 || ^7.0
RobberPhex created THRIFT-4438: -- Summary: require php ^5.6 || ^7.0 Key: THRIFT-4438 URL: https://issues.apache.org/jira/browse/THRIFT-4438 Project: Thrift Issue Type: Improvement Components: PHP - Library Affects Versions: 0.11.0 Reporter: RobberPhex We can remove php5.3~php5.5 support. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] thrift pull request #1445: migrate to psr-4
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1445 migrate to psr-4 You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift psr-4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1445.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1445 commit 82a3323d80f6f1fbdf98fee17675d74ff24df219 Author: Robert Lu <robberp...@gmail.com> Date: 2017-11-03T04:27:31Z migrate to psr-4 commit 1b08f39a19c3ffdf8d3a143ae8b7457eb7459031 Author: Robert Lu <robberp...@gmail.com> Date: 2017-11-11T01:53:28Z add phpunit to require-dev commit d775d602e7067c49057d0a65bbccba4b51f339bf Author: Robert Lu <robberp...@gmail.com> Date: 2017-11-11T01:55:17Z adjust classloader of test commit ef1df4b8e0b4c551cf5997ca83d8b5b5db1220e6 Author: Robert Lu <robberp...@gmail.com> Date: 2017-11-11T02:26:05Z fix path commit 48e5fb54754f023fca4ad712e641b0b2046bb3d7 Author: Robert Lu <robberp...@gmail.com> Date: 2017-11-11T08:52:58Z fix test directory structure commit ff857fe0f8d3ff5bcc89ac00cf06fa69347535ec Author: Robert Lu <robberp...@gmail.com> Date: 2017-11-12T07:18:37Z remove sys info commit c2fff0c1d4c3d2a3e7e687254544ef187bb048ef Author: Robert Lu <robberp...@gmail.com> Date: 2017-11-13T09:40:53Z fix test classloader commit 0ceccf67d2d06b19bb654d2ebfd38f5e424d38b4 Author: Robert Lu <robberp...@gmail.com> Date: 2017-11-13T10:28:42Z add composer commit 8562d4591abb859dfe10e9838d7486d7e55a91eb Author: Robert Lu <robberp...@gmail.com> Date: 2017-12-13T10:28:57Z fix permission commit 6e75076c0cb64e1300aeb77c79d93a7238589abb Author: Robert Lu <robberp...@gmail.com> Date: 2017-12-13T10:29:08Z add autoload-dev commit 4a8423020da3d9c96e549dda885529c4853d724d Author: Robert Lu <robberp...@gmail.com> Date: 2017-12-13T10:55:23Z add composer install ---
[GitHub] thrift issue #1400: THRIFT-4374 add stdc++ back
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1400 There is the [issue](https://issues.apache.org/jira/browse/THRIFT-4374) ---
[GitHub] thrift issue #1401: THRIFT-4373: Derefer PHP zval _TSPEC
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1401 If we want process REFERENCE everywhere. I think we should review every line of `zval` used, is it? ---
[GitHub] thrift pull request #1401: THRIFT-4373: Derefer PHP zval _TSPEC
Github user RobberPhex commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1401#discussion_r147051880
--- Diff: lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp ---
@@ -537,6 +537,9 @@ void binary_deserialize(int8_t thrift_typeID,
PHPInputTransport& transport, zval
}
zval* spec = zend_read_static_property(Z_OBJCE_P(return_value),
"_TSPEC", sizeof("_TSPEC")-1, false);
+ if (spec) {
--- End diff --
After `zend_read_static_property` with `slient=false`, we should detect
exception.
If no exception, we needn't detect spec is null.
but we need detect that `Z_TYPE_P(prop) == IS_REFERENCE`
---
[GitHub] thrift pull request #1401: THRIFT-4373: Derefer PHP zval _TSPEC
Github user RobberPhex commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1401#discussion_r147052024
--- Diff: lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp ---
@@ -699,6 +702,9 @@ void binary_serialize_hashtable_key(int8_t keytype,
PHPOutputTransport& transpor
static
void binary_serialize(int8_t thrift_typeID, PHPOutputTransport& transport,
zval* value, HashTable* fieldspec) {
+ if (value) {
--- End diff --
`Z_TYPE_P(prop) == IS_REFERENCE`
---
[GitHub] thrift pull request #1401: THRIFT-4373: Derefer PHP zval _TSPEC
Github user RobberPhex commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1401#discussion_r147052177
--- Diff: lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp ---
@@ -709,6 +715,9 @@ void binary_serialize(int8_t thrift_typeID,
PHPOutputTransport& transport, zval*
throw_tprotocolexception("Attempt to send non-object type as a
T_STRUCT", INVALID_DATA);
}
zval* spec = zend_read_static_property(Z_OBJCE_P(value), "_TSPEC",
sizeof("_TSPEC")-1, true);
+ if (spec) {
--- End diff --
I think `Z_TYPE_P(prop) == IS_REFERENCE`
---
[GitHub] thrift pull request #1399: THRIFT-4370: build generated code before running ...
Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1399#discussion_r147048687 --- Diff: lib/py/setup.py --- @@ -22,7 +22,7 @@ import sys try: from setuptools import setup, Extension -except: +except Exception: --- End diff -- I think we should use distutils.core, and setuptools is feedback, And we should only process ImportError. ```py try: from distutils.core import setup, Extension except ImportError: from setuptools import setup, Extension ``` ---
[GitHub] thrift pull request #1400: add stdc++ back
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1400 add stdc++ back at Linux x86, will cause errror: # php -d extension=./thrift_protocol.so -m PHP Warning: PHP Startup: Unable to load dynamic library './thrift_protocol.so' - ./thrift_protocol.so: undefined symbol: _ZTVN10__cxxabiv120__si_class_type_infoE in Unknown on line 0 ref [commit](https://issues.apache.org/jira/browse/THRIFT-4356?focusedCommentId=16219118=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16219118) You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift fix-libcpp-dep Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1400.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1400 commit 194b730d565c822dd516f705e51f49d5632e1052 Author: Robert Lu <robberp...@gmail.com> Date: 2017-10-25T18:39:17Z add stdc++ back ---
[GitHub] thrift issue #1391: Fix segment fault at thrift_protocol extension
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1391 @jeking3 Currently, I just remove PHP5 support at PHP extension(thrift_protocol), PHP library is still support PHP5. So, I think this PR is good. --- If PHP5 support for extension is needed, I will add it back. ---
[GitHub] thrift issue #1391: Fix segment fault at thrift_protocol extension
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1391 at job `Autotools (Ubuntu Trusty)`, it just run `make check`, so php extension cannot be compiled. at job `Cross Language Tests`, it needn't php extension. So, I think there already are some CI problems at php part. ---
[GitHub] thrift pull request #1391: Fix segment fault at thrift_protocol extension
Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1391#discussion_r146125400 --- Diff: lib/php/src/ext/thrift_protocol/config.m4 --- @@ -1,25 +1,27 @@ -dnl Copyright (C) 2009 Facebook -dnl Copying and distribution of this file, with or without modification, -dnl are permitted in any medium without royalty provided the copyright -dnl notice and this notice are preserved. +dnl Licensed to the Apache Software Foundation (ASF) under one --- End diff -- OK, I just add APL declaration to `config.m4` ---
[GitHub] thrift issue #1391: Fix segment fault at thrift_protocol extension
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1391 Hi, about license. `Copyright (C) 2009 Facebook` at file `lib/php/src/ext/thrift_protocol/config.m4` was add by commit f82aee5087bd62989482f5c532cbd80f97a39b7f. But before this commit, the license at [`php_thrift_protocol.cpp`](https://github.com/apache/thrift/blob/f82aee5087bd62989482f5c532cbd80f97a39b7f^/lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp), [`php_thrift_protocol.h`](https://github.com/apache/thrift/blob/f82aee5087bd62989482f5c532cbd80f97a39b7f^/lib/php/src/ext/thrift_protocol/php_thrift_protocol.h) was Apache License. ---
[GitHub] thrift issue #1391: Fix segment fault at thrift_protocol extension
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1391 build job 4 failed due to https://issues.apache.org/jira/browse/THRIFT-2913. And, appveyor build queued. but, same commit at my repo CI is success: https://ci.appveyor.com/project/RobberPhex/thrift/build/1.0.0-dev.58 ---
[GitHub] thrift issue #1391: Fix segment fault at thrift_protocol extension
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1391 this pr fix [`THRIFT-4356`](https://issues.apache.org/jira/browse/THRIFT-4356) and [`THRIFT-4353`](https://issues.apache.org/jira/browse/THRIFT-4353). --- And, this work is besed `è£è² <feid...@anjuke.com>`'s work. so I just squashed commits by author(not all-in-one commit). ---
[GitHub] thrift pull request #1385: THRIFT-4356 thrift_protocol call Transport cause ...
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1385 THRIFT-4356 thrift_protocol call Transport cause Segmentation fault ref: <https://issues.apache.org/jira/browse/THRIFT-4356> You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift THRIFT-4356 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1385.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1385 commit 1f6541a61fb692c2376e04b522f256ad8ca640d2 Author: Robert Lu <robberp...@gmail.com> Date: 2017-10-04T16:17:15Z if is_validate is not defined ---
[GitHub] thrift pull request #1022: THRIFT-3845
Github user RobberPhex closed the pull request at: https://github.com/apache/thrift/pull/1022 ---
[GitHub] thrift pull request #1384: THRIFT-4354 TSocket block on read
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1384 THRIFT-4354 TSocket block on read ref <https://issues.apache.org/jira/browse/THRIFT-4354> You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift THRIFT-4354 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1384.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1384 commit 0b8c5d42b78f6a9271b8b30e53351004feddb65a Author: Robert Lu <robberp...@gmail.com> Date: 2017-10-03T20:28:00Z add non-block ---
[GitHub] thrift pull request #1383: THRIFT-4353 cannot read via thrift_protocol at se...
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1383 THRIFT-4353 cannot read via thrift_protocol at server side ref <https://issues.apache.org/jira/browse/THRIFT-4353> You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift THRIFT-4353 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1383.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1383 commit 13a4dd1891347f05101af486e1a5bf8f85bf040c Author: è£è² <feid...@anjuke.com> Date: 2016-11-16T02:32:52Z support php ext read data after message begin commit 843d87f0c7e69165d1489c7f2dd089b68790720d Author: è£è² <feid...@anjuke.com> Date: 2016-11-16T02:50:22Z fix commit 61da80b5ccbe7c63f5187e3296f0453d1abee41d Author: è£è² <feid...@anjuke.com> Date: 2016-11-16T03:53:19Z fix commit 3c956e3446438f8d1a1fadaee198a32b71652e58 Author: Robert Lu <robberp...@gmail.com> Date: 2017-10-03T19:18:38Z compiler use thrift_protocol_read_binary_after_message_begin ---
[GitHub] thrift issue #1161: THRIFT-4034 CMake doesn't work to build compiler
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1161 @jeking3 I think `/CMakeList.txt` is the only entrance, we can just improve document, to fix this issue, is it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1161: THRIFT-4034 CMake doesn't work to build compiler
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1161 @jeking3 fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1161: THRIFT-4034 CMake doesn't work to build compiler
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1161 All ci have passed, finally. Please merge this pr. :) --- change list: * appveyor have installed openssl, removed installation of openssl * remove HACK of `thrifty.hh` rename to `thrifty.h` * **thrift-compiler can build by cmake, `compiler/cpp/README.md` can work.** --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1086: THRIFT-3926 Emit an error for bad http status code
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1086 status code not equal 200 doesn't means it's a `TApplicationException`. * When status code is 301/3xx, should thrift client follow the redirect? * In some server implements, server return Exception with 4xx, Exception contains the message "Access Denied" Httpcode is expression of server status, it can be used for debugging, for logging, not just a part of rpc. If someone want client process this error, return Exception when http code is not right, and client can parse and raise this exception. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1161: THRIFT-4034 CMake doesn't work to build compiler
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1161 https://issues.apache.org/jira/browse/THRIFT-4034 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1161: Thrift-4034 CMake doesn't work to build compiler
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1161 Thrift-4034 CMake doesn't work to build compiler You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift THRIFT-4034 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1161.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1161 commit cdd3a209a082bc05c9891f81d82e09095f0934fb Author: Robert Lu <robberp...@gmail.com> Date: 2017-01-19T03:40:53Z add cmake minimum version commit 3dfae805b8901dc76be72b754767f45182ed3795 Author: Robert Lu <robberp...@gmail.com> Date: 2017-01-19T03:42:15Z remove hack for rename header file commit 3e7df74491bffa76ea5f0cc59135315b76e3367a Author: Robert Lu <robberp...@gmail.com> Date: 2017-01-19T04:23:50Z fix link error and BIN_INSTALL_DIR error commit 0175e59a88b6e6ffa7b6b66d826e8b317030c5dd Author: Robert Lu <robberp...@gmail.com> Date: 2017-01-19T05:05:44Z thrift-compiler dir in cmake-build * because thrift dir in cmake-build, thrift target cannot make * thrifty.h include thrift/parse/t_program.h, solve struct dependency commit 64b242ed6b0570c548868518572ac6baaf42f4a8 Author: Robert Lu <robberp...@gmail.com> Date: 2017-01-19T05:19:58Z improve doc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1089: THRIFT-3929 php namespace remove tail "\\"
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1089 @jfarrell Can you review this pr? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3929) PHP "nsglobal" Option Results in Syntax Error in Generated Code (Trailing Backslash)
[
https://issues.apache.org/jira/browse/THRIFT-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508980#comment-15508980
]
RobberPhex commented on THRIFT-3929:
[~jfarrell] Is there any problem in [pr
1089|https://github.com/apache/thrift/pull/1089] for resolve this issue?
> PHP "nsglobal" Option Results in Syntax Error in Generated Code (Trailing
> Backslash)
>
>
> Key: THRIFT-3929
> URL: https://issues.apache.org/jira/browse/THRIFT-3929
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Compiler
>Affects Versions: 1.0
> Environment: Distributor ID: Ubuntu
> Description:Ubuntu 14.04.4 LTS
> Release:14.04
> Codename: trusty
>Reporter: Ben Meynell
> Labels: easyfix
> Fix For: 1.0
>
>
> thrift --gen php:server,psr4,oop,validate,json,nsglobal="My\Special\Place"
> -out ./src my.thrift
> Results in PHP files with namespaces defined as:
> namespace My\Special\Place\;
> Note the trailing backslash ("\"). This results in unparseable PHP:
> $ php -l src/My/Special/Place/Data.php
> Errors parsing src/My/Special/Place/Data.php
> The fix is to simply omit the trailing backslash from the generated code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] thrift pull request #1089: THRIFT-3929 php namespace remove tail "\\"
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1089 THRIFT-3929 php namespace remove tail "\\" when namespace is empty, and global namespace is not empty, don't add tail "\\" You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift THRIFT-3929 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1089.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1089 commit d2a8c366f0d99ce20c434d7210ca8cdd289ff910 Author: Robert Lu <robberp...@gmail.com> Date: 2016-09-15T02:48:16Z THRIFT-3929 php namespace remove tail "\\" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1022: THRIFT-3845
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1022 @jeking3 rebased --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-3845
GitHub user RobberPhex opened a pull request:
https://github.com/apache/thrift/pull/1022
THRIFT-3845
use `isBinaryAccelerated` to indicate use extension `thrift_protocol`.
When `TBinaryProtocolAccelerated` warped in
`TMultiplexedProtocol`,extension `thrift_protocol` can also be used for `client
serialization`, `client deserialization`, `server serialization`.
notice: `server deserialization` can't use extension `thrift_protocol`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RobberPhex/thrift THRIFT-3845
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1022.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1022
commit 30d3fb6000f84d401884a7799f2a96a08930e917
Author: Robert Lu <robberp...@gmail.com>
Date: 2016-05-31T15:38:18Z
add isStrict{Read,Write} to TProtocolDecorator for
TBinaryProtocolAccelerated
commit 2b9005a49c299ab444a21d61e38b1714f294f5cf
Author: Robert Lu <robberp...@gmail.com>
Date: 2016-05-31T16:39:06Z
add isBinaryAccelerated for thrift_protocol ext
instanceof TBinaryProtocolAccelerated will caused
TBinaryProtocolAccelerated warped in TMultiplexedProtocol can't use
thrift_protocol extension
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fix THRIFT-3844
GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1021 Fix THRIFT-3844 update `php_thrift_protocol7.cpp` let `php_thrift_protocol` can compiled with php7.0.7 You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift THRIFT-3844 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1021.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1021 commit fd909b86adb1841f97b961a3dc19a15c818ee85c Author: visoeclipse <visoecli...@gmail.com> Date: 2016-03-28T08:53:37Z Update php_thrift_protocol7.cpp bug fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
