[GitHub] thrift issue #1491: THRIFT-4489: Add UDS support for nodejs thrift client

2018-03-20 Thread danielhtshih 
Github user danielhtshih commented on the issue:

https://github.com/apache/thrift/pull/1491
  
@jeking3 here is the single commit 
https://github.com/danielhtshih/thrift/commit/9c560daf52fcd89c212451f0793973af17f6cc55
 from THRIFT-4489-squashed

Thanks.


---

[GitHub] thrift issue #1491: THRIFT-4489: Add UDS support for nodejs thrift client

2018-03-20 Thread danielhtshih 
Github user danielhtshih commented on the issue:

https://github.com/apache/thrift/pull/1491
  
@jeking3 please use this single commit 
https://github.com/apache/thrift/pull/1491/commits/041f91dd6042b98c5bbd0846f5e6ed7fb6fd4bf1

Thanks.


---

[GitHub] thrift issue #1491: THRIFT-4489: Add UDS support for nodejs thrift client

2018-03-18 Thread danielhtshih 
Github user danielhtshih commented on the issue:

https://github.com/apache/thrift/pull/1491
  
I believe the unexpected failures from the latest run is not related to my 
changes for nodejs.

Maybe it needs another merge from master branch? 
```

===
Following 14 tests were expected to cleanly succeed but needed retry:

===
server-client:  protocol: transport:   result:
nodejs-nodejs   json  buffered-domain  flaky(1 
retry)
nodejs-cpp  json  buffered-ip-ssl  flaky(3 
retries)
hs-csharp   json  framed-ipflaky(2 
retries)
cpp-cpp multicframed-ip-sslflaky(2 
retries)
cpp-cpp multij-json   http-ip-ssl  flaky(1 
retry)
cpp-cpp multij-json   framed-ip-sslflaky(1 
retry)
cpp-cpp multihhttp-ip-ssl  flaky(1 
retry)
cpp-cpp multih-header http-ip-ssl  flaky(2 
retries)
cpp-cpp multih-header buffered-ip-ssl  flaky(2 
retries)
cpp-cpp multic-compacthttp-ip-ssl  flaky(1 
retry)
cpp-cpp multic-compactbuffered-ip-ssl  flaky(3 
retries)
cpp-cpp multij-json   http-ip-ssl  flaky(1 
retry)
cpp-cpp multij-json   buffered-ip-ssl  flaky(1 
retry)
cpp-cpp multijbuffered-ip-ssl  flaky(2 
retries)

===
*** Following 1 failures were unexpected ***:
If it is introduced by you, please fix it before submitting the code.

===
server-client:  protocol: transport:   result:
cpp-cpp multij-json   buffered-ip-ssl  
failure(64)

===
```


---

[GitHub] thrift pull request #1491: Add UDS support for nodejs thrift client

2018-02-05 Thread danielhtshih 
GitHub user danielhtshih opened a pull request:

https://github.com/apache/thrift/pull/1491

Add UDS support for nodejs thrift client



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danielhtshih/thrift uds-nodejs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1491.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1491


commit 9cb998de7c7c528f444f8ba1d8966f988371cf70
Author: Daniel Shih 
Date:   2018-02-06T04:42:15Z

Add UDS support for nodejs thrift client




---